Re: Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

2015-08-24 Thread FX
On the SPU, mmap is indeed not available. Before that change, it was still possible to build libgfortran for SPU ... Is the intent to now require mmap on every system that supports libgfortran, or should use of mmap in libbacktrace be optional in some form? The idea is that libbacktrace

[nvptx] HImode complex args

2015-08-24 Thread Nathan Sidwell
My patch to walk_args_for_param to fix QImode complex args, didn't deal with HImode ones. Those also had the same problem, but I'd not triaged the testsuite enough to see at that point. This patch reverts the change to nvptx_ptx_type_from_mode, instead moving the call to arg_promotion into

[patch] libstdc++/67309 Make random work with -fsingle-precision-constant

2015-08-24 Thread Jonathan Wakely
With -fsingle-precision-constant std::max(1.0, some_double) can't deduce the template argument, so make it explicit. Tested powerpc64le-linux, committed to trunk. commit 9cdc1c4ff5e46394052808b0cfadd1b3190aae96 Author: Jonathan Wakely jwak...@redhat.com Date: Fri Aug 21 19:38:01 2015 +0100

Re: [PATCH][2/2] Make SCCVN use conditional equivalences

2015-08-24 Thread Rainer Orth
Andreas Schwab sch...@suse.de writes: On ia64 and arm64: FAIL: g++.dg/tree-ssa/pr61034.C -std=gnu++11 scan-tree-dump-times fre2 free 10 $ gcc/xg++ -Bgcc/ ../gcc/testsuite/g++.dg/tree-ssa/pr61034.C -nostdinc++ -Iia64-suse-linux/libstdc++-v3/include/ia64-suse-linux

Re: [PATCH][2/2] Make SCCVN use conditional equivalences

2015-08-24 Thread Andreas Schwab
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Andreas Schwab sch...@suse.de writes: On ia64 and arm64: FAIL: g++.dg/tree-ssa/pr61034.C -std=gnu++11 scan-tree-dump-times fre2 free 10 $ gcc/xg++ -Bgcc/ ../gcc/testsuite/g++.dg/tree-ssa/pr61034.C -nostdinc++

Re: Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

2015-08-24 Thread Ulrich Weigand
FX Coudert wrote: The idea is that libbacktrace should be able to build on all targets, at least in a minimally-functional form: https://gcc.gnu.org/ml/gcc/2015-08/msg00038.html libgfortran should continue to build on all targets, even those that don't have an mmap(). I see that there is

[patch] libstdc++/65049 Fix undefined behaviour in char_traits

2015-08-24 Thread Jonathan Wakely
char_traits must not pass null pointers to memove, memcmp etc. Tested powerpc64le-linux, committed to trunk. This should probably go on the 5 and 4.9 branches too. commit 8952ba59d56937dee483cbef8cdf1de5c4d816c2 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Aug 24 11:00:01 2015 +0100

[test] Avoid gratuitous io features

2015-08-24 Thread Nathan Sidwell
While nvptx doesn't have general io, it does manage to have 'printf'. The matrix and transpose tests were gratuitously failing because they had fprintf(stderr,...); fflush (...); The fflush is unneeded because it's followed by 'exit (0)', which flushes things, and the stderr is also

Re: [gomp4.1] Initial support for some OpenMP 4.1 construct parsing

2015-08-24 Thread Jakub Jelinek
On Mon, Jul 20, 2015 at 09:53:42PM +0300, Ilya Verbin wrote: On Fri, Jul 17, 2015 at 18:43:06 +0200, Jakub Jelinek wrote: On Fri, Jul 17, 2015 at 07:31:36PM +0300, Ilya Verbin wrote: One big question is who will maintain the list of scheduled job, its dependencies, etc. - libgomp or each

Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

2015-08-24 Thread Ulrich Weigand
FX Coudert wrote: PR libfortran/54572 * Makefile.def: Make libgfortran depend on libbacktrace. * Makefile.in: Regenerate. This causes GCC build to fail on SPU with the error: /home/uweigand/dailybuild/spu-tc-2015-08-23/gcc-head/src/libbacktrace/mmapio.c: In function

[C++ Patch] PR 53184 (Unnecessary anonymous namespace warnings)

2015-08-24 Thread Paolo Carlini
Hi, today I spent more time on this issue (which is getting duplicates). In fact it boils down to two separate issues: 1- Give a name to the warning, to make possible disabling it. 2- Don't talk about anonymous namespace when no anonymous namespace is involved. Issue 1- should be rather

[test] remove another io need

2015-08-24 Thread Nathan Sidwell
This is another case of a test failing for PTX because it wanted to use IO. We don't need to call fflush and abort, we could just return 'exit (1)'. This changes the relevant macro to do just that. As with the matrix patch, other targets should be unaffected. Any objections? nathan

[nvptx] More test disabling

2015-08-24 Thread Nathan Sidwell
This disables some more gcc tests for nvptx target. I'm now down to test fails that need further investigation. nathan 2015-08-24 Nathan Sidwell nat...@acm.org * gcc/testsuite/gcc.dg/pr49551.c: Needs -fdata-sections. * gcc/testsuite/gcc.dg/pr64935-2.c: Needs scheduling. *

Use target-insns.def for calls

2015-08-24 Thread Richard Sandiford
This is the most complicated part of the conversion, since it is the only instance in which named patterns take optional operands. That still seems like a reasonable feature to have, so I extended the target-insns.def code to support it rather than update ports to accept all operands. With that

Re: Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

2015-08-24 Thread FX
I guess we can always just hard-code that SPU does not have mmap, similar to how Solaris is hard-coded to not have dl_iterate_phdr. Would something like the below be OK (if it passes testing)? Looks good to me, though I cannot approve it. FX

Re: [PATCH][gomp4] Optimize expand_omp_for_static_chunk for chunk_size one

2015-08-24 Thread Tom de Vries
On 24-08-15 16:28, Tom de Vries wrote: On 24-08-15 11:43, Jakub Jelinek wrote: On Mon, Jul 28, 2014 at 11:21:53AM +0200, Tom de Vries wrote: Jakub, we're using expand_omp_for_static_chunk with a chunk_size of one to expand the openacc loop construct. This results in an inner and outer loop

Re: [PATCH] Adjust variable shift costs for IA MCU

2015-08-24 Thread H.J. Lu
On Thu, Jul 09, 2015 at 11:05:27AM -0700, H.J. Lu wrote: We reduce code size for IA MCU by adjusting variable shift costs for IA MCU. OK for trunk? Thanks. H.J. --- PR target/66821 * config/i386/i386.c (iamcu_cost): Adjust variable shift costs. I checked in this patch to

[libgfortran,patch] Use type-generic built-ins in float I/O routines

2015-08-24 Thread FX
This patch makes us use type-generic built-ins for isfinite(), isnan(), and signbit(), through their “safe” definitions in libgfortran.h, rather than manually handle the suffixed variants (isfinitef/isfinite/isfinitel/finiteq, and the like). This reverses the patch that originally introduced

[committed, PATCH] PR target/67329: gcc.dg/tree-ssa/ssa-dom-cse-2.c fails on -march=pentium or -march=iamcu

2015-08-24 Thread H.J. Lu
This patch updates MOVE_RATIO cost for IA MCU from 6 to 9 so that we can unroll the loop completely for DOM with -mtune=iamcu. gcc/ PR target/67329 * config/i386/i386.c (iamcu_cost): Set MOVE_RATIO cost to 9. gcc/testsuite/ PR target/67329 *

[gomp4] firstprivate bug in combined acc loops

2015-08-24 Thread Cesar Philippidis
This patch addresses a bug where a firstprivate clause in a combined parallel/kernels loop is propagated to an acc loop. I came across this bug when I was testing the new reduction changes. There's a test case for this in my reduction patch set, so I didn't include one here. This patch has been

[PING][PATCH] Fix warnings from including fdl.texi into gnat-style.texi

2015-08-24 Thread Tom de Vries
On 14-06-15 16:07, Tom de Vries wrote: On 23/03/15 16:00, Gerald Pfeifer wrote: On Fri, 20 Mar 2015, Tom de Vries wrote: The gnat-style.texi part is OK. I cannot approve the fdl part though. Gerald, Can you approve the fdl part? Let's assume I can. Okay. Can you just describe the _why_ a

Re: Go PATCH to fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Ian Lance Taylor
On Mon, Aug 24, 2015 at 4:34 AM, Marek Polacek pola...@redhat.com wrote: This is hopefully the last attempt to fix the libgo breakage. This time around I really think I got to the bottom of the problem. The issue is that the Go FE defines the __builtin_trap call, but doesn't set the

Re: [PATCH 7/13] powerpc musl support

2015-08-24 Thread David Edelsohn
Patch v2. Powerpc does not include the top level linux.h, so I had to repeat the include order fixes from there in rs6000/sysv4.h. I corrected the endianness handling (the le suffix should be added correctly now). gcc/Changelog: 2015-04-24 Gregor Richards gregor.richa...@uwaterloo.ca

Re: [PATCH][gomp4] Optimize expand_omp_for_static_chunk for chunk_size one

2015-08-24 Thread Tom de Vries
On 24-08-15 11:43, Jakub Jelinek wrote: On Mon, Jul 28, 2014 at 11:21:53AM +0200, Tom de Vries wrote: Jakub, we're using expand_omp_for_static_chunk with a chunk_size of one to expand the openacc loop construct. This results in an inner and outer loop being generated, with the inner loop

Re: Add irreflexive comparison debug check

2015-08-24 Thread Jonathan Wakely
On 21/08/15 21:30 +0200, François Dumont wrote: Ok, it looks like you really want to provide this check in pre-C++11 mode so here it is. Tested under Linux x86_64. Ok to commit ? This looks great, thanks for doing the extra work to avoid the SFINAE checks when the types are the same. Very

liboffloadintelmic patch

2015-08-24 Thread Nathan Sidwell
I've committed this patch of Thomas's (as he's away), to give the offload build visibility of gomp-constants. That'll be needed for the offload versioning patch, which I'm just retesting before committing. nathan 2015-08-24 Thomas Schwinge tho...@codesourcery.com * plugin/Makefile.am

[PING^2][PATCH, PR46193] Handle mix/max pointer reductions in parloops

2015-08-24 Thread Tom de Vries
On 22-07-15 20:15, Tom de Vries wrote: On 13/07/15 13:02, Tom de Vries wrote: Hi, this patch fixes PR46193. It handles min and max reductions of pointer type in parloops. Bootstrapped and reg-tested on x86_64. OK for trunk? Ping^2. Original submission at

Re: [PING][PATCH] Fix warnings from including fdl.texi into gnat-style.texi

2015-08-24 Thread Arnaud Charlet
The Ada part is ok. Arno On 24 Aug 2015, at 11:16, Tom de Vries tom_devr...@mentor.com wrote: On 14-06-15 16:07, Tom de Vries wrote: On 23/03/15 16:00, Gerald Pfeifer wrote: On Fri, 20 Mar 2015, Tom de Vries wrote: The gnat-style.texi part is OK. I cannot approve the fdl part though.

Re: Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

2015-08-24 Thread FX
PIC_FLAG= if test -n ${with_target_subdir}; then - PIC_FLAG=-fPIC + AC_TRY_COMPILE([void foo(void){}], [PIC_FLAG=-fPIC]) fi There’s something I don’t understand about this test. Shouldn’t AC_TRY_COMPILE take a first (empty) argument, “includes”? And shouldn’t you first set the -fPIC flag

Re: Patch for fortran/62536 and fortran/66175

2015-08-24 Thread FX
This patch cleans up nested blocks when there's an unexpected end of a compilation unit (66175), and it handles cleaned-up blocks gracefully (62536). I've run make check-fortran with the attached test cases. I have now committed the patch to trunk as revision 227135. Thanks for your

Re: [PATCH 7/13] powerpc musl support

2015-08-24 Thread Rich Felker
On Mon, Aug 24, 2015 at 06:25:14PM +0200, Szabolcs Nagy wrote: * David Edelsohn dje@gmail.com [2015-08-24 10:21:05 -0400]: Patch v2. Powerpc does not include the top level linux.h, so I had to repeat the include order fixes from there in rs6000/sysv4.h. I corrected the

Re: [PATCH 7/13] powerpc musl support

2015-08-24 Thread Szabolcs Nagy
* David Edelsohn dje@gmail.com [2015-08-24 10:21:05 -0400]: Patch v2. Powerpc does not include the top level linux.h, so I had to repeat the include order fixes from there in rs6000/sysv4.h. I corrected the endianness handling (the le suffix should be added correctly now).

Re: [PATCH, libjava/classpath]: Fix overriding recipe for target 'gjdoc' build warning

2015-08-24 Thread Jeff Law
On 08/20/2015 04:32 PM, Andrew Hughes wrote: OK, so how about deprecating Java for GCC 6 by removing it from the default languages and removing it for GCC 7 or before we switch to git (whatever happens earlier?) Yeah, that's what I suggested at the end of [0] so +1 from me. Works for me and

Re: [PATCH] Fix middle-end/67133, part 1

2015-08-24 Thread Jeff Law
On 08/23/2015 04:40 AM, Jan-Benedict Glaw wrote: On Thu, 2015-08-20 11:02:17 +0200, Andreas Schwab sch...@suse.de wrote: Marek Polacek pola...@redhat.com writes: PR middle-end/67133 * gimple-ssa-isolate-paths.c (insert_trap_and_remove_trailing_statements): Rename to

Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

2015-08-24 Thread Hans-Peter Nilsson
There exists targets that support fortran but error on -fPIC, for example cris-elf, which broke with the libbacktrace thingy. (Emitting an error for -fPIC is a conscious choice; a compilation error is better than e.g. to silently ignoring it.) This fix causes build to pass the point of error for

Re: Go PATCH to fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Marek Polacek
On Mon, Aug 24, 2015 at 08:18:41AM -0700, Ian Lance Taylor wrote: On Mon, Aug 24, 2015 at 4:34 AM, Marek Polacek pola...@redhat.com wrote: This is hopefully the last attempt to fix the libgo breakage. This time around I really think I got to the bottom of the problem. The issue is that

Re: [PATCH] Fix middle-end/67133, part 1

2015-08-24 Thread Marek Polacek
On Mon, Aug 24, 2015 at 09:54:31AM -0600, Jeff Law wrote: Not quite. As it seems, it breaks any build: configure --prefix=... --disable-multilib --enable-languages=all,ada,go make Seems the Go code triggers this ICE, so you just need to enable Go. Right. Marek is working on the

Re: [libgfortran,patch] Use type-generic built-ins in float I/O routines

2015-08-24 Thread Steve Kargl
On Mon, Aug 24, 2015 at 05:36:06PM +0200, FX wrote: This patch makes us use type-generic built-ins for isfinite(), isnan(), and signbit(), through their ???safe??? definitions in libgfortran.h, rather than manually handle the suffixed variants (isfinitef/isfinite/isfinitel/finiteq, and the

Re: Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

2015-08-24 Thread Hans-Peter Nilsson
From: FX fxcoud...@gmail.com Date: Mon, 24 Aug 2015 18:07:52 +0200 PIC_FLAG= if test -n ${with_target_subdir}; then - PIC_FLAG=-fPIC + AC_TRY_COMPILE([void foo(void){}], [PIC_FLAG=-fPIC]) fi There's something I don't understand about this test. Shouldn't AC_TRY_COMPILE take a

Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

2015-08-24 Thread Hans-Peter Nilsson
(Goofed on the CC line, sorry for the dup.) There exists targets that support fortran but error on -fPIC, for example cris-elf, which broke with the libbacktrace thingy. (Emitting an error for -fPIC is a conscious choice; a compilation error is better than e.g. to silently ignoring it.) This fix

Re: Use cmpmem optabs in builtins.c

2015-08-24 Thread Jeff Law
On 08/24/2015 05:18 AM, Richard Sandiford wrote: Similarly to the patch for cmpstr(n), this patch uses the optabs interface for cmpmem instead of using HAVE_cmpmmsi and CODE_FOR_cmpmemsi directly. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * builtins.c

Re: [patch,doc] Remove dead/inactive links for GCC binaries

2015-08-24 Thread Jeff Law
On 08/22/2015 01:01 AM, FX wrote: Attached patch cleans up the list of links we provide for GCC binaries: - pware.hvcc.edu is dead, no mirror or newer alternative found - h8300-hms.sourceforge.net is inactive since 2003, carries only gcc 3.2 and 3.3 - sunsite.informatik.rwth-aachen.de only has

Re: Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time)

2015-08-24 Thread Joseph Myers
On Fri, 21 Aug 2015, Joseph Myers wrote: On Fri, 21 Aug 2015, Nathan Sidwell wrote: this appears to cause an ICE in add_omp_infile_spec_func at; gcc_assert (offload_targets != NULL); when you use something like -foffload='-save-temps -v -fdump-rtl-all -fdump-tree-all

Re: Fix reference to freed data in df-scan.c

2015-08-24 Thread Jeff Law
On 08/24/2015 05:23 AM, Richard Sandiford wrote: While experimenting with some allocation changes I noticed that df_insn_rescan frees a df_insn_info and implicitly requires alloc-pool to give back the same data on reallocation: bool the_same = df_insn_refs_verify (collection_rec, bb,

Re: [PING] Use cmpstr and cmpstrn optabs

2015-08-24 Thread Jeff Law
On 08/24/2015 05:17 AM, Richard Sandiford wrote: Originally posted here: https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02660.html Kaz approved the SH parts and reported that there were no new failures on sh4-unknown-linux-gnu (thanks). Sorry, this must have slipped through the cracks.

Re: Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

2015-08-24 Thread Jeff Law
On 08/24/2015 06:55 AM, Ulrich Weigand wrote: FX Coudert wrote: The idea is that libbacktrace should be able to build on all targets, at least in a minimally-functional form: https://gcc.gnu.org/ml/gcc/2015-08/msg00038.html libgfortran should continue to build on all targets, even those that

Re: Use target-insns.def for calls

2015-08-24 Thread Jeff Law
On 08/24/2015 06:54 AM, Richard Sandiford wrote: calls.c had support for sibcall_pop and sibcall_value_pop, but no port defines those patterns and the code looks inconsistent with the corresponding call_pop vs. call code. I've therefore dropped it rather than add untested entries to the .def

Re: Use cbranch optabs in ifcvt.c

2015-08-24 Thread Jeff Law
On 08/24/2015 05:20 AM, Richard Sandiford wrote: Similarly to the patch for cmpstr(n), this patch uses the optabs interface for cbranchcc4 instead of using HAVE_cbranchcc4 directly. I've cached the result in a pass-local variable (valid only for the duration of the pass). The references to

libgomp version patch

2015-08-24 Thread Nathan Sidwell
Here's the updated libgomp version patch I just committed to trunk. nathan 2015-08-24 Nathan Sidwell nat...@codesourcery.com libgomp/ * libgomp.map: Add 4.0.2 version. * target.c (offload_image_descr): Add version field. (gomp_load_image_to_device): Add version argument. Adjust plugin

Re: [PATCH, PR 66521,part 2] Fix warnings on darwin when bootstrapping with vtable verification enabled

2015-08-24 Thread Eric Gallager
On 8/11/15, Caroline Tice cmt...@google.com wrote: When bootstrapping on darwin with vtable verificaiton enabled, libstdc++ is giving a lot of warnings due to a flag in VTV_CXXLINKFLAGS that has a slightly different format for darwin than for linux. This patch (actually contributed by Eric

Re: Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

2015-08-24 Thread FX
You're absolutely right on both accounts. Also, the function body is supposed to be a function body (...) or else we get a nested function (i.e. foo inside main). Might as well provide both empty. Also fixing the ChangeLog entry. Sorry for goofing. (At least I had a look at config.log

[libgfortran,patch] Remove never-used debugging code

2015-08-24 Thread FX
Continuing the summer clean-ups. There is in the init() function some dead debugging code, which as far as I know is never used: it’s compiled conditionaly on DEBUG being defined, and but we don’t have anything that can define DEBUG. The commented-out “resume” functionality was never

Re: Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

2015-08-24 Thread Ulrich Weigand
Jeff Law wrote: On 08/24/2015 06:55 AM, Ulrich Weigand wrote: I guess we can always just hard-code that SPU does not have mmap, similar to how Solaris is hard-coded to not have dl_iterate_phdr. Would something like the below be OK (if it passes testing)? Yes. I've checked this in now.

Re: [gomp4.1] Initial support for some OpenMP 4.1 construct parsing

2015-08-24 Thread Ilya Verbin
On Mon, Aug 24, 2015 at 14:26:57 +0200, Jakub Jelinek wrote: On Mon, Jul 20, 2015 at 09:53:42PM +0300, Ilya Verbin wrote: Latest liboffloadmic (I'm preparing an update for trunk) can take some pointer *ptr* as argument of __offload_offload, which is used for execution and data transfer.

Re: [patch,doc] Remove dead/inactive links for GCC binaries

2015-08-24 Thread Sandra Loosemore
On 08/24/2015 11:31 AM, Jeff Law wrote: On 08/22/2015 01:01 AM, FX wrote: Attached patch cleans up the list of links we provide for GCC binaries: - pware.hvcc.edu is dead, no mirror or newer alternative found - h8300-hms.sourceforge.net is inactive since 2003, carries only gcc 3.2 and 3.3 -

Re: [ARM] Use vector wide add for mixed-mode adds

2015-08-24 Thread Ramana Radhakrishnan
On 22/08/15 22:38, Michael Collison wrote: This is a modified version of the previous patch that addresses issue raised by Ramana. The patch now uses vect_select instead of unspec. I had to fix an unrelated issue to the read_name function in read-md.c. The fix corrects broken support for

Re: C++ delayed folding branch review

2015-08-24 Thread Kai Tietz
Hello Jason, after a longer delay the answer to your question. 2015-08-03 17:39 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/03/2015 05:42 AM, Kai Tietz wrote: 2015-08-03 5:49 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/31/2015 05:54 PM, Kai Tietz wrote: The STRIP_NOPS-requirement

Re: [PATCH] config: fix AM_ICONV for in-tree libiconv

2015-08-24 Thread Pedro Alves
On 08/23/2015 08:36 PM, Yaakov Selkowitz wrote: On Sat, 2015-08-22 at 18:04 +0100, Pedro Alves wrote: I noticed that regenerating binutils/configure or gdb/configure undoes the libiconv changes done here: [snip] However, that commit does not include any config/iconv.m4/AM_ICONV change.

Re: Fix reload1.c warning for some targets

2015-08-24 Thread Rainer Orth
Richard Sandiford rdsandif...@googlemail.com writes: Jeff Law l...@redhat.com writes: On 08/05/2015 08:18 AM, Richard Sandiford wrote: Building some targets results in a warning about orig_dup[i] potentially being used uninitialised. I think the warning is fair, since it isn't obvious that

RE: Fix PR libgomp/66761 and PR libgomp/67303 (tsan warnings)

2015-08-24 Thread VandeVondele Joost
Thanks, committed to trunk r227119 with the format fix. Do you want this on the 5 branch as well ? Joost

Re: [PATCH][gomp4] Optimize expand_omp_for_static_chunk for chunk_size one

2015-08-24 Thread Jakub Jelinek
On Mon, Jul 28, 2014 at 11:21:53AM +0200, Tom de Vries wrote: Jakub, we're using expand_omp_for_static_chunk with a chunk_size of one to expand the openacc loop construct. This results in an inner and outer loop being generated, with the inner loop having a trip count of one, which means

Re: Fix PR libgomp/66761 and PR libgomp/67303 (tsan warnings)

2015-08-24 Thread Jakub Jelinek
On Sat, Aug 22, 2015 at 10:36:45AM +, VandeVondele Joost wrote: OK for trunk ? This applies without changes to the 5 branch, should I commit there as well ? Ok, with a small change: 2015-08-22 Joost VandeVondele vond...@gnu.gcc.org PR libgomp/66761 PR libgomp/67303

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Jakub Jelinek
On Fri, Aug 21, 2015 at 07:22:24PM +0200, Richard Biener wrote: On August 21, 2015 6:42:15 PM GMT+02:00, Marek Polacek pola...@redhat.com wrote: On Fri, Aug 21, 2015 at 06:23:09PM +0200, Richard Biener wrote: Yes, but gimple_call_noreturn_p is false on __builtin_trap. That's quite

Re: [PATCH 11/15][AArch64] vreinterpret(q?), vget_(low|high), vld1(q?)_dup

2015-08-24 Thread Alan Lawrence
James Greenhalgh wrote: Did you check that these actually emit the expected instruction? Applying your patch set I see some fairly unpleasant code generation, but I might have made an error, or perhaps you have another patch in waiting? Thanks, James Yes, you are right, some of the code

Re: offload data version number

2015-08-24 Thread Jakub Jelinek
On Thu, Aug 06, 2015 at 09:52:43PM +0200, Nathan Sidwell wrote: Ping? 1) updated version patch https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00010.html 2) https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00204.html An infrastructure piece from Thomas, who noticed liboffloadmic didn't have

Re: Fwd: [PATCH 3/4] Add libgomp plugin for Intel MIC

2015-08-24 Thread Jakub Jelinek
On Thu, Aug 06, 2015 at 05:34:56PM +0300, Maxim Blumental wrote: Applied the idea with python script alternative. Review, please. 2015-07-28 Maxim Blumenthal maxim.blument...@intel.com * configure.ac: Add a check for xxd or python presence when the target is intelmic or

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Marek Polacek
On Mon, Aug 24, 2015 at 11:07:41AM +0200, Jakub Jelinek wrote: On Fri, Aug 21, 2015 at 07:22:24PM +0200, Richard Biener wrote: Not sure either. Needs to be investigated. BTW, built-in trap is also nothrow AFAIR. I think the bug is in the Go FE which incorrectly doesn't set

Solaris 12 patches

2015-08-24 Thread Rainer Orth
Over the next couple of weeks, I'll be submitting a couple of patches to support Solaris 12. Some of them will fix bootstrap failures, others support features new in that release. Most of the patches are strictly Solaris specific, with only a few needing approval. I'd like to commit them to

[committed] Fix microblaze build with rtl checking enabled

2015-08-24 Thread Richard Sandiford
This typo didn't matter for normal builds because INTVAL provides the missing brackets. It didn't build with rtl checking enabled because the __extension__ got in the way. Tested on microblaze-elf and committed as obvious. Thanks, Richard gcc/ * config/microblaze/microblaze.c

[committed] Use target-insns.def for movstr

2015-08-24 Thread Richard Sandiford
A simple conversion. Tested on x86_64-linux-gnu. Also tested by building one target per cpu directory and checking that there were no changes in the assembly output for gcc.dg, g++.dg and gcc.c-torture. Committed as preapproved. Thanks, Richard gcc/ * target-insns.def (movstr): New

[PING] Use cmpstr and cmpstrn optabs

2015-08-24 Thread Richard Sandiford
Originally posted here: https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02660.html Kaz approved the SH parts and reported that there were no new failures on sh4-unknown-linux-gnu (thanks). Richard Sandiford richard.sandif...@arm.com writes: expand_builtin_strcmp has: if

Use cmpmem optabs in builtins.c

2015-08-24 Thread Richard Sandiford
Similarly to the patch for cmpstr(n), this patch uses the optabs interface for cmpmem instead of using HAVE_cmpmmsi and CODE_FOR_cmpmemsi directly. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * builtins.c (expand_cmpstrn): Rename to...

Use cbranch optabs in ifcvt.c

2015-08-24 Thread Richard Sandiford
Similarly to the patch for cmpstr(n), this patch uses the optabs interface for cbranchcc4 instead of using HAVE_cbranchcc4 directly. I've cached the result in a pass-local variable (valid only for the duration of the pass). The references to incscc and decscc are dead. The only reference to them

Fix reference to freed data in df-scan.c

2015-08-24 Thread Richard Sandiford
While experimenting with some allocation changes I noticed that df_insn_rescan frees a df_insn_info and implicitly requires alloc-pool to give back the same data on reallocation: bool the_same = df_insn_refs_verify (collection_rec, bb, insn, false); /* If there's no change, return

Go PATCH to fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Marek Polacek
This is hopefully the last attempt to fix the libgo breakage. This time around I really think I got to the bottom of the problem. The issue is that the Go FE defines the __builtin_trap call, but doesn't set the TREE_THIS_VOLATILE flag on it. That's bad because then this call isn't

Re: Fix PR libgomp/66761 and PR libgomp/67303 (tsan warnings)

2015-08-24 Thread Jakub Jelinek
On Mon, Aug 24, 2015 at 11:04:54AM +, VandeVondele Joost wrote: Thanks, committed to trunk r227119 with the format fix. Do you want this on the 5 branch as well ? It is ok for 5 branch too. Jakub

[PATCH] Fix c++/67337 (segfault in mangle.c)

2015-08-24 Thread Markus Trippelsdorf
decl_mangling_context() in mangle.c returns a NULL_TREE in case of template type parameters. write_template_prefix() needs to handle this situation. Tested on ppc64le. This is a regression from gcc=4.8. OK for trunk, gcc-5 and gcc-4.9? Thanks. PR c++/67337 * mangle.c

Re: [PATCH] add self-tuning to x86 hardware fast path in libitm

2015-08-24 Thread Nuno Diegues
Hello everyone, after a summer internship and some backlog catching up in the past weeks, I have finally got around to review the patch according to the latest discussion. The changes have not caused regression, and the latest speedup results are coherent with what we had before. In the

Re: Go PATCH to fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Ian Lance Taylor
On Mon, Aug 24, 2015 at 9:04 AM, Marek Polacek pola...@redhat.com wrote: On Mon, Aug 24, 2015 at 08:18:41AM -0700, Ian Lance Taylor wrote: On Mon, Aug 24, 2015 at 4:34 AM, Marek Polacek pola...@redhat.com wrote: This is hopefully the last attempt to fix the libgo breakage. This time

Re: [patch,doc] Remove dead/inactive links for GCC binaries

2015-08-24 Thread FX
Heh, I was about to suggest just deleting the whole section, too. I think nowadays most people get native GCC from their OS distro and cross toolchains for embedded targets from their hardware vendor or consortium (e.g., Linaro). And, well, there's Google if you need help finding a GCC

RE: [PATCH] MIPS: Add the lo register to the clobber list in the madd-8.c and msub-8.c testcases

2015-08-24 Thread Moore, Catherine
HI Andrew, -Original Message- From: Andrew Bennett [mailto:andrew.benn...@imgtec.com] Sent: Tuesday, July 21, 2015 10:56 AM To: gcc-patches@gcc.gnu.org Cc: Matthew Fortune; Moore, Catherine Subject: [PATCH] MIPS: Add the lo register to the clobber list in the madd-8.c and msub-8.c

Re: Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time)

2015-08-24 Thread Joseph Myers
On Mon, 24 Aug 2015, Joseph Myers wrote: I'm testing this patch to default the offload targets after the original command line is processed (and before extra options from these specs are processed, so before the assertion is executed), and will commit it if tests are OK. Now committed to

[gomp4] bug fix for num_gangs inside fortran subroutines

2015-08-24 Thread Cesar Philippidis
This patch adds support for num_gangs, num_workers and vector_length inside nested functions. This fixes an ICE that I hit inside a nested fortran subroutine that was using a num_gangs clause on an acc parallel construct. I applied this patch to gomp-4_0-branch. Cesar

[patch commit SH] Fix PR target/66609

2015-08-24 Thread Kaz Kojima
I've commit the attached patch to fix PR target/66609. SH doesn't take into account weak symbol references for the pc relative calls and sibcalls. See PR target/66609 for details. The patch introduces a new unspec enum UNSPEC_PCREL so to generate pc relative symbols like foo@PCREL and use them

Re: Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time)

2015-08-24 Thread Nathan Sidwell
On 08/24/15 18:22, Joseph Myers wrote: On Mon, 24 Aug 2015, Joseph Myers wrote: I'm testing this patch to default the offload targets after the original command line is processed (and before extra options from these specs are processed, so before the assertion is executed), and will commit it

Re: Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

2015-08-24 Thread Ian Lance Taylor
Hans-Peter Nilsson hans-peter.nils...@axis.com writes: * configure.ac: Only compile with -fPIC if the target supports it. * configure: Regenerate. This is OK. Thanks. Ian

Go patch committed: Type check parameters in sink function declaration

2015-08-24 Thread Ian Lance Taylor
This patch by Chris Manghane fixes the Go frontend to type check function parameters in a sink function declaration, as in func _(int). This fixes https://golang.org/issue/11535 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index:

Move remaining flag_unsafe_math_optimizations using simplify and match

2015-08-24 Thread Hurugalawadi, Naveen
Hi, Please find attached the remaining part of patch. Tested the patch on AArch64 and X86 without any regressions. Please review the patch and let me know if any modifications are required. Thanks, Naveen ChangeLog 2015-08-25 Naveen H.S naveen.hurugalaw...@caviumnetworks.com *