Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-09 Thread H.J. Lu
On Fri, Oct 9, 2015 at 3:42 PM, Steve Ellcey wrote: > On Fri, 2015-10-09 at 15:36 -0700, H.J. Lu wrote: > >> >> I am not sure what you were asking. I tried: >> >> make check-g++ RUNTESTFLAGS="--target_board='unix{-m32\ >> -mstackrealign}' old-deja.exp=spec*.C" >> ... >> >> === g++ Summary === >>

Test for __cxa_thread_atexit_impl when cross-compiling libstdc++ for GNU targets

2015-10-09 Thread Joseph Myers
I noticed that when testing glibc with a cross compiler I got UNSUPPORTED: nptl/tst-thread_local1 because the libstdc++-v3 configuration for cross compiling defaulted to __cxa_thread_atexit_impl not being available. This patch fixes GLIBCXX_CROSSCONFIG to run the same test (for the case covering

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-09 Thread Steve Ellcey
On Fri, 2015-10-09 at 15:36 -0700, H.J. Lu wrote: > > I am not sure what you were asking. I tried: > > make check-g++ RUNTESTFLAGS="--target_board='unix{-m32\ > -mstackrealign}' old-deja.exp=spec*.C" > ... > > === g++ Summary === > > # of expected passes 495 > # of expected failures 3 > > ma

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-09 Thread H.J. Lu
On Fri, Oct 9, 2015 at 3:22 PM, Steve Ellcey wrote: > On Tue, 2015-10-06 at 11:10 -0700, H.J. Lu wrote: > >> Does it pass all tests under g++.dg/torture/stackalign? You need >> to implement -mstackrealign and -mpreferred-stack-boundary= >> as well as update check_effective_target_automatic_stack_

Re: RFC: Patch to allow spill slot alignment greater than the stack alignment

2015-10-09 Thread Steve Ellcey
On Tue, 2015-10-06 at 11:10 -0700, H.J. Lu wrote: > Does it pass all tests under g++.dg/torture/stackalign? You need > to implement -mstackrealign and -mpreferred-stack-boundary= > as well as update check_effective_target_automatic_stack_alignment > to run all stack alignment tests. FYI: I was a

Re: [RFA 0/9] Address space support for x86

2015-10-09 Thread Richard Henderson
On 10/08/2015 09:06 PM, Richard Biener wrote: On Thu, Oct 8, 2015 at 6:59 AM, Richard Henderson wrote: I started with Armin Rigo's patch, from back in July, https://gcc.gnu.org/ml/gcc/2015-07/msg00125.html but then wound up changing all of it. To wit: (1) If we use more sensible defaults

Re: [PATCH 8/9] Add TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID

2015-10-09 Thread Richard Henderson
On 10/08/2015 09:20 PM, Richard Biener wrote: On Thu, Oct 8, 2015 at 6:59 AM, Richard Henderson wrote: * target.def (TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID): New. * targhooks.h (default_addr_space_zero_address_valid): Declare. * targhooks.c (default_addr_space_zero_addr

Re: [PATCH] AIX EH data format

2015-10-09 Thread Richard Henderson
On 10/08/2015 05:35 AM, David Edelsohn wrote: The recent patches to move GCC exception handling tables on AIX to read-only data changed the EH data format from absolute pointers to data-relative or pc-relative, but the offset was encoded as 32 bit, which isn't robust in 64-bit mode. This patch a

Re: [PATCH] New attribute to create target clones

2015-10-09 Thread Evgeny Stupachenko
On Fri, Oct 9, 2015 at 11:04 PM, Jan Hubicka wrote: >> On Fri, Oct 9, 2015 at 9:27 PM, Jan Hubicka wrote: >> >> >Of course it also depends what you inline into function. You can have >> >> > >> >> >bar() target(-mavx) {fancy avx code} >> >> >foobar() { .. if (avx) bar();} >> >> >foo() ctarget

scheduling conditional branches after stores

2015-10-09 Thread Mike Stump
So, I keep on seeing inaccurate schedule time on the conditional branches after a store, and tracked it down to this type of solution. On my machine, I can run these two in the same cycle, but with a REG_DEP_OUTPUT dependency it was moving the branch to the next cycle. Now, I’ll plead ignoranc

[PATCH 1/2] clean up debug functions

2015-10-09 Thread Sebastian Pop
2015-10-07 Aditya Kumar Sebastian Pop * graphite-poly.c (print_iteration_domain): Remove verbosity. Remove OpenScop formatting. (print_iteration_domains): Same. (debug_iteration_domain): Same. (debug_iteration_domains): Same. (pr

[PATCH 2/2] add dump of data dependences

2015-10-09 Thread Sebastian Pop
2015-10-07 Aditya Kumar Sebastian Pop * graphite-dependences.c (scop_get_dependences): Add dump of the data dependence graph. * graphite-poly.c (print_isl_union_map): New. (debug_isl_union_map): New.

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-10-09 Thread Jeff Law
On 09/30/2015 12:46 PM, Jakub Jelinek wrote: On Wed, Sep 30, 2015 at 11:44:38AM -0600, Jeff Law wrote: +/* Move all SSA_NAMEs from FREE_SSA_NAMES_QUEUE to FREE_SSA_NAMES. + + We do not, but should have a mode to verify the state of the SSA_NAMEs + lists. In particular at this point every na

Re: [PR64164] drop copyrename, integrate into expand

2015-10-09 Thread Jeff Law
On 10/07/2015 04:36 PM, Alexandre Oliva wrote: On Sep 29, 2015, Szabolcs Nagy wrote: this commit commit 33cc9081157a8c90460e4c0bdda2ac461a3822cc Author: aoliva Date: 2015-09-27 09:02:00 + revert to assign_parms assignments using default defs ... introduced a test fail

[PATCH] Fix parloops gimple_uid usage

2015-10-09 Thread Tom de Vries
Hi, In tree-parloops.c:gather_scalar_reductions, we find the comment: ... /* As gimple_uid is used by the vectorizer in between vect_analyze_loop_form and destroy_loop_vec_info, we can set gimple_uid of reduc_phi stmts only now. */ reduction_list->traverse (NULL); ... However, th

Re: [PATCH ARM]: PR67880: Add test.

2015-10-09 Thread Jeff Law
On 10/08/2015 01:35 AM, Christian Bruel wrote: On 10/07/2015 11:05 PM, Ramana Radhakrishnan wrote: On Wed, Oct 7, 2015 at 5:57 PM, Jeff Law wrote: On 10/07/2015 01:39 AM, Christian Bruel wrote: A regression test to check -fno-align-functions -O2 -mthumb thanks align4.patch 2015-09-29

Re: RFA: PATCH to store_field for storing a CONSTRUCTOR into a base subobject

2015-10-09 Thread Jeff Law
On 10/07/2015 08:42 PM, Jason Merrill wrote: While looking at another issue I noticed that in g++.dg/init/vbase1.C the Diamond(int) constructor was unnecessarily storing a CONSTRUCTOR into a stack temporary and then copying it into the SubB base subobject rather than directly storing the CONSTRUC

Re: [[Boolean Vector, patch 5/5] Support boolean vectors in vector lowering

2015-10-09 Thread Jeff Law
On 10/02/2015 08:11 AM, Ilya Enkovich wrote: Hi, This patch supports boolean vectors in vector lowering. Main change is to lower vector comparison into comparisons, not cond_exprs. Thanks, Ilya -- 2015-10-02 Ilya Enkovich * tree-vect-generic.c (elem_op_func): Add new operand to ho

Re: [Boolean Vector, patch 4/5] Use boolean vectors in VEC_COND_EXPR

2015-10-09 Thread Jeff Law
On 10/02/2015 08:07 AM, Ilya Enkovich wrote: Hi, This patch forces boolean vector usage in VEC_COND_EXPR generated by vectorizer. VEC_COND_EXPR expand is fixed appropriately. Thanks, Ilya -- gcc/ 2015-10-02 Ilya Enkovich * optabs.c (expand_vec_cond_expr): Accept boolean vector as

Re: [Boolean Vector, patch 3/5] Use boolean vector in C/C++ FE

2015-10-09 Thread Jeff Law
On 10/02/2015 08:04 AM, Ilya Enkovich wrote: Hi, This patch makes C/C++ FE to use boolean vector as a resulting type for vector comparison. As a result vector comparison in source code now parsed into VEC_COND_EXPR, it required a testcase fix-up. Thanks, Ilya -- gcc/c 2015-10-02 Ilya Enkov

Re: [Boolean Vector, patch 2/5] Change vector comparison IL requirement

2015-10-09 Thread Jeff Law
On 10/02/2015 08:01 AM, Ilya Enkovich wrote: Hi, This patch change vector comparison to require boolean vector resulting type. Thanks, Ilya -- gcc/ 2015-10-02 Ilya Enkovich * tree-cfg.c (verify_gimple_comparison) Require boolean vector type for vector comparison. (v

Re: [Boolean Vector, patch 1/5] Introduce boolean vector to be used as a vector comparison type

2015-10-09 Thread Jeff Law
On 10/02/2015 07:59 AM, Ilya Enkovich wrote: 2015-10-02 Ilya Enkovich * doc/tm.texi: Regenerated. * doc/tm.texi.in (TARGET_VECTORIZE_GET_MASK_MODE): New. * stor-layout.c (layout_type): Use mode to get vector mask size. * target.def (get_mask_mode): New.

Re: [PATCH, rs6000] Add memory barriers to tbegin, tend, etc.

2015-10-09 Thread Torvald Riegel
On Fri, 2015-10-09 at 11:52 -0500, Peter Bergner wrote: > On Fri, 2015-10-09 at 16:41 +0200, Torvald Riegel wrote: > > On Thu, 2015-09-03 at 16:58 -0500, Peter Bergner wrote: > >> +Note that the semantics of the above HTM builtins are required to mimic > >> the > >> +locking semantics used for cri

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-10-09 Thread Lynn A. Boger
Here's a new one. Tried all the variations, verified that split stack is still enabled and uses gold linker for 64 bit targets when using a 64 bit default compiler, and does not give the split stack error for 32 bit default compilers. On 10/08/2015 03:46 PM, Matthias Klose wrote: On 08.10.20

Re: [PATCH] New attribute to create target clones

2015-10-09 Thread Jan Hubicka
> On Fri, Oct 9, 2015 at 9:27 PM, Jan Hubicka wrote: > >> >Of course it also depends what you inline into function. You can have > >> > > >> >bar() target(-mavx) {fancy avx code} > >> >foobar() { .. if (avx) bar();} > >> >foo() ctarget(-mavx,-mno-avx) {foobar();} > > "no-" targets are

Re: [PATCH] New attribute to create target clones

2015-10-09 Thread Evgeny Stupachenko
On Fri, Oct 9, 2015 at 9:27 PM, Jan Hubicka wrote: >> >Of course it also depends what you inline into function. You can have >> > >> >bar() target(-mavx) {fancy avx code} >> >foobar() { .. if (avx) bar();} >> >foo() ctarget(-mavx,-mno-avx) {foobar();} "no-" targets are not supported

Re: [PATCH] Unswitching outer loops.

2015-10-09 Thread H.J. Lu
On Wed, Oct 7, 2015 at 2:53 AM, Yuri Rumyantsev wrote: > Richard, > > I've fixed adding virtual phi argument and add check on irreducible basic > block. > New patch is attached. > > I checked it for bootstrap and regression testing, no new failures. > > ChangeLog: > 2015-10-07 Yuri Rumyantsev

Re: [PATCH] Fix another bootstrap-ubsan failure due to -Werror=maybe-uninitialized.

2015-10-09 Thread Mikael Morin
Le 08/10/2015 11:06, Maxim Ostapenko a écrit : Hi, running UBSan bootstrap on trunk, I've run to the such issue: /home/max/workspace/downloads/svn/trunk/gcc/fortran/parse.c: In function ‘gfc_statement decode_statement()’: /home/max/workspace/downloads/svn/trunk/gcc/fortran/parse.c:368:51: error

Re: Do not use TYPE_CANONICAL in useless_type_conversion

2015-10-09 Thread Jan Hubicka
> Jan Hubicka writes: > > > Does the patch in https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00902.html > > help? > > No, it doesn't. > > #0 fancy_abort (file=0x43f1ce48 "../../gcc/expr.c", line=282, > function=0x43f1ec38 int)::__FUNCTION__> "convert_move") at ../../gcc/d

Re: [PATCH] New attribute to create target clones

2015-10-09 Thread Jan Hubicka
> >Of course it also depends what you inline into function. You can have > > > >bar() target(-mavx) {fancy avx code} > >foobar() { .. if (avx) bar();} > >foo() ctarget(-mavx,-mno-avx) {foobar();} > > > >Now if you compile with -mavx and because ctarget takes effect only after > >inlini

Re: Do not use TYPE_CANONICAL in useless_type_conversion

2015-10-09 Thread Jan Hubicka
> > The type has BLKmode and size 32. DECL_SIZE of the FIELD_DECL is however 24 > > (see it printed as Ada size). > > Yes, no wonder since it's a bitfield, i.e. DECL_BIT_FIELD is set. > > > The DECL_MODE of the FIELD_DECL is VOIDmode (not printed), while the > > TYPE_MODE of type contained is BLK

Re: [PATCH] New attribute to create target clones

2015-10-09 Thread Jeff Law
On 10/08/2015 03:36 PM, Jan Hubicka wrote: Yes, here you have different names for different variants of the function body. Basically this pass takes ctarget attribute and creates bunch of verisons of the functions and assigns them the proper target attributes, right? Right. Given a single func

Re: [gomp4.1] OpenMP 4.1 is dead, long live OpenMP 4.5

2015-10-09 Thread Ilya Verbin
On Fri, Oct 09, 2015 at 09:55:07 +0200, Jakub Jelinek wrote: > -GOMP_4.1 { > +GOMP_4.5 { >global: > GOMP_target_41; > GOMP_target_data_41; Should we rename it to GOMP_target*_45, or do you know some more mnemonic name? -- Ilya

[PATCH, i386]: Use ROUND_DOWN some more

2015-10-09 Thread Uros Bizjak
Hello! No functional changes. 2015-10-09 Uros Bizjak * config/i386/i386.c (expand_set_or_movmem_prologue_epilogue_by_misaligned_moves): Use ROUND_DOWN where applicable. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}, committed to mainline SVN: Uros. Index: config

[gomp4] Backport from trunk

2015-10-09 Thread James Norris
Hi, The attached patch was backported from trunk. commit 13d478244d380d1564eefc204201b7f681218ce3 Author: jnorris Date: Fri Oct 9 12:35:58 2015 + * config/rs6000/rs6000.c (rs6000_offload_options): New. (TARGET_OFFLOAD_OPTIONS): New. Jim diff --git a/gcc/config/rs6000/rs

Re: [PATCH, rs6000] Add memory barriers to tbegin, tend, etc.

2015-10-09 Thread Peter Bergner
On Fri, 2015-10-09 at 16:41 +0200, Torvald Riegel wrote: > On Thu, 2015-09-03 at 16:58 -0500, Peter Bergner wrote: >> +Note that the semantics of the above HTM builtins are required to mimic the >> +locking semantics used for critical sections. Builtins that are used to >> +create a new transactio

Re: [gomp4.1] fix more scheduling inconsistencies and add verification routines

2015-10-09 Thread Jakub Jelinek
On Fri, Oct 09, 2015 at 09:38:40AM -0700, Aldy Hernandez wrote: > As per our IRC discussion. > > I am conditionally compiling the verification code because you mentioned > that the GPGPUs may not having a working printf. Both that and code size being important there. > Also, I removed the code c

Re: [gomp4.1] fix more scheduling inconsistencies and add verification routines

2015-10-09 Thread Aldy Hernandez
As per our IRC discussion. I am conditionally compiling the verification code because you mentioned that the GPGPUs may not having a working printf. Also, I removed the code caching the workgroup since it may contain the incorrect workgroup as I had suggested. Now instead we look in child_t

[PATCH] [6/n] Fix minor SSA_NAME leaks

2015-10-09 Thread Jeff Law
free_stmt_vec_info was releasing the LHS of a statement from the *wrong* statement. Thankfully, the LHS it was actually releasing was just released by some earlier code, so nothing bad happened (the name manager explicitly allows multiple releases of the same node -- something we may want to c

Re: [PATCH] bb-reorder: Improve the simple algorithm for -Os (PR67864)

2015-10-09 Thread Segher Boessenkool
On Fri, Oct 09, 2015 at 12:35:46PM +0200, Bernd Schmidt wrote: > On 10/08/2015 06:57 PM, Segher Boessenkool wrote: > >As the PR points out, the "simple" reorder algorithm makes bigger code > >than the STC algorithm did, for -Os, for x86. I now tested it for many > >different targets and it turns o

Re: Move sqrt and cbrt simplifications to match.pd

2015-10-09 Thread Richard Sandiford
Richard Sandiford writes: > Christophe Lyon writes: >> On 8 October 2015 at 18:55, Richard Sandiford >> wrote: >>> Marc Glisse writes: On Mon, 5 Oct 2015, Richard Sandiford wrote: > + /* cbrt(sqrt(x)) -> pow(x,1/6). */ > + (simplify > + (sqrts (cbrts @0)) > + (p

Re: [AArch64_be] Fix vtbl[34] and vtbx4

2015-10-09 Thread Christophe Lyon
On 8 October 2015 at 11:12, James Greenhalgh wrote: > On Wed, Oct 07, 2015 at 09:07:30PM +0100, Christophe Lyon wrote: >> On 7 October 2015 at 17:09, James Greenhalgh >> wrote: >> > On Tue, Sep 15, 2015 at 05:25:25PM +0100, Christophe Lyon wrote: >> > >> > Why do we want this for vtbx4 rather th

[PATCH][COMMITTED] PR target/67895: Fix embedded rounding/SAE specifier position for some AVX512 instructions.

2015-10-09 Thread Alexander Fomin
Committed to trunk in r228660. Thanks, Alexander --- gcc/ PR target/67895 * config/i386/sse.md (define_insn "sse_cvtsi2ss"): Adjust embedded rounding/SAE specifier position. (define_insn "sse_cvtsi2ssq"): Likewise. (define_insn "cvtusi232"): Likewise.

Re: [PATCH V3][GCC] Algorithmic optimization in match and simplify

2015-10-09 Thread James Greenhalgh
On Thu, Oct 08, 2015 at 01:29:34PM +0100, Richard Biener wrote: > > Thanks again for the comments Richard! > > > > A new algorithmic optimisation: > > > > ((X inner_op C0) outer_op C1) > > With X being a tree where value_range has reasoned certain bits to always be > > zero throughout its computed

Re: [PATCH] bb-reorder: Improve the simple algorithm for -Os (PR67864)

2015-10-09 Thread Segher Boessenkool
On Fri, Oct 09, 2015 at 11:29:16AM +0200, Richard Biener wrote: > I think the patch makes sense but it also raises a question for me - how > did we decide what edge gets EDGE_FALLTHRU when going out-of-cfglayout? Good question. I think it just tries to make "natural" control flow; I'll investigat

Re: [PATCH][PR tree-optimization/67816] Fix jump threading when DOM removes conditionals in jump threading path

2015-10-09 Thread Jeff Law
On 10/08/2015 03:56 AM, Richard Biener wrote: On Thu, Oct 8, 2015 at 12:00 AM, Jeff Law wrote: On 10/07/2015 02:26 AM, Richard Biener wrote: Hmm, other passes avoid all this by not removing edges or blocks themselves but leaving that to cfgcleanup. They simply replace the condition in GIMPL

Re: [Patch ifcvt costs 0/3] Introduce a new target hook for ifcvt costs.

2015-10-09 Thread Jeff Law
On 10/09/2015 05:28 AM, Bernd Schmidt wrote: I don't know whether you've done any more work on the patch series, but I think I've made up my mind that optimizing the sequence before computing its cost would be a good thing to try first. Either with a better expander interface which generates the

Re: [PATCH] [3/n] Fix minor SSA_NAME leaks

2015-10-09 Thread Jeff Law
On 10/09/2015 03:37 AM, Richard Biener wrote: On Thu, Oct 8, 2015 at 10:47 PM, Jeff Law wrote: And other minor leak. This time in tree-stdarg. Unlike other cases, we're dropping just the virtual definition, other definitions on the statement need to be preserved (they're going to be re-used).

[PR libgomp/65437, libgomp/66518] Initialize runtime in acc_update_device, acc_update_self

2015-10-09 Thread Thomas Schwinge
Hi! On Fri, 19 Jun 2015 09:47:41 +0200, I wrote: > On Tue, 5 May 2015 11:43:20 +0200, I wrote: > > On Mon, 4 May 2015 10:20:14 -0400, John David Anglin > > wrote: > > > FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/lib-42.c > > > -DACC_DEVICE_TYPE_hos > > > t=1 -DACC_MEM_SHARED=1 output pat

libgomp: Additional acc_shutdown bug fixing and testing

2015-10-09 Thread Thomas Schwinge
Hi! On Wed, 22 Jul 2015 16:37:46 +0200, I wrote: > [...] found an inconsistency in libgomp; committed > to gomp-4_0-branch in r226071: [...] OK for trunk? commit dc0c73e9ac5decf5b36be25497ed5f4b99136fba Author: Thomas Schwinge Date: Fri Oct 9 13:22:52 2015 +0200 libgomp: Additional acc_s

[libgomp/66518] Resolve XFAIL in libgomp.oacc-c-c++-common/lib-3.c

2015-10-09 Thread Thomas Schwinge
Hi! On Wed, 22 Jul 2015 16:32:17 +0200, I wrote: > [...] in r226070, I committed the > following to gomp-4_0-branch: [...] OK for trunk? commit 8ba8b058417afc2e7979ef25fdb943ae4e8838dd Author: Thomas Schwinge Date: Fri Oct 9 13:20:52 2015 +0200 [libgomp/66518] Resolve XFAIL in libgomp.oa

libgomp testsuite: Remove some explicit acc_device_nvidia usage

2015-10-09 Thread Thomas Schwinge
Hi! On Wed, 22 Jul 2015 16:39:54 +0200, I wrote: > [...] cleanup; committed to > gomp-4_0-branch in r226072: [...] OK for trunk? commit a8bd7234d7b6b0111a1e3b3dc032ea5eead7e258 Author: Thomas Schwinge Date: Fri Oct 9 16:40:56 2015 +0200 libgomp testsuite: Remove some explicit acc_device_

Re: Move sqrt and cbrt simplifications to match.pd

2015-10-09 Thread Richard Sandiford
Christophe Lyon writes: > On 8 October 2015 at 18:55, Richard Sandiford > wrote: >> Marc Glisse writes: >>> On Mon, 5 Oct 2015, Richard Sandiford wrote: >>> + /* cbrt(sqrt(x)) -> pow(x,1/6). */ + (simplify + (sqrts (cbrts @0)) + (pows @0 { build_real_truncate (type, d

[HSA] Fix usage of an uninitialized memory

2015-10-09 Thread Martin Liška
Hello. In the following patch, I fix usage of an uninitialized variable: hsa_cfun->decl. Installed as revision 228659. Thanks, Martin >From 7f85ed1c1d3f2fe6132117f58c84af33cb709689 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 9 Oct 2015 15:06:46 +0200 Subject: [PATCH 1/7] HSA: fix usage of

RE: [PATCH 1/4] [MIPS] Add support for MIPS SIMD Architecture (MSA)

2015-10-09 Thread Matthew Fortune
Hi Robert, Next batch of comments. This set covers the rest of mips-msa.md. >+++ b/gcc/config/mips/mips-msa.md >+(define_expand "vec_perm" >+ [(match_operand:MSA 0 "register_operand") >+ (match_operand:MSA 1 "register_operand") >+ (match_operand:MSA 2 "register_operand") >+ (match_operand:

Re: PING: [PATCH] PR target/35514: Gcc shoud generate symbol type for undefined symbol

2015-10-09 Thread H.J. Lu
On Fri, Oct 9, 2015 at 5:50 AM, Bernd Schmidt wrote: > On 10/09/2015 02:45 PM, H.J. Lu wrote: >> >> What kind of diagnostic message? The ELF linker seems to have managed to >> do >>> >>> without for a long time. Is there some discussion of this on the binutils >>> list that you can point to? >> >>

Re: [PATCH, rs6000] Add memory barriers to tbegin, tend, etc.

2015-10-09 Thread Torvald Riegel
Sorry for the much delayed response. I've been sick and am slowly catching up. On Thu, 2015-09-03 at 16:58 -0500, Peter Bergner wrote: > On a glibc thread discussing this issue, Torvald also asked that I add > documention describing the memory consistency semantics the HTM instructions > should h

Re: libgomp: Guard all devices/num_devices/num_devices_openmp access by register_lock

2015-10-09 Thread Ilya Verbin
On Fri, Oct 09, 2015 at 13:58:32 +0200, Bernd Schmidt wrote: > One oddity I noticed in target.c is that there are two different num_devices > variables: > > /* Total number of available devices. */ > static int num_devices; > > /* Number of GOMP_OFFLOAD_CAP_OPENMP_400 devices. */ > stat

Re: Move sqrt and cbrt simplifications to match.pd

2015-10-09 Thread Christophe Lyon
On 8 October 2015 at 18:55, Richard Sandiford wrote: > Marc Glisse writes: >> On Mon, 5 Oct 2015, Richard Sandiford wrote: >> >>> + /* cbrt(sqrt(x)) -> pow(x,1/6). */ >>> + (simplify >>> + (sqrts (cbrts @0)) >>> + (pows @0 { build_real_truncate (type, dconst<1, 6> ()); })) >>> + /* sqrt(c

Re: [PATCH, i386, AVX512] PR target/67895: Fix position of embedded rounding/SAE mode in AVX512 vrangep* and vcvt?si2s* instructions.

2015-10-09 Thread Kirill Yukhin
Hello, On 08 Oct 20:31, Alexander Fomin wrote: > Hi All, > > This patch addresses PR target/67895. For some AVX512 instructions > we've used to emit embedded rounding/SAE specifier in a wrong place. > The patch fixes its position for vrange* and vcvt?si2s* instructions. > I've also updated regula

Re: [gomp4.1] fix dependency scheduling problem

2015-10-09 Thread Jakub Jelinek
On Fri, Oct 02, 2015 at 03:46:59PM -0700, Aldy Hernandez wrote: > commit 6d8f6db0583326d803c7c7abd8ea26cc842643fc > Author: Aldy Hernandez > Date: Fri Oct 2 15:40:30 2015 -0700 > > * task.c (gomp_task_maybe_wait_for_dependencies): Fix scheduling > problem such that the first non par

[gomp4]

2015-10-09 Thread Nathan Sidwell
I've applied this to gomp4 branch. 1) ports the break fix in gimple-fold from trunk 2) fixes missing tab in ptx output. nathan 2015-10-09 Nathan Sidwell * config/nvptx/nvptx.c (nvptx_init_axis_predicate): Fix output formatting. PR 67861 * gimple-fold.c (gimple_fold_builtin): Add break

[gomp4] Revert patch

2015-10-09 Thread James Norris
Hi, The attached patch reverts a previously attached patch. 2015-10-06 James Norris * common.opt (OFFLOAD_ABI_PPC64): New enum. * config/nvptx/mkoffload.c (compile_native): Handle new enum. (main): Handle new option. * config/rs6000/rs6000.c (rs6000_off

Re: [PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages

2015-10-09 Thread Charles Baylis
On 7 October 2015 at 00:59, wrote: > From: Charles Baylis > > This patch series fixes up the error messages for single lane vector > load/stores, similarly to AArch64. > > make check on arm-linux-gnueabihf/qemu completes with no new regressions. > > Changes since the last version: > . removed th

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Thomas Schwinge
Hi Nathan! On Fri, 9 Oct 2015 09:34:51 -0400, Nathan Sidwell wrote: > On 10/09/15 09:26, Thomas Schwinge wrote: > > You mean the cp_parser_oacc_loop and cp_parser_oacc_kernels_parallel > > functions need documentation? I agree it's a bit terse, but documenting > > these by just listing the accep

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Jakub Jelinek
On Fri, Oct 09, 2015 at 09:34:51AM -0400, Nathan Sidwell wrote: > On 10/09/15 09:26, Thomas Schwinge wrote: > >Hi! > > >You mean the cp_parser_oacc_loop and cp_parser_oacc_kernels_parallel > >functions need documentation? I agree it's a bit terse, but documenting > >these by just listing the acce

Re: Do not describe -std=c11 etc. as experimental in c.opt help text

2015-10-09 Thread Marek Polacek
Jason: ping. On Fri, Oct 02, 2015 at 05:35:39PM +0200, Marek Polacek wrote: > On Thu, Oct 01, 2015 at 05:01:26PM +, Joseph Myers wrote: > > I noticed that c.opt still described -std=c11 and related options as > > experimental in the --help text. This patch fixes this. > > > > Jason, note tha

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Nathan Sidwell
On 10/09/15 09:26, Thomas Schwinge wrote: Hi! You mean the cp_parser_oacc_loop and cp_parser_oacc_kernels_parallel functions need documentation? I agree it's a bit terse, but documenting these by just listing the accepted parsing tokens "# pragma acc loop" etc., followed by the *_CLAUSE_MASKs

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Thomas Schwinge
Hi! Thanks to Joseph and you for your review! On Fri, 9 Oct 2015 08:26:37 -0400, Nathan Sidwell wrote: > On 10/08/15 12:39, Thomas Schwinge wrote: > > Some bits extracted out of gomp-4_0-branch, and some other bits > > rewritten; here is a patch to support OpenACC Combined Directives in C, > > C

Re: PING: [PATCH] PR target/35514: Gcc shoud generate symbol type for undefined symbol

2015-10-09 Thread Bernd Schmidt
On 10/09/2015 02:45 PM, H.J. Lu wrote: What kind of diagnostic message? The ELF linker seems to have managed to do without for a long time. Is there some discussion of this on the binutils list that you can point to? https://groups.google.com/forum/#!topic/generic-abi/_ZPPq_c8FSQ Hmm, near t

Re: PING: [PATCH] PR target/35514: Gcc shoud generate symbol type for undefined symbol

2015-10-09 Thread H.J. Lu
On Fri, Oct 9, 2015 at 4:11 AM, Bernd Schmidt wrote: > On 10/08/2015 01:10 PM, H.J. Lu wrote: >> >> On Wed, Jul 8, 2015 at 1:35 PM, H.J. Lu wrote: >>> >>> On Sun, Jul 5, 2015 at 2:54 PM, H.J. Lu wrote: On Sun, Jul 5, 2015 at 11:14 AM, H.J. Lu wrote: > > Update default_elf_asm_

Re: [PR c/64765, c/64880] Support OpenACC Combined Directives in C, C++

2015-10-09 Thread Nathan Sidwell
On 10/08/15 12:39, Thomas Schwinge wrote: Hi! Some bits extracted out of gomp-4_0-branch, and some other bits rewritten; here is a patch to support OpenACC Combined Directives in C, C++. (The Fortran front end already does support these.) As far as I know, Jakub is not available at this time,

Re: Add -foffload-abi support for PPC

2015-10-09 Thread David Edelsohn
On Fri, Oct 9, 2015 at 8:20 AM, James Norris wrote: > David, > > > On 10/08/2015 11:53 AM, David Edelsohn wrote: >> >> On Thu, Oct 8, 2015 at 12:19 PM, James Norris >> wrote: >> >>> I've revised the patch from the review comments (thank you) and >>> is attached. >>> >>> Regtested on x86_64 and po

Re: Add -foffload-abi support for PPC

2015-10-09 Thread James Norris
David, On 10/08/2015 11:53 AM, David Edelsohn wrote: On Thu, Oct 8, 2015 at 12:19 PM, James Norris wrote: I've revised the patch from the review comments (thank you) and is attached. Regtested on x86_64 and powerpcle64. OK for trunk? What is the goal? Do you want this to return the correc

Re: [PATCH GCC]Improve rtl loop inv cost by checking if the inv can be propagated to address uses

2015-10-09 Thread Bernd Schmidt
On 10/09/2015 02:00 PM, Bin.Cheng wrote: I further bootstrap and test attached patch on aarch64. Also three cases in spec2k6/fp are improved by 3~6%, two cases in spec2k6/fp are regressed by ~2%. Overall score is improved by ~0.8% for spec2k6/fp on aarch64 of my run. I may later analyze the re

Re: [PATCH GCC]Improve rtl loop inv cost by checking if the inv can be propagated to address uses

2015-10-09 Thread Bin.Cheng
On Wed, Sep 30, 2015 at 11:33 AM, Bin.Cheng wrote: > On Tue, Sep 29, 2015 at 1:21 AM, Jeff Law wrote: >> On 09/28/2015 05:28 AM, Bernd Schmidt wrote: >>> >>> On 09/28/2015 11:43 AM, Bin Cheng wrote: Bootstrap and test on x86_64 and x86_32. Will test it on aarch64. So any com

Re: libgomp: Guard all devices/num_devices/num_devices_openmp access by register_lock

2015-10-09 Thread Bernd Schmidt
On 09/28/2015 10:52 AM, Thomas Schwinge wrote: On Fri, 25 Sep 2015 19:49:50 +0300, Ilya Verbin wrote: Looks like you're right, and this scenario is possible. Thanks for your review! Jakub, OK to commit the patch I had posted? Then, in context of a similar scenario, I think we'll also want

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-10-09 Thread Martin Liška
Hi All, I've just added myself to Write After Approval maintainers. Committed 228649. Martin Index: ChangeLog === --- ChangeLog (revision 228647) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2015-10-09 Martin Liska + + * MAINTAIN

Re: [PATCH] 2015-10-02 Benedikt Huber Philipp Tomsich

2015-10-09 Thread James Greenhalgh
On Sat, Jan 03, 1970 at 03:27:04AM +, Benedikt Huber wrote: > * config/aarch64/aarch64-builtins.c: Builtins for rsqrt and > rsqrtf. > * config/aarch64/aarch64-protos.h: Declare. > * config/aarch64/aarch64-simd.md: Matching expressions for > frsqrte and fr

Re: [patch 0/6] scalar-storage-order merge (2)

2015-10-09 Thread Bernd Schmidt
On 10/06/2015 12:57 PM, Eric Botcazou wrote: this is a repost of the diff of the scalar-storage-order branch vs mainline. It contains the fixes suggested by Joseph for the C front-end and the doc, fixes for the handling of complex types, the new pragma scalar_storage_order and associated -fsso-st

Re: [Patch ifcvt costs 0/3] Introduce a new target hook for ifcvt costs.

2015-10-09 Thread Bernd Schmidt
On 10/01/2015 11:37 AM, Bernd Schmidt wrote: On 09/29/2015 04:31 PM, James Greenhalgh wrote: On the other side of the equation, we want a cost for the converted sequence. We can build a cost of the generated rtl sequence, but for targets like AArch64 this is going to be wildly off. AArch64 will

Re: [COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-10-09 Thread Marek Polacek
On Fri, Oct 09, 2015 at 01:56:23PM +0300, Alexander Fomin wrote: > I've just added myself to Write After Approval maintainers. Welcome. > Index: ChangeLog > === > diff --git a/trunk/ChangeLog b/trunk/ChangeLog > --- a/trunk/ChangeLog

RE: [RFC][PATCH] Preferred rename register in regrename pass

2015-10-09 Thread Robert Suchanek
Hi Bernd, > Hi Robert, > > gcc/ > > * regrename.c (create_new_chain): Initialize terminated_dead, > > renamed and tied_chain. > > (find_best_rename_reg): Pick and check register from the tied chain. > > (regrename_do_replace): Mark head as renamed. > > (scan_rtx_reg): Tie chain

Re: Additional headers under include/experimental/

2015-10-09 Thread Jonathan Wakely
On 06/10/15 15:12 +0100, Jonathan Wakely wrote: On 03/07/14 11:35 +0100, Jonathan Wakely wrote: I'm working on parts of the Filesystem TS and think it makes sense to split it up into separate headers for path, directory utils and the free functions, then include those from , otherwise it's going

Re: PING: [PATCH] PR target/35514: Gcc shoud generate symbol type for undefined symbol

2015-10-09 Thread Bernd Schmidt
On 10/08/2015 01:10 PM, H.J. Lu wrote: On Wed, Jul 8, 2015 at 1:35 PM, H.J. Lu wrote: On Sun, Jul 5, 2015 at 2:54 PM, H.J. Lu wrote: On Sun, Jul 5, 2015 at 11:14 AM, H.J. Lu wrote: Update default_elf_asm_output_external to also output symbol type to help ELF linker to properly issue diagnos

Re: [RFC][PATCH] Preferred rename register in regrename pass

2015-10-09 Thread Bernd Schmidt
Hi Robert, gcc/ * regrename.c (create_new_chain): Initialize terminated_dead, renamed and tied_chain. (find_best_rename_reg): Pick and check register from the tied chain. (regrename_do_replace): Mark head as renamed. (scan_rtx_reg): Tie chains in move insns

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-10-09 Thread Alexander Fomin
Hi All, I've just added myself to Write After Approval maintainers. Committed r228642. Regards, Alexander Index: ChangeLog === diff --git a/trunk/ChangeLog b/trunk/ChangeLog --- a/trunk/ChangeLog (revision 228641) +++ b/trunk/Chan

Re: [PATCH 1/9] Change default of non-overlapping address space conversion

2015-10-09 Thread Bernd Schmidt
On 10/08/2015 06:59 AM, Richard Henderson wrote: The current default of making all undefined coversions being set to null is not useful. It has caused all users to lie and say that spaces are subsets when they are not, just so that they can override the conversion. * expr.c (expand_exp

Re: [PATCH] bb-reorder: Improve the simple algorithm for -Os (PR67864)

2015-10-09 Thread Bernd Schmidt
On 10/08/2015 06:57 PM, Segher Boessenkool wrote: As the PR points out, the "simple" reorder algorithm makes bigger code than the STC algorithm did, for -Os, for x86. I now tested it for many different targets and it turns out to be worse everywhere. That's somewhat disappointing. Wasn't it su

Re: RFA: PATCH to store_field for storing a CONSTRUCTOR into a base subobject

2015-10-09 Thread Richard Biener
On Thu, Oct 8, 2015 at 4:42 AM, Jason Merrill wrote: > While looking at another issue I noticed that in g++.dg/init/vbase1.C the > Diamond(int) constructor was unnecessarily storing a CONSTRUCTOR into a > stack temporary and then copying it into the SubB base subobject rather than > directly stori

Re: [3/7] Optimize ZEXT_EXPR with tree-vrp

2015-10-09 Thread Richard Biener
On Thu, Oct 8, 2015 at 1:40 AM, Kugan wrote: > > > On 07/10/15 19:20, Richard Biener wrote: >> On Wed, Oct 7, 2015 at 1:12 AM, kugan >> wrote: >>> >>> Hi Richard, >>> >>> Thanks for the review. >>> >>> On 15/09/15 23:08, Richard Biener wrote: On Mon, Sep 7, 2015 at 4:58 AM, Kugan

Re: [nvptx] fix some c++ tests

2015-10-09 Thread Bernd Schmidt
On 10/09/2015 07:55 AM, Thomas Schwinge wrote: Hi Nathan! Thanks for looking into this. When I reported this, , quite a lot of testcases had been failing -- with recent GCC trunk, the number is smaller (because

[PR fortran/63858] Fix mix of OpenACC and OpenMP sentinels in continuations

2015-10-09 Thread Thomas Schwinge
Hi! On Mon, 27 Jul 2015 16:14:17 +0200, I wrote: > On Tue, 30 Jun 2015 03:39:42 +0300, Ilmir Usmanov wrote: > > 08.06.2015, 17:59, "Cesar Philippidis" : > > > On 06/07/2015 02:05 PM, Ilmir Usmanov wrote: > > >> 08.06.2015, 00:01, "Ilmir Usmanov" : > > This patch fixes checks of OpenMP and

RE: [Patch] [x86_64]: Add bdver4 for multi versioning and fix AMD cpu model detection.

2015-10-09 Thread Kumar, Venkataramanan
Thank you Uros, I will test and commit model selection change in all release branches as well. Regards, Venkat. > -Original Message- > From: Uros Bizjak [mailto:ubiz...@gmail.com] > Sent: Friday, October 09, 2015 3:25 PM > To: Kumar, Venkataramanan > Cc: gcc-patches@gcc.gnu.org > Subjec

Re: [Patch] [x86_64]: Add bdver4 for multi versioning and fix AMD cpu model detection.

2015-10-09 Thread Uros Bizjak
On Fri, Oct 9, 2015 at 11:50 AM, Kumar, Venkataramanan wrote: > Hi Uros, > > Please find below patch that adds bdver4 target for multi versioning. > Also I while computing model, the extended_model is incorrectly left shifted > by 4. I have removed it now. > > Is below patch Ok for trunk ? > GCC

[Patch] [x86_64]: Add bdver4 for multi versioning and fix AMD cpu model detection.

2015-10-09 Thread Kumar, Venkataramanan
Hi Uros, Please find below patch that adds bdver4 target for multi versioning. Also I while computing model, the extended_model is incorrectly left shifted by 4. I have removed it now. Is below patch Ok for trunk ? GCC bootstrap and regressions passed. diff --git a/libgcc/ChangeLog b/libgcc/

Re: [PR67891] drop is_gimple_reg test from set_parm_rtl (was: [PR67766] reorder return value copying from PARALLELs and CONCATs)

2015-10-09 Thread Richard Biener
On Fri, Oct 9, 2015 at 9:33 AM, Alexandre Oliva wrote: > On Oct 9, 2015, Alexandre Oliva wrote: > >> This fixes fallout from the PR64164 expander revamp. > >> Uroš kindly tested with an alpha-linux-gnu regstrap. > > The one regression he mentioned from that run was gcc.dg/pr43300.c. The > vecto

Re: [PATCH] [3/n] Fix minor SSA_NAME leaks

2015-10-09 Thread Richard Biener
On Thu, Oct 8, 2015 at 10:47 PM, Jeff Law wrote: > And other minor leak. This time in tree-stdarg. Unlike other cases, we're > dropping just the virtual definition, other definitions on the statement > need to be preserved (they're going to be re-used). Additionally, this one > is missing the ca

Re: [PR67766] reorder return value copying from PARALLELs and CONCATs (was: Re: [PR64164] drop copyrename, integrate into expand)

2015-10-09 Thread Richard Biener
On Fri, Oct 9, 2015 at 7:36 AM, Alexandre Oliva wrote: > This fixes fallout from the PR64164 expander revamp. On alpha, PARALLEL > hard return values may be modeless, and this confuses the code that > wants to copy the pseudo/s in the returned value to the return hard > regs. > > It used to work

Re: [PR67828] don't unswitch loops on undefined SSA values (was: Re: [PR64164] drop copyrename, integrate into expand)

2015-10-09 Thread Richard Biener
On Fri, Oct 9, 2015 at 7:26 AM, Alexandre Oliva wrote: > This patch fixes a latent bug in loop unswitching exposed by the PR64164 > changes. > > We would move a test out of a loop that might never have been executed, > and that accessed an uninitialized variable. The uninitialized SSA > name, due

  1   2   >