Multiply Optimization in match and Simplify

2015-10-28 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch that moves some multiply optimizations from fold-const using simplify and match. Please review the patch and let me know if any modifications are required. Tested the patch on X86. Observing following failures:- >> FAIL: gcc.dg/fold-plusmult.c scan-tree-dump-

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-28 Thread Jan Hubicka
> > Added and comitted now. > > Thanks. Now on to the wrong code issues. :-) > > Up to the change, the useless_type_conversion_p predicate was relying on > structural equivalence via the TYPE_CANONICAL check, now it only looks at the > outermost level (size, mode). Now some back-ends, most no

Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-28 Thread H.J. Lu
On Wed, Oct 28, 2015 at 6:21 PM, Bernd Schmidt wrote: > On 10/29/2015 02:14 AM, H.J. Lu wrote: >> >> On Wed, Oct 28, 2015 at 6:11 PM, Bernd Schmidt >> wrote: >>> >>> On 10/29/2015 02:10 AM, H.J. Lu wrote: On Wed, Oct 28, 2015 at 5:23 PM, Jeff Law wrote: > > > > So

Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-28 Thread Bernd Schmidt
On 10/29/2015 02:14 AM, H.J. Lu wrote: On Wed, Oct 28, 2015 at 6:11 PM, Bernd Schmidt wrote: On 10/29/2015 02:10 AM, H.J. Lu wrote: On Wed, Oct 28, 2015 at 5:23 PM, Jeff Law wrote: So I'll ask again, why did you commit a patch which you clearly knew did not meet the conditions Bernd set f

Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-28 Thread H.J. Lu
On Wed, Oct 28, 2015 at 6:11 PM, Bernd Schmidt wrote: > On 10/29/2015 02:10 AM, H.J. Lu wrote: >> >> On Wed, Oct 28, 2015 at 5:23 PM, Jeff Law wrote: >>> >>> >>> So I'll ask again, why did you commit a patch which you clearly knew did >>> not >>> meet the conditions Bernd set forth for approval?

Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-28 Thread Bernd Schmidt
On 10/29/2015 02:10 AM, H.J. Lu wrote: On Wed, Oct 28, 2015 at 5:23 PM, Jeff Law wrote: So I'll ask again, why did you commit a patch which you clearly knew did not meet the conditions Bernd set forth for approval? I believed that aarch64 backend didn't properly handle -fno-plt, which should

Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-28 Thread H.J. Lu
On Wed, Oct 28, 2015 at 5:23 PM, Jeff Law wrote: > On 10/27/2015 12:54 PM, H.J. Lu wrote: HJ, Thanks for committing the change even when we were discussing the change >>> >>> >>> This is what I'm primarily concerned about. >>> >>> Bernd's message was pretty clear in my mind: >>> >>>

Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-28 Thread Jeff Law
On 10/27/2015 12:54 PM, H.J. Lu wrote: HJ, Thanks for committing the change even when we were discussing the change This is what I'm primarily concerned about. Bernd's message was pretty clear in my mind: https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02861.html It was conditional approval ba

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-28 Thread Joseph Myers
On Wed, 28 Oct 2015, Mike Stump wrote: > On Oct 28, 2015, at 3:04 PM, Eric Botcazou wrote: > >> Why is -fsso-struct= listed only for C and C++, not ObjC and ObjC++? > > > > Because it was not tested with the latter 2 languages at all and may > > require > > specific adjustments in the respecti

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-28 Thread Mike Stump
On Oct 28, 2015, at 3:04 PM, Eric Botcazou wrote: >> Why is -fsso-struct= listed only for C and C++, not ObjC and ObjC++? > > Because it was not tested with the latter 2 languages at all and may require > specific adjustments in the respective front-ends to work. It won’t. Fixing the language

[PATCH][4.9/5 Backport] PR rtl-optimization/67037 Use copy_rtx when necessary

2015-10-28 Thread Grazvydas Ignotas
Hi, This is the 4.9 and GCC 5 backport of patch from PR67037 that's already in trunk. I've build it on 4.9 and confirmed that it works. Grazvydas Backport from mainline 2015-09-30 Bernd Edlinger PR rtl-optimization/67037 * lra-constraints.c (process_addr_reg): Use copy_rtx w

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-28 Thread Eric Botcazou
> Added and comitted now. Thanks. Now on to the wrong code issues. :-) Up to the change, the useless_type_conversion_p predicate was relying on structural equivalence via the TYPE_CANONICAL check, now it only looks at the outermost level (size, mode). Now some back-ends, most notably x86-64,

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-28 Thread Eric Botcazou
> Why is -fsso-struct= listed only for C and C++, not ObjC and ObjC++? Because it was not tested with the latter 2 languages at all and may require specific adjustments in the respective front-ends to work. > Almost all C options should be supported for ObjC and almost all C++ > options should b

[gomp4] minor cfe backports

2015-10-28 Thread Cesar Philippidis
I've applied this patch which backports a change in the way that seq and auto are parsed in the c front end from trunk to gomp4. Next up, I'm preparing a patch to remove *_omp_positive_int_clause from the c and c++ front ends in gomp4. That function is used to parse num_threads, num_gangs, num_wor

Re: [AArch64] Add scheduling and cost models for Exynos M1

2015-10-28 Thread Evandro Menezes
Andrew, I need to do more investigation WRT prefetching, especially Kyrill's recent patch. The change to the peeling limit also benefits A57. If James or Marcus could confirm this, I'd be glad to add it to all AArch64 targets, assuming that Xgene would be fine with it too. Thank you, --

Re: [PATCH, 2/6] Rename make_restrict_var_constraints to make_param_constraints

2015-10-28 Thread Tom de Vries
On 28/10/15 16:38, Richard Biener wrote: On Tue, 27 Oct 2015, Tom de Vries wrote: On 27/10/15 13:24, Tom de Vries wrote: Thinking it over a bit more, I realized the constraint handling started to be messy. I've reworked the patch series to simplify that first. 1Simplify constraint

Re: [PATCH, 1/6] Simplify constraint handling

2015-10-28 Thread Tom de Vries
On 28/10/15 17:05, Tom de Vries wrote: On 28/10/15 16:35, Richard Biener wrote: On Tue, 27 Oct 2015, Tom de Vries wrote: On 27/10/15 13:24, Tom de Vries wrote: Thinking it over a bit more, I realized the constraint handling started to be messy. I've reworked the patch series to simplify that

Re: [Patch, committed] PR67933

2015-10-28 Thread Bill Schmidt
On Tue, 2015-10-27 at 19:07 +0100, Paul Richard Thomas wrote: > Dear All, > > The recent patches on trunk to gfc_trans_allocate have fixed PR67933. > I have added a testcase, which has been committed as revision 229452. This test case fails at runtime on powerpc64le-linux-gnu. From gfortran.log:

omp cleanup

2015-10-28 Thread Nathan Sidwell
Jakub, looking at the next thing to merge, I stumbled on code in lower_omp_target that appears at least confused. we have: if (offloaded || data_region) { A } else if (data_region) new_body = tgt_body; if (offloaded || data_region) { B } which can clearly be simplified to:

Re: [PATCH 00/16] Unit tests framework (v3)

2015-10-28 Thread Mike Stump
On Oct 27, 2015, at 12:48 PM, David Malcolm wrote: > The following patch kit adds a unit tests framework for gcc, I’m supportive of the patch set and the concept in general. I don’t know who wants to review this, Jeff seems on track to do this. My only guidance would be to say we should allow

Re: RFA (Makefiles): PATCH to include libcpp and libiberty in GCC etags

2015-10-28 Thread Jeff Law
On 10/28/2015 01:43 PM, Jason Merrill wrote: On 10/28/2015 03:27 PM, Jeff Law wrote: On 10/28/2015 12:49 PM, Jason Merrill wrote: Periodically I try to use M-. to pull up a function from libcpp and am frustrated that it doesn't work. This patch fixes that, and throws in libiberty for good meas

Re: RFA (Makefiles): PATCH to include libcpp and libiberty in GCC etags

2015-10-28 Thread Jason Merrill
On 10/28/2015 03:27 PM, Jeff Law wrote: On 10/28/2015 12:49 PM, Jason Merrill wrote: Periodically I try to use M-. to pull up a function from libcpp and am frustrated that it doesn't work. This patch fixes that, and throws in libiberty for good measure. I also considered using --include for th

Re: Fix for PR sanitize/65000 introduces an unusual gcc_assert

2015-10-28 Thread Richard Henderson
On 10/28/2015 12:09 PM, Richard Biener wrote: On October 28, 2015 7:07:54 PM GMT+01:00, Richard Henderson wrote: On 10/28/2015 10:47 AM, Alexander Monakov wrote: Hello Richard, Your commit to fix PR 65000 (pasted below) introduced gcc_assert (ri = (int)ri); I'm unclear what is meant the

Re: [Boolean Vector, patch 1/5] Introduce boolean vector to be used as a vector comparison type

2015-10-28 Thread Ilya Enkovich
Seems the problem occurs in this check in expand_vector_operations_1: /* A scalar operation pretending to be a vector one. */ if (VECTOR_BOOLEAN_TYPE_P (type) && !VECTOR_MODE_P (TYPE_MODE (type)) && TYPE_MODE (type) != BLKmode) return; This is to filter out scalar operations

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Alexander Monakov
On Wed, 28 Oct 2015, Bernd Schmidt wrote: > On 10/28/2015 07:06 PM, Alexander Monakov wrote: > > On Wed, 28 Oct 2015, Bernd Schmidt wrote: > > > Ok, so adjust the if condition for non-integral types - make it false if > > > the > > > size of the struct is smaller than the pointer type. > > > > I'm

Re: RFA (Makefiles): PATCH to include libcpp and libiberty in GCC etags

2015-10-28 Thread Jeff Law
On 10/28/2015 12:49 PM, Jason Merrill wrote: Periodically I try to use M-. to pull up a function from libcpp and am frustrated that it doesn't work. This patch fixes that, and throws in libiberty for good measure. I also considered using --include for the TAGS files in those directories, but th

[gomp4] backport changes

2015-10-28 Thread Nathan Sidwell
I've committed this to gomp4 branch. It reduces the delta from trunk by removing unneeded code and porting some changes that occurred on the route to my recent merge of code to trunk. nathan 2015-10-28 Nathan Sidwell * target.def (goacc.fork_join): Invert sense of result. * doc/tm.texi:

Re: Fix for PR sanitize/65000 introduces an unusual gcc_assert

2015-10-28 Thread Richard Biener
On October 28, 2015 7:07:54 PM GMT+01:00, Richard Henderson wrote: >On 10/28/2015 10:47 AM, Alexander Monakov wrote: >> Hello Richard, >> >> Your commit to fix PR 65000 (pasted below) introduced >>gcc_assert (ri = (int)ri); >> >> I'm unclear what is meant there; if equality test was meant, th

Re: C++ PATCH for DR 1518 (c++/54835, c++/60417)

2015-10-28 Thread Jason Merrill
On 10/26/2015 10:47 AM, Jason Merrill wrote: On 10/25/2015 09:04 PM, Ville Voutilainen wrote: On 25 October 2015 at 22:15, Ville Voutilainen wrote: It seems to me that there's a discrepancy in handling explicit default constructors. Based on my tests, this works: struct X {explicit X() {}};

RFA (Makefiles): PATCH to include libcpp and libiberty in GCC etags

2015-10-28 Thread Jason Merrill
Periodically I try to use M-. to pull up a function from libcpp and am frustrated that it doesn't work. This patch fixes that, and throws in libiberty for good measure. I also considered using --include for the TAGS files in those directories, but that would require people to 'make TAGS' sepa

Re: [PATCH][AArch64] Fix insn types

2015-10-28 Thread Evandro Menezes
Ping. -- Evandro Menezes On 10/20/2015 11:14 AM, Evandro Menezes wrote: Kyrill, Indeed, the correct log would be: The type assigned to some insn definitions was not correct. gcc/ * config/aarch64/aarch64.md (*movhf_aarch64): Change the type of "mov %0.h[0], %1.h[0] to

Re: [PATCH][AArch64] Replace insn to zero up DF register

2015-10-28 Thread Evandro Menezes
Ping. -- Evandro Menezes On 10/20/2015 09:27 AM, Andrew Pinski wrote: On Tue, Oct 20, 2015 at 7:59 AM, Andrew Pinski wrote: On Tue, Oct 20, 2015 at 7:51 AM, Andrew Pinski wrote: On Tue, Oct 20, 2015 at 7:40 AM, Evandro Menezes wrote: In the existing targets, it seems that it's always fast

[OpenACC] internal fn folding

2015-10-28 Thread Nathan Sidwell
Richard, this patch adds folding for the new GOACC_DIM_POS and GOACC_DIM_SIZE internal functions. IIUC gimple_fold_call is the right place to add this. The size of a compute dimension is very often a compile-time constant. On the host, in particular it's 1, which means we can deduce the POS

omp-low cleanup

2015-10-28 Thread Nathan Sidwell
I've committed this as obvious. There were a couple of bits of now-redundant code I'd missed in my recent merge to trunk. nathan 2015-10-28 Nathan Sidwell * omp-low.c (MASK_GANG, MASK_WORKER, MASK_VECTOR): Delete. (extract_omp_for_data): Remove OpenACC special handling of chunking. Inde

[nvptx] some cleanups

2015-10-28 Thread Nathan Sidwell
I've committed this to trunk, cleaning up a few bits and bobs I noticed comparing with the gomp4 branch. nathan 2015-10-28 Nathan Sidwell * config/nvptx/nvptx.c (nvptx_print_operand): Remove 'd' case. (struct parallel): Update comment. (nvptx_reorg): Likewise. (nvptx_neuter): Cleanup wh

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Bernd Schmidt
On 10/28/2015 07:06 PM, Alexander Monakov wrote: On Wed, 28 Oct 2015, Bernd Schmidt wrote: Ok, so adjust the if condition for non-integral types - make it false if the size of the struct is smaller than the pointer type. I'm afraid it's an insufficient fix: it would remain broken for size-12 s

[Committed] Testsuite update for MIPS16

2015-10-28 Thread Moore, Catherine
I've now committed this patch to fix a couple of target-specific failures for MIP16 multilibs. 2015-10-28 Catherine Moore * gcc.target/mips/oddspreg-3.c: Disable for MIPS16. * gcc.target/mips/oddspreg-6.c: Likewise. * gcc.target/mips/oddspreg-1.c: Likewise. * g

Re: Fix for PR sanitize/65000 introduces an unusual gcc_assert

2015-10-28 Thread Richard Henderson
On 10/28/2015 10:47 AM, Alexander Monakov wrote: Hello Richard, Your commit to fix PR 65000 (pasted below) introduced gcc_assert (ri = (int)ri); I'm unclear what is meant there; if equality test was meant, that looks suspicious to me because truncating conversion is implementation-defined.

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Alexander Monakov
On Wed, 28 Oct 2015, Bernd Schmidt wrote: > Ok, so adjust the if condition for non-integral types - make it false if the > size of the struct is smaller than the pointer type. I'm afraid it's an insufficient fix: it would remain broken for size-12 structs (containing 3 int fields, for example): th

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Bernd Schmidt
On 10/28/2015 06:51 PM, Alexander Monakov wrote: On Wed, 28 Oct 2015, Bernd Schmidt wrote: I didn't quite get why you felt a need to change this? Your previous mail didn't seem to include a testcase, just that you get "the desired behaviour". Hm? I said, There's another issue with handlin

[PATCH 4c] Other changes: everything apart from diagnostic-show-locus.c changes

2015-10-28 Thread David Malcolm
Reimplement diagnostic_show_locus, introducing rich_location classes. gcc/ChangeLog: * diagnostic-color.c (color_dict): Eliminate "caret"; add "range1" and "range2". (parse_gcc_colors): Update comment to describe default GCC_COLORS. * diagnostic-core.h (warning_at_r

[PATCH 4a] diagnostic-show-locus.c changes: Deletions

2015-10-28 Thread David Malcolm
gcc/ChangeLog: * diagnostic-show-locus.c (adjust_line): Delete. (diagnostic_print_caret_line): Delete. --- gcc/diagnostic-show-locus.c | 102 1 file changed, 102 deletions(-) diff --git a/gcc/diagnostic-show-locus.c b/gcc/diagnostic-sho

[PATCH 4b] diagnostic-show-locus.c changes: Insertions

2015-10-28 Thread David Malcolm
gcc/ChangeLog: * diagnostic-show-locus.c (struct point_state): New struct. (class colorizer): New class. (class layout_point): New class. (class layout_range): New class. (class layout): New class. (colorizer::colorizer): New ctor. (colorizer:

Re: [PATCH 04/10] Reimplement diagnostic_show_locus, introducing rich_location classes (v5)

2015-10-28 Thread David Malcolm
On Tue, 2015-10-27 at 17:02 -0600, Jeff Law wrote: > On 10/23/2015 02:41 PM, David Malcolm wrote: > > The change since v4 can be seen at: > > > > https://dmalcolm.fedorapeople.org/gcc/2015-10-23/0001-Add-colorize_source_p-to-diagnostic_context.patch > > which is a tweak to colorization, to handl

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Alexander Monakov
On Wed, 28 Oct 2015, Bernd Schmidt wrote: > On 10/28/2015 06:34 PM, Alexander Monakov wrote: > > I didn't; a simple test exercising pointer fields appears to fail, indeed. > > So > > what's the way forward here? > > I didn't quite get why you felt a need to change this? Your previous mail > did

Fix for PR sanitize/65000 introduces an unusual gcc_assert

2015-10-28 Thread Alexander Monakov
Hello Richard, Your commit to fix PR 65000 (pasted below) introduced gcc_assert (ri = (int)ri); I'm unclear what is meant there; if equality test was meant, that looks suspicious to me because truncating conversion is implementation-defined. Can you please comment? (I found this after noticing

Re: [PATCH][auto-inc-dec.c] Account for cost of move operation in FORM_PRE_ADD and FORM_POST_ADD cases

2015-10-28 Thread Kyrill Tkachov
On 28/10/15 17:23, Christophe Lyon wrote: Hi Kyrill, Hi Christophe, On 26 October 2015 at 12:52, Kyrill Tkachov wrote: On 26/10/15 11:28, Bernd Schmidt wrote: On 10/26/2015 12:12 PM, Bernd Schmidt wrote: But isn't that balanced by the fact that it doesn't seem to take into account the

Re: [Patch, avr] Fix PR 67839 - bit addressable instructions generated for out of range addresses

2015-10-28 Thread Denis Chertykov
2015-10-28 9:28 GMT+03:00 Senthil Kumar Selvaraj : > > Ping! > > Regards > Senthil > On Fri, Oct 16, 2015 at 03:17:17PM +0530, Senthil Kumar Selvaraj wrote: > > Ping! > > > > Regards > > Senthil > > > > On Mon, Oct 05, 2015 at 02:30:58PM +0530, Senthil Kumar Selvaraj wrote: > > > Hi, > > > > > >

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Bernd Schmidt
On 10/28/2015 06:34 PM, Alexander Monakov wrote: I didn't; a simple test exercising pointer fields appears to fail, indeed. So what's the way forward here? I didn't quite get why you felt a need to change this? Your previous mail didn't seem to include a testcase, just that you get "the desir

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Alexander Monakov
On Wed, 28 Oct 2015, Bernd Schmidt wrote: > On 10/28/2015 05:54 PM, Alexander Monakov wrote: > > --- a/gcc/config/nvptx/nvptx.c > > +++ b/gcc/config/nvptx/nvptx.c > > @@ -1893,7 +1893,7 @@ init_output_initializer (FILE *file, const char *name, > > const_tree type, > > && TREE_CODE (type

[PATCH][AArch64] Avoid emitting zero immediate as zero register

2015-10-28 Thread Wilco Dijkstra
Several instructions accidentally emit wzr/xzr even when the pattern specifies an immediate. Fix this by removing the register specifier in patterns that emit immediates. Passes regression tests. OK for commit? ChangeLog: 2015-10-28 Wilco Dijkstra * gcc/config/aarch64/aarch64.md (cc

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-28 Thread Jeff Law
On 10/28/2015 10:43 AM, Joseph Myers wrote: Why is -fsso-struct= listed only for C and C++, not ObjC and ObjC++? Almost all C options should be supported for ObjC and almost all C++ options should be supported for ObjC++ (and the existing cases that aren't in c.opt generally look dubious). I miss

Re: [PATCH][auto-inc-dec.c] Account for cost of move operation in FORM_PRE_ADD and FORM_POST_ADD cases

2015-10-28 Thread Christophe Lyon
Hi Kyrill, On 26 October 2015 at 12:52, Kyrill Tkachov wrote: > > On 26/10/15 11:28, Bernd Schmidt wrote: >> >> On 10/26/2015 12:12 PM, Bernd Schmidt wrote: >>> >>> >>> But isn't that balanced by the fact that it doesn't seem to take into >>> account the gain of removing the inc_insn either? So I

Re: [PATCH] [C] fix for ICE with -g

2015-10-28 Thread Joseph Myers
I believe we now prefer to declare variables at the point of first use, so tree var_type = build_qualified_type (type, type_quals); instead of a declaration at the top of the function. OK with that change. -- Joseph S. Myers jos...@codesourcery.com

Re: [gomp4 00/14] NVPTX: further porting

2015-10-28 Thread Alexander Monakov
On Wed, 21 Oct 2015, Jakub Jelinek wrote: > On Wed, Oct 21, 2015 at 12:16:35PM +0300, Alexander Monakov wrote: > > > Of course that doesn't help the thread-limit-2.c testcase. > > > > Why not? > > Because the compiler can be configured for multiple offloading devices, > and PTX might not be th

Re: Fix 61441

2015-10-28 Thread Joseph Myers
On Tue, 13 Oct 2015, Sujoy Saraswati wrote: > Index: gcc/builtins.c > === > --- gcc/builtins.c (revision 228700) > +++ gcc/builtins.c (working copy) > @@ -7357,7 +7357,11 @@ integer_valued_real_p (tree t) > && i

[PATCH] [C] fix for ICE with -g

2015-10-28 Thread Jim Wilson
Compiling a simple testcase that defines an incomplete struct/union and then a variant of that type and then completes the struct/union gives an ICE in verify_type. palantir:2257$ cat tmp.c struct S a; const struct S b; struct S { }; palantir:2258$ ./xgcc -B./ -O -g tmp.c tmp.c:5:1: error: type va

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Bernd Schmidt
On 10/28/2015 05:54 PM, Alexander Monakov wrote: --- a/gcc/config/nvptx/nvptx.c +++ b/gcc/config/nvptx/nvptx.c @@ -1893,7 +1893,7 @@ init_output_initializer (FILE *file, const char *name, const_tree type, && TREE_CODE (type) != REAL_TYPE) || sz < 0 || sz > HOST_BITS_PER_

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-28 Thread Alexander Monakov
On Tue, 20 Oct 2015, Alexander Monakov wrote: > On Tue, 20 Oct 2015, Bernd Schmidt wrote: > > > On 10/20/2015 08:34 PM, Alexander Monakov wrote: > > > Due to special treatment of types, emitting variables of type _Bool in > > > global scope is impossible: extern references are emitted with .u8, bu

Re: [Boolean Vector, patch 1/5] Introduce boolean vector to be used as a vector comparison type

2015-10-28 Thread Bill Schmidt
On Wed, 2015-10-28 at 14:44 +0100, Christophe Lyon wrote: > Hi, > > Since r229128, I see: > FAIL: c-c++-common/torture/vector-compare-1.c -O0 execution test > on arm targets, such as arm-none-eabi. Likewise for powerpc64le-linux-gnu. The test produces: 0 != ((1.00 > 0.00 ? -1 : 0) FA

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-28 Thread Joseph Myers
Why is -fsso-struct= listed only for C and C++, not ObjC and ObjC++? Almost all C options should be supported for ObjC and almost all C++ options should be supported for ObjC++ (and the existing cases that aren't in c.opt generally look dubious). -- Joseph S. Myers jos...@codesourcery.com

RE: [RFA] Compact EH Patch

2015-10-28 Thread Matthew Fortune
> This patch implements a more compact format for exception handling data. > Although I don't > have recent numbers for the amount of compression achieved, an earlier > measurement showed > a 30% reduction in the size of EH data for libstdc++. > > A design document detailing the new format is a

Re: [OpenACC] declare directive

2015-10-28 Thread James Norris
Cesar, On 10/28/2015 11:32 AM, Cesar Philippidis wrote: On 10/27/2015 01:18 PM, James Norris wrote: > This patch adds the processing of OpenACC declare directive in C > and C++. (Note: Support in Fortran is already in trunk.) > Commentary on the changes is included as an attachment

Re: [OpenACC] declare directive

2015-10-28 Thread Cesar Philippidis
On 10/27/2015 01:18 PM, James Norris wrote: > This patch adds the processing of OpenACC declare directive in C > and C++. (Note: Support in Fortran is already in trunk.) > Commentary on the changes is included as an attachment (NOTES). A quick diff of gomp4 and trunk reveals quite a f

Re: [PATCH 6/9] ENABLE_CHECKING refactoring: generators

2015-10-28 Thread Jeff Law
On 10/21/2015 04:49 AM, Richard Biener wrote: On Mon, Oct 19, 2015 at 1:55 AM, Mikhail Maltsev wrote: On 10/06/2015 03:56 PM, Richard Biener wrote: The generators should simply unconditionally check (not in generated files, of course). And the generated code parts should use flag_checking. Ri

Re: [PATCH, 1/6] Simplify constraint handling

2015-10-28 Thread Tom de Vries
On 28/10/15 16:35, Richard Biener wrote: On Tue, 27 Oct 2015, Tom de Vries wrote: On 27/10/15 13:24, Tom de Vries wrote: Thinking it over a bit more, I realized the constraint handling started to be messy. I've reworked the patch series to simplify that first. 1Simplify constraint

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-10-28 Thread Marcus Shawcroft
On 23 October 2015 at 13:34, H.J. Lu wrote: > On Fri, Oct 23, 2015 at 4:54 AM, Marcus Shawcroft > wrote: >> Hi, >> >> This patch breaks the distinction between build and host. For example >> consider a configure along these lines: >> >> ./configure --host=aarch64-none-linux-gnu >> --target=aarch6

Re: [PATCH 09/16] Add test-gimple.c to unittests

2015-10-28 Thread Jeff Law
On 10/28/2015 06:39 AM, Richard Biener wrote: On Wed, Oct 28, 2015 at 1:34 PM, Richard Biener wrote: On Tue, Oct 27, 2015 at 8:49 PM, David Malcolm wrote: gcc/testsuite/ChangeLog: * unittests/test-gimple.c: New file. I fear that keeping tests like this up-to-date and working is more of a he

Re: [PATCH 00/16] Unit tests framework (v3)

2015-10-28 Thread Jeff Law
On 10/27/2015 01:48 PM, David Malcolm wrote: This is a followup to these proposals: * v1: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00765.html * v2: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01224.html The following patch kit adds a unit tests framework for gcc, as a new subdirectory

[wwwdocs] /software/gcc - Fix HTTP 500 internal server error

2015-10-28 Thread Lisa Marie Maginnis
Hello, This commit is breaking http://gcc.gnu.org/software/gcc: revision 1.35 date: 2015/10/23 15:57:49; author: fche; state: Exp; lines: +3 -0 .htaccess +Index for ftp redirection This is because setting `Options' is denied by the apac

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-10-28 Thread Richard Biener
On Tue, Oct 27, 2015 at 1:50 AM, kugan wrote: > > > On 23/10/15 01:23, Richard Biener wrote: >> >> On Thu, Oct 22, 2015 at 12:50 PM, Kugan >> wrote: >>> >>> >>> >>> On 21/10/15 23:45, Richard Biener wrote: On Tue, Oct 20, 2015 at 10:03 PM, Kugan wrote: > > > > On 0

Re: [PATCH, 2/6] Rename make_restrict_var_constraints to make_param_constraints

2015-10-28 Thread Richard Biener
On Tue, 27 Oct 2015, Tom de Vries wrote: > On 27/10/15 13:24, Tom de Vries wrote: > > Thinking it over a bit more, I realized the constraint handling started > > to be messy. I've reworked the patch series to simplify that first. > > > > 1Simplify constraint handling > > 2Rena

Re: [mask-load, patch 1/2] Use boolean predicate for masked loads and store

2015-10-28 Thread Ilya Enkovich
On 23 Oct 13:36, Ilya Enkovich wrote: > 2015-10-23 13:32 GMT+03:00 Richard Biener : > > > > No, we'd get > > > > mask_1 = bool != 1; > > > > and the 'mask' variable should have been simplified to 'bool' > > (yes, we'd insert a dead stmt). gimple_build simplifies > > stmts via the match-and-simpl

Re: [PATCH, 1/6] Simplify constraint handling

2015-10-28 Thread Richard Biener
On Tue, 27 Oct 2015, Tom de Vries wrote: > On 27/10/15 13:24, Tom de Vries wrote: > > Thinking it over a bit more, I realized the constraint handling started > > to be messy. I've reworked the patch series to simplify that first. > > > > 1Simplify constraint handling > > 2Rena

Re: [gomp4] fortran cleanups and c/c++ loop parsing backport

2015-10-28 Thread Cesar Philippidis
On 10/28/2015 04:00 AM, Thomas Schwinge wrote: > Hi Cesar! > > On Tue, 27 Oct 2015 11:36:10 -0700, Cesar Philippidis > wrote: >> This patch contains the following: >> >> * C front end changes from trunk: >> https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02528.html >> >> * C++ front end ch

Re: [PATCH] Use signed boolean type for boolean vectors

2015-10-28 Thread Ilya Enkovich
2015-10-28 18:21 GMT+03:00 Richard Biener : > On Wed, Oct 28, 2015 at 2:13 PM, Ilya Enkovich wrote: >> Hi, >> >> Testing boolean vector conversions I found several runtime regressions >> and investigation showed it's due to incorrect conversion caused by >> unsigned boolean type. When boolean vec

Re: [PATCH] Optional escaped commas in macros

2015-10-28 Thread Daniel Gutson
On Wed, Oct 28, 2015 at 11:58 AM, Joseph Myers wrote: > On Wed, 28 Oct 2015, Daniel Gutson wrote: > >> I presented the issue in the WG21 std-proposal mailing list and the general >> consensus was that I should ask WG14 first. The problem is that this issue >> is C++ only so I'm kind of stuck. Anyw

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-28 Thread Richard Biener
On Tue, Oct 27, 2015 at 4:30 PM, Martin Liška wrote: > On 10/27/2015 03:49 PM, Richard Biener wrote: >> On Tue, Oct 27, 2015 at 1:36 PM, Martin Liška wrote: >>> On 10/26/2015 02:48 PM, Richard Biener wrote: On Thu, Oct 22, 2015 at 1:02 PM, Martin Liška wrote: > On 10/21/2015 04:06 PM, R

Re: [PATCH] Use signed boolean type for boolean vectors

2015-10-28 Thread Richard Biener
On Wed, Oct 28, 2015 at 2:13 PM, Ilya Enkovich wrote: > Hi, > > Testing boolean vector conversions I found several runtime regressions > and investigation showed it's due to incorrect conversion caused by > unsigned boolean type. When boolean vector is represented as an > integer vector on target

Re: [PATCH] Improving alias dumps

2015-10-28 Thread Tom de Vries
On 28/10/15 14:01, Richard Biener wrote: On Wed, Oct 28, 2015 at 1:04 PM, Tom de Vries wrote: On 26/10/15 14:29, Richard Biener wrote: On Mon, Oct 26, 2015 at 1:26 PM, Tom de Vries wrote: Hi, After spending some time looking at ealias/pta dumps, I realized that they're hard to understand

Re: [PATCH] Optional escaped commas in macros

2015-10-28 Thread Joseph Myers
On Wed, 28 Oct 2015, Daniel Gutson wrote: > I presented the issue in the WG21 std-proposal mailing list and the general > consensus was that I should ask WG14 first. The problem is that this issue > is C++ only so I'm kind of stuck. Anyway I already asked the convener about > this (David Keaton) a

Re: [ping] Re: Fix PR debug/66728

2015-10-28 Thread Ulrich Weigand
Bernd Schmidt wrote: > This is all a bit html mangled, but this and the other change in > loc_descriptor seem to have the effect of doing nothing when called with > BLKmode. What is the desired effect of this on the debug information, > and how is it achieved? Sorry for the mangling caused by

Re: [Boolean Vector, patch 1/5] Introduce boolean vector to be used as a vector comparison type

2015-10-28 Thread James Greenhalgh
On Fri, Oct 02, 2015 at 02:59:21PM +0100, Ilya Enkovich wrote: > Hi, > > This patch starts the first series to introduce vec as a vector > comparison type. This series introduces the new vec type and force its > usage for all vector comparisons. This series doesn't intoroduce any new > vectoriza

Re: [PATCH] Fix Fortran FP classification/compare builtin folding

2015-10-28 Thread Tobias Burnus
Richard Biener wrote: > The following fixes missed constant folding of __builtin_signbit and > friends. The first issue is that the calls were never detected as > having compatible arguments because the FE builds the function > types in a wrong way (they should be variadic but have 'void', > even

Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-10-28 Thread Ramana Radhakrishnan
> > This thread seems destined to cause typos and finger slips... > > if (!REG_P (callee) > && ((GET_CODE (callee) != SYMBOL_REF) >|| aarch64_is_noplt_call_p (callee))) > > Obviously :). Sigh, Yeah it is one of those patches. Applied to trunk with the changes. Ramana

Re: [PATCH] Optional escaped commas in macros

2015-10-28 Thread Daniel Gutson
On Tue, Oct 27, 2015 at 7:30 PM, Joseph Myers wrote: Hello Joseph. > On Tue, 27 Oct 2015, Andres Tiraboschi wrote: > >> While we start a discussion with the C committee regarding the standarization >> of this feature, we think that this is a useful nonstandard addition to be >> early adopted. >

Re: [OpenACC 11/11] execution tests

2015-10-28 Thread Nathan Sidwell
On 10/21/15 13:16, Nathan Sidwell wrote: On 10/21/15 16:14, Ilya Verbin wrote: <11-trunk-tests.patch> Does the testcase with offload IR appear here accidentally? D'oh! yup, fixed. Now all applied, Thanks for everybody's help. nathan

[PATCH] Fix Fortran FP classification/compare builtin folding

2015-10-28 Thread Richard Biener
The following fixes missed constant folding of __builtin_signbit and friends. The first issue is that the calls were never detected as having compatible arguments because the FE builds the function types in a wrong way (they should be variadic but have 'void', even multiple!, arguments). The sec

Re: [OpenACC 2/11] PTX backend changes

2015-10-28 Thread Nathan Sidwell
This is the patch I've just committed. It includes the new target hook overriding, which was originally in patch 3. nathan 2015-10-28 Nathan Sidwell * config/nvptx/nvptx.h (struct machine_function): Add axis_predicate. * config/nvptx/nvptx-protos.h (nvptx_expand_oacc_fork, nvptx_expand_o

Re: [ping] Re: Fix PR debug/66728

2015-10-28 Thread Bernd Schmidt
On 10/28/2015 02:06 PM, Richard Sandiford wrote: Ulrich Weigand writes: seems this still hasn't gone upstream ... Any news? Ah, sorry, I should have been pinging it. I think it's still waiting for review. Hmm, unfortunately I have a hard time making sense of this patch. Some extra explan

RE: [PATCH, Mips] Compact branch/delay slot optimization.

2015-10-28 Thread Moore, Catherine
> -Original Message- > From: Simon Dardis [mailto:simon.dar...@imgtec.com] > Sent: Tuesday, October 06, 2015 10:00 AM > To: Moore, Catherine; Matthew Fortune > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH, Mips] Compact branch/delay slot optimization. > > Hello, > > I'd like to res

[PATCH] Fix gcc.dg/tree-ssa/operand-equal-2.c testcase

2015-10-28 Thread Richard Biener
forwprop1 cannot handle it (it requires to CSE the two vector initializers first). fre1 can do that but due to an oversight in gimple_simplify it didn't. Fixed thus. Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2015-10-28 Richard Biener * gimple-match-head.c (

Re: [Boolean Vector, patch 1/5] Introduce boolean vector to be used as a vector comparison type

2015-10-28 Thread Christophe Lyon
Hi, Since r229128, I see: FAIL: c-c++-common/torture/vector-compare-1.c -O0 execution test on arm targets, such as arm-none-eabi. Christophe.

[PATCH] Fix PR67600 testcase

2015-10-28 Thread Richard Biener
Remove the 600k preprocessed headers. tested on x86_64 with -m32 and -m64, committed. Richard. 2015-10-28 Richard Biener * g++.dg/torture/pr67600.C: Remove preprocessed headers in favor of #includes.

Re: [PATCH] Fix PR68067

2015-10-28 Thread Richard Biener
On Tue, 27 Oct 2015, Richard Biener wrote: > On Tue, 27 Oct 2015, Richard Biener wrote: > > > > > The following patch adjusts negate_expr_p to account for the fact > > that we can't generally change a - (b - c) to (c - b) + a because > > -INF - 0 is ok while 0 - -INF not. Similarly for a - (b +

Re: [PATCH][RFC][tree-ifcombine] Making tree-ifcombine more friendly for conditional comparisons generation

2015-10-28 Thread Richard Biener
On Wed, 28 Oct 2015, Kyrill Tkachov wrote: > Hi all, > > This is a follow up to the thread at > https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01646.html > I'm trying to increase the utilisation of conditional compare instructions on > aarch64 and I've identified > tree ifcombine as a place that i

[PATCH] Use signed boolean type for boolean vectors

2015-10-28 Thread Ilya Enkovich
Hi, Testing boolean vector conversions I found several runtime regressions and investigation showed it's due to incorrect conversion caused by unsigned boolean type. When boolean vector is represented as an integer vector on target it's a signed integer actually. Unsigned boolean type was chosen

Re: [ping] Re: Fix PR debug/66728

2015-10-28 Thread Richard Sandiford
Ulrich Weigand writes: > Hi Richard, > > seems this still hasn't gone upstream ... Any news? Ah, sorry, I should have been pinging it. I think it's still waiting for review. Thanks, Richard >> This is yet another bug caused by rtx having modeless scalar integer >> constants. We need to use c

Re: [PATCH] Improving alias dumps

2015-10-28 Thread Richard Biener
On Wed, Oct 28, 2015 at 1:04 PM, Tom de Vries wrote: > On 26/10/15 14:29, Richard Biener wrote: >> >> On Mon, Oct 26, 2015 at 1:26 PM, Tom de Vries >> wrote: >>> >>> Hi, >>> >>> After spending some time looking at ealias/pta dumps, I realized that >>> they're hard to understand because we use var

Re: [PATCH 00/16] Unit tests framework (v3)

2015-10-28 Thread Bernd Schmidt
On 10/28/2015 12:38 PM, Bernd Schmidt wrote: * This uses a plugin into whatever compiler was built, but sometimes you can't really set up unit tests that way because what you want to test depends on target specifics. What I've often wanted is a special test target that gets built wi

  1   2   >