Re: Backport important ASan features from upstream.

On Thu, Nov 19, 2015 at 11:19:23AM +0300, Maxim Ostapenko wrote: > Hi! > > Since the last sanitizer library merge to GCC happened, some new useful > features were applied upstream. In particular, the most significant are: > > * The shadow offset for ASan was unified on Aarch64 for 39 and 42 VMAs

[PATCH][combine] PR rtl-optimization/68381: Only restrict pure simplification in mult-extend subst case, allow other substitutions

Hi all, In this PR we end up removing a widening multiplication. I suspect it's some path in combine that doesn't handle the case where we return clobber of 0 properly. This started with my recent combine patch r230326. Changing the subst hunk from that patch to just return x when handling a

Re: [PATCH][RTL-ree] PR rtl-optimization/68194: Restrict copy instruction in presence of conditional moves

On 18/11/15 09:11, Kyrill Tkachov wrote: On 17/11/15 23:11, Bernd Schmidt wrote: On 11/17/2015 02:03 PM, Kyrill Tkachov wrote: + || !reg_overlap_mentioned_p (tmp_reg, SET_SRC (PATTERN (cand->insn return false; Well, I think the statement we want to make is "return false from

Re: [PATCH] Add clang-format config to contrib folder

On 11/19/2015 12:09 AM, Sebastian Pop wrote: Martin, thanks for getting this patch out. I like the patch. Jeff, clang-format has scripts that allow formatting only the lines touched by a patch. It also has a script to integrate with git:

Backport important ASan features from upstream.

Hi! Since the last sanitizer library merge to GCC happened, some new useful features were applied upstream. In particular, the most significant are: * The shadow offset for ASan was unified on Aarch64 for 39 and 42 VMAs (http://reviews.llvm.org/D13782). AFAU, this change wouldn't require any

Re: [PATCH] Avoid useless work in loop vectorization

On Wed, 18 Nov 2015, Alan Lawrence wrote: > On 13/11/15 08:41, Richard Biener wrote: > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > > > > Richard. > > > > 2015-11-13 Richard Biener > > > > * tree-vect-loop.c (vect_analyze_loop_2):

[PATCH] Fix PR68117

I'm reverting an earlier change removing the redirect_edge_var_map_destroy call from delete_tree_ssa. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-11-19 Richard Biener PR middle-end/68117 * tree-ssa.c (delete_tree_ssa):

Re: [PATCH] [4.9] Re: [PATCH][5] Backport ISL 0.15 support

On Wed, 18 Nov 2015, Matthias Klose wrote: > On 12.10.2015 12:58, Richard Biener wrote: > > > > This backports the patch to allow bootstrapping with ISL 0.15 to the > > GCC 5 branch (the GCC 4.9 branch will require backporting of some > > dependencies). > > I don't think so. 4.8 and 4.9 don't

Re: [PATCH, PR68373 ] Call scev_const_prop in pass_parallelize_loops::execute

On 17/11/15 23:20, Tom de Vries wrote: [ was: Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def ] Hi, Consider test-case test.c, with a use of the final value of the iteration variable (return i): ... unsigned int foo (int *a, unsigned int n) { unsigned int i; for (i = 0;

Re: Backport important ASan features from upstream.

On 11/19/2015 11:36 AM, Andrew Pinski wrote: On Nov 19, 2015 12:19 AM, "Maxim Ostapenko" wrote: Hi! Since the last sanitizer library merge to GCC happened, some new useful features were applied upstream. In particular, the most significant are: * The

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

On 11/19/2015 01:50 AM, Joseph Myers wrote: I don't think all the reformattings here are things we want to do globally for most source files. E.g. @@ -75,18 +74,17 @@ get_mask_first_set_bit (unsigned mask) static bool has_undefined_value_p (tree t) { - return (ssa_undefined_value_p (t)

Re: PATCH to shorten_compare -Wtype-limits handling

On 11/18/2015 09:26 PM, Jason Merrill wrote: The rs6000 target was hitting a bootstrap failure due to -Werror=type-limits. Since warn_tautological_cmp and other warnings avoid warning if one of the operands comes from a macro, I thought it would make sense to do that here as well. The also

Re: RFC/RFA: Fix bug with REE optimization corrupting extended registers

On 11/19/2015 10:18 AM, Bernd Schmidt wrote: On 11/19/2015 06:06 PM, Jeff Law wrote: Frankly, the overall structure of ree is a mess -- I've found it incredibly difficult to follow every time I've had to look at it. Yeah, no kidding. The check seems to be in the wrong place - it's done very

Re: [PATCH] Transactional Memory: Support __cxa_free_exception and fix exception handling.

On 11/18/2015 06:22 PM, Torvald Riegel wrote: The EH scheme that we had been using for TM / libitm doesn't work properly. We fail to handle throwing exceptions whose constructors may throw themselves. We also do not clean up properly in all situations when a transactions abort while being in

Re: PATCH to shorten_compare -Wtype-limits handling

On 19 November 2015 at 17:54, Jeff Law wrote: >> But there were a couple of patches from you some time ago, for >> example: http://permalink.gmane.org/gmane.comp.gcc.patches/343476 >> >> What happened with those? > > On hold pending fixing the type-limits warning placement.

Openacc reduction tests

in adding the complex double support I noticed some existing tests had commented out sequences. These were broken tests a) the multiplication reduction assumed that 0 * 99! was numerically stable in the face of arbitrary re-association. While it did guess that results might vary, it used an

Re: [C++ PATCH] Fix unexpanded pack error with auto-deduced functions (PR c++/68396)

On 11/19/2015 09:35 AM, Ryan Burn wrote: This fixes an issue where the return type of an auto-deduced function gets classified as a parameter pack if it's called in a decltype expression inside of a type expansion. Thanks! Do you have a copyright assignment on file with the FSF? This patch

Re: RFC/RFA: Fix bug with REE optimization corrupting extended registers

On 11/19/2015 08:34 AM, Nick Clifton wrote: Hi Bernd, I had a look around. There's code testing HARD_REGNO_NREGS in ree.c:combine_set_extension. It's inside #if 0, and labelled "temporarily disabled". See if enabling that helps you? (Jeff, that #if 0 was added by you). I suspect that the

Re: [C PATCH] Don't leak C_MAYBE_CONST_EXPRs into fold() (PR c/68412)

On Wed, Nov 18, 2015 at 09:14:46PM +, Joseph Myers wrote: > remove_c_maybe_const_expr doesn't seem to be quite what you want. Apart > from this not being a case covered by the comment on the function, you're > ignoring the possibility of the side effects in the > C_MAYBE_CONST_EXPR_PRE.

Re: [PATCH 01/15] Selftest framework (unittests v4)

On 11/19/2015 07:08 PM, David Malcolm wrote: gcc_assert terminates the process and no further testing is done, whereas the approach the kit tries to run as much of the testsuite as possible, and then fail if any errors occurred. Yeah, but let's say someone is working on bitmaps and one of the

Re: PATCH to shorten_compare -Wtype-limits handling

On 11/19/2015 10:48 AM, Manuel López-Ibáñez wrote: On 19 November 2015 at 17:09, Jeff Law wrote: The even longer term direction for this code is to separate out the type-limits warning from the canonicalization and shortening. I've got a blob of code form Kai that goes in

Re: [PATCH 01/15] Selftest framework (unittests v4)

On Nov 19, 2015, at 10:08 AM, David Malcolm wrote: > gcc_assert terminates the process and no further testing is done, > whereas the approach the kit tries to run as much of the testsuite as > possible, and then fail if any errors occurred. Running as much as possible is

Re: [PATCH 01/15] Selftest framework (unittests v4)

On 11/19/2015 09:44 PM, Bernd Schmidt wrote: > It's one option, but it doesn't seem like the best one either. I was > thinking of something not dissimilar to your approach, but with fewer > bells and whistles. My class registrator would look something like this: > > static list test_callbacks; >

Re: [PATCH] Fix ICE with mangling aliases (PR c++/67354, take 2)

On 11/19/2015 07:40 AM, Jakub Jelinek wrote: @@ -4502,6 +4509,7 @@ c_parse_final_cleanups (void) locus_at_end_of_parsing = input_location; at_eof = 1; + defer_mangling_aliases = false; Let's clear this in generate_mangling_aliases rather than here. OK with that change. Jason

Re: [PATCH 1/2] [graphite] Move codegen related functions to graphite-isl-ast-to-gimple.c

Fixed in r230625. David, please test on your systems, we were not able to reproduce the fails on x86_64-linux: the linker does optimize away the functions that are not used. Thanks, Sebastian Aditya K wrote: > Thanks for the update. I'll fix that asap. > > > -Aditya > > >

Re: [PATCH/RFC] C++ FE: expression ranges (v2)

On 11/15/2015 12:01 AM, David Malcolm wrote: As with the C frontend, there's an issue with tree nodes that don't have locations: VAR_DECL, INTEGER_CST, etc: int test (int foo) { return foo * 100; ^^^ ^^^ } where we'd like to access the source spelling ranges of the

[PATCH] (Partial) Implementation of simplificaiton of CSHIFT

The attached patch provides a partial implementation for the simplification for CSHIFT. It is partial in that it only applies to rank 1 arrays. For arrays with rank > 1, gfc_simplify_cshift will issue an error. Here, the intent is that hopefully someone that knows what they are doing with

Re: [PATCH][RTL-ree] PR rtl-optimization/68194: Restrict copy instruction in presence of conditional moves

I1 is def_insn, I3 is cand->insn. tmp_reg is 'ax'. What we want to do is reject this transformation because the destination of def_insn (aka I1), that is 'ax', is not the operand of the extend operation in cand->insn (aka I3). As you said, rtx_equal won't work on just SET_SRC (PATTERN

Re: [PATCH 0/5] Add support -mcpu=thunderxt88pass1 and needed changes to support that

On Thu, Nov 19, 2015 at 4:08 AM, Kyrill Tkachov wrote: > Hi Andrew, > > On 17/11/15 22:10, Andrew Pinski wrote: >> >> To Add support for -mcpu=thunderxt88pass1, I needed to fix up a few >> things in the support for -mcpu=native. First was I wanted to do the same >>

msp430: fix alignment in multiply

Minor fix, committed. 2015-11-19 DJ Delorie * config/msp430/lib2hw_mul.S: Fix alignment. Index: libgcc/config/msp430/lib2hw_mul.S === --- libgcc/config/msp430/lib2hw_mul.S (revision 230632) +++

Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT

On Thu, Nov 19, 2015 at 04:58:36PM -0800, Steve Kargl wrote: > + else > +{ > + int dm; > + > + if (dim) > + { > + if (!gfc_is_constant_expr (dim)) > + return NULL; > + > + dm = mpz_get_si (dim->value.integer); > + } > + else > + dm = 1; > + > +

[patch] Python Pretty Printers get disabled on libstdc++ reload by GDB (PR libstdc++/68448)

Hi, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68448 https://bugzilla.redhat.com/show_bug.cgi?id=1279406 echo -e '#include \nint main(){std::vector l;\nreturn 0;}'|g++ -g -Wall -x c++ -;gdb -q ./a.out -batch -ex 'b 3' -ex r -ex 'p l' -ex r -ex 'p l' Actual: [...] $1 = std::vector of length

Re: vector lightweight debug mode

Thanks for the explanation, it is much clearer. So here is a the more limited patch. Tested under Linux x86_64. Ok to commit ? François On 18/11/2015 13:27, Jonathan Wakely wrote: > On 17/11/15 20:49 +0100, François Dumont wrote: >> On 16/11/2015 11:29, Jonathan Wakely wrote: >>> Not doing

Re: [PATCH 01/15] Selftest framework (unittests v4)

On Thu, 2015-11-19 at 18:35 +0100, Bernd Schmidt wrote: > In general I'm much happier with this approach, and I think this series > is close to ready, but I want to bring up some questions that could use > wider discussion. > > This patch adds a selftest.h/.c to gcc, with an API loosely > >

Re: RFC/RFA: Fix bug with REE optimization corrupting extended registers

On 11/18/2015 07:15 AM, Nick Clifton wrote: Hi Guys, I recently discovered a bug in the current Redundant Extension Elimination optimization. If the candidate extension instruction increases the number of hard registers used, the pass does not check to see if these extra registers

Re: [C PATCH] Don't leak C_MAYBE_CONST_EXPRs into fold() (PR c/68412)

On Thu, 19 Nov 2015, Marek Polacek wrote: > On Wed, Nov 18, 2015 at 09:14:46PM +, Joseph Myers wrote: > > remove_c_maybe_const_expr doesn't seem to be quite what you want. Apart > > from this not being a case covered by the comment on the function, you're > > ignoring the possibility of

Re: [PATCH 2/4][AArch64] Increase the loop peeling limit

On 11/05/2015 02:51 PM, Evandro Menezes wrote: 2015-11-05 Evandro Menezes gcc/ * config/aarch64/aarch64.c (aarch64_override_options_internal): Increase loop peeling limit. This patch increases the limit for the number of peeled insns. With this

Re: PATCH to shorten_compare -Wtype-limits handling

On 11/19/2015 02:44 PM, Martin Sebor wrote: On 11/18/2015 09:26 PM, Jason Merrill wrote: The rs6000 target was hitting a bootstrap failure due to -Werror=type-limits. Since warn_tautological_cmp and other warnings avoid warning if one of the operands comes from a macro, I thought it would make

Re: [PATCH 4/4][AArch64] Add cost model for Exynos M1

On 11/05/2015 06:09 PM, Evandro Menezes wrote: 2015-10-25 Evandro Menezes gcc/ * config/aarch64/aarch64-cores.def: Use the Exynos M1 cost model. * config/aarch64/aarch64.c (exynosm1_addrcost_table): New variable. (exynosm1_regmove_cost):

Re: [PATCH 3a/4][AArch64] Add attribute for compatibility with ARM pipeline models

On 11/12/2015 11:32 AM, Evandro Menezes wrote: On 11/12/2015 09:39 AM, Evandro Menezes wrote: On 11/12/2015 08:55 AM, James Greenhalgh wrote: On Tue, Nov 10, 2015 at 11:50:12AM -0600, Evandro Menezes wrote: 2015-11-10 Evandro Menezes gcc/ *

Re: [PATCH 3b/4][AArch64] Add scheduling model for Exynos M1

On 11/10/2015 11:54 AM, Evandro Menezes wrote: 2015-11-10 Evandro Menezes gcc/ * config/aarch64/aarch64-cores.def: Use the Exynos M1 sched model. * config/aarch64/aarch64.md: Include "exynos-m1.md". * config/arm/arm-cores.def: Use the Exynos M1

Re: Aw: Re: TR1 Special Math

On Thu, 19 Nov 2015, Ed Smith-Rowland wrote: > Testing coverage is growing. > I starting to build check_inf tests for everyone (but they aren't in the > patch. > I'll look at musl to see how you do check_denorm, etc. FWIW, in glibc I've systematically put special cases and a representative

[PATCH] fix PR68341: correctly compute the insertion point for close phi nodes

--- gcc/graphite-isl-ast-to-gimple.c | 96 ++-- 1 file changed, 62 insertions(+), 34 deletions(-) diff --git a/gcc/graphite-isl-ast-to-gimple.c b/gcc/graphite-isl-ast-to-gimple.c index 3e0907d..91bda33 100644 --- a/gcc/graphite-isl-ast-to-gimple.c +++

Re: [PATCH] C++ FE: offer suggestions for misspelled field names

OK, thanks. Jason

Re: [PATCH][AArch64] Replace insn to zero up DF register

On 10/30/2015 05:24 AM, Marcus Shawcroft wrote: On 20 October 2015 at 00:40, Evandro Menezes wrote: In the existing targets, it seems that it's always faster to zero up a DF register with "movi %d0, #0" instead of "fmov %d0, xzr". This patch modifies the respective

[PTX] Add weak support

I've committed this patch to trunk, which adds weak symbol support to PTX. PTX supports weak definitions but not weak declarations, so some of the tests need explicitly skipping, however the overall change is for the better. I did discover a bug in the PTX JIT, in that it resolved weak

C++ PATCH for c++/68422 (sizeof... slow to evaluate)

This turns out to be because we represent sizeof... as a sizeof a pack expansion internally, and we generated a full new pack expansion one element at a time rather than just look at how many elements there were in the argument pack. We already had an optimization in tsubst_parameter_pack to

[PATCH] fix PR68428: ignore bb dominated by the scop->exit

--- gcc/graphite-scop-detection.c | 6 +- gcc/testsuite/gcc.dg/graphite/pr68428.c | 23 +++ 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/graphite/pr68428.c diff --git a/gcc/graphite-scop-detection.c

[PATCH] add testcase for PR68335

--- gcc/testsuite/gfortran.dg/graphite/pr68335.f90 | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/graphite/pr68335.f90 diff --git a/gcc/testsuite/gfortran.dg/graphite/pr68335.f90 b/gcc/testsuite/gfortran.dg/graphite/pr68335.f90

Re: libgomp: Compile-time error for non-portable gomp_mutex_t initialization

On Wed, Nov 18, 2015 at 06:19:29PM +0300, Ilya Verbin wrote: > On Fri, Sep 25, 2015 at 17:28:25 +0200, Jakub Jelinek wrote: > > On Fri, Sep 25, 2015 at 05:04:47PM +0200, Thomas Schwinge wrote: > > > On Thu, 26 Mar 2015 23:41:30 +0300, Ilya Verbin wrote: > > > > On Thu, Mar 26,

Re: [PATCH][combine] PR rtl-optimization/68381: Only restrict pure simplification in mult-extend subst case, allow other substitutions

Hi Kyrill, On Thu, Nov 19, 2015 at 10:26:25AM +, Kyrill Tkachov wrote: > In this PR we end up removing a widening multiplication. I suspect it's > some path in combine > that doesn't handle the case where we return clobber of 0 properly. That is troublesome. Could you look deeper? > This

[SPARC] Fix PR target/68408

This is the breakage of the init_priority attribute on sparc-elf, a regression from older releases in the 4.x series. Tested on sparc-elf, applied on all active branches. 2015-11-19 Eric Botcazou PR target/68408 * config/sparc/sp-elf.h

Re: [patch] Fix PR lto/61313

On 11/19/2015 01:02 PM, Eric Botcazou wrote: this fixes the glitch I introduced when trying to fix another bug: https://gcc.gnu.org/ml/gcc-patches/2012-05/msg00330.html The --with-plugin-ld value specified by the user is also stripped, although that's unnecessay to fix the original bug. So I

[PATCH] Fix ICE with mangling aliases (PR c++/67354, take 2)

On Wed, Nov 18, 2015 at 04:22:21PM -0500, Jason Merrill wrote: > On 11/18/2015 03:52 AM, Jakub Jelinek wrote: > >If changing at_eof for this is too big hack, perhaps we could have a > >different bool just to affect the mangling aliases (and set it to true > >in generate_mangling_aliases or so). >

[C++ PATCH] Issue hard error even with -fpermissive for certain goto violations (PR c++/67409, take 2)

On Thu, Nov 19, 2015 at 02:52:55AM +, Manuel López-Ibáñez wrote: > static bool > error_jumpto (diagnostic_t kind, location_t loc, tree decl) > { > bool complained = (decl >? emit_diagnostic (kind, input_location, 0, > "jump to label

Re: [PATCH] Add clang-format config to contrib folder

On 11/19/2015 11:40 AM, Martin Liška wrote: > On 11/19/2015 12:09 AM, Sebastian Pop wrote: >> Martin, thanks for getting this patch out. I like the patch. >> Jeff, clang-format has scripts that allow formatting only the lines >> touched by a patch. >> It also has a script to integrate with git:

[patch] Fix PR lto/61313

Hi, this fixes the glitch I introduced when trying to fix another bug: https://gcc.gnu.org/ml/gcc-patches/2012-05/msg00330.html The --with-plugin-ld value specified by the user is also stripped, although that's unnecessay to fix the original bug. So I guess that we can leave this value

Re: [1/2] OpenACC routine support

On Wed, Nov 18, 2015 at 11:02:01AM -0800, Cesar Philippidis wrote: > static inline void > cp_ensure_no_oacc_routine (cp_parser *parser) > { > - cp_finalize_oacc_routine (parser, NULL_TREE, false, true); > + if (parser->oacc_routine && !parser->oacc_routine->error_seen) > +{ > + tree

Re: [PATCH 0/5] Add support -mcpu=thunderxt88pass1 and needed changes to support that

Hi Andrew, On 17/11/15 22:10, Andrew Pinski wrote: To Add support for -mcpu=thunderxt88pass1, I needed to fix up a few things in the support for -mcpu=native. First was I wanted to do the same cleanup that was done for some of the other .def files and move the #undef into the .def files

Re: Backport important ASan features from upstream.

On 19/11/15 13:18, Jakub Jelinek wrote: On Thu, Nov 19, 2015 at 11:19:23AM +0300, Maxim Ostapenko wrote: Hi! Since the last sanitizer library merge to GCC happened, some new useful features were applied upstream. In particular, the most significant are: * The shadow offset for ASan was

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

On 16/11/15 13:45, Richard Biener wrote: I've eliminated all the uses for pass_tree_loop_init/pass_tree_loop_done in >the pass group. Instead, I've added conditional loop optimizer setup in: >- pass_lim and pass_scev_cprop (added in this patch), and Reposting the "Add pass_oacc_kernels pass

Re: [PATCH,RFC] Introduce RUN_UNDER_VALGRIND in test-suite

On 2015.11.19 at 15:38 +0100, Martin Liška wrote: > > In last two weeks I've removed couple of memory leaks, mainly tight to > middle-end. Currently, a user of the GCC compiler can pass > '--enable-checking=valgrind' configure option that will run all > commands within valgrind environment, but

Re: [PATCH] [4.9] Re: [PATCH][5] Backport ISL 0.15 support

On 19.11.2015 09:07, Richard Biener wrote: On Wed, 18 Nov 2015, Matthias Klose wrote: On 12.10.2015 12:58, Richard Biener wrote: This backports the patch to allow bootstrapping with ISL 0.15 to the GCC 5 branch (the GCC 4.9 branch will require backporting of some dependencies). I don't

Re: [PATCH] Simple optimization for MASK_STORE.

Hi Richard, I send you updated version of patch which contains fixes you mentioned and additional early exit in register_edge_assert_for() for gcond with vector comparison - it tries to produce assert for if (vect != {0,0,0,0}) but can't create such constant. This is not essential since this is

[PATCH; committed] Fix typo in doc/gty.texi

Committed to trunk (as r230609) as obvious, having verified that the docs build. gcc/ChangeLog: * doc/gty.texi (Support for inheritance): Fix missing parentheses in example. --- gcc/doc/gty.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH][combine] PR rtl-optimization/68381: Only restrict pure simplification in mult-extend subst case, allow other substitutions

On 19/11/15 15:00, Kyrill Tkachov wrote: On 19/11/15 14:41, Segher Boessenkool wrote: On Thu, Nov 19, 2015 at 01:38:53PM +, Kyrill Tkachov wrote: That is troublesome. Could you look deeper? Yes. Thanks. So the bad case is when we're in subst and returning a CLOBBER of zero and

Re: [C++ PATCH] Issue hard error even with -fpermissive for certain goto violations (PR c++/67409, take 2)

OK. Jason

Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT

On Thu, Nov 19, 2015 at 05:31:32PM -0800, Steve Kargl wrote: > On Thu, Nov 19, 2015 at 04:58:36PM -0800, Steve Kargl wrote: > > + else > > +{ > > + int dm; > > + > > + if (dim) > > + { > > + if (!gfc_is_constant_expr (dim)) > > + return NULL; > > + > > + dm =

Re: [PATCH 1/2] [graphite] Move codegen related functions to graphite-isl-ast-to-gimple.c

The patch fixed the bootstrap failure. Thanks, David On Thu, Nov 19, 2015 at 3:37 PM, Sebastian Pop wrote: > Fixed in r230625. > > David, please test on your systems, we were not able to reproduce the fails on > x86_64-linux: the linker does optimize away the functions that

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

BTW, I'm with whoever said absolutely no way to the idea of making automatic changes like this as part of a commit hook. I think the whitespace change can go in if it hasn't already, but I think the other one still has enough problems that I'll say - leave it for the next stage 1. @@

Fix -fno-checking segfault

Hi, in an enabled-checking compiler gcc_checking_assert is always executed. If that depends on things having happened under flag_checking being true, but it's actually false during runtime due to -fno-checking things go awry, like segfaulting in this case. The fix is obvious and checked in

Re: Fix -fno-checking segfault

Hi Michael, On 19/11/15 16:13, Michael Matz wrote: Hi, in an enabled-checking compiler gcc_checking_assert is always executed. If that depends on things having happened under flag_checking being true, but it's actually false during runtime due to -fno-checking things go awry, like segfaulting

Re: OpenACC declare directive updates

Jakub, Here's the updated version of the Fortran changes. More test cases have been added as well as the issues that Cesar pointed on in error checking have been addressed (Thanks). I've also addressed the issue, described below, in dealing with declare directives when found within a BLOCK

update acc routines in fortran

This patch extends the existing support for acc routines in fortran. It's a little bit more invasive than what I remembered, but it's still fairly straightforward. Basically, it adds support for the following: - name routines - gang, worker, vector and seq clauses In addition, I've also taught

[PATCH, PR68337] Don't fold memcpy/memmove we want to instrument

Hi, Currently we fold all memcpy/memmove calls with a known data size. It causes two problems when used with Pointer Bounds Checker. The first problem is that we may copy pointers as integer data and thus loose bounds. The second problem is that if we inline memcpy, we also have to inline bounds

[PATCH] fix vectorizer performance problem on cygwin hosted cross compiler

A cygwin hosted cross compiler to aarch64-linux, compiling a C version of linpack with -Ofast, produces code that runs 17% slower than a linux hosted compiler. The problem shows up in the vect dump, where some different vectorization optimization decisions were made by the cygwin compiler than

Re: [PATCH] S/390: Clobber r1 in patterns resulting in pfpo instruction.

On 11/18/2015 03:35 PM, Dominik Vogt wrote: > The attached patch fixes the S/390 patterns using the "pfpo" > instruction in s390.md. The instructions clobber r1, but the > patterns did not reflect that. Good catch! Your testcase requires -mzarch in the options to enable pfpo with -m31 as well.

Re: [gomp4.5] Handle #pragma omp declare target link

On Mon, Nov 16, 2015 at 06:40:43PM +0300, Ilya Verbin wrote: > Here is WIP patch, not for check-in. There are still many FIXMEs, which I am > going to resolve, however target-link-1.c testcase pass. > Is this approach correct? Any comments on FIXMEs? > > > diff --git a/gcc/c/c-parser.c

Re: [PATCH] Allow embedded timestamps by C/C++ macros to be set externally (2)

On 11/17/2015 12:26 AM, Joseph Myers wrote: > fprintf to stderr is never appropriate. All diagnostics should go through > a diagnostic function that properly causes the message to be translated. > > If you want a fatal error (exit immediately after giving the message > rather than continuing

Re: [PATCH] Get rid of insn-codes.h in optabs-tree.c

On 11/19/2015 03:28 PM, Ilya Enkovich wrote: This is a refactoring patch discussed in another thread [1]. It gets rid of CODE_FOR_nothing usage in optabs-tree.c by introducing boolean predicated in optabs-query. Bootstrapped and regtesed on x86_64-unknown-linux-gnu. Looks pretty reasonable,

Re: [PATCH] Implement GOMP_OFFLOAD_unload_image in intelmic plugin

On Thu, Nov 19, 2015 at 06:47:28PM +0300, Ilya Verbin wrote: > I will add this: > > diff --git a/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > b/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > index 6ee585e..f8c1725 100644 > --- a/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > +++

Re: RFC/RFA: Fix bug with REE optimization corrupting extended registers

Hi Bernd, I had a look around. There's code testing HARD_REGNO_NREGS in ree.c:combine_set_extension. It's inside #if 0, and labelled "temporarily disabled". See if enabling that helps you? (Jeff, that #if 0 was added by you). I suspect that the code was disabled because it prevented too many

Re: [PATCH] Allow embedded timestamps by C/C++ macros to be set externally (2)

On 11/19/2015 04:35 PM, Dhole wrote: > On 11/17/2015 12:26 AM, Joseph Myers wrote: >> fprintf to stderr is never appropriate. All diagnostics should go through >> a diagnostic function that properly causes the message to be translated. >> >> If you want a fatal error (exit immediately after

Re: [PATCH] Transactional Memory: Support __cxa_free_exception and fix exception handling.

On Thu, 2015-11-19 at 09:35 -0600, Torvald Riegel wrote: > The EH scheme that we had been using for TM / libitm doesn't work > properly. We fail to handle throwing exceptions whose constructors may > throw themselves. We also do not clean up properly in all situations > when a transactions abort

Re: [PATCH] Implement GOMP_OFFLOAD_unload_image in intelmic plugin

On Thu, Nov 19, 2015 at 14:33:06 +0100, Jakub Jelinek wrote: > On Mon, Nov 16, 2015 at 08:33:28PM +0300, Ilya Verbin wrote: > > diff --git a/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > > b/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > > index 772e198..6ee585e 100644 > > ---

Re: [PATCH] Add clang-format config to contrib folder

On Wed, 18 Nov 2015, Jeff Law wrote: > Given that gnu-indent seems to muck up C++ badly in my > experience, clang-format may be a better long term solution. I'd really like > to get to a point one day where formatting is a commit hook so that things are > always kept properly formatted. I hope

Re: [OpenACC 0/7] host_data construct

On Thu, Nov 19, 2015 at 02:26:50PM +, Julian Brown wrote: > OK, thanks -- as to what the standard says, it's so ill-specified in > this area that nothing can be learned about the behaviour of offloaded > regions within host_data constructs, and my question about that on the > technical mailing

Re: [PATCH] Get rid of insn-codes.h in optabs-tree.c

On 19 Nov 16:46, Bernd Schmidt wrote: > On 11/19/2015 03:28 PM, Ilya Enkovich wrote: > >This is a refactoring patch discussed in another thread [1]. It gets > >rid of CODE_FOR_nothing usage in optabs-tree.c by introducing boolean > >predicated in optabs-query. Bootstrapped and regtesed on >

[PATCH] Fix division-by-unsigned optimization in VRP (PR tree-optimization/68431)

This fixes a failure to optimize division by an unsigned. The comment before the condition I'm fixing says "When vr0.max < 0, vr1.min != 0 and ..." but "&& !compare_values (vr1.min, zero)" actually ensures that vr1.min is zero. (Indeed, the following int_const_binop would attemp to divide by zero

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

On 11/19/2015 02:58 PM, Bernd Schmidt wrote: > On 11/19/2015 11:16 AM, Martin Liška wrote: >> You are right, however as the original coding style was really broken, >> it was much easier >> to use the tool and clean-up fall-out. >> >> Waiting for thoughts related to v2. > > Better, but still some

Re: [PATCH][combine] PR rtl-optimization/68381: Only restrict pure simplification in mult-extend subst case, allow other substitutions

On 19/11/15 14:41, Segher Boessenkool wrote: On Thu, Nov 19, 2015 at 01:38:53PM +, Kyrill Tkachov wrote: That is troublesome. Could you look deeper? Yes. Thanks. So the bad case is when we're in subst and returning a CLOBBER of zero and 'from' is (reg/v:SI 80 [ x ]) and 'to' is

Re: [PATCH] Fix division-by-unsigned optimization in VRP (PR tree-optimization/68431)

On November 19, 2015 3:57:03 PM GMT+01:00, Marek Polacek wrote: >This fixes a failure to optimize division by an unsigned. The comment >before >the condition I'm fixing says "When vr0.max < 0, vr1.min != 0 and ..." >but >"&& !compare_values (vr1.min, zero)" actually ensures

RE: [PATCH 1/2] [graphite] Move codegen related functions to graphite-isl-ast-to-gimple.c

Thanks for the update. I'll fix that asap. -Aditya > Date: Thu, 19 Nov 2015 08:36:58 -0500 > Subject: Re: [PATCH 1/2] [graphite] Move codegen related functions to > graphite-isl-ast-to-gimple.c > From: dje@gmail.com > To: hiradi...@msn.com;

[PATCH 05/15] Add selftests to fold-const.c

Jeff approved an older version of this (as a separate unittests/test-folding.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03305.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files > is pre-approved. gcc/ChangeLog:

[PATCH 15/15] RFC: Add ggc-tests.c

Jeff approved an earlier version of this (as unittests/test-ggc.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03306.html > Not terribly happy with that counter to used to create a big list > to detect recursion. But I'm not offhand sure how to avoid without > exposing more of the ggc system

[PATCH 06/15] Add function-tests.c

Jeff approved an earlier version of this (as unittests/test-functions.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03310.html with: > There's some if (0) code in here that needs to be eliminated. (done) > The RTL case in particular is probably stretching the limits of what > we can do

[PATCH 14/15] Add selftests to vec.c

Jeff approved an earlier version of this (as unittests/test-vec.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03308.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is > pre-approved. This version puts the tests

[PATCH 03/15] Add selftests to tree-cfg.c

Jeff approved an older version of this: https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03285.html with: > Unless there's a good reason, drop the presumably redundant tests > and this is OK. Save preapprovald for these changes as the bitmap > patch. This version removes the redundant tests, and

[PATCH 00/15] Unittests framework v4: -fself-test

On Mon, 2015-11-16 at 19:17 +0100, Bernd Schmidt wrote: > So Jeff and I just had a chat, and we came up with some thoughts about > how to proceed. I think we both agree that it would be good to have a > special testing backend, along with frontends designed to be able to > read in gimple or rtl

Re: RFC/RFA: Fix bug with REE optimization corrupting extended registers

On 11/19/2015 04:34 PM, Nick Clifton wrote: Hi Bernd, I had a look around. There's code testing HARD_REGNO_NREGS in ree.c:combine_set_extension. It's inside #if 0, and labelled "temporarily disabled". See if enabling that helps you? (Jeff, that #if 0 was added by you). I suspect that the

  1   2   >