[ping] pending patches

2015-12-01 Thread Eric Botcazou
IA-64 (stack checking improvement): https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01604.html MIPS (stack checking improvement): https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01602.html Aarch64 (stack checking implementation): https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01988.html DWARF-2

Re: [PR68001, CilkPlus] Fix for PR68001

2015-12-01 Thread Tom de Vries
On 30/11/15 21:43, Zamyatin, Igor wrote: FAIL: obj-c++.dg/property/dotsyntax-11.mm -fgnu-runtime (test for errors, line 51) FAIL: obj-c++.dg/property/dotsyntax-11.mm -fgnu-runtime (test for errors, line 56) FAIL: obj-c++.dg/property/dotsyntax-11.mm -fgnu-runtime (test for errors, line 59) An

Re: [PATCH] Fix PR68029

2015-12-01 Thread Jeff Law
On 11/27/2015 06:11 AM, Jiří Engelthaler wrote: 2015-11-27 13:49 GMT+01:00 Bernd Schmidt : On 11/27/2015 01:30 PM, Jiří Engelthaler wrote: Sorry for international characters in my name. It should be Jiri Engelthaler 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří : There is precedent for non-

Re: [C PATCH] Fix up location used in get_parm_info diagnostics (PR c/68533)

2015-12-01 Thread Jeff Law
On 12/02/2015 12:16 AM, Jakub Jelinek wrote: On Tue, Dec 01, 2015 at 08:57:39PM -0700, Jeff Law wrote: On 12/01/2015 01:34 PM, Jakub Jelinek wrote: Hi! get_parm_info right now uses input_location as the diagnostics locus, but as can be seen on the testcase, that is pretty random location at th

Re: [C PATCH] Fix up location used in get_parm_info diagnostics (PR c/68533)

2015-12-01 Thread Jakub Jelinek
On Tue, Dec 01, 2015 at 08:57:39PM -0700, Jeff Law wrote: > On 12/01/2015 01:34 PM, Jakub Jelinek wrote: > >Hi! > > > >get_parm_info right now uses input_location as the diagnostics locus, but as > >can be seen on the testcase, that is pretty random location at that point, > >often the type of the

Re: [PATCH] Fix declaration of pthread-structs in s-osinte-rtems.ads (ada/68169)

2015-12-01 Thread Jeff Law
On 12/01/2015 12:56 PM, Jan Sommer wrote: Am Monday 30 November 2015, 16:19:30 schrieb Jeff Law: On 11/30/2015 03:06 PM, Jan Sommer wrote: Could someone with write access please commit the patch? The paperwork with the FSF has gone through. If something else is missing, please tell me. I won't

Re: [PATCH 1/2] destroy values as well as keys when removing them from hash maps

2015-12-01 Thread Trevor Saunders
On Tue, Dec 01, 2015 at 07:43:35PM +, Richard Sandiford wrote: > tbsaunde+...@tbsaunde.org writes: > > -template > > +template > > template > > inline void > > -simple_hashmap_traits ::remove (T &entry) > > +simple_hashmap_traits ::remove (T &entry) > > { > >H::remove (entry.m_key); >

Re: [C PATCH] Fix up location used in get_parm_info diagnostics (PR c/68533)

2015-12-01 Thread Jeff Law
On 12/01/2015 01:34 PM, Jakub Jelinek wrote: Hi! get_parm_info right now uses input_location as the diagnostics locus, but as can be seen on the testcase, that is pretty random location at that point, often the type of the last parameter. This patch changes it to use the locus from the binding

[gomp4] backport fortran gang parsing updates

2015-12-01 Thread Cesar Philippidis
This patch carries over fortran gang parsing updates I recently applied to trunk to gomp-4_0-branch. Most of it was straightforward, but I did take the opportunity to clean up struct gfc_omp_clauses by eliminating some unnecessary bits for num_gangs, num_workers, vector_length and tile. Besides tha

Re: [PATCH] rs6000: Optimise SImode cstore on 64-bit

2015-12-01 Thread Segher Boessenkool
On Wed, Dec 02, 2015 at 01:50:46PM +1030, Alan Modra wrote: > On Wed, Dec 02, 2015 at 01:55:17AM +, Segher Boessenkool wrote: > > + emit_insn (gen_subdi3 (tmp, op1, op2)); > > + emit_insn (gen_lshrdi3 (tmp2, tmp, GEN_INT (63))); > > + emit_insn (gen_anddi3 (tmp3, tmp2, const1_rtx)); > > Why

Re: [PATCH] rs6000: Optimise SImode cstore on 64-bit

2015-12-01 Thread Alan Modra
On Wed, Dec 02, 2015 at 01:55:17AM +, Segher Boessenkool wrote: > + emit_insn (gen_subdi3 (tmp, op1, op2)); > + emit_insn (gen_lshrdi3 (tmp2, tmp, GEN_INT (63))); > + emit_insn (gen_anddi3 (tmp3, tmp2, const1_rtx)); Why the AND? The top 63 bits are already clear. -- Alan Modra Australia

Re: -fstrict-aliasing fixes 1/5: propagate -fno-strict-aliasing in the inliner

2015-12-01 Thread Jan Hubicka
> > * ipa-inline-transform.c (inline_call): Drop -fstrict-aliasing when > > inlining -fno-strict-aliasing into -fstrict-aliasing body. > > * gcc.dg/lto/alias-1_0.c: New testcase. > > * gcc.dg/lto/alias-1_1.c: New testcase. > >Index: ipa-inline-transform.c > >

Re: [PATCH] rs6000: Optimise SImode cstore on 64-bit

2015-12-01 Thread David Edelsohn
On Tue, Dec 1, 2015 at 8:55 PM, Segher Boessenkool wrote: > On 64-bit we can do comparisons of 32-bit values by extending those > values to 64-bit, subtracting them, and then getting the high bit of > the result. For registers this is always cheaper than using the carry > bit sequence; and if the

[PATCH] rs6000: Optimise SImode cstore on 64-bit

2015-12-01 Thread Segher Boessenkool
On 64-bit we can do comparisons of 32-bit values by extending those values to 64-bit, subtracting them, and then getting the high bit of the result. For registers this is always cheaper than using the carry bit sequence; and if the comparison involves a constant, this is cheaper than the sequence

Go patch committed: Fix array dimension handling on 32-bit host

2015-12-01 Thread Ian Lance Taylor
The Go frontend code that handled array dimensions when generating reflection and mangling assumed that an array dimension would fit in an unsigned long. That is of course not true when a 32-bit host is cross-compiling to a 64-bit target. This patch fixes the problem. This was reported as GCC PR

Re: [google gcc-4_9] Fix bad LIPO profile produced by gcov-tool

2015-12-01 Thread Xinliang David Li
So that field was never inited/used before? Also saved_compressed_len = (unsigned long) gcov_read_unsigned (); should use unsigned not unsigned long type. On Tue, Dec 1, 2015 at 4:53 PM, Rong Xu wrote: > This is only needed for gcov-tool as we need to rewrite the > moduel-info to the profile (t

Re: [google gcc-4_9] Fix bad LIPO profile produced by gcov-tool

2015-12-01 Thread Rong Xu
This is only needed for gcov-tool as we need to rewrite the moduel-info to the profile (this is only used in decompress) The transitional compiler path does not need it because the string is already decompressed. It only needs to use the strings. gcov-dump in theory does not need it either if it

[google gcc-4_9] Fix bad LIPO profile produced by gcov-tool

2015-12-01 Thread Rong Xu
Hi, This patch fixes the issue when using gcov-tool to merge LIPO profiles after we compressing the module infomration . We should not decompress the string as the compressed string should be written directly to the profile later. Tested with some LIPO profiles. Thanks, -Rong 2015-12-01 Rong Xu

Re: [gomp-nvptx 6/9] nvptx libgcc: rewrite in C

2015-12-01 Thread Alexander Monakov
On Wed, 2 Dec 2015, Bernd Schmidt wrote: > What exactly is the problem with having asm files? I'm asking because this... Wrappers for malloc and free need different code under -muniform-simt. > > On 12/01/2015 04:28 PM, Alexander Monakov wrote: > > +/* __shared__ char *__nvptx_stacks[32]; */ >

[committed] Tighten runtime initialization check in __canonicalize_funcptr_for_compare on hppa-linux

2015-12-01 Thread John David Anglin
The attached change fixes a startup issue of emacs24 on Debian hppa-linux. The emacs24 build does some tricky stuff to preinitialize values, so that standard static initialization check is skipped. However, the global offset table has moved in the final executable and emacs24 crashes. The atta

Re: [gomp-nvptx 6/9] nvptx libgcc: rewrite in C

2015-12-01 Thread Bernd Schmidt
What exactly is the problem with having asm files? I'm asking because this... On 12/01/2015 04:28 PM, Alexander Monakov wrote: +/* __shared__ char *__nvptx_stacks[32]; */ +asm ("// BEGIN GLOBAL VAR DEF: __nvptx_stacks"); +asm (".visible .shared .u64 __nvptx_stacks[32];"); + +/* __shared__ unsi

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-01 Thread Tom de Vries
On 01/12/15 15:44, Jakub Jelinek wrote: On Tue, Dec 01, 2015 at 03:25:42PM +0100, Tom de Vries wrote: Handle BUILT_IN_GOACC_PARALLEL in ipa-pta 2015-12-01 Tom de Vries * tree-ssa-structalias.c (find_func_aliases_for_builtin_call) (find_func_clobbers, ipa_pta_execute): Handle

Re: Incorrect code due to indirect tail call of varargs function with hard float ABI

2015-12-01 Thread Kugan
>> >> gcc/ChangeLog: >> >> 2015-11-18 Kugan Vivekanandarajah >> >> PR target/68390 >> * config/arm/arm.c (arm_function_ok_for_sibcall): Get function type >> for indirect function call. >> >> gcc/testsuite/ChangeLog: >> >> 2015-11-18 Kugan Vivekanandarajah >> >> PR target/

Re: Gimple loop splitting v2

2015-12-01 Thread Jeff Law
On 12/01/2015 09:46 AM, Michael Matz wrote: Hi, So, okay for trunk? -ENOPATCH Jeff

Re: [gomp-nvptx 9/9] adjust SIMD loop lowering for SIMT targets

2015-12-01 Thread Alexander Monakov
Apologies -- last-minute attempt to cleanup and enhance broke this patch; fixed version below. The main difference is checking whether we're transforming a loop that might be executed on the target: checking decl->offloadable isn't enough, because target region outlining might not have happened ye

Re: [PATCH] Empty redirect_edge_var_map after each pass and function

2015-12-01 Thread Jeff Law
On 12/01/2015 11:33 AM, Alan Lawrence wrote: I was not able to reduce the testcase below about 30k characters, with e.g. #define T_VOID 0 T_VOID producing the ICE, but manually changing to 0 preventing the ICE; as did running the preprocessor as a separate step, or a wide var

Re: PR 68432: Add a target hook to control size/speed optab choices

2015-12-01 Thread Bernd Schmidt
On 12/01/2015 10:15 PM, Richard Sandiford wrote: [This is a less invasive fix for the PR, without any changes to the .md attribute handling] As a minimal fix I like this much better. I'll ok it under the condition that you have verified in all ports that size/speed issues are the only reaso

Re: [PATCH] fix PR65726

2015-12-01 Thread Jeff Law
On 12/01/2015 02:50 PM, Andreas Tobler wrote: On 30.11.15 23:30, Jeff Law wrote: On 11/26/2015 11:49 AM, Andreas Tobler wrote: Hi all, the attached patch fixes the build issue from this ticket if bootstrap is disabled. Tested on x86_64-*-linux* and on x86_64-*-freebsd* with gcc and clang. Ok

Re: [PATCH] fix PR65726

2015-12-01 Thread Andreas Tobler
On 30.11.15 23:30, Jeff Law wrote: On 11/26/2015 11:49 AM, Andreas Tobler wrote: Hi all, the attached patch fixes the build issue from this ticket if bootstrap is disabled. Tested on x86_64-*-linux* and on x86_64-*-freebsd* with gcc and clang. Ok for trunk? And 5.3? Thanks, Andreas 2015-11

Re: [patch] add ELFv2 check to FreeBSD PowerPC64

2015-12-01 Thread Andreas Tobler
On 29.11.15 22:15, Andreas Tobler wrote: Hi all, I'd like to commit this patch to trunk. It is FreeBSD only. If nobody objects I'll commit it within two days. Thanks, Andreas 2015-11-29 Andreas Tobler * config/rs6000/freebsd64.h (ELFv2_ABI_CHECK): Add new macro. (SUBSUBT

Re: [RFA] Compact EH Patch

2015-12-01 Thread Jason Merrill
On 11/25/2015 11:58 AM, Moore, Catherine wrote: -Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Friday, September 18, 2015 3:25 PM To: Moore, Catherine; gcc-patches@gcc.gnu.org Cc: ja...@redhat.com; Matthew Fortune Subject: Re: [RFA] Compact EH Patch Index:

Re: [PATCH][PR tree-optimization/67816] Fix jump threading when DOM removes conditionals in jump threading path

2015-12-01 Thread Jeff Law
On 10/09/2015 09:45 AM, Jeff Law wrote: Yes, but as you remove jump threading paths you could leave the CFG change to cfg-cleanup anyway? To get better behavior wrt loop fixup at least? So go ahead and detect, remove the threading paths, but leave final fixup to cfg-cleanup. I can certainly tr

RE: [RFA] Compact EH Patch

2015-12-01 Thread Moore, Catherine
Ping? > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Moore, Catherine > Sent: Wednesday, November 25, 2015 11:58 AM > To: Richard Henderson; gcc-patches@gcc.gnu.org > Cc: ja...@redhat.com; Matthew Fortune > Subject: RE: [RF

PR 68432: Add a target hook to control size/speed optab choices

2015-12-01 Thread Richard Sandiford
[This is a less invasive fix for the PR, without any changes to the .md attribute handling] The problem in the PR is that some i386 optabs FAIL when optimising for size rather than speed. The gimple level generally needs access to this information before calling the generator, so this patch adds

Re: RFD: annotate iterator patterns with expanded forms

2015-12-01 Thread Bernd Schmidt
On 12/01/2015 04:31 PM, Bernd Schmidt wrote: On 12/01/2015 04:23 PM, Jakub Jelinek wrote: With the comments in the *.md file I'd worry about them getting out of date, or people feeling they have to edit them manually (rather than being regenerated or whatever). I suppose we could have a Makefi

Re: PR68577: Handle narrowing for vector popcount, etc.

2015-12-01 Thread Richard Sandiford
Richard Biener writes: > On Tue, Dec 1, 2015 at 10:14 AM, Richard Sandiford > wrote: >> diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c >> index 3b078da..af86bce 100644 >> --- a/gcc/tree-vect-stmts.c >> +++ b/gcc/tree-vect-stmts.c >> @@ -2122,6 +2122,40 @@ vectorizable_mask_load_store

Re: -fstrict-aliasing fixes 1/5: propagate -fno-strict-aliasing in the inliner

2015-12-01 Thread Bernhard Reutner-Fischer
On December 1, 2015 12:05:39 AM GMT+01:00, Jan Hubicka wrote: >Hi, >this is first patch in the broken up series. It adds the logic into >ipa-inline-transform to drop the flag when inlining. I do it always >until >we find a way to make early optimizations safe WRT this transform. > >The testcase

[C PATCH] Fix up location used in get_parm_info diagnostics (PR c/68533)

2015-12-01 Thread Jakub Jelinek
Hi! get_parm_info right now uses input_location as the diagnostics locus, but as can be seen on the testcase, that is pretty random location at that point, often the type of the last parameter. This patch changes it to use the locus from the binding info. Bootstrapped/regtested on x86_64-linux a

Re: [patch] RFC asan support for i?86/x86_64-*freebsd*

2015-12-01 Thread Andreas Tobler
Hi! On 01.12.15 13:22, Uros Bizjak wrote: 2015-11-29 Andreas Tobler * config/i386/i386.h: Define two new macros: SUBTARGET_SHADOW_OFFSET_64 and SUBTARGET_SHADOW_OFFSET_32. * config/i386/i386.c (ix86_asan_shadow_offset): Use these macros. * config/i386/darwin.h: Override the SUBTARGET_SHADOW

[PTX] uninitialized decls

2015-12-01 Thread Nathan Sidwell
This patch removes some more code duplication. ASM_OUTPUT_ALIGNED_DECL_COMMON & ASM_OUTPUT_ALIGNED_DECL_LOCAL had virtually identical definitions, so I fowarded them both to a new helper function. I noticed that: (a) a common decl could use .weak, which is closer to common semantics than a r

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread Steve Kargl
On Tue, Dec 01, 2015 at 12:58:28PM -0500, David Malcolm wrote: > On Tue, 2015-12-01 at 18:51 +0100, Bernhard Reutner-Fischer wrote: > > As said, we could as well use a list of candidates with NULL as record > > marker. > > Implementation cosmetics. Steve seems to not be thrilled by the > > overall

Re: [PATCH] Fix declaration of pthread-structs in s-osinte-rtems.ads (ada/68169)

2015-12-01 Thread Jan Sommer
Am Monday 30 November 2015, 16:19:30 schrieb Jeff Law: > On 11/30/2015 03:06 PM, Jan Sommer wrote: > > Could someone with write access please commit the patch? > > The paperwork with the FSF has gone through. If something else is missing, > > please tell me. > > I won't be available next week. > I

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread Steve Kargl
On Tue, Dec 01, 2015 at 06:34:57PM +0100, Bernhard Reutner-Fischer wrote: > On 1 December 2015 at 17:41, Steve Kargl > > > > Yes, I know there are other C++ (mis)features within the > > Fortran FE especially in the trans-*.c files. Those are > > accepted (by some) as necessary evils to interface w

Re: [PATCH 1/2] destroy values as well as keys when removing them from hash maps

2015-12-01 Thread Richard Sandiford
tbsaunde+...@tbsaunde.org writes: > -template > +template > template > inline void > -simple_hashmap_traits ::remove (T &entry) > +simple_hashmap_traits ::remove (T &entry) > { >H::remove (entry.m_key); > + entry.m_value.~Value (); > } This is just repeating my IRC comment really, but

[PATCH] PR c/68637: Rebuid array with the updated function pointer type

2015-12-01 Thread H.J. Lu
When we apply function attribute to array of function pointer, we need to rebuild array with the updated function pointer type. gcc/ PR c/68637 * attribs.c (decl_attributes): Rebuid array with the updated * function pointer type. gcc/testsuite/ PR c/68637

Re: [RFA] [PATCH] Fix invalid redundant extension elimination for rl78 port

2015-12-01 Thread Richard Sandiford
Jeff Law writes: > @@ -1080,6 +1070,18 @@ add_removable_extension (const_rtx expr, rtx_insn > *insn, > } > } > > + /* Fourth, if the extended version occupies more registers than the > + original and the source of the extension is the same hard register > + as

Re: [PING v2][PATCH][4.9] Backport fix for PR sanitizer/64820.

2015-12-01 Thread Joakim Tjernlund
On Tue, 2015-12-01 at 20:23 +0300, Maxim Ostapenko wrote: > On 25/11/15 12:14, Maxim Ostapenko wrote: > > I would like to ping the patch: > > https://gcc.gnu.org/ml/gcc-patches/2015-11/msg02174.html. > > > > Ping. Yes, please add :)

Re: [gomp4.5] Handle #pragma omp declare target link

2015-12-01 Thread Jakub Jelinek
On Tue, Dec 01, 2015 at 08:29:27PM +0300, Ilya Verbin wrote: > libgomp/ > * target.c (finalized): New static variable. > (resolve_device): Do nothing when finalized is true. > (GOMP_offload_register_ver): Likewise. > (GOMP_offload_unregister_ver): Likewise. > (gomp_tar

[GOOGLE] add more type in lipo type compare

2015-12-01 Thread Dehao Chen
The following patch can fix an ICE when compiling with LIPO. OK for google-4_9? Thanks, Dehao Index: gcc/l-ipo.c === --- gcc/l-ipo.c (revision 225685) +++ gcc/l-ipo.c (working copy) @@ -731,6 +731,7 @@ lipo_cmp_type (tree t1, tree t2

Re: When not optimizing do not compute RTX memory attributes

2015-12-01 Thread Jan Hubicka
> On Tue, 1 Dec 2015, Jan Hubicka wrote: > > > Hi, > > memory attributes are currently optimized and attached to RTL even when not > > optimizing. This is obviously just a wasted effort. > > Huh, are you sure? What about globals used from different optimize > contexts? Hmm, you are right - we w

[PATCH] Empty redirect_edge_var_map after each pass and function

2015-12-01 Thread Alan Lawrence
This follows on from discussion at https://gcc.gnu.org/ml/gcc-patches/2015-11/msg03392.html To recap: Starting in r229479 and continuing until at least 229711, compiling polynom.c from spec2000 on aarch64-none-linux-gnu, with options -O3 -mcpu=cortex-a53 -ffast-math (on both cross, native bootstrap

RE: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread VandeVondele Joost
So, I have tested the patch, it seems to work well. I would really like to see this feature in the compiler, I'm sure it will help people developing Fortran code. I have already an enhancement request, catching the name of 'Keyword argument' : > cat test.f90 MODULE test CONTAINS SUBROUTINE fo

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread David Malcolm
On Tue, 2015-12-01 at 18:51 +0100, Bernhard Reutner-Fischer wrote: > On 1 December 2015 at 18:28, David Malcolm wrote: > > On Tue, 2015-12-01 at 13:55 +0100, Bernhard Reutner-Fischer wrote: > > > >> +/* Lookup function FN fuzzily, taking names in FUN into account. */ > >> + > >> +const char* >

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread Bernhard Reutner-Fischer
On 1 December 2015 at 18:28, David Malcolm wrote: > On Tue, 2015-12-01 at 13:55 +0100, Bernhard Reutner-Fischer wrote: >> +/* Lookup function FN fuzzily, taking names in FUN into account. */ >> + >> +const char* >> +gfc_lookup_function_fuzzy (const char *fn, gfc_symtree *fun) >> +{ >> + auto_v

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread Bernhard Reutner-Fischer
On 1 December 2015 at 17:41, Steve Kargl wrote: > On Tue, Dec 01, 2015 at 05:12:57PM +0100, Bernhard Reutner-Fischer wrote: >> On 1 December 2015 at 16:01, Steve Kargl >> wrote: >> > On Tue, Dec 01, 2015 at 01:55:01PM +0100, Bernhard Reutner-Fischer wrote: >> >> >> >> David Malcolm nice Levenshte

Re: [gomp4.5] Handle #pragma omp declare target link

2015-12-01 Thread Ilya Verbin
On Tue, Dec 01, 2015 at 14:15:59 +0100, Jakub Jelinek wrote: > On Tue, Dec 01, 2015 at 11:48:51AM +0300, Ilya Verbin wrote: > > > On 01 Dec 2015, at 11:18, Jakub Jelinek wrote: > > >> On Mon, Nov 30, 2015 at 11:55:20PM +0300, Ilya Verbin wrote: > > >> Ok, but it doesn't solve the issue with doing

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread David Malcolm
On Tue, 2015-12-01 at 13:55 +0100, Bernhard Reutner-Fischer wrote: > gcc/fortran/ChangeLog > > 2015-11-29 Bernhard Reutner-Fischer > > * gfortran.h (gfc_lookup_function_fuzzy): New declaration. > * resolve.c: Include spellcheck.h. > (lookup_function_fuzzy_find_candidates): Ne

[PING v2][PATCH][4.9] Backport fix for PR sanitizer/64820.

2015-12-01 Thread Maxim Ostapenko
On 25/11/15 12:14, Maxim Ostapenko wrote: I would like to ping the patch: https://gcc.gnu.org/ml/gcc-patches/2015-11/msg02174.html. Ping. -Maxim

Re: [UPC 01/22] front-end changes

2015-12-01 Thread David Malcolm
On Tue, 2015-12-01 at 00:19 -0800, Gary Funck wrote: > On 12/01/15 09:12:44, Eric Botcazou wrote: > > > All languages (c, c++, fortran, go, lto, objc, obj-c++) have been > > > bootstrapped; no test suite regressions were introduced, > > > relative to the GCC trunk. > > > > That's not all languages

[PTX] simplify arg advance

2015-12-01 Thread Nathan Sidwell
arg_advance doesn't need to consider TImode. Those are always passed by reference. nathan 2015-12-01 Nathan Sidwell * config/nvptx/nvptx.c (nvptx_function_arg_advance): Don't consider mode. Index: config/nvptx/nvptx.c === --

Re: [PATCH] Derive interface buffers from max name length

2015-12-01 Thread Bernhard Reutner-Fischer
On 1 December 2015 at 15:52, Janne Blomqvist wrote: > On Tue, Dec 1, 2015 at 2:54 PM, Bernhard Reutner-Fischer > wrote: >> These three function used a hardcoded buffer of 100 but would be better >> off to base off GFC_MAX_SYMBOL_LEN which denotes the maximum length of a >> name in any of our supp

Gimple loop splitting v2

2015-12-01 Thread Michael Matz
Hi, On Mon, 16 Nov 2015, Jeff Law wrote: > OK, if you want to keep them, then have a consistent way to turn them > on/off for future debugging. if0/if1 doesn't provide much of a clue to > someone else what to turn on/off if they need to debug this stuff. > > > I don't see any negative tests -

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread Steve Kargl
On Tue, Dec 01, 2015 at 05:12:57PM +0100, Bernhard Reutner-Fischer wrote: > On 1 December 2015 at 16:01, Steve Kargl > wrote: > > On Tue, Dec 01, 2015 at 01:55:01PM +0100, Bernhard Reutner-Fischer wrote: > >> > >> David Malcolm nice Levenshtein distance spelling check helpers > >> were used in som

Re: RFC: Merge the GUPC branch into the GCC 6.0 trunk

2015-12-01 Thread Gary Funck
On 12/01/15 12:12:29, Richard Biener wrote: > On Mon, 30 Nov 2015, Gary Funck wrote: > > At this time, we would like to re-submit the UPC patches for comment > > with the goal of introducing these changes into GCC 6.0. > > First of all let me say that it is IMNSHO now too late for GCC 6. I realiz

RE: [Patch 2/3][Aarch64] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-12-01 Thread David Sherwood
Hi, Thanks for the comments James, I've moved the patterns around and added new comments to them. Hope this is ok. Regards, David Sherwood. ChangeLog: 2015-12-01 David Sherwood gcc/ * config/aarch64/aarch64.md: New pattern. * config/aarch64/aarch64-simd.md: Likewise.

Re: [gomp-nvptx 2/9] nvptx backend: new "uniform SIMT" codegen variant

2015-12-01 Thread Alexander Monakov
On Tue, 1 Dec 2015, Bernd Schmidt wrote: > > Didn't we also conclude that address-taking (let's say for stack addresses) is > also an operation that does not result in the same state? This is intended to be used with soft-stacks in OpenMP offloading, and soft-stacks are per-warp outside of SIMD r

Re: [PATCH][ARM] Use snprintf rather than sprintf where possible

2015-12-01 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00937.html This fell through the cracks for me. Is this ok at this stage? Or should I leave it for GCC 7? Thanks, Kyrill On 09/11/15 11:36, Kyrill Tkachov wrote: Hi all, Judging by the thread at https://gcc.gnu.org/ml/gcc-patches/2015-10/ms

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread Bernhard Reutner-Fischer
On 1 December 2015 at 16:01, Steve Kargl wrote: > On Tue, Dec 01, 2015 at 01:55:01PM +0100, Bernhard Reutner-Fischer wrote: >> >> David Malcolm nice Levenshtein distance spelling check helpers >> were used in some parts of other frontends. This proposed patch adds >> some spelling corrections to t

Re: [gomp-nvptx 2/9] nvptx backend: new "uniform SIMT" codegen variant

2015-12-01 Thread Bernd Schmidt
On 12/01/2015 04:28 PM, Alexander Monakov wrote: I'm taking a different approach. I want to execute all insns in all warp members, while ensuring that effect (on global and local state) is that same as if any single thread was executing that instruction. Most instructions automatically satisfy

Re: [gomp-nvptx 8/9] libgomp: update gomp_nvptx_main for -mgomp

2015-12-01 Thread Bernd Schmidt
On 12/01/2015 04:28 PM, Alexander Monakov wrote: Bernd, is your position on exposing shared memory as first-class address space on NVPTX subject to change? Do you remember what middle-end issues you've encountered when trying that? TYPE_ADDR_SPACE does not reliably contain the address space. P

Re: [PATCH] Commentary typo fix for gfc_typenode_for_spec()

2015-12-01 Thread Steve Kargl
On Tue, Dec 01, 2015 at 01:55:00PM +0100, Bernhard Reutner-Fischer wrote: > Regstrapped without regressions, ok for trunk stage3 now / next stage1? > > gcc/fortran/ChangeLog > > 2015-11-29 Bernhard Reutner-Fischer > > * trans-types.c (gfc_typenode_for_spec): Commentary typo fix. > Pat

Re: [PATCH] Add testcase for tree-optimization/64769

2015-12-01 Thread Jakub Jelinek
On Tue, Dec 01, 2015 at 04:38:03PM +0100, Marek Polacek wrote: > There's an open PR with -fopenmp-simd testcase that used to ICE but is now > fixed for 5/6, but not 4.9. > > Should I commit this right away to trunk, wait for gcc-5 branch to open and > then commit it to 5 as well and then close the

[gomp-nvptx 1/9] nvptx backend: allow emitting COND_EXEC insns

2015-12-01 Thread Alexander Monakov
This allows to use COND_EXEC patterns on nvptx. The backend is mostly ready for that, although I had to slightly fix nvptx_print_operand. I've also opted to make calls predicable to make the uniform-simt patch simpler, and to that end I need a small fixup in nvptx_output_call_insn. RTL optimizat

[gomp-nvptx 3/9] nvptx backend: add two more identifier maps

2015-12-01 Thread Alexander Monakov
This allows to rewrite libgcc wrappers in C by adding back-maps __nvptx_real_malloc -> malloc and __nvptx_real_free -> free. While at it, I've made the implementation leaner. * config/nvptx/nvptx.c (nvptx_name_replacement): Rewrite. Add __nvptx_real_malloc -> malloc and __nvptx_r

[PATCH] Add testcase for tree-optimization/64769

2015-12-01 Thread Marek Polacek
There's an open PR with -fopenmp-simd testcase that used to ICE but is now fixed for 5/6, but not 4.9. Should I commit this right away to trunk, wait for gcc-5 branch to open and then commit it to 5 as well and then close the PR? Or just to trunk and close the PR? Tested on x86_64-linux. 2015-1

Re: RFD: annotate iterator patterns with expanded forms

2015-12-01 Thread Bernd Schmidt
On 12/01/2015 04:23 PM, Jakub Jelinek wrote: On Tue, Dec 01, 2015 at 04:14:21PM +0100, Bernd Schmidt wrote: One problem I have whenever I try to edit i386.md is that I can't find the patterns I'm looking for. Let's say I'm looking for lshrsi3, but there's no pattern by this name, what I'm lookin

Re: RFD: annotate iterator patterns with expanded forms

2015-12-01 Thread Jakub Jelinek
On Tue, Dec 01, 2015 at 04:14:21PM +0100, Bernd Schmidt wrote: > One problem I have whenever I try to edit i386.md is that I can't find the > patterns I'm looking for. Let's say I'm looking for lshrsi3, but there's no > pattern by this name, what I'm looking for is "3". Even > worse are things like

[gomp-nvptx 6/9] nvptx libgcc: rewrite in C

2015-12-01 Thread Alexander Monakov
To easily build libgcc for -mgomp multilib, I've rewritten libgcc routines from asm to C. En passant, I've fixed a bug in malloc and realloc wrappers where they failed to handle out-of-memory conditions. I'm assuming it wasn't intentional. I also use a patch for Newlib that rewrites its nvptx-sp

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread VandeVondele Joost
Today, I ran 'gfortran -static-libfortran test.f90' and was very pleased with the answer: gfortran: error: unrecognized command line option ‘-static-libfortran’; did you mean ‘-static-libgfortran’? So thanks David, and hopefully we get this user experience for the FE as well. Joost

[gomp-nvptx 9/9] adjust SIMD loop lowering for SIMT targets

2015-12-01 Thread Alexander Monakov
This is incomplete. This handles OpenMP SIMD for NVPTX in simple cases, partly by punting on anything unusual such as simduid loops, partly by getting lucky, as testcases do not expose the missing bits. What it currently does is transform SIMD loop for (V = N1; V cmp N2; V + STEP) BODY; into

[gomp-nvptx 0/9] Codegen bits for NVPTX OpenMP SIMD

2015-12-01 Thread Alexander Monakov
Hello! This patch series shows how I'm approaching OpenMP SIMD for NVPTX. It looks good both in check-c testing and libgomp testing, including new target-3x.c cases (but for-5.c fails to run with resource exhaustion, maybe it should be split for NVPTX -- will investigate more later). The previou

Re: RFC: Merge the GUPC branch into the GCC 6.0 trunk

2015-12-01 Thread Richard Biener
On Tue, 1 Dec 2015, Andi Kleen wrote: > Bernd Schmidt writes: > > > I'm worried we'll end up carrying > > something around as a burden that is of no practical use (considering > > we already support the more widespread OpenMP). > > I'm not an expert on UPC, but from glancing over the descriptio

[gomp-nvptx 8/9] libgomp: update gomp_nvptx_main for -mgomp

2015-12-01 Thread Alexander Monakov
Here's how I've updated gomp_nvptx_main to set up shared memory arrays __nvptx_stacks and __nvptx_uni for -mgomp. Since it makes sense only for -mgomp multilib, I've wrapped the whole file under #ifdef that checks corresponding built-in macros. Reaching those shared memory arrays is awkward. I c

[gomp-nvptx 5/9] new target hook: TARGET_SIMT_VF

2015-12-01 Thread Alexander Monakov
This patch adds a new target hook and implements it in a straightforward manner on NVPTX to indicate that the target is running in SIMT fashion with 32 threads in a synchronous group ("warp"). For use in OpenMP transforms. --- gcc/config/nvptx/nvptx.c | 12 gcc/doc/tm.texi |

[gomp-nvptx 4/9] nvptx backend: add -mgomp option and multilib

2015-12-01 Thread Alexander Monakov
Since OpenMP offloading requires both soft-stacks and "uniform SIMT", both non-traditional codegen variants, I'm building a multilib variant with those enabled. This patch adds option -mgomp which enables -msoft-stack plus -muniform-simt, and builds a multilib with it. * config/nvptx/nvpt

[gomp-nvptx 2/9] nvptx backend: new "uniform SIMT" codegen variant

2015-12-01 Thread Alexander Monakov
This patch introduces a code generation variant for NVPTX that I'm using for SIMD work in OpenMP offloading. Let me try to explain the idea behind it... In place of SIMD vectorization, NVPTX is using SIMT (single instruction/multiple threads) execution: groups of 32 threads execute the same instr

[gomp-nvptx 7/9] nvptx mkoffload: pass -mgomp for OpenMP offloading

2015-12-01 Thread Alexander Monakov
This patch wires up use of alternative -mgomp multilib for OpenMP offloading via nvptx mkoffload. It makes OpenACC and OpenMP incompatible for simultaneous offloading compilation, so I've added a diagnostic for that. * config/nvptx/mkoffload.c (main): Check that either OpenACC or OpenMP

Re: [PATCH] Add testcase for tree-optimization/67916

2015-12-01 Thread Richard Biener
On Tue, Dec 1, 2015 at 4:18 PM, Marek Polacek wrote: > This PR was fixed in r228767 (or went latent?), but this testcase has never > been added. > > Tested on x86_64-linux, ok for trunk? Ok. Richard. > 2015-12-01 Marek Polacek > > PR tree-optimization/67916 > * gcc.dg/torture

Re: [PATCH] Don't ignore noreturn functions for "unused" warning (PR middle-end/68582)

2015-12-01 Thread Richard Biener
On Tue, Dec 1, 2015 at 3:47 PM, Marek Polacek wrote: > We were failing to give "defined but not used" warning for functions marked > with the attribute noreturn/volatile. The problem is that for functions the > TREE_THIS_VOLATILE flag means something different than for decls. The fix is > to che

[PATCH] Add testcase for tree-optimization/67916

2015-12-01 Thread Marek Polacek
This PR was fixed in r228767 (or went latent?), but this testcase has never been added. Tested on x86_64-linux, ok for trunk? 2015-12-01 Marek Polacek PR tree-optimization/67916 * gcc.dg/torture/pr67916.c: New test. diff --git gcc/testsuite/gcc.dg/torture/pr67916.c gcc/tests

RFD: annotate iterator patterns with expanded forms

2015-12-01 Thread Bernd Schmidt
One problem I have whenever I try to edit i386.md is that I can't find the patterns I'm looking for. Let's say I'm looking for lshrsi3, but there's no pattern by this name, what I'm looking for is "3". Even worse are things like "*xordi_2", which has just "*_2" and can't reasonably be searched

Re: RFC: Merge the GUPC branch into the GCC 6.0 trunk

2015-12-01 Thread Andi Kleen
Bernd Schmidt writes: > I'm worried we'll end up carrying > something around as a burden that is of no practical use (considering > we already support the more widespread OpenMP). I'm not an expert on UPC, but from glancing over the description it seems to target a distributed message passing pr

Re: [1/2] OpenACC routine support

2015-12-01 Thread Cesar Philippidis
On 12/01/2015 06:40 AM, Thomas Schwinge wrote: > I noticed while working on other test cases: > > On Wed, 18 Nov 2015 11:02:01 -0800, Cesar Philippidis > wrote: >> --- a/gcc/cp/parser.c >> +++ b/gcc/cp/parser.c > >> @@ -1318,13 +1318,21 @@ cp_finalize_omp_declare_simd (cp_parser *parser, >> t

Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-01 Thread Steve Kargl
On Tue, Dec 01, 2015 at 01:55:01PM +0100, Bernhard Reutner-Fischer wrote: > > David Malcolm nice Levenshtein distance spelling check helpers > were used in some parts of other frontends. This proposed patch adds > some spelling corrections to the fortran frontend. > > Suggestions are printed if w

Re: [PATCH] Derive interface buffers from max name length

2015-12-01 Thread Janne Blomqvist
On Tue, Dec 1, 2015 at 2:54 PM, Bernhard Reutner-Fischer wrote: > These three function used a hardcoded buffer of 100 but would be better > off to base off GFC_MAX_SYMBOL_LEN which denotes the maximum length of a > name in any of our supported standards (63 as of f2003 ff.). Please use xasprintf(

Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

2015-12-01 Thread Tom de Vries
On 01/12/15 13:29, Jakub Jelinek wrote: On Tue, Dec 01, 2015 at 01:27:32PM +0100, Christophe Lyon wrote: >I've committed the attached patch as obvious: it adds >dg-require-effective-target fopenmp to these new tests >so that they are skipped e.g. on arm bare-metal targets >(using newlib). > >Not

Re: [1/2] OpenACC routine support

2015-12-01 Thread Thomas Schwinge
Hi Cesar! I noticed while working on other test cases: On Wed, 18 Nov 2015 11:02:01 -0800, Cesar Philippidis wrote: > --- a/gcc/cp/parser.c > +++ b/gcc/cp/parser.c > @@ -1318,13 +1318,21 @@ cp_finalize_omp_declare_simd (cp_parser *parser, tree > fndecl) > } > } > > -/* Diagnose if #pr

[PATCH] Don't ignore noreturn functions for "unused" warning (PR middle-end/68582)

2015-12-01 Thread Marek Polacek
We were failing to give "defined but not used" warning for functions marked with the attribute noreturn/volatile. The problem is that for functions the TREE_THIS_VOLATILE flag means something different than for decls. The fix is to check the flag only for VAR_DECLs, as suggested by Richi in the P

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-01 Thread Richard Biener
On Tue, 1 Dec 2015, Tom de Vries wrote: > [ was: Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta ] > > On 30/11/15 17:36, Tom de Vries wrote: > > On 30/11/15 14:24, Richard Biener wrote: > > > On Mon, 30 Nov 2015, Tom de Vries wrote: > > > > > > > On 30/11/15 10:16, Richard Biener

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-01 Thread Jakub Jelinek
On Tue, Dec 01, 2015 at 03:25:42PM +0100, Tom de Vries wrote: > Handle BUILT_IN_GOACC_PARALLEL in ipa-pta > > 2015-12-01 Tom de Vries > > * tree-ssa-structalias.c (find_func_aliases_for_builtin_call) > (find_func_clobbers, ipa_pta_execute): Handle BUILT_IN_GOACC_PARALLEL. Isn't th

  1   2   >