[PATCH, i386] Introduce support for PKU instructions.

2015-12-17 Thread Kirill Yukhin
Hello, Patch in the bottom introduces support Intel PKRU instructions: rdpkru and wrpkru. It is pretty straight-forward, so I hope it is still suitable for v6. Names for new intrinsics will appear shortly in new revision of SDM. Bootstrapped & regtested. Is it ok for trunk? gcc/ * commo

Re: [PATCH] OpenACC documentation for libgomp

2015-12-17 Thread Sandra Loosemore
On 12/16/2015 06:29 AM, James Norris wrote: Hi, Attached is the patch to add OpenACC documentation for libgomp. Ok to commit to trunk? I have some copy-editing nits. I can't say I'm familiar enough with this functionality to comment intelligently on the content, though +To activate t

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-12-17 Thread Saraswati, Sujoy (OSTL)
Hi, I've added myself to "Write After Approval" maintainers. Committed revision 231805. Regards, Sujoy Index: MAINTAINERS === --- MAINTAINERS (revision 231804) +++ MAINTAINERS (revision 231805) @@ -554,6 +554,7 @@ Matthew Sachs

[PATCH] Move split-path pass next to the tracer pass

2015-12-17 Thread Jeff Law
Richi noted that the two passes, which do very similar things are at slightly different places in the pipeline. There really isn't a good reason for that. This patch sinks the split-path pass slightly so that it's immediately before the tracer pass. Bootstrapped and regression tested on

Re: [Patch, fortran} pr68196 [4.9/5 Regression] ICE on function result with procedure pointer component

2015-12-17 Thread Steve Kargl
On Thu, Dec 17, 2015 at 11:12:17PM +0100, Paul Richard Thomas wrote: > > Some problems have come up that are not dissimilar to the original > bug, involving infinite recursion with procedure components, with the > same type as the containing type. The fix is verging on the trivial. > However, give

Re: Fix PR66206

2015-12-17 Thread Bernd Schmidt
On 12/18/2015 02:15 AM, Andrew Pinski wrote: Except PATTERN (insn) will never be a REG. The only case where the input can be a REG is: gcc_assert (!find_btr_use (src)); Yeah, so we _are_ calling it with a REG. It's a minor issue that won't trigger in practice, but in order to close the PR we

Re: [PATCH] shrink-wrap: Once more PRs 67778, 68634, and now 68909

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 10:07 PM, Segher Boessenkool wrote: It turns out v4 wasn't quite complete anyway; so here "v5". If a candidate PRE cannot get the prologue because a block BB is reachable from it, but PRE does not dominate BB, we try again with the dominators of PRE. That "try again" needs to agai

libgo patch committed: Make sure NLA_HDRLEN is defined

2015-12-17 Thread Ian Lance Taylor
This libgo patch from Lynn Boger makes sure that NLA_HDRLEN is defined in the syscall package. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline and GCC 5 branch. Ian Index: libgo/mksysinfo.sh === --- l

Re: Fix PR66206

2015-12-17 Thread Andrew Pinski
On Thu, Dec 17, 2015 at 5:00 PM, Bernd Schmidt wrote: > This is a small problem found by a static analyzer, a function in bt-load > can in theory return the address of a local variable. > > Bootstrapped and tested on x86_64-linux, ok? Except PATTERN (insn) will never be a REG. The only case where

Fix PR66206

2015-12-17 Thread Bernd Schmidt
This is a small problem found by a static analyzer, a function in bt-load can in theory return the address of a local variable. Bootstrapped and tested on x86_64-linux, ok? Bernd PR rtl-optimization/66206 * bt-load.c (find_btr_use): Change first arg to be a pointer to an rtx. All callers ch

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 1:59 PM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 1:21 PM, Uros Bizjak wrote: >> On Thu, Dec 17, 2015 at 7:09 PM, H.J. Lu wrote: >>> On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 5:42 A

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-12-17 Thread Jeff Law
On 12/11/2015 03:05 AM, Richard Biener wrote: On Thu, Dec 10, 2015 at 9:08 PM, Jeff Law wrote: On 12/03/2015 07:38 AM, Richard Biener wrote: This pass is now enabled by default with -Os but has no limits on the amount of stmts it copies. The more statements it copies, the more likely it is

[PATCH] Limit path splitting to loops we optimize for speed

2015-12-17 Thread Jeff Law
It's not currently clear what the final disposition for the path splitting code will be. However, there's no reason not to implement Richi's request that we only do this transformation when optimizing for speed and at optimization levels higher than -O2. This patch limits the transformation

Re: [PTX] simplify calling struct

2015-12-17 Thread Bernhard Reutner-Fischer
On December 16, 2015 2:53:51 PM GMT+01:00, Nathan Sidwell wrote: >PTX's machine_function structure squirrels away the function type to >calculate >the presence of varadic args later, rather than calculate it >immediately. It >also uses an rtx field as a boolean. This patch reorganizes it wi

Re: [testsuite][ARM target attributes] Fix effective_target tests

2015-12-17 Thread Christophe Lyon
Hi, Here is an updated version of this patch. I did test it with -mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard in addition to my usual set of options. Compared to the previous version: - I added some doc in sourcebuild.texi - I no longer modify arm_vfp_ok... - I replaced all

[Patch, fortran} pr68196 [4.9/5 Regression] ICE on function result with procedure pointer component

2015-12-17 Thread Paul Richard Thomas
Dear All, Some problems have come up that are not dissimilar to the original bug, involving infinite recursion with procedure components, with the same type as the containing type. The fix is verging on the trivial. However, given that I found two further bugs in fixing the one reported, I worry t

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Jason Merrill
The C++ changes are also for handling comparing an element to itself, which shouldn't happen; I'd prefer a gcc_checking_assert that it doesn't. Jason

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 1:21 PM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 7:09 PM, H.J. Lu wrote: >> On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: >>> On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 2:

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread Uros Bizjak
On Thu, Dec 17, 2015 at 7:09 PM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: >> On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: >>> On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: On Thu, Dec 17, 2015 at 2:00 PM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 2:04 A

Fix alias.c wrt aliases and anchors

2015-12-17 Thread Jan Hubicka
Hi, the alias-2.c testcase fails on targets with anchors. The reason is that the variable itself is anchored while the alias is not and they point to the same location. I folllowed the docs of SYMBOL_REF claiming that SYMBOL_REF_DECL if the symbol is label and tought it is safe to disambiguate t

Re: ipa-cp heuristics fixes

2015-12-17 Thread Jan Hubicka
> Jakub, > thanks a lot for looking into this! I am now bit on tight schedule moving back > to Prague and I knew little about the implementation of debug info for > optimized out arguments. Hi, here is better testcase that also trigger splitting struct a {int a;int b;}; inline static int reta (str

[PATCH] shrink-wrap: Once more PRs 67778, 68634, and now 68909

2015-12-17 Thread Segher Boessenkool
It turns out v4 wasn't quite complete anyway; so here "v5". If a candidate PRE cannot get the prologue because a block BB is reachable from it, but PRE does not dominate BB, we try again with the dominators of PRE. That "try again" needs to again consider BB though, we aren't done with it. This

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jeff Law
hWell, it might be the only target that has warnings because of that, but from a quick look it seems like any target that uses avr-stdint.h or newlib-stdint.h could theoretically have null values for those macros. Without a bit of digging I'm not sure how much of that is real and how much is co

Re: stop IPA wrapping 'main'

2015-12-17 Thread Jan Hubicka
> gcc.dg/20031102-1.c now causes some 'surprising' optimization > behaviour. It is essentially > > int FooBar(void) > { > ... stuff > return 0; > } > > int main(void) > { > return FooBar(); > } > > > What happens is that FooBar gets inlined into main, and then > ipa-icf notices FooBar an

Re: ipa-cp heuristics fixes

2015-12-17 Thread Jan Hubicka
Jakub, thanks a lot for looking into this! I am now bit on tight schedule moving back to Prague and I knew little about the implementation of debug info for optimized out arguments. > > Ok, so here is a WIP patch changing the functions you wanted, untested so > far. > > I've been looking at 3 tes

Re: PATCH: PR target/66232: -fPIC -fno-plt -mx32 fails to generate indirect branch via GOT

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 8:49 AM, H.J. Lu wrote: > Since Pmode is 64-bit with -maddress-mode=long for x32, indirect call > via GOT slot doesn't need zero_extend. This patch limits *call_got_x32 > and *call_value_got_x32 patterns to 32-bit Pmode, adds *call_got_x32_long > and *call_value_got_x32_lo

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Trevor Saunders
On Thu, Dec 17, 2015 at 12:53:20PM -0700, Jeff Law wrote: > On 12/17/2015 11:58 AM, Jan-Benedict Glaw wrote: > >On Thu, 2015-12-17 11:39:24 -0700, Jeff Law wrote: > >>On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: > >>>On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: > On 12/16/2015 03:46

Re: [PATCH][WIP] libstdc++: Make certain exceptions transaction_safe.

2015-12-17 Thread Jonathan Wakely
On 14/11/15 20:45 +0100, Torvald Riegel wrote: +void +_txnal_cow_string_D1(void *that) +{ + typedef std::basic_string bs_type; + bs_type::_Rep *rep = reinterpret_cast( + const_cast(_txnal_cow_string_c_str(that))) - 1; + + // The string can be shared, in which case we would need to decreme

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jeff Law
On 12/17/2015 11:58 AM, Jan-Benedict Glaw wrote: On Thu, 2015-12-17 11:39:24 -0700, Jeff Law wrote: On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: Shall I bisect one of the cases anew, with

Re: [PATCH] IRA: Fix % constraint modifier handling on disabled alternatives.

2015-12-17 Thread Vladimir Makarov
On 12/14/2015 08:05 AM, Andreas Krebbel wrote: Hi, the constraint modifier % applies to all the alternatives of a pattern and hence is mostly added to the first constraint of an operand. IRA currently ignores it if the alternative with the % gets disabled by using the `enabled' attribute or if

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Andrew Pinski
On Thu, Dec 17, 2015 at 12:58 AM, Yury Gribov wrote: > Some obvious symmetry fixes. > > Cc-ing > * Andrey (Belevantsev) for bb_top_order_comparator > * Andrew (MacLeod) for compare_case_labels > * Andrew (Pinski) for resort_field_decl_cmp IIRC this was actually not written by me but I copied it b

Re: [PATCH 3/5] "Fix" intransitive comparison in reload_pseudo_compare_func

2015-12-17 Thread Vladimir Makarov
On 12/17/2015 04:00 AM, Yury Gribov wrote: This patch fixes intransitive comparison in reload_pseudo_compare_func. Imagine the following situation: 1) bitmap_bit_p is unset for A and B but set for C 2) A < B (due to early ira_reg_class_max_nregs comparison) 3) B < C (due to following regno_assig

Re: [PATCH] Fix PR c++/68831 (superfluous -Waddress warning for C++ delete)

2015-12-17 Thread Jason Merrill
OK. Jason

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jan-Benedict Glaw
On Thu, 2015-12-17 11:39:24 -0700, Jeff Law wrote: > On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: > > On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: > > > On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: > > > > Shall I bisect one of the cases anew, with the "Test value of > > > > _GLIBCX

Re: [PATCH] C FE: improvements to ranges of bad return values

2015-12-17 Thread Jeff Law
On 12/16/2015 07:19 PM, David Malcolm wrote: In the C FE, c_parser_statement_after_labels passes "xloc" to c_finish_return, which is the location of the first token within the returned expression. Hence we don't get a full underline for the following: diagnostic-range-bad-return.c:34:10: warnin

[PATCH] [graphite] replace ISL with isl

2015-12-17 Thread Sebastian Pop
--- Makefile.in | 2 +- Makefile.tpl | 2 +- config/isl.m4 | 2 +- configure | 10 +++--- configure.ac | 14 contrib/d

stop IPA wrapping 'main'

2015-12-17 Thread Nathan Sidwell
gcc.dg/20031102-1.c now causes some 'surprising' optimization behaviour. It is essentially int FooBar(void) { ... stuff return 0; } int main(void) { return FooBar(); } What happens is that FooBar gets inlined into main, and then ipa-icf notices FooBar and main have identical bodies.

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jeff Law
On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: Shall I bisect one of the cases anew, with the "Test value of _GLIBCXX_USE_C99_WCHAR not whether it is defined" patch that uncovered it, applied?

config-list.mk and obsoleted configurations (was: [BUILDROBOT] "error: null argument where non-null required" on multiple targets)

2015-12-17 Thread Jan-Benedict Glaw
On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: > On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: > > Shall I bisect one of the cases anew, with the "Test value of > > _GLIBCXX_USE_C99_WCHAR not whether it is defined" patch that > > uncovered it, applied? Starting with some arbitrary old revis

Re: [PATCH] PR c++/68795: fix uninitialized close_paren_loc in cp_parser_postfix_expression

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 07:32 PM, David Malcolm wrote: + if (close_paren_loc) close_paren_loc != UNKNOWN_LOCATION - it's very confusing otherwise. Bernd

Re: ipa-cp heuristics fixes

2015-12-17 Thread Jakub Jelinek
On Wed, Dec 16, 2015 at 08:15:12PM +0100, Jan Hubicka wrote: > just to summarize a discussion on IRC. The problem is that we produce debug > statements for eliminated arguments only in ipa-sra and ipa-split, while we > don't do anything for cgraph clones. This is a problem on release branches, > to

[PATCH] PR c++/68795: fix uninitialized close_paren_loc in cp_parser_postfix_expression

2015-12-17 Thread David Malcolm
cp_parser_parenthesized_expression_list can leave *close_paren_loc untouched if an error occurs; specifically when following this goto: 7402 if (expr == error_mark_node) 7403goto skip_comma; which can lead to cp_parser_postfix_expression attempting to use uninitialize

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 8:11 AM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: >> On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: >>> On Thu, Dec 17, 2015 at 2:00 PM, H.J. Lu wrote: On Thu, Dec 17, 2015 at 2:04 AM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 12

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 06:44 PM, Kyrill Tkachov wrote: Perhaps I had underestimated how involved this issue is :) So if I want to improve the aarch64 situation for GCC 6, would the recommended course of action be to just define the QI and HImode compare against zero patterns? For GCC 6 I think this is t

Re: [BUILDROBOT] "error: null argument where non-null required" on multiple targets

2015-12-17 Thread Jeff Law
On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: On Tue, 2015-12-15 10:43:58 -0700, Jeff Law wrote: On 12/14/2015 01:07 PM, Jan-Benedict Glaw wrote: On Mon, 2015-12-14 18:54:28 +, Moore, Catherine wrote: avr-rtems http://toolchain.lug-owl.de/buildbot/show_build_details.ph

Re: [PATCH] Fix PR c++/68831 (superfluous -Waddress warning for C++ delete)

2015-12-17 Thread Patrick Palka
On Thu, Dec 10, 2015 at 6:54 PM, Patrick Palka wrote: > Is this OK to commit if bootstrap + regtest on x86_64 succeeds? > > gcc/cp/ChangeLog: > > PR c++/68831 > * init.c (build_delete): Use a warning sentinel to disable > -Waddress warnings when building the conditional tha

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Kyrill Tkachov
On 17/12/15 17:27, Segher Boessenkool wrote: On Thu, Dec 17, 2015 at 05:12:16PM +0100, Bernd Schmidt wrote: On 12/17/2015 05:10 PM, Kyrill Tkachov wrote: Well, this patch still produces the QImode comparison if the target has a QImode comparison (the have_insn_for check in the simplify_compari

Re: [PATCH][AArch64][1/2] PR rtl-optimization/68796 Add compare-of-zero_extract pattern

2015-12-17 Thread Kyrill Tkachov
Hi James, On 17/12/15 17:24, James Greenhalgh wrote: On Thu, Dec 17, 2015 at 03:36:40PM +, Kyrill Tkachov wrote: 2015-12-17 Kyrylo Tkachov PR rtl-optimization/68796 * config/aarch64/aarch64.md (*and3nr_compare0_zextract): New pattern. * config/aarch64/aarch64.c (aarc

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Jeff Law
On 12/17/2015 10:04 AM, Kyrill Tkachov wrote: In this case, I'm expecting a QImode compare with zero to map down to the aarch64 TST reg, #255 instruction which definitely zeroes out any bits outside of QImode (as it is a bitwise AND with a bitmask), so zero_extract is the more correct expression

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Segher Boessenkool
On Thu, Dec 17, 2015 at 05:12:16PM +0100, Bernd Schmidt wrote: > On 12/17/2015 05:10 PM, Kyrill Tkachov wrote: > >Well, this patch still produces the QImode comparison if the target has > >a QImode comparison > >(the have_insn_for check in the simplify_comparison hunk). > > Ok, I didn't look that

Re: [PATCH][AArch64][1/2] PR rtl-optimization/68796 Add compare-of-zero_extract pattern

2015-12-17 Thread James Greenhalgh
On Thu, Dec 17, 2015 at 03:36:40PM +, Kyrill Tkachov wrote: > 2015-12-17 Kyrylo Tkachov > > PR rtl-optimization/68796 > * config/aarch64/aarch64.md (*and3nr_compare0_zextract): > New pattern. > * config/aarch64/aarch64.c (aarch64_select_cc_mode): Handle > ZERO_EXTRACT co

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Kyrill Tkachov
Hi Jeff, On 17/12/15 16:59, Jeff Law wrote: On 12/17/2015 09:26 AM, Kyrill Tkachov wrote: One could argue that if the target has (or advertises having) a native QImode register comparison then it's objectively a simplification to transform a comparison in a wider mode to a comparison in the sho

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Jeff Law
On 12/17/2015 09:26 AM, Kyrill Tkachov wrote: One could argue that if the target has (or advertises having) a native QImode register comparison then it's objectively a simplification to transform a comparison in a wider mode to a comparison in the shorter mode. Generally true. The most commonly

Re: [Patch, avr] Provide correct memory move costs

2015-12-17 Thread Denis Chertykov
2015-12-16 10:08 GMT+03:00 Senthil Kumar Selvaraj : > Hi, > > When analyzing code size regressions for AVR for top-of-trunk, I > found a few cases where aggresive inlining (by the middle-end) > of functions containing calls to memcpy was bloating up the code. > > Turns out that the AVR back

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Jeff Law
On 12/17/2015 08:58 AM, Bernd Schmidt wrote: I suspect that this is an oversight in the documentation, and if given two choices the simpler form is intended to be the canonical one. The other BZ I was looking at in this space was 15596. It's PPC, but shows a generic weakness in how we identify

C++ PATCH for c++/67550 (wrong value for reference to const class var)

2015-12-17 Thread Jason Merrill
In my rework of decl_constant_value and kin, I enabled its use in more places, which revealed a problem: when it is allowing non-constexpr aggregate initializers, we need to double-check that we aren't returning something that had initializers stripped out in split_nonconstant_init. Tested x86

PATCH: PR target/66232: -fPIC -fno-plt -mx32 fails to generate indirect branch via GOT

2015-12-17 Thread H.J. Lu
Since Pmode is 64-bit with -maddress-mode=long for x32, indirect call via GOT slot doesn't need zero_extend. This patch limits *call_got_x32 and *call_value_got_x32 patterns to 32-bit Pmode, adds *call_got_x32_long and *call_value_got_x32_long for 64-bit Pmode. OK for trunk if there is no regress

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-12-17 Thread Andris Pavenis
Just committed.revision 231774 Andris Index: MAINTAINERS === --- MAINTAINERS (revision 231774) +++ MAINTAINERS (working copy) @@ -525,6 +525,7 @@ Patrick Palka Seongbae Park Devang Patel +Andris Pavenis Fernando Pereira Ka

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Jeff Law
On 12/17/2015 08:58 AM, Bernd Schmidt wrote: On 12/17/2015 04:36 PM, Kyrill Tkachov wrote: The documentation on RTL canonical forms in md.texi says: "Equality comparisons of a group of bits (usually a single bit) with zero will be written using @code{zero_extract} rather than the equivalent

C++ PATCH for c++/67576 (multiple evaluation of typeid operand)

2015-12-17 Thread Jason Merrill
When I changed build_typeid to take the address of a polymorphic operand rather than using the lvalue directly, I forgot the parallel change from stabilize_reference to save_expr. Tested x86_64-pc-linux-gnu, applying to trunk and 5. commit 5361caf55040d2a15b5ebb5ff0fc1e3e605dba9c Author: Jason

Re: [PATCH] Fix PR68852

2015-12-17 Thread Kyrill Tkachov
On 14/12/15 15:14, Richard Biener wrote: The following fixes PR68852 - so I finally needed to sit down and fix the "build-from-scalars" hack in the SLP vectorizer by pretending we'd have a sane vectorizer IL. Basically I now mark the SLP node with a proper vect_def_type but I have to push that

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Kyrill Tkachov
On 17/12/15 16:12, Bernd Schmidt wrote: On 12/17/2015 05:10 PM, Kyrill Tkachov wrote: Well, this patch still produces the QImode comparison if the target has a QImode comparison (the have_insn_for check in the simplify_comparison hunk). Ok, I didn't look that closely because I had doubts abou

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-12-17 Thread Alessandro Fanfarillo
Great! Thanks. 2015-12-17 15:57 GMT+01:00 Steve Kargl : > On Thu, Dec 17, 2015 at 01:22:06PM +0100, Alessandro Fanfarillo wrote: >> >> I've noticed that this patch has been applied only on trunk and not on >> the gcc-5-branch. Is it a problem to include EVENTS in gcc-5? >> > > No problem. When I

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 7:50 AM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: >> On Thu, Dec 17, 2015 at 2:00 PM, H.J. Lu wrote: >>> On Thu, Dec 17, 2015 at 2:04 AM, Uros Bizjak wrote: On Thu, Dec 17, 2015 at 12:29 AM, H.J. Lu wrote: > Since sibcall never retur

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 05:10 PM, Kyrill Tkachov wrote: Well, this patch still produces the QImode comparison if the target has a QImode comparison (the have_insn_for check in the simplify_comparison hunk). Ok, I didn't look that closely because I had doubts about the approach. This kind of check also g

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Kyrill Tkachov
On 17/12/15 15:58, Bernd Schmidt wrote: On 12/17/2015 04:36 PM, Kyrill Tkachov wrote: The documentation on RTL canonical forms in md.texi says: "Equality comparisons of a group of bits (usually a single bit) with zero will be written using @code{zero_extract} rather than the equivalent @co

Re: [PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 04:36 PM, Kyrill Tkachov wrote: The documentation on RTL canonical forms in md.texi says: "Equality comparisons of a group of bits (usually a single bit) with zero will be written using @code{zero_extract} rather than the equivalent @code{and} or @code{sign_extract} operations.

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 5:42 AM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 2:00 PM, H.J. Lu wrote: >> On Thu, Dec 17, 2015 at 2:04 AM, Uros Bizjak wrote: >>> On Thu, Dec 17, 2015 at 12:29 AM, H.J. Lu wrote: Since sibcall never returns, we can only use call-clobbered register as GOT

[PATCH][combine][RFC][2/2] PR rtl-optimization/68796: Perfer zero_extract comparison against zero rather than unsupported shorter modes

2015-12-17 Thread Kyrill Tkachov
Hi all, The documentation on RTL canonical forms in md.texi says: "Equality comparisons of a group of bits (usually a single bit) with zero will be written using @code{zero_extract} rather than the equivalent @code{and} or @code{sign_extract} operations. " However, this is not always followed

[PATCH][AArch64][1/2] PR rtl-optimization/68796 Add compare-of-zero_extract pattern

2015-12-17 Thread Kyrill Tkachov
Hi all, In this PR I'm trying to increase the use of the aarch64 instruction TST that performs a bitwise AND with a bitmask and compares the result with zero. GCC has many ways of representing these operations in RTL. Depending on the mask, the target and the context it might be an AND-immediat

Re: [PATCH 0/2] obsolete some old targets

2015-12-17 Thread Trevor Saunders
On Tue, Dec 15, 2015 at 03:25:18PM -0700, Jeff Law wrote: > On 12/15/2015 03:02 PM, Trevor Saunders wrote: > >> > >>Can you mark interix as obsolete? It hasn't even built for a long time. > > > > Sure, I can do that if you want, I just wasn't sure before you wanted > > to. > Please do. I know w

Re: [PATCH 0/2] obsolete some old targets

2015-12-17 Thread Trevor Saunders
On Thu, Dec 17, 2015 at 03:36:18PM +0100, Kamil Rytarowski wrote: > Hi, > > I talked with devs and it will be better to just keep it removed and focus on > native NetBSD with NetBSD userland. > > Actually nobody seems to be interested in the Debian/NetBSD distribution. that's what I thought fro

Re: [PATCH] Fix PR68707, 67323

2015-12-17 Thread Alan Lawrence
On 17/12/15 10:46, Richard Biener wrote: On Thu, 17 Dec 2015, Alan Lawrence wrote: On 16/12/15 15:01, Richard Biener wrote: The following patch adds a heuristic to prefer store/load-lanes over SLP when vectorizing. Compared to the variant attached to the PR I made the STMT_VINFO_STRIDED_P be

[PTX] Reorder hard regs

2015-12-17 Thread Nathan Sidwell
This reorders the hardregs to be a contiguous block, and names them somewhat more conventionally. (I had considered %sp, %fp etc, but went with the longer names). nathan 2015-12-17 Nathan Sidwell * config/nvptx/nvptx.h (NVPTX_RETURN_REGNUM, FRAME_POINTER_REGNUM, ARG_POINTER_REGNUM, STA

Re: [PATCH 4/5] Fix intransitive comparison in compare_access_positions

2015-12-17 Thread Martin Jambor
Hi, On Thu, Dec 17, 2015 at 12:02:11PM +0300, Yury Gribov wrote: > Another intransitive comparison in reload_pseudo_compare_func. Buggy > scenario: > 1) A and B are ints of equal presion so we return 0 > 2) C is REAL and thus can compare differently to A and B > > Cc-ing Martin who's the original

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-12-17 Thread Steve Kargl
On Thu, Dec 17, 2015 at 01:22:06PM +0100, Alessandro Fanfarillo wrote: > > I've noticed that this patch has been applied only on trunk and not on > the gcc-5-branch. Is it a problem to include EVENTS in gcc-5? > No problem. When I applied the EVENTS patch to trunk, the 5.3 release was being pre

Re: [PATCH][combine] Check WORD_REGISTER_OPERATIONS normally rather than through preprocessor

2015-12-17 Thread Segher Boessenkool
Hi Kyrill, On Tue, Dec 15, 2015 at 05:07:41PM +, Kyrill Tkachov wrote: > As part of the war on conditional compilation here's an #if check on > WORD_REGISTER_OPERATIONS that > seems to have been missed out. > > Bootstrapped and tested on arm, aarch64, x86_64. > > Is it still ok to commit th

[PATCH] Fix PR68946

2015-12-17 Thread Richard Biener
This fixes PR68946. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2015-12-17 Richard Biener PR tree-optimization/68946 * tree-vect-slp.c (vect_slp_analyze_node_operations): Push SLP def type to stmt operands one stmt at a time. * gc

[ptx] annotate 2 tests

2015-12-17 Thread Nathan Sidwell
These two tests require label values, annotated thusly. nathan 2015-12-17 Nathan Sidwell * c-c++-common/Wunused-var-13.c: Requires label values. * gcc.dg/torture/pr46216.c: Likewise. Index: c-c++-common/Wunused-var-13.c === -

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-12-17 Thread Pierre-Marie de Rodat
On 12/16/2015 10:30 PM, Jason Merrill wrote: OK with those changes. All changes done, and all patches pushed. Thank you very much!! -- Pierre-Marie de Rodat

Re: libgcc: unwind-ia64.c without malloc/free

2015-12-17 Thread Jeff Law
On 12/17/2015 06:17 AM, Bernd Schmidt wrote: On 12/17/2015 12:17 AM, Bernd Edlinger wrote: this is just an idea, how to avoid use of malloc in unwind-ia64.c. [...] What do you think? Not worth worrying about IMO. I think ia64 is dead and best left to rest in maintenance mode. Agreed. And in

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread Uros Bizjak
On Thu, Dec 17, 2015 at 2:00 PM, H.J. Lu wrote: > On Thu, Dec 17, 2015 at 2:04 AM, Uros Bizjak wrote: >> On Thu, Dec 17, 2015 at 12:29 AM, H.J. Lu wrote: >>> Since sibcall never returns, we can only use call-clobbered register >>> as GOT base. Otherwise, callee-saved register used as GOT base w

RE: [PATCH][AArch64] Add TARGET_IRA_CHANGE_PSEUDO_ALLOCNO_CLASS

2015-12-17 Thread Wilco Dijkstra
James Greenhalgh wrote: > On Wed, Dec 16, 2015 at 01:05:21PM +, Wilco Dijkstra wrote: > > James Greenhalgh wrote: > > > On Tue, Dec 15, 2015 at 10:54:49AM +, Wilco Dijkstra wrote: > > > > ping > > > > > > > > > -Original Message- > > > > > From: Wilco Dijkstra [mailto:wilco.dijks...

Re: [PATCH][ARC] Refurbish and extend builtin function support for ARC

2015-12-17 Thread Joern Wolfgang Rennecke
On 17/12/15 09:31, Claudiu Zissulescu wrote: Please find a new patch that refurbishes and extends the builtin function support for ARC. I also added a number of builtins for ARCv2 architecture, and a number of tests. Ok to commit? gcc/ 2015-12-14 Claudiu Zissulescu ... (VUNSPEC_DE

Re: [PATCH] Fix some blockers of PR c++/24666 (arrays decay to pointers too early)

2015-12-17 Thread Patrick Palka
On Thu, 17 Dec 2015, Paolo Carlini wrote: Hi, On 16/12/2015 23:10, Patrick Palka wrote: gcc/cp/ChangeLog: PR c++/59878 * typeck.c (convert_for_initialization): Don't perform an early decaying conversion if converting to a class type. gcc/testsuite/ChangeLog: PR c++/59878

Re: [PATCH] Remove unused modified_noreturn_calls

2015-12-17 Thread Richard Biener
On Thu, 17 Dec 2015, Bernd Schmidt wrote: > On 12/17/2015 10:59 AM, Richard Biener wrote: > > > > +extern void gt_ggc_mx (gimple *&); > > +extern void gt_pch_nx (gimple *&); > > + > > This doesn't occur in the ChangeLog - unrelated change? Not unrelated, it's required to make gtype-desc.c compi

Re: libgcc: unwind-ia64.c without malloc/free

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 12:17 AM, Bernd Edlinger wrote: this is just an idea, how to avoid use of malloc in unwind-ia64.c. [...] What do you think? Not worth worrying about IMO. I think ia64 is dead and best left to rest in maintenance mode. Bernd

Re: [PATCH] Remove unused modified_noreturn_calls

2015-12-17 Thread Bernd Schmidt
On 12/17/2015 10:59 AM, Richard Biener wrote: +extern void gt_ggc_mx (gimple *&); +extern void gt_pch_nx (gimple *&); + This doesn't occur in the ChangeLog - unrelated change? Bernd

Re: [PATCH] PR target/68937: i686: -fno-plt produces wrong code (maybe only with tailcall

2015-12-17 Thread H.J. Lu
On Thu, Dec 17, 2015 at 2:04 AM, Uros Bizjak wrote: > On Thu, Dec 17, 2015 at 12:29 AM, H.J. Lu wrote: >> Since sibcall never returns, we can only use call-clobbered register >> as GOT base. Otherwise, callee-saved register used as GOT base won't >> be properly restored. >> >> Tested on x86-64 w

Re: [PATCH 5/5] Fix intransitive comparison in dr_group_sort_cmp

2015-12-17 Thread Richard Biener
On Thu, 17 Dec 2015, Yury Gribov wrote: > On 12/17/2015 02:57 PM, Richard Biener wrote: > > On Thu, 17 Dec 2015, Yury Gribov wrote: > > > > > That's an interesting one. The original comparison function assumes that > > > operand_equal_p(a,b) is true iff compare_tree(a, b) == 0. > > > Unfortunatel

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Andrey Belevantsev
On 17.12.2015 15:13, Yury Gribov wrote: On 12/17/2015 02:58 PM, Andrey Belevantsev wrote: Hello, On 17.12.2015 11:58, Yury Gribov wrote: Some obvious symmetry fixes. Cc-ing * Andrey (Belevantsev) for bb_top_order_comparator Here, as Jakub mentioned, we assume that the argument addresses wil

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 03:25 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:59 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:41 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: Some obvious symmetry fixes. C

Re: [PATCH 5/5] Fix intransitive comparison in dr_group_sort_cmp

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:57 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: That's an interesting one. The original comparison function assumes that operand_equal_p(a,b) is true iff compare_tree(a, b) == 0. Unfortunately that's not true (functions are written by different authors). T

[PATCH] Fix PR68951

2015-12-17 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-12-17 Richard Biener PR tree-optimization/68951 * tree-vect-data-refs.c (vect_peeling_hash_get_lowest_cost): Ignore strided non-group accesses. * gcc.dg/torture/pr68951.c: New testcas

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Richard Biener
On Thu, 17 Dec 2015, Yury Gribov wrote: > On 12/17/2015 02:59 PM, Richard Biener wrote: > > On Thu, 17 Dec 2015, Yury Gribov wrote: > > > > > On 12/17/2015 02:41 PM, Richard Biener wrote: > > > > On Thu, 17 Dec 2015, Yury Gribov wrote: > > > > > > > > > Some obvious symmetry fixes. > > > > > >

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-12-17 Thread Alessandro Fanfarillo
Hi, I've noticed that this patch has been applied only on trunk and not on the gcc-5-branch. Is it a problem to include EVENTS in gcc-5? 2015-12-02 23:00 GMT+01:00 Steve Kargl : > Committed as revision 231208. > > Alessandro, Tobias, is this a candidate for a commit to > the 5-branch when it is r

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:59 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:41 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: Some obvious symmetry fixes. Cc-ing * Andrey (Belevantsev) for bb_top_order_comparator * Andrew (MacLeod) for compare_c

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:58 PM, Andrey Belevantsev wrote: Hello, On 17.12.2015 11:58, Yury Gribov wrote: Some obvious symmetry fixes. Cc-ing * Andrey (Belevantsev) for bb_top_order_comparator Here, as Jakub mentioned, we assume that the argument addresses will never be equal, The problem is that t

[RFC] Use gfc_decl_attributes in fortran frontend

2015-12-17 Thread Tom de Vries
Hi, Consider this patch, which reduces max_len of the oacc function attribute to 0: ... diff --git a/gcc/fortran/f95-lang.c b/gcc/fortran/f95-lang.c index 8556b70..60f4ad3 100644 --- a/gcc/fortran/f95-lang.c +++ b/gcc/fortran/f95-lang.c @@ -93,7 +93,7 @@ static const struct attribute_spec gfc_a

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:39 PM, Jakub Jelinek wrote: On Thu, Dec 17, 2015 at 11:58:30AM +0300, Yury Gribov wrote: 2015-12-17 Yury Gribov * c-family/c-common.c (resort_field_decl_cmp): Make symmteric. * cp/class.c (method_name_cmp): Ditto. (resort_method_name_cmp): Dit

  1   2   >