Re: [PATCH 1/4, libgomp] Resolve deadlock on plugin exit (Ping x2)

2016-05-10 Thread Chung-Lin Tang
Ping x2 On 2016/4/16 3:39 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/3/21 06:21 PM, Chung-Lin Tang wrote: >> Hi, this is the set of patches from >> https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01411.html >> revised again, this time also with audits for the HSA plugin. >> >> The changes are p

Re: [PATCH, libgomp] Fix deadlock in acc_set_device_type (ping x3)

2016-05-10 Thread Chung-Lin Tang
Ping x3 On 2016/4/19 10:30 PM, Chung-Lin Tang wrote: > Ping x2. > > Hi Jakub, > This patch is fairly straightforward, and solves a easily encountered > deadlock. Please approve for trunk and gcc-6-branch. > > Thanks, > Chung-Lin > > On 2016/4/16 03:39 PM, Chung-Lin Tang wrote: >> Ping. >> >> On

Re: [PATCH, libgomp] Rewire OpenACC async (Ping x3)

2016-05-10 Thread Chung-Lin Tang
Ping x3 On 2016/4/16 3:40 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/4/8 07:02 PM, Chung-Lin Tang wrote: >> Ping. >> >> On 2016/3/29 5:48 PM, Chung-Lin Tang wrote: >>> I've updated this patch for trunk (as attached), and re-tested without >>> regressions. This patch is still a fix for >>> lib

[PATCH] clean up insn-automata.c (was: Re: out of bounds access in insn-automata.c)

2016-05-10 Thread Alexander Monakov
On Wed, 30 Mar 2016, Bernd Schmidt wrote: > On 03/25/2016 04:43 AM, Aldy Hernandez wrote: > > If Bernd is fine with this, I'm happy to retract my patch and any > > possible followups. I'm just interested in having no path causing a > > possible out of bounds access. If your patch will do that, I'

Re: [PATCH], Add PowerPC ISA 3.0 vector d-form addressing

2016-05-10 Thread Segher Boessenkool
On Tue, May 10, 2016 at 11:52:36PM -0400, Michael Meissner wrote: > > > Is this patch acceptable to be checked into the trunk? > > > > You forgot to attach the patch. > > Whoops, sorry about that. > > [gcc] > 2016-05-10 Michael Meissner > > * config/rs6000/predicates.md (quad_memory_op

Re: Enabling -frename-registers?

2016-05-10 Thread Jeff Law
On 05/02/2016 07:31 AM, Jeff Law wrote: On 04/29/2016 07:32 AM, Bernd Schmidt wrote: On 04/29/2016 03:02 PM, David Edelsohn wrote: How has this show general benefit for all architectures to deserve enabling it by default at -O2? It should improve postreload scheduling in general, and it can a

Re: [PATCH], Add PowerPC ISA 3.0 vector d-form addressing

2016-05-10 Thread Michael Meissner
On Tue, May 10, 2016 at 07:06:48PM -0500, Segher Boessenkool wrote: > On Tue, May 10, 2016 at 06:39:56PM -0400, Michael Meissner wrote: > > In the last email exchange, you did not say whether the patch was acceptible > > for inclusion. I added documentation for -mlra, since you did mention it > >

Re: [PATCH 3/3] shrink-wrap: Remove complicated simple_return manipulations

2016-05-10 Thread Jan Hubicka
Hi, can you also send me the string/str(c)spn.c testcase you speak about? Honza

Re: [PATCH 3/3] shrink-wrap: Remove complicated simple_return manipulations

2016-05-10 Thread Jan Hubicka
> > Wilco Dijkstra wrote: > > > It relies on static branch probabilities, which are set completely wrong in > > GCC, > so it ends up optimizing the hot path in many functions for size > rather than speed > and visa versa. > > This sounds like the static branch prediction issue that we have b

Re: [PATCH] [rtlfe] Barebones implementation of "__RTL"; next steps?

2016-05-10 Thread Trevor Saunders
On Tue, May 10, 2016 at 05:01:00PM -0400, David Malcolm wrote: > [CCing Prasad since this may be useful for his gimple FE work, by > replacing "rtl" with "gimple" in the patch] > > On Mon, 2016-05-09 at 11:44 +0200, Richard Biener wrote: > > On Wed, May 4, 2016 at 10:49 PM, David Malcolm > > wrot

Re: [RS6000] complex long double ABI_V4 fix

2016-05-10 Thread Segher Boessenkool
On Wed, May 11, 2016 at 09:17:00AM +0930, Alan Modra wrote: > On Mon, May 09, 2016 at 09:43:36AM -0500, Segher Boessenkool wrote: > > Since this monstruous, unreadable condition is used a lot, use a nicely > > named > > helper function instead? > > Like this? Like that. Thanks! > * confi

Re: [PATCH], Add PowerPC ISA 3.0 vector d-form addressing

2016-05-10 Thread Segher Boessenkool
On Tue, May 10, 2016 at 06:39:56PM -0400, Michael Meissner wrote: > In the last email exchange, you did not say whether the patch was acceptible > for inclusion. I added documentation for -mlra, since you did mention it > should > be documented. I tweaked the -mdebug=reg output so that it always p

Re: [PATCH] PR driver/69265: add hint for options with misspelled arguments

2016-05-10 Thread Manuel López-Ibáñez
On 10/05/16 22:03, David Malcolm wrote: On Tue, 2016-05-10@22:09 +0200, Bernhard Reutner-Fischer wrote: On Mon, May 09, 2016@08:14:47PM -0400, David Malcolm wrote: - inform (loc, "valid arguments to %qs are: %s", option ->opt_text, s); + const char *hint = find_closest_string (arg, &

Re: [PATCH] Fix PR70497, missed "subreg" CSE on GIMPLE

2016-05-10 Thread H.J. Lu
On Mon, May 9, 2016 at 5:59 AM, Richard Biener wrote: > > The following patch implements CSEing of "subreg" reads from memory > like (from the testcase in the PR) > > union U { int i[16]; char c; }; > > char foo(int i) > { > union U u; > u.i[0] = i; > return u.c; > } > > CSEing u.c as (char)

Re: [RS6000] complex long double ABI_V4 fix

2016-05-10 Thread Alan Modra
On Mon, May 09, 2016 at 09:43:36AM -0500, Segher Boessenkool wrote: > On Fri, May 06, 2016 at 03:54:43PM +0930, Alan Modra wrote: > > Revision 235792 regressed compat/scalar-by-value-6 for powerpc-linux > > -m32 due to accidentally changing the ABI. By another historical > > accident, complex long

[wwwdocs] Suggested usability improvements for the website

2016-05-10 Thread aquaglow
Patch suggests changes to the main GCC website stylesheet, with the aim of improving usability: - Increase line-height (aids tracking lines of text) - Set fixed-width (for large screens only), as current line length exceeds UX guidelines for readability - Improve homepage layout and visual appeara

Re: [PATCH 2/3] cfgcleanup: Fold jumps and conditional branches with returns

2016-05-10 Thread Segher Boessenkool
On Tue, May 10, 2016 at 09:33:56PM +0200, Christophe Lyon wrote: > This patch causes an ICE on gcc.dg/20010822-1.c for target arm-none-eabi > --with-cpu=cortex-a9 That is PR71028, I sent a patch to fix it, will commit in a minute. (See https://gcc.gnu.org/ml/gcc-patches/2016-05/msg00673.html ). S

Re: [PATCH], Add PowerPC ISA 3.0 vector d-form addressing

2016-05-10 Thread Michael Meissner
In the last email exchange, you did not say whether the patch was acceptible for inclusion. I added documentation for -mlra, since you did mention it should be documented. I tweaked the -mdebug=reg output so that it always prints if LRA was used or not (previously, it only printed if LRA was true).

Re: [PATCH] PR driver/69265: add hint for options with misspelled arguments

2016-05-10 Thread David Malcolm
On Tue, 2016-05-10 at 22:09 +0200, Bernhard Reutner-Fischer wrote: > On Mon, May 09, 2016 at 08:14:47PM -0400, David Malcolm wrote: > > > - inform (loc, "valid arguments to %qs are: %s", option > > ->opt_text, s); > > + const char *hint = find_closest_string (arg, &candidates); > > +

[PATCH] [rtlfe] Barebones implementation of "__RTL"; next steps?

2016-05-10 Thread David Malcolm
[CCing Prasad since this may be useful for his gimple FE work, by replacing "rtl" with "gimple" in the patch] On Mon, 2016-05-09 at 11:44 +0200, Richard Biener wrote: > On Wed, May 4, 2016 at 10:49 PM, David Malcolm > wrote: > > This patch kit introduces an RTL frontend, for the purpose > > of u

[patch,openacc] use firstprivate pointers for subarrays in c and c++

2016-05-10 Thread Cesar Philippidis
Pointers are special in OpenACC. Depending on the context, they can either be treated as a "scalar" or as special firstprivate pointer. This is in contrast to OpenMP target pointers, which are always treated as firstprivate pointers if I'm not mistaken. The difference between a firstprivate scalar

[patch] Tidy up RTL libfunc machinery

2016-05-10 Thread Eric Botcazou
Hi, this patch is aimed at cleaning up the mess with the RTL libfunc machinery. On the one hand you have comments like these in the RTL expander: /* It is incorrect to use the libcall calling conventions to call memcpy in this context. This could be a user call to memcpy and the use

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-05-10 Thread Joseph Myers
On Sat, 9 Apr 2016, Mikhail Maltsev wrote: > gcc/c/ChangeLog: > > 2016-04-08 Mikhail Maltsev > > PR c/43651 > * c-decl.c (declspecs_add_qual): Warn when -Wduplicate-decl-specifier > is enabled. > * c-errors.c (pedwarn_c90): Return true if warned. > * c-

Re: [PATCH] PR driver/69265: add hint for options with misspelled arguments

2016-05-10 Thread Bernhard Reutner-Fischer
On Mon, May 09, 2016 at 08:14:47PM -0400, David Malcolm wrote: > - inform (loc, "valid arguments to %qs are: %s", option->opt_text, s); > + const char *hint = find_closest_string (arg, &candidates); > + if (hint) > + inform (loc, "valid arguments to %qs are: %s; did you mean %qs

Re: [ARM] Enable __fp16 as a function parameter and return type.

2016-05-10 Thread Joseph Myers
On Tue, 3 May 2016, Matthew Wahab wrote: > > This patch addresses one incompatibility of the original __fp16 > > specification with the more recent ACLE specification and the > > specification in ISO/IEC TS 18661-3 for how such types should work. > > Another such incompatibility is the peculiar

Re: [PATCH] Remove TARGET_INVALID_PARAMETER_TYPE and TARGET_INVALID_RETURN_TYPE hooks.

2016-05-10 Thread Joseph Myers
On Tue, 3 May 2016, Matthew Wahab wrote: > Hello, > > The target hooks TARGET_INVALID_PARAMETER_TYPE and > TARGET_INVALID_RETURN_TYPE were only used by the ARM backend and > are no longer used. This patch removes them. > > Tested for arm-none-linux-gnueabihf with native bootstrap and make check

Re: [PATCH] x86 interrupt attribute patch [2/2]

2016-05-10 Thread Sandra Loosemore
On 04/20/2016 07:42 AM, Koval, Julia wrote: diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index a5a8b23..82de5bf 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -5263,6 +5263,83 @@ On x86-32 targets, the @code{stdcall} attribute causes the compiler to assume that the call

Re: [PATCH 2/3] cfgcleanup: Fold jumps and conditional branches with returns

2016-05-10 Thread Christophe Lyon
On 3 May 2016 at 08:59, Segher Boessenkool wrote: > This patch makes cfgcleanup optimize jumps to returns. There are three > cases this handles: > > -- A jump to a return; this is simplified to just that return. > -- A conditional branch to a return; simplified to a conditional return. > -- A con

Re: [PATCH][CilkPlus] Allow parenthesized initialization in for-loops

2016-05-10 Thread Ilya Verbin
On Fri, Mar 25, 2016 at 18:23:23 +0300, Ilya Verbin wrote: > On Mon, Mar 21, 2016 at 15:58:18 +0100, Jakub Jelinek wrote: > > On Mon, Mar 21, 2016 at 05:45:52PM +0300, Ilya Verbin wrote: > > > www.cilkplus.org/sites/default/files/open_specifications/Intel_Cilk_plus_lang_spec_1.2.htm > > > says: > >

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-10 Thread Christophe Lyon
On 10 May 2016 at 19:18, Ilya Verbin wrote: > On Tue, May 10, 2016 at 14:36:36 +0100, Ramana Radhakrishnan wrote: >> On Tue, May 10, 2016 at 2:02 PM, Christophe Lyon >> wrote: >> > On 9 May 2016 at 15:34, Christophe Lyon wrote: >> >> On 9 May 2016 at 15:29, Jeff Law wrote: >> >>> On 05/09/2016

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-05-10 Thread Bernhard Reutner-Fischer
On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang wrote: >Hi, this patch resolves an ICE for Fortran when using the OpenACC >host_data directive. Actually, rather than say resolve, it's more like >adjusting the front-end to same middle-end restrictions as C/C++, >namely that we only support po

Re: [PATCH] Fix PR70497, missed "subreg" CSE on GIMPLE

2016-05-10 Thread Bernhard Reutner-Fischer
On May 9, 2016 3:42:21 PM GMT+02:00, Richard Biener wrote: >On Mon, 9 May 2016, Marc Glisse wrote: > >> On Mon, 9 May 2016, Richard Biener wrote: s/ROCDE/RCODE/ Thanks,

C PATCH to add -Wswitch-unreachable (PR c/49859)

2016-05-10 Thread Marek Polacek
Over the years, we got several PRs that suggested to add a warning that would warn about unreachable statements between `switch (cond)' and the first case. In some cases our -Wuninitialized warning can detect such a case, but mostly not. This patch is an attempt to add a proper warning about this

Re: [PATCH 4/4] Initial version of RTL frontend

2016-05-10 Thread Bernd Schmidt
On 05/10/2016 08:05 PM, Richard Biener wrote: On May 10, 2016 7:02:33 PM GMT+02:00, Jeff Law wrote: Well, not if we take Bernd's idea and create a new backend for testing purposes. If we want to know/test what reload's doing, we cons up the appropriate RTL for that testing backend, set the rig

Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass

2016-05-10 Thread H.J. Lu
On Tue, May 10, 2016 at 9:19 AM, Ilya Enkovich wrote: > Hi, > > Curretly CSE may modify CFG and leave invalid dominance info. This patch > improves track of CFG changes by CSE passes and frees dominance info if > required. This allows to remove corresponding workaround from STV pass. > > Does it

Re: [PATCH 4/4] Initial version of RTL frontend

2016-05-10 Thread Richard Biener
On May 10, 2016 7:02:33 PM GMT+02:00, Jeff Law wrote: >On 05/10/2016 08:17 AM, Richard Biener wrote: >> On Tue, May 10, 2016 at 4:13 PM, David Malcolm >wrote: >>> On Wed, 2016-05-04 at 16:49 -0400, David Malcolm wrote: >>> [...snip...] I wrote this by compiling a test.c with -fdump-rtl-

Re: [PATCH] Simplify read-md.c and read-rtl.c using require_char_ws

2016-05-10 Thread Bernd Schmidt
On 05/10/2016 08:10 PM, David Malcolm wrote: +/* Consume any whitespace, then consume the next non-whitespace + character, issuing a fatal error if it is not EXPECTED. */ + +void require_char_ws (char expected) Formatting. Otherwise ok. Bernd

Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass

2016-05-10 Thread Bernd Schmidt
On 05/10/2016 07:36 PM, Richard Biener wrote: The policy for passes is to only free dominator info if they wreck it. They have to expect it being present but can also choose to free it early of course. Seems like a policy that's inviting surprises such as this one, but if this is the case, t

Re: [gomp4.5] Parsing of most of OpenMP 4.5 clauses

2016-05-10 Thread Jerry DeLisle
On 05/07/2016 11:42 AM, Paul Richard Thomas wrote: > Dear Jakub, > > As you might have noticed, I am forced to spend a couple of months out > from gfortran support in order to move from France back to the UK. I > am therefore dealing very sporadically with patches. Since we seem to > have entered

[PATCH] Simplify read-md.c and read-rtl.c using require_char_ws

2016-05-10 Thread David Malcolm
read-md.c and read-rtl.c repeatedly use this pattern: c = read_skip_spaces (); if (c != ')') fatal_expected_char (')', c); Simplify them by introduce a helper function to do this. Successfully bootstrapped®rtested on x86_64-pc-linux-gnu. OK for trunk? gcc/ChangeLog: * rea

Re: [PATCH] Fix PR70937

2016-05-10 Thread Jerry DeLisle
On 05/09/2016 12:41 AM, Richard Biener wrote: > On Fri, 6 May 2016, Richard Biener wrote: > >> On Fri, 6 May 2016, Richard Biener wrote: >> >>> >>> The following patch fixes another case of missing DECL_EXPR in the FE. >>> >>> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. >>> >>>

Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass

2016-05-10 Thread Richard Biener
On May 10, 2016 7:17:59 PM GMT+02:00, Bernd Schmidt wrote: >On 05/10/2016 07:06 PM, Richard Biener wrote: >> >> Dominators are never freed. > >Not sure what you're trying to say here. There's lots of calls to >free_dominance_info in the tree and obviously we need to do something >to >prevent the

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-10 Thread Ilya Verbin
On Tue, May 10, 2016 at 14:36:36 +0100, Ramana Radhakrishnan wrote: > On Tue, May 10, 2016 at 2:02 PM, Christophe Lyon > wrote: > > On 9 May 2016 at 15:34, Christophe Lyon wrote: > >> On 9 May 2016 at 15:29, Jeff Law wrote: > >>> On 05/09/2016 01:37 AM, Christophe Lyon wrote: > After this m

Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass

2016-05-10 Thread Bernd Schmidt
On 05/10/2016 07:06 PM, Richard Biener wrote: Dominators are never freed. Not sure what you're trying to say here. There's lots of calls to free_dominance_info in the tree and obviously we need to do something to prevent the bug Ilya is trying to fix. Bernd

Re: [PATCH 3/3] shrink-wrap: Remove complicated simple_return manipulations

2016-05-10 Thread David Edelsohn
> Wilco Dijkstra wrote: > It relies on static branch probabilities, which are set completely wrong in > GCC, so it ends up optimizing the hot path in many functions for size rather than speed and visa versa. This sounds like the static branch prediction issue that we have been discussing wit

[PATCH, i386]: Merge 64-bit and 32-bit gotoff_operand code paths in legitimize_pic_address

2016-05-10 Thread Uros Bizjak
Hello! This patch merges 64-bit and 32-bit gotoff_operand code paths in legitimize_pic_address. Also, the patch uses copy_to_suggested_reg, which seems to be invented just for this purpose. Also, expand_simple_binop will ouput to suggested target reg by itself, so there is no need to emit separate

Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass

2016-05-10 Thread Richard Biener
On May 10, 2016 6:59:31 PM GMT+02:00, Bernd Schmidt wrote: >On 05/10/2016 06:19 PM, Ilya Enkovich wrote: >> Curretly CSE may modify CFG and leave invalid dominance info. This >patch >> improves track of CFG changes by CSE passes and frees dominance info >if >> required. This allows to remove cor

Re: [PATCH 4/4] Initial version of RTL frontend

2016-05-10 Thread Jeff Law
On 05/10/2016 08:17 AM, Richard Biener wrote: On Tue, May 10, 2016 at 4:13 PM, David Malcolm wrote: On Wed, 2016-05-04 at 16:49 -0400, David Malcolm wrote: [...snip...] I wrote this by compiling a test.c with -fdump-rtl-all on x86_64-pc-linux-gnu, and then attempting to load the state at each

Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass

2016-05-10 Thread Bernd Schmidt
On 05/10/2016 06:19 PM, Ilya Enkovich wrote: Curretly CSE may modify CFG and leave invalid dominance info. This patch improves track of CFG changes by CSE passes and frees dominance info if required. This allows to remove corresponding workaround from STV pass. Does it look OK? Better tracki

Re: [PATCH 3/3] shrink-wrap: Remove complicated simple_return manipulations

2016-05-10 Thread Wilco Dijkstra
>> The new version does not seem better, as it adds a branch on the path >> and it is not smaller. > > That looks like bb-reorder isn't doing its job? Maybe it thinks that > pop is too expensive to copy? It relies on static branch probabilities, which are set completely wrong in GCC, so it ends u

[PATCH, PR middle-end/70807] Free dominance info in CSE pass

2016-05-10 Thread Ilya Enkovich
Hi, Curretly CSE may modify CFG and leave invalid dominance info. This patch improves track of CFG changes by CSE passes and frees dominance info if required. This allows to remove corresponding workaround from STV pass. Does it look OK? Bootstrapped and regtested on x86-64-unknown-linux-gnu.

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-10 Thread Ilya Verbin
On Mon, May 09, 2016 at 11:39:51 +0200, Matthias Klose wrote: > >well, it breaks the build for many multilib configurations where multilib > >binaries cannot be run on the current environment, e.g. building x32 > >multilibs > >on a kernel which doesn't have x32 enabled. > > > >The reason is again

[PATCH, CHKP, PR middle-end/70877] Support instrumentation of direct calls with a type cast

2016-05-10 Thread Ilya Enkovich
Hi, Currently instrumentation ignores call type for direct calls. This patch fixes it to enable direct calls where function is casted to another function type. Bootstrapped and regtested on x86_64-unknown-linux-gnu on MPX enabled hardware. I'm going to port this patch to gcc-6-branch. Thanks,

Re: [PATCH] Apply fix for PR68463 to RS6000

2016-05-10 Thread Ilya Verbin
On Tue, May 10, 2016 at 11:48:53 -0400, David Edelsohn wrote: > On Tue, May 10, 2016 at 11:39 AM, James Norris > wrote: > > The fix for PR68463 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68463) > > was missing code that prevented the fix from working on RS6000. The > > attached patch adds the

Re: [PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Pierre-Marie de Rodat
On 05/10/2016 05:20 PM, Jakub Jelinek wrote: gcc/ * dwarf2out.c (resolve_args_picking_1): Consider DW_OP_neg as an unary operation, not a binary one. Ok. This is committed. Thank you Jakub for the quick feedback! -- Pierre-Marie de Rodat

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-10 Thread Joseph Myers
On Tue, 10 May 2016, Bernd Schmidt wrote: > I think Andreas' concern is that this might need to have a "ll" suffix. The > simplest option might be to use the HOST_WIDE_INT_C macro, and then > HOST_WIDE_INT_PRINT_DEC for the error message. HOST_WIDE_INT_PRINT_DEC is a host printf format, not a for

Re: [PATCH] libstdc++/71038 fix error checks in filesystem::copy_file

2016-05-10 Thread Jonathan Wakely
On 10/05/16 17:40 +0200, Jacques du Rand wrote: How do i unsubscribe? The same way you subscribed, or by looking at the headers of mails from the list, or by using the form at https://gcc.gnu.org/lists.html

[PATCH, CHKP, PR tree-optimization/70876] Support WITH_SIZE_EXPR in instrumented calls

2016-05-10 Thread Ilya Enkovich
Hi, This patch adds WITH_SIZE_EXPR operands in instrumented calls. It also adds check for args passed by reference on call expand to correctly bind arg and its bounds. Bootstrapped and regtested on x86_64-unknown-linux-gnu on MPX enabled machine. Applied to trunk. I'm going to port it to gcc-6

[PATCH] Test begin and end functions for directory iterators

2016-05-10 Thread Jonathan Wakely
A minor fix for missing noexcept qualifiers, pointed out by Eric again. * include/experimental/bits/fs_dir.h (begin, end): Add noexcept. * testsuite/experimental/filesystem/iterators/directory_iterator.cc: Test begin and end functions. * testsuite/experimental/file

Re: [PATCH, i386, PR target/70799, 1/2] Support constants in STV pass (DImode)

2016-05-10 Thread Uros Bizjak
On Tue, May 10, 2016 at 5:41 PM, Ilya Enkovich wrote: > On 02 May 10:50, Uros Bizjak wrote: >> On Fri, Apr 29, 2016 at 5:42 PM, Ilya Enkovich >> wrote: >> > Hi, >> > >> > As the first part of PR70799 fix I'd like to add constants support for >> > DI-STV pass (which is also related to PR70763).

Re: [PATCH] Apply fix for PR68463 to RS6000

2016-05-10 Thread David Edelsohn
On Tue, May 10, 2016 at 11:39 AM, James Norris wrote: > Hi! > > The fix for PR68463 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68463) > was missing code that prevented the fix from working on RS6000. The > attached patch adds the missing code for RS6000. > > Bootstrapped and regtested on Power8

Re: [PATCH, i386, PR target/70799, 1/2] Support constants in STV pass (DImode)

2016-05-10 Thread Ilya Enkovich
On 02 May 10:50, Uros Bizjak wrote: > On Fri, Apr 29, 2016 at 5:42 PM, Ilya Enkovich wrote: > > Hi, > > > > As the first part of PR70799 fix I'd like to add constants support for > > DI-STV pass (which is also related to PR70763). This patch adds CONST_INT > > support as insn operands and extends

[PATCH] Test begin and end functions for directory iterators

2016-05-10 Thread redi
A minor fix for missing noexcept qualifiers, pointed out by Eric again. * include/experimental/bits/fs_dir.h (begin, end): Add noexcept. * testsuite/experimental/filesystem/iterators/directory_iterator.cc: Test begin and end functions. * testsuite/experimental/file

[PATCH] Apply fix for PR68463 to RS6000

2016-05-10 Thread James Norris
Hi! The fix for PR68463 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68463) was missing code that prevented the fix from working on RS6000. The attached patch adds the missing code for RS6000. Bootstrapped and regtested on Power8. OK for trunk? Thanks! Jim = ChangeLog * con

[PATCH] libstdc++/71038 fix error checks in filesystem::copy_file

2016-05-10 Thread Jonathan Wakely
This is a very silly error, but only shows up when !_GLIBCXX_USE_SENDFILE so I missed it. PR libstdc++/71038 * src/filesystem/ops.cc (do_copy_file): Fix backwards conditions. * testsuite/experimental/filesystem/operations/copy_file.cc: New test. Tested x86_64-linux and x8

Re: [PATCH] x86 interrupt attribute patch [2/2]

2016-05-10 Thread Uros Bizjak
On Tue, May 10, 2016 at 4:54 PM, Koval, Julia wrote: > Gentle ping. > > -Original Message- > From: Koval, Julia > Sent: Wednesday, April 20, 2016 4:42 PM > To: gcc-patches@gcc.gnu.org > Cc: Lu, Hongjiu ; vaalfr...@gmail.com; > ubiz...@gmail.com; l...@redhat.com; Zamyatin, Igor > Subject:

Re: [PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Jakub Jelinek
On Tue, May 10, 2016 at 05:06:59PM +0200, Pierre-Marie de Rodat wrote: > When the DWARF back-end generates DW_OP_neg operations in DWARF > procedures, we get an ICE because of inconsistent stack usage > computation for the embedding expression. This is because > resolve_args_picking_1 thinks DW_OP_

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope

2016-05-10 Thread Jakub Jelinek
On Tue, May 10, 2016 at 05:03:30PM +0200, Martin Liška wrote: > On 05/06/2016 04:39 PM, Jakub Jelinek wrote: > > Depends on how exactly it is defined. It could be enabling just its own > > sanitizer bit and nothing else, then users would need to use > > -fsanitize=address,use-after-scope > > or >

[PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Pierre-Marie de Rodat
Hello, When the DWARF back-end generates DW_OP_neg operations in DWARF procedures, we get an ICE because of inconsistent stack usage computation for the embedding expression. This is because resolve_args_picking_1 thinks DW_OP_neg is a binary operation (pops 2 stack slots, pushes 1) whereas it rea

Re: [PATCH vs] Take known zero bits into account when checking extraction.

2016-05-10 Thread Bernd Schmidt
On 05/10/2016 03:06 PM, Dominik Vogt wrote: + int cost_of_and; + int cost_of_zero_ext; + + cost_of_and = rtx_cost (x, mode, in_code, 1, speed_p); + cost_of_zero_ext = rtx_cost (temp, mode, in_code, 1, speed_p); + if (

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope

2016-05-10 Thread Martin Liška
On 05/06/2016 04:39 PM, Jakub Jelinek wrote: > Depends on how exactly it is defined. It could be enabling just its own > sanitizer bit and nothing else, then users would need to use > -fsanitize=address,use-after-scope > or > -fsanitize=kernel-address,use-after-scope I'm inclined to the second op

RE: [PATCH] x86 interrupt attribute patch [2/2]

2016-05-10 Thread Koval, Julia
Gentle ping. -Original Message- From: Koval, Julia Sent: Wednesday, April 20, 2016 4:42 PM To: gcc-patches@gcc.gnu.org Cc: Lu, Hongjiu ; vaalfr...@gmail.com; ubiz...@gmail.com; l...@redhat.com; Zamyatin, Igor Subject: [PATCH] x86 interrupt attribute patch [2/2] Hi, Here is the new vers

Re: [PATCH 4/4] Initial version of RTL frontend

2016-05-10 Thread Richard Biener
On Tue, May 10, 2016 at 4:13 PM, David Malcolm wrote: > On Wed, 2016-05-04 at 16:49 -0400, David Malcolm wrote: > [...snip...] >> >> I wrote this by compiling a test.c with -fdump-rtl-all on >> x86_64-pc-linux-gnu, and then attempting to load the state at each >> pass, and then trying to run just

Re: [PATCH 4/4] Initial version of RTL frontend

2016-05-10 Thread David Malcolm
On Wed, 2016-05-04 at 16:49 -0400, David Malcolm wrote: [...snip...] > > I wrote this by compiling a test.c with -fdump-rtl-all on > x86_64-pc-linux-gnu, and then attempting to load the state at each > pass, and then trying to run just one pass, and fixing bugs until the > dump output from each pa

Re: [PATCH GCC]Do more tree if-conversions by handlding PHIs with more than two arguments.

2016-05-10 Thread Bin.Cheng
On Tue, May 10, 2016 at 3:00 PM, Christophe Lyon wrote: > On 3 May 2016 at 11:07, Bin.Cheng wrote: >> On Mon, May 2, 2016 at 10:02 AM, Richard Biener >> wrote: >>> On Fri, Apr 29, 2016 at 5:51 PM, Bin.Cheng wrote: On Thu, Apr 28, 2016 at 10:18 AM, Richard Biener wrote: > On Wed,

Re: [PATCH GCC]Do more tree if-conversions by handlding PHIs with more than two arguments.

2016-05-10 Thread Christophe Lyon
On 3 May 2016 at 11:07, Bin.Cheng wrote: > On Mon, May 2, 2016 at 10:02 AM, Richard Biener > wrote: >> On Fri, Apr 29, 2016 at 5:51 PM, Bin.Cheng wrote: >>> On Thu, Apr 28, 2016 at 10:18 AM, Richard Biener >>> wrote: On Wed, Apr 27, 2016 at 5:49 PM, Bin Cheng wrote: > Hi, > Curren

Re: [PATCH, GCC] PR middle-end/55299, fold bitnot through ASR and rotates

2016-05-10 Thread Mikhail Maltsev
On 05/08/2016 10:57 PM, Marc Glisse wrote: > On Sun, 8 May 2016, Mikhail Maltsev wrote: > >> Hi! >> >> I decided to revive this patch: >> https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00999.html. >> I addressed review comments about sign conversions. Bootstrapped and >> regtested >> on x86_64-lin

[PATCH] libstdc++/71036 Handle EEXIST in filesystem::create_directory

2016-05-10 Thread Jonathan Wakely
Another bug Eric noticed. I had tests for create_directories() but not create_directory(), and the former was already checking whether it existed or not, so I didn't notice this bug. PR libstdc++/71036 * src/filesystem/ops.cc (create_dir): Handle EEXIST from mkdir. * tests

Re: [PATCH vs] Take known zero bits into account when checking extraction.

2016-05-10 Thread Dominik Vogt
New version of the patch including the changes Jeff requested. * Reformatted code. * Including test cases (unfortunately requires lp64 although the feature does not). * Bootstrapped and regression tested on s390, s390x, x86_64. On Wed, Apr 27, 2016 at 09:20:05AM +0100, Dominik Vogt wrote: >

[committed] Add debugging ruler to diagnostic-show-locus.c

2016-05-10 Thread David Malcolm
When debugging diagnostic-show-locus.c, it's invaluable to have a "ruler" showing column numbers. This patch adds in support via a new "show_ruler_p" flag within the diagnostic_context. There's no direct way for end-users to enable this, but plugins can enable it by setting the flag, so the plugi

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-10 Thread Ramana Radhakrishnan
On Tue, May 10, 2016 at 2:02 PM, Christophe Lyon wrote: > On 9 May 2016 at 15:34, Christophe Lyon wrote: >> On 9 May 2016 at 15:29, Jeff Law wrote: >>> On 05/09/2016 01:37 AM, Christophe Lyon wrote: >>> Hi, After this merge, I'm seeing lots of timeouts on arm (using QEMU). Is

[PATCH, ARM] Do not set ARM_ARCH_ISA_THUMB for armv5

2016-05-10 Thread Thomas Preudhomme
Hi, ARM_ARCH_ISA_THUMB is currently set to 1 when compiling for armv5 despite armv5 not supporting Thumb instructions (armv5t does): arm-none-eabi-gcc -dM -march=armv5 -E - < /dev/null | grep ISA_THUMB #define __ARM_ARCH_ISA_THUMB 1 The reason is TARGET_ARM_ARCH_ISA_THUMB being set to 1 if targ

[PATCH] Fix PR70986

2016-05-10 Thread Richard Biener
ifcvt is confused about fake edges not being loop exits which the following fixes. Bootstrap / regtest pending on x86_64-unknown-linux-gnu. Richard. 2016-05-10 Richard Biener PR tree-optimization/70986 * cfganal.c: Include cfgloop.h. (connect_infinite_loops_to_exit)

Re: [PATCH 3/3] Enhance dumps of IVOPTS

2016-05-10 Thread Bin.Cheng
On Mon, May 9, 2016 at 10:46 AM, Richard Biener wrote: > On Fri, May 6, 2016 at 11:19 AM, Martin Liška wrote: >> Hi. >> >> Honza asked me to explain the change more verbosely. >> The patch simplify enhances verbose dump of IVOPTS so that >> # of iterations is printed. Apart from that it also prin

Re: [PATCH] libstdc++/71005 fix post-increment for filesystem iterators

2016-05-10 Thread Jonathan Wakely
On 10/05/16 12:25 +0100, Jonathan Wakely wrote: Eric pointed out that the post-increment operator on filesystem directory iterators was returning the incremented value, because the returnedobject shared its state with the incremented iterator. This makes post-increment return a proxy, which cont

[PTX] Fixup some tests

2016-05-10 Thread Nathan Sidwell
I've committed this to annotate some failing tests. The alloca and label-requiring tests won't work on ptx, and it appears the default for the target-specific tests has changed to 'run', so mark these as compile-time. nathan 2016-05-10 Nathan Sidwell * gcc.dg/nested-func-10.c: Requires

[PATCH] Fix PR71039

2016-05-10 Thread Richard Biener
The following fixes PR71039 - we were failing to verify we can insert the lhs on the predecessor edges. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2016-05-10 Richard Biener PR tree-optimization/71039 * tree-ssa-phiprop.c: Include tree-ssa-loop.h.

[PATCH] libstdc++/71036 Handle EEXIST in filesystem::create_directory

2016-05-10 Thread redi
Another bug Eric noticed. I had tests for create_directories() but not create_directory(), and the former was already checking whether it existed or not, so I didn't notice this bug. PR libstdc++/71036 * src/filesystem/ops.cc (create_dir): Handle EEXIST from mkdir. * tests

Re: [PATCH][CilkPlus] Merge libcilkrts from upstream

2016-05-10 Thread Christophe Lyon
On 9 May 2016 at 15:34, Christophe Lyon wrote: > On 9 May 2016 at 15:29, Jeff Law wrote: >> On 05/09/2016 01:37 AM, Christophe Lyon wrote: >> >>> >>> Hi, >>> After this merge, I'm seeing lots of timeouts on arm (using QEMU). >>> Is this "expected"? (as in: should I increase my timeout value) >> >

[PATCH] libstdc++/71037 Add base path to filesystem::canonical exceptions

2016-05-10 Thread Jonathan Wakely
A very simple one. PR libstdc++/71037 * src/filesystem/ops.cc (canonical(const path&, const path&)): Add base path to exception. * testsuite/experimental/filesystem/operations/canonical.cc: Test paths contained in exception. Tested x86_64-linux, committed

Re: [PATCH, rs6000] Fix PR70963: Wrong code for V2DF/V2DI vec_cts with zero scale factor

2016-05-10 Thread Bill Schmidt
> On May 10, 2016, at 3:25 AM, Segher Boessenkool > wrote: > > Hi Bill, > > On Mon, May 09, 2016 at 10:00:31PM -0500, Bill Schmidt wrote: >> PR70963 reports a problem with vec_cts when used to convert vector double to >> vector long long. >> This is due to a register with an undefined value t

[PATCH] Remove unused using declaration in libstdc++ testsuite

2016-05-10 Thread Jonathan Wakely
A minor tweak. Tested x86_64-linux, committed to trunk. commit 68e7dfdee8a53d5d18357b654a84221dc5a5529e Author: Jonathan Wakely Date: Tue May 10 13:02:09 2016 +0100 * testsuite/experimental/type_erased_allocator/2.cc: Remove unused using declaration. diff --git a/libstdc++-v3

Re: [PATCH] Don't emit AVX512DQ insns for -mavx512vl -mno-avx512dq (PR target/70927, take 2)

2016-05-10 Thread Kirill Yukhin
Hi Jakub, On 09 May 18:43, Jakub Jelinek wrote: > On Tue, May 03, 2016 at 08:23:28PM +0200, Jakub Jelinek wrote: > > While working on a patch I'm going to post momentarily, I've noticed that > > we sometimes emit AVX512DQ specific instructions even when avx512dq is not > > enabled (in particular, E

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-10 Thread Bernd Schmidt
On 05/06/2016 01:26 AM, Eduard Sanou wrote: errno = 0; epoch = strtoll (source_date_epoch, &endptr, 10); - if ((errno == ERANGE && (epoch == LLONG_MAX || epoch == LLONG_MIN)) - || (errno != 0 && epoch == 0)) -fatal_error (UNKNOWN_LOCATION, "environment variable $SOURCE_DATE_EPO

[PATCH] libstdc++/71005 fix post-increment for filesystem iterators

2016-05-10 Thread Jonathan Wakely
Eric pointed out that the post-increment operator on filesystem directory iterators was returning the incremented value, because the returnedobject shared its state with the incremented iterator. This makes post-increment return a proxy, which contains the directory_entry value before the increme

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-10 Thread Andreas Schwab
Dhole writes: > On 16-05-06 08:26:07, Andreas Schwab wrote: >> Eduard Sanou writes: >> >> > diff --git a/gcc/c-family/c-common.h b/gcc/c-family/c-common.h >> > index 1714284..dea2900 100644 >> > --- a/gcc/c-family/c-common.h >> > +++ b/gcc/c-family/c-common.h >> > @@ -1086,6 +1086,16 @@ extern

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-10 Thread Dhole
On 16-05-09 13:01:12, Bernd Schmidt wrote: > >Wouldn't it be better to add a more general directive, e.g. one that would > >allow setting any env var for the compiler, rather than one specific, > >similarly to how dg-set-target-env-var allows any env var to be set for the > >execution? dg-set-comp

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-05-10 Thread Dhole
On 16-05-06 08:26:07, Andreas Schwab wrote: > Eduard Sanou writes: > > > diff --git a/gcc/c-family/c-common.h b/gcc/c-family/c-common.h > > index 1714284..dea2900 100644 > > --- a/gcc/c-family/c-common.h > > +++ b/gcc/c-family/c-common.h > > @@ -1086,6 +1086,16 @@ extern vec *make_tree_vector_cop

Re: [PATCH] cfgcleanup: Handle a branch with just a return in both arms (PR71028)

2016-05-10 Thread Bernd Schmidt
On 05/10/2016 09:55 AM, Segher Boessenkool wrote: PR rtl-optimization/71028 * cfgcleanup.c (try_optimize_cfg): Do not flip a conditional jump with just a return in the fallthrough block if the branch block contains just a returns as well. Looks good. Bernd

Re: [PATCH] Take known zero bits into account when checking extraction.

2016-05-10 Thread Richard Biener
On Tue, May 10, 2016 at 12:07 PM, Dominik Vogt wrote: > On Tue, May 10, 2016 at 11:14:35AM +0200, Richard Biener wrote: >> On Mon, May 9, 2016 at 3:36 PM, Marc Glisse wrote: >> > On Mon, 9 May 2016, Dominik Vogt wrote: >> > >> >> This turns out to be quite difficult. A small test function >> >>

  1   2   >