Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
On 11/01/16 22:31, Jason Merrill wrote: > On Tue, Nov 1, 2016 at 4:00 PM, Bernd Edlinger > wrote: >> On 11/01/16 20:48, Jason Merrill wrote: else if ((DECL_EXTERN_C_P (newdecl) && DECL_EXTERN_C_P (olddecl)) || compparms (T

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
On 11/02/16 07:11, Bernd Edlinger wrote: > On 11/01/16 19:15, Bernd Edlinger wrote: >> On 11/01/16 18:11, Jason Merrill wrote: >>> On Tue, Nov 1, 2016 at 11:45 AM, Bernd Edlinger >>> wrote: On 11/01/16 16:20, Jason Merrill wrote: > On 10/17/2016 03:18 PM, Bernd Edlinger wrote: > I'm n

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
On 11/01/16 19:15, Bernd Edlinger wrote: > On 11/01/16 18:11, Jason Merrill wrote: >> On Tue, Nov 1, 2016 at 11:45 AM, Bernd Edlinger >> wrote: >>> On 11/01/16 16:20, Jason Merrill wrote: On 10/17/2016 03:18 PM, Bernd Edlinger wrote: I'm not even sure we need a new warning. Can we combi

Re: [PATCH 0/3] use rtx_insn * more

2016-11-01 Thread Trevor Saunders
On Mon, Oct 31, 2016 at 07:37:54AM -0600, Jeff Law wrote: > On 10/28/2016 01:13 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > HI, > > > > This series changes various variables type from rtx to rtx_insn * so that > > the > > remaining patches in this series > > http://gc

Re: [Aarch64] Variant field

2016-11-01 Thread Andrew Pinski
On Fri, Oct 28, 2016 at 10:56 AM, Andrew Pinski wrote: > On Fri, Oct 28, 2016 at 10:50 AM, Benedikt Huber > wrote: >> Hi, >> >> In the aarch64 backend we would need VARIANT field in AARCH64_CORE to >> specify and detect >> variants of xgene. >> >> I found this patch of Andrew Pinski >> https://g

Re: [PATCH] enhance buffer overflow warnings (and c/53562)

2016-11-01 Thread Martin Sebor
On 11/01/2016 01:14 PM, Jakub Jelinek wrote: On Tue, Nov 01, 2016 at 01:12:55PM -0600, Jeff Law wrote: On 11/01/2016 08:10 AM, Jakub Jelinek wrote: On Mon, Oct 31, 2016 at 08:39:15PM -0600, Martin Sebor wrote: Attached is an updated patch that works around the problem with the definition of th

[PATCH] Update my email address in MAINTAINERS

2016-11-01 Thread Josh Conner
Glad to be back. - Josh 2016-11-01 Josh Conner * MAINTAINERS (Write After Approval): Update email address. MAINTAINERS.patch Description: Binary data

[PATCH, rs6000] Fold vector addition built-ins in GIMPLE

2016-11-01 Thread Bill Schmidt
Hi, As Jakub suggested in response to my *ahem* ornate patch for overloaded function built-ins, a much better approach is to use the existing machinery for overloading and then immediately fold the specific functions during gimplification. There is a target hook available for this purpose that we

Re: [PATCH, Fortran] New warning flag -Wargument-mismatch to control argument mismatch warnings

2016-11-01 Thread Jerry DeLisle
On 11/01/2016 12:38 PM, Fritz Reese wrote: See attached... Good to go. --- Fritz Reese On Tue, Nov 1, 2016 at 11:24 AM, Fritz Reese wrote: All, Here I propose a new warning flag -Wargument-mismatch to control warnings emitted when the type, rank, or some other property of actual ar

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Mark Wielaard
On Wed, 2016-11-02 at 00:08 +0100, Mark Wielaard wrote: > That seemed to have been the last usage of origin_die in gen_variable_die. > So removing that caused: > > /home/mark/src/gcc/gcc/dwarf2out.c: In function ‘void gen_variable_die(tree, > tree, dw_die_ref)’: > /home/mark/src/gcc/gcc/dwarf2out

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Mark Wielaard
On Tue, Nov 01, 2016 at 01:20:23PM -0400, Jason Merrill wrote: > On Tue, Nov 1, 2016@12:10 PM, Jakub Jelinek wrote: > > + && !get_AT (var_die, DW_AT_inline) > > + && (origin_die == NULL || get_AT (origin_die, DW_AT_inline) == > > NULL) > > Can we drop this repetition (here and fo

Re: [BUILDROBOT] dwarf2out.c:22452:14: error: variable ‘origin_die’ set but not used [-Werror=unused-but-set-variable]

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 11:34:08PM +0100, Jan-Benedict Glaw wrote: > Hi Jakub! > > Seems this patch caused some breakage when building via > config-list.mk with a recent compiler (ie. with itself) : > > +2016-11-01 Jakub Jelinek > + > + * dwarf2out.c (add_name_and_src_coords_attributes):

Re: [PATCH] libiberty: Fix memory leak in ada_demangle when symbol cannot be demangled.

2016-11-01 Thread Ian Lance Taylor
On Mon, Oct 31, 2016 at 2:57 AM, Mark Wielaard wrote: > > libiberty/ChangeLog: > > * cplus-dem.c (ada_demangle): Initialize demangled to NULL and > XDELETEVEC demangled when unknown. This is OK. Thanks. Ian

[PATCH 2/2, expand] make expand_builtin_strncmp more general

2016-11-01 Thread Aaron Sawdey
This patch adds code to expand_builtin_strncmp so it also attempts expansion via cmpstrnsi in the case where c_strlen() returns NULL for both string arguments, meaning that neither one is a constant. -- Aaron Sawdey, Ph.D. acsaw...@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782

[PATCH 1/2, i386] cmpstrnsi needs string length

2016-11-01 Thread Aaron Sawdey
This patch adds a test to the cmpstrnsi pattern in i386.md so that it will bail out (FAIL) if neither of the strings is a constant string. It can only work as a proper strncmp if the length is not longer than both of the strings. This change is required if expand_builtin_strncmp is going to try exp

[PATCH 0/2] strncmp builtin expansion improvement

2016-11-01 Thread Aaron Sawdey
Builtin expansion of strncmp currently only happens when at least one of the string arguments is a constant string. I'd like to make it also attempt expansion of the cmpstrnsi pattern in the case where neither argument is a constant string, as is already done with cmpstrsi in expand_builtin_strcmp.

Re: RFA (tree-inline): PATCH for C++ inheriting constructors overhaul

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 05:33:17PM -0400, Jason Merrill wrote: > Like so? LGTM, thanks. > diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c > index de5e575..6899d2a 100644 > --- a/gcc/tree-inline.c > +++ b/gcc/tree-inline.c > @@ -1045,6 +1045,7 @@ copy_tree_body_r (tree *tp, int *walk_subtrees,

Re: libgo: Fix GOARCH_PHYSPAGESIZE for ia64

2016-11-01 Thread Ian Lance Taylor
On Mon, Oct 31, 2016 at 2:02 AM, Andreas Schwab wrote: > diff --git a/libgo/configure b/libgo/configure > index 3c866f7f21..7a9df58c21 100755 > --- a/libgo/configure > +++ b/libgo/configure > @@ -13677,7 +13677,7 @@ rm -f core conftest.err conftest.$ac_objext > conftest.$ac_ext > GOARCH=ia64

Re: [RFC][PATCH] Remove a bad use of SLOW_UNALIGNED_ACCESS

2016-11-01 Thread Wilco Dijkstra
Jeff Law wrote: > I think you'll need to look at bz61320 before this could go in. I had a look, but there is nothing there that is related - eventually a latent alignment bug was fixed in IVOpt. Note that the bswap phase currently inserts unaligned accesses irrespectively of STRICT_ALIGNMENT or

Re: RFA (tree-inline): PATCH for C++ inheriting constructors overhaul

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 4:20 PM, Jakub Jelinek wrote: > On Mon, Oct 31, 2016 at 11:45:08AM -0400, Jason Merrill wrote: >> Is the tree-inline.c patch OK for trunk? > >> --- a/gcc/tree-inline.c >> +++ b/gcc/tree-inline.c >> @@ -1241,6 +1241,28 @@ copy_tree_body_r (tree *tp, int *walk_subtrees, void

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 4:00 PM, Bernd Edlinger wrote: > On 11/01/16 20:48, Jason Merrill wrote: >>> else if ((DECL_EXTERN_C_P (newdecl) >>> && DECL_EXTERN_C_P (olddecl)) >>>|| compparms (TYPE_ARG_TYPES (TREE_TYPE (newdecl)), >>>

Re: [RFC][PATCH] Remove a bad use of SLOW_UNALIGNED_ACCESS

2016-11-01 Thread Jeff Law
On 11/01/2016 11:36 AM, Wilco Dijkstra wrote: Looking at PR77308, one of the issues is that the bswap optimization phase doesn't work on ARM. This is due to an odd check that uses SLOW_UNALIGNED_ACCESS (which is always true on ARM). Since the testcase in PR77308 generates much better code with

Re: [PATCH] DWARF5 .debug_rnglists support

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 09:44:27PM +0100, Rainer Orth wrote: > this patch broke Solaris bootstrap with /bin/as: > > /vol/gcc/src/hg/trunk/local/gcc/dwarf2out.c: In function 'void > output_rnglists()': > /vol/gcc/src/hg/trunk/local/gcc/dwarf2out.c:11055:8: error: unused variable > 'basebuf' [-Wer

Re: [PATCH] DWARF5 .debug_rnglists support

2016-11-01 Thread Rainer Orth
Hi Jakub, > 2016-11-01 Jakub Jelinek > > * tree.h (BLOCK_IN_COLD_SECTION_P): Define. > * final.c (final_scan_insn): Set BLOCK_IN_COLD_SECTION_P. > * dwarf2out.c (rnglist_idx): New variable. > (struct dw_ranges): Add label, idx and maybe_new_sec fields. > (DEBUG_RNG

Re: RFA (tree-inline): PATCH for C++ inheriting constructors overhaul

2016-11-01 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 11:45:08AM -0400, Jason Merrill wrote: > Is the tree-inline.c patch OK for trunk? > --- a/gcc/tree-inline.c > +++ b/gcc/tree-inline.c > @@ -1241,6 +1241,28 @@ copy_tree_body_r (tree *tp, int *walk_subtrees, void > *data) > *walk_subtrees = 0; > return NULL;

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
On 11/01/16 20:48, Jason Merrill wrote: >> else if ((DECL_EXTERN_C_P (newdecl) >> && DECL_EXTERN_C_P (olddecl)) >>|| compparms (TYPE_ARG_TYPES (TREE_TYPE (newdecl)), >> TYPE_ARG_TYPES (TREE_TYPE (oldd

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 2:15 PM, Bernd Edlinger wrote: > On 11/01/16 18:11, Jason Merrill wrote: >> On Tue, Nov 1, 2016 at 11:45 AM, Bernd Edlinger >> wrote: >>> On 11/01/16 16:20, Jason Merrill wrote: On 10/17/2016 03:18 PM, Bernd Edlinger wrote: I'm not even sure we need a new warning.

[PATCH] xtensa: don't xfail gcc.c-torture/compile/20001226-1.c

2016-11-01 Thread Max Filippov
With jump trampolines implemented in binutils since 2.25 and enabled by default this test no longer fails on xtensa. 2016-11-01 Max Filippov gcc/testsuite/ * gcc.c-torture/compile/20001226-1.c: Don't xfail on xtensa. --- gcc/testsuite/gcc.c-torture/compile/20001226-1.c | 1 - 1 file ch

Re: [PATCH, Fortran] New warning flag -Wargument-mismatch to control argument mismatch warnings

2016-11-01 Thread Fritz Reese
And changelog From: Fritz O. Reese Date: Tue, 1 Nov 2016 10:54:39 -0400 Subject: [PATCH] New warning -Wargument-mismatch for function argument mismatches. gcc/fortran/ * lang.opt, invoke.texi: New argument -Wargument-mismatch. * interface.c (compare_parameter, compar

Re: [PATCH, Fortran] New warning flag -Wargument-mismatch to control argument mismatch warnings

2016-11-01 Thread Fritz Reese
See attached... --- Fritz Reese On Tue, Nov 1, 2016 at 11:24 AM, Fritz Reese wrote: > All, > > Here I propose a new warning flag -Wargument-mismatch to control > warnings emitted when the type, rank, or some other property of actual > arguments does not match that of a function's formal par

Re: [PATCH] enhance buffer overflow warnings (and c/53562)

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 01:12:55PM -0600, Jeff Law wrote: > On 11/01/2016 08:10 AM, Jakub Jelinek wrote: > >On Mon, Oct 31, 2016 at 08:39:15PM -0600, Martin Sebor wrote: > >>Attached is an updated patch that works around the problem with > >>the definition of the NOTE_DATA macro discussed below. I

Re: [PATCH] enhance buffer overflow warnings (and c/53562)

2016-11-01 Thread Jeff Law
On 11/01/2016 08:10 AM, Jakub Jelinek wrote: On Mon, Oct 31, 2016 at 08:39:15PM -0600, Martin Sebor wrote: Attached is an updated patch that works around the problem with the definition of the NOTE_DATA macro discussed below. I've raised bug 78174 for it and temporarily worked around it in the

[PATCH] xtensa: fix ICE on pr59037.c test

2016-11-01 Thread Max Filippov
xtensa gcc gets ICE on pr59037.c test because its xtensa_output_literal function cannot handle integer literals of sizes other than 4 and 8, whereas the test uses 16-byte int vector. Split integer literal formatting into the recursive function xtensa_output_integer_literal_parts capable of handling

Re: [PATCH] Emit DWARF5 DW_AT_reference and DW_AT_rvalue_reference

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 2:04 PM, Jason Merrill wrote: > On Tue, Nov 1, 2016 at 9:56 AM, Jakub Jelinek wrote: >> On Mon, Oct 31, 2016 at 09:56:28AM -0400, Jason Merrill wrote: >>> >Or by changing get_qualified_die (in particular check_base_type) to use a >>> >langhook, we could at least for DW_AT_{

Re: [patch, fortran] Fix PR 69544

2016-11-01 Thread Dominique d'Humières
gfortran regtested without regression with the patch --- ../_clean/gcc/fortran/match.c 2016-11-01 17:24:32.0 +0100 +++ gcc/fortran/match.c 2016-11-01 16:21:31.0 +0100 @@ -6219,6 +6219,7 @@ match_simple_where (void) c->next = XCNEW (gfc_code); *c->next = new_st; + c->

[committed] hppa: Add new shift/add patterns

2016-11-01 Thread John David Anglin
The attached change fixes an obscure reload problem compiling hash.c in racket-6.7. This occurs when we to load the address of a DFmode MEM with a scaled-indexed address to integer registers. Although we prefer ASHIFT to MULT, MULT is still used in memory addresses and we need to handle this fo

Re: [PATCH][AArch64] Add function comments to some prologue/epilogue helpers

2016-11-01 Thread James Greenhalgh
On Tue, Nov 01, 2016 at 10:49:10AM +, Jiong Wang wrote: > >>>Is this ok for trunk? > >>> > >>>Thanks, > >>>Kyrill > >>> > >>>2016-10-12 Kyrylo Tkachov > >>> > >>>* config/aarch64/aarch64.c (aarch64_register_saved_on_entry): Add > >>>function comment. > >>>(aarch64_next_callee_sav

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
On 11/01/16 18:11, Jason Merrill wrote: > On Tue, Nov 1, 2016 at 11:45 AM, Bernd Edlinger > wrote: >> On 11/01/16 16:20, Jason Merrill wrote: >>> On 10/17/2016 03:18 PM, Bernd Edlinger wrote: >>> I'm not even sure we need a new warning. Can we combine this warning >>> with the block that currentl

Re: [PATCH][AArch64] Cleanup add expander

2016-11-01 Thread James Greenhalgh
On Mon, Oct 24, 2016 at 04:19:47PM +, Wilco Dijkstra wrote: > The add expander still contains some expansion code that was required for the > previous prolog/epilog code, but which is no longer needed. I also noticed > that > the current version splits off immediates from frame addressing ins

Re: [PATCH 5/5] [AARCH64] Add variant support to -m="native"and add thunderxt88p1.

2016-11-01 Thread Andrew Pinski
On Tue, Nov 17, 2015 at 2:10 PM, Andrew Pinski wrote: > Since ThunderX T88 pass 1 (variant 0) is a ARMv8 part while pass 2 (variant 1) > is an ARMv8.1 part, I needed to add detecting of the variant also for this > difference. Also I simplify a little bit and combined the single core and > arch det

Re: [PATCH, testsuite]: Cleanup lib/target-supports.exp, ...

2016-11-01 Thread Uros Bizjak
On Tue, Nov 1, 2016 at 5:05 PM, Jakub Jelinek wrote: > On Tue, Nov 01, 2016 at 10:05:22AM +0100, Uros Bizjak wrote: >> ... simplify some conditions and add i?86-*-* target where missing. >> >> 2016-11-01 Uros Bizjak >> >> * lib/target-supports.exp: Normalize order of i?86 and x86_64 targets

Re: [PATCH] Emit DWARF5 DW_AT_reference and DW_AT_rvalue_reference

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 9:56 AM, Jakub Jelinek wrote: > On Mon, Oct 31, 2016 at 09:56:28AM -0400, Jason Merrill wrote: >> >Or by changing get_qualified_die (in particular check_base_type) to use a >> >langhook, we could at least for DW_AT_{reference,rvalue_reference} just use >> >equate_type_number

[RFC][PATCH] Remove a bad use of SLOW_UNALIGNED_ACCESS

2016-11-01 Thread Wilco Dijkstra
Looking at PR77308, one of the issues is that the bswap optimization phase doesn't work on ARM. This is due to an odd check that uses SLOW_UNALIGNED_ACCESS (which is always true on ARM). Since the testcase in PR77308 generates much better code with this patch (~13% fewer instructions), it seems

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 12:10 PM, Jakub Jelinek wrote: > + && !get_AT (var_die, DW_AT_inline) > + && (origin_die == NULL || get_AT (origin_die, DW_AT_inline) == NULL) Can we drop this repetition (here and for DW_AT_const_expr)? get_AT should look through DW_AT_abstract_origin, and

Re: [PATCH] xtensa: Fix PR target/78118

2016-11-01 Thread Max Filippov
On Tue, Nov 1, 2016 at 9:28 AM, augustine.sterl...@gmail.com wrote: > On Mon, Oct 31, 2016 at 11:32 PM, Max Filippov wrote: >> 2016-10-26 Max Filippov >> gcc/ >> * config/xtensa/xtensa-protos.h >> (xtensa_use_return_instruction_p): New prototype. >> * config/xtensa/xten

Re: [patch, fortran] Fix PR 69544

2016-11-01 Thread Thomas Koenig
Hi Dominique, The patch fixes the ICE due to the missing gfc_current_locus in the last one, but the same should be applied to match_simple_where, otherwise one gets an ICE for statements such as if (n==10) where (txt(1:3) /= '' ) y(1:3,i,j) = txt(1:3) I can confirm that the bug exists. B

Re: [gcc] Enable DW_OP_VAL_EXPRESSION support in dwarf module

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 1:02 PM, Jiong Wang wrote: > Besides this issue, do you think the PARALLEL + UNSPEC based approach to > represent DWARF RAW expression is acceptable? Yes. Jason

[PATCH][ARM][2/2] Remove old rtx costs

2016-11-01 Thread Kyrill Tkachov
Hi all, This is the big removal patch that removes the old costs functions, the function pointer field in tune_params, and the transitional options -mold-rtx-costs and -mnew-generic-costs. The diff stats come in at: 3 files changed, 61 insertions(+), 1275 deletions(-) Bootstrapped and tested o

[PATCH][ARM][1/2] Use generic_extra_costs in all remaining tuning structs

2016-11-01 Thread Kyrill Tkachov
Hi all, This is the first of two patches to do away with the transitional -mold-rtx-costs option and finalise the transition to the table-based RTX costs approach. This first patch switches the remaining tuning structs to use generic_extra_costs so that the 2nd patch can remove the rtx_costs f

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 11:45 AM, Bernd Edlinger wrote: > On 11/01/16 16:20, Jason Merrill wrote: >> On 10/17/2016 03:18 PM, Bernd Edlinger wrote: >> I'm not even sure we need a new warning. Can we combine this warning >> with the block that currently follows? > > After 20 years of not having a wa

Re: [gcc] Enable DW_OP_VAL_EXPRESSION support in dwarf module

2016-11-01 Thread Jiong Wang
On 01/11/16 16:48, Jason Merrill wrote: On Tue, Nov 1, 2016 at 11:59 AM, Jiong Wang wrote: On 01/11/16 15:24, Jason Merrill wrote: On Tue, Nov 1, 2016 at 11:12 AM, Jiong Wang wrote: On 31/10/16 19:50, Jason Merrill wrote: On 10/21/2016 04:30 AM, Jiong Wang wrote: All DW_OP_* of the expre

[committed] Fix up libgomp/hashtab.h license

2016-11-01 Thread Jakub Jelinek
Hi! libgomp is GPLv3 + runtime exception licensed, hashtab.h has been copied and adjusted from include/ similarly how splay-tree.c has been changed, the latter got the GPLv3 + runtime exception boiler plate, but not hashtab.h. Fixed thusly, committed to trunk. Shall I backport to release branche

Re: [PATCH] DWARF5 .debug_rnglists support

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 12:14 PM, Jakub Jelinek wrote: > On Mon, Oct 31, 2016 at 05:03:12PM -0400, Jason Merrill wrote: >> > Ok. Another option would be to call value_format in size_of_die >> > in this case and put the comment into value_format. >> >> That works, too. > > Done. >> >> >> In general

Re: [gcc] Enable DW_OP_VAL_EXPRESSION support in dwarf module

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 11:59 AM, Jiong Wang wrote: > On 01/11/16 15:24, Jason Merrill wrote: >> On Tue, Nov 1, 2016 at 11:12 AM, Jiong Wang wrote: >>> On 31/10/16 19:50, Jason Merrill wrote: On 10/21/2016 04:30 AM, Jiong Wang wrote: > > All DW_OP_* of the expression are grouped toget

Re: [PATCH] xtensa: Fix PR target/78118

2016-11-01 Thread augustine.sterl...@gmail.com
On Mon, Oct 31, 2016 at 11:32 PM, Max Filippov wrote: > 2016-10-26 Max Filippov > gcc/ > * config/xtensa/xtensa-protos.h > (xtensa_use_return_instruction_p): New prototype. > * config/xtensa/xtensa.c (xtensa_current_frame_size, > xtensa_callee_save_size): Remove.

[PATCH v2] bb-reorder: Improve compgotos pass (PR71785)

2016-11-01 Thread Segher Boessenkool
For code like the testcase in PR71785 GCC factors all the indirect branches to a single dispatcher that then everything jumps to. This is because having many indirect branches with each many jump targets does not scale in large parts of the compiler. Very late in the pass pipeline (right before p

Re: [PATCH] DWARF5 .debug_rnglists support

2016-11-01 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 05:03:12PM -0400, Jason Merrill wrote: > > Ok. Another option would be to call value_format in size_of_die > > in this case and put the comment into value_format. > > That works, too. Done. > > >> In general there's a lot of code duplication between the existing ranges >

[PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 10:38:40AM -0400, Jason Merrill wrote: > > The current DWARF 5 wording is: > > "If the variable entry represents the defining declaration for a C++ static > > data > > member of a structure, class or union, the entry has a DW_AT_specification > > attribute, whose value is a

Re: [PATCH, testsuite]: Cleanup lib/target-supports.exp, ...

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 10:05:22AM +0100, Uros Bizjak wrote: > ... simplify some conditions and add i?86-*-* target where missing. > > 2016-11-01 Uros Bizjak > > * lib/target-supports.exp: Normalize order of i?86 and x86_64 targets. > Whitespace fixes. ... > (check_effective_target

Re: [gcc] Enable DW_OP_VAL_EXPRESSION support in dwarf module

2016-11-01 Thread Jiong Wang
On 01/11/16 15:24, Jason Merrill wrote: On Tue, Nov 1, 2016 at 11:12 AM, Jiong Wang wrote: On 31/10/16 19:50, Jason Merrill wrote: On 10/21/2016 04:30 AM, Jiong Wang wrote: All DW_OP_* of the expression are grouped together inside the PARALLEL, and those operations which don't have RTL mappin

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
On 11/01/16 16:20, Jason Merrill wrote: > On 10/17/2016 03:18 PM, Bernd Edlinger wrote: >> +@item -Wbuiltin-function-redefined @r{(C++ and Objective-C++ only)} >> +@opindex Wbuiltin-function-redefined >> +@opindex Wno-builtin-function-redefined >> +Do warn if built-in functions are redefined. This

[PATCH] AIX visibility

2016-11-01 Thread David Edelsohn
This patch enables visibility support for AIX. AIX of course chose different syntax, so the default machinery isn't usable. AIX appends the visibility to the .globl and .comm pseudo-ops. Within the rs6000 port, this patch only affects AIX / XCOFF. Also, because visibility support implicitly ena

[PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

2016-11-01 Thread Tamar Christina
Hi all, A glibc update recently broke this test by adding a CPP macro that uses the ## string function which traditional-cpp does not support. The change in glibc that made the test fail is from 6962682ffe5e5f0373047a0b894fee7a774be254. This fixes (PR78136) by changing the test to use a local in

Re: [PATCH VECT]Swap operands for cond_reduction when necessary

2016-11-01 Thread Bin.Cheng
On Fri, Oct 28, 2016 at 1:38 PM, Richard Biener wrote: > On Wed, Oct 26, 2016 at 6:42 PM, Bin Cheng wrote: >> Hi, >> For stmt defining reduction, GCC vectorizer assumes that the reduction >> variable is always the last (second) operand. Another fact is that >> vectorizer doesn't swap operands

Re: [PR56974] output DWARF-5 markers for ref_qualifiers

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 11:34:47AM -0400, Jason Merrill wrote: > On Wed, Oct 19, 2016 at 6:15 AM, Alexandre Oliva wrote: > > When a method or a method or function type has a ref-qualifier, output > > DW_AT_reference or DW_AT_rvalue_reference in the subprogram or > > subroutine_type tag, as specifi

Re: [PR56974] output DWARF-5 markers for ref_qualifiers

2016-11-01 Thread Jason Merrill
On Wed, Oct 19, 2016 at 6:15 AM, Alexandre Oliva wrote: > When a method or a method or function type has a ref-qualifier, output > DW_AT_reference or DW_AT_rvalue_reference in the subprogram or > subroutine_type tag, as specified in DWARF version 5 drafts, see >

[PATCH] [ARC] Various small miscellaneous fixes.

2016-11-01 Thread Claudiu Zissulescu
This is an updated version of the patch that can be applied as is. Ok to apply? Claudiu gcc/ 2016-05-09 Claudiu Zissulescu * config/arc/arc.c (arc_process_double_reg_moves): Change. * config/arc/arc.md (movsi_insn): Disable unsupported move instructions for ARCv2 cores

Re: [gcc] Enable DW_OP_VAL_EXPRESSION support in dwarf module

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 11:12 AM, Jiong Wang wrote: > On 31/10/16 19:50, Jason Merrill wrote: >> >> On 10/21/2016 04:30 AM, Jiong Wang wrote: >>> >>> All DW_OP_* of the expression are grouped together inside the PARALLEL, >>> and those operations which don't have RTL mapping are wrapped by >>> UNSP

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
On 11/01/16 16:02, Jason Merrill wrote: > On 10/17/2016 03:18 PM, Bernd Edlinger wrote: >> Regarding this hunk: >> >> /* Whether or not the builtin can throw exceptions has no >> bearing on this declarator. */ >> - TREE_NOTHROW (olddecl) = 0; >> + TREE_NOTHROW (olddecl)

[PATCH, Fortran] New warning flag -Wargument-mismatch to control argument mismatch warnings

2016-11-01 Thread Fritz Reese
All, Here I propose a new warning flag -Wargument-mismatch to control warnings emitted when the type, rank, or some other property of actual arguments does not match that of a function's formal parameters according to its declaration or interface specification. The warnings are of course enabled b

Re: [PATCH testsuite]Require vect_cond_mixed for test case gcc.dg/vect/pr56541.c

2016-11-01 Thread Bin.Cheng
On Thu, Aug 11, 2016 at 11:38 AM, Richard Biener wrote: > On Thu, Aug 11, 2016 at 11:56 AM, Bin.Cheng wrote: >> On Thu, Aug 11, 2016 at 10:50 AM, Richard Biener >> wrote: >>> On Wed, Aug 10, 2016 at 5:58 PM, Bin Cheng wrote: Hi, Due to some reasons, tree-if-conv.c now factors floating

Re: [PATCH][AArch64] Expand DImode constant stores to two SImode stores when profitable

2016-11-01 Thread Kyrill Tkachov
And here is the patch itself. On 01/11/16 15:21, Kyrill Tkachov wrote: On 31/10/16 11:54, Kyrill Tkachov wrote: On 24/10/16 17:15, Andrew Pinski wrote: On Mon, Oct 24, 2016 at 7:27 AM, Kyrill Tkachov wrote: Hi all, When storing a 64-bit immediate that has equal bottom and top halves we c

Re: [PATCH][AArch64] Expand DImode constant stores to two SImode stores when profitable

2016-11-01 Thread Kyrill Tkachov
On 31/10/16 11:54, Kyrill Tkachov wrote: On 24/10/16 17:15, Andrew Pinski wrote: On Mon, Oct 24, 2016 at 7:27 AM, Kyrill Tkachov wrote: Hi all, When storing a 64-bit immediate that has equal bottom and top halves we currently synthesize the repeating 32-bit pattern twice and perform a singl

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Jason Merrill
On 10/17/2016 03:18 PM, Bernd Edlinger wrote: +@item -Wbuiltin-function-redefined @r{(C++ and Objective-C++ only)} +@opindex Wbuiltin-function-redefined +@opindex Wno-builtin-function-redefined +Do warn if built-in functions are redefined. This option is only +supported for C++ and Objective-C++

Re: [gcc] Enable DW_OP_VAL_EXPRESSION support in dwarf module

2016-11-01 Thread Jiong Wang
On 31/10/16 19:50, Jason Merrill wrote: On 10/21/2016 04:30 AM, Jiong Wang wrote: All DW_OP_* of the expression are grouped together inside the PARALLEL, and those operations which don't have RTL mapping are wrapped by UNSPEC. The parsing algorithm is simply something like: foreach elem insi

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope (v2)

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 03:53:46PM +0100, Martin Liška wrote: > @@ -1504,7 +1505,7 @@ non_rewritable_lvalue_p (tree lhs) > > static void > maybe_optimize_var (tree var, bitmap addresses_taken, bitmap not_reg_needs, > - bitmap suitable_for_renaming) > + bitmap sui

[PATCH, Fortran] Allow warnings given through gfc_error to associate with warning flags

2016-11-01 Thread Fritz Reese
All, Currently warnings given by the GNU Fortran front-end typically indicate which flag controls the warning, if any, as given by the first argument to gfc_warning. However, there is no support for controlling warnings which are emitted by gfc_error when warnings_not_errors is set. Herein I propo

Re: [PATCH] Fix PR77407

2016-11-01 Thread Marc Glisse
On Mon, 31 Oct 2016, Richard Biener wrote: On Fri, 28 Oct 2016, Marc Glisse wrote: On Wed, 28 Sep 2016, Richard Biener wrote: The following patch implements patterns to catch x / abs (x) and x / -x, taking advantage of undefinedness at x == 0 as opposed to the PR having testcases with explic

Re: [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Jason Merrill
On 10/17/2016 03:18 PM, Bernd Edlinger wrote: Regarding this hunk: /* Whether or not the builtin can throw exceptions has no bearing on this declarator. */ - TREE_NOTHROW (olddecl) = 0; + TREE_NOTHROW (olddecl) = TREE_NOTHROW (newdecl); You may ask, why the old code

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope (v2)

2016-11-01 Thread Martin Liška
On 11/01/2016 03:53 PM, Jakub Jelinek wrote: > On Tue, Nov 01, 2016 at 03:47:54PM +0100, Martin Liška wrote: >> On 10/27/2016 07:23 PM, Jakub Jelinek wrote: >>> Ok for trunk with that change. >>> >>> Jakub >> >> Hello. >> >> I'll commit the patch as soon as following patch would be accepted. Th

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope (v2)

2016-11-01 Thread Martin Liška
On 10/27/2016 07:23 PM, Jakub Jelinek wrote: > On Thu, Oct 27, 2016 at 04:40:30PM +0200, Martin Liška wrote: >> On 10/21/2016 04:26 PM, Jakub Jelinek wrote: >>> On Wed, Oct 12, 2016 at 04:07:53PM +0200, Martin Liška wrote: > Ok, first let me list some needed follow-ups that don't need to be han

[PING**2] [PATCH, C++] Warn on redefinition of builtin functions (PR c++/71973)

2016-11-01 Thread Bernd Edlinger
Ping... On 10/24/16 15:36, Bernd Edlinger wrote: > Hi! > > I'd like to ping for my patch here: > https://gcc.gnu.org/ml/gcc-patches/2016-10/msg01348.html > > > Thanks > Bernd. > > On 10/17/16 21:18, Bernd Edlinger wrote: >> On 10/17/16 20:05, Joseph Myers wrote: >>> On Sun, 16 Oct 2016, Bernd Edli

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope (v2)

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 03:47:54PM +0100, Martin Liška wrote: > On 10/27/2016 07:23 PM, Jakub Jelinek wrote: > > Ok for trunk with that change. > > > > Jakub > > Hello. > > I'll commit the patch as soon as following patch would be accepted. The patch > fixes false positives when running asan

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope (v2)

2016-11-01 Thread Martin Liška
On 10/27/2016 07:23 PM, Jakub Jelinek wrote: > Ok for trunk with that change. > > Jakub Hello. I'll commit the patch as soon as following patch would be accepted. The patch fixes false positives when running asan-bootstrap. Patch can bootstrap on ppc64le-redhat-linux and survives regressi

Re: [patch, fortran] Fix PR 69544

2016-11-01 Thread Dominique d'Humières
Hi Thomas, > the attached, rather simple, patch, fixes a regression where > the locus was not set, leading to an ICE on a warning. Looking for the occurrences of gfc_clear_new_st in fortran/match.c, I have found it in the following procs: gfc_match_if match_simple_forall gfc_match_forall match_s

Re: [PATCH] enhance buffer overflow warnings (and c/53562)

2016-11-01 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 08:39:15PM -0600, Martin Sebor wrote: > Attached is an updated patch that works around the problem with > the definition of the NOTE_DATA macro discussed below. I've > raised bug 78174 for it and temporarily worked around it in > the patch. I'll see if I can come up with a

libgo patch committed: Add functions used by cgo

2016-11-01 Thread Ian Lance Taylor
When using the cgo tool with the -gccgo option, calls to C.GoString, C.GoStringN, and C.GoBytes will be translated into calls to __go_byte_array_to_string and __go_string_to_byte_array. Those functions were removed when the string code was copied from Go 1.7, but we still need them for cgo. While

Re: [patch, fortran] Fix PR 69544

2016-11-01 Thread Steve Kargl
On Tue, Nov 01, 2016 at 11:58:10AM +0100, Thomas Koenig wrote: > > the attached, rather simple, patch, fixes a regression where > the locus was not set, leading to an ICE on a warning. > > Regression-tested on trunk. OK on all affected and open branches > (7/6/5)? > Yes. -- Steve

[Patch AArch64] aarch64-c.o should depend on TARGET_H

2016-11-01 Thread James Greenhalgh
Hi, I've noticed that aarch64-c.o doesn't get rebuilt after a change to the target hooks. That leaves it out of sync with the rest of the compiler in incremental builds, which in turn causes this code to write to the wrong memory location: void aarch64_register_pragmas (void) { /* Upda

Re: [PATCH] Emit DWARF5 DW_AT_reference and DW_AT_rvalue_reference

2016-11-01 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 09:56:28AM -0400, Jason Merrill wrote: > >Or by changing get_qualified_die (in particular check_base_type) to use a > >langhook, we could at least for DW_AT_{reference,rvalue_reference} just use > >equate_type_number_to_die/lookup_type_die reliably (DW_AT_endianity issue > >

libgo patch committed: Only rebuild package if dependent .gox changed

2016-11-01 Thread Ian Lance Taylor
This patch to libgo tweaks the libgo Makefile so that we only rebuild a package if the .gox file of some imported package changes. We now use mvifdiff and stamp files to track whether a .gox file has changed. When package A depends on package B, and we rebuild package B, we only rebuild package A

Re: Implement -Wduplicated-branches (PR c/64279) (v3)

2016-11-01 Thread Jakub Jelinek
On Tue, Nov 01, 2016 at 09:41:20AM -0400, Jason Merrill wrote: > On Tue, Oct 25, 2016 at 9:59 AM, Marek Polacek wrote: > > On Mon, Oct 24, 2016 at 04:10:21PM +0200, Marek Polacek wrote: > >> On Thu, Oct 20, 2016 at 12:28:36PM +0200, Marek Polacek wrote: > >> > I found a problem with this patch--we

Go patch committed: Don't put print/println constants into temporaries

2016-11-01 Thread Ian Lance Taylor
This patch to the Go frontend stops putting constants passed to the predeclared print/println functions in temporaries. This was an accidental recent change when the printlock function was introduced. The print/println functions are unusual in that integer constants are treated as int64 or uint64

libgo patch committed: Minor Makefile improvements

2016-11-01 Thread Ian Lance Taylor
This patch to libgo implements some minor Makefile improvements suggested by Ralph Corderoy. These reduce the number of processes used to generate some files. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: Implement -Wduplicated-branches (PR c/64279) (v3)

2016-11-01 Thread Jason Merrill
On Tue, Oct 25, 2016 at 9:59 AM, Marek Polacek wrote: > On Mon, Oct 24, 2016 at 04:10:21PM +0200, Marek Polacek wrote: >> On Thu, Oct 20, 2016 at 12:28:36PM +0200, Marek Polacek wrote: >> > I found a problem with this patch--we can't call >> > do_warn_duplicated_branches in >> > build_conditional

[PATCH, vec-tails] Support loop epilogue vectorization

2016-11-01 Thread Yuri Rumyantsev
Hi All, I re-send all patches sent by Ilya earlier for review which support vectorization of loop epilogues and loops with low trip count. We assume that the only patch - vec-tails-07-combine-tail.patch - was not approved by Jeff. I did re-base of all patches and performed bootstrapping and regre

Re: [PATCH v2][AArch32][NEON] Implementing vmaxnmQ_ST and vminnmQ_ST intrinsincs.

2016-11-01 Thread Kyrill Tkachov
Hi Tamar, On 26/10/16 16:01, Tamar Christina wrote: Hi Christophe, Here's the updated patch. Cheers, Tamar From: Christophe Lyon Sent: Wednesday, October 19, 2016 11:23:56 AM To: Tamar Christina Cc: GCC Patches; Kyrylo Tkachov; nd Subject: Re: [PATCH v

[PATCH] PR tree-optimization/78162: Reject negative offsets in store merging early

2016-11-01 Thread Kyrill Tkachov
Hi all, Store merging ICEs on this invalid testcase because it trips up on the negative bitposition to store to. It doesn't really expect to handle negative offsets and I believe they won't occur very often in valid code anyway. Filling out structs/bitfields/class members involves positive offs

[PATCH] PR tree-optimization/78170: Truncate sign-extended padding when encoding bitfields

2016-11-01 Thread Kyrill Tkachov
Hi all, In this PR the code writes a -1 to a bitfield of size 17 bits and ends up overwriting another bitfields. The problem is that the intermediate buffer in encode_tree_to_bitpos holding the value to merge holds a 24-bit temporary with -1 written to it i.e. sign-extended to all ones. That i

[patch, fortran] Fix PR 69544

2016-11-01 Thread Thomas Koenig
Hello world, the attached, rather simple, patch, fixes a regression where the locus was not set, leading to an ICE on a warning. Regression-tested on trunk. OK on all affected and open branches (7/6/5)? Regards Thomas 2016-11-01 Thomas Koenig PR fortran/69544 * mat

  1   2   >