Re: [PATCH] PR78879

2016-12-22 Thread Yuan, Pengfei
> How specifically does this fix the problem. I suspect you're just > papering over the bug by changing the order of thread processing. > > You'll note that when a thread is canceled we call the > paths.unordered_remove without incrementing i. AFAICT you're just > changing order in which

Re: [Patch ,gcc/MIPS] add an build-time/runtime option to disable madd.fmt

2016-12-22 Thread Yunqiang Su
> 在 2016年12月23日,10:47,Paul Hua 写道: > > On aarch64 target the result are 1.332268e-17. > On x86 with fma target the result are also 1.332268e-17. > > so, I don't think the Loongson's madd.fmt/msub.fmt is incorrect. OMG. Will this behavior make some app wrong working

Re: [Patch ,gcc/MIPS] add an build-time/runtime option to disable madd.fmt

2016-12-22 Thread Paul Hua
On aarch64 target the result are 1.332268e-17. On x86 with fma target the result are also 1.332268e-17. so, I don't think the Loongson's madd.fmt/msub.fmt is incorrect. We should do something for usage of fused madd, the all things has been tested an fedora21 remix for loongson(1). 1, gcc:add

New Spanish PO file for 'gcc' (version 6.2.0)

2016-12-22 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/gcc/es.po (This file, 'gcc-6.2.0.es.po', has

RE: [PATCH, testsuite] MIPS: Cleanup the forcing of assembly output in error tests.

2016-12-22 Thread Moore, Catherine
> -Original Message- > From: Toma Tabacu [mailto:toma.tab...@imgtec.com] > Sent: Wednesday, December 14, 2016 9:56 AM > To: gcc-patches@gcc.gnu.org > Cc: Matthew Fortune ; Moore, > Catherine > Subject: [PATCH, testsuite] MIPS:

Go patch committed: Fix spurious redefinition error

2016-12-22 Thread Ian Lance Taylor
This patch to the Go frontend by Than McIntosh changes Struct_type::do_mangled_name to incorporate the field names even for hidden symbols. This is needed in cases where a package imports a type "S" that has an anonymous struct, e.g. // imported from some other package type S struct { X

Re: [PATCH, Fortran, alloc_poly, v2] Fix allocation of memory for polymorphic assignment

2016-12-22 Thread Janus Weil
2016-12-20 17:07 GMT+01:00 Andre Vehreschild : > Hi Janus, > >> 1) After adding that code block in gfc_trans_assignment_1, it seems >> like the comment above is outdated, right? > > Thanks for noting. > >> 2) Wouldn't it be better to move this block, which does the correct >>

[PATCH 3/3] [i386] Use re-aligned stack pointer for aligned SSE movs

2016-12-22 Thread Daniel Santos
This adds an optional `align' parameter to choose_baseaddr allowing the caller to request an address that is aligned to some boundary. Then ix86_emit_save_regs_using_mov and ix86_emit_restore_regs_using_mov are modified so that optimally aligned memory is used when such a base register is

[PATCH 1/3] [i386] Move stack frame re-alignment to before SSE saves.

2016-12-22 Thread Daniel Santos
This step adds new fields to struct ix86_frame to track where we started the stack re-alignment and what we need to allocate prior to re-alignment. In ix86_compute_frame_layout, we do the stack frame re-alignment computation prior to computing the SSE save area so that it we have an aligned SSE

[PATCH 2/3] [i386] Keep stack pointer valid after after re-alignment.

2016-12-22 Thread Daniel Santos
This stage adds the fields sp_realigned and sp_realigned_offset to struct machine_frame_state and adds the concept of the stack pointer being re-aligned rather than invalid. The inline functions sp_valid_at and fp_valid_at are added to test if a given location relative to the CFA can be accessed

Re: C++ PATCH for c++/42329, P0522 and other template template parm issues

2016-12-22 Thread Jason Merrill
On Wed, Dec 21, 2016 at 4:06 PM, Jason Merrill wrote: > The last patch implements paper P0522, which resolves DR150 to clarify > that default arguments do make a template suitable as an argument to a > template template-parameter based on a new rule that the > template-parameter

C++ PATCH for c++/78906 (ICE with member template variable)

2016-12-22 Thread Jason Merrill
If we're adding the enclosing template args, we also need to switch to looking at the most general template. Tested x86_64-pc-linux-gnu, applying to trunk. commit 35fe583ade362f018f095435980424f1244ab92f Author: Jason Merrill Date: Thu Dec 22 13:27:26 2016 -0500

Use aligned SSE movs for re-aligned MS ABI pro/epilogues

2016-12-22 Thread Daniel Santos
According to the Microsoft 64-bit ABI specification, registers RDI, RSI and XMM6-15 are non-volatile and the stack alignment is 16 bytes. In practice, the Windows implementation appears to not be so picky about the 16-byte alignment requirement, probably because it never to save SSE registers

Re: [PATCH v2,rs6000] PR78056: Finish fixing build failure on Power7

2016-12-22 Thread Segher Boessenkool
Hi Kelvin, On Fri, Dec 16, 2016 at 04:57:12PM -0700, Kelvin Nilsen wrote: > 2016-12-16 Kelvin Nilsen > > PR target/78056 > * gcc.target/powerpc/pr78056-1.c: New test. > * gcc.target/powerpc/pr78056-2.c: New test. > * gcc.target/powerpc/pr78056-3.c:

Re: [testsuite,committed] Fix prototype of memset in a test case.

2016-12-22 Thread Richard Sandiford
Georg-Johann Lay writes: > One test case used unsigned long for the 3rd parameter of memset, which > should be size_t. This made the test crash for targets where correct > parameter passing depends on correct prototypes. > > Fixed and committed as obvious. Catching up on

Re: [PATCH v2] combine: Improve change_zero_ext, call simplify_set afterwards.

2016-12-22 Thread Segher Boessenkool
On Thu, Dec 22, 2016 at 04:18:34PM +0100, Georg-Johann Lay wrote: > >>>If you don't have instruction scheduling subregs of mem are allowed (and > >>>are counted as registers). Combine asks recog, and it think this is > >>>fine. > >>> > >>>Why does reload use r31 here? Why does it think that is

Re: [PATCH] Speed-up use-after-scope (re-writing to SSA) (version 2)

2016-12-22 Thread Jakub Jelinek
On Thu, Dec 22, 2016 at 06:03:50PM +0100, Martin Liška wrote: > Done by hash_map. Ok. > > 3) I think you just want to do copy_node, plus roughly what > >copy_decl_for_dup_finish does (and set DECL_ARTIFICIAL and > >DECL_IGNORED_P) - except that you don't have copy_body_data > >so you

Re: [v3 PATCH] Implement 2801, Default-constructibility of unique_ptr.

2016-12-22 Thread Jonathan Wakely
On 20/12/16 22:52 +0200, Ville Voutilainen wrote: diff --git a/libstdc++-v3/include/bits/unique_ptr.h b/libstdc++-v3/include/bits/unique_ptr.h index 56e6ec0..63dff37 100644 --- a/libstdc++-v3/include/bits/unique_ptr.h +++ b/libstdc++-v3/include/bits/unique_ptr.h @@ -175,10 +175,14 @@

Re: [PATCH] Speed-up use-after-scope (re-writing to SSA) (version 2)

2016-12-22 Thread Martin Liška
On 12/21/2016 09:52 AM, Jakub Jelinek wrote: > On Tue, Dec 20, 2016 at 12:26:41PM +0100, Martin Liška wrote: >> Ok, llvm folks are unwilling to accept the new API function, thus I've >> decided to come up >> with approach suggested by Jakub. Briefly, when expanding ASAN_POISON >> internal

Re: [v3 PATCH] Implement LWG 2842, in_place_t check for optional::optional(U&&) should decay U.

2016-12-22 Thread Jonathan Wakely
On 19/12/16 16:07 +0200, Ville Voutilainen wrote: Tested on Linux-x64. The perfect forwarder needs to sfinae out of the way of the in_place_t signature, and the in_place_t signature needs to check is_constructible. I also did some housekeeping to get rid of the int-pack constraints, because in

Re: [PATCH] PR78879

2016-12-22 Thread Jeff Law
On 12/21/2016 11:08 PM, Yuan, Pengfei wrote: Hi, The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78879 There are some other invocations of unordered_remove in tree-ssa-threadupdate.c, which may also need to be replaced with ordered_remove. Regards, Yuan, Pengfei

Re: [Patch ,gcc/MIPS] add an build-time/runtime option to disable madd.fmt

2016-12-22 Thread Yunqiang Su
> 在 2016年12月23日,00:18,Richard Sandiford 写道: > > Yunqiang Su writes: >>> 在 2016年12月22日,23:48,Yunqiang Su 写道: >>> 在 2016年12月22日,23:31,Richard Sandiford 写道:

[PATCH][x86_64] Enable AVX512 VPOPCNTD/VPOPCNTQ instructions

2016-12-22 Thread Andrew Senkevich
Hi, this patch enables AVX512 VPOPCNTD/VPOPCNTQ instructions recently added in Instruction Set Extensions (https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf). gcc/ * common/config/i386/i386-common.c

Re: [Patch ,gcc/MIPS] add an build-time/runtime option to disable madd.fmt

2016-12-22 Thread Richard Sandiford
Yunqiang Su writes: >> 在 2016年12月22日,23:48,Yunqiang Su 写道: >> >>> >>> 在 2016年12月22日,23:31,Richard Sandiford >>> 写道: >>> >>> Matthew Fortune writes: Sandra Loosemore

Re: Reorganise machmode.h headers

2016-12-22 Thread Richard Sandiford
Jeff Law writes: > On 11/16/2016 09:32 AM, Richard Sandiford wrote: >> Later patches will make machmode.h rely on wide-int.h and the >> new poly-int.h, so it needs to appear later in the coretypes.h >> include list. >> >> Previously machmode.h included insn-modes.h, which as well

Re: [PATCH,rs6000] Fix PR11488 for rs6000 target

2016-12-22 Thread Richard Sandiford
Pat Haugen writes: > This patch attempts to fix problems with the first scheduling pass > creating too much register pressure. It does this by enabling the target > hook to compute the pressure classes for rs6000 target since the first > thing I observed while

Re: [Patch ,gcc/MIPS] add an build-time/runtime option to disable madd.fmt

2016-12-22 Thread Yunqiang Su
> 在 2016年12月22日,23:48,Yunqiang Su 写道: > >> >> 在 2016年12月22日,23:31,Richard Sandiford 写道: >> >> Matthew Fortune writes: >>> Sandra Loosemore writes: On 12/21/2016 11:54 AM, Yunqiang

Re: [Patch ,gcc/MIPS] add an build-time/runtime option to disable madd.fmt

2016-12-22 Thread Yunqiang Su
> 在 2016年12月22日,23:31,Richard Sandiford 写道: > > Matthew Fortune writes: >> Sandra Loosemore writes: >>> On 12/21/2016 11:54 AM, Yunqiang Su wrote: By this patch, I add a build-time option `

Re: [Patch ,gcc/MIPS] add an build-time/runtime option to disable madd.fmt

2016-12-22 Thread Richard Sandiford
Matthew Fortune writes: > Sandra Loosemore writes: >> On 12/21/2016 11:54 AM, Yunqiang Su wrote: >> > By this patch, I add a build-time option ` --with-unfused-madd4=yes/no', >> > and runtime option -m(no-)unfused-madd4, >> > to disable

Re: C++ PATCH for c++/42329, P0522 and other template template parm issues

2016-12-22 Thread Jason Merrill
On Wed, Dec 21, 2016 at 4:06 PM, Jason Merrill wrote: > The fourth patch fixes 42329, where we were failing to bind a template > template-parameter to a base class of the argument type. We need to make sure that the argument is a class before we try this. Tested

Re: [PATCH v2] combine: Improve change_zero_ext, call simplify_set afterwards.

2016-12-22 Thread Georg-Johann Lay
On 22.12.2016 15:27, Dominik Vogt wrote: On Thu, Dec 22, 2016 at 12:00:37PM +0100, Georg-Johann Lay wrote: On 21.12.2016 18:46, Segher Boessenkool wrote: On Wed, Dec 21, 2016 at 01:58:18PM +0100, Georg-Johann Lay wrote: $ avr-gcc

Re: [PATCH v4] Run tests only if the machine supports the instruction set.

2016-12-22 Thread Andreas Krebbel
> gcc/ChangeLog-archlevel > > * config/s390/s390-c.c (s390_cpu_cpp_builtins_internal): Define > __S390_ARCH_LEVEL__. > gcc/testsuite/ChangeLog-setmem > > * gcc.target/s390/md/setmem_long-1.c: Use "s390_useable_hw". > * gcc.target/s390/md/rXsbg_mode_sXl.c: Likewise. >

Re: [PATCH v2] combine: Improve change_zero_ext, call simplify_set afterwards.

2016-12-22 Thread Dominik Vogt
On Thu, Dec 22, 2016 at 12:00:37PM +0100, Georg-Johann Lay wrote: > On 21.12.2016 18:46, Segher Boessenkool wrote: > >On Wed, Dec 21, 2016 at 01:58:18PM +0100, Georg-Johann Lay wrote: > >>$ avr-gcc > >>/gnu/gcc.gnu.org/trunk/gcc/testsuite/gcc.c-torture/compile/pr26833.c -S > >>-O1 -mmcu=avr4 -S -v

[PATCH] Implement no_sanitize function attribute

2016-12-22 Thread Martin Liška
Hello. As I previously agreed with Jakub, I prepared patch which adds no_sanitize function attribute (same what clang support). That encompasses following changes: 1) all no_sanitize_* function attributes are parsed and stored to no_sanitize_flags in DECL_ATTRIBUTES 2) instead of flag_sanitize

Re: [PATCH, gcc/MIPS] Add options to disable/enable madd.fmt/msub.fmt instructions

2016-12-22 Thread Yunqiang Su
> 在 2016年12月22日,13:11,Paul Hua 写道: > > Hi, > >> +On MIPS targets, set the @option{-mno-unfused-madd4} option by default. >> +On some platform, like Loongson 3A/3B 1000/2000/3000, madd.fmt/msub.fmt is >> +broken, which may which may generate wrong calculator result. > >

Re: [gimplefe] change dump format of realpart_expr and imagpart_expr with TDF_GIMPLE

2016-12-22 Thread Richard Biener
On December 22, 2016 12:27:38 PM GMT+01:00, Prathamesh Kulkarni wrote: >Hi, >For TDF_GIMPLE, the attached patch changes dump >format of realpart_expr from REALPART_EXPR to __real var >since the latter form is accepted by gimplefe. Similarly for >imagpart_expr. >Is

Re: [PATCH] Fix tree-optimization/78886.

2016-12-22 Thread Jakub Jelinek
On Thu, Dec 22, 2016 at 02:08:35PM +0100, Martin Liška wrote: > Patch is pre-approved by Jakub. I guess the same patch can be install to both > release branches after it finishes regression tests, right? Yes, thanks. > >From b0efc394e047ebc25386f8cb99f595b8d4c7f83a Mon Sep 17 00:00:00 2001 >

[PATCH] Fix tree-optimization/78886.

2016-12-22 Thread Martin Liška
Patch is pre-approved by Jakub. I guess the same patch can be install to both release branches after it finishes regression tests, right? Thanks, Martin >From b0efc394e047ebc25386f8cb99f595b8d4c7f83a Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 21 Dec 2016 16:21:45 +0100

Re: [PATCH] varasm: Propagate litpool decl alignment to generated RTX.

2016-12-22 Thread Andreas Krebbel
On 12/20/2016 11:38 AM, Richard Biener wrote: > On Fri, Dec 16, 2016 at 9:29 PM, Andreas Krebbel > wrote: >> When pushing a value into the literal pool the resulting decl might >> get a higher alignment than the original expression depending on how a >> target defines

[testsuite,patch,committed] ad PR52641: More case for int32plus, size32plus, etc.

2016-12-22 Thread Georg-Johann Lay
http://gcc.gnu.org/r243885 Committed this addition of restrictions, mostly for 16-bit int or 16-bit size targtes. Johann gcc/testsuite/ PR testsuite/52641 * gcc.dg/pr35258.c (main) : Use an integer value that has at least a size of 4. * gcc.dg/Walloca-1.c

[committed] Add two new -Wnonnull tests

2016-12-22 Thread Jakub Jelinek
Hi! I've committed following patch as obvious to add two tests that were discussed in the recent thread. 2016-12-22 Jakub Jelinek PR middle-end/78858 * c-c++-common/ubsan/pr78858.c: New test. * gcc.dg/nonnull-5.c: New test. ---

[gimplefe] change dump format of realpart_expr and imagpart_expr with TDF_GIMPLE

2016-12-22 Thread Prathamesh Kulkarni
Hi, For TDF_GIMPLE, the attached patch changes dump format of realpart_expr from REALPART_EXPR to __real var since the latter form is accepted by gimplefe. Similarly for imagpart_expr. Is this OK after bootstrap+test ? Thanks, Prathamesh diff --git a/gcc/testsuite/gcc.dg/gimplefe-20.c

Re: [PATCH v2] combine: Improve change_zero_ext, call simplify_set afterwards.

2016-12-22 Thread Georg-Johann Lay
On 21.12.2016 18:46, Segher Boessenkool wrote: On Wed, Dec 21, 2016 at 01:58:18PM +0100, Georg-Johann Lay wrote: $ avr-gcc /gnu/gcc.gnu.org/trunk/gcc/testsuite/gcc.c-torture/compile/pr26833.c -S -O1 -mmcu=avr4 -S -v /gnu/gcc.gnu.org/trunk/gcc/testsuite/gcc.c-torture/compile/pr26833.c: In