Re: [PATCH] Fix parloops ICE (PR tree-optimization/81578)

2017-07-27 Thread Richard Biener
On July 27, 2017 9:10:48 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >Not all vectorizable reductions are valid OpenMP standard reductions >(we could create user defined reductions from that, but that would be >quite a lot of work). > >This patch bails out for unsupported reductions. > >Bootstrapped

Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-27 Thread Alexandre Oliva
On Jul 26, 2017, Jim Wilson wrote: > On 07/24/2017 01:04 PM, David Malcolm wrote: >> * The LSP implementation is a just a proof-of-concept, to further >> motivate capturing the extra data. Turning it into a "proper" LSP >> server implementation would be a *lot* more work, and I'm unlikely to >>

[PATCH][PR target/81535] Fix tests on Power

2017-07-27 Thread Yury Gribov
Hi all, This patch fixes issues reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81535 I removed call to g in pr79439.c because gcc was duplicating the basic block with call depending on compiler flags (so scan-assembler-times pattern wasn't reliable anymore). I also added alias to

[PATCHv2][PING][PR 59521] Respect __builtin_expect in switch statements

2017-07-27 Thread Yury Gribov
Hi all, This is a ping for https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01275.html . I've fixed attachment type, hopefully it's easier to read now. This patch adds support for __builtin_expect in switch statements at tree level (RTL part would be reviewed/commited separately). It's an updat

Re: [PATCHv4][PING][PR 57371] Remove useless floating point casts in comparisons

2017-07-27 Thread Yuri Gribov
On Tue, Jul 25, 2017 at 9:32 PM, Jeff Law wrote: > On 07/25/2017 08:10 AM, Richard Biener wrote: >> On Mon, Jul 17, 2017 at 9:29 AM, Yuri Gribov wrote: >>> Hi all, >>> >>> This is an updated version of patch in >>> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00409.html . It prevents >>> optimiz

Re: [PATCH] Improve extraction of changed file in contrib/mklog

2017-07-27 Thread Yuri Gribov
On Wed, Jul 26, 2017 at 6:11 PM, Jeff Law wrote: > On 07/09/2017 01:03 PM, Yuri Gribov wrote: >> Hi, >> >> Currently mklog will fail to analyze lines like this in patches: >> diff -rupN gcc/gcc/testsuite/lib/profopt.exp >> gcc-compare-checks/gcc/testsuite/lib/profopt.exp >> (it fails with "Error:

Re: [PATCH] Fix PR middle-end/81564: ICE in group_case_labels_stmt()

2017-07-27 Thread Peter Bergner
On 7/27/17 12:21 PM, Steven Bosscher wrote: > On Wed, Jul 26, 2017 at 9:35 PM, Peter Bergner wrote: >> The test case for PR81564 exposes an issue where the case labels for a >> switch statement point to blocks that have already been removed by an >> earlier call to cleanup_tree_cfg(). In that case

Re: [PATCH,AIX] Enable Go for AIX

2017-07-27 Thread Ian Lance Taylor
On Wed, Jul 26, 2017 at 5:48 AM, REIX, Tony wrote: > Description: > * This patch enables Go on AIX. > > Tests: > * Fedora25/x86_64 + GCC trunk : Configure/Build: SUCCESS >- build made by means of gmake. > > ChangeLog: > * configure.ac, configure: Enable Go for AIX > * contrib/config-list.m

Re: [PATCH,AIX] Manage .go_export section for AIX

2017-07-27 Thread Ian Lance Taylor
On Wed, Jul 26, 2017 at 3:09 AM, REIX, Tony wrote: > Description: > * This patch manages the .go_export section as an EXCLUDE section on AIX. > > Tests: > * Fedora25/x86_64 + GCC trunk : Configure/Build: SUCCESS >- build made by means of gmake. > > ChangeLog: > * go-backend.c (go_write_expo

[PATCH] fix the handling of string precision in pretty printer (PR 81586)

2017-07-27 Thread Martin Sebor
The pretty printer treats precision in %s directives as a request to print exactly as many characters from the string argument when what precision normally (in C) means is the maximum number of characters to read from the string. It doesn't mean to read past the terminating NUL. The attached pat

[PATCH], PR target/81593, Optimize PowerPC vector sets coming from a vector extracts

2017-07-27 Thread Michael Meissner
This patches optimizes the PowerPC vector set operation for 64-bit doubles and longs where the elements in the vector set may have been extracted from another vector (PR target/81593): Here an an example: vector double test_vpasted (vector double high, vector double low) {

Re: [PATCH] C++: fix ordering of missing std #include suggestion (PR c++/81514)

2017-07-27 Thread Martin Sebor
I'm not sure why Solaris' decl of std::sprintf doesn't hit the reject path above. I was able to reproduce the behavior seen on Solaris on my Fedora box by using this: namespace std { extern int sprintf (char *dst, const char *format, ...); } This is how C library symbols were intende

Re: tls-dialect gnu2

2017-07-27 Thread H.J. Lu
On Thu, Jul 27, 2017 at 3:07 PM, Nathan Sidwell wrote: > Jan, > I notice the x86 default -mtls-dialect is GNU not GNU2. The latter was > added in 2006. Is there a reason not to default to it now? (perhaps > because of the ldso dependency?) You may have noticed. There is zero test for -mtls-di

[Patch] Testsuite fixes for failures caused by patch for PR 80925 - loop peeling and alignment

2017-07-27 Thread Steve Ellcey
I was looking at the latest aarch64 failures and noticed PR 80925.  There seems to be a consensus to change the tests to reflect the current loop peeling behaviour so I have created a patch to do that.  There are three issues with this patch that might need fixing before it can be checked in. One,

tls-dialect gnu2

2017-07-27 Thread Nathan Sidwell
Jan, I notice the x86 default -mtls-dialect is GNU not GNU2. The latter was added in 2006. Is there a reason not to default to it now? (perhaps because of the ldso dependency?) nathan -- Nathan Sidwell

RFA: Backport fix for PR80769

2017-07-27 Thread Richard Sandiford
This is a minimal-ish backport of the fix for PR80769. The trunk version also replaced open-coded instances of get_next_strinfo with calls to the new function. It also added asserts in various other places to try to ensure that related strinfos were consistently delayed or not delayed. Tested on

Re: [PATCH, rs6000] Add support for the vec_xl_be builtin

2017-07-27 Thread Segher Boessenkool
Hi Carl, On Thu, Jul 27, 2017 at 01:48:41PM -0700, Carl Love wrote: > + pat = GEN_FCN (icode) (target, addr); > + if (! pat) > +return 0; No space after "!". > + /* Reverse element order of elements if in LE mode */ Single space after "/*"; sentences end with dot space space. > + /* L

[PATCH] C++: fix ordering of missing std #include suggestion (PR c++/81514)

2017-07-27 Thread David Malcolm
PR c++/81514 reports a problem where g++.dg/lookup/missing-std-include-2.C fails on Solaris, offering the suggestion: error: 'string' is not a member of 'std' note: suggested alternative: 'sprintf' instead of the expected: error: 'string' is not a member of 'std' note: 'std::string' is

[PATCH, rs6000] Add support for the vec_xl_be builtin

2017-07-27 Thread Carl Love
GCC Maintainers: The following patch add support for the vec_xl_be builtins. The builtin always loads data in BE order. The patch has been tested on powerpc64le-unknown-linux-gnu (Power 8 LE) and on powerpc64-unknown-linux-gnu (Power 7 BE). Please let me know if the following patch is acceptab

Re: [PATCH 2/2] Remove reload_in_progress and other cleanups.

2017-07-27 Thread Peter Bergner
On 7/27/17 2:29 PM, Segher Boessenkool wrote: > Hi! > > On Thu, Jul 27, 2017 at 10:44:43AM -0500, Peter Bergner wrote: >> This patch removes reload specific code from the rs6000 port made possible >> by the elimination of the usage of the -mno-lra option. > >> * config/rs6000/predicates.md (

Re: [PATCH 1/2] Eliminate -mno-lra from the rs6000 port.

2017-07-27 Thread Peter Bergner
On 7/27/17 11:47 AM, Segher Boessenkool wrote: > On Thu, Jul 27, 2017 at 10:43:44AM -0500, Peter Bergner wrote: >> This patch makes the -mlra option a nop while disallowing -mno-lra. >> It also removes the target bit mask and its usage. >> Finally, this patch updates the testsuite by removing all u

Re: [PATCH 04/17] C frontend: capture BLT information

2017-07-27 Thread Martin Sebor
On 07/24/2017 02:05 PM, David Malcolm wrote: This patch extends the C frontend so that it optionally builds a BLT tree, by using an auto_blt_node class within the recursive descent through the parser, so that its ctor/dtors build the blt_node hierarchy; this is rapidly (I hope) rejected in the no

Re: [PATCH] [PowerPC/RTEMS] Add 64-bit support using ELFv2 ABI

2017-07-27 Thread Segher Boessenkool
On Thu, Jul 27, 2017 at 07:28:30AM +0200, Sebastian Huber wrote: > >This deletes eabi.h and I don't see you add all its definitions to > >rtems.h directly (NAME__MAIN etc.) Is this on purpose? > > Yes, I always wondered why GCC added the __eabi() call to main() out of > thin air. In general, the

Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-27 Thread Martin Sebor
I think this is great. My overall question is: is the new BLT representation available in the middle-end? If not, do you have plans to make it available? (I think it might be especially useful there, to either accurately highlight the source of a problem when it's far removed from the problem s

[PATCH] PR debug/81570: dwarf2cfi.c: Update cfa.offset in create_pseudo_cfg

2017-07-27 Thread H.J. Lu
execute_dwarf2_frame is called for each funtion. But create_cie_data is called only once to initialize cie_cfi_row for all functions. Since INCOMING_FRAME_SP_OFFSET may be different for each function, we can't use the same INCOMING_FRAME_SP_OFFSET in cie_cfi_row for all functions. This patch sets

Re: [PATCH 2/2] Remove reload_in_progress and other cleanups.

2017-07-27 Thread Segher Boessenkool
Hi! On Thu, Jul 27, 2017 at 10:44:43AM -0500, Peter Bergner wrote: > This patch removes reload specific code from the rs6000 port made possible > by the elimination of the usage of the -mno-lra option. > * config/rs6000/predicates.md (volatile_mem_operand) Remove code > related to rel

[committed] Fix C omp for verification (PR c/45784)

2017-07-27 Thread Jakub Jelinek
Hi! Apparently for C sizeof on VLA the FE tends to emit something that is folded into a COMPOUND_EXPR with the VLA decl on lhs and the actual condition on rhs. In the bar routine in the testcase I'm actually testing a case where there are multiple such COMPOUND_EXPRs. This patch accepts those an

Re: [PATCH] New C++ warning option '-Wduplicated-access-specifiers'

2017-07-27 Thread Richard Sandiford
Martin Sebor writes: > On 07/23/2017 02:42 PM, Volker Reichelt wrote: >> On 21 Jul, Martin Sebor wrote: >>> On 07/20/2017 10:35 AM, Volker Reichelt wrote: Hi, the following patch introduces a new C++ warning option -Wduplicated-access-specifiers that warns about redundant

[PATCH] Fix parloops ICE (PR tree-optimization/81578)

2017-07-27 Thread Jakub Jelinek
Hi! Not all vectorizable reductions are valid OpenMP standard reductions (we could create user defined reductions from that, but that would be quite a lot of work). This patch bails out for unsupported reductions. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2017-07-27

Re: [Patch AArch64 2/2] Fix memory sizes to load/store patterns

2017-07-27 Thread James Greenhalgh
On Mon, Jul 03, 2017 at 11:46:58AM +0100, James Greenhalgh wrote: > On Wed, Jun 21, 2017 at 11:50:08AM +0100, James Greenhalgh wrote: > > *ping* > > Ping*2 Ping*3 Thanks, James > > Thanks, > James > > > On Mon, Jun 12, 2017 at 02:54:00PM +0100, James Greenhalgh wrote: > > > > > > Hi, > > >

Re: [Mechanical Patch ARM/AArch64 1/2] Rename load/store scheduling types to encode data size

2017-07-27 Thread James Greenhalgh
On Wed, Jun 21, 2017 at 11:49:47AM +0100, James Greenhalgh wrote: > On Mon, Jun 12, 2017 at 03:28:52PM +0100, Kyrill Tkachov wrote: *ping ^2* Thanks, James > > > > On 12/06/17 14:53, James Greenhalgh wrote: > > >Hi, > > > > > >In the AArch64 backend and scheduling models there is some confusio

Re: [Patch AArch64] Stop generating BSL for simple integer code

2017-07-27 Thread James Greenhalgh
On Mon, Jun 12, 2017 at 02:44:40PM +0100, James Greenhalgh wrote: > [Sorry for the re-send. I spotted that the attributes were not right for the > new pattern I was adding. The change between this and the first version was: > > + [(set_attr "type" "neon_bsl,neon_bsl,neon_bsl,multiple") > +

Re: [PATCH] Fix PR middle-end/81564: ICE in group_case_labels_stmt()

2017-07-27 Thread Steven Bosscher
On Wed, Jul 26, 2017 at 9:35 PM, Peter Bergner wrote: > The test case for PR81564 exposes an issue where the case labels for a > switch statement point to blocks that have already been removed by an > earlier call to cleanup_tree_cfg(). In that case, the code in > group_case_labels_stmt() that doe

Re: [PATCH] [RISCV] Add RTEMS support

2017-07-27 Thread Palmer Dabbelt
It appears to work for me: I can generate a simple no-op executable and link it with multilib. I don't know anything about RTEMS, so I'm just going to trust it'll actually work :). We're not going to have bandwidth to test this, but if you're interested there's some support for running the GCC te

Re: [PATCH] Improve alloca alignment

2017-07-27 Thread Jeff Law
On 07/26/2017 05:29 PM, Wilco Dijkstra wrote: > Jeff Law wrote: > >> + if (required_align > MAX_SUPPORTED_STACK_ALIGNMENT) >> +{ >> + extra = (required_align - MAX_SUPPORTED_STACK_ALIGNMENT) >> + / BITS_PER_UNIT; >> + size = plus_constant (Pmode, size, extra); >> + size = f

Re: [PATCH 1/2] Eliminate -mno-lra from the rs6000 port.

2017-07-27 Thread Segher Boessenkool
Hi! On Thu, Jul 27, 2017 at 10:43:44AM -0500, Peter Bergner wrote: > This patch makes the -mlra option a nop while disallowing -mno-lra. > It also removes the target bit mask and its usage. > Finally, this patch updates the testsuite by removing all usage of > the -mlra and -mno-lra options. So y

Re: [PATCH][AArch64] Fix missing optimization for CMP+AND

2017-07-27 Thread James Greenhalgh
On Wed, Mar 29, 2017 at 11:17:20AM +0100, Sudi Das wrote: > > Hi all > > During combine GCC tries to merge CMP (with zero) and AND into a TST. > However, in cases where an ANDS operand is not compatible, this was being > missed. Adding a define_split where this operand was moved to a register > s

Re: [PATCH][GCC][AArch64] optimize float immediate moves (2 /4) - HF/DF/SF mode.

2017-07-27 Thread James Greenhalgh
On Mon, Jun 26, 2017 at 11:50:51AM +0100, Tamar Christina wrote: > Hi all, > > Here's the re-spun patch. > Aside from the grouping of the split patterns it now also uses h register for > the fmov for HF when available, > otherwise it forces a literal load. > > Regression tested on aarch64-none-l

Re: [PATCH][2/2] Fix PR81502

2017-07-27 Thread Andrew Pinski
On Thu, Jul 27, 2017 at 6:50 AM, Richard Biener wrote: > > I am testing the following additional pattern for match.pd to fix > PR81502 resulting in the desired optimization to > > bar: > .LFB526: > .cfi_startproc > movl%edi, %eax > ret > > the pattern optimizes a BIT_FI

RE:[PATCH,AIX] Changes for linking gotools on AIX.

2017-07-27 Thread REIX, Tony
Hi Ian, David, On AIX, that is more complicated... We have to use -static-libgo when building the libgo tests. Because AIX does not work like Linux does and because the Go libgo tests are done by duplicating several .go files of libgo packages that already appear in the libgo.a (libgo.so) libr

Re: [patch 2/2,avr] PR49847: Add hook to place read-only lookup-tables in named address-space

2017-07-27 Thread Denis Chertykov
2017-07-27 16:50 GMT+04:00 Georg-Johann Lay : > On 27.07.2017 14:29, Georg-Johann Lay wrote: >> >> For some targets, the best place to put read-only lookup tables as >> generated by -ftree-switch-conversion is not the generic address space >> but some target specific address space. >> >> This is th

[PATCH 2/2] Remove reload_in_progress and other cleanups.

2017-07-27 Thread Peter Bergner
This patch removes reload specific code from the rs6000 port made possible by the elimination of the usage of the -mno-lra option. This passed bootstrap and regtesting with no regressions, ok for trunk? Peter * config/rs6000/predicates.md (volatile_mem_operand) Remove code relate

[PATCH 1/2] Eliminate -mno-lra from the rs6000 port.

2017-07-27 Thread Peter Bergner
This patch makes the -mlra option a nop while disallowing -mno-lra. It also removes the target bit mask and its usage. Finally, this patch updates the testsuite by removing all usage of the -mlra and -mno-lra options. This passed bootstrap and regtesting with no regressions, ok for trunk? Peter

Re: [PATCH][GCC][AArch64] optimize float immediate moves (1 /4) - infrastructure.

2017-07-27 Thread James Greenhalgh
On Wed, Jul 26, 2017 at 05:00:05PM +0100, Tamar Christina wrote: > Hi James, > > I have updated the patch and have responded to your question blow. > > Ok for trunk? Ok, with a few small changes. > > > static bool > > > @@ -5857,12 +5955,6 @@ aarch64_preferred_reload_class (rtx x, > > reg_clas

[PATCH 0/2] Force usage of LRA for all rs6000 port compiles.

2017-07-27 Thread Peter Bergner
In GCC 7, the rs6000 port made the switch to using LRA over reload by default. We kept the ability of using reload in case there was an LRA issue. We have squashed all known rs6000 specific LRA bugs and now is the time to remove the ability to use reload from GCC 8/rs6000. The first patch replac

RE:[PATCH,AIX] Don't leak a file descriptor if an archive is malformed.

2017-07-27 Thread REIX, Tony
Better with the patch file... Sorry. The Resend did not add the joint file I added with first message (in HTML format, refused). Hope it's OK now. Tony Index: libbacktrace/ChangeLog === --- libbacktrace/ChangeLog (revision 250609) +++

[PATCH,AIX] Don't leak a file descriptor if an archive is malformed.

2017-07-27 Thread REIX, Tony
(Damned ! Brut text format required !!) Description: * This patch fixes a possible leak of a file descriptor if an archive is malformed. Tests: * Fedora25/x86_64 + GCC trunk : SUCCESS - gmake in libbacktrace directory * AIX : - gmake in libbacktrace directory ChangeLog: * xcoff.c: Don

Re: c-family PATCH to improve -Wsign-compare (PR c/81417)

2017-07-27 Thread David Malcolm
On Thu, 2017-07-27 at 16:42 +0200, Marek Polacek wrote: > On Tue, Jul 25, 2017 at 11:03:12AM -0400, David Malcolm wrote: > > Thanks for updating the patch. > > > > There's still an issue with ordering in the updated patch. > > > > There are three orderings: > > > > (a) the order of the express

c-family PATCH to improve and simplify -Wmultistatement-macros (PR c/81448, c/81306)

2017-07-27 Thread Marek Polacek
To recap, -Wmultistatement-macros warns for code like #define FOO y++; z++ if (i) FOO; if FOO expands to multiple statements not wrapped in {}. It tracks the location of the guard (if), the location of the body of the conditional (y++) and the location of the following statement (z++).

Re: c-family PATCH to improve -Wsign-compare (PR c/81417)

2017-07-27 Thread Marek Polacek
On Tue, Jul 25, 2017 at 11:03:12AM -0400, David Malcolm wrote: > Thanks for updating the patch. > > There's still an issue with ordering in the updated patch. > > There are three orderings: > > (a) the order of the expressions in the source code (LHS CMP RHS) > > (b) the order of kinds of s

[PATCH] Dump BB number when dumping a BB with label.

2017-07-27 Thread Martin Liška
Hi. Following simple patch adds support for dumping of BBs when it's a BB that contains a label. That makes it easier for debugging as one can find destination for an edge in dump file. Sample, before: foo (int a) { int D.1821; int _1; int _4; int _5; [0.00%] [count: INV]: switch (

[PATCH] Add -nolibc option

2017-07-27 Thread Tristan Gingold
Hello, this patch adds a new option -nolibc to supress -lc in the link command. This refines -nostdlib/-nostartfiles/nodefaultlibs, so that it is possible to link with libgcc but without libc. Our main use case is for embedded targets when we use the GNAT compiler without an installed libc.

Re: [Patch (preapproved)] Guard Copy Header pass on flag_tree_loop_vectorize

2017-07-27 Thread James Greenhalgh
On Thu, Jul 27, 2017 at 02:26:03PM +0200, Richard Biener wrote: > On Thu, Jul 27, 2017 at 2:08 PM, Jakub Jelinek wrote: > > On Thu, Jul 27, 2017 at 01:54:21PM +0200, Richard Biener wrote: > >> --- gcc/common.opt (revision 250619) > >> +++ gcc/common.opt (working copy) > >> ftree-vectori

Re: [PATCH] [RISCV] Add RTEMS support

2017-07-27 Thread Kito Cheng
Hi Sebastian: LGTM, I've test riscv32-rtems-gcc is buildable. Thanks for you patch :) Hi Palmer: Could you help to commit this patch ? Thanks. On Thu, Jul 27, 2017 at 7:05 PM, Sebastian Huber wrote: > gcc/ > * config.gcc (riscv*-*-elf*): Add (riscv*-*-rtems*). > * config/riscv/

Re: [PATCH] Fix PR middle-end/81564: ICE in group_case_labels_stmt()

2017-07-27 Thread Peter Bergner
On 7/27/17 2:48 AM, Richard Biener wrote: > On Wed, Jul 26, 2017 at 9:35 PM, Peter Bergner wrote: >> The fix here is to just treat case labels that point to blocks that have >> already been deleted similarly to case labels that point to the default >> case statement, by removing them. >> >> This p

[PATCH][2/2] Fix PR81502

2017-07-27 Thread Richard Biener
I am testing the following additional pattern for match.pd to fix PR81502 resulting in the desired optimization to bar: .LFB526: .cfi_startproc movl%edi, %eax ret the pattern optimizes a BIT_FIELD_REF on a BIT_INSERT_EXPR by either extracting from the destination or t

[PATCH] Fix PR81571

2017-07-27 Thread Richard Biener
The following fixes PR81571. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2017-07-27 Richard Biener PR tree-optimization/81571 * tree-vect-slp.c (vect_build_slp_tree): Properly verify reduction PHIs. * gcc.dg/torture/pr81571.c: New

[PATCH] Fix PR81573

2017-07-27 Thread Richard Biener
The following fixes PR81573. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2017-07-27 Richard Biener PR tree-optimization/81573 PR tree-optimization/81494 * tree-vect-loop.c (vect_create_epilog_for_reduction): Handle multi defuse cycl

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread David Malcolm
On Thu, 2017-07-27 at 10:49 +0200, Pierre-Marie de Rodat wrote: > On 07/26/2017 06:48 PM, David Malcolm wrote: > > IIRC RHEL 6 has Python 2.6 as its /usr/bin/python (but Python 2.7 > > is > > available as a "software collection" add-on). > > > > I don't know if gcc as a project would want to suppo

Re: [patch 0/2] PR49847: Add hook to place read-only lookup-tables in named address-space

2017-07-27 Thread Georg-Johann Lay
On 27.07.2017 14:34, Richard Biener wrote: On Thu, Jul 27, 2017 at 2:29 PM, Georg-Johann Lay wrote: For some targets, the best place to put read-only lookup tables as generated by -ftree-switch-conversion is not the generic address space but some target specific address space. This is the case

Re: [PATCH v2] [SPARC] Add -mfsmuld option

2017-07-27 Thread Eric Botcazou
> Thanks for your quick review. I am really glad that we can now use the > upcoming GCC 7.2 release. You"re welcome. I just realized that FSMULD would pop up out of nowhere in the log displayed by -mdebug=options so I have installed the attached fixlet. 2017-07-27 Eric Botcazou * c

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-07-27 Thread Martin Liška
PING^1 On 07/13/2017 03:48 PM, Martin Liška wrote: > On 07/11/2017 05:52 PM, Jason Merrill wrote: >> On Tue, Jul 11, 2017 at 9:37 AM, Martin Liška wrote: >>> On 07/03/2017 11:00 PM, Jason Merrill wrote: On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška wrote: > On 06/30/2017 09:34 PM, Jason

Re: [PATCH] Make __FUNCTION__ a mergeable string and do not generate symbol entry.

2017-07-27 Thread Martin Liška
PING^1 On 07/14/2017 10:35 AM, Martin Liška wrote: > On 05/01/2017 09:13 PM, Jason Merrill wrote: >> On Wed, Apr 26, 2017 at 6:58 AM, Martin Liška wrote: >>> On 04/25/2017 01:58 PM, Jakub Jelinek wrote: On Tue, Apr 25, 2017 at 01:48:05PM +0200, Martin Liška wrote: > Hello. > > Th

Re: [PATCH] Fix indirect call optimization done by autoFDO.

2017-07-27 Thread Martin Liška
On 07/26/2017 07:22 PM, Jeff Law wrote: > So is the comment wrong? Or is my interpretation wrong? > > jeff Yes, comment needs adjustment, done that in r250622. Thanks for review, Martin

Re: [PATCH] Initialize counters in autoFDO to zero, not to uninitialized.

2017-07-27 Thread Martin Liška
On 07/26/2017 07:43 PM, Jeff Law wrote: > On 07/11/2017 04:35 AM, Martin Liška wrote: >> Hello. >> >> This fixes majority of autoFDO test-cases. >> >> Patch can boostrap and survives regression tests. >> >> Ready for trunk? >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >> 2017-07-11 Martin Liska

Re: [patch 2/2,avr] PR49847: Add hook to place read-only lookup-tables in named address-space

2017-07-27 Thread Georg-Johann Lay
On 27.07.2017 14:29, Georg-Johann Lay wrote: For some targets, the best place to put read-only lookup tables as generated by -ftree-switch-conversion is not the generic address space but some target specific address space. This is the case for AVR, where for most devices .rodata must be located

Re: [7/7] Pool alignment information for common bases

2017-07-27 Thread Richard Sandiford
Richard Biener writes: > On Tue, Jul 4, 2017 at 2:01 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Mon, Jul 3, 2017 at 9:49 AM, Richard Sandiford >>> wrote: @@ -2070,8 +2143,7 @@ vect_find_same_alignment_drs (struct dat if (dra == drb) return;

Re: [patch 1/2] PR49847: Add hook to place read-only lookup-tables in named address-space

2017-07-27 Thread Georg-Johann Lay
On 27.07.2017 14:29, Georg-Johann Lay wrote: For some targets, the best place to put read-only lookup tables as generated by -ftree-switch-conversion is not the generic address space but some target specific address space. This is the case for AVR, where for most devices .rodata must be located

C++-ify vec_info structures

2017-07-27 Thread Richard Sandiford
[ Needed to unblock https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00198.html ] This patch uses new, delete, constructors and desctructors to manage vec_info. This includes making ~vec_info free all the data shared by bb_vec_info and loop_vec_info, whereas previously the code was duplicated in des

Re: [PATCH] Fix segfault in gcov.c (PR gcov-profile/81561).

2017-07-27 Thread Martin Liška
On 07/27/2017 01:48 PM, Richard Biener wrote: > On Thu, Jul 27, 2017 at 12:12 PM, Martin Liška wrote: >> Hello. >> >> As reported in mentioned PR, we segfault in gcov tool when one uses -a. It's >> caused by fact >> that vectors blocks and block_lists have indices kept in sync and as one >> remo

Re: [patch 0/2] PR49847: Add hook to place read-only lookup-tables in named address-space

2017-07-27 Thread Richard Biener
On Thu, Jul 27, 2017 at 2:29 PM, Georg-Johann Lay wrote: > For some targets, the best place to put read-only lookup tables as > generated by -ftree-switch-conversion is not the generic address space > but some target specific address space. > > This is the case for AVR, where for most devices .rod

[patch 0/2] PR49847: Add hook to place read-only lookup-tables in named address-space

2017-07-27 Thread Georg-Johann Lay
For some targets, the best place to put read-only lookup tables as generated by -ftree-switch-conversion is not the generic address space but some target specific address space. This is the case for AVR, where for most devices .rodata must be located in RAM. Part #1 adds a new, optional target h

Re: [Patch (preapproved)] Guard Copy Header pass on flag_tree_loop_vectorize

2017-07-27 Thread Richard Biener
On Thu, Jul 27, 2017 at 2:08 PM, Jakub Jelinek wrote: > On Thu, Jul 27, 2017 at 01:54:21PM +0200, Richard Biener wrote: >> --- gcc/common.opt (revision 250619) >> +++ gcc/common.opt (working copy) >> ftree-vectorize >> -Common Report Var(flag_tree_vectorize) Optimization >> +Common Repo

Re: Handle data dependence relations with different bases

2017-07-27 Thread Richard Sandiford
Richard Sandiford writes: > Eric Botcazou writes: >> [Sorry for missing the previous messages] >> >>> Thanks. Just been retesting, and I think I must have forgotten >>> to include Ada last time. It turns out that the patch causes a dg-scan >>> regression in gnat.dg/vect17.adb, because we now th

Re: [Patch (preapproved)] Guard Copy Header pass on flag_tree_loop_vectorize

2017-07-27 Thread Jakub Jelinek
On Thu, Jul 27, 2017 at 01:54:21PM +0200, Richard Biener wrote: > --- gcc/common.opt (revision 250619) > +++ gcc/common.opt (working copy) > ftree-vectorize > -Common Report Var(flag_tree_vectorize) Optimization > +Common Report Optimization > Enable vectorization on trees. > > ftree-

[PATCH][1/n] Fix PR81502

2017-07-27 Thread Richard Biener
This fixes a part of PR81502 where we fail to re-write a variable into SSA because we don't know how to re-write a bit insertion into a BIT_INSERT_EXPR. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2017-07-27 Richard Biener PR tree-optimization/815

Re: [PATCH] Switch vec_init and vec_extract optabs to 2 mode optab to allow extraction of vector from vector or initialization of vector from smaller vectors (PR target/80846)

2017-07-27 Thread Andreas Krebbel
On 07/25/2017 11:14 AM, Jakub Jelinek wrote: S/390 parts are ok. -Andreas-

Re: [Patch (preapproved)] Guard Copy Header pass on flag_tree_loop_vectorize

2017-07-27 Thread Richard Biener
On Thu, Jul 27, 2017 at 1:43 PM, James Greenhalgh wrote: > > Hi, > > While answering a user question on the equivalence of > -ftree-loop-vectorize + -ftree-slp-vectorize and -ftree-vectorize I > spotted one case which broke the equivalence. pass_ch::process_loop_p > was guarded on flag_tree_vector

Re: [PATCH] Fix segfault in gcov.c (PR gcov-profile/81561).

2017-07-27 Thread Richard Biener
On Thu, Jul 27, 2017 at 12:12 PM, Martin Liška wrote: > Hello. > > As reported in mentioned PR, we segfault in gcov tool when one uses -a. It's > caused by fact > that vectors blocks and block_lists have indices kept in sync and as one > removes an element > from blocks via: >blocked.erase (

Re: [PATCH] Bound partial-inlining-entry-probability param (PR ipa/80663).

2017-07-27 Thread Jan Hubicka
> On 05/26/2017 10:54 AM, Richard Biener wrote: > > On Thu, May 25, 2017 at 12:00 PM, Martin Liška wrote: > >> Hello. > >> > >> Having value of parameter partial-inlining-entry-probability bigger than > >> 100 does not > >> make sense and can be just used to artificially trigger partial inlining.

[Patch (preapproved)] Guard Copy Header pass on flag_tree_loop_vectorize

2017-07-27 Thread James Greenhalgh
Hi, While answering a user question on the equivalence of -ftree-loop-vectorize + -ftree-slp-vectorize and -ftree-vectorize I spotted one case which broke the equivalence. pass_ch::process_loop_p was guarded on flag_tree_vectorize, meaning you would get it for -ftree-vectorize, but not for -ftree

Re: [PATCH] Switch vec_init and vec_extract optabs to 2 mode optab to allow extraction of vector from vector or initialization of vector from smaller vectors (PR target/80846)

2017-07-27 Thread Segher Boessenkool
On Tue, Jul 25, 2017 at 11:14:32AM +0200, Jakub Jelinek wrote: > The following patch adjusts the vec_init and vec_extract optabs, so that > they don't have in the expander names just the vector mode, but also another > mode, for vec_extract the mode of the result and for vec_init the mode of > the

[PATCH] [RISCV] Add RTEMS support

2017-07-27 Thread Sebastian Huber
gcc/ * config.gcc (riscv*-*-elf*): Add (riscv*-*-rtems*). * config/riscv/rtems.h: New file. --- gcc/config.gcc | 7 ++- gcc/config/riscv/rtems.h | 31 +++ 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 gcc/config/risc

[Committed] S/390: Fix PR81534

2017-07-27 Thread Andreas Krebbel
The HI/QI atomic_fetch_" expander accepted symbolic references and emitted CAS patterns whose insn predicates rejected them. Fixed by allowing symbolic references there as well. Reload will get rid of them due to the constraint letter. Regression tested on s390x. Committed to mainline and GCC 7

Re: [PATCH] Bound partial-inlining-entry-probability param (PR ipa/80663).

2017-07-27 Thread Martin Liška
On 05/26/2017 10:54 AM, Richard Biener wrote: > On Thu, May 25, 2017 at 12:00 PM, Martin Liška wrote: >> Hello. >> >> Having value of parameter partial-inlining-entry-probability bigger than 100 >> does not >> make sense and can be just used to artificially trigger partial inlining. >> >> Patch c

[PATCH] Fix segfault in gcov.c (PR gcov-profile/81561).

2017-07-27 Thread Martin Liška
Hello. As reported in mentioned PR, we segfault in gcov tool when one uses -a. It's caused by fact that vectors blocks and block_lists have indices kept in sync and as one removes an element from blocks via: blocked.erase (it); Then calling recursively the same function breaks the synchroniz

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread Pierre-Marie de Rodat
On 07/27/2017 10:50 AM, Matthias Klose wrote: you are unconditionally hard coding python as the interpreter, which on most distributions points to 2.7. Please check python3 as well and make that the preferred interpreter if available. python 2.7 is now EOL'd for 2020. Understood, thank you. I’

Re: [PATCH 2/2] Introduce Python testcases to check DWARF output

2017-07-27 Thread Pierre-Marie de Rodat
On 07/27/2017 10:36 AM, Richard Biener wrote: Given that gdb can decode dwarf and we rely on gdb for guality and gdb has python scripting can we somehow walk its dwarf tree from within a python script? That is, not need the dwarf decoding or objdump requirement? I’m quite familiar with GDB’s P

Re: [PATCH] Move static chain and non-local goto init after NOTE_INSN_FUNCTION_BEG (PR sanitize/81186).

2017-07-27 Thread Martin Liška
On 07/25/2017 02:49 PM, Jakub Jelinek wrote: > On Tue, Jul 18, 2017 at 10:38:50AM +0200, Martin Liška wrote: >> 2017-06-27 Martin Liska >> >> PR sanitize/81186 > > 8 spaces instead of tab? > >> * function.c (expand_function_start): Set parm_birth_insn after >> static chain is

Re: [PATCH 0/2] Python testcases to check DWARF output

2017-07-27 Thread Pierre-Marie de Rodat
Thank you for your feedback. On 07/27/2017 09:52 AM, Richard Biener wrote: I'm fine with the direction if a reviewer wants to go in that direction. I wish python didn't have a built-in speed penalty, that's the only downside I don't like about it. Aside from that, even switching all of the tes

Re: [PATCH 2/2] Introduce Python testcases to check DWARF output

2017-07-27 Thread Pierre-Marie de Rodat
On 07/26/2017 07:09 PM, David Malcolm wrote: +If `single_cu` is True, make sure there is exactly one compilation unit and "is True" -> "is true" Fixed. +:param bool or_error: When True, if `single` is True and no attribute "True" -> "true" in two places Fixed. +:pa

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread Matthias Klose
you are unconditionally hard coding python as the interpreter, which on most distributions points to 2.7. Please check python3 as well and make that the preferred interpreter if available. python 2.7 is now EOL'd for 2020. Matthias On 26.07.2017 18:00, Pierre-Marie de Rodat wrote: > gcc/testsuit

Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-27 Thread Bin.Cheng
On Wed, Jul 26, 2017 at 11:06 PM, Jonathan Wakely wrote: > On 26/07/17 20:14 +0200, Paolo Carlini wrote: >> >> Hi again, >> >> On 26/07/2017 16:27, Paolo Carlini wrote: >>> >>> Hi, >>> >>> On 26/07/2017 16:21, Andreas Schwab wrote: ERROR: 27_io/basic_fstream/53984.cc: unknown dg option:

Re: [PATCH 1/2] Introduce testsuite support to run Python tests

2017-07-27 Thread Pierre-Marie de Rodat
On 07/26/2017 06:48 PM, David Malcolm wrote: IIRC RHEL 6 has Python 2.6 as its /usr/bin/python (but Python 2.7 is available as a "software collection" add-on). I don't know if gcc as a project would want to support 2.6+ or simply 2.7 for Python 2. I don’t know neither: let’s wait for further f

Ping! [Patch, fortran] PR34640 - ICE when assigning item of a derived-component to a pointer

2017-07-27 Thread Paul Richard Thomas
Hi Jerry, I apologise for the long delay in replying to you. I was on vacation in a location that excluded all but the most meagre emails :-) In addition, my workstation has been in the repair shop for the last couple of weeks and is now the subject of a warranty claim. The span field is added in

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-27 Thread Richard Biener
On Thu, Jul 27, 2017 at 10:30 AM, wrote: > From: Trevor Saunders > > The preC++ way of passing information about the call site of a function was to > use a macro that passed __file__, __LINE__, and __FUNCTION__ to a function > with > the same name with _stat appended to it. The way this is now

Re: [PATCH 2/2] Introduce Python testcases to check DWARF output

2017-07-27 Thread Richard Biener
On Wed, Jul 26, 2017 at 6:00 PM, Pierre-Marie de Rodat wrote: > For now, this supports only platforms that have an objdump available for > the corresponding target. There are several things that would be nico to > have in the future: > > * add support for more DWARF dumping tools, such as otool

Re: Patch ping

2017-07-27 Thread Jakub Jelinek
On Thu, Jul 27, 2017 at 09:19:34AM +0200, Richard Biener wrote: > > I'm building both addresses and subtracting them to get the offset. > > I guess the other option is to compute just the address of the base > > (i.e. base_addr), and add offset (if non-NULL) plus bitpos / BITS_PER_UNIT > > plus off

Re: [PATCH] Backport to GCC7

2017-07-27 Thread Martin Liška
Adding one more that I've just tested. Thanks, Martin >From 96cea83ca9362a5598ab54ed83132cc0ab30a7e7 Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 17 Jul 2017 11:44:54 + Subject: Backport r250271 gcc/ChangeLog: 2017-07-17 Martin Liska PR sanitizer/81302 * opts.c (finish_options):

[PATCH gfortran] PR53542 USE-associated variables shows original instead of renamed symbol name

2017-07-27 Thread Dominique d'Humières
Dear all, I am planning to commit the following patch as obvious (once Tobias has done the debugging) unless someone objects in the coming days. Cheers, Dominique 2017-07-27 Dominique d'Humieres PR fortran/53542 * expr.c (gfc_check_init_expr): Use the renamed name. 2017-07

  1   2   >