Re: [patch, c++] Add a warning flag for the enum bit-field declaration warning in bug #61414.

On 10/16/2017 06:37 AM, Sam van Kampen via gcc-patches wrote: ..I just realised that the clang flag is -Wbitfield-enum-conversion, not -Wenum-bitfield-conversion. Please apply the patch below instead, which has replaced the two words to remove the inconsistency. 2017-10-16 Sam van Kampen

RE: [PING][PATCH][Aarch64] Improve int<->FP conversions

Patch updated with all comments from James. Bootstrapped and tested on aarch64-linux-gnu. Okay for trunk? 2017-10-15 Michael Collison * config/aarch64/aarch64.md(_trunc>2): New pattern. (_trunchf2: New pattern. (_trunc2: New pattern. * config/aarch64/it

Re: [patch, c++] Add a warning flag for the enum bit-field declaration warning in bug #61414.

On Mon, 16 Oct 2017, Sam van Kampen via gcc-patches wrote: > +Wbitfield-enum-conversion > +C++ Var(warn_bitfield_enum_conversion) Init(1) Warning > +Warn about struct bit-fields being too small to hold enumerated types. Any option supported for C++ should also be supported for ObjC++ unless ther

[PATCH, committed] Add myself to MAINTAINERS

ChangeLog: 2017-10-16 Igor Tsimbalist * MAINTAINERS (write after approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (revision 253797) +++ MAINTAINERS (working copy) @@ -603,6 +603,7 @@ Philipp Tomsich

[PATCH] c-family: add name_hint/deferred_diagnostic (v2)

Here's an updated version of the patch which drops refcounting in favor of using gnu::unique_ptr. One wart with this approach is that the handling of suppressed diagnostics has to happen in both deferred_diagnostic subclasses, rather than in the name_hint class. It would be possible to fix this b

[committed] Add gnu::unique_ptr

From: Trevor Saunders On Mon, 2017-10-16 at 11:47 +0100, Pedro Alves wrote: > On 10/14/2017 12:35 AM, David Malcolm wrote: > > > As far as I can tell from your mail, the one issue that blocks that > > is the lack of gdb::unique_xmalloc_ptr. > > > > So here's an patch on top of the previous one

[testsuite] Fix directives order

Hi, I have noticed a few testcases where dg-do should be moved as the first directive, and others where dg-options should be moved before dg-add-options. The attached patch does that. I noticed no difference in testing, at least because the arm configs I test do not include v8m. So, no regression

Re: [PATCH] Add -fsanitize=pointer-{compare,subtract}.

Hi. All nits included in mainline review request I've just done: https://reviews.llvm.org/D38971 Martin

patch to fix PR82353

This is another version of the patch to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82353 The patch was successfully bootstrapped on x86-64 with Go and Ada. Committed as rev. 253796. Index: ChangeLog === --- ChangeLog (re

[PATCH] Do not put gimple stmt on an abnormal edge (PR sanitizer/82545).

Hi. As discussed with Jakub on IRC, we should not put ASAN reporting function on critical edges. Can that potentially lead to a missed use-after-scope, but I guess it's very rare. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Thanks, Martin gcc/ChangeLog: 2017-10-

Re: [committed] Fix another tree-ssa-dse.c thinko

On 10/16/2017 07:56 PM, Jeff Law wrote: With this patch we get a clean bootstrap & regression test with Martin's latest sbitmap checking patches on x86. Thanks Jeff for testing. May I consider this as green for installation of my patch? Martin

[PATCH][Middle-end]Fix PR80295 [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

resend this patch for middle-end to review. this patch was originally sent to aarch64 for review in the beginning: https://gcc.gnu.org/ml/gcc-patches/2017-10/msg00404.html The implementation of __builtin_update_setjmp_buf is not correct

[OBVIOUS][PATCH] Fix fallout of attribute directive ignored warning

Hi. This fixes follow-up which is caused by differences in between C and C++ FE: ./objdir/gcc/xgcc -Bobjdir/gcc /home/marxin/Programming/gcc/gcc/testsuite/c-c++-common/ubsan/attrib-5.c -c /home/marxin/Programming/gcc/gcc/testsuite/c-c++-common/ubsan/attrib-5.c:6:1: warning: ‘foobar’ attribute

[patch][arm] gcc-7-branch: Fix bootstrap on FreeBSD

Hi all, I struggled over a bootstrap issue while building gcc-7 for armv7-*-freebsd* I got a 'permission denied' while creating the arm-tables.opt file. The source tree is located on a nfs server. The below patch fixed it for me. Ok to apply? TIA, Andreas 2017-10-16 Andreas Tobler

Re: [PATCH] Avoid creation if invalid BIT_FIELD_REFs (PR tree-optimization/82549)

On October 16, 2017 8:46:12 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >The tree-cfg.c verification requires that BIT_FIELD_REF bitpos fits >into >uhwi, but fold-const.c happily creates BIT_FIELD_REFs with negative >bitpos >(on invalid source). > >The following patch just punts optimization instea

[PATCH] Avoid creation if invalid BIT_FIELD_REFs (PR tree-optimization/82549)

Hi! The tree-cfg.c verification requires that BIT_FIELD_REF bitpos fits into uhwi, but fold-const.c happily creates BIT_FIELD_REFs with negative bitpos (on invalid source). The following patch just punts optimization instead of creating BIT_FIELD_REF with negative bitpos and also adds some format

Re: [PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

> On Oct 16, 2017, at 5:52 AM, Wilco Dijkstra wrote: > > Qing Zhao wrote: > >> Is my patch Okay? > > Given it's a mid-end patch this shouldn't be marked as AArch64 specific. > Similarly the PR needs to be updated to say middle-end. So resending > it making it clear it's not a target bug shoul

[committed] Fix another tree-ssa-dse.c thinko

Martin's checking turned up another bug in the same line of code that we use to check if we're doing a real from a live location. The computation of the end of the range to check did not account for the offset of the write reference. Ugh. With this patch we get a clean bootstrap & regression te

[PATCH, Fortran, committed] PR82511: ICE Bad IO basetype (12) on attempted read or write of entire DEC structure

All, The simple attached patch which fixes PR 82511 has been committed to trunk as r253791. It regtests on x86_64-redhat-linux-gnu. The issue was an ICE when a variable containing a BT_UNION (basetype 12) component was given in a I/O list. The patch treats the BT_UNION component as a derived type

Re: [PATCH, Makefile] improve default cpu selection for e500v2

Hello Andrew, > On Oct 16, 2017, at 15:45 , Andrew Jenner wrote: > > This change is fine with me too. Thanks! Great, just checked-in. Thanks for your prompt feedback! With Kind Regards, Olivier

Re: [PATCH GCC][7/7]Merge adjacent memset builtin partitions

On Mon, Oct 16, 2017 at 5:00 PM, Bin.Cheng wrote: > On Mon, Oct 16, 2017 at 2:56 PM, Bin.Cheng wrote: >> On Thu, Oct 12, 2017 at 2:43 PM, Richard Biener >> wrote: >>> On Thu, Oct 5, 2017 at 3:17 PM, Bin Cheng wrote: Hi, This patch merges adjacent memset builtin partitions if possible.

Re: [PATCH, RFC] Add a pass counter for "are we there yet" purposes

On October 16, 2017 5:46:35 PM GMT+02:00, Sandra Loosemore wrote: >On 10/16/2017 12:53 AM, Richard Biener wrote: >> On October 16, 2017 7:38:50 AM GMT+02:00, Sandra Loosemore > wrote: >>> This patch is a first cut at solving the problem discussed in this >>> thread >>> >>> https://gcc.gnu.org/ml/

Re: [PATCH GCC][7/7]Merge adjacent memset builtin partitions

On Mon, Oct 16, 2017 at 2:56 PM, Bin.Cheng wrote: > On Thu, Oct 12, 2017 at 2:43 PM, Richard Biener > wrote: >> On Thu, Oct 5, 2017 at 3:17 PM, Bin Cheng wrote: >>> Hi, >>> This patch merges adjacent memset builtin partitions if possible. It is >>> a useful special case optimization transformin

Re: [PATCH, RFC] Add a pass counter for "are we there yet" purposes

On 10/16/2017 12:53 AM, Richard Biener wrote: On October 16, 2017 7:38:50 AM GMT+02:00, Sandra Loosemore wrote: This patch is a first cut at solving the problem discussed in this thread https://gcc.gnu.org/ml/gcc/2017-10/msg00016.html where I have some nios2 backend patches in my queue that

[PATCH GCC]Introduce qsort_range interface for GCC vector

Hi, I was asked by Richi to replace insertion sort with qsort_range in loop nest distribution patch. Although I believe stable sort (thus insertion) sort is needed in that case, I also added qsort_range interface in vec.h. The new interface might be useful in other places. Bootstrap and test on x8

Re: [PATCH] Fix bitmap_bit_in_range_p (PR tree-optimization/82493).

On 10/16/2017 06:03 AM, Martin Liška wrote: > On 10/13/2017 04:59 PM, Jeff Law wrote: >> On 10/13/2017 07:02 AM, Martin Liška wrote: >>> On 10/12/2017 11:54 PM, Jeff Law wrote: On 10/11/2017 12:13 AM, Martin Liška wrote: > 2017-10-10 Martin Liska > > PR tree-optimization/82493

Re: [patch] implement generic debug() for vectors and hash sets

One more thing. I see we have a "pvt" macro in gdbinit.in: define pvt set debug_vec_tree ($) end I propose we either remove this altogether, since we have a generic debug() way of dumping things, or implement it with "set debug($)" if somebody's finger memory will be adversely affected. (I'm lo

Re: [PATCH GCC][7/7]Merge adjacent memset builtin partitions

On Thu, Oct 12, 2017 at 2:43 PM, Richard Biener wrote: > On Thu, Oct 5, 2017 at 3:17 PM, Bin Cheng wrote: >> Hi, >> This patch merges adjacent memset builtin partitions if possible. It is >> a useful special case optimization transforming below code: >> >> #define M (256) >> #define N (512) >> >

[patch] implement generic debug() for vectors and hash sets

We have a generic mechanism for dumping types from the debugger with: (gdb) call debug(some_type) However, even though most types are implemented, we have no canonical way of dumping vectors or hash sets. The attached patch fixes this oversight. With it you can call debug(vec<>) and debug(hash_

Re: [PATCH] Add -fsanitize=pointer-{compare,subtract}.

On Mon, Oct 16, 2017 at 03:38:28PM +0200, Martin Liška wrote: > --- a/libsanitizer/asan/asan_report.cc > +++ b/libsanitizer/asan/asan_report.cc > @@ -344,14 +344,70 @@ static INLINE void CheckForInvalidPointerPair(void *p1, > void *p2) { >if (!flags()->detect_invalid_pointer_pairs) return; >

Re: [PATCH, Makefile] improve default cpu selection for e500v2

On 13/10/2017 17:07, Jeff Law wrote: On 08/31/2017 12:54 PM, Olivier Hainque wrote: Hello, gcc can be configured with an "e500v2" cpu target name, conveying SPE with double precision floats. config.gcc already has a provision for a good default cpu selection for SPE with double precision float

Re: [PATCH, GCC/ARM] Allow +nodsp for -mcpu=cortex-m33

On 16/10/17 10:27, Thomas Preudhomme wrote: > Hi, > > DSP instructions are optional for Arm Cortex-M33, yet its -mcpu option > does not allow +nodsp. Users are thus left with using > -march=armv8-m.main -mtune=cortex-m33. This patch allows +nodsp to > -mcpu=cortex-m33. > > ChangeLog entry is as f

Re: [PATCH] Add -fsanitize=pointer-{compare,subtract}.

On 10/16/2017 02:21 PM, Jakub Jelinek wrote: > On Mon, Oct 16, 2017 at 01:57:59PM +0200, Martin Liška wrote: >> Agree. Do you feel that it's right moment to trigger review process of >> libsanitizer >> changes? > > Yes. We don't have that much time left to get it through... Good, I've triggered

[Committed][testsuite] Fix PR82442

Recently the gcc.dg/vect/pr31699.c was modified to check for vect_float effective target instead for vect_double. As a result it now fails on armhf. Fix by avoiding double. Tested on armhf, aarch64 and x64. Committed as trivial. ChangeLog: 2017-10-16 Wilco Dijkstra gcc/testsuite/

[PATCH][AArch64] Wrong type-attribute for stp and str

Hi, it seems the type attributes for neon_stp and neon_store1_1reg should be the other way around. Thanks Dominik ChangeLog: 2017-10-16 Dominik Infuehr * config/aarch64/aarch64-simd.md (*aarch64_simd_mov): Fix type-attribute. -- diff --git a/gcc/config/aarch64/aarch64-simd.m

Re: [patch, c++] Add a warning flag for the enum bit-field declaration warning in bug #61414.

..I just realised that the clang flag is -Wbitfield-enum-conversion, not -Wenum-bitfield-conversion. Please apply the patch below instead, which has replaced the two words to remove the inconsistency. 2017-10-16 Sam van Kampen * c-family/c.opt: Add a warning flag for struct bit-fields

Re: [PATCH] Add -fsanitize=pointer-{compare,subtract}.

On Mon, Oct 16, 2017 at 01:57:59PM +0200, Martin Liška wrote: > Agree. Do you feel that it's right moment to trigger review process of > libsanitizer > changes? Yes. We don't have that much time left to get it through... > --- a/libsanitizer/asan/asan_report.cc > +++ b/libsanitizer/asan/asan_re

Re: [PATCH] scheduler bug fix for AArch64 insn fusing SCHED_GROUP usage

> On Oct 11, 2017, at 6:52 AM, Jim Wilson wrote: > > On Sun, 2017-09-10 at 19:45 +0200, Jim Wilson wrote: >> -- Forwarded message -- >> From: Jim Wilson >> Date: Tue, Sep 5, 2017 at 8:04 PM >> Subject: Re: [PATCH] scheduler bug fix for AArch64 insn fusing >> SCHED_GROUP usage >>

Re: [PATCH] Fix bitmap_bit_in_range_p (PR tree-optimization/82493).

On 10/13/2017 04:59 PM, Jeff Law wrote: > On 10/13/2017 07:02 AM, Martin Liška wrote: >> On 10/12/2017 11:54 PM, Jeff Law wrote: >>> On 10/11/2017 12:13 AM, Martin Liška wrote: 2017-10-10 Martin Liska PR tree-optimization/82493 * sbitmap.c (bitmap_bit_in_range_p): Fix t

Re: [PATCH] Add -fsanitize=pointer-{compare,subtract}.

On 10/13/2017 03:13 PM, Jakub Jelinek wrote: > On Fri, Oct 13, 2017 at 02:53:50PM +0200, Martin Liška wrote: >> @@ -3826,6 +3827,19 @@ pointer_diff (location_t loc, tree op0, tree op1) >> pedwarn (loc, OPT_Wpointer_arith, >> "pointer to a function used in subtraction"); >> >> + if

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

> On Oct 16, 2017, at 1:56 PM, Wilco Dijkstra wrote: > > This patch cleans up autopref scheduling. > > The code is greatly simplified. Sort accesses on the offset first, and > only if the offsets are the same fall back to other comparisons in > rank_for_schedule. This doesn't at all restore th

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

    ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts     A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so tha

Re: [PATCH][ARM] Remove movdi_vfp_cortexa8

ping   Kyrill Tkachov wrote: > On 14/12/16 16:37, Wilco Dijkstra wrote: > > > Merge the movdi_vfp_cortexa8 pattern into movdi_vfp and remove it to avoid > > unnecessary duplication and repeating bugs like PR78439 due to changes being > > applied only to one of the duplicates. > > When this was

Missing REDUCE[SD,SS] intrinsics

Hi, This patch written by Olga Makhotina adds missing intrinsics for REDUCE[SD,SS]. 16.10.2017 Olga Makhotina gcc/ * config/i386/avx512dqintrin.h (_mm_mask_reduce_sd, _mm_maskz_reduce_sd, _mm_mask_reduce_ss, _mm_maskz_reduce_ss): New intrinsics. * config/i386/i3

[patch, c++] Add a warning flag for the enum bit-field declaration warning in bug #61414.

This patch adds a warning flag for the warning described in bug report #61414. My proposed warning flag is -Wenum-bitfield-conversion, which corresponds with the warning flag that clang has for a similar warning. 2017-10-16 Sam van Kampen * c-family/c.opt: Add a warning flag for struct

Re: [PATCH 2/2] S/390: Do not end groups after fallthru edge

On 10/11/2017 01:53 PM, Robin Dapp wrote: > This patch fixes cases where we start a new group although the previous one > has > not ended. > > Regression tested on s390x. > > gcc/ChangeLog: > > 2017-10-11 Robin Dapp > > * config/s390/s390.c (s390_has_ok_fallthru): New function. >

[PATCH] Fix PR82396: qsort comparator non-negative on sorted output

This patch cleans up autopref scheduling. The code is greatly simplified.  Sort accesses on the offset first, and only if the offsets are the same fall back to other comparisons in rank_for_schedule.  This doesn't at all restore the original behaviour since we no longer compare the base address, b

Re: [AArch64] Patches for review

Hi, Here is the list of my AArch64 patches for review: * https://gcc.gnu.org/ml/gcc-patches/2017-01/msg01216.html (Fix symbol offset limit) * https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00396.html (PR60580: Fix frame pointer option magic) * https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00359

Re: [PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

Qing Zhao wrote: > Is my patch Okay? Given it's a mid-end patch this shouldn't be marked as AArch64 specific. Similarly the PR needs to be updated to say middle-end. So resending it making it clear it's not a target bug should help getting a review. Wilco

Re: [PATCH] Implement unique_xmalloc_ptr and add more selftests

On 10/14/2017 12:35 AM, David Malcolm wrote: > As far as I can tell from your mail, the one issue that blocks that > is the lack of gdb::unique_xmalloc_ptr. > > So here's an patch on top of the previous one which adds the > xmalloc_deleter (taken from gdb, but changing "xfree" to > "free", and ad

Re: [PATCH PR/82546] tree node size

On 10/16/2017 02:49 AM, Richard Biener wrote: On October 13, 2017 8:29:40 PM GMT+02:00, Nathan Sidwell wrote: I intend to continue cleaning this up of course. It's not clear to me whether we should cache these node sizes in an array, and the way it goes about checking nodes with nested switc

Re: [PATCH][GCC][testsuite][mid-end][ARM][AARCH64] Fix failing vec align tests.

Hi All, I've submitted a patch to fix this https://gcc.gnu.org/ml/gcc-patches/2017-10/msg00971.html Permission (just as the new patch) to backport these test changes to GCC 7 to fix the regressions there? Thanks, Tamar. From: Christophe Lyon Sent: Frida

[PATCH, testsuite] Add dg-require-stack-size

Hi, I noticed gcc.dg/tree-ssa/ldist-27.c failing for nvptx due to a too large stack size. I started updating the testcase using "dg-add-options stack_size", but came across dg-require-support and realized I could make a dg-require-stack-size directive with an argument, and use that instead.

[PATCH][GCC][Testsuite][SPARC][ARM] Fix vect-multitypes-1.c test on SPARC64 and ARMEB.

Hi All, This patch fixes a regression introduced by r253451. The target needs all three conditions to be true before it can vectorize unaligned accesses. This patch turns the erroneous || into an &&. regtested on aarch64-none-elf, arm-none-linux-gnueabihf, x86_64-pc-linux-gnu, armeb-none-linux-gn

Patch ping

Hi! I'd like to ping a few patches: http://gcc.gnu.org/ml/gcc-patches/2017-09/msg01939.html PR libstdc++/81706 - omp declare simd attribute vs. builtins C++ part of the patch http://gcc.gnu.org/ml/gcc-patches/2017-10/msg00162.html PR target/82370 - prefer shorter VEX encoding of VP{AND,OR,

[PATCH, GCC/ARM] Allow +nodsp for -mcpu=cortex-m33

Hi, DSP instructions are optional for Arm Cortex-M33, yet its -mcpu option does not allow +nodsp. Users are thus left with using -march=armv8-m.main -mtune=cortex-m33. This patch allows +nodsp to -mcpu=cortex-m33. ChangeLog entry is as follows: *** gcc/ChangeLog *** 2017-10-11 Thomas Preud'ho

Re: [PATCH 1/2] S/390: Handle long-running instructions

On 10/11/2017 01:53 PM, Robin Dapp wrote: ... > @@ -14623,8 +14659,13 @@ s390_sched_variable_issue (FILE *file, int verbose, > rtx_insn *insn, int more) > case 1: > case 2: > case S390_SCHED_STATE_NORMAL: > + if (s390_sched_state == 0) > + starts

RE: [PATCH, i386] Avoid 512-bit mode MOV for prefer-avx256 option in Intel AVX512 configuration

Uros, Is this patch (second one which fixed in the way as Jakub proposed) ok for the trunk? Could you please merge it? Sergey -Original Message- From: Shalnov, Sergey Sent: Friday, October 6, 2017 4:20 PM To: Jakub Jelinek Cc: 'gcc-patches@gcc.gnu.org' ; 'ubiz...@gmail.com' ; 'kirill.y

Re: [PATCH][GCC][AArch64] Restrict lrint inlining on ILP32.

Ping? From: gcc-patches-ow...@gcc.gnu.org on behalf of Tamar Christina Sent: Wednesday, September 13, 2017 4:00:24 PM To: gcc-patches@gcc.gnu.org Cc: nd; James Greenhalgh; Richard Earnshaw; Marcus Shawcroft; pins...@gmail.com Subject: [PATCH][GCC][AArch64

[openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

Hi, this patch enables some openacc test-cases for non-nvidia devices. Committed. Thanks, - Tom Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices 2017-10-16 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/declare-1.c: Don't require openacc_nvidia_accel_selected. * testsu

RE: [PATCH][GCC][ARM] Dot Product NEON patterns [Patch (2/8)]

> -Original Message- > From: Richard Earnshaw (lists) [mailto:richard.earns...@arm.com] > Sent: 12 October 2017 13:57 > To: Tamar Christina; Kyrill Tkachov; gcc-patches@gcc.gnu.org > Cc: nd; Ramana Radhakrishnan; ni...@redhat.com > Subject: Re: [PATCH][GCC][ARM] Dot Product NEON patterns

[patch] Enhance support for -Wstack-usage/-Wvla-larger-than/-Walloca-larger-than

Hi, a big limitation of -Wstack-usage/-Wvla-larger-than/-Walloca-larger-than is that you need -O2 (or more precisely -ftree-vrp) in order to be able to say something sensible for dynamically-sized objects/VLAs/calls to alloca. That can be problematic, for example if the coding guidelines preve

[committed] Another testcase for already fixed PR (PR c++/53574)

Hi! Paolo has pinged me about this PR, which is indeed fixed for years. I've checked in a slightly further reduced testcase as obvious. 2017-10-16 Jakub Jelinek PR c++/53574 * g++.dg/other/pr53574.C: New test. --- gcc/testsuite/g++.dg/other/pr53574.C.jj 2017-10-16 10:12:5