Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Jakub Jelinek
On Tue, Nov 07, 2017 at 11:08:58AM +0100, Martin Liška wrote: > > Hasn't it enabled it also for any other FEs other than C family and Fortran? > > Say jit, brig, go, lto?, ... > > I think better would be to remove the initialization to -1 and revert the > > fortran/options.c change, and instead use

Re: [PATCH] Fix use-after-free in the strlen pass (PR tree-optimization/82977)

2017-11-15 Thread Jakub Jelinek
On Tue, Nov 14, 2017 at 04:46:01PM -0700, Martin Sebor wrote: > How about at least detecting the problem then? The attached patch > catches the bug while running the Wstringop-truncation tests and > passes x86_64 bootstrap. Well, IMHO then the extra argument should be there only #if CHECKING_P, s

Re: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-15 Thread Richard Biener
On Tue, 14 Nov 2017, Tamar Christina wrote: > Hi All, > > This patch allows larger bitsizes to be used as copy size > when the target does not have SLOW_UNALIGNED_ACCESS. > > fun3: > adrpx2, .LANCHOR0 > add x2, x2, :lo12:.LANCHOR0 > mov x0, 0 > sub sp, sp,

Re: [PATCH] Fix use-after-free in the strlen pass (PR tree-optimization/82977)

2017-11-15 Thread Richard Biener
On Tue, 14 Nov 2017, Jeff Law wrote: > On 11/14/2017 02:30 PM, Jakub Jelinek wrote: > > On Tue, Nov 14, 2017 at 02:24:28PM -0700, Martin Sebor wrote: > >> On 11/14/2017 02:04 PM, Jakub Jelinek wrote: > >>> Hi! > >>> > >>> strlen_to_stridx.get (rhs1) returns an address into the hash_map, and > >>>

Re: [PATCH] Small expand_mul_overflow improvement (PR target/82981)

2017-11-15 Thread Richard Biener
On Tue, 14 Nov 2017, Jakub Jelinek wrote: > Hi! > > For targets that don't have {,u}mulv4 insn we try 3 different > expansions of the basic signed * signed -> signed or unsigned * unsigned -> > unsigned overflow computation. The first one is done if >if (GET_MODE_2XWIDER_MODE (mode).exi

Re: [PATCH][AArch64] Improve scheduling model for X-Gene

2017-11-15 Thread Dominik Inführ
Could you please commit it for me? I don’t have commit rights. Thanks, Dominik > On 13 Nov 2017, at 12:27, Kyrill Tkachov wrote: > > > On 13/11/17 11:09, Dominik Inführ wrote: >> Oh sure, I've now successfully bootstrapped on arm-linux-gnueabihf and >> aarch64-unknown-linux-gnu. >> >> Domin

Re: [PATCH] Zero vptr in dtor for -fsanitize=vptr.

2017-11-15 Thread Martin Liška
Thanks for review. I actually noticed your introduction of cp_build_fold_indirect_ref after I installed my patch. I'm testing following fix. Martin >From 63d9cff5c183f3614cff527ff991e1586a9efa5b Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 15 Nov 2017 10:01:51 +0100 Subject: [PATCH] Fix fall

Re: [PATCH] [PR82155] Fix crash in dwarf2out_abstract_function

2017-11-15 Thread Pierre-Marie de Rodat
Hello Richard, On 09/25/2017 01:54 PM, Richard Biener wrote: Ok for trunk and gcc-7 branch after a while. Is it still okay to commit to gcc-7, now? -- Pierre-Marie de Rodat

Re: [PATCH][AArch64] Improve scheduling model for X-Gene

2017-11-15 Thread Kyrill Tkachov
On 15/11/17 08:49, Dominik Inführ wrote: Could you please commit it for me? I don’t have commit rights. Ah, of course. Committed with r254759. Thanks, Kyrill Thanks, Dominik On 13 Nov 2017, at 12:27, Kyrill Tkachov wrote: On 13/11/17 11:09, Dominik Inführ wrote: Oh sure, I've now suc

Re: [build, libgcc, libgo] Adapt Solaris 12 references

2017-11-15 Thread Rainer Orth
Hi Ian, > On Tue, Nov 14, 2017 at 2:09 AM, Rainer Orth > wrote: >> >>> With the change in the Solaris release model (no more major releases >>> like Solaris 12 but only minor ones like 11.4), the Solaris 12 >>> references in GCC need to be adapted. >>> >>> The following patch does this, consistin

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Eric Botcazou
> But we don't. Wonder if in addition to your patch or instead of it it > wouldn't be safer (especially for FEs added in the future) to: > >/* If we see "return;" in some basic block, then we do reach the end > without returning a value. */ > - else if (warn_return_type > + else if (

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Martin Liška
On 11/15/2017 10:42 AM, Eric Botcazou wrote: >> But we don't. Wonder if in addition to your patch or instead of it it >> wouldn't be safer (especially for FEs added in the future) to: >> >>/* If we see "return;" in some basic block, then we do reach the end >> without returning a value.

Re: [AARCH64] implements neon vld1_*_x2 intrinsics

2017-11-15 Thread Kyrill Tkachov
Hi Kugan, On 07/11/17 04:10, Kugan Vivekanandarajah wrote: Hi, Attached patch implements the vld1_*_x2 intrinsics as defined by the neon document. Bootstrap for the latest patch is ongoing on aarch64-linux-gnu. Is this OK for trunk if no regressions? This looks mostly ok to me (though I ca

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Eric Botcazou
> Following patch survives regression tests and bootstraps. Please drop the Ada bits though, -Wreturn-type just doesn't work in Ada. -- Eric Botcazou

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Jakub Jelinek
On Wed, Nov 15, 2017 at 10:54:23AM +0100, Martin Liška wrote: > gcc/c/ChangeLog: > > 2017-11-15 Martin Liska > > * c-decl.c (grokdeclarator): > Compare warn_return_type for greater than zero. > (start_function): Likewise. > (finish_function): Likewise. > * c-typec

Re: [PATCH][GCC][ARM] Implement "arch" GCC pragma and "+" attributes [Patch (2/3)]

2017-11-15 Thread Kyrill Tkachov
Hi Tamar, On 10/11/17 10:56, Tamar Christina wrote: Hi Sandra, I've respun the patch with the docs changes you requested. Regards, Tamar > -Original Message- > From: Sandra Loosemore [mailto:san...@codesourcery.com] > Sent: 07 November 2017 03:38 > To: Tamar Christina; gcc-patches@gcc

Re: [RFA][PATCH] patch 4/n Refactor bits of vrp_visit_assignment_or_call

2017-11-15 Thread Kyrill Tkachov
Hi Jeff, I think you attached the wrong patch to this mail... Kyrill On 15/11/17 06:32, Jeff Law wrote: So the next group of changes is focused on breaking down evrp into an analysis engine and the actual optimization pass. The analysis engine can be embedded into other dom walker passes qui

Re: [PATCH] enhance -Warray-bounds to handle strings and excessive indices

2017-11-15 Thread Richard Biener
On Tue, Nov 14, 2017 at 6:45 PM, Martin Sebor wrote: > On 11/14/2017 05:28 AM, Richard Biener wrote: >> >> On Mon, Nov 13, 2017 at 6:37 PM, Martin Sebor wrote: >>> >>> Richard, this thread may have been conflated with the one Re: >>> [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets

Re: [PATCH, rs6000] (v2) GIMPLE folding for vector compares

2017-11-15 Thread Richard Biener
On Tue, Nov 14, 2017 at 11:11 PM, Will Schmidt wrote: > > Hi, > Add support for gimple folding of vec_cmp_{eq,ge,gt,le,ne} > for the integer data types. > > As part of this change, several define_insn stanzas have been added/updated > in vsx.md that specify the "ne: -> not: + eq: " combinations

Re: [PATCH][GCC][ARM] Add Armv8.3-a to AArch32.

2017-11-15 Thread Kyrill Tkachov
Hi Tamar, On 14/11/17 15:54, Tamar Christina wrote: Hi All, This patch adds Armv8.3-a as an architecture to the compiler with the feature set inherited from Armv8.2-a. Bootstrapped regtested on arm-none-linux-gnueabihf and no issues. This is ok with a couple of ChangeLog nits. gcc/ 2017-1

Re: [PATCH][GCC][ARM] Restrict TARGET_DOTPROD to baseline Armv8.2-a.

2017-11-15 Thread Kyrill Tkachov
Hi Tamar, On 14/11/17 15:53, Tamar Christina wrote: Hi All, Dot Product is intended to only be available for Armv8.2-a and newer. While this restriction is reflected in the intrinsics, the patterns themselves were missing the Armv8.2-a bit. While GCC would prevent invalid options e.g. `-march=

Re: [PATCH][GCC][ARM][AArch64] Testsuite framework changes and execution tests [Patch (8/8)]

2017-11-15 Thread Kyrill Tkachov
Hi Tamar, On 06/10/17 13:45, Tamar Christina wrote: Hi All, this is a minor respin of the patch with the comments addressed. Note this patch is now 7/8 in the series. Regtested on arm-none-eabi, armeb-none-eabi, aarch64-none-elf and aarch64_be-none-elf with no issues found. Ok for trunk?

Re: Add __builtin_tgmath for better tgmath.h implementation (bug 81156)

2017-11-15 Thread Richard Biener
On Wed, Nov 15, 2017 at 2:54 AM, Joseph Myers wrote: > Various implementations of C99/C11 have the property that > their macro expansions contain many copies of the macro arguments, so > resulting in exponential blowup of the size of macro expansions where > a call to such a macro contains other

Re: [PATCH 02/14] Support for adding and stripping location_t wrapper nodes

2017-11-15 Thread Richard Biener
On Wed, Nov 15, 2017 at 7:17 AM, Trevor Saunders wrote: > On Fri, Nov 10, 2017 at 04:45:17PM -0500, David Malcolm wrote: >> This patch provides a mechanism in tree.c for adding a wrapper node >> for expressing a location_t, for those nodes for which >> !CAN_HAVE_LOCATION_P, along with a new method

Re: [PATCH] [PR82155] Fix crash in dwarf2out_abstract_function

2017-11-15 Thread Richard Biener
On Wed, Nov 15, 2017 at 10:11 AM, Pierre-Marie de Rodat wrote: > Hello Richard, > > On 09/25/2017 01:54 PM, Richard Biener wrote: >> >> Ok for trunk and gcc-7 branch after a while. > > Is it still okay to commit to gcc-7, now? Yes. Richard. > -- > Pierre-Marie de Rodat

Re: [AARCH64] implements neon vld1_*_x2 intrinsics

2017-11-15 Thread James Greenhalgh
On Wed, Nov 15, 2017 at 09:58:28AM +, Kyrill Tkachov wrote: > Hi Kugan, > > On 07/11/17 04:10, Kugan Vivekanandarajah wrote: > > Hi, > > > > Attached patch implements the vld1_*_x2 intrinsics as defined by the > > neon document. > > > > Bootstrap for the latest patch is ongoing on aarch64-lin

RE: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-15 Thread Tamar Christina
> -Original Message- > From: Richard Biener [mailto:rguent...@suse.de] > Sent: Wednesday, November 15, 2017 08:24 > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; l...@redhat.com; > i...@airs.com > Subject: Re: [PATCH][GCC][mid-end] Allow larger copies when target > supports una

Re: [Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-15 Thread Dominique d'Humières
Hi Paul, Your patch fixes the ICE and pass the tests. However I see At line 22 of file pr78990.f90 Fortran runtime error: Attempting to allocate already allocated variable ‘return_t1' for the original tests (with mold or source). This runtime error depends on the options: % gfc pr78990.f90 %

[PATCH][GCC][DOCS][AArch64][ARM] Documentation updates adding -A extensions.

2017-11-15 Thread Tamar Christina
Hi All, This patch updates the documentation for AArch64 and ARM correcting the use of the architecture namings by adding the -A suffix in appropriate places. Build done on aarch64-none-elf and arm-none-eabi and no issues. Ok for trunk? Thanks, Tamar gcc/ 2017-11-15 Tamar Christina

Re: [PATCH] [PR82155] Fix crash in dwarf2out_abstract_function

2017-11-15 Thread Pierre-Marie de Rodat
On 11/15/2017 12:16 PM, Richard Biener wrote: Is it still okay to commit to gcc-7, now? Yes. Done. Thank you! -- Pierre-Marie de Rodat

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Martin Liška
On 11/15/2017 11:04 AM, Jakub Jelinek wrote: > On Wed, Nov 15, 2017 at 10:54:23AM +0100, Martin Liška wrote: >> gcc/c/ChangeLog: >> >> 2017-11-15 Martin Liska >> >> * c-decl.c (grokdeclarator): >> Compare warn_return_type for greater than zero. >> (start_function): Likewise. >>

[PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Martin Liška
On 11/06/2017 07:29 PM, Martin Sebor wrote: > Sorry for being late with my comment.  I just spotted this minor > formatting issue.  Even though GCC isn't (yet) consistent about > it the keyword "constexpr" should be quoted in the error message > below (and, eventually, in all diagnostic messages). 

[PATCH] Fix PR82985

2017-11-15 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to branch, testcase also to trunk. Richard. 2017-11-15 Richard Biener PR tree-optimization/82985 Backport from mainline 2017-08-15 Richard Biener PR tree-optimization/81790 * tree-ssa-scc

RE: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-15 Thread Richard Biener
On Wed, 15 Nov 2017, Tamar Christina wrote: > > > > -Original Message- > > From: Richard Biener [mailto:rguent...@suse.de] > > Sent: Wednesday, November 15, 2017 08:24 > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; l...@redhat.com; > > i...@airs.com > > Subject: Re: [PATC

lambda-switch regression

2017-11-15 Thread Nathan Sidwell
g++.dg/lambda/lambda-switch.C Has recently regressed. It appears the location of a warning message has moved. l = []() // { dg-warning "statement will never be executed" } { case 3: // { dg-error "case" } break;

Re: [patch] backwards threader cleanups

2017-11-15 Thread Pedro Alves
On 11/15/2017 07:34 AM, Aldy Hernandez wrote: > > > On 11/14/2017 02:38 PM, David Malcolm wrote: >> On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: > >>https://gcc.gnu.org/codingconventions.html#Class_Form >> says that: >> >> "When defining a class, first [...] >> declare all public

Re: [PATCH] Fix test-suite fallout of default -Wreturn-type.

2017-11-15 Thread Jonathan Wakely
On 06/11/17 15:12 +0100, Martin Liška wrote: On 11/06/2017 02:58 PM, Paolo Carlini wrote: Hi, On 06/11/2017 14:37, Martin Liška wrote: Thank you for the patch. I'm going to install the remaining part that will fix x86_64 fallout. All changes are quite obvious, so hope it's fine to install it.

[PR c++/81574] lambda capture of function reference

2017-11-15 Thread Nathan Sidwell
This patch fixes 81574. Even when the capture default is '=', a reference to a function is captured by reference. The init-capture case captures a pointer, via auto deduction machinery. AFAICT that's the correct behaviour. applying to trunk. nathan -- Nathan Sidwell 2017-11-15 Nathan Sidw

Re: [PATCH, rs6000] (v2) GIMPLE folding for vector compares

2017-11-15 Thread Segher Boessenkool
Hi Will, On Tue, Nov 14, 2017 at 04:11:34PM -0600, Will Schmidt wrote: > Add support for gimple folding of vec_cmp_{eq,ge,gt,le,ne} > for the integer data types. The code looks fine, just some typographical stuff: > * config/rs6000/vsx.md (vcmpneb, vcmpneh, vcmpnew): Update to specify >

[PATCH] i386: Update the default -mzeroupper setting

2017-11-15 Thread H.J. Lu
-mzeroupper is specified to generate vzeroupper instruction. If it isn't used, the default should depend on !TARGET_AVX512ER. Users can always use -mzeroupper or -mno-zeroupper to override it. Sebastian, can you run the full test with it? OK for trunk if there is no regression? Thanks. H.J. -

Add libgomp.oacc-c-c++-common/f-asyncwait-{1,2,3}.c

2017-11-15 Thread Tom de Vries
Hi, I noticed that there is only one asyncwait testcase for C on trunk. I've rewritten asyncwait-{1,2,3}.f90 into C (and changed the float math into int math to keep things as simple as possible). Tested on top of trunk for host. Tested on top of trunk, gcc-7-branch, openacc-gcc-7-branch, g

Re: Add __builtin_tgmath for better tgmath.h implementation (bug 81156)

2017-11-15 Thread Joseph Myers
On Wed, 15 Nov 2017, Richard Biener wrote: > Thanks - I suppose we can't avoid the repeated expansion by sth like > > #define exp(Val) ({ __typeof__ Val tem = Val; __TGMATH_UNARY_REAL_IMAG > (tem, exp, cexp); }) Well, that still expands its argument twice. You'd need to use __auto_type to avoi

Re: [PATCH] Fix pr81706 tests on darwin

2017-11-15 Thread Dominique d'Humières
Committed as revision r254770. Thanks for the review. Dominique > Le 13 nov. 2017 à 18:26, Mike Stump a écrit : > > On Nov 12, 2017, at 6:05 AM, Dominique d'Humières wrote: >> >> The following patch fixes pr81706 tests on darwin >> >> --- ../_clean/gcc/testsuite/gcc.target/i386/pr81706.c

[PATCH] Improve -Wmaybe-uninitialized documentation

2017-11-15 Thread Jonathan Wakely
The docs for -Wmaybe-uninitialized have some issues: - That first sentence is looong. - Apparently some C++ programmers think "automatic variable" means one declared with C++11 `auto`, rather than simply a local variable. - The sentence about only warning when optimizing is stuck in between

Re: [PATCH] Canonicalize constant multiplies in division

2017-11-15 Thread Wilco Dijkstra
Richard Biener wrote: > On Tue, Oct 17, 2017 at 6:32 PM, Wilco Dijkstra > wrote: >>  (if (flag_reciprocal_math) >> - /* Convert (A/B)/C to A/(B*C)  */ >> + /* Convert (A/B)/C to A/(B*C). */ >>   (simplify >>    (rdiv (rdiv:s @0 @1) @2) >> -   (rdiv @0 (mult @1 @2))) >> +  (rdiv @0 (mult @1 @2)))

[PATCH 1/3][middle-end]PR78809 (Inline strcmp with small constant strings)

2017-11-15 Thread Qing Zhao
Hi, this is the first patch for PR78809 (totally 3 patches) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78809 inline strcmp with small constant strings The design doc is at: https://www.mail-archive.com/gcc@gcc.gnu.org/msg83822.html this patch is for the first part of change: A. for strncmp (

[testsuite, committed] Compile strncpy-fix-1.c with -Wno-stringop-truncation

2017-11-15 Thread Tom de Vries
[ Re: [PATCH 3/4] enhance overflow and truncation detection in strncpy and strncat (PR 81117) ] On 08/06/2017 10:07 PM, Martin Sebor wrote: Part 3 of the series contains the meat of the patch: the new -Wstringop-truncation option, and enhancements to -Wstringop- overflow, and -Wpointer-sizeof-m

Re: [PATCH][ARM] Fix more -Wreturn-type fallout

2017-11-15 Thread Kyrill Tkachov
Hi Sudi, On 10/11/17 17:06, Sudi Das wrote: Hi This patch fixes a couple of more tests that are giving out warnings with -Wreturn-type: - g++.dg/ext/pr57735.C - gcc.target/arm/pr54300.C Thank you for the patch. I've committed it on your behalf with r254773. Kyrill *** gcc/testsuite/Cha

Re: [PATCH] Fix use-after-free in the strlen pass (PR tree-optimization/82977)

2017-11-15 Thread Martin Sebor
On 11/15/2017 01:28 AM, Richard Biener wrote: On Tue, 14 Nov 2017, Jeff Law wrote: On 11/14/2017 02:30 PM, Jakub Jelinek wrote: On Tue, Nov 14, 2017 at 02:24:28PM -0700, Martin Sebor wrote: On 11/14/2017 02:04 PM, Jakub Jelinek wrote: Hi! strlen_to_stridx.get (rhs1) returns an address into

Re: [PATCH PR82726/PR70754][2/2]New fix by finding correct root reference in combined chains

2017-11-15 Thread Bin.Cheng
On Mon, Nov 13, 2017 at 1:20 PM, Richard Biener wrote: > On Sat, Nov 11, 2017 at 11:19 AM, Bernhard Reutner-Fischer > wrote: >> On Fri, Nov 10, 2017 at 02:14:25PM +, Bin.Cheng wrote: >>> Hmm, the patch... >> >> + /* Setup UID for all statements in dominance order. */ >> + basic_block *bbs

Re: [PATCH][AArch64] Add STP pattern to store a vec_concat of two 64-bit registers

2017-11-15 Thread Christophe Lyon
Hi Kyrill, On 8 November 2017 at 19:34, Kyrill Tkachov wrote: > > On 06/06/17 14:17, James Greenhalgh wrote: >> >> On Tue, Jun 06, 2017 at 09:40:44AM +0100, Kyrill Tkachov wrote: >>> >>> Hi all, >>> >>> On top of the previous vec_merge simplifications [1] we can add this >>> pattern to perform

Re: [PATCH 02/14] Support for adding and stripping location_t wrapper nodes

2017-11-15 Thread David Malcolm
On Wed, 2017-11-15 at 12:11 +0100, Richard Biener wrote: > On Wed, Nov 15, 2017 at 7:17 AM, Trevor Saunders rg> wrote: > > On Fri, Nov 10, 2017 at 04:45:17PM -0500, David Malcolm wrote: > > > This patch provides a mechanism in tree.c for adding a wrapper > > > node > > > for expressing a location_

Re: [PATCH] Simplify floating point comparisons

2017-11-15 Thread Wilco Dijkstra
Richard Biener wrote: > On Tue, Oct 17, 2017 at 6:28 PM, Wilco Dijkstra > wrote: >> +(if (flag_unsafe_math_optimizations) >> +  /* Simplify (C / x op 0.0) to x op 0.0 for C > 0.  */ >> +  (for op (lt le gt ge) >> +   neg_op (gt ge lt le) >> +    (simplify >> +  (op (rdiv REAL_CST@0 @1) r

[PATCH] make canonicalize_condition keep its promise

2017-11-15 Thread Aaron Sawdey
So, the story of this very small patch starts with me adding patterns for ppc instructions bdz[tf] and bdnz[tf] such as this: [(set (pc) (if_then_else (and (ne (match_operand:P 1 "register_operand" "c,*b,*b,*b") (const_int 1)) (match_o

Re: [testsuite, committed] Compile strncpy-fix-1.c with -Wno-stringop-truncation

2017-11-15 Thread Martin Sebor
On 11/15/2017 08:12 AM, Tom de Vries wrote: [ Re: [PATCH 3/4] enhance overflow and truncation detection in strncpy and strncat (PR 81117) ] On 08/06/2017 10:07 PM, Martin Sebor wrote: Part 3 of the series contains the meat of the patch: the new -Wstringop-truncation option, and enhancements to

RE: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-15 Thread tamar . christina
> -Original Message- > From: Richard Biener [mailto:rguent...@suse.de] > Sent: Wednesday, November 15, 2017 12:50 > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; l...@redhat.com; > i...@airs.com > Subject: RE: [PATCH][GCC][mid-end] Allow larger copies when target > supports unali

Re: [PATCH][AArch64] Add STP pattern to store a vec_concat of two 64-bit registers

2017-11-15 Thread Kyrill Tkachov
Hi Christophe, On 15/11/17 15:31, Christophe Lyon wrote: Hi Kyrill, On 8 November 2017 at 19:34, Kyrill Tkachov wrote: On 06/06/17 14:17, James Greenhalgh wrote: On Tue, Jun 06, 2017 at 09:40:44AM +0100, Kyrill Tkachov wrote: Hi all, On top of the previous vec_merge simplifications [1] w

RE: [PATCH][GCC][ARM] Implement "arch" GCC pragma and "+" attributes [Patch (2/3)]

2017-11-15 Thread Tamar Christina
> -Original Message- > From: Kyrill Tkachov [mailto:kyrylo.tkac...@foss.arm.com] > Sent: Wednesday, November 15, 2017 10:11 > To: Tamar Christina ; Sandra Loosemore > ; gcc-patches@gcc.gnu.org > Cc: nd ; Ramana Radhakrishnan > ; Richard Earnshaw > ; ni...@redhat.com > Subject: Re: [PATCH]

Re: [patches] Re: [PATCH] RISC-V: Add Jim Wilson as a maintainer

2017-11-15 Thread Palmer Dabbelt
On Tue, 07 Nov 2017 09:53:12 PST (-0800), Palmer Dabbelt wrote: On Tue, 07 Nov 2017 09:47:37 PST (-0800), Jim Wilson wrote: On Mon, Nov 6, 2017 at 6:39 PM, Palmer Dabbelt wrote: +riscv port Jim Wilson It is jimw not jim for the email address. Please fix. Sorry.

Re: [PATCH] i386: Update the default -mzeroupper setting

2017-11-15 Thread Uros Bizjak
On Wed, Nov 15, 2017 at 2:37 PM, H.J. Lu wrote: > -mzeroupper is specified to generate vzeroupper instruction. If it > isn't used, the default should depend on !TARGET_AVX512ER. Users can > always use -mzeroupper or -mno-zeroupper to override it. > > Sebastian, can you run the full test with it?

Re: [PATCH][AArch64] Add STP pattern to store a vec_concat of two 64-bit registers

2017-11-15 Thread Christophe Lyon
On 15 November 2017 at 16:58, Kyrill Tkachov wrote: > Hi Christophe, > > > On 15/11/17 15:31, Christophe Lyon wrote: >> >> Hi Kyrill, >> >> >> On 8 November 2017 at 19:34, Kyrill Tkachov >> wrote: >>> >>> On 06/06/17 14:17, James Greenhalgh wrote: On Tue, Jun 06, 2017 at 09:40:44AM +0

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Martin Sebor
On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor formatting issue. Even though GCC isn't (yet) consistent about it the keyword "constexpr" should be quoted in the error message below (and, ev

Re: [PATCH][GCC][DOCS][AArch64][ARM] Documentation updates adding -A extensions.

2017-11-15 Thread Sandra Loosemore
On 11/15/2017 04:51 AM, Tamar Christina wrote: Hi All, This patch updates the documentation for AArch64 and ARM correcting the use of the architecture namings by adding the -A suffix in appropriate places. Just to clarify, was the documentation previously using incorrect terminology, or are

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Jonathan Wakely
On 15/11/17 09:30 -0700, Martin Sebor wrote: On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor formatting issue. Even though GCC isn't (yet) consistent about it the keyword "constexpr" should

[PATCH, GCC/ARM] Fix ICE in Armv8-M Security Extensions code

2017-11-15 Thread Thomas Preudhomme
Hi, Commit r253825 which introduced some sanity checks for sbitmap revealed a bug in the conversion of cmse_nonsecure_entry_clear_before_return () to using bitmap structure. bitmap_and expects that the two bitmaps have the same length, yet the code in cmse_nonsecure_entry_clear_before_return () h

Re: [PATCH] i386: Update the default -mzeroupper setting

2017-11-15 Thread H.J. Lu
On Wed, Nov 15, 2017 at 8:09 AM, Uros Bizjak wrote: > On Wed, Nov 15, 2017 at 2:37 PM, H.J. Lu wrote: >> -mzeroupper is specified to generate vzeroupper instruction. If it >> isn't used, the default should depend on !TARGET_AVX512ER. Users can >> always use -mzeroupper or -mno-zeroupper to over

[PATCH, GCC/testsuite/ARM] Fix selection of effective target for cmse tests

2017-11-15 Thread Thomas Preudhomme
Hi, Some of the tests in the gcc.target/arm/cmse directory (eg. gcc.target/arm/cmse/mainline/bitfield-4.c) are failing when run without an architecture specified in RUNTESTFLAGS due to them not adding the option to select an Armv8-M architecture. This patch fixes the issue by adding the right op

RE: [PATCH][GCC][DOCS][AArch64][ARM] Documentation updates adding -A extensions.

2017-11-15 Thread Tamar Christina
Hi Sandra, > -Original Message- > From: Sandra Loosemore [mailto:san...@codesourcery.com] > Sent: Wednesday, November 15, 2017 16:38 > To: Tamar Christina ; gcc-patches@gcc.gnu.org > Cc: nd ; James Greenhalgh ; > Richard Earnshaw ; Marcus Shawcroft > > Subject: Re: [PATCH][GCC][DOCS][AArc

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Martin Sebor
On 11/15/2017 09:38 AM, Jonathan Wakely wrote: On 15/11/17 09:30 -0700, Martin Sebor wrote: On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor formatting issue. Even though GCC isn't (yet) co

[PATCH, GCC/testsuite/ARM] Rework expectation for call to Armv8-M nonsecure function

2017-11-15 Thread Thomas Preudhomme
Hi, Testcase gcc.target/arm/cmse/cmse-14.c checks whether bar is called via __gnu_cmse_nonsecure_call libcall and not via a direct call. However the pattern is a bit surprising in that it needs to explicitely allow "by" due to allowing anything before the 'b'. This patch rewrites the logic to lo

Re: lambda-switch regression

2017-11-15 Thread David Malcolm
On Wed, 2017-11-15 at 08:03 -0500, Nathan Sidwell wrote: > g++.dg/lambda/lambda-switch.C Has recently regressed. g++.dg/cpp0x/lambda/lambda-switch.C > It appears the > location of a warning message has moved. > > l = []() // { dg-warning "statement will never > be execute

[PATCH, GCC/ARM] Use bitmap to control cmse_nonsecure_call register clearing

2017-11-15 Thread Thomas Preudhomme
Hi, As part of r253256, cmse_nonsecure_entry_clear_before_return has been rewritten to use auto_sbitmap instead of an integer bitfield to control which register needs to be cleared. This commit continue this work in cmse_nonsecure_call_clear_caller_saved. ChangeLog entry is as follows: *** gcc/

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Jonathan Wakely
On 15/11/17 10:04 -0700, Martin Sebor wrote: On 11/15/2017 09:38 AM, Jonathan Wakely wrote: On 15/11/17 09:30 -0700, Martin Sebor wrote: On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor for

[PATCH, GCC/ARM] Factor out CMSE register clearing code

2017-11-15 Thread Thomas Preudhomme
Hi, Functions cmse_nonsecure_call_clear_caller_saved and cmse_nonsecure_entry_clear_before_return both contain very similar code to clear registers. What's worse, they differ slightly at times so if a bug is found in one careful thoughts is needed to decide whether the other function needs fixing

[PATCH, GCC/ARM] Do no clobber r4 in Armv8-M nonsecure call

2017-11-15 Thread Thomas Preudhomme
Hi, Expanders for Armv8-M nonsecure call unnecessarily clobber r4 despite the libcall they perform not writing to r4. Furthermore, the requirement for the branch target address to be in r4 as expected by the libcall is modeled in a convoluted way in the define_insn patterns: the address is a reg

Re: [PATCH][GCC][DOCS][AArch64][ARM] Documentation updates adding -A extensions.

2017-11-15 Thread Sandra Loosemore
On 11/15/2017 10:00 AM, Tamar Christina wrote: On 11/15/2017 04:51 AM, Tamar Christina wrote: Hi All, This patch updates the documentation for AArch64 and ARM correcting the use of the architecture namings by adding the -A suffix in appropriate places. Just to clarify, was the documentation

Re: [PATCH, rs6000] Repair vec_xl, vec_xst, vec_xl_be, vec_xst_be built-in functions

2017-11-15 Thread Segher Boessenkool
Hi! On Tue, Nov 14, 2017 at 02:24:13PM -0600, Bill Schmidt wrote: > + for (i = 0; i < 16; ++i) > + perm[i] = GEN_INT (reorder[i]); > + > + pcv = force_reg (V16QImode, > + gen_rtx_CONST_VECTOR (V16QImode, > + gen_r

Re: lambda-switch regression

2017-11-15 Thread David Malcolm
On Wed, 2017-11-15 at 12:06 -0500, David Malcolm wrote: > On Wed, 2017-11-15 at 08:03 -0500, Nathan Sidwell wrote: > > g++.dg/lambda/lambda-switch.C Has recently regressed. > > g++.dg/cpp0x/lambda/lambda-switch.C > > > It appears the > > location of a warning message has moved. > > > >

Re: lambda-switch regression

2017-11-15 Thread Martin Sebor
On 11/15/2017 06:03 AM, Nathan Sidwell wrote: g++.dg/lambda/lambda-switch.C Has recently regressed. It appears the location of a warning message has moved. l = []()// { dg-warning "statement will never be executed" } { case 3:// { dg-error "case" }

Re: [PATCH] Set default to -fomit-frame-pointer

2017-11-15 Thread Wilco Dijkstra
Sandra Loosemore wrote: > I'd prefer that you remove the reference to configure options entirely > here.  Nowadays most GCC users install a package provided by their OS > distribution, Linaro, etc, rather than trying to build GCC from scratch. OK, I've removed that reference. Similarly the FRAM

Re: lambda-switch regression

2017-11-15 Thread David Malcolm
On Wed, 2017-11-15 at 12:25 -0500, David Malcolm wrote: > On Wed, 2017-11-15 at 12:06 -0500, David Malcolm wrote: > > On Wed, 2017-11-15 at 08:03 -0500, Nathan Sidwell wrote: > > > g++.dg/lambda/lambda-switch.C Has recently regressed. > > > > g++.dg/cpp0x/lambda/lambda-switch.C > > > > > It app

Re: [PATCH] make canonicalize_condition keep its promise

2017-11-15 Thread Peter Bergner
On 11/15/17 9:40 AM, Aaron Sawdey wrote: > Index: gcc/rtlanal.c > === > --- gcc/rtlanal.c (revision 254553) > +++ gcc/rtlanal.c (working copy) > @@ -5623,7 +5623,11 @@ >if (CC0_P (op0)) > return 0; > > - return

[PATCH] Add noexcept to generic std::size, std::empty and std::data

2017-11-15 Thread Jonathan Wakely
The standard doesn't say these are noexcept, but they can be. * include/bits/range_access.h (size, empty, data): Add conditional noexcept to generic overloads. Tested powerpc64le-linux, committed to trunk. commit 9348811e74851f9ce6594cbe1b98a855193867dc Author: Jonathan Wakely

Re: [PATCH] PR fortran/78240 -- kludge of the day

2017-11-15 Thread Steve Kargl
On Tue, Nov 14, 2017 at 05:21:41PM -0500, Fritz Reese wrote: > On Tue, Nov 14, 2017 at 4:58 PM, Janus Weil wrote: > > Hi guys, > > > > I see this new test case failing on x86_64-linux-gnu: > > > > FAIL: gfortran.dg/pr78240.f90 -O (test for excess errors) > > > > > > $ gfortran-8 pr78240.f90 > >

Re: [PATCH] PR fortran/78240 -- kludge of the day

2017-11-15 Thread Fritz Reese
On Wed, Nov 15, 2017 at 1:13 PM, Steve Kargl wrote: > On Tue, Nov 14, 2017 at 05:21:41PM -0500, Fritz Reese wrote: >> On Tue, Nov 14, 2017 at 4:58 PM, Janus Weil wrote: >> > Hi guys, >> > >> > I see this new test case failing on x86_64-linux-gnu: >> > >> > FAIL: gfortran.dg/pr78240.f90 -O (tes

[PATCH] Minor improvements to Filesystem tests

2017-11-15 Thread Jonathan Wakely
Make these tests a little more robust. * testsuite/27_io/filesystem/iterators/directory_iterator.cc: Leave error_code unset. * testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc: Check for past-the-end before dereferencing. * testsuite/exp

Re: [PATCH, rs6000] Correct some Power9 scheduling info

2017-11-15 Thread Pat Haugen
On 09/27/2017 12:56 PM, Pat Haugen wrote: > The following patch corrects some Power9 resource requirements and > instruction latencies. Bootstrap/regtest on powerpc64le-linux with no > new regressions. Ok for trunk? Updated patch follows. Bootstrap/regtest on powerpc64le-linux (Power9) with no reg

Re: [PATCH] i386: Update the default -mzeroupper setting

2017-11-15 Thread Uros Bizjak
On Wed, Nov 15, 2017 at 5:59 PM, H.J. Lu wrote: > On Wed, Nov 15, 2017 at 8:09 AM, Uros Bizjak wrote: >> On Wed, Nov 15, 2017 at 2:37 PM, H.J. Lu wrote: >>> -mzeroupper is specified to generate vzeroupper instruction. If it >>> isn't used, the default should depend on !TARGET_AVX512ER. Users c

[PING**2] [PATCH] Add a warning for invalid function casts

2017-11-15 Thread Bernd Edlinger
Ping... On 11/08/17 17:55, Bernd Edlinger wrote: > Ping... > > for the C++ part of this patch: > > https://gcc.gnu.org/ml/gcc-patches/2017-10/msg00559.html > > > Thanks > Bernd. > >> On 10/10/17 00:30, Bernd Edlinger wrote: >>> On 10/09/17 20:34, Martin Sebor wrote: On 10/09/2017 11:50 A

Re: Hurd port for gcc-7 go PATCH 1-3(15)

2017-11-15 Thread Matthias Klose
On 06.11.2017 16:36, Svante Signell wrote: > Hi, > > Attached are patches to enable gccgo to build properly on Debian > GNU/Hurd on gcc-7 (7-7.2.0-12). sysinfo.go:6744:7: error: redefinition of 'SYS_IOCTL' const SYS_IOCTL = _SYS_ioctl ^ sysinfo.go:6403:7: note: previous definition of 'SYS

[PATCH 4/4] libstdc++: immutable _M_sbuf in istreambuf_iterator

2017-11-15 Thread Petr Ovtchenkov
No needs to have mutable _M_sbuf in istreambuf_iterator more. --- libstdc++-v3/include/bits/streambuf_iterator.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/include/bits/streambuf_iterator.h b/libstdc++-v3/include/bits/streambuf_iterator.h index 203da9d..e2b67

[PATCH 3/4] libstdc++: avoid character accumulation in istreambuf_iterator

2017-11-15 Thread Petr Ovtchenkov
Ask associated streambuf for character when needed instead of accumulate it in istreambuf_iterator object. Benefits from this: - minus one class member in istreambuf_iterator - trivial synchronization of states of istreambuf_iterator and associated streambuf --- libstdc++-v3/include/bits/

[PATCH 1/4] Revert "2017-10-04 Petr Ovtchenkov "

2017-11-15 Thread Petr Ovtchenkov
This reverts commit 0dfbafdf338cc6899d146add5161e52efb02c067 (svn r253417). --- libstdc++-v3/include/bits/streambuf_iterator.h | 59 ++ 1 file changed, 33 insertions(+), 26 deletions(-) diff --git a/libstdc++-v3/include/bits/streambuf_iterator.h b/libstdc++-v3/include/bit

[PATCH 2/4] libstdc++: istreambuf_iterator keep attached streambuf

2017-11-15 Thread Petr Ovtchenkov
istreambuf_iterator should not forget about attached streambuf when it reach EOF. Checks in debug mode has no infuence more on character extraction in istreambuf_iterator increment operators. In this aspect behaviour in debug and non-debug mode is similar now. Test for detached srteambuf in istre

Re: Hurd port for gcc-7 go PATCH 1-3(15)

2017-11-15 Thread Svante Signell
On Wed, 2017-11-15 at 21:40 +0100, Matthias Klose wrote: > On 06.11.2017 16:36, Svante Signell wrote: > > Hi, > > > > Attached are patches to enable gccgo to build properly on Debian > > GNU/Hurd on gcc-7 (7-7.2.0-12). > > sysinfo.go:6744:7: error: redefinition of 'SYS_IOCTL' >  const SYS_IOCTL =

Re: lambda-switch regression

2017-11-15 Thread Martin Sebor
On 11/15/2017 10:38 AM, David Malcolm wrote: On Wed, 2017-11-15 at 12:25 -0500, David Malcolm wrote: On Wed, 2017-11-15 at 12:06 -0500, David Malcolm wrote: On Wed, 2017-11-15 at 08:03 -0500, Nathan Sidwell wrote: g++.dg/lambda/lambda-switch.C Has recently regressed. g++.dg/cpp0x/lambda/lamb

[PATCH] fix -mnop-mcount generate 5byte nop in 32bit.

2017-11-15 Thread 박한범
"-mnop-mcount" needs to make 5byte size "nop" instruction. however recently gcc make only 4byte "nop" in 32bit. I have test in gcc 5.4, 7.2. === bug result === 080485c5 : 80485c5: 0f 1f

Re: [PATCH 3/4] libstdc++: avoid character accumulation in istreambuf_iterator

2017-11-15 Thread Paolo Carlini
Hi, On 15/11/2017 11:48, Petr Ovtchenkov wrote: Ask associated streambuf for character when needed instead of accumulate it in istreambuf_iterator object. Benefits from this: - minus one class member in istreambuf_iterator - trivial synchronization of states of istreambuf_iterator an

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-15 Thread Michael Meissner
David tells me that the patch to enable float128 built-in functions to work with the -mabi=ieeelongdouble option broke AIX because on AIX, the float128 insns are disabled, and they all become CODE_FOR_nothing. The switch statement that was added in rs6000.c to map KFmode built-in functions to TFmo

Re: [PATCH] fix -mnop-mcount generate 5byte nop in 32bit.

2017-11-15 Thread Uros Bizjak
Hello! > "-mnop-mcount" needs to make 5byte size "nop" instruction. > however recently gcc make only 4byte "nop" in 32bit. > I have test in gcc 5.4, 7.2. -fprintf (file, "1:\tnopl 0x00(%%eax,%%eax,1)\n"); /* 5 byte nop. */ +fprintf (file, "1:\tnopl 0x01(%%eax,%%eax,1)\n"); /* 5 byte nop.

  1   2   >