Re: Patch ping

2017-11-21 Thread Jakub Jelinek
On Mon, Nov 20, 2017 at 02:58:22PM -0800, Jim Wilson wrote: > On 11/19/2017 11:55 PM, Jakub Jelinek wrote: > > I'd like to ping the following patches: > > > >http://gcc.gnu.org/ml/gcc-patches/2017-10/msg01895.html > >PR debug/82718 > >Fix DWARF5 .debug_loclist handling with hot/cold pa

Re: [PATCH] Fix load_gsi computation in store-merging (PR tree-optimization/83047)

2017-11-21 Thread Richard Biener
On Mon, 20 Nov 2017, Jakub Jelinek wrote: > Hi! > > This is something the bswap pass has been already doing, but not the > new load handling code in store-merging. If all the loads have the same > vuse, it still doesn't mean they are necessarily in the same basic block. > If they are in multiple

Re: [PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-21 Thread Richard Biener
On Mon, 20 Nov 2017, Jakub Jelinek wrote: > Hi! > > Apparently ARM can do the widening SImode multiply only using a libcall, > so the recently changed expand_mul_overflow ignores it at first, then > sees possibility to use the HImode code, but uses expand_simple_binop > with OPTAB_DIRECT which re

Re: [PATCH] Fix ICE with __RTL and -g (PR debug/82933)

2017-11-21 Thread Richard Biener
On Mon, 20 Nov 2017, Jakub Jelinek wrote: > Hi! > > The dwarf2out.c code relies on the assembly_start debug hook being > invoked before any RTL is processed from final.c (and needs it to be > done just once). Normally it is called from cgraphunit.c, but when > __RTL is seen with a starting pass,

Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-21 Thread Richard Biener
On Mon, 20 Nov 2017, Jakub Jelinek wrote: > Hi! > > All the hash_maps in tree-ssa-strlen.c except for the newly added one > were pointers to hash maps, which were constructed either lazily or during > the pass. But strlen_to_stridx is now constructed at the compiler start, > which is something I

Re: Patch ping

2017-11-21 Thread Jakub Jelinek
On Mon, Nov 20, 2017 at 01:31:39PM -0500, Nathan Sidwell wrote: > On 11/20/2017 02:55 AM, Jakub Jelinek wrote: > > >http://gcc.gnu.org/ml/gcc-patches/2017-11/msg00851.html > >C++2A P0428R2 - familiar template syntax for generic lambdas > > Are there existing testcases checking this is per

[Ping][PATCH v3] Fix Incorrect ASan global variables alignment on arm (PR sanitizer/81697)

2017-11-21 Thread Maxim Ostapenko
Hi, I would like to ping the following patch: https://gcc.gnu.org/ml/gcc-patches/2017-10/msg02288.html Thanks, -Maxim gcc/ChangeLog: 2017-11-21 Maxim Ostapenko PR sanitizer/81697 * asan.c (asan_protect_global): Add new ignore_decl_rtl_set_p parameter. Return true if ignore_decl_rtl_set_p

Re: [PATCH v3 1/14] D: The front-end (DMD) language implementation and license.

2017-11-21 Thread Iain Buclaw
On 13 November 2017 at 00:20, Andrei Alexandrescu wrote: > On 11/06/2017 01:46 PM, Iain Buclaw wrote: >> >> On 25 October 2017 at 03:06, Jeff Law wrote: >>> >>> On 10/18/2017 01:33 AM, Iain Buclaw wrote: On 6 October 2017 at 14:51, Ian Lance Taylor wrote: > > On Fri, Oct 6, 201

Re: [PATCH] rs6000: Don't touch below the stack pointer (PR77687)

2017-11-21 Thread Olivier Hainque
> On Nov 20, 2017, at 21:16 , Segher Boessenkool > wrote: > > I backported this to GCC 7 now. Nice, thanks Segher!

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-21 Thread Uros Bizjak
On Mon, Nov 20, 2017 at 4:51 PM, Marek Polacek wrote: > On Thu, Nov 16, 2017 at 02:20:59PM -0500, Jason Merrill wrote: >> On Thu, Nov 16, 2017 at 12:41 PM, Marek Polacek wrote: >> > On Tue, Nov 14, 2017 at 07:34:54AM +0100, Richard Biener wrote: >> >> On November 14, 2017 6:21:41 AM GMT+01:00, Ja

Re: [PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-21 Thread Christophe Lyon
On 21 November 2017 at 09:14, Richard Biener wrote: > On Mon, 20 Nov 2017, Jakub Jelinek wrote: > >> Hi! >> >> Apparently ARM can do the widening SImode multiply only using a libcall, >> so the recently changed expand_mul_overflow ignores it at first, then >> sees possibility to use the HImode cod

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-11-21 Thread Charles Baylis
On 20 November 2017 at 21:09, Charles Baylis wrote: > I have modified this patch accordingly. Patch 1 is no longer needed. > > Passes "make check" (with patch 3) on arm-linux-gnueabihf with no > regressions. Bootstrap is in progress. Bootstrap built successfully using qemu host. > Can I still g

Re: [patch] Add support for #pragma GCC unroll

2017-11-21 Thread Eric Botcazou
> First of all, the structuring in this section is screwed up. The > discussion and examples for the previous item (#pragma ivdep) should be > moved inside the @table so that you don't have to introduce another > @table here, just insert another entry into the existing one. That's also the case f

Re: [patch] Add support for #pragma GCC unroll

2017-11-21 Thread Eric Botcazou
> The documentation for the directive is missing indeed. We can fix this > during stage3. Someone who speaks Fortran will have to write it down... > Currently the directive works on the whole function (see > gfc_cfun_has_unroll()) and instructs the loop-optimizers to run on > that function. gfc_

Re: [PING][patch] PR81794: have "would be stringified in traditional C" warning in libcpp/macro.c be controlled by -Wtraditional

2017-11-21 Thread Bernhard Reutner-Fischer
On Mon, Nov 20, 2017 at 08:03:23PM -0500, David Malcolm wrote: > [1] FWIW the script I use for this is here: > https://github.com/davidmalcolm/gcc-build NUM_CORES=$(getconf _NPROCESSORS_ONLN || echo 1) You usually don't want to count offline processors. and in create_src, instead of fiddling

Re: [RFC][PATCH] Change default to -fcommon

2017-11-21 Thread Eric Botcazou
> There is one use in Ada which looks like an optimization for specific > targets: > > /* Ada doesn't feature Fortran-like COMMON variables so we shouldn't > try to fiddle with DECL_COMMON. However, on platforms that don't > support global BSS sections, uninitialized global variables

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-21 Thread Gerald Pfeifer
On Mon, 20 Nov 2017, Aldy Hernandez wrote: > Minor oversight... Actually, there appears to be another issue related to this when bootstrapping with clang 3.4.1 (FreeBSD 10.4): /scratch/tmp/gerald/GCC-HEAD/gcc/print-rtl.c:982:1: error: explicit instantiation cannot have a storage class DEFINE_DE

[RFC][PATCH] Extend DCE to remove unnecessary new/delete-pairs

2017-11-21 Thread Dominik Inführ
Hi, this patch tries to extend tree-ssa-dce.c to remove unnecessary new/delete-pairs (it already does that for malloc/free). Clang does it too and it seems to be allowed by http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3664.html. I’ve bootstrapped/regtested on aarch64-linux and x86_

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-21 Thread Florian Weimer
On 11/18/2017 05:49 PM, Ed Smith-Rowland wrote: I feel that distros are likely to pick up gcc-7 soon and I'd like to do *something*.  This would be something of a transition path. Historically, in glibc, we would have used symbol versioning for this, so that existing binaries retain the old be

[PATCH] Fix result for conditional reductions matching at index 0

2017-11-21 Thread Kilian Verhetsel
Hi, When translating conditional reductions based on integer induction, the compiler uses the value zero to indicate the absence of any matches: if the index of the last match is still zero at the end of the loop, the default value is returned. The problem with this approach is that this default

RE: [PATCH] Don't split call from its call arg location

2017-11-21 Thread Claudiu Zissulescu
> > gcc/ > > 2017-11-20 Claudiu Zissulescu > > > > * cfgrtl.c (force_nonfallthru_and_redirect): Don't split a call > > and its corresponding call arg location note. > OK, but please add the test from the original message you posted to > gcc.target/arc with suitable dg-options. > Commit

RE: [PATCH] [ARC] Reimplement exception handling support.

2017-11-21 Thread Claudiu Zissulescu
> Mostly OK, my only comment is about the comments! There's a couple of > places where the comments are phrased in terms of "this commit" and > "see changes". Comments in the code should (I think) be phrased in > terms of how the code is right now (or at least after the changes is > merged), so:

[committed] fix typo in find_jump_threads_backwards()

2017-11-21 Thread Aldy Hernandez
One typo I caused, and one that was already there :). Fixed both. commit eecc0d1efb049a057af214764bea6256db07828e Author: aldyh Date: Tue Nov 21 11:39:51 2017 + * tree-ssa-threadbackward.c (find_jump_threads_backwards): Fix typo in comment. diff --git a/gcc/tr

Re: [RFA][PATCH] Stack clash protection 07/08 -- V4 (aarch64 bits)

2017-11-21 Thread James Greenhalgh
I've finally built up enough courage to start getting my head around this... I see one outstanding issue sitting on this patch version: On Sat, Oct 28, 2017 at 05:08:54AM +0100, Jeff Law wrote: > On 10/13/2017 02:26 PM, Wilco Dijkstra wrote: > > --param=stack-clash-protection-probe-interval=13 >

RE: [PATCH] [ARC] update GLIBC_DYNAMIC_LINKER per glibc upstreaming review comments

2017-11-21 Thread Claudiu Zissulescu
Please also consider this for backporting as that is the gcc version in use by > glibc test harnesses ! > Backported to gcc7 branch. Cheers, Claudiu

Re: [PATCH] Add -fsanitize=pointer-{compare,subtract}.

2017-11-21 Thread Martin Liška
On 10/16/2017 10:39 PM, Martin Liška wrote: > Hi. > > All nits included in mainline review request I've just done: > https://reviews.llvm.org/D38971 > > Martin Hi. There's updated version of patch where I added new test-cases and it's rebased with latest version of libsanitizer changes. This is

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-21 Thread Aldy Hernandez
On 11/21/2017 05:59 AM, Gerald Pfeifer wrote: On Mon, 20 Nov 2017, Aldy Hernandez wrote: Minor oversight... Actually, there appears to be another issue related to this when bootstrapping with clang 3.4.1 (FreeBSD 10.4): I have no idea how to bootstrap with clang :). Perhaps someone can t

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-21 Thread Gerald Pfeifer
On Tue, 21 Nov 2017, Aldy Hernandez wrote: > I have no idea how to bootstrap with clang :). Perhaps someone can > throw a hint. It just works. Usually. :-) I run two testers, one nightly, one weekly, on a FreeBSD.org cluster, one with clang 3.4 the other with clang 4.0 right now, and while bot

[patch][i386, AVX] Adding missing mask[z]_sqrt_round_s[d,s] intrinsics

2017-11-21 Thread Makhotina, Olga
Hi, This patch adds missing intrinsics for _mm_mask[z]_sqrt_round_[sd,ss]. 21.11.2017 Olga Makhotina  gcc/   * config/i386/avx512fintrin.h (_mm_mask_sqrt_round_sd,   _mm_maskz_sqrt_round_sd, _mm_mask_sqrt_round_ss,   _mm_maskz_sqrt_round_ss): New intrinsics.

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-21 Thread Jonathan Wakely
On 21/11/17 12:33 +0100, Florian Weimer wrote: On 11/18/2017 05:49 PM, Ed Smith-Rowland wrote: I feel that distros are likely to pick up gcc-7 soon and I'd like to do *something*.  This would be something of a transition path. Historically, in glibc, we would have used symbol versioning for th

Re: [RFC][PATCH] Change default to -fcommon

2017-11-21 Thread Richard Biener
On Mon, Nov 20, 2017 at 11:00 PM, Michael Matz wrote: > Hi, > > On Mon, 20 Nov 2017, Richard Biener wrote: > >> Also we cannot raise alignment of commons and thus vectorization is >> pessimized (all vectorizer testcases use - fno-common). > > That would be a simple oversight then. That's one of t

Re: [RFC][PATCH] Change default to -fcommon

2017-11-21 Thread Michael Matz
Hi, On Tue, 21 Nov 2017, Richard Biener wrote: > > That would be a simple oversight then. That's one of the nice things > > with common symbols, they contain their own alignment which you can > > freely adjust, you don't have to care for something like section > > alignment. > > You can't be

[PATCH] Fix up -Wreturn-type (PR c++/83045)

2017-11-21 Thread Jakub Jelinek
Hi! The C++ FE now emits __builtin_unreachable () with BUILTINS_LOCATION on spots that return from functions/methods returning non-void without proper return. This breaks the -Wreturn-type warning, because we then don't see any return stmt without argument on the edges to exit, instead we see tho

[committed] Fix a buglet in store merging (PR tree-optimization/83086)

2017-11-21 Thread Jakub Jelinek
Hi! During the first loop iteration, n is uninitialized, so testing n.base_addr is wrong. Testing (i == first ? this_n.base_addr : n.base_addr) is overkill, perform_symbolic_merge will fail if some iterations have base_addr set and others don't. Bootstrapped/regtested on x86_64-linux and i686-li

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-21 Thread Marek Polacek
On Tue, Nov 21, 2017 at 10:02:34AM +0100, Uros Bizjak wrote: > LGTM for x86 part. Thanks a lot. I'll commit the patch later today. Marek

Re: [PATCH] Fix result for conditional reductions matching at index 0

2017-11-21 Thread Richard Biener
On Tue, Nov 21, 2017 at 12:35 PM, Kilian Verhetsel wrote: > > Hi, > > When translating conditional reductions based on integer induction, the > compiler uses the value zero to indicate the absence of any matches: if > the index of the last match is still zero at the end of the loop, the > default

[committed] One c-family TREE_INT_CST_LOW -> tree_to_uhwi change

2017-11-21 Thread Jakub Jelinek
Hi! When tweaking c-common.c last time, I was looking for TREE_INT_CST_LOW uses and which are justified and which aren't. This case caught my eyes, while it isn't wrong, pretty much everywhere in the compiler we after tree_fits_uhwi_p use tree_to_uhwi. Bootstrapped/regtested on x86_64-linux and

[PATCH] Fix mips hang with --help=target --help=optimizers (PR target/82880)

2017-11-21 Thread Jakub Jelinek
Hi! This is a patch from James that has been sitting in bugzilla for a few weeks. The bug is that mips_register_frame_header_opt registers the pass from a static variable which has an automatic variable in the initializer, which means that the first time it is called it is registered properly, bu

Re: Make ivopts handle calls to internal functions

2017-11-21 Thread Richard Biener
On Mon, Nov 20, 2017 at 12:31 PM, Bin.Cheng wrote: > On Fri, Nov 17, 2017 at 3:03 PM, Richard Sandiford > wrote: >> ivopts previously treated pointer arguments to internal functions >> like IFN_MASK_LOAD and IFN_MASK_STORE as normal gimple values. >> This patch makes it treat them as addresses in

Re: [RFC][PATCH] Change default to -fcommon

2017-11-21 Thread Wilco Dijkstra
Michael Matz wrote: > bss _sections_ != bss-like segments in the executable.  Targets might not > have a bss section that could be named in the asm file, or no way to > switch to it without disrupting surrounding code, but they might have > common symbols, which ultimately might or might not be

Re: Add optabs for common types of permutation

2017-11-21 Thread Richard Biener
On Mon, Nov 20, 2017 at 1:35 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: >>> On 11/09/2017 06:24 AM, Richard Sandiford wrote: ...so that we can use them for variable-length vectors. For now constant-length vectors continue

RE: [PATCH] Fix mips hang with --help=target --help=optimizers (PR target/82880)

2017-11-21 Thread Moore, Catherine
> -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Tuesday, November 21, 2017 9:07 AM > To: Moore, Catherine ; Matthew > Fortune > Cc: gcc-patches@gcc.gnu.org; James Cowgill > > Subject: [PATCH] Fix mips hang with --help=target --help=optimizers (PR > target/82

Re: Add support for in-order addition reduction using SVE FADDA

2017-11-21 Thread Richard Biener
On Mon, Nov 20, 2017 at 1:54 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Fri, Nov 17, 2017 at 5:53 PM, Richard Sandiford >> wrote: >>> This patch adds support for in-order floating-point addition reductions, >>> which are suitable even in strict IEEE mode. >>> >>> Previously vect

Re: [committed][PATCH] Fix bogus propagation in DOM

2017-11-21 Thread Richard Biener
On Mon, Nov 20, 2017 at 7:33 PM, Jeff Law wrote: > On 11/20/2017 03:25 AM, Richard Biener wrote: >> On Sun, Nov 19, 2017 at 9:16 PM, Jeff Law wrote: >>> On my local branch gcc.dg/torture/pr56349.c fails by sending GCC into an >>> infinite loop trying to simplify a self-referring statement. ie >>>

Re: [14/nn] Add helpers for shift count modes

2017-11-21 Thread Richard Biener
On Mon, Nov 20, 2017 at 10:02 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Thu, Oct 26, 2017 at 2:06 PM, Richard Biener >> wrote: >>> On Mon, Oct 23, 2017 at 1:25 PM, Richard Sandiford >>> wrote: This patch adds a stub helper routine to provide the mode of a scalar shif

Re: Cleanup predict.c

2017-11-21 Thread Martin Liška
On 11/14/2017 05:07 PM, Martin Liška wrote: > On 11/14/2017 10:20 AM, Jan Hubicka wrote: >> @@ -4670,11 +4671,12 @@ expand_call_inline (basic_block bb, gimp >>       if (dump_file && (dump_flags & TDF_DETAILS)) >>   { >> -  fprintf (dump_file, "Inlining "); >> -  print_generic_expr (dum

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Martin Liška
Hi. I'm sending v2 of the patch where I fixed test-suite fallout. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin >From 3195b1b71c387b1359c90f6e752e1c312120cd69 Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 15 Nov 2017 08:41:12 +0100 S

[libstdc++-,doc] Mislocated

2017-11-21 Thread Przemyslaw Wirkus
Hello, Wrong element position causes libstdc++v3 make doc-pdf-docbook docs generation procedure to fail. PDF documentation generation for libstdc++v3 is broken for make doc-pdf-docbook rule. Pdflatex compilation fail because Latex is not correctly generated from wrongly formatted variablelist el

Re: [libstdc++-,doc] Mislocated

2017-11-21 Thread Jonathan Wakely
On 21/11/17 15:22 +, Przemyslaw Wirkus wrote: Hello, Wrong element position causes libstdc++v3 make doc-pdf-docbook docs generation procedure to fail. PDF documentation generation for libstdc++v3 is broken for make doc-pdf-docbook rule. Pdflatex compilation fail because Latex is not correc

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Martin Sebor
On 11/21/2017 08:00 AM, Martin Liška wrote: Hi. I'm sending v2 of the patch where I fixed test-suite fallout. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. The changes look good to me. Thanks for the nice cleanup! Martin PS While going through the patch I notic

[PATCH] C: don't suggest names that came from earlier failures (PR c/83056)

2017-11-21 Thread David Malcolm
PR c/83056 reports an issue affecting trunk and gcc-7 in which the C frontend's implementation of lookup_name_fuzzy uses undeclared identifiers as suggestions when encountering subsequent undeclared identifiers. The fix is to filter out the names bound to error_mark_node in lookup_name_fuzzy. The

Re: [PATCH] C: don't suggest names that came from earlier failures (PR c/83056)

2017-11-21 Thread Marek Polacek
On Tue, Nov 21, 2017 at 10:45:56AM -0500, David Malcolm wrote: > PR c/83056 reports an issue affecting trunk and gcc-7 in which > the C frontend's implementation of lookup_name_fuzzy uses undeclared > identifiers as suggestions when encountering subsequent undeclared > identifiers. > > The fix is

RE: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-21 Thread Shalnov, Sergey
Uros, I did new patch with all comments addressed as proposed. 1. old option -mprefer-avx128 is Alias(mprefer-vector-width=, 128, none) 2. Simplified default initialization (as Bernhard proposed) 3. Fixed documentation (proposed by Sandra) 4. Several tests are changed to use new style of the option

Re: Backports for GCC 7 branch

2017-11-21 Thread Martin Liška
Hi. There's another bunch of backports to GCC 7 branch I've just tested and bootstrapped. Martin >From 6a918e72d251dd4e2aa8b2c9643f857ceef3997d Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 31 Oct 2017 11:55:19 + Subject: [PATCH 4/7] Backport r254257 gcc/ChangeLog: 2017-10-31 Martin Li

Re: [patch, fortran] Implement maxloc and minloc for character

2017-11-21 Thread Janne Blomqvist
On Mon, Nov 20, 2017 at 8:29 PM, Thomas Koenig wrote: > Am 20.11.2017 um 09:30 schrieb Janne Blomqvist: >> >> On Sun, Nov 19, 2017 at 11:11 PM, Thomas Koenig >> wrote: >>> >>> There is one question regarding the ABI. Apparently, the string length >>> is passed as an int even on a 64-bit system. I

Re: [PATCH] [MSP430] [PR78554] Prevent SUBREG from referencing a SYMBOL_REF

2017-11-21 Thread Jeff Law
On 08/24/2017 07:18 AM, Jozef Lawrynowicz wrote: > As reported in PR78554, attempting to store an __int20 address in memory > causes an ICE due to an invalid insn. This only occurs at optimisation > levels higher than -O0 because these optimisation levels pass > -ftree-ter, which causes the compile

Re: [1/4] Give the target more control over ARRAY_TYPE modes

2017-11-21 Thread Jeff Law
On 11/08/2017 08:12 AM, Richard Sandiford wrote: > So far we've used integer modes for LD[234] and ST[234] arrays. > That doesn't scale well to SVE, since the sizes aren't fixed at > compile time (and even if they were, we wouldn't want integers > to be so wide). > > This patch lets the target use

Re: [libstdc++-,doc] Mislocated

2017-11-21 Thread Przemyslaw Wirkus
On 21/11/17 15:27 +, Jonathan Wakely wrote: >>OK for trunk? >OK, thanks. I don't have privileges to commit. Could you please commit it on my behalf?

Re: Add support for in-order addition reduction using SVE FADDA

2017-11-21 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 20, 2017 at 1:54 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Fri, Nov 17, 2017 at 5:53 PM, Richard Sandiford >>> wrote: This patch adds support for in-order floating-point addition reductions, which are suitable even in strict I

Re: [PATCH] Simplify floating point comparisons

2017-11-21 Thread Jeff Law
On 11/15/2017 08:36 AM, Wilco Dijkstra wrote: > Richard Biener wrote: >> On Tue, Oct 17, 2017 at 6:28 PM, Wilco Dijkstra >> wrote: > >>> +(if (flag_unsafe_math_optimizations) >>> +  /* Simplify (C / x op 0.0) to x op 0.0 for C > 0.  */ >>> +  (for op (lt le gt ge) >>> +   neg_op (gt ge lt le

Re: [PATCH] Fix result for conditional reductions matching at index 0

2017-11-21 Thread Kilian Verhetsel
> This is PR81179 I think, please mention that in the changelog. Correct, my bad for missing that. > This unconditionally pessimizes code even if there is no valid index > zero, right? Almost, since for a loop such as: #define OFFSET 1 unsigned int find(const unsigned int *a, unsigned int

Re: Add support for in-order addition reduction using SVE FADDA

2017-11-21 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 20, 2017 at 1:54 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Fri, Nov 17, 2017 at 5:53 PM, Richard Sandiford >>> wrote: This patch adds support for in-order floating-point addition reductions, which are suitable even in strict I

Re: [DWARF] mark partial fn versions and OMP frags as partial in dwarf2+ debug info

2017-11-21 Thread Jeff Law
On 11/15/2017 12:05 AM, Alexandre Oliva wrote: > debug info: partial noentry functions: infra > > This is the first patch of a set that addresses two different but > somewhat related issues. > > On the one hand, after partial inlining, the non-inlined function > fragment is output in a way that d

Re: Add support for in-order addition reduction using SVE FADDA

2017-11-21 Thread Jeff Law
On 11/21/2017 09:45 AM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Nov 20, 2017 at 1:54 PM, Richard Sandiford >> wrote: >>> Richard Biener writes: On Fri, Nov 17, 2017 at 5:53 PM, Richard Sandiford wrote: > This patch adds support for in-order floating-point addi

Re: [PATCH] handle non-constant offsets in -Wstringop-overflow (PR 77608)

2017-11-21 Thread Jeff Law
On 11/19/2017 04:28 PM, Martin Sebor wrote: > On 11/18/2017 12:53 AM, Jeff Law wrote: >> On 11/17/2017 12:36 PM, Martin Sebor wrote: >>> The attached patch enhances -Wstringop-overflow to detect more >>> instances of buffer overflow at compile time by handling non- >>> constant offsets into the des

Re: [RFTesting] New POINTER_DIFF_EXPR

2017-11-21 Thread Jeff Law
On 11/19/2017 04:54 PM, Marc Glisse wrote: > Hello, > > new version, regtested on powerpc64le-unknown-linux-gnu. The front-end > parts are up for review. > > 2017-10-28  Marc Glisse  > > gcc/c/ > * c-fold.c (c_fully_fold_internal): Handle POINTER_DIFF_EXPR. > * c-typeck.c (pointer_diff)

Re: [PATCH] Fix result for conditional reductions matching at index 0

2017-11-21 Thread Alan Hayward
> On 21 Nov 2017, at 16:43, Kilian Verhetsel > wrote: > > >> This is PR81179 I think, please mention that in the changelog. > > Correct, my bad for missing that. > >> This unconditionally pessimizes code even if there is no valid index >> zero, right? > > Almost, since for a loop such as: >

Re: [PATCH] make canonicalize_condition keep its promise

2017-11-21 Thread Jeff Law
On 11/20/2017 06:41 AM, Aaron Sawdey wrote: > On Sun, 2017-11-19 at 16:44 -0700, Jeff Law wrote: >> On 11/15/2017 08:40 AM, Aaron Sawdey wrote: >>> So, the story of this very small patch starts with me adding >>> patterns >>> for ppc instructions bdz[tf] and bdnz[tf] such as this: >>> >>>   [(set (

Re: Add support for in-order addition reduction using SVE FADDA

2017-11-21 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 20, 2017 at 1:54 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Fri, Nov 17, 2017 at 5:53 PM, Richard Sandiford >>> wrote: This patch adds support for in-order floating-point addition reductions, which are suitable even in strict I

Re: [RFC][PATCH] Extend DCE to remove unnecessary new/delete-pairs

2017-11-21 Thread Jeff Law
On 11/21/2017 04:14 AM, Dominik Inführ wrote: > Hi, > > this patch tries to extend tree-ssa-dce.c to remove unnecessary > new/delete-pairs (it already does that for malloc/free). Clang does it too > and it seems to be allowed by > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3664.ht

Re: Add support for in-order addition reduction using SVE FADDA

2017-11-21 Thread Richard Sandiford
Jeff Law writes: > On 11/21/2017 09:45 AM, Richard Sandiford wrote: >> Richard Biener writes: >>> On Mon, Nov 20, 2017 at 1:54 PM, Richard Sandiford >>> wrote: Richard Biener writes: > On Fri, Nov 17, 2017 at 5:53 PM, Richard Sandiford > wrote: >> This patch adds support for i

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Jeff Law
On 11/21/2017 08:00 AM, Martin Liška wrote: > Hi. > > I'm sending v2 of the patch where I fixed test-suite fallout. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > Ready to be installed? > Martin > > > 0001-Add-quotes-for-constexpr-keyword.patch > > > From

Re: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-21 Thread Uros Bizjak
On Tue, Nov 21, 2017 at 4:50 PM, Shalnov, Sergey wrote: > Uros, > I did new patch with all comments addressed as proposed. > 1. old option -mprefer-avx128 is Alias(mprefer-vector-width=, 128, none) > 2. Simplified default initialization (as Bernhard proposed) > 3. Fixed documentation (proposed by

RE: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-21 Thread Shalnov, Sergey
Uros, Yes, please. Thank you for your proposals and comments. Please commit as you proposed. Sergey -Original Message- From: Uros Bizjak [mailto:ubiz...@gmail.com] Sent: Tuesday, November 21, 2017 6:13 PM To: Shalnov, Sergey Cc: gcc-patches@gcc.gnu.org; kirill.yuk...@gmail.com; Koval, Ju

Re: [PATCH] Fix up -Wreturn-type (PR c++/83045)

2017-11-21 Thread Jeff Law
On 11/21/2017 06:52 AM, Jakub Jelinek wrote: > Hi! > > The C++ FE now emits __builtin_unreachable () with BUILTINS_LOCATION > on spots that return from functions/methods returning non-void without > proper return. This breaks the -Wreturn-type warning, because we then > don't see any return stmt

RE: [PATCH][GCC][ARM] Dot Product NEON intrinsics [Patch (3/8)]

2017-11-21 Thread Tamar Christina
Ping > -Original Message- > From: Tamar Christina [mailto:tamar.christ...@arm.com] > Sent: Monday, November 6, 2017 16:54 > To: gcc-patches@gcc.gnu.org > Cc: nd ; Ramana Radhakrishnan > ; Richard Earnshaw > ; ni...@redhat.com; Kyrylo Tkachov > > Subject: [PATCH][GCC][ARM] Dot Product NEON

RE: [PATCH][GCC][ARM] Generate .arch and .arch_extensions for each function if required. [Patch (3/3)]

2017-11-21 Thread Tamar Christina
Ping > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Tamar Christina > Sent: Monday, November 6, 2017 16:52 > To: gcc-patches@gcc.gnu.org > Cc: nd ; Ramana Radhakrishnan > ; Richard Earnshaw > ; ni...@redhat.com; Kyrylo Tkac

RE: [PATCH][GCC][DOCS][AArch64][ARM] Documentation updates adding -A extensions.

2017-11-21 Thread Tamar Christina
Ping > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Tamar Christina > Sent: Wednesday, November 15, 2017 11:51 > To: gcc-patches@gcc.gnu.org > Cc: nd ; James Greenhalgh ; > Richard Earnshaw ; Marcus Shawcroft > > Subject:

Re: Fix PR82849 (ICE in modulo scheduling)

2017-11-21 Thread Jeff Law
On 11/19/2017 07:46 AM, Jan Hubicka wrote: > Hi, > my understanding of the code is that trip_count is trying to estimate number > of iterations when counts are available and disable modulo scheduler for > loops with too few iterations. That's my reading as well. > We now have get_estimated_loop_it

Re: [RFC][PATCH] Extend DCE to remove unnecessary new/delete-pairs

2017-11-21 Thread Dominik Inführ
Thanks for the reply, I know that it’s too late for GCC 8. I wanted to get some feedback on this patch, so I could address all issues until GCC 9 development starts. But I suppose it is better to just post it again later. Dominik > On 21 Nov 2017, at 18:09, Jeff Law wrote: > > On 11/21/2017 0

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-11-21 Thread James Greenhalgh
On Mon, Nov 20, 2017 at 07:22:15PM +, Steve Ellcey wrote: > On Mon, 2017-11-20 at 18:27 +, James Greenhalgh wrote: > > > > If you have the time, would you mind giving me a quick run-down of what > > design decisions went in to this patch, and why they are the right thing > > to do? Sorry t

Re: [RFC][PATCH] Extend DCE to remove unnecessary new/delete-pairs

2017-11-21 Thread Jeff Law
On 11/21/2017 10:30 AM, Dominik Inführ wrote: > Thanks for the reply, I know that it’s too late for GCC 8. I wanted to get > some feedback on this patch, so I could address all issues until GCC 9 > development starts. But I suppose it is better to just post it again later. The problem is most fol

[PATCH, i386]: Improve movbe insn a bit

2017-11-21 Thread Uros Bizjak
2017-11-21 Uros Bizjak * config/i386/i386.md (*bswap2_movbe): Add integer suffix to movbe mnemonic. (*bswaphi2_movbe): Ditto. (bswaphi_lowpart): Merge with *bswaphi_lowpart_1. testsuite/ChangeLog: 2017-11-21 Uros Bizjak * gcc.target/i386/movbe-1.c: Update scan string f

Re: [PATCH] make canonicalize_condition keep its promise

2017-11-21 Thread Aaron Sawdey
On Tue, 2017-11-21 at 10:06 -0700, Jeff Law wrote: > On 11/20/2017 06:41 AM, Aaron Sawdey wrote: > > On Sun, 2017-11-19 at 16:44 -0700, Jeff Law wrote: > > > On 11/15/2017 08:40 AM, Aaron Sawdey wrote: > > > > So, the story of this very small patch starts with me adding > > > > patterns > > > > for

Re: [DWARF] mark partial fn versions and OMP frags as partial in dwarf2+ debug info

2017-11-21 Thread Jakub Jelinek
On Wed, Nov 15, 2017 at 05:05:36AM -0200, Alexandre Oliva wrote: > debug info: partial noentry functions: infra > > This is the first patch of a set that addresses two different but > somewhat related issues. > > On the one hand, after partial inlining, the non-inlined function > fragment is outp

Re: [PATCH, GCC/ARM] Fix cmse_nonsecure_entry return insn size

2017-11-21 Thread Thomas Preudhomme
Hi Kyrill, On 09/11/17 14:26, Kyrill Tkachov wrote: Hi Thomas, On 08/11/17 09:50, Thomas Preudhomme wrote: Hi, A number of instructions are output in assembler form by output_return_instruction () when compiling a function with the cmse_nonsecure_entry attribute for Armv8-M Mainline with hard

Re: [libstdc++-,doc] Mislocated

2017-11-21 Thread Jonathan Wakely
On 21/11/17 16:36 +, Przemyslaw Wirkus wrote: On 21/11/17 15:27 +, Jonathan Wakely wrote: OK for trunk? OK, thanks. I don't have privileges to commit. Could you please commit it on my behalf? Done - thanks again for the patch.

[Patch, rs6000] Fix register values in ppc-asm.h

2017-11-21 Thread Pat Haugen
The following patch fixes a couple typos in ppc-asm.h. Committed as obvious. Will also backport to GCC 6/7 branches. -Pat 2017-11-21 Pat Haugen * config/rs6000/ppc-asm.h (f50, vs50): Fix values. Index: gcc/config/rs6000/ppc-asm.h

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Martin Liška
On 11/21/2017 06:13 PM, Jeff Law wrote: On 11/21/2017 08:00 AM, Martin Liška wrote: Hi. I'm sending v2 of the patch where I fixed test-suite fallout. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin 0001-Add-quotes-for-constexpr-keywor

Re: Backports for GCC 7 branch

2017-11-21 Thread Martin Liška
I'm going to install one more patch. Martin >From e58dd9f5b28468e2afb928c767041e5a3fef057f Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 27 Oct 2017 08:34:56 + Subject: [PATCH] Backport r254137 gcc/ChangeLog: 2017-10-27 Martin Liska PR gcov-profile/82457 * doc/invoke.texi: Documen

Re: [PATCH] handle non-constant offsets in -Wstringop-overflow (PR 77608)

2017-11-21 Thread Martin Sebor
On 11/21/2017 09:55 AM, Jeff Law wrote: On 11/19/2017 04:28 PM, Martin Sebor wrote: On 11/18/2017 12:53 AM, Jeff Law wrote: On 11/17/2017 12:36 PM, Martin Sebor wrote: The attached patch enhances -Wstringop-overflow to detect more instances of buffer overflow at compile time by handling non- c

Re: [patch, fortran] Implement maxloc and minloc for character

2017-11-21 Thread Thomas Koenig
Hi Janne, So, any other comments about my patch? OK for trunk? - In many cases the copyright notice has "This file is part of the GNU Fortran 95 runtime library (libgfortran)." It's a while since we've called ourselves "GNU Fortran 95", so just remove the "95". That's what I got for copying

Re: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-21 Thread Uros Bizjak
I have committed the attached patch. Uros. On Tue, Nov 21, 2017 at 6:18 PM, Shalnov, Sergey wrote: > Uros, > Yes, please. Thank you for your proposals and comments. > Please commit as you proposed. > Sergey > > -Original Message- > From: Uros Bizjak [mailto:ubiz...@gmail.com] > Sent: Tue

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-21 Thread Eric Botcazou
> This patch by Than McIntosh fixes a small bug in the libgo Makefile > recipe that constructs the directory from which to pick up > libgcc_s.so; the gccgo invocation with -print-libgcc-file-name was > missing the flags, which meant that for -m32 builds we'd see the > 64-bit libgcc dir. Bootstrapp

Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-21 Thread Martin Sebor
On 11/20/2017 02:57 PM, Jakub Jelinek wrote: On Mon, Nov 20, 2017 at 02:25:35PM -0700, Martin Sebor wrote: On 11/20/2017 02:14 PM, Jakub Jelinek wrote: Hi! All the hash_maps in tree-ssa-strlen.c except for the newly added one were pointers to hash maps, which were constructed either lazily or

Re: [patch, fortran] Implement maxloc and minloc for character

2017-11-21 Thread Janne Blomqvist
On Tue, Nov 21, 2017 at 9:50 PM, Thomas Koenig wrote: > Hi Janne, > > >>> So, any other comments about my patch? OK for trunk? >> >> >> - In many cases the copyright notice has "This file is part of the GNU >> Fortran 95 runtime library (libgfortran)." It's a while since we've >> called ourselves

[PATCH] PR libstdc++/48101 improve errors for invalid container specializations

2017-11-21 Thread Jonathan Wakely
This uses static_assert to improve the errors when attempting to instantiate invalid specializations of containers, e.g. set, or unordered_set, hash> (which mixes up the order of the hasher and equality predicate arguments). This means instead of more than 100 lines of confusing errors for https:

committed: remove unused function (PR 83099)

2017-11-21 Thread Martin Sebor
My last commit included an unused static function that caused a -Wunused-function warning/error. I removed the function in r255036 to unblock the bootstrap while retesting everything in the meanwhile. Martin

Re: Add optabs for common types of permutation

2017-11-21 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 20, 2017 at 1:35 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: On 11/09/2017 06:24 AM, Richard Sandiford wrote: > ...so that we can use them for variable-length vectors. For now >

[PATCH] Handle GOMP_NVPTX_PTXRW in libgomp nvptx plugin

2017-11-21 Thread Tom de Vries
On 11/07/2017 03:54 PM, Jakub Jelinek wrote: On Tue, Nov 07, 2017 at 06:48:25AM -0800, Cesar Philippidis wrote: Changes in the patch series: - removed OPENACC_ from environment variable names - made temp files use gomp-nvptx prefix. - fixed build error due to missing _GNU_SOURCE in libgomp-nvptx

  1   2   >