Re: [PATCH v3] Ability to remap file names in __FILE__, etc (PR other/70268)

2018-01-18 Thread Boris Kolpackov
Ximin Luo writes: > Higher-level build scripts sometimes like to save CFLAGS etc into the build > output, making the overall build output unreproducible even if GCC is playing > nicely. Rather than add logic to strip -f{file,debug,macro,...}-prefix-map, > into all possible

[PATCH, fortran] Support Fortran 2018 teams

2018-01-18 Thread Damian Rouson
  All, Attached please find what I hope is the final version of the patch that adds partial support for teams of images, the last remaining major Fortran 2018 feature without current support in gfortran (or any other Fortran compiler of which I’m aware).  I submitted the first draft of this

libgo patch committed: Use rlimit64 when we use getrlimit64

2018-01-18 Thread Ian Lance Taylor
This libgo patch changes the syscall package to use the rlimit64 type, if available, when we use getrlimit64. This makes no difference on most systems, because renames the type appropriately anyhow, but apparently it makes a difference on AIX. Bootstrapped and ran Go testsuite on

Re: Go patch committed: Update to Go1.10beta1

2018-01-18 Thread Ian Lance Taylor
On Thu, Jan 18, 2018 at 12:02 AM, Rainer Orth wrote: > >> On Thu, Jan 11, 2018 at 1:46 AM, Rainer Orth >> wrote: >>> On Wed, Jan 10, 2018 at 5:42 AM, Ian Lance Taylor wrote: > > Whoops, there's a bug on

Re: Go patch committed: Update to Go1.10beta1

2018-01-18 Thread Ian Lance Taylor
On Thu, Jan 11, 2018 at 8:56 AM, Rainer Orth wrote: > >>> This patch updates libgo to the Go1.10beta1 release. The final Go >>> 1.10 release is expected around February 1, so it's not clear how the >>> release timing is going to work with GCC 8. In any case this

libgo patch committed: Add go:noescape for AIX

2018-01-18 Thread Ian Lance Taylor
This patch by Tony Reix adds some go:noescape declarations for AIX. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE (revision

libgo patch commited: Recognize AIX objects and archives

2018-01-18 Thread Ian Lance Taylor
This patch by Tony Reix adds code to the go tool to recognize AIX objects and archives. Bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE (revision

Re: Go patch committed: Enable escape analysis for runtime

2018-01-18 Thread Ian Lance Taylor
On Thu, Jan 18, 2018 at 11:53 AM, Rainer Orth wrote: > >> This patch to the Go frontend by Cherry Zhang enables escape analysis >> for the runtime package in the Go frontend. The runtime package was >> hard-coded non-escape, and the escape analysis was not run for

Re: [PATCH,PTX] Add support for CUDA 9

2018-01-18 Thread Cesar Philippidis
On 12/19/2017 04:39 PM, Tom de Vries wrote: > On 12/20/2017 12:25 AM, Cesar Philippidis wrote: >> og7-ptx-cuda9.diff >> >> >> 2017-12-19  Cesar Philippidis  >> >> gcc/ >> * config/nvptx/nvptx.c (output_init_frag): Don't use generic address >> spaces for

Re: [PATCH] Fix pr83619.C (was Re: Fix ICE with profile info mismatch)

2018-01-18 Thread Jeff Law
On 01/18/2018 03:57 PM, Jakub Jelinek wrote: > On Thu, Jan 18, 2018 at 04:59:01PM +0100, Jan Hubicka wrote: >> this patch ICE where the profile in cgraph mismatch profile in BB. This is >> becuase >> of expansion of speculative devirtualization where we get some roundoff >> issues. >> >>

[C++ PATCH] Fix ICE in joust with -Wconversion (PR c++/81167)

2018-01-18 Thread Jakub Jelinek
Hi! As mentioned in the PR, we ICE on this testcase because w->fn is a conversion operator, w->convs[0]->type is a reference to a class type, but because that conversion is ck_ref_bind, source_type looks through it and finds ck_identity with the class type. Then we because w->fn is not a

[PATCH] -Warray-bounds: Fix false positive in some "switch" stmts (PR tree-optimization/83510)

2018-01-18 Thread David Malcolm
PR tree-optimization/83510 reports that r255649 (for PR tree-optimization/83312) introduced a false positive for -Warray-bounds for array accesses within certain switch statements: those for which value-ranges allow more than one case to be reachable, but for which one or more of the

[PATCH] Fix unwind info in x86 interrupt functions (PR debug/83728)

2018-01-18 Thread Jakub Jelinek
Hi! Last summer i386 INCOMING_FRAME_SP_OFFSET macro has been changed, so that it is one word for most of the functions (as previously always), but 2 words for functions with interrupt attribute. Unfortunately this breaks the unwind info, as can be seen on the gcc.dg/guality/pr68037-1.c testcase.

[C++ PATCH] Avoid spurious -Wignored-qualifiers warning on artificial C++17 P0138R2 cast (PR c++/83919)

2018-01-18 Thread Jakub Jelinek
Hi! These casts for P0138R2 isn't something the user typed in their code, so diagnosing -Wignored-qualifiers on these looks wrong. -Wuseless-cast has been handled similarly in the past already. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2018-01-18 Jakub Jelinek

[C++ PATCH] Fix ICE in potential_constant_expression_1 (PR c++/83918)

2018-01-18 Thread Jakub Jelinek
Hi! Before location wrappers were introduced, the potential_constant_expression_1 assumption that a VIEW_CONVERT_EXPR must have non-NULL type was right, if it is a type dependent reinterpret cast, it would be REINTERPRET_CAST_EXPR instead. Location wrappers around decls can have NULL type, if

[PATCH] Fix pr83619.C (was Re: Fix ICE with profile info mismatch)

2018-01-18 Thread Jakub Jelinek
On Thu, Jan 18, 2018 at 04:59:01PM +0100, Jan Hubicka wrote: > this patch ICE where the profile in cgraph mismatch profile in BB. This is > becuase > of expansion of speculative devirtualization where we get some roundoff > issues. > > Bootstrapped/regtested x86_64-linux, comitted. > Honza > >

[C++ Patch] PR 83921 ("[7/8 Regression] GCC rejects constexpr initialization of empty aggregate")

2018-01-18 Thread Paolo Carlini
Hi, I'm finishing testing on x86_64-linux the below - which anyway seems very unlikely to cause regressions because we aren't really stress testing the relevant checks in potential_constant_expression_1 much, if at all (surely stmtexpr19.C tests static). Anyway, the issue is the following.

Re: [PATCH, rs6000] Add 128-bit support for vec_xl(), vec_xl_be(), vec_xst(), vec_xst_be() builtins.

2018-01-18 Thread Segher Boessenkool
Hi Carl, On Thu, Jan 18, 2018 at 08:06:17AM -0800, Carl Love wrote: > The following patch adds missing 128-bit support for the builtins > vec_xl(), vec_xl_be(), vec_xst(), vec_xst_be(). It also includes a bug > fix required for the new 128-bit arguments for the vec_xst_be() and > vec_xl_be()

C++ PATCH to fix bogus error with constexpr and empty class (PR c++/81933)

2018-01-18 Thread Marek Polacek
The problem in this PR is that we get error: constexpr call flows off the end of the function for a valid testcase, but not in C++17 mode. That's because in C++17 we execute: 4321 if (cxx_dialect >= cxx17 && !BINFO_VIRTUAL_P (binfo)) 4322 { 4323 tree decl =

Re: C++ PATCH for c++/83714, ICE checking return from template

2018-01-18 Thread Jason Merrill
On Wed, Jan 17, 2018 at 4:31 PM, Jason Merrill wrote: > On Wed, Jan 17, 2018 at 3:46 PM, Paolo Carlini > wrote: >> Hi Jason, >> >> On 17/01/2018 00:04, Jason Merrill wrote: >>> >>> Like my recent patch for 83186, we were missing a >>>

Re: std::vector default default and move constructors

2018-01-18 Thread François Dumont
On 16/01/2018 01:20, Jonathan Wakely wrote: On 15/01/18 22:32 +0100, François Dumont wrote: On 15/01/2018 13:29, Jonathan Wakely wrote: In fact it introduces a serious regression because of this line: -  vector(vector&& __x) noexcept -  : _Base(std::move(__x)) { } + 

[C++ Patch, obvious] Fix comment typo

2018-01-18 Thread Paolo Carlini
Hi, I noticed the below, I'm committing the fix it as obvious. Cheers, Paolo. / 2018-01-18 Paolo Carlini * cp-tree.h: Fix comment typo (DECL_NON_TRIVIALLY_INITIALIZED_P vs DECL_NONTRIVIALLY_INITIALIZED_P). Index: cp-tree.h

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread Jakub Jelinek
On Thu, Jan 18, 2018 at 03:31:38PM -0500, John David Anglin wrote: > On 2018-01-18 2:44 PM, John David Anglin wrote: > > > I don't have hpux or hppa-linux fenv.h, so can't check pr52451.c. > > Will have to investigate.  I see they predate your patch. > This is a test issue.  The long double

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread John David Anglin
On 2018-01-18 2:44 PM, John David Anglin wrote: I don't have hpux or hppa-linux fenv.h, so can't check pr52451.c. Will have to investigate.  I see they predate your patch. This is a test issue.  The long double support on hpux is a software emulation and it's not supported the fenv.h

C++ PATCH for c++/82461, member list-initialization and -std=c++17

2018-01-18 Thread Jason Merrill
In C++17 mode, build_special_member_call builds up an initializer for the object and then uses it directly rather than pass it to the copy constructor. This pattern results in a TARGET_EXPR showing up in potential_constant_expression, which complains about a TARGET_EXPR indicating a temporary of

Re: Go patch committed: Enable escape analysis for runtime

2018-01-18 Thread Rainer Orth
Hi Ian, > This patch to the Go frontend by Cherry Zhang enables escape analysis > for the runtime package in the Go frontend. The runtime package was > hard-coded non-escape, and the escape analysis was not run for the > runtime package. This patch removes the hard-code, and lets the > escape

Re: [PATCH, libstdc++]: Fix configure check for linux/random.h

2018-01-18 Thread Jonathan Wakely
On 18/01/18 20:31 +0100, Uros Bizjak wrote: Hello! linux/random.h uses __u32 types, which are defined through inclusion of linux/types.h header. On some older systems (e.g. CentOS 5.11) linux/random.h doesn't include linux/types.h by itself, and configure declares found linux/random.h as

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread John David Anglin
On 2018-01-18 12:51 PM, Jakub Jelinek wrote: On Thu, Jan 18, 2018 at 08:10:50AM -0500, John David Anglin wrote: On 2018-01-17 3:07 PM, Jakub Jelinek wrote: PR83882 complains that PR81715 testcase fails on callee copies parameter targets. The following patch ought to fix that, but I have only

[PATCH, libstdc++]: Fix configure check for linux/random.h

2018-01-18 Thread Uros Bizjak
Hello! linux/random.h uses __u32 types, which are defined through inclusion of linux/types.h header. On some older systems (e.g. CentOS 5.11) linux/random.h doesn't include linux/types.h by itself, and configure declares found linux/random.h as unusable. Attached patch fixes detection by

Re: [PATCH] handle local aggregate initialization in strlen (PR 83821)

2018-01-18 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01131.html This was submitted in stage 3 but if fixing xfailed assertions in tests by enhancing optimizations is out of scope for the current stage let me know so I can schedule this change for GCC 9. On 01/12/2018 02:30 PM, Martin Sebor

Re: [PATCH], Fix PR target/pr83862: Fix PowerPC long double signbit with -mabi=ieeelongdouble

2018-01-18 Thread Michael Meissner
On Thu, Jan 18, 2018 at 12:39:05PM -0600, Segher Boessenkool wrote: > On Wed, Jan 17, 2018 at 06:40:12PM -0500, Michael Meissner wrote: > > On Wed, Jan 17, 2018 at 04:09:57PM -0600, Segher Boessenkool wrote: > > > On Tue, Jan 16, 2018 at 10:55:43PM -0500, Michael Meissner wrote: > > > > PR

Re: [PATCH], Fix PR target/pr83862: Fix PowerPC long double signbit with -mabi=ieeelongdouble

2018-01-18 Thread Segher Boessenkool
On Wed, Jan 17, 2018 at 06:40:12PM -0500, Michael Meissner wrote: > On Wed, Jan 17, 2018 at 04:09:57PM -0600, Segher Boessenkool wrote: > > On Tue, Jan 16, 2018 at 10:55:43PM -0500, Michael Meissner wrote: > > > PR target/83862 pointed out a problem I put into the 128-bit floating > > > point > >

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread Jakub Jelinek
On Thu, Jan 18, 2018 at 08:10:50AM -0500, John David Anglin wrote: > On 2018-01-17 3:07 PM, Jakub Jelinek wrote: > > PR83882 complains that PR81715 testcase fails on callee copies parameter > > targets. The following patch ought to fix that, but I have only > > bootstrapped/regtested it on

Re: [PATCH] PR82964: Fix 128-bit immediate ICEs

2018-01-18 Thread Wilco Dijkstra
Christophe Lyon wrote: > After this patch (r256800), I have noticed new failures on aarch64: >    gcc.target/aarch64/f16_mov_immediate_1.c scan-assembler-times > mov\tw[0-9]+, #?19520 3 (found 0 times) Thanks for spotting these, the scripts appear to have missed those (contrib/dg-cmp-results.sh

[Committed][AArch64] Fix fp16 test failures after PR82964 fix

2018-01-18 Thread Wilco Dijkstra
This fixes test failures in gcc.target/aarch64/f16_mov_immediate_*.c after fixing PR82964 (https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01636.html). The check for a scalar floating point constant didn't include 16-bit floating point modes, so use GET_MODE_CLASS instead. This fixes the

RE: New code merge optimization?

2018-01-18 Thread Sebastian Perta
Hi, Thank you very much! I tried with and without -fcode-hoisting the file I mentioned earlier gcc/testsuite/gcc.c-torture/execute/pr58574.c but it remains the same. But I can certainly extend on this. Sorry I didn't found out this myself! I'll do more research next time before I start asking

Re: [PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-18 Thread Martin Sebor
On 01/15/2018 03:09 AM, Florian Weimer wrote: * Martin Sebor: +the virtual table. Modifying the representation of such objects may violate ^vtable pointer? The vtable itself is not corrupted, I assume. Well, what happens is undefined, so who knows? ;) But of course in reality,

Fix call of edge insertions hooks when cloning

2018-01-18 Thread Jan Hubicka
Hi, this patch was attached to the PR for a while. I have regtested it and comitted. Honza Index: ChangeLog === --- ChangeLog (revision 256850) +++ ChangeLog (working copy) @@ -1,5 +1,12 @@ 2018-01-18 Jan Hubicka

[PATCH, i386]: Backport a small retpoline improvement to gcc-7 branch

2018-01-18 Thread Uros Bizjak
Hello! I'd like to backport a small improvement to retpoline functionality to gcc-7 branch. 2018-01-17 Uros Bizjak * config/i386/i386.c (indirect_thunk_name): Declare regno as unsigned int. Compare regno with INVALID_REGNUM. (output_indirect_thunk): Ditto.

Re: New code merge optimization?

2018-01-18 Thread Andrew Pinski
On Thu, Jan 18, 2018 at 8:03 AM, Sebastian Perta wrote: > Hi, > > Thank you! > As the description says this finds equivalent functions, I would like to find > identical sequences inside > functions but at least this will provide all the up to date tools to compare >

Re: [PATCH][arm] Convert gcc.target/arm/stl-cond.c into an RTL test

2018-01-18 Thread Christophe Lyon
On 18 January 2018 at 10:28, Kyrill Tkachov wrote: > Hi Christophe, > > > On 18/01/18 09:25, Christophe Lyon wrote: >> >> Hi Kyrill, >> >> >> On 17 January 2018 at 12:27, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> This is an

[PATCH, rs6000] Add 128-bit support for vec_xl(), vec_xl_be(), vec_xst(), vec_xst_be() builtins.

2018-01-18 Thread Carl Love
GCC maintainers: The following patch adds missing 128-bit support for the builtins vec_xl(), vec_xl_be(), vec_xst(), vec_xst_be(). It also includes a bug fix required for the new 128-bit arguments for the vec_xst_be() and vec_xl_be() builtins. New test cases are also included. This patch

RE: New code merge optimization?

2018-01-18 Thread Sebastian Perta
Hi, Thank you! As the description says this finds equivalent functions, I would like to find identical sequences inside functions but at least this will provide all the up to date tools to compare code sequences, thank you again! Best Regards, Sebastian > -Original Message- > From:

Fix ICE with profile info mismatch

2018-01-18 Thread Jan Hubicka
Hi, this patch ICE where the profile in cgraph mismatch profile in BB. This is becuase of expansion of speculative devirtualization where we get some roundoff issues. Bootstrapped/regtested x86_64-linux, comitted. Honza PR ipa/83619 * g++.dg/torture/pr83619.C: New testcase.

Re: [PATCH] Fix profile_quality sanity check.

2018-01-18 Thread Tom de Vries
On 01/18/2018 03:59 PM, Martin Liška wrote: Hi. Following patch adds a new enum value so that we don't see following warning: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01211.html Hi, with the patch, I still see the same warning. And not surprisingly, given that profile_precise is still

Re: [C++ Patch] PR 81013 ("[7/8 Regression] ICE with invalid union in class hierarchy")

2018-01-18 Thread Jason Merrill
OK. On Thu, Jan 18, 2018 at 8:43 AM, Paolo Carlini wrote: > Hi, > > this error recovery regression is caused by my work for c++/70202 back in > 2016. At the time I remember wondering whether in the easy cases of errors > right at beginning of xref_basetypes (not those

Re: New code merge optimization?

2018-01-18 Thread Martin Jambor
Hi, On Thu, Jan 18 2018, Sebastian Perta wrote: > Hello, > > I am interested in implementing a new pass in gcc to merge identical > sequences of code in GCC to be used mainly for RL78. > The commercial RL78 compilers have such algorithms implemented and they make > quite good use of it. >

New code merge optimization?

2018-01-18 Thread Sebastian Perta
Hello, I am interested in implementing a new pass in gcc to merge identical sequences of code in GCC to be used mainly for RL78. The commercial RL78 compilers have such algorithms implemented and they make quite good use of it. Opportunities arise from the limited capabilities of RL78, for other

[PATCH] Fix profile_quality sanity check.

2018-01-18 Thread Martin Liška
Hi. Following patch adds a new enum value so that we don't see following warning: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01211.html Apart from that I decided to not to number values of the enum as it uses default number. Is it welcome? Patch can bootstrap on ppc64le-redhat-linux and

[PATCH,AIX] Optimize parsing of include files.

2018-01-18 Thread REIX, Tony
Description: * This patch optimizes the time required for parsing the include files. Tests: * AIX: Build: SUCCESS - build made by means of gmake on AIX. ChangeLog: * xcoff.c: Optimize parsing of include files. Cordialement, Tony Reix Bull - ATOS IBM Coop Architect & Technical Leader

Re: [PATCH 1/3] [builtins] Generic support for __builtin_speculation_safe_load()

2018-01-18 Thread Richard Biener
On Thu, Jan 18, 2018 at 3:07 PM, Richard Earnshaw (lists) wrote: > On 18/01/18 12:44, Richard Biener wrote: >> On Wed, Jan 17, 2018 at 3:55 PM, Richard Earnshaw >> wrote: >>> >>> This patch adds generic support for the new builtin >>>

[PATCH][arm] Fix gcc.target/arm/pr70278.c

2018-01-18 Thread Kyrill Tkachov
Hi all, This test needs an armv4t Thumb1 target but doesn't add the right effective target checks. This patch adds them so the test is skipped appropriately on Thumb2 hard-float tarets. Committing to trunk. Thanks, Kyrill 2018-01-18 Kyrylo Tkachov *

Re: [ARM,testsuite] Make arm_arch_FUNC_ok more robust

2018-01-18 Thread Kyrill Tkachov
Hi Christophe, On 18/01/18 14:08, Christophe Lyon wrote: Hi, I'm resurrecting a patch I posted in 2012-09 :) That's the month I first started working on GCC :) effective_target_arm_arch_FUNC_ok currently contains only #if !defined (DEF) #error FOO

[ARM,testsuite] Make arm_arch_FUNC_ok more robust

2018-01-18 Thread Christophe Lyon
Hi, I'm resurrecting a patch I posted in 2012-09 :) effective_target_arm_arch_FUNC_ok currently contains only #if !defined (DEF) #error FOO #endif which is not sufficient for GCC to complain in case of an unsupported flags combination. For

Re: [PATCH 1/3] [builtins] Generic support for __builtin_speculation_safe_load()

2018-01-18 Thread Richard Earnshaw (lists)
On 18/01/18 12:44, Richard Biener wrote: > On Wed, Jan 17, 2018 at 3:55 PM, Richard Earnshaw > wrote: >> >> This patch adds generic support for the new builtin >> __builtin_speculation_safe_load. It provides the overloading of the >> different access sizes and a default

Re: [PATCH][arm] Fix gcc.target/arm/pr40887.c directives

2018-01-18 Thread Christophe Lyon
On 18 January 2018 at 10:25, Kyrill Tkachov wrote: > > On 18/01/18 09:15, Christophe Lyon wrote: >> >> Hi Kyrill, >> >> >> On 17 January 2018 at 12:20, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> This patch converts

Re: [PATCH v3] Ability to remap file names in __FILE__, etc (PR other/70268)

2018-01-18 Thread Ximin Luo
Hello, I see Boris' patch was accepted with some further changes. Any chance my additions for reproducible builds can be included as well? They are described below. It should still apply on top, minus the strchr -> strrchr change which was folded into Boris' accepted version. Ximin Ximin

[C++ Patch] PR 81013 ("[7/8 Regression] ICE with invalid union in class hierarchy")

2018-01-18 Thread Paolo Carlini
Hi, this error recovery regression is caused by my work for c++/70202 back in 2016. At the time I remember wondering whether in the easy cases of errors right at beginning of xref_basetypes (not those in the loop below handled via dropped_base) we really wanted to proceed or immediately bail

Re: [PATCH,NVPTX] Fix PR83920

2018-01-18 Thread Tom de Vries
On 01/18/2018 12:40 AM, Cesar Philippidis wrote: In PR83920, I encountered a nvptx bug where live predicate variables were clobbered before their value was broadcasted. Hi, I've managed to reproduce the problem based on the description in the PR. Apparently, there were problems in certain

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread John David Anglin
On 2018-01-17 3:07 PM, Jakub Jelinek wrote: PR83882 complains that PR81715 testcase fails on callee copies parameter targets. The following patch ought to fix that, but I have only bootstrapped/regtested it on x86_64-linux and i686-linux + on the testcase with hppa. John, do you think you

Re: [PATCH][arm] Fix gcc.target/arm/xor-and.c

2018-01-18 Thread Christophe Lyon
On 17 January 2018 at 12:11, Kyrill Tkachov wrote: > Hi all, > > This test is naughty because it doesn't use the proper effective target > checks > and add-options mechanisms for setting a Thumb1 target, which leads to > Thumb1 hard-float errors > when testing a

Re: [PATCH] Small retpoline clean-up.

2018-01-18 Thread Jan Hubicka
> Hello. > > The patch is small clean-up of retpoline stuff. I know that H.J. is planning > to introduce an option driving which retpoline loop filler is selected. > Hopefully the suggested patch clarifies current default selection of > the filler. > > Patch survives make check -k -j10

[PATCH] Small retpoline clean-up.

2018-01-18 Thread Martin Liška
Hello. The patch is small clean-up of retpoline stuff. I know that H.J. is planning to introduce an option driving which retpoline loop filler is selected. Hopefully the suggested patch clarifies current default selection of the filler. Patch survives make check -k -j10 RUNTESTFLAGS="i386.exp".

Re: [PATCH 1/3] [builtins] Generic support for __builtin_speculation_safe_load()

2018-01-18 Thread Richard Biener
On Thu, Jan 18, 2018 at 1:44 PM, Richard Biener wrote: > On Wed, Jan 17, 2018 at 3:55 PM, Richard Earnshaw > wrote: >> >> This patch adds generic support for the new builtin >> __builtin_speculation_safe_load. It provides the overloading of

Re: [PATCH 1/3] [builtins] Generic support for __builtin_speculation_safe_load()

2018-01-18 Thread Richard Biener
On Wed, Jan 17, 2018 at 3:55 PM, Richard Earnshaw wrote: > > This patch adds generic support for the new builtin > __builtin_speculation_safe_load. It provides the overloading of the > different access sizes and a default fall-back expansion for targets > that do not

[COMMITTED] Add myself to MAINTAINERS (write after approval)

2018-01-18 Thread Boris Kolpackov
ChangeLog: 2018-01-18 Boris Kolpackov * MAINTAINERS (write after approval): Add myself. --- MAINTAINERS (revision 256843) +++ MAINTAINERS (working copy) @@ -454,6 +454,7 @@ Michael Koch Nicolas Koenig

Re: [PR c++/83160] local ref to capture

2018-01-18 Thread Nathan Sidwell
On 01/17/2018 01:44 PM, Jason Merrill wrote: This makes sense to me. But I think we'd want also that flag set on the ck_identity inside the ck_base that direct_reference_binding creates, so setting it first rather than in an else. Ah yes, you spotted the bit I failed to mention. (I think we

Re: [PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-18 Thread Christophe Lyon
Hi David, On 15 January 2018 at 11:09, Richard Biener wrote: > On Mon, Jan 8, 2018 at 8:36 PM, David Malcolm wrote: >> On Sat, 2018-01-06 at 08:44 +0100, Richard Biener wrote: >>> On January 5, 2018 11:55:11 PM GMT+01:00, David Malcolm

Re: [PATCH] PR82964: Fix 128-bit immediate ICEs

2018-01-18 Thread Christophe Lyon
Hi Wilco, On 17 January 2018 at 17:22, Wilco Dijkstra wrote: > James Greenhalgh wrote: > >> - /* Do not allow wide int constants - this requires support in movti. */ >> + /* Only allow simple 128-bit immediates. */ >>if (CONST_WIDE_INT_P (x)) >> -return

Re: [PATCH][arm] Convert gcc.target/arm/stl-cond.c into an RTL test

2018-01-18 Thread Kyrill Tkachov
Hi Christophe, On 18/01/18 09:25, Christophe Lyon wrote: Hi Kyrill, On 17 January 2018 at 12:27, Kyrill Tkachov wrote: Hi all, This is an awkward testsuite failure. The original bug was that we were failing to put out the conditional code in the conditional

Re: [PATCH][arm] Convert gcc.target/arm/stl-cond.c into an RTL test

2018-01-18 Thread Christophe Lyon
Hi Kyrill, On 17 January 2018 at 12:27, Kyrill Tkachov wrote: > Hi all, > > This is an awkward testsuite failure. The original bug was that we were > failing to put out > the conditional code in the conditional form of the STL instruction (oops!). > So we wanted to

Re: [PATCH][arm] Fix gcc.target/arm/pr40887.c directives

2018-01-18 Thread Kyrill Tkachov
On 18/01/18 09:15, Christophe Lyon wrote: Hi Kyrill, On 17 January 2018 at 12:20, Kyrill Tkachov wrote: Hi all, This patch converts gcc.target/arm/pr40887.c to use the proper effective target check and dg-add-options for armv5te so that we avoid situations

[PATCH][arm] PR target/65578: Fix builtin-bswap16-1.c and builtin-bswap-1.c

2018-01-18 Thread Kyrill Tkachov
Hi all, The builtin-bswap-1.c and builtin-bswap16-1.c are pretty annoying at the moment. They force an explicit armv6 option that is a thumb1 target, so if you're testing a toolchain configured with something like --with-cpu=cortex-a15 --with-float=hard --with-mode=thumb you'll get those pesky

Re: [PATCH][arm] Fix gcc.target/arm/pr40887.c directives

2018-01-18 Thread Christophe Lyon
Hi Kyrill, On 17 January 2018 at 12:20, Kyrill Tkachov wrote: > Hi all, > > This patch converts gcc.target/arm/pr40887.c to use the proper effective > target check and dg-add-options for armv5te > so that we avoid situations where we end up trying to compile the

Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}

2018-01-18 Thread Tom de Vries
On 01/17/2018 06:51 PM, Jakub Jelinek wrote: On Wed, Jan 17, 2018 at 06:42:33PM +0100, Tom de Vries wrote: +static rtx +expand_builtin_goacc_parlevel_id_size (tree exp, rtx target, int ignore) +{ + tree fndecl = get_callee_fndecl (exp); + + const char *name; + switch (DECL_FUNCTION_CODE

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread Richard Biener
On Thu, 18 Jan 2018, Jakub Jelinek wrote: > On Thu, Jan 18, 2018 at 09:18:21AM +0100, Richard Biener wrote: > > On Thu, 18 Jan 2018, Jakub Jelinek wrote: > > > > > On Thu, Jan 18, 2018 at 09:10:03AM +0100, Richard Biener wrote: > > > > On Wed, 17 Jan 2018, Jakub Jelinek wrote: > > > > > > > > >

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread Jakub Jelinek
On Thu, Jan 18, 2018 at 09:18:21AM +0100, Richard Biener wrote: > On Thu, 18 Jan 2018, Jakub Jelinek wrote: > > > On Thu, Jan 18, 2018 at 09:10:03AM +0100, Richard Biener wrote: > > > On Wed, 17 Jan 2018, Jakub Jelinek wrote: > > > > > > > Hi! > > > > > > > > PR83882 complains that PR81715

Re: [PATCH] i386: Use const reference of struct ix86_frame to avoid copy

2018-01-18 Thread Uros Bizjak
On Wed, Jan 17, 2018 at 5:00 PM, H.J. Lu wrote: > We can use const reference of struct ix86_frame to avoid making a local > copy of ix86_frame. ix86_expand_epilogue makes a local copy of struct > ix86_frame and uses the reg_save_offset field as a local variable. This >

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread Richard Biener
On Thu, 18 Jan 2018, Jakub Jelinek wrote: > On Thu, Jan 18, 2018 at 09:10:03AM +0100, Richard Biener wrote: > > On Wed, 17 Jan 2018, Jakub Jelinek wrote: > > > > > Hi! > > > > > > PR83882 complains that PR81715 testcase fails on callee copies parameter > > > targets. The following patch ought

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread Jakub Jelinek
On Thu, Jan 18, 2018 at 09:10:03AM +0100, Richard Biener wrote: > On Wed, 17 Jan 2018, Jakub Jelinek wrote: > > > Hi! > > > > PR83882 complains that PR81715 testcase fails on callee copies parameter > > targets. The following patch ought to fix that, but I have only > > bootstrapped/regtested

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-18 Thread Woodhouse, David
On Thu, 2018-01-18 at 08:52 +0100, Uros Bizjak wrote: > This puts an extra burden on the developer, which has to use correct > thunk name in their code. Sure, this can be solved trivially with > #ifdef __x86_64__, so the issue is minor, but I thought it has to be > mentioned before the name is set

Re: [PATCH] Avoid creating overflows in match.pd (P + A) - (P + B) POINTER_DIFF_EXPR optimization (PR c/61240)

2018-01-18 Thread Richard Biener
On Wed, 17 Jan 2018, Jakub Jelinek wrote: > Hi! > > POINTER_DIFF_EXPR returns a signed integer, but sadly POINTER_PLUS_EXPR > second arguments are unsigned integers, so if we are adding negative numbers > to pointers, those are very large numbers and we get TREE_OVERFLOW which the > C FE then

Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)

2018-01-18 Thread Richard Biener
On Wed, 17 Jan 2018, Jakub Jelinek wrote: > Hi! > > PR83882 complains that PR81715 testcase fails on callee copies parameter > targets. The following patch ought to fix that, but I have only > bootstrapped/regtested it on x86_64-linux and i686-linux + on the testcase > with hppa. Looks

Re: Go patch committed: Update to Go1.10beta1

2018-01-18 Thread Rainer Orth
Hi Ian, > On Thu, Jan 11, 2018 at 1:46 AM, Rainer Orth > wrote: >> >>> On Wed, Jan 10, 2018 at 5:42 AM, Ian Lance Taylor wrote: Whoops, there's a bug on big-endian 32-bit systems. I'm testing https://golang.org/cl/87135. >>> >>>