Backports to 8.x branch

2018-05-30 Thread Jakub Jelinek
Hi! I've backported a couple of patches to 8.x, after bootstrapping/regtesting them there: Jakub 2018-05-30 Jakub Jelinek Backported from mainline 2018-05-08 Jakub Jelinek PR target/85683 * config/i386/i386.md: Add peepholes for mem {+,-,&,|,^}= x;

[PATCH] Replace dead store with early return

2018-05-30 Thread Jonathan Wakely
Coverity noticed a dead store to 'value', and Jason approved this change off-list. * typeck.c (cxx_sizeof_or_alignof_type): Return size_one_node instead of using it in dead store. Tested powerpc64le-linux, committed to trunk. commit 14edce5a9e82c8747a5511339ab563f92269efc8 Auth

[Ada] Secondary stack implementation clean up

2018-05-30 Thread Pierre-Marie de Rodat
This patch reimplements the secondary stack runtime support as follows: * The compiler interface remains unchanged. This applies to both types and subprograms used by the compiler to create and manage secondary stacks. * The secondary stack is no longer a doubly linked list of chunks.

[Ada] Secondary stack leak in "for X of ..." loops

2018-05-30 Thread Pierre-Marie de Rodat
This patch fixes a memory leak bug. In particular, in a loop of the form "for X of ...", with a type that has the Iterable aspect specified, if the result of the Element function is returned on the secondary stack (e.g. the result subtype has caller-unknown size), then memory for the secondary stac

[Ada] Spurious error on legal synchronized constituent

2018-05-30 Thread Pierre-Marie de Rodat
This patch corrects the predicate which determines whether an entity denotes a synchronized object as per SPARK RM 9.1. to account for a case where the object is not atomic, but its type is. The patch also cleans up various atomic object-related predicates. Tested on x86_64-pc-linux-gnu, committe

[Ada] Simplify conditions by removing always true conjuncts

2018-05-30 Thread Pierre-Marie de Rodat
Checking "Original_Node (N) /= N" is equivalent to "Is_Rewrite_Substitution (N)", which is checked just two lines before. Trivial simplification, semantics unaffected. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-05-30 Piotr Trojanek gcc/ada/ * sem_prag.adb (Analyze_Pragma)

[Ada] Reuse Is_Rewrite_Substitution where possible

2018-05-30 Thread Pierre-Marie de Rodat
Use a high-level Is_Rewrite_Substitution instead of a low-level inequality, with the intention to improve the code easier to read. Semantics unaffected, so no test provided. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-05-30 Piotr Trojanek gcc/ada/ * errout.adb, exp_aggr.ad

[Ada] Correctly ignore Assertion_Policy in modes CodePeer and GNATprove

2018-05-30 Thread Pierre-Marie de Rodat
In the modes for static analysis with CodePeer or formal verification with GNATprove, the value of Assertion_Policy for a given policy is ignored if it's not Disable, as CodePeer/GNATprove are meant to check assertions even when not enabled at run time. This was not done consistently, which could l

[Ada] Add support for Define_Switch with a callback in GNAT.Command_Line

2018-05-30 Thread Pierre-Marie de Rodat
Add support for Define_Switch with a callback in GNAT.Command_Line. The callback is called for every instance of the switch found on the command line. This make it possible to have full control over the switch value and chain multiple actions if needed. Tested on x86_64-pc-linux-gnu, committed on

[Ada] Extend the applicability of Thread_Local_Storage to composite types

2018-05-30 Thread Pierre-Marie de Rodat
This patch allows the GNAT-specific Thread_Local_Storage to be applied to variables of a composite type initiallized with an aggregate with static components that requires no elaboration code. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-05-30 Ed Schonberg gcc/ada/ * freeze

[Ada] ACATS 4.1G - CXAG003 - Name_Case_Equivalence doesn't exist

2018-05-30 Thread Pierre-Marie de Rodat
Implement a missing portion of Ada 2005's AI05-0049-1 for subprogram Ada.Directories.Name_Case_Equivalence so that user programs can account for operating system differences in case sensitivity. -- Source -- -- main.adb with Ada.Directories; use Ada.Directories; with A

[Ada] Implement pragma Max_Entry_Queue_Depth

2018-05-30 Thread Pierre-Marie de Rodat
This patch implements AI12-0164-1 for the aspect/pragma Max_Entry_Queue_Depth. Previously, the GNAT specific pragma Max_Queue_Length fulfilled this role, but was not named to match the standard and thus was insufficent. -- Source -- -- pass.ads with System; package Pas

Re: [C++ PATCH] Do not warn about zero-as-null when NULL is used.

2018-05-30 Thread Ville Voutilainen
On 29 May 2018 at 23:43, Ville Voutilainen wrote: > Another round. The other occurrence of > maybe_warn_zero_as_null_pointer_constant > in typeck.c seems superfluous. The one in cvt.c seems necessary for > cpp0x/Wzero-as-null* tests. It seems like cp_build_binary_op is far more > suited > to che

Re: [PATCH] PR fortan/85779 -- Fix NULL pointer dereference

2018-05-30 Thread Thomas König
Hi Steve, > Am 24.05.2018 um 02:24 schrieb Steve Kargl > : > > Subject says it all. OK to commit? OK. Thanks for the patch! Thomas > > 2018-05-23 Steven G. Kargl > >PR fortran/85779 >*decl.c (gfc_match_derived_decl): Fix NULL point dereference. > > 2018-05-23 Steven G. Kargl

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-30 Thread Richard Biener
On Tue, May 29, 2018 at 4:58 PM Martin Sebor wrote: > On 05/28/2018 03:11 AM, Richard Biener wrote: > > On Fri, May 25, 2018 at 10:15 PM Martin Sebor wrote: > > > >> Attached is revision 3 of the patch incorporating your > >> determine_value_range function with the requested changes. > > > > I'm

Re: [PATCH][AArch64] Fix aarch64_ira_change_pseudo_allocno_class

2018-05-30 Thread Wilco Dijkstra
Richard Sandiford > The "?" change seems to make intrinsic sense given the extra cost of the > GPR alternative.  But I think the real reason for this failure is that > we define no V1DF patterns, and target-independent code falls back to > using moves in the corresponding *integer* mode.  So for

[PATCH] PR85964

2018-05-30 Thread Richard Biener
This makes tracer not explode with -fno-guess-branch-probabilities. I've settled with find_best_successor/predecessor not returning anything if _any_ edge in the interesting direction doesn't have ->count () initialized (rather than ignoring such edges). Honza - I suppose it is on purpose that f

[RFC] Add gcc.dg-selftests/dg-final.exp

2018-05-30 Thread Tom de Vries
Hi, this patch tests the error behaviour of dg-final directives when called with an incorrect number of arguments. The test is lazy, in that it doesn't bother to pass correct arguments, assuming that the number of arguments check is done before checking the actual arguments. Using the patch, I m

RFC: Linux/i386: Set TARGET_THREAD_SPLIT_STACK_OFFSET to 0x34

2018-05-30 Thread H.J. Lu
TARGET_THREAD_SPLIT_STACK_OFFSET has been wrong for Linux/i386 from the start. Should we change glibc for GCC's mistake or fix GCC? H.J. --- In glibc, sysdeps/i386/nptl/tls.h has typedef struct { void *tcb;/* Pointer to the TCB. Not necessarily the thre

Tighten LRA test for reloading the inner reg of a paradoxical subreg

2018-05-30 Thread Richard Sandiford
Kyrill Tkachov writes: > Hi Richard, > > On 29/05/18 15:26, Richard Sandiford wrote: >> Kyrill Tkachov writes: >>> Hi all, >>> >>> The recent changes to aarch64_expand_vector_init cause an ICE in the >>> attached testcase. The register allocator "ICEs with Max. number of >>> generated reload i

PING^1: [PATCH GCC 8] x86: Re-enable partial_reg_dependency and movx for Haswell

2018-05-30 Thread H.J. Lu
On Sun, May 20, 2018 at 11:51 AM, Jan Hubicka wrote: >> r254152 disabled partial_reg_dependency and movx for Haswell and newer >> Intel processors. r258972 restored them for skylake-avx512. For Haswell, >> movx improves performance. But partial_reg_stall may be better than >> partial_reg_depend

[PATCH][x86] Remove duplicated headers includes

2018-05-30 Thread Peryt, Sebastian
Hi, I have made some cleaning to remove redundancy in includes call of some of the headers in x86intrin.h. Removed headers were included in both x86intrin.h and immintrin.h which is included into x86intrin.h. Is it ok for trunk? 2018-05-30 Sebastian Peryt gcc/ * config/i386/cldemo

Re: C++ PATCH for c++/85889, reject capturing a structured binding

2018-05-30 Thread Marek Polacek
On Wed, May 30, 2018 at 01:33:17AM +0300, Ville Voutilainen wrote: > On 30 May 2018 at 01:23, Jason Merrill wrote: > > On Tue, May 29, 2018 at 4:44 PM, Marek Polacek wrote: > >> [expr.prim.lambda.capture] p8 says "If a lambda-expression explicitly > >> captures > >> an entity that is not odr-usa

[PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Segher Boessenkool
This patch changes the (C++) mangling of the 128-bit float types: __ieee128 becomes u9__ieee128 __ibm128 becomes u8__ieee128 __float128 is not a type anymore IEEE long double becomes u9__ieee128 IBM long double stays g This is a necessary ABI break. It wil

Re: [PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Segher Boessenkool
On Wed, May 30, 2018 at 12:58:49PM +, Segher Boessenkool wrote: > This patch changes the (C++) mangling of the 128-bit float types: > > __ieee128 becomes u9__ieee128 > __ibm128 becomes u8__ieee128 __ibm128 becomes u8__ibm128 of course. > __float128 is not a type any

Re: [PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Jakub Jelinek
On Wed, May 30, 2018 at 12:58:49PM +, Segher Boessenkool wrote: > This patch changes the (C++) mangling of the 128-bit float types: > > __ieee128 becomes u9__ieee128 > __ibm128 becomes u8__ieee128 ^^ what is the advantage/reason for the above, rather than mangling it as g? >

Re: [PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Segher Boessenkool
On Wed, May 30, 2018 at 03:15:21PM +0200, Jakub Jelinek wrote: > On Wed, May 30, 2018 at 12:58:49PM +, Segher Boessenkool wrote: > > This patch changes the (C++) mangling of the 128-bit float types: > > > > __ieee128 becomes u9__ieee128 > > __ibm128 becomes u8__ieee128 > > ^^ what

Re: [PATCH] PR85964

2018-05-30 Thread Jan Hubicka
> > This makes tracer not explode with -fno-guess-branch-probabilities. > I've settled with find_best_successor/predecessor not returning > anything if _any_ edge in the interesting direction doesn't have > ->count () initialized (rather than ignoring such edges). > > Honza - I suppose it is on p

[RFC] Add contrib/generate-from-maintainers.sh

2018-05-30 Thread Tom de Vries
Hi, I've recently setup mutt with a gmail account to sent patches to gcc-patches, and realized it would be convenient to add the email addresses in the MAINTAINERS file to the mutt address book. I've written this script, that in normal mode generates the info in csv format: ... Aaron Sawdey, a

[PATCH] libitm/x86: Correct offsets of __private_tm and pointer_guard

2018-05-30 Thread H.J. Lu
In glibc, sysdeps/i386/nptl/tls.h has typedef struct { void *tcb;/* Pointer to the TCB. Not necessarily the thread descriptor used by libpthread. */ dtv_t *dtv; void *self; /* Pointer to the thread descriptor. */ int multiple_threads; u

Re: [PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Jason Merrill
On Wed, May 30, 2018 at 9:45 AM, Segher Boessenkool wrote: > On Wed, May 30, 2018 at 03:15:21PM +0200, Jakub Jelinek wrote: >> On Wed, May 30, 2018 at 12:58:49PM +, Segher Boessenkool wrote: >> > This patch changes the (C++) mangling of the 128-bit float types: >> > >> > __ieee128 becomes

Re: [C++ PATCH] Do not warn about zero-as-null when NULL is used.

2018-05-30 Thread Jason Merrill
On Wed, May 30, 2018 at 5:24 AM, Ville Voutilainen wrote: > On 29 May 2018 at 23:43, Ville Voutilainen > wrote: >> Another round. The other occurrence of >> maybe_warn_zero_as_null_pointer_constant >> in typeck.c seems superfluous. The one in cvt.c seems necessary for >> cpp0x/Wzero-as-null* te

Re: [PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Segher Boessenkool
On Wed, May 30, 2018 at 11:03:39AM -0400, Jason Merrill wrote: > On Wed, May 30, 2018 at 9:45 AM, Segher Boessenkool > wrote: > > On Wed, May 30, 2018 at 03:15:21PM +0200, Jakub Jelinek wrote: > >> On Wed, May 30, 2018 at 12:58:49PM +, Segher Boessenkool wrote: > >> > This patch changes the (C

Re: [C++ PATCH] Do not warn about zero-as-null when NULL is used.

2018-05-30 Thread Ville Voutilainen
On 30 May 2018 at 18:12, Jason Merrill wrote: > Hmm, why doesn't maybe_warn_zero_as_null_pointer_constant check > null_node_p like it does NULLPTR_TYPE_P? Now it does. This passes all the Wzero-as-null-pointer-constant tests in warn/ and cpp0x/, running full suite on Linux-PPC64. Ok for trunk if

Re: Warning about -Wmain for local variables

2018-05-30 Thread Prathamesh Kulkarni
On 30 May 2018 at 18:12, Jonathan Wakely wrote: > On 30 May 2018 at 11:40, Prathamesh Kulkarni wrote: >> gcc with -Wmain warns for local variables named main. >> >> int foo() >> { >> int main = 0; >> return main; >> } >> >> a.c: In function ‘foo’: >> a.c:3:7: warning: ‘main’ is usually a funct

Re: [Aarch64] PR target/83009: Relax strict address checking for store pair lanes

2018-05-30 Thread Andre Vieira (lists)
On 30/05/18 16:11, Sudakshina Das wrote: > Hi Andre > > On 30/05/18 11:41, Sudakshina Das wrote: >> On 19/05/18 04:12, James Greenhalgh wrote: >>> On 8 May 2018, at 02:58, Andre Vieira (lists) wrote: Hi Richard, > On 07/05/18 11:14, Richard Sandiford wrote: > "Andre Vi

Re: Incremental LTO linking part 3: lto-wrapper support

2018-05-30 Thread Jan Hubicka
> > @@ -1108,9 +1109,12 @@ > > file_offset = (off_t) loffset; > > } > >fd = open (filename, O_RDONLY | O_BINARY); > > + /* Linker plugin passes -fresolution and -flinker-output options. */ > >if (fd == -1) > > { > > lto_argv[lto_argc++] = argv[i]; > > +

Re: [PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Jason Merrill
On Wed, May 30, 2018 at 11:32 AM, Segher Boessenkool wrote: > On Wed, May 30, 2018 at 11:03:39AM -0400, Jason Merrill wrote: >> On Wed, May 30, 2018 at 9:45 AM, Segher Boessenkool >> wrote: >> > On Wed, May 30, 2018 at 03:15:21PM +0200, Jakub Jelinek wrote: >> >> On Wed, May 30, 2018 at 12:58:49P

Re: [PATCH] rs6000: Fix mangling for 128-bit float

2018-05-30 Thread Jakub Jelinek
On Wed, May 30, 2018 at 08:45:22AM -0500, Segher Boessenkool wrote: > > If you need to keep g for compatibility (you do), then why not just have > > e (long double is double) > > g (long double when matching __ibm128, or explicit __ibm128) > > u9__ieee128 (long double when matching __ieee128, or ex

Re: Incremental LTO linking part 6: dwarf2out support

2018-05-30 Thread Jan Hubicka
> On 05/23/2018 09:54 AM, Jan Hubicka wrote: > >> On 05/08/2018 09:31 AM, Jan Hubicka wrote: > >>> Hi, > >>> this patch tells dwarf2out that it can have early debug not only in WPA > >>> mode > >>> but also when incrementally linking. This prevents ICE on almost every > >>> testcase > >>> compile

[PATCH] Fix PR85960, IPA PTA and IFUNCs

2018-05-30 Thread Richard Biener
The following fixes behavior of IPA PTA with IFUNCs. Those were treated as simple aliases (since ->alias is set) and thus we just considered the ifunc resolver as body. The following instead associates an IFUNC call with an indirect call to a var initialized from the resolver result. Bootstrap

Re: Incremental LTO linking part 5: symtab and compilation driver support

2018-05-30 Thread Jan Hubicka
> On Tue, 8 May 2018, Jan Hubicka wrote: > > > Hi, > > this patch adds the symtab support for LTO incremental linking. Most of the > > code path is same for both modes of incremental link except hat we want to > > produce LTO object file rather than compile down to assembly. > > > > Only non-obvi

Re: Incremental LTO linking part 7: documentation

2018-05-30 Thread Jan Hubicka
> Hi, > > just small nits: > > On Tue, May 08 2018, Jan Hubicka wrote: > > Hi, > > this patch adds documentation of -flinker-output. > > > > * doc/invoke.texi (-flinker-output): Document > > Index: doc/invoke.texi > > === > > ---

Re: [RFA] Incremental LTO linking part 1: simple-object bits

2018-05-30 Thread H.J. Lu
On Tue, May 8, 2018 at 8:05 AM, Jan Hubicka wrote: > Hi, > for incremental linking of LTO objects we need to copy debug sections from > source object files into destination without renaming them from .gnu.debuglto > into the standard debug section (because they will again be LTO debug section > in

Re: [RFA] Incremental LTO linking part 1: simple-object bits

2018-05-30 Thread Jan Hubicka
> On Tue, May 8, 2018 at 8:05 AM, Jan Hubicka wrote: > > Hi, > > for incremental linking of LTO objects we need to copy debug sections from > > source object files into destination without renaming them from > > .gnu.debuglto > > into the standard debug section (because they will again be LTO deb

Re: [PATCH 02/10] Add JSON implementation

2018-05-30 Thread Eric Gallager
On 5/29/18, David Malcolm wrote: > This patch is the JSON patch I posted last year; > it adds support to gcc for reading and writing JSON, > based on DOM-like trees of json::value instances. > > This is overkill for what's needed by the rest of the > patch kit (which just needs to be able to write

C++ PATCH for c++/85873 (constant array not in .rodata)

2018-05-30 Thread Jason Merrill
My recent patch for -Winit-list-lifetime added a warning for returning a temporary initializer_list, but the bug report is correct that we *could* promote the constant array to .rodata as an optimization, did in GCC 7, and don't in GCC 8. That we did in GCC 7 was for the wrong reason, because we w

Re: [PATCH 02/10] Add JSON implementation

2018-05-30 Thread David Malcolm
On Wed, 2018-05-30 at 13:25 -0400, Eric Gallager wrote: > On 5/29/18, David Malcolm wrote: > > This patch is the JSON patch I posted last year; > > it adds support to gcc for reading and writing JSON, > > based on DOM-like trees of json::value instances. > > > > This is overkill for what's needed

Re: [RFA] Incremental LTO linking part 1: simple-object bits

2018-05-30 Thread Rainer Orth
Hi Jan, >> > Index: include/simple-object.h >> > === >> > --- include/simple-object.h (revision 260042) >> > +++ include/simple-object.h (working copy) >> > @@ -198,12 +198,15 @@ >> > simple_object_release_write (simple_objec

Re: [PATCH] Remove MPX support

2018-05-30 Thread Jakub Jelinek
On Tue, May 01, 2018 at 11:28:13AM -0600, Jeff Law wrote: > On 04/27/2018 05:00 AM, Martin Liška wrote: > > I'm sending patch that removes MPX. It preserves all options > > -fcheck-pointer-bounds, -fchkp-* and -mmpx > > target option. These options are now NOP. On the contrary following options >

Re: [PATCH][AArch64] Fix aarch64_ira_change_pseudo_allocno_class

2018-05-30 Thread Richard Sandiford
Wilco Dijkstra writes: > Richard Sandiford >> The "?" change seems to make intrinsic sense given the extra cost of the >> GPR alternative.  But I think the real reason for this failure is that >> we define no V1DF patterns, and target-independent code falls back to >> using moves in the correspon

Re: [C++ PATCH] Do not warn about zero-as-null when NULL is used.

2018-05-30 Thread Ville Voutilainen
On 30 May 2018 at 18:32, Ville Voutilainen wrote: > Now it does. This passes all the Wzero-as-null-pointer-constant tests in warn/ > and cpp0x/, running full suite on Linux-PPC64. Ok for trunk if the tests > pass? Here we go again. :) 2018-05-30 Ville Voutilainen gcc/cp/ Do not warn

Re: [C++ PATCH] Do not warn about zero-as-null when NULL is used.

2018-05-30 Thread Jason Merrill
On Wed, May 30, 2018 at 3:00 PM, Ville Voutilainen wrote: > On 30 May 2018 at 18:32, Ville Voutilainen > wrote: >> Now it does. This passes all the Wzero-as-null-pointer-constant tests in >> warn/ >> and cpp0x/, running full suite on Linux-PPC64. Ok for trunk if the tests >> pass? > > Here we g

C++ PATCH for c++/85807, ICE with call in template NSDMI

2018-05-30 Thread Jason Merrill
The problem in this testcase was that we were calling get_nsdmi from template context, and then calling set_flags_from_callee on the resulting CALL_EXPR, which doesn't work in a template. Furthermore, we would then store the template-context trees for the NSDMI in the hash table, where they would

Re: [PATCH][x86] Remove duplicated headers includes

2018-05-30 Thread Uros Bizjak
On Wed, May 30, 2018 at 2:44 PM, Peryt, Sebastian wrote: > Hi, > > I have made some cleaning to remove redundancy in includes call of some of > the headers in x86intrin.h. > Removed headers were included in both x86intrin.h and immintrin.h which is > included into x86intrin.h. > > Is it ok for t

Re: [PATCH][x86] Remove duplicated headers includes

2018-05-30 Thread H.J. Lu
On Wed, May 30, 2018 at 12:51 PM, Uros Bizjak wrote: > On Wed, May 30, 2018 at 2:44 PM, Peryt, Sebastian > wrote: >> Hi, >> >> I have made some cleaning to remove redundancy in includes call of some of >> the headers in x86intrin.h. >> Removed headers were included in both x86intrin.h and immint

[PATCH] PR c++/77777 improve location for diagnostic

2018-05-30 Thread Jonathan Wakely
Pass in the location of the invalid expression, not the next input location (which might be a comma or closing parenthesis on a different line). gcc/cp: PR c++/7 * call.c (resolve_args): Use location of expression, not current input location. gcc/testsuite:

[PATCH] avoid ICE when pretty-printing a VLA with an error bound (PR 85956)

2018-05-30 Thread Martin Sebor
The syntactically valid but undefined test case submitted in bug 85956 shows that the pretty-printer ICEs when passed a pointer to variable-length array whose upper bound is an error-mark-node. The ICE is triggered by -Warray-bounds discovering that a negative subscript into the VLA is out-of-bou

Re: [PATCH 02/10] Add JSON implementation

2018-05-30 Thread Eric Gallager
On 5/30/18, David Malcolm wrote: > On Wed, 2018-05-30 at 13:25 -0400, Eric Gallager wrote: >> On 5/29/18, David Malcolm wrote: >> > This patch is the JSON patch I posted last year; >> > it adds support to gcc for reading and writing JSON, >> > based on DOM-like trees of json::value instances. >>

C++ PATCH for c++/85977, array reference size deduction failure

2018-05-30 Thread Marek Polacek
We are failing to deduce the template parameter N here template void foo(const long int (&)[N]) {} void bar() { foo ({1,2,3}); } because of the type mismatch; parm is long int (element type of the array), while arg is int (element type of {1, 2, 3}), and unify doesn't like that: 21

Re: [PATCH] PR c++/77777 improve location for diagnostic

2018-05-30 Thread Jason Merrill
OK. On Wed, May 30, 2018 at 4:28 PM, Jonathan Wakely wrote: > Pass in the location of the invalid expression, not the next input > location (which might be a comma or closing parenthesis on a different > line). > > gcc/cp: > > PR c++/7 > * call.c (resolve_args): Use location o

Re: [PATCH] consider MIN_EXPR in get_size_range() (PR 85888)

2018-05-30 Thread Jeff Law
On 05/30/2018 03:37 AM, Richard Biener wrote: > On Tue, May 29, 2018 at 4:58 PM Martin Sebor wrote: > >> On 05/28/2018 03:11 AM, Richard Biener wrote: >>> On Fri, May 25, 2018 at 10:15 PM Martin Sebor wrote: >>> Attached is revision 3 of the patch incorporating your determine_value_ran

Re: [PATCH] Document some arch-specific operand modifiers

2018-05-30 Thread Jeff Law
On 03/14/2018 10:35 AM, Borislav Petkov wrote: > Hi, > > here's an attempt to document some of the inline asm operand modifiers > which make sense and which get used so that people can find what they > mean in the docs. > > This is my first gcc patch so there might be clumsiness ahead. :) > > Th

Re: [PATCH] c/55976 -Werror=return-type should error on returning a value from a void function

2018-05-30 Thread Jeff Law
On 04/22/2018 01:17 PM, dave.pa...@oracle.com wrote: > This patch fixes handling of -Werror=return-type as well as > -Wno-return-type. Currently, -Werror=return-type does not turn the > warnings into errors and -Wno-return-type does not turn off > warning/error. Now they both work as expected. > >

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-05-30 Thread Jeff Law
On 05/03/2018 03:55 AM, Nick Clifton wrote: > Hi Jeff, > > Thanks for the review. > >> The docs still say "Control characters in the string will be replaced >> with spaces", but they're being escaped now. That needs to be fixed. > > Done. > >> I note you overload the cast operator in your ne

Re: [PATCH] correct/improve handling of -Walloc-size-larger-than (PR 82063)

2018-05-30 Thread Jeff Law
On 05/18/2018 05:58 PM, Martin Sebor wrote: > The -Walloc-size-larger-than= option is supposed make it possible > to disable the warning by specifying a limit that's larger than > the default of PTRDIFF_MAX (the handler for the option argument > gets around the INT_MAX maximum for numeric arguments

Re: [PATCH] crtstuff.c: remove leftover declaration of _Jv_RegisterClasses

2018-05-30 Thread Jeff Law
On 05/25/2018 05:10 PM, Rasmus Villemoes wrote: > 2018-05-26 Rasmus Villemoes > > libgcc/ > * crtstuff.c: Remove declaration of _Jv_RegisterClasses. Thanks. Installed on the trunk. Jeff

Re: [PATCH] [MSP430] Fix PR39240 execution failure for msp430-elf

2018-05-30 Thread Jeff Law
On 05/28/2018 05:23 AM, Jozef Lawrynowicz wrote: > pr39240.c fails at execution at -O1 and above for msp430, due to an erroneous > > subreg expression in the zero_extendqisi2 msp430 insn pattern. This causes the > > zero extension operation to get optimized out. > > The attached patch fixes the 

Re: [PATCH] Update comment about the format of attribute name in attribute_spec handler

2018-05-30 Thread Jeff Law
On 05/28/2018 06:25 AM, Jozef Lawrynowicz wrote: > With the changes in r250911 to canonicalize attribute names (i.e. remove > leading and trailing underscores if present) a comment for "handler" in > the attribute_spec struct needs to be updated to reflect that the NAME  > argument > > is now stri

Re: [PATCH] [MSP430] Fix -fleading-underscore having no effect

2018-05-30 Thread Jeff Law
On 05/28/2018 06:54 AM, Jozef Lawrynowicz wrote: > Fix -fleading-underscore having no effect for msp430-elf by prepending > user_label_prefix to name when outputting assembly labels. > > Successfully regtested the GCC testsuite for msp430-elf, and this fixed > unwind-1.c from dg.exp. > > If the p

Re: [RFC][PR82479] missing popcount builtin detection

2018-05-30 Thread Kugan Vivekanandarajah
Hi Bin, Thanks for the review. Please find the revised patch based on the review comments. Thanks, Kugan On 17 May 2018 at 19:56, Bin.Cheng wrote: > On Thu, May 17, 2018 at 2:39 AM, Kugan Vivekanandarajah > wrote: >> Hi Richard, >> >> On 6 March 2018 at 02:24, Richard Biener wrote: >>> On Thu

[PATCH] Avoid hot/cold partitioning in naked functions (PR target/85984)

2018-05-30 Thread Jakub Jelinek
Hi! We say in the documentation only supported body of naked functions is basic asm, anything else may but might not work. On the following testcase we end up with ICE, because the missing epilogue means the first partition is not separated from the second partition with a barrier and something b

Re: [PATCH] avoid ICE when pretty-printing a VLA with an error bound (PR 85956)

2018-05-30 Thread Jakub Jelinek
On Wed, May 30, 2018 at 02:39:15PM -0600, Martin Sebor wrote: > gcc/c-family/ChangeLog: > > PR middle-end/85956 > * c-pretty-print.c (c_pretty_printer::direct_abstract_declarator): > Handle error-mark-node in array bounds gracefully. This isn't sufficient, as it still ICEs with