The two patches attached have addressed two issues in the ANSI escape
sequence translator I sent before. Please review, and consider
backporting these to gcc-8-branch.
commit 5e79ccaa625169fcaca5847feff0ee168cbad83f (HEAD -> makepkg)
Author: Liu Hao
Date: Tue Aug 14 12:22:08 2018 +0800
[PATCH 2/6] detect unterminated const arrays in strlen calls (PR 86552)
The attached changes implement the detection of past-the-end reads
by strlen due to unterminated arguments.
PR tree-optimization/86552 - missing warning for reading past the end
gcc/ChangeLog:
* builtins.c
On Tue, 2018-08-14 at 11:02 +1200, Jason Merrill wrote:
>
>
> On Tue, Aug 14, 2018, 10:24 AM Marek Polacek
> wrote:
> > On Mon, Aug 13, 2018 at 10:14:21PM +1200, Jason Merrill wrote:
> > > >> >> > --- gcc/cp/decl.c
> > > >> >> > +++ gcc/cp/decl.c
> > > >> >> > @@ -9581,7 +9581,7 @@
Ping and I've updated the patch since last time as follows:
- unittest scans assembly rather than the constprop dump because its
forward changed
- unittests should handle different hosts where any of
NO_DOT_IN_LABEL, NO_DOLLAR_IN_LABEL or __USER_LABEL_PREFIX__ may
be defined
-
On Tue, Aug 14, 2018, 10:24 AM Marek Polacek wrote:
> On Mon, Aug 13, 2018 at 10:14:21PM +1200, Jason Merrill wrote:
> > >> >> > --- gcc/cp/decl.c
> > >> >> > +++ gcc/cp/decl.c
> > >> >> > @@ -9581,7 +9581,7 @@ compute_array_index_type (tree name, tree
> size, tsubst_flags_t complain)
> > >> >>
On Mon, Aug 13, 2018 at 10:14:21PM +1200, Jason Merrill wrote:
> >> >> > --- gcc/cp/decl.c
> >> >> > +++ gcc/cp/decl.c
> >> >> > @@ -9581,7 +9581,7 @@ compute_array_index_type (tree name, tree size,
> >> >> > tsubst_flags_t complain)
> >> >> > {
> >> >> >tree folded = cp_fully_fold
The attached changes implement the detection of past-the-end reads
by strncpy due to unterminated arguments and excessive bounds.
PR tree-optimization/86552 - missing warning for reading past the end of non-string arrays
gcc/ChangeLog:
* builtins.c (expand_builtin_strnlen): Detect, avoid
The attached changes implement the detection of past-the-end reads
by stpcpy due to unterminated arguments.
PR tree-optimization/86552 - missing warning for reading past the end of non-string arrays
gcc/ChangeLog:
* builtins.c (unterminated_array): Handle ARRAY_REF.
The attached changes implement the detection of past-the-end reads
by the sprintf family of functions due to unterminated arguments to
%s directives.
PR tree-optimization/86552 - missing warning for reading past the end of non-string arrays
gcc/ChangeLog:
* gimple-ssa-sprintf.c (struct
The attached changes implement the detection of past-the-end reads
by strcpy due to unterminated arguments.
PR tree-optimization/86552 - missing warning for reading past the end of non-string arrays
gcc/ChangeLog:
* builtins.c (unterminated_array): New.
(expand_builtin_strcpy): Adjust.
The attached changes implement the detection of nul-terminated
constant arrays and incorrect or early folding of such arrays.
This resolves PR 86711 - wrong folding of memchr, and prevents
PR 86714 - tree-ssa-forwprop.c confused by too long initializer.
No warnings are issued.
PR
To make reviewing the changes easier I've split up the patch
into a series:
1. Detection of nul-terminated constant arrays to prevent early
folding. This resolves PR 86711 - wrong folding of memchr,
and prevents PR 86714 - tree-ssa-forwprop.c confused by too
long initializer, but
Hi
For Darwin when we switch between text sections a linker-visible symbol is
required to preserve the linker’s “atom model”. Some time ago we implemented
TARGET_ASM_FUNCTION_SWITCHED_TEXT_SECTIONS to provide this.
A suitable symbol is now emitted directly from final.c so the target hook
On Mon, 13 Aug 2018 11:42:26 -0700
Cesar Philippidis wrote:
> On 08/13/2018 09:21 AM, Julian Brown wrote:
>
> > diff --git
> > a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
> > b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c new file
> > mode 100644 index
On Mon, Aug 13, 2018 at 5:36 PM, Fritz Reese wrote:
> On Fri, Aug 3, 2018 at 9:19 AM Janne Blomqvist
> wrote:
> >
> > The getentropy function, found on Linux, OpenBSD, and recently also
> > FreeBSD, can be used to get random bytes to initialize the PRNG. It
> > is similar to the traditional
On Mon, Aug 13, 2018 at 01:12:12PM +0300, Janne Blomqvist wrote:
> PING
LGTM.
> > diff --git a/libgfortran/intrinsics/random.c b/libgfortran/intrinsics/
> > random.c
> > index 234c5ff95fd..229fa6995c0 100644
> > --- a/libgfortran/intrinsics/random.c
> > +++ b/libgfortran/intrinsics/random.c
> >
Hi all,
this simple patch improves some of the diagnostics for invalid
ASSOCIATE statements:
https://github.com/janusw/gcc/commit/2f484479c741abddc8ac473cb0c1b9010397e006
In particular it gives a more precise locus and improved wording,
which is achieved basically by splitting a 'gfc_match'
After the combine 2-2 changes, this testcase does not have a ZERO_EXTEND
in the intermediate code, but an AND instead.
This adjusts the testcase. Committing.
2018-08-13 Segher Boessenkool
gcc/testcuite/
* gcc.target/powerpc/pr56605.c: The generated code can have an AND
On 08/13/2018 11:42 AM, Cesar Philippidis wrote:
> On 08/13/2018 09:21 AM, Julian Brown wrote:
>
>> diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
>> b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
>> new file mode 100644
>> index 000..2fa708a
>> ---
PR libstdc++/45093
* include/bits/stl_tree.h (_Rb_tree::_M_destroy_node(_Link_type)):
Combine definitions to avoid --detect-odr-violations warning.
Tested x86_64-linux, committed to trunk.
commit 99bf8add336b2307c09f122c8913ce9798a4cc6a
Author: Jonathan Wakely
Date:
Thanks to Lars for the suggestions.
* libsupc++/new_opa.cc (operator new(size_t, align_val_t)): Use
__is_pow2 to check for valid alignment. Avoid branching when rounding
size to multiple of alignment.
Tested x86_64-linux, committed to trunk.
commit
* include/Makefile.am: Install and for freestanding.
* include/Makefile.in: Regenerate.
* testsuite/17_intro/freestanding.cc: Check for and .
Tested x86_64-linux, committed to trunk.
commit 4c758384cab0b274b0d7626411483c5b366b308d
Author: Jonathan Wakely
Date: Mon
On 13/08/18 13:04 +0100, Jonathan Wakely wrote:
On 13/08/18 12:55 +0100, Szabolcs Nagy wrote:
On 09/08/18 10:08, Jonathan Wakely wrote:
On 09/08/18 06:56 +0200, Sebastian Huber wrote:
On 08/08/18 16:33, Jonathan Wakely wrote:
On 08/08/18 16:22 +0200, Ulrich Weigand wrote:
Jonathan Wakely
This PR complains about us accepting a lambda with a capture-default
at file scope, which seems to be forbidden. This patch disallows
such a use. clang gives an error, so I did the same, but maybe we
only want a pedwarn.
Bootstrapped/regtested on x86_64-linux, ok for trunk?
2018-08-13 Marek
On 08/13/2018 09:21 AM, Julian Brown wrote:
> diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
> b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
> new file mode 100644
> index 000..2fa708a
> --- /dev/null
> +++
Hi,
With the introduction of early debug, we've added a phase in the compiler which
produces information which is not visible, unless we run the compiler in the
debugger and call debug_dwarf from dwarf2out_early_finish or some such.
This patch adds dumping of "early" and "final" debug info, into
I repost updated patch containing ChangeLog entry.
Regards,
Kai
Jim Wilson
Kai Tietz
* config/aarch64.c (aarch64_sched_reorder): Implement
TARGET_SCHED_REORDER hook.
(aarch64_variable_issue): Implement TARGET_SCHED_VARIABLE_ISSUE
hook.
(TARGET_SCHED_REORDER): Define.
2018-08-13 18:23 GMT+02:00 Segher Boessenkool :
> I cannot okay patches for aarch64. But I did not notice other typoes,
> if that is what you're asking.
Yes. Thanks.
So, is patch ok with updated ChangeLog:
Jim Wilson
Kai Tietz
* config/aarch64.c
Hi Thomas,
Thanks for the review.
I’ll correct the typo before committing if I have no other changes required by
a maintainer.
Regards,
Tamar.
From: Thomas Preudhomme
Sent: Monday, August 13, 2018 14:37
To: Tamar Christina
Cc: gcc-patches@gcc.gnu.org; nd ; James Greenhalgh
; Richard
On Mon, Aug 13, 2018 at 06:13:58PM +0200, Kai Tietz wrote:
> 2018-08-13 17:51 GMT+02:00 Segher Boessenkool :
> > On Mon, Aug 13, 2018 at 10:16:20AM +0200, Kai Tietz wrote:
> >> * config/aarch64.c (aarch64_sched_reorder): Implementing
> >> TARGET_SHED_REORDER hook.
> >>
This patch adds support for placing gang-private variables in NVPTX
per-CU shared memory. This is done by marking up addressable variables
declared at the appropriate parallelism level with an attribute ("oacc
gangprivate") in omp-low.c.
Target-dependent code in the NVPTX backend then modifies
2018-08-13 17:51 GMT+02:00 Segher Boessenkool :
> Hi!
>
> On Mon, Aug 13, 2018 at 10:16:20AM +0200, Kai Tietz wrote:
>> * config/aarch64.c (aarch64_sched_reorder): Implementing
>> TARGET_SHED_REORDER hook.
>> (aarch64_variable_issue): Implemented TARGET_SHED_VARIABLE_ISSUE
On Mon, Aug 13, 2018 at 06:27:53PM +1200, Jason Merrill wrote:
> On Sun, Aug 12, 2018 at 3:53 PM, Marek Polacek wrote:
> > - var = add_capture (lambda,
> > -id,
> > -initializer,
> > -/*by_reference_p=*/
> >
Hi!
On Mon, Aug 13, 2018 at 10:16:20AM +0200, Kai Tietz wrote:
> * config/aarch64.c (aarch64_sched_reorder): Implementing
> TARGET_SHED_REORDER hook.
> (aarch64_variable_issue): Implemented TARGET_SHED_VARIABLE_ISSUE
> hook.
> (TARGET_SHED_REORDER):
On 08/13/2018 08:08 AM, Tom de Vries wrote:
> On 08/13/2018 04:54 PM, Cesar Philippidis wrote:
>> Going
>> forward, how would you like to proceed with the nvptx BE vector length
>> changes.
>
> Do you have a branch available on github containing the patch series
> you've submitted?
Yes,
On 08/13/2018 04:54 PM, Cesar Philippidis wrote:
> Going
> forward, how would you like to proceed with the nvptx BE vector length
> changes.
Do you have a branch available on github containing the patch series
you've submitted?
Thanks,
- Tom
On 08/13/2018 05:04 AM, Tom de Vries wrote:
> On 08/10/2018 08:39 PM, Cesar Philippidis wrote:
>> is that I modified the default value for vectors as follows
>>
>> +int vectors = default_dim_p[GOMP_DIM_VECTOR]
>> + ? 0 : dims[GOMP_DIM_VECTOR];
>>
>> Technically, trunk only
On Fri, Aug 3, 2018 at 9:19 AM Janne Blomqvist
wrote:
>
> The getentropy function, found on Linux, OpenBSD, and recently also
> FreeBSD, can be used to get random bytes to initialize the PRNG. It
> is similar to the traditional way of reading from /dev/urandom, but
> being a system call rather
2018-08-13 15:43 GMT+02:00 Bernhard Reutner-Fischer :
> On 13 August 2018 15:12:30 CEST, Bernhard Reutner-Fischer
> wrote:
>>On 13 August 2018 10:16:20 CEST, Kai Tietz
>>wrote:
>>>Hello,
>>>
>>>this patch implements variable issue rate feature for falkor cpu.
>>>Additionally this patch adjusts
As I said below, the patch for PR 86552, 86711, 86714 that
was first posted on July 19 fixes both of these issues and
also diagnoses calls with unterminated strings:
https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00155.html
On 08/12/2018 03:06 AM, Bernd Edlinger wrote:
Hi,
I'd like to ping
Vlad Lazar writes:
> diff --git a/gcc/expmed.h b/gcc/expmed.h
> index
> 2890d9c9bbd034f01030dd551d544bf73e73b784..86a32a643fdd0fc9f396bd2c7904244bd484df16
> 100644
> --- a/gcc/expmed.h
> +++ b/gcc/expmed.h
> @@ -702,6 +702,10 @@ extern rtx emit_store_flag (rtx, enum rtx_code, rtx,
> rtx,
On 13 August 2018 15:12:30 CEST, Bernhard Reutner-Fischer
wrote:
>On 13 August 2018 10:16:20 CEST, Kai Tietz
>wrote:
>>Hello,
>>
>>this patch implements variable issue rate feature for falkor cpu.
>>Additionally this patch adjusts the issue rate for falkor 8 as this
>>value reflects more cpu's
Hi Tamar,
Thanks for your patch.
Just one comment about your ChangeLog entry for the testsuiet change:
shouldn't it mention that it is a new testcase? The patch you attached
seems to create the file.
Best regards,
Thomas
On Mon, 13 Aug 2018 at 10:33, Tamar Christina
wrote:
> Hi All,
>
> On
AIX 4.3, 5.1, 5.2, and 5.3 no longer are supported by IBM. This patch
removes the GCC config.gcc stanzas and configuration files
corresponding to those AIX releases.
Thanks, David
* config.gcc [rs6000-ibm-aix4.x]: Delete.
[rs6000-ibm-aix5.1]: Delete.
[rs6000-ibm-aix5.2]: Delete.
On 13 August 2018 10:16:20 CEST, Kai Tietz wrote:
>Hello,
>
>this patch implements variable issue rate feature for falkor cpu.
>Additionally this patch adjusts the issue rate for falkor 8 as this
>value reflects more cpu's specification.
>
>This patch was tested against SPEC 2017 & 2016 and
On 08/13/2018 02:54 PM, Ramana Radhakrishnan wrote:
> On Mon, Aug 13, 2018 at 1:49 PM, Martin Liška wrote:
>> PING^1
>>
>> On 07/24/2018 02:05 PM, Martin Liška wrote:
>>> Hi.
>>>
>>> I'm sending updated version of the patch. It comes up with a new target
>>> common hook
>>> that provide option
Hi.
Following patch handles and issue seen in Linux kernel. It's about
__builtin_expects seen in a PHI node.
Another issue I saw is compilation with -frounding-math. In that case
we should use non-rounding math for folding of probability value in
__builtin_with_probability.
Patch can bootstrap
On Mon, Aug 13, 2018 at 1:49 PM, Martin Liška wrote:
> PING^1
>
> On 07/24/2018 02:05 PM, Martin Liška wrote:
>> Hi.
>>
>> I'm sending updated version of the patch. It comes up with a new target
>> common hook
>> that provide option completion list. It's used both in --help=target and
>> with
Hello Rasmus,
> On 28 Jun 2018, at 10:43, Rasmus Villemoes wrote:
>
> * config/vxworks.h: Guard vxworks_asm_out_constructor and
> vxworks_asm_out_destructor by !HAVE_INITFINI_ARRAY_SUPPORT
> * config/vxworks.c: Likewise.
ok as well, also modulo a ChangeLog formatting nit:
PING^1
On 07/24/2018 02:05 PM, Martin Liška wrote:
> Hi.
>
> I'm sending updated version of the patch. It comes up with a new target
> common hook
> that provide option completion list. It's used both in --help=target and with
> --completion
> option. I implemented support for -match and
Hi.
i386 target uses hint-based expansion of memcpy-like and memset-like functions.
I would like to add a test in order to cover the functionality.
Ready for trunk?
Martin
gcc/ChangeLog:
2018-08-13 Martin Liska
* config/i386/i386.c (ix86_expand_set_or_movmem): Dump
selected
On 13/08/18 12:55 +0100, Szabolcs Nagy wrote:
On 09/08/18 10:08, Jonathan Wakely wrote:
On 09/08/18 06:56 +0200, Sebastian Huber wrote:
On 08/08/18 16:33, Jonathan Wakely wrote:
On 08/08/18 16:22 +0200, Ulrich Weigand wrote:
Jonathan Wakely wrote:
Aha, so newlib was using memalign
On 08/10/2018 08:39 PM, Cesar Philippidis wrote:
> is that I modified the default value for vectors as follows
>
> + int vectors = default_dim_p[GOMP_DIM_VECTOR]
> + ? 0 : dims[GOMP_DIM_VECTOR];
>
> Technically, trunk only supports warp-sized vectors, but the fallback
> code is
On 09/08/18 10:08, Jonathan Wakely wrote:
On 09/08/18 06:56 +0200, Sebastian Huber wrote:
On 08/08/18 16:33, Jonathan Wakely wrote:
On 08/08/18 16:22 +0200, Ulrich Weigand wrote:
Jonathan Wakely wrote:
Aha, so newlib was using memalign previously:
@@ -53,20 +54,24 @@ aligned_alloc
Hi Rasmus,
> On 13 Aug 2018, at 10:24, Rasmus Villemoes wrote:
>
>> Ok, modulo ChangeLog reformatting:
>
> Thanks for spotting that. I have a script that fixes the whitespace
> issue automatically, but it doesn't catch missing leading * in entries.
>
> Do you want me to send an updated and
On 08/13/2018 10:09 AM, Ilya Leoshkevich wrote:
> 2018-07-27 Ilya Leoshkevich
>
> * config/s390/s390.c (s390_decompose_constant_pool_ref):
> New function.
> (s390_decompose_address): Factor out constant pool ref
> decomposition.
Applied. Thanks!
Andreas
On 08/09/2018 12:17 PM, Martin Sebor wrote:
Using build_string() rather than build_string_literal() needed
a tweak in digest_init_r(). It didn't break anything but since
the array type may not have a domain yet, neither will the
string. It looks like that may get adjusted later on but I've
On Sun, Aug 12, 2018 at 2:13 AM, Marek Polacek wrote:
> On Sat, Aug 11, 2018 at 11:32:24PM +1200, Jason Merrill wrote:
>> On Fri, Aug 10, 2018 at 8:59 AM, Marek Polacek wrote:
>> > On Mon, Aug 06, 2018 at 12:02:31AM +1000, Jason Merrill wrote:
>> >> > OK -- see the patch below. Now, I'm not
PING
On Fri, Aug 3, 2018 at 5:05 PM, Janne Blomqvist
wrote:
> On Fri, Aug 3, 2018 at 4:28 PM, Jakub Jelinek wrote:
>
>> On Fri, Aug 03, 2018 at 04:19:03PM +0300, Janne Blomqvist wrote:
>> > --- a/libgfortran/intrinsics/random.c
>> > +++ b/libgfortran/intrinsics/random.c
>> > @@ -309,12 +309,9
Hi All,
On AArch64 we have integer modes larger than TImode, and while we can generate
moves for these they're not as efficient.
So instead make sure we limit the maximum we can copy to TImode. This means
copying a 16 byte struct will issue 1 TImode copy, which will be done using a
single STP
Ping
> -Original Message-
> From: gcc-patches-ow...@gcc.gnu.org
> On Behalf Of Tamar Christina
> Sent: Tuesday, July 31, 2018 10:47
> To: gcc-patches@gcc.gnu.org
> Cc: nd ; Ramana Radhakrishnan
> ; Richard Earnshaw
> ; ni...@redhat.com; Kyrylo Tkachov
> ; Thomas Preudhomme
>
> Subject:
On 2018-08-10 17:59, Olivier Hainque wrote:
> Hello Rasmus,
>
>> On 28 Jun 2018, at 10:43, Rasmus Villemoes wrote:
>>
>> Assume that if the user passed --enable-initfini-array when building
>> gcc, the rest of the toolchain (including the link spec and linker
>> script) is set up appropriately.
Hello,
this patch implements variable issue rate feature for falkor cpu.
Additionally this patch adjusts the issue rate for falkor 8 as this
value reflects more cpu's specification.
This patch was tested against SPEC 2017 & 2016 and showed in general
some improvements without any regressions for
gcc/ChangeLog:
2018-07-27 Ilya Leoshkevich
* config/s390/s390.c (s390_decompose_constant_pool_ref):
New function.
(s390_decompose_address): Factor out constant pool ref
decomposition.
---
gcc/config/s390/s390.c | 155 ++---
On Aug 09 2018, Ian Lance Taylor wrote:
> On Thu, Aug 9, 2018 at 8:03 AM, Andreas Schwab wrote:
>> TestMemoryProfiler uses a too restrictive pattern that fails to match
>> backtraces that contain two tabs after the function address. That can
>> happen when the formatted addresses are of
OK.
On Sun, Aug 12, 2018 at 4:53 AM, Marek Polacek wrote:
> This fixes ICE-on-invalid with an array of auto. The problem was that
> create_array_type_for_decl got null name, so the error call crashed. We
> need to handle this case as elsewhere in the function.
>
> Bootstrapped/regtested on
On Sun, Aug 12, 2018 at 3:53 PM, Marek Polacek wrote:
> - var = add_capture (lambda,
> -id,
> -initializer,
> -/*by_reference_p=*/
> - (this_capture_p
> -
67 matches
Mail list logo
