Re: [PATCH] Make strlen range computations more conservative

2018-08-20 Thread Richard Biener
On Sun, 19 Aug 2018, Bernd Edlinger wrote: > Hi, > > > I rebased my range computation patch to current trunk, > and updated it according to what was discussed here. > > That means get_range_strlen has already a parameter > that is used to differentiate between ranges for warnings > and ranges f

Re: [PATCH] Make strlen range computations more conservative

2018-08-20 Thread Bernd Edlinger
On 08/20/18 12:12, Richard Biener wrote: > On Wed, Aug 15, 2018 at 6:39 AM Jeff Law wrote: >> >> On 08/10/2018 10:56 AM, Martin Sebor wrote: >>> On 08/08/2018 11:36 PM, Jeff Law wrote: On 08/02/2018 09:42 AM, Martin Sebor wrote: > The warning bits are definitely not okay by me. The

Re: [PATCH] Make strlen range computations more conservative

2018-08-20 Thread Richard Biener
On Wed, Aug 15, 2018 at 6:39 AM Jeff Law wrote: > > On 08/10/2018 10:56 AM, Martin Sebor wrote: > > On 08/08/2018 11:36 PM, Jeff Law wrote: > >> On 08/02/2018 09:42 AM, Martin Sebor wrote: > >> > >>> The warning bits are definitely not okay by me. The purpose > >>> of the warnings (-W{format,spri

Re: [PATCH] Make strlen range computations more conservative

2018-08-20 Thread Richard Biener
On Fri, Aug 3, 2018 at 9:19 AM Jeff Law wrote: > > On 07/25/2018 01:23 AM, Richard Biener wrote: > > On Tue, 24 Jul 2018, Bernd Edlinger wrote: > > > >> On 07/24/18 23:46, Jeff Law wrote: > >>> On 07/24/2018 01:59 AM, Bernd Edlinger wrote: > Hi! > > This patch makes strlen range com

Re: [PATCH, LTO wrappers] If we're not building a plugin don't try to invoke it.

2018-08-20 Thread Richard Biener
On Sat, Aug 18, 2018 at 11:02 PM Iain Sandoe wrote: > > > Hi, > > The LTO wrappers are built and installed whether a plug-in is built or not. > > If one then tries to do --version or --help on those tools, it fails because > the > plugin is missing. A simple solution is not to try and invoke --p

Re: [PATCH, driver specs] Put -flto-partition= on the collect2 c/l

2018-08-20 Thread Richard Biener
On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: > > Hi > > While working on the Darwin LTO issues I noticed that collect2 looks for > "-flto-partition=none” in its command line option, but it doesn’t get passed. > > So - is the attached patch the right idea, or should collect2 be looking in >

Re: [PATCH RFC] gimplefe: expose MULT_HIGHPART_EXPR

2018-08-20 Thread Richard Biener
On Fri, Aug 17, 2018 at 3:09 PM Alexander Monakov wrote: > > For testing generic expansion of MULT_HIGHPART_EXPR I chose to expose it > via the GIMPLE FE with the following patch. > > "h*" is how tree-pretty-print dumps MULT_HIGHPART_EXPR. > > This patch accepts "h*" which ideally shouldn't happen

Re: [PATCH RFC] add generic expansion for MULT_HIGHPART_EXP

2018-08-20 Thread Richard Biener
On Fri, Aug 17, 2018 at 2:54 PM Alexander Monakov wrote: > > Hello, > > We currently have an unfortunate situation where, on the one hand, scalar > MULT_HIGHPART_EXPR is usable only if the backend provides the corresponding > pattern (otherwise ICEs in expand), but on the other hand, the BRIG fron

Re: [PATCH][C++] Fix PR86763, wrong-code with TYPE_TYPELESS_STORAGE

2018-08-20 Thread Richard Biener
On Mon, 20 Aug 2018, Szabolcs Nagy wrote: > On 02/08/18 09:30, Richard Biener wrote: > > --- gcc/testsuite/g++.dg/torture/pr86763.C (nonexistent) > > +++ gcc/testsuite/g++.dg/torture/pr86763.C (working copy) > > @@ -0,0 +1,36 @@ > > +// { dg-do run } > > +// { dg-additional-options "-fschedule-i

Re: [PATCH][C++] Fix PR86763, wrong-code with TYPE_TYPELESS_STORAGE

2018-08-20 Thread Szabolcs Nagy
On 02/08/18 09:30, Richard Biener wrote: --- gcc/testsuite/g++.dg/torture/pr86763.C (nonexistent) +++ gcc/testsuite/g++.dg/torture/pr86763.C (working copy) @@ -0,0 +1,36 @@ +// { dg-do run } +// { dg-additional-options "-fschedule-insns2 -fstrict-aliasing" } + +#include +#include +#in

Re: [PATCH][Middle-end]patch for fixing PR 86519

2018-08-20 Thread Rainer Orth
Hi Jeff, > On 08/17/2018 09:43 PM, Paul Hua wrote: >> Hi Qing: >> >>> >>> the change has been committed as: >>> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=263563 >>> >>> >>> Qing >>> >> >> The strcmpopt_6.c test still fa

Re: [PATCH] Use more DECL_BUILT_IN_P macro.

2018-08-20 Thread Richard Biener
On Wed, Aug 15, 2018 at 2:52 PM Martin Liška wrote: > > On 08/14/2018 06:02 PM, Martin Sebor wrote: > > On 08/14/2018 03:06 AM, Martin Liška wrote: > >> Hi. > >> > >> The patch adds more usages of the new macro. I hope it improves > >> readability of code. > > > > I think it does :) I see that mo

Re: Fix test 86658 in Debug mode

2018-08-20 Thread Jonathan Wakely
On 18/08/18 22:09 +0200, François Dumont wrote: This test fails when using 'make check-debug' because it redefines _GLIBCXX_DEBUG. Using dg-options fixes this problem. Changing it to "#define _GLIBCXX_DEBUG 1" would also have fixed it, because that would be the same value as -D_GLIBCXX_DEBUG se

Re: [PATCH] Fix P81033 for FDEs in partitioned code.

2018-08-20 Thread Richard Biener
On Tue, Aug 14, 2018 at 10:18 PM Mike Stump wrote: > > On Aug 14, 2018, at 4:20 AM, Iain Sandoe wrote: > > When function sub-sections are enabled, Darwin’s assembler needs the FDE > > local start > > label for each sub-section to follow a linker-visible one so that the FDE > > will be correctly

<    1   2