Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-16 Thread Sandra Loosemore
On 10/12/2018 09:43 AM, David Malcolm wrote: Here's a proposed "User Experience Guidelines" section for our internals manual It's a mixture of proposed policy, together with notes on how to implement the recommendations. Thoughts? I think this documentation will be very helpful. I'll leave

Re: [doc PATCH] mention interaction with noinline in flatten

2018-10-16 Thread Sandra Loosemore
On 10/11/2018 02:58 PM, Martin Sebor wrote: While writing tests for attribute flatten I wasn't 100% sure from reading the manual if it would respect attribute noinline or if it would override it.  Turns out it's the former so the attached patch mentions it in the manual.  Unless there are

Re: [PATCH, doc] describe mode checking for doloop_end pattern

2018-10-16 Thread Sandra Loosemore
On 10/11/2018 09:20 AM, Paul Koning wrote: Since the code that uses the doloop_end pattern does not check the operand mode as given in the pattern, the pattern itself may need to do this, and that was not documented. This patch adds that information. It also updates the example to reflect

Re: [ARM/FDPIC v3 01/21] [ARM] FDPIC: Add -mfdpic option support

2018-10-16 Thread Sandra Loosemore
On 10/12/2018 03:52 AM, Richard Earnshaw (lists) wrote: On 11/10/18 14:34, Christophe Lyon wrote: 2018-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.opt: Add -mfdpic option. * doc/invoke.texi: Add documentation for -mfdpic. This is OK (once

Re: [PATCH 3/6] [ARC] Add BI/BIH instruction support.

2018-10-16 Thread Sandra Loosemore
On 10/10/2018 02:00 AM, Claudiu Zissulescu wrote: Use BI/BIH instruction to implement casesi pattern. Only ARC V2. Very minor nit in the documentation part of this patch: diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 802cc642453..454587310c8 100644 --- a/gcc/doc/invoke.texi

Re: [PATCH] add simple attribute introspection

2018-10-16 Thread Eric Gallager
On 10/13/18, Martin Sebor wrote: > Attached is an updated/enhanced patch with many more tests > and the suggested documentation tweak. It also restores > the handling of empty attributes that the first revision > inadvertently removed from the C parser. > > The tests are much more comprehensive

Re: [PATCH] add simple attribute introspection

2018-10-16 Thread Jeff Law
On 10/13/18 6:19 PM, Martin Sebor wrote: > Attached is an updated/enhanced patch with many more tests > and the suggested documentation tweak.  It also restores > the handling of empty attributes that the first revision > inadvertently removed from the C parser. > > The tests are much more 

New Spanish PO file for 'gcc' (version 8.2.0)

2018-10-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: https://translationproject.org/latest/gcc/es.po (This file, 'gcc-8.2.0.es.po', has

[PATCH] Fix regression in std::random_device default constructor

2018-10-16 Thread Jonathan Wakely
When the default constructor was split out into a separate function (in r261522) I accidentally made it call _M_init("mt19937") instead of _M_init_pretr1("mt19937"). That means it will always throw an exception, because "mt19937" isn't a valid token accepted by the _M_init function. Restore the

Re: [PATCH] Switch conversion: support any ax + b transformation (PR tree-optimization/84436).

2018-10-16 Thread Jeff Law
On 10/11/18 6:56 AM, Martin Liška wrote: > Hi. > > As seen in the PR, switch conversion can do better when we return equal > numbers > based on index value. I implemented more than that, more precisely I support > all linear > transformation based on index value. It's the same what clang is

Re: [PATCH] handle attribute positional arguments consistently (PR 87541, 87542)

2018-10-16 Thread Jeff Law
On 10/8/18 5:22 PM, Martin Sebor wrote: > Attached is an updated patch with the INTEGRAL_TYPE_P test added > to detect constant non-integer arguments like (void*)0, and with > quoting made unconditional.  I also removed the pretty printer > business to avoid the "value%s" format, and modified the 

Re: [PATCH 3/6] [ARC] Add BI/BIH instruction support.

2018-10-16 Thread Andrew Burgess
* Claudiu Zissulescu [2018-10-10 11:00:13 +0300]: > Use BI/BIH instruction to implement casesi pattern. Only ARC V2. This removes the compact-casesi as an option for earlier ARC, right? Was there a reason why that had to be done? > > gcc/ > 2018-03-21 Claudiu Zissulescu > > *

Re: [00/10][RFC] Splitting the C and C++ concept of "complete type"

2018-10-16 Thread Joseph Myers
On Tue, 16 Oct 2018, Richard Sandiford wrote: > > as Joseph pointed out, there are some related discussions > > on the WG14 reflector. How a about moving the discussion > > there? > > The idea was to get a feel for what would be acceptable to GCC > maintainers. When Arm presented an extension

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

2018-10-16 Thread Jeff Law
On 10/4/18 9:51 AM, Martin Sebor wrote: > On 10/04/2018 08:58 AM, Jeff Law wrote: >> On 8/27/18 9:42 AM, Richard Biener wrote: >>> On Mon, Aug 27, 2018 at 5:32 PM Jeff Law wrote: On 08/27/2018 02:29 AM, Richard Biener wrote: > On Sun, Aug 26, 2018 at 7:26 AM Jeff Law wrote: >>

Re: [C++ Patch, obvious] PR 84705 ("[6/7/8/9 Regression] internal compiler error: in add_stmt, at cp/semantics.c:390")

2018-10-16 Thread Paolo Carlini
Hi, On 16/10/18 22:49, Jason Merrill wrote: On Tue, Oct 16, 2018 at 2:39 PM Paolo Carlini wrote: the main issue is already fixed in trunk - we don't ICE anymore - but I noticed that for ill-formed code like: int i = static_cast(i); we emit a duplicate diagnostic about the incomplete

Re: [Patch, Fortran] PR67125 - ALLOCATE with source-expr lbounds/ubound off by one

2018-10-16 Thread Tobias Burnus
Hi Paul, thanks for the review; committed as Rev. 265212. Using your check in gfc_array_allocate won't work as already early in gfc_trans_allocate everything is converted to a descriptor – likewise, checking "expr3" wouldn't work either. I was pondering whether to check it elsewhere in

Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-16 Thread Jeff Law
On 10/12/18 9:43 AM, David Malcolm wrote: > Here's a proposed "User Experience Guidelines" section for our > internals manual > > It's a mixture of proposed policy, together with notes on how to > implement the recommendations. > > Thoughts? > > gcc/ChangeLog: > * Makefile.in

Re: [C++ Patch, obvious] PR 84705 ("[6/7/8/9 Regression] internal compiler error: in add_stmt, at cp/semantics.c:390")

2018-10-16 Thread Jason Merrill
On Tue, Oct 16, 2018 at 2:39 PM Paolo Carlini wrote: > the main issue is already fixed in trunk - we don't ICE anymore - but I > noticed that for ill-formed code like: > > int i = static_cast(i); > > we emit a duplicate diagnostic about the incomplete type d, easy to > avoid by returning

Re: [Patch, fortran] PR56386 - [F03] ICE with ASSOCIATE construct and an derived type array component

2018-10-16 Thread Tobias Burnus
Paul Richard Thomas wrote: This is a semi-obvious patch that fixes no fewer than five PRs: 56386, 58906, 77385, 80260 & 82077. The last two are marked as 7/8/9 regressions and so, although I haven't tested it yet, I suppose that the others must be too. Thanks to Dominique for picking up the

Re: [PATCH] Add sinh(tanh(x)) and cosh(tanh(x)) rules

2018-10-16 Thread Jeff Law
On 10/12/18 8:36 AM, Giuliano Augusto Faulin Belinassi wrote: > Hello. > I don't think there is a need for overflow handling here because > the argument is bound by the argument of the sqrt function :-) Yea, I guess you're right. The domain of arctanh is -1 to 1, so I guess we're safe there.

Re: [PATCH] v2: Run selftests for C++ as well as C

2018-10-16 Thread Jeff Law
On 10/13/18 7:12 AM, David Malcolm wrote: > On Fri, 2018-10-12 at 14:17 -0400, David Malcolm wrote: >> On Fri, 2018-10-12 at 14:45 -0400, David Malcolm wrote: >>> [re this thread "ToT build failure?": >>> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00344.html ] >>> >>> On Thu, 2017-07-06 at

Re: [RFC PATCH] libgcc: apply LIB2FUNCS_EXCLUDE logic to LIB2FUNCS_ST

2018-10-16 Thread Jeff Law
On 10/15/18 1:36 AM, Rasmus Villemoes wrote: > One target file (config/c6x/t-elf) lists _printf and _gcc_bcmp in > LIB2FUNCS_EXCLUDE, but that does not have any effect, since those are > not filtered away from LIB2FUNCS_ST. Another option is to do as in > config/rl78/t-rl78, which explicitly sets

C++: is there a good way to check for a valid no-op conversion?

2018-10-16 Thread David Malcolm
I've been extending -fopt-info to cover inlining, and I added a %S format code to dump_printf which accepts a symtab_node *. Unfortunately, -Wformat doesn't like the fact that I'm passing in a subclass pointer (cgraph_node *), e.g.: ipa-inline.c: In function ‘unsigned int

[v3 PATCH] PR libstdc++/87619

2018-10-16 Thread Ville Voutilainen
Simple, short, and sweet, just a thinko. 2018-10-16 Ville Voutilainen PR libstdc++/87619 * include/std/variant (__select_index): Fix an off-by-one. * testsuite/20_util/variant/87619.cc: New. diff --git a/libstdc++-v3/include/std/variant b/libstdc++-v3/include/std/variant index

[PATCH v5 08/10] testsuite: Mark that PRU has one-cycle jumps

2018-10-16 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * gcc.dg/tree-ssa/20040204-1.c: XFAIL on pru. * gcc.dg/tree-ssa/reassoc-33.c: Ditto. * gcc.dg/tree-ssa/reassoc-34.c: Ditto. * gcc.dg/tree-ssa/reassoc-35.c: Ditto. * gcc.dg/tree-ssa/reassoc-36.c:

[PATCH v5 09/10] testsuite: Mark that PRU uses all function pointer bits

2018-10-16 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * g++.old-deja/g++.abi/ptrmem.C: Add PRU to list. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/g++.old-deja/g++.abi/ptrmem.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 10/10] testsuite: Mark testsuite that PRU has different calling convention

2018-10-16 Thread Dimitar Dimitrov
For variadic functions, the last named and all anonymous arguments are passed on stack. Regular functions pass arguments in registers. gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * gcc.dg/builtin-apply2.c: Skip for PRU. * gcc.dg/torture/stackalign/builtin-apply-2.c:

[PATCH v5 06/10] testsuite: Remove PRU from test cases requiring hosted environment

2018-10-16 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * gcc.c-torture/execute/20101011-1.c: Define DO_TEST to 0 for PRU. * gcc.dg/20020312-2.c: No PIC register for PRU. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/gcc.c-torture/execute/20101011-1.c | 3 +++

[PATCH v5 07/10] testsuite: Define PRU stack usage

2018-10-16 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * gcc.dg/stack-usage-1.c: Define PRU stack usage. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/gcc.dg/stack-usage-1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/testsuite/gcc.dg/stack-usage-1.c

[PATCH v5 03/10] testsuite: Add PRU tests

2018-10-16 Thread Dimitar Dimitrov
gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * gcc.target/pru/abi-arg-struct.c: New test. * gcc.target/pru/ashiftrt.c: New test. * gcc.target/pru/builtins-1.c: New test. * gcc.target/pru/builtins-error.c: New test. * gcc.target/pru/clearbit.c:

[PATCH v5 05/10] testsuite: Add check for unsupported TI ABI PRU features to testsuite

2018-10-16 Thread Dimitar Dimitrov
Not all C language features are supported when -mabi=ti option is used for PRU target. gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * lib/gcc-dg.exp: Filter unsupported features in PRU's TI ABI mode. * lib/target-utils.exp: Ditto. * lib/target-supports.exp

[PATCH v5 02/10] Initial TI PRU libgcc port

2018-10-16 Thread Dimitar Dimitrov
The floating point support has been borrowed from C6X libgcc port to help with TI PRU toolchain ABI compatibility. libgcc/ChangeLog: 2018-10-08 Dimitar Dimitrov * config.host: Add PRU target. * config/pru/asri.c: New file. * config/pru/eqd.c: New file. *

[PATCH v5 04/10] testsuite: Add check for overflowed IMEM region to testsuite

2018-10-16 Thread Dimitar Dimitrov
PRU architecture supports maximum 256k program memory (IMEM). Some GCC test cases manage to produce executables bigger than that. gcc/testsuite/ChangeLog: 2018-10-08 Dimitar Dimitrov * lib/gcc-dg.exp: Bail on region overflow for tiny targets. * lib/target-utils.exp: Ditto.

[PATCH v5 00/10] New backend for the TI PRU processor

2018-10-16 Thread Dimitar Dimitrov
This is the latest patch set for adding TI PRU I/O processor backend to GCC. Comments from all previous series have been addressed [1], [2], [3], [4]. Test results can be downloaded from here: http://dinux.eu/gnupru/testresults/20181014-c45bebb5ee9 Changes since patch series v4 [4]: -

Re: [PATCH] Optimize sin(atan(x)) and cos(atan(x)), take 3 (PR tree-optimization/86829)

2018-10-16 Thread Christophe Lyon
On Tue, 16 Oct 2018 at 19:33, Giuliano Augusto Faulin Belinassi wrote: > > Hello, > > > cosatanf: > > .LFB3: > > .loc 1 44 1 is_stmt 1 > > .cfi_startproc > >@ args = 0, pretend = 0, frame = 0 > > @ frame_needed = 0, uses_anonymous_args = 0 > > .LVL50: > >

[Patch, fortran] PR56386 - [F03] ICE with ASSOCIATE construct and an derived type array component

2018-10-16 Thread Paul Richard Thomas
This is a semi-obvious patch that fixes no fewer than five PRs: 56386, 58906, 77385, 80260 & 82077. The last two are marked as 7/8/9 regressions and so, although I haven't tested it yet, I suppose that the others must be too. Thanks to Dominique for picking up the other four PRs that are fixed by

[C++ Patch, obvious] PR 84705 ("[6/7/8/9 Regression] internal compiler error: in add_stmt, at cp/semantics.c:390")

2018-10-16 Thread Paolo Carlini
Hi, the main issue is already fixed in trunk - we don't ICE anymore - but I noticed that for ill-formed code like:     int i = static_cast(i); we emit a duplicate diagnostic about the incomplete type d, easy to avoid by returning error_mark_node from

PING [PATCH] handle attribute positional arguments consistently (PR 87541, 87542)

2018-10-16 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00473.html On 10/08/2018 05:22 PM, Martin Sebor wrote: Attached is an updated patch with the INTEGRAL_TYPE_P test added to detect constant non-integer arguments like (void*)0, and with quoting made unconditional.  I also removed the pretty

Re: [PATCH] lra: fix spill_hard_reg_in_range clobber check

2018-10-16 Thread Jeff Law
On 10/16/18 10:10 AM, Ilya Leoshkevich wrote: >> Am 16.10.2018 um 16:20 schrieb Jeff Law : >> >> On 10/16/18 3:17 AM, Ilya Leoshkevich wrote: >>> Bootstrap and regtest are running on x86_64-redhat-linux. >>> >>> Insns in FROM..TO range might not be recognized yet, and their >>> corresponding

Re: [PATCH] Optimize sin(atan(x)) and cos(atan(x)), take 3 (PR tree-optimization/86829)

2018-10-16 Thread Giuliano Augusto Faulin Belinassi
Hello, > cosatanf: > .LFB3: > .loc 1 44 1 is_stmt 1 > .cfi_startproc >@ args = 0, pretend = 0, frame = 0 > @ frame_needed = 0, uses_anonymous_args = 0 > .LVL50: > .loc 1 45 5 > .loc 1 44 1 is_stmt 0 > push{r4, lr} >

Re: [PATCH][AArch64] Use @ pattern to eliminate switch statement in one more place

2018-10-16 Thread Richard Sandiford
Kyrylo Tkachov writes: > Hi all, > > We can use the new '@' modifier to MD patterns to generate > mode-parametrised gen_ functions > for the despeculate_copy patterns and therefore remove the switch on > modes in aarch64.c > that is used to pick the right generator. This simplifies the code. > >

Re: [PATCH 14/14] Add D Phobos config, makefiles, and testsuite.

2018-10-16 Thread Richard Sandiford
Iain Buclaw writes: > diff --git a/libphobos/d_rules.am b/libphobos/d_rules.am > new file mode 100644 > index 000..b16cf5052d2 > --- /dev/null > +++ b/libphobos/d_rules.am > @@ -0,0 +1,60 @@ > +# This file contains some common rules for D source compilation > +# used for libdruntime and

Re: [aarch64}: added variable issue rate feature for falkor

2018-10-16 Thread Kyrill Tkachov
Hi Kai, On 11/10/18 16:25, Kai Tietz wrote: Hi, I reworked patch use a tuning flag instead of checking explicit for CPU flavor. I will send soon an update for it, which won't use the static variable anymore, and uses instead the SCHED-api. I would like first to get some comments on current

Re: [PATCH] Provide extension hint for aarch64 target (PR driver/83193).

2018-10-16 Thread James Greenhalgh
On Mon, Oct 08, 2018 at 05:34:52AM -0500, Martin Liška wrote: > Hi. > > I'm attaching updated version of the patch. Can't say I'm thrilled by the allocation/free (aarch64_parse_extension allocates, everyone else has to free) responsibilities here. If you can clean that up I'd be much happier.

Re: [patch] allow target config to state r18 is fixed on aarch64

2018-10-16 Thread Kyrill Tkachov
Hi Olivier, On 12/10/18 19:43, Olivier Hainque wrote: Hi Kyrill, Thanks for your feedback! On 12 Oct 2018, at 05:50, Kyrill Tkachov wrote: CC'ing the aarch64 maintainers as they'll have to approve it. I'm guessing you've tested this in the usual way (bootstrap and test)? Sorry, I failed

Account Recovery!!!

2018-10-16 Thread Admin_Supportdesk
Account Recovery Message Dear gcc-patches@gcc.gnu.org Our record indicates that you recently made a request to deactivate this "gcc-patches@gcc.gnu.org" email And this request will be processed shortly. If this request was made accidentally and you

Re: [v3, testsuite] Introduce dg-add-options net_ts

2018-10-16 Thread Jonathan Wakely
On 16/10/18 13:38 +0200, Rainer Orth wrote: Some of the new Networking TS tests FAIL before Solaris 11.4 like this: FAIL: experimental/net/internet/address/v4/members.cc (test for excess errors) Excess errors: Undefined first referenced symbol

Re: [PATCH] Optimize sin(atan(x)) and cos(atan(x)), take 3 (PR tree-optimization/86829)

2018-10-16 Thread Christophe Lyon
On Tue, 16 Oct 2018 at 18:04, Giuliano Augusto Faulin Belinassi wrote: > > Hello, Christophe > Could you please dump the assembly of cosatanf here? > > Sure: .global cosatanf .syntax unified .arm .fpu softvfp .type cosatanf, %function cosatanf: .LFB3:

Re: [PATCH] Provide extension hint for aarch64 target (PR driver/83193).

2018-10-16 Thread Kyrill Tkachov
On 08/10/18 11:34, Martin Liška wrote: Hi. I'm attaching updated version of the patch. Martin This looks ok to me, but you'll need approval from a maintainer. Thanks for the iterations, Kyrill

Re: [PATCH] Initial commit of Networking TS implementation

2018-10-16 Thread Jonathan Wakely
On 16/10/18 17:12 +0100, Jonathan Wakely wrote: On 16/10/18 16:36 +0100, Jonathan Wakely wrote: On 16/10/18 16:24 +0100, Jonathan Wakely wrote: On 12/10/18 11:50 +0100, Jonathan Wakely wrote: This implementation is very incomplete (see the various TODO comments in the code) but rather than

Re: [PATCH] Initial commit of Networking TS implementation

2018-10-16 Thread Jonathan Wakely
On 16/10/18 17:12 +0100, Jonathan Wakely wrote: On 16/10/18 16:36 +0100, Jonathan Wakely wrote: On 16/10/18 16:24 +0100, Jonathan Wakely wrote: On 12/10/18 11:50 +0100, Jonathan Wakely wrote: This implementation is very incomplete (see the various TODO comments in the code) but rather than

Re: [PATCH] Initial commit of Networking TS implementation

2018-10-16 Thread Jonathan Wakely
On 16/10/18 16:36 +0100, Jonathan Wakely wrote: On 16/10/18 16:24 +0100, Jonathan Wakely wrote: On 12/10/18 11:50 +0100, Jonathan Wakely wrote: This implementation is very incomplete (see the various TODO comments in the code) but rather than keeping it out of tree any longer I'm committing it

Re: [PATCH] lra: fix spill_hard_reg_in_range clobber check

2018-10-16 Thread Ilya Leoshkevich
> Am 16.10.2018 um 16:20 schrieb Jeff Law : > > On 10/16/18 3:17 AM, Ilya Leoshkevich wrote: >> Bootstrap and regtest are running on x86_64-redhat-linux. >> >> Insns in FROM..TO range might not be recognized yet, and their >> corresponding entries in lra_insn_recog_data[] might be NULLs. In the

[gomp5] Add reduction support for taskloop/taskloop simd

2018-10-16 Thread Jakub Jelinek
Hi! The following patch adds support for reduction clause on taskloop, which must not appear if nogroup appears, and if it appears, acts as task_reduction on the implicit taskgroup around all the tasks created by the construct and in_reduction on all the created tasks. We can handle those more

Re: [PATCH] Optimize sin(atan(x)) and cos(atan(x)), take 3 (PR tree-optimization/86829)

2018-10-16 Thread Giuliano Augusto Faulin Belinassi
Hello, Christophe Could you please dump the assembly of cosatanf here? On Tue, Oct 16, 2018 at 12:23 PM Christophe Lyon wrote: > > On Tue, 16 Oct 2018 at 17:15, Giuliano Augusto Faulin Belinassi > wrote: > > > > Hello. Sorry for the late reply. > > > > > but then cosatanf is computed as

Re: [PATCH] Initial commit of Networking TS implementation

2018-10-16 Thread Jonathan Wakely
On 16/10/18 16:24 +0100, Jonathan Wakely wrote: On 12/10/18 11:50 +0100, Jonathan Wakely wrote: This implementation is very incomplete (see the various TODO comments in the code) but rather than keeping it out of tree any longer I'm committing it to trunk. This will allow others to experiment

Re: [PATCH 07/14] Add patches for D language support in GCC targets.

2018-10-16 Thread Richard Sandiford
Iain Buclaw writes: > diff --git a/gcc/Makefile.in b/gcc/Makefile.in > index 4b7cec82382..0b2daa320c3 100644 > --- a/gcc/Makefile.in > +++ b/gcc/Makefile.in > @@ -2496,6 +2525,7 @@ s-tm-texi: build/genhooks$(build_exeext) > $(srcdir)/doc/tm.texi.in > && ( test $(srcdir)/doc/tm.texi -nt

Re: [PATCH] Initial commit of Networking TS implementation

2018-10-16 Thread Jonathan Wakely
On 12/10/18 11:50 +0100, Jonathan Wakely wrote: This implementation is very incomplete (see the various TODO comments in the code) but rather than keeping it out of tree any longer I'm committing it to trunk. This will allow others to experiment with it and (I hope) work on finishing it. Either

Re: [PATCH] Optimize sin(atan(x)) and cos(atan(x)), take 3 (PR tree-optimization/86829)

2018-10-16 Thread Christophe Lyon
On Tue, 16 Oct 2018 at 17:15, Giuliano Augusto Faulin Belinassi wrote: > > Hello. Sorry for the late reply. > > > but then cosatanf is computed as (ie there's not call to cosatanf()): > >movwr3, #48430 > >movtr3, 45883 > > so r3=0xb33bbd2e (-4.371139E-8) which is not zero.

Re: [PATCH] Optimize sin(atan(x)) and cos(atan(x)), take 3 (PR tree-optimization/86829)

2018-10-16 Thread Giuliano Augusto Faulin Belinassi
Hello. Sorry for the late reply. > but then cosatanf is computed as (ie there's not call to cosatanf()): >movwr3, #48430 >movtr3, 45883 > so r3=0xb33bbd2e (-4.371139E-8) which is not zero. Does this behavior is still present if we change the line 58 to: int

[PATCH] Define _GLIBCXX_USE_DEV_RANDOM as replacement for _GLIBCXX_USE_RANDOM_TR1

2018-10-16 Thread Jonathan Wakely
Define and use a new macro with a more descriptive name. Only use the old macro in . * acinclude.m4 (GLIBCXX_CHECK_RANDOM_TR1): Replace with ... (GLIBCXX_CHECK_DEV_RANDOM): New macro with more descriptive name. Define _GLIBCXX_USE_DEV_RANDOM as well as

Re: [PATCH][RFC] Add bitmap_clear_first_set_bit for worklist handling

2018-10-16 Thread Jeff Law
On 10/16/18 3:12 AM, Richard Biener wrote: > > This adds bitmap_clear_first_set_bit to replace the common > > unsigned idx = bitmap_first_set_bit (b); > bitmap_clear_bit (b, idx); > > pattern which disturbs the bitmap lookup cached element. We can > always find and clear the first set bit

Re: [PATCH] lra: fix spill_hard_reg_in_range clobber check

2018-10-16 Thread Jeff Law
On 10/16/18 3:17 AM, Ilya Leoshkevich wrote: > Bootstrap and regtest are running on x86_64-redhat-linux. > > Insns in FROM..TO range might not be recognized yet, and their > corresponding entries in lra_insn_recog_data[] might be NULLs. In the > code from PR87596 the problematic insn is merely >

Re: [PATCH] Reset insn priority after inc/ref replacement in haifa sched

2018-10-16 Thread Jeff Law
On 10/16/18 12:48 AM, Robin Dapp wrote: >> A C++ style nit/question: instead of adding a new overload >> >> priority (rtx_insn *, bool) >> >> you can add a parameter with a default value in the existing >> static function >> >> priority (rtx_insn *insn, bool force_recompute = false) > >

Re: [PATCH] Fix PR87473 (SLSR ICE on hidden basis)

2018-10-16 Thread Jeff Law
On 10/15/18 3:02 AM, Richard Biener wrote: > On Fri, Oct 12, 2018 at 10:01 PM Bill Schmidt wrote: >> >> Hi, >> >> This patch addresses SLSR bug PR87473. The underlying problem here is that >> create_add_on_incoming_edge contains code to handle a phi_arg that is equal >> to the base expression of

Re: [PATCH, OpenACC, 7/8] Multi-dimensional dynamic array support for OpenACC data clauses, libgomp support

2018-10-16 Thread Jakub Jelinek
On Tue, Oct 16, 2018 at 08:57:00PM +0800, Chung-Lin Tang wrote: > --- a/libgomp/target.c > +++ b/libgomp/target.c > @@ -490,6 +490,140 @@ gomp_map_val (struct target_mem_desc *tgt, void > **hostaddrs, size_t i) >return tgt->tgt_start + tgt->list[i].offset; > } > > +/* Dynamic array related

[PATCH, OpenACC, 8/8] Multi-dimensional dynamic array support for OpenACC data clauses, libgomp testsuite additions

2018-10-16 Thread Chung-Lin Tang
These are the added cases for testing the OpenACC dynamic (sub)arrays functionality. Thanks, Chung-Lin libgomp/ * testsuite/libgomp.oacc-c-c++-common/da-1.c: New test. * testsuite/libgomp.oacc-c-c++-common/da-2.c: New test. *

[PATCH, OpenACC, 7/8] Multi-dimensional dynamic array support for OpenACC data clauses, libgomp support

2018-10-16 Thread Chung-Lin Tang
This part is the libgomp runtime handling for OpenACC dynamic arrays. We handle such arrays by creating a "pointer block" that emulates the N-1 dimensions, and then treating each data row of the final Nth dimension as an individual object mapped in the TGT. All the rows are processed as

[PATCH, OpenACC, 6/8] Multi-dimensional dynamic array support for OpenACC data clauses, tree pretty-printing additions

2018-10-16 Thread Chung-Lin Tang
This tree-pretty-print.c patch allows proper dumping of the dynamic arrays case of OMP_CLAUSE_MAP. Thanks, Chung-Lin gcc/ * tree-pretty-print.c (dump_omp_clauses): Add cases for printing GOMP_MAP_DYNAMIC_ARRAY map kinds. diff --git a/gcc/tree-pretty-print.c

[PATCH, OpenACC, 5/8] Multi-dimensional dynamic array support for OpenACC data clauses, omp-low: bias scanning/adjustment during omp-lowering

2018-10-16 Thread Chung-Lin Tang
This part is also in omp-low.c. We scan and adjust the code during omp-lowering, to add the biases for each dimension when a dynamic array access is detected, which is required for generally supporting copying sections of each dimension. The code is a bit sophisticated, and I wonder if this

[PATCH, OpenACC, 3/8] Multi-dimensional dynamic array support for OpenACC data clauses, gimplify patch

2018-10-16 Thread Chung-Lin Tang
This gimplify.c patch adds to the omp clause scanning to handle dynamic array cases, mainly to properly handle dimension biases of GOMP_MAP_DYNAMIC_ARRAYs by making sure the bias field is seen in the omp-ctx. Thanks, Chung-Lin gcc/ * gimplify.c (gimplify_scan_omp_clauses): For

[PATCH, OpenACC, 4/8] Multi-dimensional dynamic array support for OpenACC data clauses, omp-low: dynamic array descriptor creation

2018-10-16 Thread Chung-Lin Tang
The next two patches are the bulk of the compiler patch in the middle-ends. The first patch here, implements the creation of dynamic array descriptors to pass to the runtime, a different way than completely using map-clauses. Because we support arbitrary number of dimensions, adding more map

[PATCH, OpenACC, 2/8] Multi-dimensional dynamic array support for OpenACC data clauses, C/C++ front-end parts

2018-10-16 Thread Chung-Lin Tang
These are the parts for the C/C++ front-ends. We now allow certain non-contiguous cases under OpenACC, and pass the defined base/length pairs for each array dimension as a TREE_LIST passed to the middle-end through OMP_CLAUSE_SIZE. Thanks, Chung-Lin gcc/c/ * c-typeck.c

[PATCH, OpenACC, 1/8] Multi-dimensional dynamic array support for OpenACC data clauses, gomp-constants.h additions

2018-10-16 Thread Chung-Lin Tang
This part defines GOMP_MAP_DYNAMIC_ARRAY_* symbols in include/gomp-constants.h. Basically use the next bit to define GOMP_MAP_FLAG_SPECIAL_3 to achieve this purpose. Thanks, Chung-Lin Tang include/ * gomp-constants.h (GOMP_MAP_FLAG_SPECIAL_3): Define. (enum

[PATCH, OpenACC, 0/8] Multi-dimensional dynamic array support for OpenACC data clauses

2018-10-16 Thread Chung-Lin Tang
Hi Jakub, this patch set is supposed to be OpenACC functionality, but most of it touches shared code, so I have CCed both you and Thomas. This patch adds capability to handle C/C++ non-contiguous, dynamically allocated multi-dimensional arrays in OpenACC data clauses: int *a[100], **b;

Re: [v3, testsuite] Introduce dg-add-options net_ts

2018-10-16 Thread Jonathan Wakely
On 16/10/18 13:38 +0200, Rainer Orth wrote: Some of the new Networking TS tests FAIL before Solaris 11.4 like this: FAIL: experimental/net/internet/address/v4/members.cc (test for excess errors) Excess errors: Undefined first referenced symbol

[PATCH] Fix tests that fail when compiled without optimisation

2018-10-16 Thread Jonathan Wakely
* testsuite/20_util/duration/literals/range_neg.cc: Adjust pruned diagnostic to account for quotes around 'constexpr'. * testsuite/23_containers/deque/capacity/max_size.cc: Define static variable. * testsuite/23_containers/vector/capacity/max_size.cc:

[v3, testsuite] Introduce dg-add-options net_ts

2018-10-16 Thread Rainer Orth
Some of the new Networking TS tests FAIL before Solaris 11.4 like this: FAIL: experimental/net/internet/address/v4/members.cc (test for excess errors) Excess errors: Undefined first referenced symbol in file inet_ntop

[PATCH] PR libstdc++/87618 fix typos in linker script

2018-10-16 Thread Jonathan Wakely
PR libstdc++/87618 * config/abi/pre/gnu.ver: Fix typos in patterns for basic_stringbuf. * testsuite/27_io/basic_stringbuf/cons/char/default.cc: Disable optimisation to check constructor definition can be linked to. *

Re: [00/10][RFC] Splitting the C and C++ concept of "complete type"

2018-10-16 Thread Richard Sandiford
Hi Martin, Thanks for the reply. "Uecker, Martin" writes: > Hi Richard, > > as Joseph pointed out, there are some related discussions > on the WG14 reflector. How a about moving the discussion > there? The idea was to get a feel for what would be acceptable to GCC maintainers. When Arm

[AARCH64]Don't force symbols which referencing per-function literal pool into memory

2018-10-16 Thread Renlin Li
Hi all, "-mcmodel=large" and "-mpc-relative-loads" are used to avoid adrp+add to address symbols. When the combination is used, the original symbol is first forced into per-function literal pools. And a local symbol is created to reference it. In this case, the way to reference this local

[00/10][RFC] Splitting the C and C++ concept of "complete type"

2018-10-16 Thread Richard Sandiford
The C standard says: At various points within a translation unit an object type may be "incomplete" (lacking sufficient information to determine the size of objects of that type) or "complete" (having sufficient information). For AArch64 SVE, we'd like to split this into two

Re: [PATCH 02/14] Add D frontend (GDC) implementation.

2018-10-16 Thread Richard Sandiford
Iain Buclaw writes: > On 18 September 2018 at 02:33, Iain Buclaw wrote: >> This patch adds the D front-end implementation, the only part of the >> compiler that interacts with GCC directly, and being the parts that I >> maintain, is something that I can talk about more directly. >> >> For the

Re: [PATCH 04/14] Add D front-end (GDC) config, Makefile, and manpages.

2018-10-16 Thread Richard Sandiford
I'll pretend to be a doc reviewer... Iain Buclaw writes: > +@page > +@vskip 0pt plus 1filll > +Published by the Free Software Foundation @* > +51 Franklin Street, Fifth Floor@* > +Boston, MA 02110-1301, USA@* Would be good to copy the expanded GNU Press stuff from gcc.texi. > +The

Re: Extend usage of C++11 direct init in __debug::vector

2018-10-16 Thread Jonathan Wakely
On 16/10/18 10:20 +0100, Jonathan Wakely wrote: On 15/10/18 22:45 +0200, François Dumont wrote: On 10/15/2018 12:10 PM, Jonathan Wakely wrote: On 15/10/18 07:23 +0200, François Dumont wrote: This patch extend usage of C++11 direct initialization in __debug::vector and makes some calls to

Re: Extend usage of C++11 direct init in __debug::vector

2018-10-16 Thread Jonathan Wakely
On 15/10/18 22:45 +0200, François Dumont wrote: On 10/15/2018 12:10 PM, Jonathan Wakely wrote: On 15/10/18 07:23 +0200, François Dumont wrote: This patch extend usage of C++11 direct initialization in __debug::vector and makes some calls to operator - more consistent. Note that I also

[PATCH] lra: fix spill_hard_reg_in_range clobber check

2018-10-16 Thread Ilya Leoshkevich
Bootstrap and regtest are running on x86_64-redhat-linux. Insns in FROM..TO range might not be recognized yet, and their corresponding entries in lra_insn_recog_data[] might be NULLs. In the code from PR87596 the problematic insn is merely (note 148 154 68 7 NOTE_INSN_DELETED) however I

Re: [Patch, Fortran] PR87556 – for FORM TEAM also use argse.pre/post

2018-10-16 Thread Paul Richard Thomas
Hi Tobias, Following our exchange off-list, I rather agree with you that a testcase is pointless. Besides which, I do not see this regressing :-) OK for trunk and, if you are feeling strong, 8-branch. Thanks and welcome back. Paul On Mon, 15 Oct 2018 at 20:46, Tobias Burnus wrote: > > as the

[PATCH][RFC] Add bitmap_clear_first_set_bit for worklist handling

2018-10-16 Thread Richard Biener
This adds bitmap_clear_first_set_bit to replace the common unsigned idx = bitmap_first_set_bit (b); bitmap_clear_bit (b, idx); pattern which disturbs the bitmap lookup cached element. We can always find and clear the first set bit in O(1) so this implements this as a primitive.

[wwwdocs] Announce Solaris 10 obsoletion

2018-10-16 Thread Rainer Orth
The following patch documents the Solaris 10 obsoletion in the GCC 9 changes.html. I've based this on the GCC 4.9 text which allowed for obsoletion of several targets. Tested by inspection in Firefox. Ok to install? As a followup, we should update criteria.html to name sparc-sun-solaris2.11 as

Re: [Patch, Fortran] PR67125 - ALLOCATE with source-expr lbounds/ubound off by one

2018-10-16 Thread Paul Richard Thomas
Hi Tobias, Your patch is OK for trunk and, I would suggest 8-branch. As a matter of curiosity, why did you not use the condition: if (!(expr3_desc && GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (expr3_desc))) ? Your solution is fine, though. Cheers Paul On Fri, 12 Oct 2018 at 12:29, Tobias Burnus

[PATCH][AArch64] Use @ pattern to eliminate switch statement in one more place

2018-10-16 Thread Kyrylo Tkachov
Hi all, We can use the new '@' modifier to MD patterns to generate mode-parametrised gen_ functions for the despeculate_copy patterns and therefore remove the switch on modes in aarch64.c that is used to pick the right generator. This simplifies the code. Bootstrapped and tested on

[build, doc] Obsolete Solaris 10 support

2018-10-16 Thread Rainer Orth
This patch implements the Solaris 10 obsoletion announced yesterday: https://gcc.gnu.org/ml/gcc/2018-10/msg00139.html Bootstrapped on i386-pc-solaris2.10 without and with --enable-obsolete and inspected gccinstall.info. The contrib-list.mk part is untested, but completely mechanical.

Re: [PATCH] __debug::list use C++11 direct initialization

2018-10-16 Thread Jonathan Wakely
On 16/10/18 07:06 +0200, François Dumont wrote: On 10/15/2018 12:07 PM, Jonathan Wakely wrote: On 09/10/18 07:11 +0200, François Dumont wrote: Here is the communication for my yesterday's patch which I thought svn had failed to commit (I had to interrupt it). Similarly to what I've done for

Re: [00/10][RFC] Splitting the C and C++ concept of "complete type"

2018-10-16 Thread Richard Biener
On Mon, Oct 15, 2018 at 8:40 PM Uecker, Martin wrote: > > > Hi Richard, > > as Joseph pointed out, there are some related discussions > on the WG14 reflector. How a about moving the discussion > there? > > I find your approach very interesting and that it already > comes with an implementation is

Re: [PATCH] Reset insn priority after inc/ref replacement in haifa sched

2018-10-16 Thread Robin Dapp
> A C++ style nit/question: instead of adding a new overload > > priority (rtx_insn *, bool) > > you can add a parameter with a default value in the existing > static function > > priority (rtx_insn *insn, bool force_recompute = false) Sometimes I'm still stuck in C land with GCC :),