Re: [RS6000] Use gen_hard_reg_clobber in rs6000.c

On Fri, Dec 14, 2018 at 07:57:08PM -0600, Segher Boessenkool wrote: > On Sat, Dec 15, 2018 at 11:48:07AM +1030, Alan Modra wrote: > > I noticed when looking at PR88311 that rs6000_call_sysv should be > > using gen_hard_reg_clobber (as the sysv call insns did prior to me > > introducing rs6000_call_

Re: [PATCH][RS6000] Fix PR87870: ppc64 generates poor code when loading constants into TImode vars

On Thu, Dec 13, 2018 at 10:59:36AM -0600, Peter Bergner wrote: > On 11/16/18 5:29 PM, Segher Boessenkool wrote: > > On Fri, Nov 16, 2018 at 04:26:18PM -0600, Peter Bergner wrote: > >> However, when I made the change below, the length attribute seems a > >> little off. For *_64bit, we have a length

Re: [RS6000] Use gen_hard_reg_clobber in rs6000.c

On Sat, Dec 15, 2018 at 11:48:07AM +1030, Alan Modra wrote: > I noticed when looking at PR88311 that rs6000_call_sysv should be > using gen_hard_reg_clobber (as the sysv call insns did prior to me > introducing rs6000_call_sysv). This patch fixes that minor > regression, and other like places in r

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

On 12/14/18 4:36 PM, Jeff Law wrote: On 12/14/18 3:05 AM, Uecker, Martin wrote: Am Donnerstag, den 13.12.2018, 16:35 -0700 schrieb Jeff Law: On 12/12/18 11:12 AM, Uecker, Martin wrote: ... diff --git a/gcc/c/c-objc-common.h b/gcc/c/c-objc-common.h index 78e768c2366..ef039560eb9 100644 --- a/

[RS6000] Use gen_hard_reg_clobber in rs6000.c

I noticed when looking at PR88311 that rs6000_call_sysv should be using gen_hard_reg_clobber (as the sysv call insns did prior to me introducing rs6000_call_sysv). This patch fixes that minor regression, and other like places in rs6000.c. Bootstrapped and regression tested powerpc64le-linux. Pow

Re: [PATCH] handle expressions in __builtin_has_attribute (PR 88383)

the manual a function declaration like __attribute__ ((alloc_size (1), malloc)) void* allocate (unsigned); should have those two attributes applied to it. Yet, alloc_size is actually applied to its type (but not to its decl) while malloc to the function's decl but not its type (bug 88397)

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

On Fri, Dec 14, 2018 at 3:24 PM Jeff Law wrote: > > On 12/14/18 4:01 PM, H.J. Lu wrote: > > On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak wrote: > >> On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: > >>> get_frame_size () returns used stack slots during compilation, which > >>> may be optimized ou

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

On 12/14/18 3:05 AM, Uecker, Martin wrote: > > Am Donnerstag, den 13.12.2018, 16:35 -0700 schrieb Jeff Law: >> On 12/12/18 11:12 AM, Uecker, Martin wrote: > ... > diff --git a/gcc/c/c-objc-common.h b/gcc/c/c-objc-common.h > index 78e768c2366..ef039560eb9 100644 > --- a/gcc/c/c-objc-com

[PATCH] v5: C++: more location wrapper nodes (PR c++/43064, PR c++/43486)

On Thu, 2018-12-13 at 15:37 -0500, Jason Merrill wrote: > On 12/13/18 3:12 PM, David Malcolm wrote: > > On Wed, 2018-12-12 at 15:37 -0500, Jason Merrill wrote: > > > On 12/7/18 3:13 PM, David Malcolm wrote: > > > > On Tue, 2018-12-04 at 18:31 -0500, Jason Merrill wrote: > > > > > On 12/3/18 5:10 PM

[PATCH, ARM] Fix PR77904 testcase failure

Hi, Commit r242693 forced fp to be saved/restored when needed due to an instance of GCC using fp as a scratch register to save sp while it's being clobbered by an inline asm. The normal path in thumb1_compute_save_reg_mask saving callee-saved registers which are live in the function does not work

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

On 12/14/18 4:01 PM, H.J. Lu wrote: > On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak wrote: >> On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: >>> get_frame_size () returns used stack slots during compilation, which >>> may be optimized out later. Since ix86_find_max_used_stack_alignment >>> is cal

[committed] Fix valgrind error in cselib_record_sets (PR rtl-optimization/88478)

Hi! On Wed, Dec 05, 2018 at 04:50:19AM -0200, Alexandre Oliva wrote: > * cselib.c (cselib_record_sets): Skip strict low part sets > with NULL src_elt. > --- > gcc/cselib.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/cselib.c b/gcc/cselib.c > index 6d3a4078c689..4a

Re: [PATCH] Fix avx512f_sfixupimm* (PR target/88489)

On 12/14/18 12:50 PM, Jakub Jelinek wrote: > Hi! > > The avx512f-vfixupimms{s,d}-2.c testcases were miscompiled with -mavx512vl. > The problem is that there are separate instructions (e.g. vfixupimmsd vs. > vfixupimmpd), each of those have different behavior, the first one is > TARGET_AVX512F, the

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On Dec 14, 2018, Jason Merrill wrote: > Let's move the initialization of "fields" inside the 'then' block here > with the initialization of "cvquals", rather than clear it in the > 'else'. We'd still have to NULL-initialize it somewhere, so I'd rather just move the entire loop into the condition

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak wrote: > > On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: > > > > get_frame_size () returns used stack slots during compilation, which > > may be optimized out later. Since ix86_find_max_used_stack_alignment > > is called by ix86_finalize_stack_frame_

V6 [PATCH] C/C++: Add -Waddress-of-packed-member

On Fri, Dec 14, 2018 at 2:10 PM Jason Merrill wrote: > > On 12/13/18 6:56 PM, H.J. Lu wrote: > > On Thu, Dec 13, 2018 at 12:50 PM Jason Merrill wrote: > >> > >> On 9/25/18 11:46 AM, H.J. Lu wrote: > >>> On Fri, Aug 31, 2018 at 2:04 PM, Jason Merrill wrote: > On 07/23/2018 05:24 PM, H.J. Lu

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On 12/14/18 5:33 PM, Alexandre Oliva wrote: On Dec 14, 2018, Jason Merrill wrote: If inh is false, we're a copy constructor, which always has a parm, so this hunk seems unnecessary. ack -  int cvquals = cp_type_quals (TREE_TYPE (parm)); +  int cvquals = parm ? cp_type_quals (TREE_T

Re: [PATCH] Improve gimplification of constructors with RANGE_EXPRs (PR c++/82294, PR c++/87436)

On Fri, Dec 14, 2018 at 12:22:28PM +0100, Richard Biener wrote: > > Still need to wait for the FE patch if I want to commit the testcases, those > > depend on both patches. > > I've added size32plus effective target to the larger test, as 384MB is too > > much for 16 or 20 bit address targets. > >

Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes

On Fri, Dec 7, 2018 at 4:00 PM Jason Merrill wrote: > On 12/7/18 12:48 PM, Tom Tromey wrote: > >> "Pedro" == Pedro Alves writes: > > > > Pedro> I would say that it's very, very unlikely, and not worth it of the > > Pedro> maintenance burden. > > > > Agreed, and especially true for the more un

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On Dec 14, 2018, Jason Merrill wrote: >> If inh is false, we're a copy constructor, which always has a parm, >> so this hunk seems unnecessary. ack >>> -  int cvquals = cp_type_quals (TREE_TYPE (parm)); >>> +  int cvquals = parm ? cp_type_quals (TREE_TYPE (parm)) : 0; >> >> This could

Re: [doc,committed] clarify docs for function attribute "const"

On 12/13/18 7:07 PM, Sandra Loosemore wrote: On 12/13/18 3:52 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00426.html (I have now committed the @code{const} cleanup mentioned below.) This patch is OK except for one nit.  @cindex pointer arguments  Note that a

Re: V5 [PATCH] C/C++: Add -Waddress-of-packed-member

On 12/13/18 6:56 PM, H.J. Lu wrote: On Thu, Dec 13, 2018 at 12:50 PM Jason Merrill wrote: On 9/25/18 11:46 AM, H.J. Lu wrote: On Fri, Aug 31, 2018 at 2:04 PM, Jason Merrill wrote: On 07/23/2018 05:24 PM, H.J. Lu wrote: On Mon, Jun 18, 2018 at 12:26 PM, Joseph Myers wrote: On Mon, 18 Ju

Re: [C++ PATCH] Sanity check __cxa_* user declarations (PR c++/88482)

On 12/13/18 6:29 PM, Jakub Jelinek wrote: Hi! If the user provides his own __cxa_* prototypes and does so incorrectly (or even worse declares them as variables etc.), we can get various ICEs. The following patch adds some sanity checking, mainly that they are actually functions and with a compa

Re: PING^2: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

On Fri, Dec 14, 2018 at 1:28 PM Jeff Law wrote: > > On 12/11/18 9:03 AM, H.J. Lu wrote: > > On Mon, Dec 3, 2018 at 5:45 AM H.J. Lu wrote: > >> On Mon, Jun 18, 2018 at 2:20 AM Richard Biener > >> wrote: > >>> On Fri, Jun 15, 2018 at 2:59 PM H.J. Lu wrote: > Currently GCC inserts ENDBR instr

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

On 12/14/18 4:33 PM, Paolo Carlini wrote: Hi, On 14/12/18 21:19, Jason Merrill wrote: On 12/14/18 1:44 PM, Paolo Carlini wrote: Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carl

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On 12/14/18 3:42 PM, Jason Merrill wrote: On 12/6/18 7:23 PM, Alexandre Oliva wrote: This patch started out from the testcase in PR88146, that attempted to synthesize an inherited ctor without any args before a varargs ellipsis and crashed while at that, because of the unguarded dereferencing of

Re: [PATCH 1/4] introduce struct strlen_data_t into gimple-fold

On 12/14/18 2:23 PM, Jeff Law wrote: On 12/10/18 2:00 PM, Martin Sebor wrote: Jeff, is there something you are expecting me to change in response to this or have you just not gotten around to reviewing the rest? Your last comment led me to believe you had another iteration on the first patch to

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

Hi, On 14/12/18 21:19, Jason Merrill wrote: On 12/14/18 1:44 PM, Paolo Carlini wrote: Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merril

Re: PING^2: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

On 12/11/18 9:03 AM, H.J. Lu wrote: > On Mon, Dec 3, 2018 at 5:45 AM H.J. Lu wrote: >> On Mon, Jun 18, 2018 at 2:20 AM Richard Biener >> wrote: >>> On Fri, Jun 15, 2018 at 2:59 PM H.J. Lu wrote: Currently GCC inserts ENDBR instruction at entries of all non-static functions, unless LTO

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi! On Fri, 25 May 2018 13:01:58 -0700, Cesar Philippidis wrote: > This patch updates GCC's to support OpenACC 2.5's data clause semantics. > In OpenACC 2.5, copy, copyin and copyout all behave like their > present_or_* counterparts in OpenACC 2.0. The patch also adds support > for the new fi

Re: [PATCH 1/4] introduce struct strlen_data_t into gimple-fold

On 12/10/18 2:00 PM, Martin Sebor wrote: > Jeff, is there something you are expecting me to change in > response to this or have you just not gotten around to reviewing > the rest? Your last comment led me to believe you had another iteration on the first patch to do before we moved forward. > >

Re: [PATCH] Remove duplicated code block in gimple-ssa-split-paths.c

On 12/14/18 2:25 AM, Richard Biener wrote: > > Jeffs last commit added the fix twice. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2018-12-14 Richard Biener > > * gimple-ssa-split-paths.c (is_feasible_trace): Remove > duplicated code block.

[PR88495] An OpenACC async queue is always synchronized with itself

Hi! Committed to trunk in r267152: commit 963e7a8d58a248f8093947e9a5ba56306d36a8e2 Author: tschwinge Date: Fri Dec 14 20:43:02 2018 + [PR88495] An OpenACC async queue is always synchronized with itself An OpenACC async queue is always synchronized with itself, so invocations

[PR88484] OpenACC wait directive without wait argument but with async clause

Hi! Committed to trunk in r267151: commit 44b7d2b9c1b1a535212b8312c6dc76dd1570db45 Author: tschwinge Date: Fri Dec 14 20:42:50 2018 + [PR88484] OpenACC wait directive without wait argument but with async clause We don't correctly handle "#pragma acc wait async (a)" for "a >=

Re: [PATCH, ARM] Do softfloat when -mfpu set, -mfloat-abi=softfp and targeting Thumb-1

Hi Richard, Thanks for catching the problem with this approach. Hopefully this version should solve the real problem: FP instructions are only enabled for TARGET_32BIT and TARGET_HARD_FLOAT but GCC only gives an error when TARGET_HARD_FLOAT is true and -mfpu is not set. Among other things, it ma

Re: [PATCH] Delete powerpcspe

On 12/14/18 11:41 AM, Joseph Myers wrote: > On Fri, 14 Dec 2018, Jeff Law wrote: > >>> I wonder if we could set up auto-(simulator)-testing for all supported >>> archs (and build testing for all supported configs) on the CF >>> (with the required scripting in contrib/ so it's easy to replicate).

Re: [PR88407] [OpenACC] Correctly handle unseen async-arguments

Hi! On Fri, 7 Dec 2018 16:38:58 +0100, I wrote: > So, confused about the intended behavior, I've asked the OpenACC > committee to clarify, and filed "[OpenACC] > Correctly handle unseen async-arguments". > > Assuming this gets clarified in the way I think it should,

Revise libgomp.oacc-c-c++-common/data-2-lib.c, libgomp.oacc-c-c++-common/data-2.c

Hi! Committed to trunk in r267149: commit 1d61d32a5dda2b567f2253284ce3ecf40c253fab Author: tschwinge Date: Fri Dec 14 20:42:29 2018 + Revise libgomp.oacc-c-c++-common/data-2-lib.c, libgomp.oacc-c-c++-common/data-2.c These are meant to be functionally equivalent (but no longe

Re: [PATCH, libgcc/ARM & testsuite] Optimize executable size when using softfloat fmul/dmul

Hi Richard, None, is there any? All the one I could find in the big switch selecting tm_files and tmake_files in gcc/config.gcc are including arm/elf.h. I tried to build for arm-wince-pe but got: "Configuration arm-wince-pe not supported". However note that to guarantee correct results the only re

Re: [PATCH 5/6, OpenACC, libgomp] Async re-work, C/C++ testsuite changes

Hi! On Fri, 7 Dec 2018 16:30:53 +0100, I wrote: > On Tue, 25 Sep 2018 21:11:42 +0800, Chung-Lin Tang > wrote: > > These are the testsuite/libgomp.oacc-c-c++-common/* changes. > > Please commit the following three hunks to trunk: the code as present > doesn't declare its async/wait dependencies

Re: [PR88370] acc_get_cuda_stream/acc_set_cuda_stream: acc_async_sync, acc_async_noval

Hi! On Wed, 5 Dec 2018 15:14:16 +0100, I wrote: > On Mon, 19 Nov 2018 16:33:30 +0900, Chung-Lin Tang > wrote: > > On 2018/11/18 10:36 AM, Thomas Schwinge wrote: > > > Generally, I envision test cases running a few "acc_get_cuda_stream" > > > calls with relevant argument values, to see whether th

Re: [committed 0/4] (Partial) OpenMP 5.0 support for GCC 9

On Fri, Dec 14, 2018 at 09:55:51PM +0100, Thomas Schwinge wrote: > Anyway, that was easy enough to fix; in r267145 committed to trunk: > liboffloadmic/ > * runtime/offload.h (omp_target_is_present, omp_target_memcpy) > (omp_target_memcpy_rect, omp_target_associa

Add user-friendly diagnostics for OpenACC loop parallelism assigned (was: [PATCH 3/3] Add user-friendly OpenACC diagnostics regarding detected parallelism)

Hi! On Thu, 26 Jul 2018 07:14:21 -0700, Cesar Philippidis wrote: > On 07/26/2018 01:33 AM, Richard Biener wrote: > > On Wed, Jul 25, 2018 at 5:30 PM Cesar Philippidis > > wrote: > >> > >> This patch Thanks! > >> teaches GCC to inform the user how it assigned parallelism > >> to each OpenACC l

Re: [committed 0/4] (Partial) OpenMP 5.0 support for GCC 9

Hi Jakub! On Thu, 8 Nov 2018 18:16:11 +0100, Jakub Jelinek wrote: > The OpenMP 5.0 specification, https://www.openmp.org/specifications/ , > has been just released a few minutes ago and to celebrate that, I've merged > gomp-5_0-branch into trunk after bootstrapping/regtesting it on x86_64-linux

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On 12/6/18 7:23 PM, Alexandre Oliva wrote: This patch started out from the testcase in PR88146, that attempted to synthesize an inherited ctor without any args before a varargs ellipsis and crashed while at that, because of the unguarded dereferencing of the parm type list, that usually contains

Re: [C++ PATCH] [PR c++/87814] undefer deferred noexcept on tsubst if request

On 12/6/18 7:19 PM, Alexandre Oliva wrote: tsubst_expr and tsubst_copy_and_build are not expected to handle DEFERRED_NOEXCEPT exprs, but if tsubst_exception_specification takes a DEFERRED_NOEXCEPT expr with !defer_ok, it just passes the expr on for tsubst_copy_and_build to barf. This patch arran

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

On 12/14/18 1:44 PM, Paolo Carlini wrote: Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merrill wrote: On Fri, Oct 26, 2018 at 4:52 AM Paolo

Re: [C++ PATCH] [PR c++/87814] undefer deferred noexcept on tsubst if request

On Dec 6, 2018, Alexandre Oliva wrote: > Regstrapped on x86_64- and i686-linux-gnu, mistakenly along with a patch > with a known regression, and got only that known regression. Retesting > without it. Ok to install? Ping? That retesting confirmed no regressions. https://gcc.gnu.org/ml/gcc-pa

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On Dec 6, 2018, Alexandre Oliva wrote: > Regstrapped on x86_64- and i686-linux-gnu, mistakenly along with a patch > with a known regression, and got only that known regression. Retesting > without it. Ok to install? Ping? That round of retesting confirmed no regressions. https://gcc.gnu.org/

Re: [nvptx] vector length patch series

On 29-10-18 20:28, Cesar Philippidis wrote: > On 10/5/18 23:22, Tom de Vries wrote: >> On 9/18/18 10:04 PM, Cesar Philippidis wrote: >>> 591973d3c3a [nvptx] use user-defined vectors when possible >> >> If I drop this patch, I get the same test results. Can you find a >> testcase for which this patc

[PATCH] Fix avx512f_sfixupimm* (PR target/88489)

Hi! The avx512f-vfixupimms{s,d}-2.c testcases were miscompiled with -mavx512vl. The problem is that there are separate instructions (e.g. vfixupimmsd vs. vfixupimmpd), each of those have different behavior, the first one is TARGET_AVX512F, the latter TARGET_AVX512VL, but the 128-bit version of the

[PATCH] Fix up AVX512F masked gather vectorization, add support for AVX512F 512-bit masked scatter vectorization (PR tree-optimization/88464)

Hi! In the previous patch I've unfortunately left one important case from the testcase and apparently it wasn't covered by anything else in the testsuite. The 3 functions covered float and double gathers with indexes with the same bitsize and WIDENING gather (double gather with int index), but did

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merrill wrote: On Fri, Oct 26, 2018 at 4:52 AM Paolo Carlini wrote: On 24/10/18 22:41, Jason

Re: [PATCH] Delete powerpcspe

On Fri, 14 Dec 2018, Jeff Law wrote: > > I wonder if we could set up auto-(simulator)-testing for all supported > > archs (and build testing for all supported configs) on the CF > > (with the required scripting in contrib/ so it's easy to replicate). I'd > > simply test only released snapshots to

Linux x86 unwinder: Handle __NR_sigreturn for __kernel_sigreturn support

I believe this may address recent unwinder failures in Fedora if the vDSO unwinder does not contain unwinding data: The question is: Do we want to move in that direction? Or should we make clear that the userspace ABI *requires* unwinding i

Re: [PATCH, libphobos] Committed remove unused internal modules

On Mon, 19 Nov 2018 at 00:40, Iain Buclaw wrote: > > Hi, > > This patch removes two x86-centric modules that are ignored as gdc > doesn't implement the D_InlineAsm version condition. Bootstrapped and > testsuite ran on x86_64-linux-gnu. > > Committed to trunk as r266256 > > -- > Iain > --- > libp

Re: [PATCH 1/6, OpenACC, libgomp] Async re-work, interfaces

Hi! A few more -- final? ;-) -- comments: On Tue, 25 Sep 2018 21:10:21 +0800, Chung-Lin Tang wrote: > This patch separates out the header interface changes. GOMP_VERSION has been > bumped, > and various changes to the plugin interface, and a few libgomp internal > functions > declared. The li

[committed] Fix minor goof in last change for TARGET_ASM_POST_CFI_STARTPROC

It looks like Jason asked Sam to make a last minute doc change. Sam made that change in the tm.texi file, but target.def has the old text. This causes a build failure. I'm guessing the wrong target.def was committed. Regardless the fix is trivial. Jeff diff --git a/gcc/target.def b/gcc/target

Re: Add a loop versioning pass

Richard Biener writes: > On December 12, 2018 7:43:10 PM GMT+01:00, Richard Sandiford > wrote: >>Richard Biener writes: >>> On Thu, Dec 6, 2018 at 2:19 PM Richard Sandiford Tested on x86_64-linux-gnu, aarch64-linux-gnu and aarch64_be-elf. Also repeated the performance testing (but hav

Re: [PATCH, ARM] Improve robustness of -mslow-flash-data

Hi Thomas, On 11/12/18 16:09, Thomas Preudhomme wrote: Hi Kyrill, I've tested on armeb-none-eabi with -mslow-flash-data for both -mfloat-abi=hard and -mfloat-abi=soft. Both show no regression and the former shows some new PASS. Regarding the part you are hesitant about, the code was taken from

Re: [PATCH, GCC, AARCH64, 5/6] Enable BTI : Add new pass for BTI.

Hi James On 29/11/18 16:47, Sudakshina Das wrote: > Hi > > On 13/11/18 14:47, Sudakshina Das wrote: >> Hi >> >> On 02/11/18 18:38, Sudakshina Das wrote: >>> Hi >>> >>> This patch is part of a series that enables ARMv8.5-A in GCC and >>> adds Branch Target Identification Mechanism. >>> (https://de

Re: [PATCH] Delete powerpcspe

On 12/14/18 1:20 AM, Segher Boessenkool wrote: > On Thu, Dec 13, 2018 at 09:49:51AM -0700, Jeff Law wrote: >> On 12/12/18 10:33 AM, Segher Boessenkool wrote: >>> On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: > One way to de

Re: [PATCH] Delete powerpcspe

On 12/14/18 2:52 AM, Richard Biener wrote: > On Thu, Dec 13, 2018 at 5:49 PM Jeff Law wrote: >> >> On 12/12/18 10:33 AM, Segher Boessenkool wrote: >>> On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: > One way to deal with th

Re: [PATCH 1/3][GCC] Add new target hook asm_post_cfi_startproc

On 12/13/18 7:03 PM, Jason Merrill wrote: > And this seems consistent with the other stuff in > dwarf2out_do_cfi_startproc.  You might amend the documentation to > mention that the expected use is to add more .cfi_* directives. OK > with that change. > > Jason Hi Jason, Thanks for the approva

Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

Hi Segher, Thanks for the review. On Wed, 12 Dec 2018 19:47:53 -0600 Segher Boessenkool wrote: > The unused bits in a MODE_PARTIAL_INT value are undefined, so nonzero_bits > isn't valid for conversion in either direction. > > And *which* bits are undefined isn't defined anywhere either, so we c

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

Hi Chung-Lin! On Tue, 25 Sep 2018 21:09:49 +0800, Chung-Lin Tang wrote: > This patch is a re-organization of OpenACC asynchronous queues. Again, many thanks for that! In addition to the review emails I just posted, I've also put all that stuff into a GitHub branch:

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

On 2018/12/14 10:53 PM, Thomas Schwinge wrote: Additionally the following, or why not? Please comment on the one TODO which before your async re-work also was -- incorrectly? -- run asynchronously? diff --git libgomp/oacc-parallel.c libgomp/oacc-parallel.c index 5a441c9efe38..91875c57fc97 10

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > --- a/libgomp/oacc-async.c > +++ b/libgomp/oacc-async.c > +attribute_hidden struct goacc_asyncqueue * > +lookup_goacc_asyncqueue (struct goacc_thread *thr, bool create, int async) > +{ > + /* The special value acc_async_

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > --- a/libgomp/oacc-parallel.c > +++ b/libgomp/oacc-parallel.c > @@ -377,8 +360,6 @@ GOACC_enter_exit_data (int device, size_t mapnum, > finalize = true; > } > > - acc_dev->openacc.async_set_async_func (async)

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

On 2018/12/14 10:17 PM, Thomas Schwinge wrote: Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: --- a/libgomp/oacc-async.c +++ b/libgomp/oacc-async.c +attribute_hidden struct goacc_asyncqueue * +lookup_goacc_asyncqueue (struct goacc_thread *thr, bool create, int asyn

Re: Too strict synchronization with the local (host) thread?

Hi Chung-Lin! On Tue, 11 Dec 2018 21:30:31 +0800, Chung-Lin Tang wrote: > On 2018/12/7 11:56 PM, Thomas Schwinge wrote: > >> --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-79.c > >> +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-79.c > >> @@ -114,6 +114,7 @@ main (int argc, char **

[PATCH v2] [MIPS] GCC: Fix Loongson3 LLSC Errata

From: Paul Hua In some older Loongson3 processors there is a LL/SC errata that can cause the CPU to deadlock occasionally. The details are very complicated. We find a way to work around this errata by a) adding a sync before ll/lld instruction, b) adding a sync before branch target that betwee

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

On 2018/12/14 10:32 PM, Thomas Schwinge wrote: Invoked as "acc_wait_async ([...], acc_async_sync)" (as used in a test case that I'll soon submit/commit), we'll end up with "aq2 == NULL", and will segfault in the nvptx "openacc.async.serialize_func". What does "wait async(acc_async_sync)" suppos

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > void > acc_wait_async (int async1, int async2) > { > + struct goacc_thread *thr = get_goacc_thread (); > > + goacc_aq aq2 = lookup_goacc_asyncqueue (thr, true, async2); > + goacc_aq aq1 = lookup_goacc_asyncqueue (t

Re: [PATCH] [PR86823] retain deferred access checks from outside firewall

OK. On Thu, Dec 13, 2018 at 8:35 PM Alexandre Oliva wrote: > > On Dec 6, 2018, Alexandre Oliva wrote: > > > I'm giving your proposed patch a full round of testing along with other > > patches. > > [PR86823] retain deferred access checks from outside firewall > > We used to preserve deferred acce

Re: [PATCH] [PR87012] canonicalize ref type for tmpl arg

On Thu, Dec 13, 2018 at 8:37 PM Alexandre Oliva wrote: > On Dec 5, 2018, Jason Merrill wrote: > > > I would expect that this same issue would come up with other types; I > > think we want to fix this sooner, when we are figuring out what type > > we want to convert the argument to. > > You mean

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

On 2018/12/13 11:51 PM, Thomas Schwinge wrote: On Thu, 13 Dec 2018 23:28:49 +0800, Chung-Lin Tang wrote: On 2018/12/7 6:26 AM, Julian Brown wrote: On Thu, 6 Dec 2018 22:22:46 + Julian Brown wrote: On Thu, 6 Dec 2018 21:42:14 +0100 Thomas Schwinge wrote: [...] ..., where the "Invalid

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

Hi Chung-Lin! A little bit of documentation starter update for you to include. Please make sure that all relevant functions have such comments addded. commit 7e0896281d155e1544751f43c1eaace8e005e019 Author: Thomas Schwinge Date: Thu Dec 13 17:59:46 2018 +0100 [WIP] into async re-work: do

Re: [C++ PATCH] Use RANGE_EXPRs in build_vec_init (PR c++/82294, PR c++/87436)

OK. On Thu, Dec 13, 2018 at 6:03 PM Jakub Jelinek wrote: > > Hi! > > The following patch makes use of RANGE_EXPRs in build_vec_init, instead of > appending many ctor elements. > > E.g. on the PR87436 testcase the memory usage goes down from more than 5GB > to a few megabytes and compile time decre

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > --- a/libgomp/oacc-async.c > +++ b/libgomp/oacc-async.c > +attribute_hidden struct goacc_asyncqueue * > +lookup_goacc_asyncqueue (struct goacc_thread *thr, bool create, int async) > +{ > + /* The special value acc_async_

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Fri, 7 Dec 2018 22:19:14 +0800, Chung-Lin Tang wrote: > On 2018/12/7 07:32 PM, Thomas Schwinge wrote: > > Does the following make sense? > > I don't quite remember why I simply ensured asyncqueue creation here at the > time, > maybe simply because it allowed simpler code at th

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

Hi Chung-Lin! On Thu, 06 Dec 2018 21:42:14 +0100, I wrote: > On Tue, 25 Sep 2018 21:09:49 +0800, Chung-Lin Tang > wrote: > > Also included in this patch is the code for the acc_get/set_default_async > > API functions in OpenACC 2.5. > > It's a minor part of this patch, but since some code was m

Re: [PATCH] [RFC] PR target/52813 and target/11807

(Maybe the discussion has moved on from this already -- sorry if so) Christophe Lyon writes: > On Wed, 12 Dec 2018 at 12:21, Thomas Preudhomme > wrote: >> >> So my understanding is that the original code (CMSIS library) used to >> clobber sp because the asm statement was actually changing the sp

Re: [PATCH] error on missing LTO symbols

On Fri, Dec 14, 2018 at 02:17:49PM +0100, Tom de Vries wrote: > Build x86_64 and reg-tested libgomp. > > 2018-12-13 Tom de Vries > > * lto-cgraph.c (verify_node_partition): New function. > (input_overwrite_node, input_varpool_node): Use verify_node_partition. > > * testsuite

[PATCH] Fix PR84521

This fixes and simplifies the setjmp and non-local goto implementation. Currently the virtual frame pointer is saved when using __builtin_setjmp or a non-local goto. Depending on whether a frame pointer is used, this may either save SP or FP with an immediate offset. However the goto or longjmp a

Re: [PATCH] error on missing LTO symbols

On 14-12-18 14:08, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 02:07:18PM +0100, Tom de Vries wrote: >> Done, using offload_device_nonshared_as for >> libgomp.c-c++-common/variable-not-offloaded.c and >> openacc_nvidia_accel_configured for >> libgomp.oacc-c-c++-common/function-not-offloaded.c. >

Re: [PATCH] error on missing LTO symbols

On Fri, Dec 14, 2018 at 02:07:18PM +0100, Tom de Vries wrote: > Done, using offload_device_nonshared_as for > libgomp.c-c++-common/variable-not-offloaded.c and > openacc_nvidia_accel_configured for > libgomp.oacc-c-c++-common/function-not-offloaded.c. > > > Otherwise LGTM. > > Updated patch OK?

Re: [PATCH] error on missing LTO symbols

[ cc-ing HSAIL maintainer ] On 14-12-18 10:54, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >> Build and reg-tested on x86_64 with nvptx accelerator. >> >> 2018-12-13 Tom de Vries >> >> * lto-cgraph.c (verify_node_partition): New function. >> (i

Re: [PATCH 01/10] Fix LRA bug

On 14/12/2018 10:04, Andrew Stubbs wrote: Anyway, this patch should not affect any use case that did not already have UB, so I'll get it committed shortly. Now done. Thanks for the review. Andrew

Re: [PATCH] Improve gimplification of constructors with RANGE_EXPRs (PR c++/82294, PR c++/87436)

On Fri, 14 Dec 2018, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:40:19AM +0100, Richard Biener wrote: > > This looks OK to me - the only comment I have is on the two magic > > constants (64 and 8) which are used twice in the patch. Can you > > either see to hoist the common condition into s

Re: [committed][testsuite] Remove bashism from libbacktrace/allocfail.sh

On Fri, Dec 14, 2018 at 10:48:26AM +0100, Tom de Vries wrote: > Test-case libbacktrace/allocfail.sh contains bashism "set -o pipefail", which > makes the script fail on ubuntu 18.04, which links /bin/sh to /bin/dash. > > Fix this by removing the "set -o pipefail". > > Tested by running the test-c

[Ada] Fix Max_Size_In_Storage_Elements for unconstrained array types

It appears that GNAT was not fully compliant with the intent of the RM here because it wouldn't include the size of the bounds added in front of the data in an allocation in the value of Max_Size_In_Storage_Elements. Tested on x86_64-suse-linux, applied on the mainline. 2018-12-14 Eric Botcaz

Re: [PATCH] Improve gimplification of constructors with RANGE_EXPRs (PR c++/82294, PR c++/87436)

On Fri, Dec 14, 2018 at 10:40:19AM +0100, Richard Biener wrote: > This looks OK to me - the only comment I have is on the two magic > constants (64 and 8) which are used twice in the patch. Can you > either see to hoist the common condition into sth like > > bool prefer_loop_initializer_p = ...

[Ada] Small fix for records with boolean discriminants

The point is to avoid building comparisons of the form "D == true" in this case for the qualifiers of the union describing the variant part because 1) it's useless and 2) it's output as "D = 1" by -gnatR, which is not valid Ada. The dwarf2out.c change only affects the Ada compiler. Tested on x8

Re: [PATCH] x86: Add -march=cascadelake

On Fri, Dec 14, 2018 at 06:33:37PM +0800, Wei Xiao wrote: --- a/gcc/config/i386/driver-i386.c +++ b/gcc/config/i386/driver-i386.c @@ -832,8 +832,16 @@ const char *host_detect_local_cpu (int argc, const char **argv) cpu = "skylake"; break; case 0x55: - /* Skylake

RE: [PATCH 0/2][ARC] Fixes needed for the upcomming release.

Thank you Andrew for your quick review. Both patches are committed. Claudiu From: Claudiu Zissulescu [claz...@gmail.com] Sent: Tuesday, December 11, 2018 11:23 AM To: gcc-patches@gcc.gnu.org Cc: francois.bed...@synopsys.com; claudiu.zissule...@synopsys.com;

Re: [PATCH] x86: Add -march=cascadelake

The part 2 is implemented by attached patch. Ok for trunk? Wei gcc/ * config/i386/driver-i386.c (host_detect_local_cpu): Detect cascadelake. * config/i386/i386.c (fold_builtin_cpu): Handle cascadelake. * doc/extend.texi: Add cascadelake. gcc/testsuite/ * g++.target/i3

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

Am Donnerstag, den 13.12.2018, 16:35 -0700 schrieb Jeff Law: > On 12/12/18 11:12 AM, Uecker, Martin wrote: ... > > > > diff --git a/gcc/c/c-objc-common.h b/gcc/c/c-objc-common.h > > > > index 78e768c2366..ef039560eb9 100644 > > > > --- a/gcc/c/c-objc-common.h > > > > +++ b/gcc/c/c-objc-common.h

Re: [PATCH 01/10] Fix LRA bug

On 13/12/2018 23:49, Jeff Law wrote: OK. But be aware we may have to revisit and look more closely what what you're doing in your port if we stumble over more problems with reload changing the structure of your insns and causing problems in the process. Thanks. What's novel about this, I thin

Re: [PATCH] error on missing LTO symbols

Hi Tom! Thanks for looking into this one! Just one quick comment: On Fri, 14 Dec 2018 10:21:35 +0100, Tom de Vries wrote: > --- a/gcc/lto-cgraph.c > +++ b/gcc/lto-cgraph.c > +#ifdef ACCEL_COMPILER > + if (in_other_partition) > +{ > + if (TREE_CODE (decl) == FUNCTION_DECL > + ||

  1   2   >