Re: [PATCH, middle-end/i386]: Fix PR88502, Inline built-in asinh, acosh, atanh for -ffast-math

... and the patch. On Mon, Dec 17, 2018 at 8:58 AM Uros Bizjak wrote: > > Attached patch inlines calls to asinh{,f}, acosh{,f,l} and atanh{,f,l} > using x87 XFmode arithmetic. In the patch, I left out asinhl due to > its reduced input argument range, but perhaps it could be added back, > since we

Re: [PATCH, middle-end/i386]: Fix PR88502, Inline built-in asinh, acosh, atanh for -ffast-math

On Mon, 17 Dec 2018, Uros Bizjak wrote: > ... and the patch. middle-end parts are OK. > On Mon, Dec 17, 2018 at 8:58 AM Uros Bizjak wrote: > > > > Attached patch inlines calls to asinh{,f}, acosh{,f,l} and atanh{,f,l} > > using x87 XFmode arithmetic. In the patch, I left out asinhl due to > > i

Re: Implementation of F2018:18.4 C descriptors and ISO_Fortran_binding.h

Hi Paul, Your patch did not apply smoothly on my working tree: patching file gcc/configure Reversed (or previously applied) patch detected! Assume -R? [n] … patching file gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90 Hunk #1 FAILED at 5. 1 out of 2 hunks FAILED -- saving rejects to file

Re: [PATCH] avoid folding snprintf calls with bounds > INT_MAX (PR 87096)

Hi, On Thu, 13 Dec 2018 at 19:14, Jeff Law wrote: > > On 12/12/18 4:18 PM, Martin Sebor wrote: > > POSIX requires snprintf to fail with EOVERFLOW when the specified > > bound exceeds INT_MAX. This requirement conflicts with the C > > requirements on valid calls to the function and isn't universa

Re: V6 [PATCH] C/C++: Add -Waddress-of-packed-member

On Fri, Dec 14, 2018 at 11:48 PM H.J. Lu wrote: > > On Fri, Dec 14, 2018 at 2:10 PM Jason Merrill wrote: > > > > On 12/13/18 6:56 PM, H.J. Lu wrote: > > > On Thu, Dec 13, 2018 at 12:50 PM Jason Merrill wrote: > > >> > > >> On 9/25/18 11:46 AM, H.J. Lu wrote: > > >>> On Fri, Aug 31, 2018 at 2:04

Re: [PATCH] DWARF: Don't expand hash table when no insert is needed

On Sun, Dec 16, 2018 at 9:33 PM H.J. Lu wrote: > > find_slot_with_hash has > > if (insert == INSERT && m_size * 3 <= m_n_elements * 4) > expand (); > > which may expand hash table even if no insert is neeed and change hash > table traverse order. When output_macinfo_op is called, all index >

Re: [PATCH 1/6, OpenACC, libgomp] Async re-work, interfaces

On 2018/12/15 1:52 AM, Thomas Schwinge wrote: --- a/include/gomp-constants.h +++ b/include/gomp-constants.h @@ -199,7 +200,7 @@ enum gomp_map_kind /* Versions of libgomp and device-specific plugins. GOMP_VERSION should be incremented whenever an ABI-incompatible change is introduced

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

On 2018/12/14 10:56 PM, Thomas Schwinge wrote: Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: --- a/libgomp/oacc-async.c +++ b/libgomp/oacc-async.c +attribute_hidden struct goacc_asyncqueue * +lookup_goacc_asyncqueue (struct goacc_thread *thr, bool create, int async)

Re: [PATCH, og8] Add OpenACC 2.6 `serial' construct support

Hi Maciej, I don't think there's anything wrong with the patch itself; if the testcases pass, then it should implement the functionality correctly. My only issue is should "serial" really be promoted to such a visible construct in the middle-end? It's just a special case of parallel, and user deb

Re: Linux x86 unwinder: Handle __NR_sigreturn for __kernel_sigreturn support

* Florian Weimer: > I believe this may address recent unwinder failures in Fedora if the > vDSO unwinder does not contain unwinding data: > > > > The question is: Do we want to move in that direction? Or should we > make clear that the users

Re: [PATCH] [RFC] PR target/52813 and target/11807

Dimitar Dimitrov writes: > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: >> Hi, >> >> if I understood that right, then clobbering sp is and has always been >> ignored. PR77904 was about the clobber not being ignored, so the behaviour hasn't been consistent. I'm also not sure it was

Re: [PATCH v3 09/10] Ignore LLVM's blank lines.

On 12/12/2018 12:07, Rainer Orth wrote: * lib/target-supports.exp (check_effective_target_llvm_binutils): New. like "exceptions", this new effective-target keyword needs documenting in sourcebuild.texi. This patch adds the missing docs, and removes the extra blank lines. OK? Andrew

Re: [PATCH v3 10/10] Port testsuite to GCN

On 12/12/2018 11:53, Andrew Stubbs wrote: Since the previous v2 posting, the sqrt_insn additional option mechanism has been reworked. Otherwise the patch has only been rebased. This updated patch includes the missing internals documentation. OK? Andrew Port testsuite to GCN This collection

Re: V6 [PATCH] C/C++: Add -Waddress-of-packed-member

On Mon, Dec 17, 2018 at 1:39 AM Richard Biener wrote: > > On Fri, Dec 14, 2018 at 11:48 PM H.J. Lu wrote: > > > > On Fri, Dec 14, 2018 at 2:10 PM Jason Merrill wrote: > > > > > > On 12/13/18 6:56 PM, H.J. Lu wrote: > > > > On Thu, Dec 13, 2018 at 12:50 PM Jason Merrill wrote: > > > >> > > > >>

Re: [PATCH] error on missing LTO symbols

Hi, On Fri, Dec 14 2018, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >> --- /dev/null >> +++ b/libgomp/testsuite/libgomp.c-c++-common/variable-not-offloaded.c >> @@ -0,0 +1,21 @@ >> +/* { dg-do link } */ >> +/* { dg-excess-errors "lto1, mkoffload and lto-wr

Re: [PATCH] [RFC] PR target/52813 and target/11807

On Mon, 17 Dec 2018 at 12:47, Richard Sandiford wrote: > > Dimitar Dimitrov writes: > > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: > >> Hi, > >> > >> if I understood that right, then clobbering sp is and has always been > >> ignored. > > PR77904 was about the clobber not being igno

Fix buffer overflow when handling mismatched profiles

Hi, building Firefox with FDO and trunk reproduces another problem where we ICE in streamer on histogram counter being negative when it should not. I will turn this ICE into profile verification error because it may happen when profile collection was corrupted, but in this case it is caused by fact

Re: [PATCH] DWARF: Don't expand hash table when no insert is needed

On Mon, Dec 17, 2018 at 2:00 AM Richard Biener wrote: > > On Sun, Dec 16, 2018 at 9:33 PM H.J. Lu wrote: > > > > find_slot_with_hash has > > > > if (insert == INSERT && m_size * 3 <= m_n_elements * 4) > > expand (); > > > > which may expand hash table even if no insert is neeed and change ha

ping: [PATCH][GCC][AARCH64]Introduce aarch64 atomic_{load,store}ti patterns

Ping On 27/09/18 14:43, Matthew Malcomson wrote: > [PATCH][GCC][AARCH64] Introduce aarch64 atomic_{load,store}ti patterns > > In Armv8.4-a these patterns use the LDP/STP instructions that are guaranteed > to > be single-copy atomic, ensure correct memory ordering semantics by using > the DMB ins

Re: V6 [PATCH] C/C++: Add -Waddress-of-packed-member

On Mon, Dec 17, 2018 at 1:43 PM H.J. Lu wrote: > > On Mon, Dec 17, 2018 at 1:39 AM Richard Biener > wrote: > > > > On Fri, Dec 14, 2018 at 11:48 PM H.J. Lu wrote: > > > > > > On Fri, Dec 14, 2018 at 2:10 PM Jason Merrill wrote: > > > > > > > > On 12/13/18 6:56 PM, H.J. Lu wrote: > > > > > On Th

Re: [PATCH] [RFC] PR target/52813 and target/11807

Christophe Lyon writes: > On Mon, 17 Dec 2018 at 12:47, Richard Sandiford > wrote: >> >> Dimitar Dimitrov writes: >> > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: >> >> Hi, >> >> >> >> if I understood that right, then clobbering sp is and has always been >> >> ignored. >> >> PR7790

Re: [PATCH] DWARF: Don't expand hash table when no insert is needed

On Mon, Dec 17, 2018 at 2:26 PM H.J. Lu wrote: > > On Mon, Dec 17, 2018 at 2:00 AM Richard Biener > wrote: > > > > On Sun, Dec 16, 2018 at 9:33 PM H.J. Lu wrote: > > > > > > find_slot_with_hash has > > > > > > if (insert == INSERT && m_size * 3 <= m_n_elements * 4) > > > expand (); > > > >

Re: [PATCH] [RFC] PR target/52813 and target/11807

On Mon, 17 Dec 2018 at 14:35, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Mon, 17 Dec 2018 at 12:47, Richard Sandiford > > wrote: > >> > >> Dimitar Dimitrov writes: > >> > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: > >> >> Hi, > >> >> > >> >> if I understood that

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Fri, 14 Dec 2018 22:52:44 +0800, Chung-Lin Tang wrote: > On 2018/12/14 10:17 PM, Thomas Schwinge wrote: > > On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang > > wrote: > >> --- a/libgomp/oacc-async.c > >> +++ b/libgomp/oacc-async.c > > > >> +attribute_hidden struct goacc_as

Re: V6 [PATCH] C/C++: Add -Waddress-of-packed-member

On 12/17/18 7:42 AM, H.J. Lu wrote: On Mon, Dec 17, 2018 at 1:39 AM Richard Biener wrote: On Fri, Dec 14, 2018 at 11:48 PM H.J. Lu wrote: On Fri, Dec 14, 2018 at 2:10 PM Jason Merrill wrote: On 12/13/18 6:56 PM, H.J. Lu wrote: On Thu, Dec 13, 2018 at 12:50 PM Jason Merrill wrote: On

Re: [ping] Change static chain to r11 on aarch64

Hi Hans-Peter, > While the choice of static-chain register does not affect the > ABI, it's the other way round: the choice of static-chain > register matters, specifically it's call-clobberedness. Agreed. > It looks like the current aarch64 static-chain register R18 is > call-saved but without s

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Fri, 14 Dec 2018 22:42:28 +0800, Chung-Lin Tang wrote: > On 2018/12/14 10:32 PM, Thomas Schwinge wrote: > > Invoked as "acc_wait_async ([...], acc_async_sync)" (as used in a test > > case that I'll soon submit/commit), we'll end up with "aq2 == NULL", and > > will segfault in th

Re: [PATCH] [RFC] PR target/52813 and target/11807

On 12/17/18 2:42 PM, Christophe Lyon wrote: > On Mon, 17 Dec 2018 at 14:35, Richard Sandiford > wrote: >> >> Christophe Lyon writes: >>> On Mon, 17 Dec 2018 at 12:47, Richard Sandiford >>> wrote: Dimitar Dimitrov writes: > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote:

Re: [PATCH] error on missing LTO symbols

On 17-12-18 13:46, Martin Jambor wrote: > Hi, > > On Fri, Dec 14 2018, Jakub Jelinek wrote: >> On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >>> --- /dev/null >>> +++ b/libgomp/testsuite/libgomp.c-c++-common/variable-not-offloaded.c >>> @@ -0,0 +1,21 @@ >>> +/* { dg-do link } */ >>

Re: [PATCH] [RFC] PR target/52813 and target/11807

On 12/17/18 2:35 PM, Richard Sandiford wrote: > Christophe Lyon writes: >> On Mon, 17 Dec 2018 at 12:47, Richard Sandiford >> wrote: >>> >>> Dimitar Dimitrov writes: On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: > Hi, > > if I understood that right, then clobbering s

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Fri, 14 Dec 2018 23:00:57 +0800, Chung-Lin Tang wrote: > On 2018/12/14 10:53 PM, Thomas Schwinge wrote: > > Please comment on the one TODO > > which before your async re-work also was -- incorrectly? -- run > > asynchronously? > > @@ -563,6 +563,8 @@ GOACC_update (int device, s

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Mon, 17 Dec 2018 19:03:12 +0800, Chung-Lin Tang wrote: > On 2018/12/14 10:56 PM, Thomas Schwinge wrote: > > + //TODO Are these safe to call, or might this cause deadlock if > > something's locked? > > CUDA_CALL_ASSERT (cuEventCreate, &e, CU_EVENT_DISABLE_TIMING); > > C

[PATCH] AIX extra_headers

Currently the AIX configuration defines extra_headers to install some PowerPC-specific headers, such as altivec.h. The GCC configuration for Power was changed to define this centrally and the individual definitions for Linux were removed, but remained for AIX. This means that AIX overrides the com

Re: [PATCH] [RFC] PR target/52813 and target/11807

On Sun, Dec 16, 2018 at 10:43:47AM +0200, Dimitar Dimitrov wrote: > On Fri, Dec 14 2018 2:52:17 EET Segher Boessenkool wrote: > > You need a few tweaks to what you committed. Or just one perhaps: if > > flag_pic is not set, you should not check PIC_OFFSET_TABLE_REGNUM, it is > > meaningless in tha

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

On 16/12/2018 22:45, Uecker, Martin wrote: > Am Sonntag, den 16.12.2018, 09:13 -0700 schrieb Jeff Law: >> Ultimately using function descriptors is an ABI breaking choice and we >> might declare that function descriptors imply higher function >> alignments.   > > Increasing the alignment is not an

Re: [PATCH, OpenACC] Properly handle wait clause with no arguments

Hi Chung-Lin! On Tue, 27 Nov 2018 22:41:54 +0800, Chung-Lin Tang wrote: > On 2018/11/8 3:13 AM, Thomas Schwinge wrote: > > Now, why do we need the following changes, in this rather "convoluted" > > form: > |--- gcc/omp-expand.c (revision 263981) |+++ gcc/omp-expand.c (workin

[PATCH] PR c++/52321 print note for static_cast to/from incomplete type

If build_static_cast_1 returns false, and one or both type is a pointer/reference to an incomplete class, print a note saying so. This doesn't attempt to check whether the static_cast failed because the type is incomplete (which was checked inside build_static_cast_1 but not in the caller). It jus

[PATCH v2, middle-end/i386]: Fix PR88502, Inline built-in asinh, acosh, atanh for -ffast-math

On Mon, Dec 17, 2018 at 9:26 AM Richard Biener wrote: > > On Mon, 17 Dec 2018, Uros Bizjak wrote: > > > ... and the patch. > > middle-end parts are OK. > > > On Mon, Dec 17, 2018 at 8:58 AM Uros Bizjak wrote: > > > > > > Attached patch inlines calls to asinh{,f}, acosh{,f,l} and atanh{,f,l} > > >

Re: [PATCH] [RFC] PR target/52813 and target/11807

On Mon, Dec 17, 2018 at 11:47:42AM +, Richard Sandiford wrote: > Dimitar Dimitrov writes: > > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: > >> Hi, > >> > >> if I understood that right, then clobbering sp is and has always been > >> ignored. > > PR77904 was about the clobber not

[arm][RFC] PR target/88469 fix incorrect argument passing with 64-bit bitfields

Unfortunately another PCS bug has come to light with the layout of structs whose alignment is dominated by a 64-bit bitfield element. Such fields in the type list appear to have alignment 1, but in reality, for the purposes of alignment of the underlying structure, the alignment is derived from th

Re: [patch] Fix bootstrap powerpc*-*-freebsd* targets

Hi! On Mon, Dec 17, 2018 at 10:40:01AM +1030, Alan Modra wrote: > Since I broke powerpc*-freebsd and the other non-linux powerpc > targets, I guess I ought to fix them. The following is a variation on > your first patch, that results in -mcall-linux for powerpc-freebsd* > providing the 32-bit pow

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

On 12/16/18 3:45 PM, Uecker, Martin wrote: > Am Sonntag, den 16.12.2018, 09:13 -0700 schrieb Jeff Law: >> On 12/16/18 6:45 AM, Uecker, Martin wrote: >>> Am Freitag, den 14.12.2018, 18:20 -0700 schrieb Martin Sebor: On 12/14/18 4:36 PM, Jeff Law wrote: > On 12/14/18 3:05 AM, Uecker, Martin

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

On 12/16/18 6:45 AM, Uecker, Martin wrote: Am Freitag, den 14.12.2018, 18:20 -0700 schrieb Martin Sebor: On 12/14/18 4:36 PM, Jeff Law wrote: On 12/14/18 3:05 AM, Uecker, Martin wrote: Am Donnerstag, den 13.12.2018, 16:35 -0700 schrieb Jeff Law: On 12/12/18 11:12 AM, Uecker, Martin wrote:

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

Hi Chung-Lin! On Fri, 14 Dec 2018 22:28:58 +0800, Chung-Lin Tang wrote: > On 2018/12/13 11:51 PM, Thomas Schwinge wrote: > > On Thu, 13 Dec 2018 23:28:49 +0800, Chung-Lin > > Tang wrote: > >> On 2018/12/7 6:26 AM, Julian Brown wrote: > >>> On Thu, 6 Dec 2018 22:22:46 + > >>> Julian Brown

Re: [PATCH] PR fortran 88116,88467 -- Catch array constructor errors

On Sun, Dec 16, 2018 at 07:46:45AM -0800, Steve Kargl wrote: > On Sun, Dec 16, 2018 at 11:45:11AM +0100, Dominique d'Humières wrote: > > Hi Steve, > > > > The patch works as expected. > > > > Is "Can\’t " instead of "Can’t " really necessary? > > > > I don't remember how dejagnu handles quotes

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

Am Montag, den 17.12.2018, 10:28 -0700 schrieb Jeff Law: > On 12/16/18 3:45 PM, Uecker, Martin wrote: > > Am Sonntag, den 16.12.2018, 09:13 -0700 schrieb Jeff Law: > > > On 12/16/18 6:45 AM, Uecker, Martin wrote: > > > > Am Freitag, den 14.12.2018, 18:20 -0700 schrieb Martin Sebor: > > > > > On 12/

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

Am Montag, den 17.12.2018, 10:31 -0700 schrieb Martin Sebor: > On 12/16/18 6:45 AM, Uecker, Martin wrote: > > Am Freitag, den 14.12.2018, 18:20 -0700 schrieb Martin Sebor: > > > On 12/14/18 4:36 PM, Jeff Law wrote: > > > > On 12/14/18 3:05 AM, Uecker, Martin wrote: > > > > > > > > > > Am Donnersta

Re: [arm][RFC] PR target/88469 fix incorrect argument passing with 64-bit bitfields

Hi, > Unfortunately another PCS bug has come to light with the layout of > structs whose alignment is dominated by a 64-bit bitfield element. Such > fields in the type list appear to have alignment 1, but in reality, for > the purposes of alignment of the underlying structure, the alignment is >

Re: [PATCH] avoid folding snprintf calls with bounds > INT_MAX (PR 87096)

On 12/17/18 2:23 AM, Christophe Lyon wrote: Hi, On Thu, 13 Dec 2018 at 19:14, Jeff Law wrote: On 12/12/18 4:18 PM, Martin Sebor wrote: POSIX requires snprintf to fail with EOVERFLOW when the specified bound exceeds INT_MAX. This requirement conflicts with the C requirements on valid calls t

Re: [PATCH] AIX extra_headers

On Mon, Dec 17, 2018 at 10:07:30AM -0500, David Edelsohn wrote: > Currently the AIX configuration defines extra_headers to install some > PowerPC-specific headers, such as altivec.h. The GCC configuration for > Power was changed to define this centrally and the individual > definitions for Linux we

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

Am Montag, den 17.12.2018, 15:25 + schrieb Szabolcs Nagy: > On 16/12/2018 22:45, Uecker, Martin wrote: > > Am Sonntag, den 16.12.2018, 09:13 -0700 schrieb Jeff Law: > > > Ultimately using function descriptors is an ABI breaking choice and we > > > might declare that function descriptors imply h

[PATCH, d] Committed merge with upstream dmd

Hi, This patch merges the D front-end implementation with dmd upstream 237ca3fbe. Backports a fix where a bad cast to TypeFunction resulted in memory corruption. The logic in the function semantic has been fixed, and casts have been replaced with a function call to always check the front-end AST

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

On Dez 17 2018, "Uecker, Martin" wrote: > Am Montag, den 17.12.2018, 10:28 -0700 schrieb Jeff Law: >> On 12/16/18 3:45 PM, Uecker, Martin wrote: >> > But most architectures require a higher alignment anyway. >> > Here is a list of all targets where function alignment >> > is 1 byte: >> > >> > gc

Re: [PATCH] [RFC] PR target/52813 and target/11807

Segher Boessenkool writes: > On Mon, Dec 17, 2018 at 11:47:42AM +, Richard Sandiford wrote: >> Dimitar Dimitrov writes: >> > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: >> >> Hi, >> >> >> >> if I understood that right, then clobbering sp is and has always been >> >> ignored. >>

Patch ping (was Re: [C++ PATCH] Fix ICE with offsetof-like initializer (PR c++/88410))

Hi! On Sun, Dec 09, 2018 at 12:05:06PM +0100, Jakub Jelinek wrote: > The following testcase ICEs starting with my change to move offsetof-like > expression handling from the parsing to cp_fold - if the base expression > is not INTEGER_CST, but a constant VAR_DECL initialized with INTEGER_CST, > th

[PATCH][GCC][AArch64] Fix command line options canonicalization. (PR target/88530)

Hi All, The options don't seem to get canonicalized into the smallest possible set before output to the assembler. This means that overlapping feature sets are emitted with superfluous parts. Normally this isn't an issue, but in the case of crypto we have retro-actively split it into aes and sha2

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

On 17/12/2018 18:22, Uecker, Martin wrote: > Am Montag, den 17.12.2018, 15:25 + schrieb Szabolcs Nagy: >> On 16/12/2018 22:45, Uecker, Martin wrote: >>> Am Sonntag, den 16.12.2018, 09:13 -0700 schrieb Jeff Law: Ultimately using function descriptors is an ABI breaking choice and we mig

Re: [PATCH] v5: C++: more location wrapper nodes (PR c++/43064, PR c++/43486)

On 12/14/18 7:17 PM, David Malcolm wrote: + /* Since default args are effectively part of the function type, +strip location wrappers here, since otherwise the location of +one function's default arguments is arbitrarily chosen for +all functions with similar signatur

Re: [PATCH] [RFC] PR target/52813 and target/11807

On 12/17/18 7:46 PM, Richard Sandiford wrote: > Segher Boessenkool writes: >> On Mon, Dec 17, 2018 at 11:47:42AM +, Richard Sandiford wrote: >>> Dimitar Dimitrov writes: On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: > Hi, > > if I understood that right, then clobb

Re: [PATCH][RS6000] Fix PR87870: ppc64 generates poor code when loading constants into TImode vars

On 12/14/18 8:23 PM, Segher Boessenkool wrote: > On Thu, Dec 13, 2018 at 10:59:36AM -0600, Peter Bergner wrote: >> For the alternatives >> I'm changing, we're loading into GPR regs and these alternatives are always >> split (split2), so these length values are never used/seen at final assembly >> t

Ping: [PATCH 0/4] c/c++, asm: Various updates

Ping? On Mon, Dec 10, 2018 at 10:47:23PM +, Segher Boessenkool wrote: > This ties up some loose ends, and adds some more testcases. > > Tested on powerpc64-linux {-m32,-m64}. Is this okay for trunk? > > > Segher > > > Segher Boessenkool (4): > c/c++, asm: Write the asm-qualifier loop w

Re: [PATCH] C/C++: don't suggest decls that are being initialized (PR c++/88320)

On 12/5/18 4:29 PM, David Malcolm wrote: diff --git a/gcc/cp/parser.h b/gcc/cp/parser.h index 8bfa3f3..8f389e4 100644 --- a/gcc/cp/parser.h +++ b/gcc/cp/parser.h @@ -405,6 +405,15 @@ struct GTY(()) cp_parser { specification, if any, or UNKNOWN_LOCATION otherwise. */ location_t innermo

Re: [PATCH] PR c++/52321 print note for static_cast to/from incomplete type

On 12/17/18 10:37 AM, Jonathan Wakely wrote: If build_static_cast_1 returns false, and one or both type is a pointer/reference to an incomplete class, print a note saying so. This doesn't attempt to check whether the static_cast failed because the type is incomplete (which was checked inside buil

Re: [C++ PATCH] Fix ICE with offsetof-like initializer (PR c++/88410)

On 12/9/18 6:05 AM, Jakub Jelinek wrote: Hi! The following testcase ICEs starting with my change to move offsetof-like expression handling from the parsing to cp_fold - if the base expression is not INTEGER_CST, but a constant VAR_DECL initialized with INTEGER_CST, then we don't fold it as offse

Re: [PATCH 2/9]: C++ P0482R5 char8_t: Core language support

On 12/5/18 11:16 AM, Jason Merrill wrote: On 12/5/18 2:09 AM, Tom Honermann wrote: On 12/3/18 5:01 PM, Jason Merrill wrote: On 12/3/18 4:51 PM, Jason Merrill wrote: On 11/5/18 2:39 PM, Tom Honermann wrote: This patch adds support for the P0482R5 core language changes. This includes: - The -

[nvptx, committed] Rewrite nvptx_goacc_validate_dims to use predicate vars

[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0023-nvptx-Force-vl32-if-calling-vector-partitionable-rou.patch I've factored out this cleanup patch from here. Committed to trunk. Thanks, - Tom [nvptx] Rewrite nvptx_goacc_validate_dims to use predicate v

[nvptx, committed] Unify C/Fortran routine handling in nvptx_goacc_validate_dims

[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: >> 0004-openacc-Make-GFC-default-to-1-for-OpenACC-routine-di.patch > If I remove this, I run into ICEs in the compiler, but I think that > means we need to understand and fix that ICE, instead of concluding that

Re: [PATCH 2/9]: C++ P0482R5 char8_t: Core language support

On 12/17/18 4:02 PM, Jason Merrill wrote: On 12/5/18 11:16 AM, Jason Merrill wrote: On 12/5/18 2:09 AM, Tom Honermann wrote: On 12/3/18 5:01 PM, Jason Merrill wrote: On 12/3/18 4:51 PM, Jason Merrill wrote: On 11/5/18 2:39 PM, Tom Honermann wrote: This patch adds support for the P0482R5 core

Re: [nvptx] vector length patch series

On 14-12-18 20:58, Tom de Vries wrote: > 0009-nvptx-Fix-whitespace-in-nvptx_single-and-nvptx_neute.patch Committed (Could have been committed as obvious). Thanks, - Tom [nvptx] Fix whitespace in nvptx_single and nvptx_neuter_pars Fix whitespace in nvptx_single and nvptx_neuter_pars. Build and r

[nvptx, committed] Add PTX_WARP_SIZE

[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0005-nvptx-update-openacc-dim-macros.patch Factored out this patch. Committed. Thanks, - Tom [nvptx] Add PTX_WARP_SIZE Add PTX_WARP_SIZE constant and use it in nvptx_simt_vf. The function nvptx_simt_vf is

[nvptx, committed] Move macro defs to top of nvptx.c

[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0005-nvptx-update-openacc-dim-macros.patch Factored out this patch. Committed. Thanks, - Tom [nvptx] Move macro defs to top of nvptx.c Move macro definition to the top of the file, allowing them to be used

[PATCH, rs6000] Clarify when typedef names can be used with AltiVec vector types

Hi, We recently discovered some incorrect documentation about this topic and agreed it should be changed. This is my attempt to clarify it. Built and verified on powerpc64le-linux-gnu. Is this ok for trunk? Thanks, Bill 2018-12-17 Bill Schmidt * doc/extend.texi (PowerPC Altivec/

Re: [PATCH][RS6000] Fix PR87870: ppc64 generates poor code when loading constants into TImode vars

On Mon, Dec 17, 2018 at 02:23:54PM -0600, Peter Bergner wrote: > On 12/14/18 8:23 PM, Segher Boessenkool wrote: > > On Thu, Dec 13, 2018 at 10:59:36AM -0600, Peter Bergner wrote: > >> For the alternatives > >> I'm changing, we're loading into GPR regs and these alternatives are always > >> split (s

Re: [PATCH, V2, d] Fix IdentityExp comparison for complex floats

On Wed, 28 Nov 2018 at 23:46, Iain Buclaw wrote: > > On Wed, 28 Nov 2018 at 22:32, Johannes Pfau wrote: > > > > Next version, addresses the review comments. > > > > Tested at https://github.com/D-Programming-GDC/GDC/pull/768 > > --- > > gcc/d/ChangeLog: > > > > 2018-11-28 Johannes Pfau > > > >

Re: [PATCH][RS6000] Fix PR87870: ppc64 generates poor code when loading constants into TImode vars

On 12/17/18 3:55 PM, Segher Boessenkool wrote: > On Mon, Dec 17, 2018 at 02:23:54PM -0600, Peter Bergner wrote: >> This means we require the insn to eventually be split and not reach final >> assembly, does it not? > > Yes, but is the length attribute used for something that matters before > that?

[PATCH] Fix AVX512VL gather ICEs (PR target/88513, PR target/88514)

Hi! Some of the following testcases ICE, because I was assuming that VEC_UNPACK_{LO,HI}_EXPR and VEC_PACK_TRUNC_EXPR just work on the VECTOR_BOOLEAN_TYPE_P mask types that AVX512* has (with scalar modes), but they really only work if the wider mode is different from the narrower one, so e.g. one c

Re: [PATCH] PR libstdc++/71044 optimize std::filesystem::path construction

On 13/12/18 20:34 +, Jonathan Wakely wrote: Construction and modification of paths is now done more efficiently, by splitting the input into a stack-based buffer of string_view objects instead of a dynamically-allocated vector containing strings. Once the final size is known only

Re: [PATCH] v5: C++: more location wrapper nodes (PR c++/43064, PR c++/43486)

On Mon, 2018-12-17 at 14:33 -0500, Jason Merrill wrote: > On 12/14/18 7:17 PM, David Malcolm wrote: > > + /* Since default args are effectively part of the function > > type, > > +strip location wrappers here, since otherwise the > > location of > > +one function's default arguments is

[nvptx] vector length patch series -- openacc parts

On 14-12-18 20:58, Tom de Vries wrote: > 0003-openacc-Add-target-hook-TARGET_GOACC_ADJUST_PARALLEL.patch > 0017-nvptx-Enable-large-vectors.patch > 0023-nvptx-Force-vl32-if-calling-vector-partitionable-rou.patch Thomas, these patches are openacc (0003) or have openacc components (0017, 0023).

Re: [patch] Fix bootstrap powerpc*-*-freebsd* targets

On Mon, Dec 17, 2018 at 11:05:57AM -0600, Segher Boessenkool wrote: > Hi! > > On Mon, Dec 17, 2018 at 10:40:01AM +1030, Alan Modra wrote: > > Since I broke powerpc*-freebsd and the other non-linux powerpc > > targets, I guess I ought to fix them. The following is a variation on > > your first pat

Re: [ping] Change static chain to r11 on aarch64

On Mon, 17 Dec 2018, Wilco Dijkstra wrote: > H-P: > > So, changing from R18 to R11 for aarch64 seems right, as the > > latter is call-clobbered and the former is call-saved IIUC. > > The AArch64 ABI defines x18 as platform specific: > http://infocenter.arm.com/help/topic/com.arm.doc.ihi0055b/IHI005

Re: [ping] Change static chain to r11 on aarch64

On Mon, 17 Dec 2018, Hans-Peter Nilsson wrote: > On Mon, 17 Dec 2018, Wilco Dijkstra wrote: > > H-P: > > > So, changing from R18 to R11 for aarch64 seems right, as the > > > latter is call-clobbered and the former is call-saved IIUC. > > > > The AArch64 ABI defines x18 as platform specific: > > htt

Re: [C++ Patch] PR 71140 ("[concepts] ill-formed nested-requirement lacking a semicolon not rejected")

On Wed, Oct 31, 2018 at 2:34 PM Andrew Sutton wrote: > > Sorry for the slow reply. I've been stuck working on some other projects. >> >> Can you say a bit about why that was better than continuing to use VAR_DECL? > > I wanted to make sure that we avoid normal VAR_DECL processing routines, so > w

Re: [PATCH] Fix AVX512VL gather ICEs (PR target/88513, PR target/88514)

On Mon, Dec 17, 2018 at 11:37 PM Jakub Jelinek wrote: > > Hi! > > Some of the following testcases ICE, because I was assuming that > VEC_UNPACK_{LO,HI}_EXPR and VEC_PACK_TRUNC_EXPR just work on the > VECTOR_BOOLEAN_TYPE_P mask types that AVX512* has (with scalar modes), > but they really only work