Re: [patch] Add baseline for SPARC64/Linux

2019-02-21 Thread Eric Botcazou
> 2019-02-20 Eric Botcazou > > * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux. > * config/abi/post/sparc64-linux-gnu: New directory. > * config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file. > * config/abi/post/sparc64-linux-gnu/32:

[C++ PATCH] PR c++/87685 - generic lambda 'this' capture error.

2019-02-21 Thread Jason Merrill
The standard says that in a generic lambda we should speculatively capture 'this' if we see a call to an overload set that contains a non-static member function, but it seems wrong to reject the program if we can't capture, since it might not actually be needed. Tested x86_64-pc-linux-gnu,

Re: [PR fortran/83057, patch] - OPEN without a filename and without STATUS='SCRATCH' could produce a warning

2019-02-21 Thread Jerry DeLisle
On 2/20/19 2:34 PM, Harald Anlauf wrote: There was a rather obvious bug in the logic for checking the arguments to the OPEN statement when NEWUNIT= was specified, which prohibited the generation of the appropriate error message. Regtested successfully. OK for trunk? Yes and thanks for patch.

Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-21 Thread Mike Stump
On Feb 21, 2019, at 4:09 PM, James Greenhalgh wrote: > >> NOTE: I have included a bunch of RTL testcases that I used in development, >> these >> don't exercise much of the compiler and are pretty specific to the backend >> as it >> currently is, so I'm not sure they give much value. I'd

[C++ PATCH] PR c++/88394 - ICE with VLA init-capture.

2019-02-21 Thread Jason Merrill
We mostly use is_normal_capture_proxy to decide whether or not to use DECL_CAPTURED_VARIABLE; we could just check whether it's set. VLA capture is still mostly broken, but this fixes this ICE. Tested x86_64-pc-linux-gnu, applying to trunk. * lambda.c (is_normal_capture_proxy): Check

Re: [PATCH 11/25] Simplify vec_merge according to the mask.

2019-02-21 Thread H.J. Lu
On Fri, Sep 28, 2018 at 6:33 AM Andrew Stubbs wrote: > > On 28/09/18 09:11, Richard Sandiford wrote: > > Yes, thanks. > > Committed. > > Thanks for all the reviews. :-) > This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89445 -- H.J.

[C++ PATCH] PR c++/88869 - C++17 ICE with CTAD and explicit specialization.

2019-02-21 Thread Jason Merrill
The members of an explicit specialization of a class template don't have the template parameters of that class template, so we shouldn't try to provide arguments for them. Only set outer_args when the class is an instantiation. Tested x86_64-pc-linux-gnu, applying to trunk. * pt.c

Re: [PATCH] avoid -Wabsolute-value in dead subexpressions (PR 89425)

2019-02-21 Thread Joseph Myers
On Thu, 21 Feb 2019, Martin Sebor wrote: > Joseph noticed the -Wabsolute-value warning newly introduced in GCC > 9 and included in -Wextra triggers on some unreachable subexpressions > in Glibc code that the C front end otherwise makes an effort to avoid > diagnosing. The attached trivial patch

Re: C++ PATCH for c++/89420 - ICE with CAST_EXPR in explicit-specifier

2019-02-21 Thread Jason Merrill
On 2/21/19 1:35 PM, Marek Polacek wrote: We were ICEing because we called build_converted_constant_expr on an expression that wasn't value-dependent, but it still contained template codes, and that didn't work too well because check_narrowing calls maybe_constant_value. Hmm, I'm concerned

Re: [committed] Fix -Wmissing-attributes warning in libstdc++ (PR libstdc++/89402)

2019-02-21 Thread Jonathan Wakely
On 22/02/19 02:23 +0100, Jakub Jelinek wrote: On Fri, Feb 22, 2019 at 01:10:32AM +, Jonathan Wakely wrote: On 20/02/19 09:07 +0100, Jakub Jelinek wrote: > Hi! > > The following patch fixes a warning when building on targets where long > double switched from being the same as double to

Re: [committed] Fix -Wmissing-attributes warning in libstdc++ (PR libstdc++/89402)

2019-02-21 Thread Jakub Jelinek
On Fri, Feb 22, 2019 at 01:10:32AM +, Jonathan Wakely wrote: > On 20/02/19 09:07 +0100, Jakub Jelinek wrote: > > Hi! > > > > The following patch fixes a warning when building on targets where long > > double switched from being the same as double to something wider, > > like e.g.

Re: [PATCH 9/9]: C++ P0482R5 char8_t: Updates to gdb pretty printing support

2019-02-21 Thread Jonathan Wakely
On 05/11/18 14:40 -0500, Tom Honermann wrote: This patch adds recognition of the u8string and u8string_view type aliases to the gdb pretty printer extension. libstdc++-v3/ChangeLog: 2018-11-04 Tom Honermann * python/libstdcxx/v6/printers.py (register_type_printers): Add type

Re: [PATCH 8/9]: C++ P0482R5 char8_t: Updates to existing standard library tests

2019-02-21 Thread Jonathan Wakely
On 22/02/19 01:19 +, Jonathan Wakely wrote: On 05/11/18 14:40 -0500, Tom Honermann wrote: This patch augments existing tests to validate behavior for char8_t. In all cases, added test cases are cloned from existing tests for wchar_t or char16_t. A few tests required updates to line

Re: [PATCH 8/9]: C++ P0482R5 char8_t: Updates to existing standard library tests

2019-02-21 Thread Jonathan Wakely
On 05/11/18 14:40 -0500, Tom Honermann wrote: This patch augments existing tests to validate behavior for char8_t. In all cases, added test cases are cloned from existing tests for wchar_t or char16_t. A few tests required updates to line numbers for diagnostic messages. I had to make a

Re: [PATCH 6/9]: C++ P0482R5 char8_t: A small correction to a common testsuite header file

2019-02-21 Thread Jonathan Wakely
On 05/11/18 14:40 -0500, Tom Honermann wrote: This patch corrects ambiguous partial specializations of typelist::detail::append_. Previously, neither append_, Typelist_Chain> nor append_ was a better match for append_, null_type>. libstdc++-v3/ChangeLog: 2018-11-04 Tom Honermann *

Re: [committed] Fix -Wmissing-attributes warning in libstdc++ (PR libstdc++/89402)

2019-02-21 Thread Jonathan Wakely
On 20/02/19 09:07 +0100, Jakub Jelinek wrote: Hi! The following patch fixes a warning when building on targets where long double switched from being the same as double to something wider, like e.g. powerpc*-linux, alpha*-linux, s390*-linux etc. Fixed thusly, bootstrapped/regtested on

Re: C++ PATCH for c++/88294 - ICE with non-constant noexcept-specifier

2019-02-21 Thread Jason Merrill
On 2/21/19 1:34 PM, Marek Polacek wrote: On Thu, Feb 21, 2019 at 11:22:41AM -1000, Jason Merrill wrote: On 2/21/19 10:56 AM, Marek Polacek wrote: On Wed, Feb 20, 2019 at 01:53:18PM -1000, Jason Merrill wrote: On 2/20/19 10:31 AM, Marek Polacek wrote: Here we ICE when substituting a deferred

アラート:別のデバイスからログインしたApple IDログイン.

2019-02-21 Thread Apple Support
親愛なるCIient、gcc-patches@gcc.gnu.org セキュリティ上の理由から、Apple IDはロックされています。 誰かが新しいデバイスであなたのApple IDを悩ませました 日付:2019年2月22日、 ブラウザ:Chrome オペレーティングシステム:Windows AppleのIDを引き続き使用するには、アカウントを確認する必要があります。 確認するにはここをクリック

libgo patch committed: Remove unixgram test sockets

2019-02-21 Thread Ian Lance Taylor
This libgo patch changes the net package tests to remove unixgram test sockets after they are used. This is for PR 89406. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

libgo patch committed: remove work directory on usage error

2019-02-21 Thread Ian Lance Taylor
This libgo patch changes the go tool to remove the work directory on a usage error. We ensure that cmd/go consistently calls base.Exit rather than os.Exit, so that we don't incorrectly leave the work directory around on exit. This is tested by modifying the testsuite to run all the tests with

Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-21 Thread James Greenhalgh
On Mon, Feb 18, 2019 at 08:40:12AM -0600, Matthew Malcomson wrote: > Handle stack pointer with SUBS/ADDS instructions. > > In general the stack pointer was not handled for many SUBS/ADDS patterns in > aarch64.md. > Both the "extended register" and "immediate" forms allow the stack pointer to >

C++ PATCH for c++/89420 - ICE with CAST_EXPR in explicit-specifier

2019-02-21 Thread Marek Polacek
We were ICEing because we called build_converted_constant_expr on an expression that wasn't value-dependent, but it still contained template codes, and that didn't work too well because check_narrowing calls maybe_constant_value. The fix is to instantiate the expression before converting it. I

Re: C++ PATCH for c++/88294 - ICE with non-constant noexcept-specifier

2019-02-21 Thread Marek Polacek
On Thu, Feb 21, 2019 at 11:22:41AM -1000, Jason Merrill wrote: > On 2/21/19 10:56 AM, Marek Polacek wrote: > > On Wed, Feb 20, 2019 at 01:53:18PM -1000, Jason Merrill wrote: > > > On 2/20/19 10:31 AM, Marek Polacek wrote: > > > > Here we ICE when substituting a deferred noexcept-specifier, because

Re: [PATCH] x86: (Reapply) Move AESNI generation to Skylake and Goldmont

2019-02-21 Thread H.J. Lu
On Thu, Feb 21, 2019 at 3:10 PM Thiago Macieira wrote: > > This is a repeat of commit r263989, which commit r264052 accidentally > reverted. > > Original commit message: > > The instruction set first appeared with Westmere, but not all processors > in that and the next few generations have the

[PATCH] x86: (Reapply) Move AESNI generation to Skylake and Goldmont

2019-02-21 Thread Thiago Macieira
This is a repeat of commit r263989, which commit r264052 accidentally reverted. Original commit message: The instruction set first appeared with Westmere, but not all processors in that and the next few generations have the instructions. According to Wikipedia[1], the first generation in which

[C++ PATCH] PR c++/89422 - ICE with -g and lambda in default arg in template.

2019-02-21 Thread Jason Merrill
Here, we were trying to instantiate the default argument before setting DECL_FRIEND_CONTEXT, so that the instantiated lambda ended up being treated as part of the S template, which confused dwarf2out. Tested x86_64-pc-linux-gnu, applying to trunk. * pt.c (tsubst_function_decl):

[C++ PATCH] PR c++/88419 - C++17 ICE with class template arg deduction.

2019-02-21 Thread Jason Merrill
Just like in make_constrained_auto, we need to defer setting TYPE_CANONICAL until we've set fields that will affect structural_comptypes. Tested x86_64-pc-linux-gnu, applying to trunk. * pt.c (make_template_placeholder): Set TYPE_CANONICAL after CLASS_PLACEHOLDER_TEMPLATE. ---

[PATCH] avoid -Wabsolute-value in dead subexpressions (PR 89425)

2019-02-21 Thread Martin Sebor
Joseph noticed the -Wabsolute-value warning newly introduced in GCC 9 and included in -Wextra triggers on some unreachable subexpressions in Glibc code that the C front end otherwise makes an effort to avoid diagnosing. The attached trivial patch guards the warning to avoid these spurious

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-21 Thread Martin Sebor
On 2/21/19 3:42 PM, Jeff Law wrote: On 2/21/19 3:39 PM, Martin Sebor wrote: On 2/21/19 1:27 PM, Jeff Law wrote: On 2/21/19 1:12 PM, Martin Sebor wrote: On 2/21/19 12:08 PM, Jeff Law wrote: On 2/18/19 7:53 PM, Martin Sebor wrote: Please let me know what it will take to get the fix for these

Re: Patch RFC: Avoid recursive insert into const_desc_htab

2019-02-21 Thread Ian Lance Taylor
On Thu, Feb 21, 2019 at 1:57 AM Richard Biener wrote: > > On Wed, Feb 20, 2019 at 6:53 PM Ian Lance Taylor wrote: > > > > The underlying cause of PR 89170 is a bug that appears to have existed > > since 2001, when the function decode_addr_const was changed to call > > output_constant_def. The

Re: [PATCH, GCC, AArch64] Fix a couple of bugs in BTI

2019-02-21 Thread James Greenhalgh
On Thu, Feb 21, 2019 at 06:19:10AM -0600, Sudakshina Das wrote: > Hi > > While doing more testing I found a couple of issues with my BTI patches. > This patch fixes them: > 1) Remove a reference to return address key. The original patch was > written based on a different not yet committed patch

Re: [PATCH 1/2][GCC][AArch64] Update Armv8.4-a's FP16 FML intrinsics

2019-02-21 Thread James Greenhalgh
On Wed, Feb 20, 2019 at 08:00:13AM -0600, Tamar Christina wrote: > Hi All, > > This patch updates the Armv8.4-a FP16 FML intrinsics's suffixes from u32 to > f16 > to be more consistent with the naming convention for intrinsics. > > The specifications for these intrinsics have not been published

Re: [PATCH][AArch64] Add support for Neoverse E1

2019-02-21 Thread James Greenhalgh
On Thu, Feb 21, 2019 at 11:43:08AM -0600, Kyrill Tkachov wrote: > Hi all, > > This patch adds -mcpu and -mtune support for the Neoverse E1 CPU [1]. > The new option is -mcpu=neoverse-e1. > Bootstrapped and tested on aarch64-none-linux-gnu. OK. Thanks, James > [1] >

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-21 Thread Jeff Law
On 2/21/19 3:39 PM, Martin Sebor wrote: > On 2/21/19 1:27 PM, Jeff Law wrote: >> On 2/21/19 1:12 PM, Martin Sebor wrote: >>> On 2/21/19 12:08 PM, Jeff Law wrote: On 2/18/19 7:53 PM, Martin Sebor wrote: > Please let me know what it will take to get the fix for these two > issues

Re: [PATCH][AArch64] Add support for Neoverse N1

2019-02-21 Thread James Greenhalgh
On Thu, Feb 21, 2019 at 11:42:56AM -0600, Kyrill Tkachov wrote: > Hi all, > > This patch adds support for the Neoverse N1 CPU [1]. This was supported > in GCC earlier through the codename Ares, > which it now replaces. -mcpu=ares is still accepted as there's been a > binutils release supporting

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-21 Thread Martin Sebor
On 2/21/19 1:27 PM, Jeff Law wrote: On 2/21/19 1:12 PM, Martin Sebor wrote: On 2/21/19 12:08 PM, Jeff Law wrote: On 2/18/19 7:53 PM, Martin Sebor wrote: Please let me know what it will take to get the fix for these two issues approved.  I've answered the questions so I don't know what else

Re: [PATCH][GCC][AArch64] Fix command line options canonicalization version #2. (PR target/88530)

2019-02-21 Thread James Greenhalgh
On Wed, Feb 20, 2019 at 08:00:38AM -0600, Tamar Christina wrote: > Hi All, > > Commandline options on AArch64 don't get canonicalized into the smallest > possible set before output to the assembler. This means that overlapping > feature > sets are emitted with superfluous parts. > > Normally

Re: [PATCH, testsuite] Enable vect_usad_char effective target for PowerPC and fix up SAD_EXPR testcases

2019-02-21 Thread Jeff Law
On 2/19/19 2:07 PM, Pat Haugen wrote: > Power9 added support for V16QImode SAD operations. While making the > check_effective_target change I noticed that the tests will also pass on > Power7/Power8 even though they don't have the optab support. The reason is > the tests are only checking that

Re: [PATCH] Fix PR89437

2019-02-21 Thread Jeff Law
On 2/21/19 8:55 AM, Wilco Dijkstra wrote: > Fix PR89437. Fix the sinatan-1.c testcase to not run without > a C99 target system. Use nextafterl for long double initialization. > > Fix an issue with sinl (atanl (sqrtl (LDBL_MAX)) returning 0.0 > instead of 1.0 by using x < sqrtl (LDBL_MAX) in

Re: [PATCH] Remove unused extern variables from debug (PR debug/86964)

2019-02-21 Thread Jeff Law
On 2/21/19 12:22 PM, Richard Biener wrote: > On February 21, 2019 8:06:05 PM GMT+01:00, Jeff Law wrote: >> On 2/19/19 5:51 AM, Johan Carlsson wrote: >>> Adding so that the DIEs of unused external variables can be removed >>from the output when >>> using -feliminate-unused-debug-symbols. >>> >>>

Re: C++ PATCH for c++/88294 - ICE with non-constant noexcept-specifier

2019-02-21 Thread Jason Merrill
On 2/21/19 10:56 AM, Marek Polacek wrote: On Wed, Feb 20, 2019 at 01:53:18PM -1000, Jason Merrill wrote: On 2/20/19 10:31 AM, Marek Polacek wrote: Here we ICE when substituting a deferred noexcept-specifier, because it contains 'this', a PARM_DECL, in an evaluated context. This is different

Re: [C++ PATCH] Ensure constexpr evaluation is done on pre-cp_fold_function bodies (PR c++/89285, take 4)

2019-02-21 Thread Jason Merrill
On 2/20/19 9:08 PM, Jakub Jelinek wrote: On Wed, Feb 20, 2019 at 01:58:58PM -1000, Jason Merrill wrote: On 2/20/19 11:52 AM, Jakub Jelinek wrote: On Wed, Feb 20, 2019 at 11:12:07AM -1000, Jason Merrill wrote: (z = REALPART_EXPR >;, (bool) IMAGPART_EXPR >;); which is not

Re: [PATCH] Minimum version of mpfr? (was Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074))

2019-02-21 Thread Jakub Jelinek
On Thu, Feb 21, 2019 at 04:50:27PM -0500, David Malcolm wrote: > gcc/fortran/simplify.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c > index fa6396b..a1df735 100644 > --- a/gcc/fortran/simplify.c > +++

[PATCH] Minimum version of mpfr? (was Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074))

2019-02-21 Thread David Malcolm
On Wed, 2019-02-13 at 00:09 +0100, Jakub Jelinek wrote: > Hi! > > As discussed recently on the mailing list, the norm2 simplification > doesn't > work if we limit mpfr emin/emax to some values derived from maximum > floating > exponents (and precision for denormals). > > The following patch

Re: C++ PATCH for c++/88294 - ICE with non-constant noexcept-specifier

2019-02-21 Thread Marek Polacek
On Wed, Feb 20, 2019 at 01:53:18PM -1000, Jason Merrill wrote: > On 2/20/19 10:31 AM, Marek Polacek wrote: > > Here we ICE when substituting a deferred noexcept-specifier, because it > > contains 'this', a PARM_DECL, in an evaluated context. This is different > > from "noexcept(noexcept(this))"

Re: [PATCH] libstdc++/89130 and libstdc++/89090 fixes for vector relocation

2019-02-21 Thread Jonathan Wakely
On 05/02/19 14:45 +, Jonathan Wakely wrote: This fixes two PRs, one trivial (don't use C++17 features in C++11 mode) and one more serious (don't require MoveInsertable when we should only need CopyInsertable). It would be nice to rely on if-constexpr in C++11 mode, but it causes clang

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-21 Thread Jeff Law
On 2/21/19 1:12 PM, Martin Sebor wrote: > On 2/21/19 12:08 PM, Jeff Law wrote: >> On 2/18/19 7:53 PM, Martin Sebor wrote: >>> Please let me know what it will take to get the fix for these two >>> issues approved.  I've answered the questions so I don't know what >>> else I'm expected to do here.

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-21 Thread Martin Sebor
On 2/21/19 12:08 PM, Jeff Law wrote: On 2/18/19 7:53 PM, Martin Sebor wrote: Please let me know what it will take to get the fix for these two issues approved.  I've answered the questions so I don't know what else I'm expected to do here.  

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-02-21 Thread Jeff Law
On 1/24/19 3:10 PM, Eric Botcazou wrote: >> md.texi says >> >> The @samp{tablejump} insn is always the last insn before the jump >> table it uses. Its assembler code normally has no need to use the >> second operand, but you should incorporate it in the RTL pattern so >> that the jump optimizer

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-02-21 Thread Jeff Law
On 1/23/19 6:52 AM, Alexander Monakov wrote: > On Wed, 23 Jan 2019, Andrey Belevantsev wrote: > >> For that, I'm not sure. Your patch will leave the tablejump unscheduled at >> all, i.e. any fields like INSN_TICK would be unfilled and thus the later >> passes like bundling on ia64 will not work.

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-02-21 Thread Jeff Law
On 1/23/19 12:29 PM, Segher Boessenkool wrote: > On Wed, Jan 23, 2019 at 04:52:24PM +0300, Alexander Monakov wrote: >> On Wed, 23 Jan 2019, Andrey Belevantsev wrote: >>> For that, I'm not sure. Your patch will leave the tablejump unscheduled at >>> all, i.e. any fields like INSN_TICK would be

Re: PING^1: V2 [PATCH] driver: Also prune joined switches with negation

2019-02-21 Thread Jakub Jelinek
On Thu, Feb 21, 2019 at 10:40:09AM -0800, H.J. Lu wrote: > > Prune joined switches with Negative and RejectNegative to allow > > -march=skylake-avx512 to override previous -march=native on command-line. > > > > gcc/ > > > > PR driver/69471 > > * opts-common.c (prune_options): Also

Re: [PATCH] Remove unused extern variables from debug (PR debug/86964)

2019-02-21 Thread Richard Biener
On February 21, 2019 8:06:05 PM GMT+01:00, Jeff Law wrote: >On 2/19/19 5:51 AM, Johan Carlsson wrote: >> Adding so that the DIEs of unused external variables can be removed >from the output when >> using -feliminate-unused-debug-symbols. >> >> Tested on x86_64-elf, aarch64-elf, powerpc-eabi,

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-21 Thread Jeff Law
On 2/18/19 7:53 PM, Martin Sebor wrote: > Please let me know what it will take to get the fix for these two > issues approved.  I've answered the questions so I don't know what > else I'm expected to do here. > >   https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00793.html I think there is still a

Re: [PATCH] Remove unused extern variables from debug (PR debug/86964)

2019-02-21 Thread Jeff Law
On 2/19/19 5:51 AM, Johan Carlsson wrote: > Adding so that the DIEs of unused external variables can be removed from the > output when > using -feliminate-unused-debug-symbols. > > Tested on x86_64-elf, aarch64-elf, powerpc-eabi, powerpc64-elf and arm-eabi. > > > 2019-02-18 Johan Karlsson >

Re: PING [PATCH] avoid 4095/INT_MAX warning for fprintf (PR 88993)

2019-02-21 Thread Jeff Law
On 2/19/19 5:43 PM, Martin Sebor wrote: > I received feedback on the first patch that it doesn't suppress all > the instances of the warning so I've relaxed the checker even more > to avoid the excess instances seen in Elfutils and beefed up > the tests.  The top of trunk compiles cleanly now with 

PING^1: V2 [PATCH] driver: Also prune joined switches with negation

2019-02-21 Thread H.J. Lu
On Thu, Feb 14, 2019 at 5:51 AM H.J. Lu wrote: > > On Thu, Feb 14, 2019 at 12:03:30PM +0100, Jakub Jelinek wrote: > > On Wed, Feb 13, 2019 at 06:27:51PM -0800, H.J. Lu wrote: > > > --- a/gcc/doc/options.texi > > > +++ b/gcc/doc/options.texi > > > @@ -227,7 +227,10 @@ options, their

Re: [PATCH 1/1] Move AESNI generation to Skylake and Goldmont

2019-02-21 Thread H.J. Lu
On Thu, Feb 21, 2019 at 10:31 AM Thiago Macieira wrote: > > On Thursday, 30 August 2018 09:00:10 PST H.J. Lu wrote: > > On Wed, Aug 29, 2018 at 11:56 PM, Uros Bizjak wrote: > > >> gcc/config/i386/i386.c | 6 +++--- > > >> 1 file changed, 3 insertions(+), 3 deletions(-) > > >> > > >> diff --git

Re: [PATCH 1/1] Move AESNI generation to Skylake and Goldmont

2019-02-21 Thread Thiago Macieira
On Thursday, 30 August 2018 09:00:10 PST H.J. Lu wrote: > On Wed, Aug 29, 2018 at 11:56 PM, Uros Bizjak wrote: > >> gcc/config/i386/i386.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c > >> index

[PATCH] PR c++/88690 - C++17 ICE with empty base in aggregate.

2019-02-21 Thread Jason Merrill
Base fields for empty bases appear in initialization order, which may not be the same as layout order. If they also show up in a CONSTRUCTOR in that order, output_constructor_regular_field aborts because it understandably doesn't want to go backwards. I also considered making o_c_r_f more

Re: [COMMITTED] Fix pr88850 test

2019-02-21 Thread Wilco Dijkstra
Hi Christophe, >> > But my question was more: why skip the test if one forces >> > -mfloat-abi=softfp while you have this very same option in the >> > dg-additional-options ? >> > Isn't it a typo that -mfloat-abi=soft in the "exclude" should use floatfp? >> >> I don't know, I just copied the

[PATCH][arm] Add support for Neoverse N1

2019-02-21 Thread Kyrill Tkachov
Hi all, This patch adds support for the Neoverse N1 [1]. This CPU was previously supported through the Ares codename. -mcpu=ares is retained as an alias of the new -mcpu=neoverse-n1. Bootstrapped and tested on arm-none-linux-gnueabihf. Will commit to trunk together with the aarch64 patch if

[PATCH][AArch64] Add support for Neoverse E1

2019-02-21 Thread Kyrill Tkachov
Hi all, This patch adds -mcpu and -mtune support for the Neoverse E1 CPU [1]. The new option is -mcpu=neoverse-e1. Bootstrapped and tested on aarch64-none-linux-gnu. Ok for trunk? Thanks, Kyrill [1]

[PATCH][AArch64] Add support for Neoverse N1

2019-02-21 Thread Kyrill Tkachov
Hi all, This patch adds support for the Neoverse N1 CPU [1]. This was supported in GCC earlier through the codename Ares, which it now replaces. -mcpu=ares is still accepted as there's been a binutils release supporting it, but the internal structures are renamed to use Neoverse N1-related

Re: [PATCH] [8/9 Regression] i386: Add pass_remove_partial_avx_dependency

2019-02-21 Thread H.J. Lu
On Thu, Feb 21, 2019 at 5:58 AM Jan Hubicka wrote: > > Hello, > > 2019-02-01 H.J. Lu > Hongtao Liu > Sunil K Pandey > > PR target/87007 > * config/i386/i386-passes.def: Add > pass_remove_partial_avx_dependency. > *

Re: [PATCH] Fix PR89437

2019-02-21 Thread Wilco Dijkstra
Hi Richard, >>Fix an issue with sinl (atanl (sqrtl (LDBL_MAX)) returning 0.0 >>instead of 1.0 by using x < sqrtl (LDBL_MAX) in match.pd. > > Wasn't that a intermediate problem with the mpfr exponent range limiting? > Please check whether that's still needed. I tested it with trunk about an

Re: [PATCH] Fix PR89437

2019-02-21 Thread Giuliano Belinassi
I've just submitted a patch for this too :-P. Sorry about that. What is your nick in IRC, Wilco? On 02/21, Wilco Dijkstra wrote: > Fix PR89437. Fix the sinatan-1.c testcase to not run without > a C99 target system. Use nextafterl for long double initialization. > > Fix an issue with sinl

[PATCH] Fix 89437, incorrect result for sinl ( atanl (x))

2019-02-21 Thread Giuliano Belinassi
A incorrect call to `nextafter` instead of `nextafterl` made the test `sinatan-1.c` pass, when it should have failed. The cause of the failure is pointed out in PR89437. This patch addresses the cause of failure, as well the issue in the test. gcc/ChangeLog: 2019-02-21 Giuliano Belinassi

Re: [PATCH] Fix PR89437

2019-02-21 Thread Richard Biener
On February 21, 2019 4:55:57 PM GMT+01:00, Wilco Dijkstra wrote: >Fix PR89437. Fix the sinatan-1.c testcase to not run without >a C99 target system. Use nextafterl for long double initialization. OK. >Fix an issue with sinl (atanl (sqrtl (LDBL_MAX)) returning 0.0 >instead of 1.0 by using x <

Re: [PATCH 2/2][GCC][Arm] Update Armv8.4-a's FP16 FML intrinsics

2019-02-21 Thread Kyrill Tkachov
Hi Tamar, On 2/20/19 1:59 PM, Tamar Christina wrote: Hi All, This patch updates the Armv8.4-a FP16 FML intrinsics's suffixes from u32 to f16 to be more consistent with the naming convention for intrinsics. The specifications for these intrinsics have not been published yet so we do not

Re: PING^1: [PATCH] i386: Check -mindirect-branch/-mfunction-return with -fcf-protection

2019-02-21 Thread H.J. Lu
On Thu, Feb 21, 2019 at 5:34 AM Jan Hubicka wrote: > > > On Tue, Sep 25, 2018 at 6:50 AM H.J. Lu wrote: > > > > > > Issue an error when -mindirect-branch or -mfunction-return are used > > > with incompatible -fcf-protection. > > > > > > gcc/ > > > > > > PR target/87412 > > > *

[PATCH] Fix PR89437

2019-02-21 Thread Wilco Dijkstra
Fix PR89437. Fix the sinatan-1.c testcase to not run without a C99 target system. Use nextafterl for long double initialization. Fix an issue with sinl (atanl (sqrtl (LDBL_MAX)) returning 0.0 instead of 1.0 by using x < sqrtl (LDBL_MAX) in match.pd. OK for commit? ChangeLog: 2019-02-21 Wilco

Re: [PATCH] [8/9 Regression] i386: Add pass_remove_partial_avx_dependency

2019-02-21 Thread Jan Hubicka
Hello, 2019-02-01 H.J. Lu Hongtao Liu Sunil K Pandey PR target/87007 * config/i386/i386-passes.def: Add pass_remove_partial_avx_dependency. * config/i386/i386-protos.h (make_pass_remove_partial_avx_dependency): New. *

Re: PING^1: [PATCH] i386: Check -mindirect-branch/-mfunction-return with -fcf-protection

2019-02-21 Thread Jan Hubicka
> On Tue, Sep 25, 2018 at 6:50 AM H.J. Lu wrote: > > > > Issue an error when -mindirect-branch or -mfunction-return are used > > with incompatible -fcf-protection. > > > > gcc/ > > > > PR target/87412 > > * config/i386/i386.c (ix86_set_indirect_branch_type): Issue an > >

PING^1: [PATCH] i386: Check -mindirect-branch/-mfunction-return with -fcf-protection

2019-02-21 Thread H.J. Lu
On Tue, Sep 25, 2018 at 6:50 AM H.J. Lu wrote: > > Issue an error when -mindirect-branch or -mfunction-return are used > with incompatible -fcf-protection. > > gcc/ > > PR target/87412 > * config/i386/i386.c (ix86_set_indirect_branch_type): Issue an > error for

[PATCH, GCC, AArch64] Fix a couple of bugs in BTI

2019-02-21 Thread Sudakshina Das
Hi While doing more testing I found a couple of issues with my BTI patches. This patch fixes them: 1) Remove a reference to return address key. The original patch was written based on a different not yet committed patch ([PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key)

Re: [Patch] [arm] Fix 88714, Arm LDRD/STRD peepholes - remove q constraint

2019-02-21 Thread Kyrill Tkachov
On 2/20/19 9:12 PM, Jakub Jelinek wrote: On Mon, Feb 18, 2019 at 12:47:04PM +, Kyrill Tkachov wrote: Ok. Thanks for working on this. Sorry for the endless story here, but I've realized that the *arm_ldrd and *arm_strd instructions are the only remaining uses of the undocumented internal

Re: Patch RFC: Avoid recursive insert into const_desc_htab

2019-02-21 Thread Richard Biener
On Wed, Feb 20, 2019 at 6:53 PM Ian Lance Taylor wrote: > > The underlying cause of PR 89170 is a bug that appears to have existed > since 2001, when the function decode_addr_const was changed to call > output_constant_def. The problem is that output_constant_def calls > compare_constant, and

Re: libgo patch committed: Run examples

2019-02-21 Thread Andreas Schwab
On Feb 20 2019, Ian Lance Taylor wrote: > if test x$hasoutput = xtrue; then > - echo ' {"'$n'", '$j', "'"$output"'", '$unordered'},' > + echo ' {"'$n'", '$j', "'"$(cat example2.txt)"'", > '$unordered'},' That still has a problematic echo

Re: [PATCH][C++] Fix ICE with VTV

2019-02-21 Thread Richard Biener
On Wed, 20 Feb 2019, Caroline Tice wrote: > I have managed to reproduce the issue now, and the patch does appear > to fix the ICE. > > There is a second issue, which will need more investigation: When > compiled with '-flto' the extra internal functions that VTV generates, > and which are