Re: [PATCH] PR libstdc++/87431 re-adjust never-valueless optimizations

2019-04-03 Thread Antony Polukhin
On Wed, Apr 3, 2019, 23:39 Ville Voutilainen wrote: > On Wed, 3 Apr 2019 at 23:32, Antony Polukhin wrote: > > > > Looks good. Covers most of the use cases. > > > > Please consider adding filesystem::path, pair, tuple, string_view?, > error_code, list, deque (myabe all the other containers), opti

Re: [wwwdoc][Patch] Mention Loongson 3a1000 3a2000 3a3000 2k1000 support in gcc9

2019-04-03 Thread Paul Hua
Hi, This is a updated version, Ok for commit? On Thu, Jan 17, 2019 at 10:05 AM Paul Hua wrote: > > Hi Gerald, > > Updated version, please review. > > Thanks. > > On Mon, Jan 14, 2019 at 7:46 AM Gerald Pfeifer wrote: > > > > Hi Paul, > > > > On Mon, 31 Dec 2018, Paul Hua wrote: > > > The attache

PR 89864 - gcc fails to build/bootstrap with XCode 10.2

2019-04-03 Thread Erik Schnetter
Fixinclude the header file that incorrectly uses the C-only _Atomic keyword when compiled as C++. Apply the same work-around for two GCC source files that transitively use this header file. Index: fixincludes/inclhack.def === --- fix

Re: [PATCH] handle strings as template arguments (PR 47488, 89833, 89876)

2019-04-03 Thread Martin Sebor
On 4/1/19 11:27 AM, Jason Merrill wrote: On 3/31/19 10:17 PM, Martin Sebor wrote: To fix PR 89833, a P1 regression, the attached patch tries to handle string literals as C++ 2a non-type template arguments by treating them the same as brace enclosed initializer lists (where the latter are handled

Re : add tsv110 pipeline scheduling

2019-04-03 Thread wuyuan (E)
Hi ,James: Thank you for your review, Please attach the following author information to the patch. 2019-04-04 wu yuan * config/aarch64/aarch64-cores.def (tsv1100): Change scheduling model. * config/aarch64/aarch64.md : Add "tsv110.md" * config/aarch64/tsv110.md

Re: [PATCH] PR libstdc++/87431 re-adjust never-valueless optimizations

2019-04-03 Thread Jonathan Wakely
On 03/04/19 23:39 +0300, Ville Voutilainen wrote: On Wed, 3 Apr 2019 at 23:32, Antony Polukhin wrote: Looks good. Covers most of the use cases. Please consider adding filesystem::path, pair, tuple, string_view?, error_code, list, deque (myabe all the other containers), optional, variant itse

Re: [PATCH] PR libstdc++/87431 re-adjust never-valueless optimizations

2019-04-03 Thread Jonathan Wakely
On 03/04/19 23:32 +0300, Antony Polukhin wrote: Looks good. Covers most of the use cases. Please consider adding filesystem::path, pair, tuple, string_view?, string_view is trivially_copyable, and < 256 bytes, so works automatically. error_code, list, deque (myabe all the other containers),

[PING] [PATCH V3] PR88497 - Extend reassoc for vector bit_field_ref

2019-04-03 Thread Kewen.Lin
Hi, Gentle ping for this patch: https://gcc.gnu.org/ml/gcc-patches/2019-03/msg00966.html Thanks! on 2019/3/19 上午11:14, Kewen.Lin wrote: > Hi, > > Please refer to below link for previous threads. > https://gcc.gnu.org/ml/gcc-patches/2019-03/msg00348.html > > Comparing to patch v2, I've moved up

[C++ PATCH] PR c++/81866 - ICE with member template and default targ.

2019-04-03 Thread Jason Merrill
This testcase manages to find a way to look up the partial instantiation of B for the default argument of C before we've created the partial instantiation of B as part of the normal instantiation of the members of A. Which we can deal with, but we were getting confused because the partial instantia

Re: [Patch fortran] PR 68567 - ICE on using wrong defined arrays (different cases/messages)

2019-04-03 Thread Dominique d'Humières
Thanks for the quick answer. Committed as revision r270137. Dominique > Le 3 avr. 2019 à 21:15, Steve Kargl a > écrit : > > On Wed, Apr 03, 2019 at 05:01:42PM +0200, Dominique d'Humières wrote: >> Hi Steve, >> >> Do you agree with the following packaging of your patch for pr68567? >> > > I

[committed] [Patch, fortran] PR 89375 fortran/expr.c:4723:5: warning: logical ‘or’ of equal expressions [-Wlogical-op]

2019-04-03 Thread Dominique d'Humières
Committed as obvious at revision r270115: 2019-04-03 Dominique d'Humieres PR fortran/89375 * expr.c (comp_pointer): Remove redundant condition. Dominique

Re: [PATCH] PR libstdc++/87431 re-adjust never-valueless optimizations

2019-04-03 Thread Ville Voutilainen
On Wed, 3 Apr 2019 at 23:32, Antony Polukhin wrote: > > Looks good. Covers most of the use cases. > > Please consider adding filesystem::path, pair, tuple, string_view?, > error_code, list, deque (myabe all the other containers), optional, variant > itself (for cases when variant holds another v

Re: [PATCH] PR libstdc++/87431 re-adjust never-valueless optimizations

2019-04-03 Thread Antony Polukhin
Looks good. Covers most of the use cases. Please consider adding filesystem::path, pair, tuple, string_view?, error_code, list, deque (myabe all the other containers), optional, variant itself (for cases when variant holds another variant). It would be very useful for the _Never_valueless_alt to

[PATCH] PR c++/86586 - -fcompare-debug=-Wsign-compare.

2019-04-03 Thread Jason Merrill
This patch limits constexpr folding for -Wsign-compare to only cases that we would warn for without considering constant values, avoiding the folding in the testcase in question. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/c-family/ * c-warn.c (warn_for_sign_compare): Call fold_for

[C++ PATCH] PR c++/89331 - ICE with offsetof in incomplete class.

2019-04-03 Thread Jason Merrill
We were aborting when build_base_path returned an error because of the derived class not being complete yet, which wasn't considered by the assert. Fixed by checking for complete type first. The semantics.c change avoids a duplicate error message. Tested x86_64-pc-linux-gnu, applying to trunk.

[PATCH] avoid an other ICE due to invalid built-in call (PR 89934)

2019-04-03 Thread Martin Sebor
PR 89934 reports yet another ICE due to a call to a library built-in function with invalid arguments. The attached patch does the bare minimum to avoid it. I will commit it to trunk and to GCC 8 later this week if there are no objections. Martin PS There have been many of these reports (at lea

Re: [Patch fortran] PR 68567 - ICE on using wrong defined arrays (different cases/messages)

2019-04-03 Thread Steve Kargl
On Wed, Apr 03, 2019 at 05:01:42PM +0200, Dominique d'Humières wrote: > Hi Steve, > > Do you agree with the following packaging of your patch for pr68567? > I honestly don't remember why I did not submit the patch to the list. If it fixes the bug and regression tests cleanly, then I won't object

Re: [PATCH] Fix PR71598, aliasing between enums and compatible types

2019-04-03 Thread Ian Lance Taylor via gcc-patches
On Wed, Apr 3, 2019 at 6:19 AM Christophe Lyon wrote: > > Thanks, here is what I have committed as r270126. > (skip one test on short_enums targets, skip the other one on > non-short_enums targets) I noticed that your testsuite/ChangeLog entry is marked 2019-04-13, but it should perhaps be 2019-0

Re: [PATCH,AIX] disables -flto on Go tests for AIX

2019-04-03 Thread Ian Lance Taylor
On Mon, Apr 1, 2019 at 12:49 AM CHIGOT, CLEMENT wrote: > > Description: > * This patches disables go tests with -flto on AIX. > > Tests: > * AIX 7.2: Configure/Build: SUCCESS > > Changelog: > * lib/go-torture.exp: add check for lto option Thanks. I moved the adjustment up into the block w

Re: Re : add tsv110 pipeline scheduling

2019-04-03 Thread James Greenhalgh
On Tue, Apr 02, 2019 at 03:26:22PM +0100, wuyuan (E) wrote: > Hi ,James: > Has the submitted patch been merged into the trunk? Looking forward to your > reply , thank you very much! >

[PATCH] Fix typo in comment

2019-04-03 Thread Jonathan Wakely
* files.c (search_path_exhausted): Fix typo in comment. Committed as obvious. commit 0e105a283e738b74744fa806a19d5f4afe56732a Author: Jonathan Wakely Date: Wed Apr 3 18:55:08 2019 +0100 Fix typo in comment * files.c (search_path_exhausted): Fix typo in comment.

Re: [PATCH] [ARC] PR 88409: miscompilation due to missing cc clobber in longlong.h macros

2019-04-03 Thread Vineet Gupta
On 4/3/19 2:53 AM, Claudiu Zissulescu wrote: > Pushed, thank you for your contribution, > Claudiu Thx, can this be backported to gcc-8-stable please which is what glibc folks use for testing ! -Vineet > > On Tue, Apr 2, 2019 at 9:27 PM Vineet Gupta > wrote: >> simple test such as below was fai

[PATCH] PR libstdc++/87431 re-adjust never-valueless optimizations

2019-04-03 Thread Jonathan Wakely
Avoid creating arbitrarily large objects on the stack when creating temporaries in order to provide the strong exception-safety guarantee. Also implement Antony Polukhin's suggestion to whitelist specific types that can be efficiently move-assigned, so that emplacing those types never causes a va

[committed] [PR rtl-optimization/81025 ] Don't walk through barriers when looking for consecutive labels

2019-04-03 Thread Jeff Law
Copying from BZ: The bug here is in reorg and its legacy of trying to compensate for the lack of a CFG. In particular it has a function skip_consecutive_labels. The idea (of course) is to have jumps target the last label if there's several in a row. The code looks something like this: for (

Re: [PATCH] Fix PR71598, aliasing between enums and compatible types

2019-04-03 Thread Christophe Lyon
On Wed, 3 Apr 2019 at 15:19, Christophe Lyon wrote: > > On Wed, 3 Apr 2019 at 10:24, Richard Biener wrote: > > > > On Wed, 3 Apr 2019, Christophe Lyon wrote: > > > > > Hi! > > > > > > On Fri, 29 Mar 2019 at 20:02, Jeff Law wrote: > > > > > > > > On 3/29/19 9:09 AM, Jason Merrill wrote: > > > > >

[Patch fortran] PR 68567 - ICE on using wrong defined arrays (different cases/messages)

2019-04-03 Thread Dominique d'Humières
Hi Steve, Do you agree with the following packaging of your patch for pr68567? 2019-04-03 Steven G. Kargl PR fortran/68567 * expr.c (gfc_reduce_init_expr): Add extra check to avoid dereferencing a null pointer. 2019-04-03 Dominique d'Humieres PR fortran/6

Re: [PATCH, wwwdocs] Update on existence of free emulators for alpha, VAX

2019-04-03 Thread Gerald Pfeifer
Let me include the maintainers for alpha and vax; from a web page perspective this is clearly fine, but I'm not expert enough on the technical aspects. (Richard, Matt, if/once you okay, I can apply the patch so you're off the hook.) Gerald On Sun, 31 Mar 2019, co...@sdf.org wrote: > As far as I

Re: [PATCH] Fix PR71598, aliasing between enums and compatible types

2019-04-03 Thread Christophe Lyon
On Wed, 3 Apr 2019 at 10:24, Richard Biener wrote: > > On Wed, 3 Apr 2019, Christophe Lyon wrote: > > > Hi! > > > > On Fri, 29 Mar 2019 at 20:02, Jeff Law wrote: > > > > > > On 3/29/19 9:09 AM, Jason Merrill wrote: > > > > On Fri, Mar 29, 2019 at 4:48 AM Richard Biener > > > > wrote: > > > >> >

[Committed] S/390: Reject long disp for vector load/store early

2019-04-03 Thread Andreas Krebbel
The vector memory instructions only support short displacements. Reject invalid displacements early to prevent plenty of lay instructions to be generated later which then cannot be merged properly. Committed to mainline after bootstrapping and regtesting on IBM z14. gcc/ChangeLog: 2019-04-03 An

Re: [RFC] D support for S/390

2019-04-03 Thread Rainer Orth
Hi Robin, >> Are the values inside the tables the problem? Or just some of the >> helper functions/templates that interact with them to generate the >> static data? >> >> If the latter, then a rebuild of the files may not be necessary. > > I managed to get this to work without rebuilding the file

Re: [PATCH 3/N] Fix GCC internal format in D front-end.

2019-04-03 Thread Martin Liška
On 4/2/19 4:13 PM, Iain Buclaw wrote: > On Tue, 2 Apr 2019 at 12:51, Martin Liška wrote: >> >> On 3/11/19 3:00 PM, Martin Liška wrote: >>> On 3/11/19 2:38 PM, Jakub Jelinek wrote: I think for D you need to go through Iain Buclaw, I have no idea if exp->error even has the gcc internal for

Re: [PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-03 Thread Richard Biener
On Mon, Apr 1, 2019 at 5:36 PM Vladislav Ivanishin wrote: > > Hi! > > This is a fairly trivial change fixing a false negative in > -Wmaybe-uninitialized. I am pretty sure this is simply an overlooked > case (is_value_included_in() is not meant to deal with the case where > both compare codes are

Re: [PATCH] Updated patch for PR84101

2019-04-03 Thread Richard Sandiford
Richard Biener writes: >> > So, may I go with the original patch? >> >> Still feels like we're counting spills on targets that shouldn't need them. >> But going back to: >> >>/* Assume that a reg-reg move is possible and cheap, >> do not account for vector to gp register move c

Re: [PATCH] Updated patch for PR84101

2019-04-03 Thread Richard Biener
On Wed, 3 Apr 2019, Richard Sandiford wrote: > Richard Biener writes: > > On Mon, 1 Apr 2019, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > This is an update from last years attempt to tame down vectorization > >> > when it runs in to ABI inefficiencies at function return. I'v

Re: [PATCH] Updated patch for PR84101

2019-04-03 Thread Richard Sandiford
Richard Biener writes: > On Mon, 1 Apr 2019, Richard Sandiford wrote: > >> Richard Biener writes: >> > This is an update from last years attempt to tame down vectorization >> > when it runs in to ABI inefficiencies at function return. I've >> > updated the patch to look for multi-reg returns ins

[PATCH][RFC] Fix PRs 88882, 89905, 89892 (and more?)

2019-04-03 Thread Richard Biener
The following patch tries to plug the CFG cleanup forwarder block removal hole for wrong-debug PRs. Currently when we cannot move debug-stmts to the destination block (because that has multiple predecessors and thus the debug stmt could possibly not be valid on all paths into the block) we simpl

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-03 Thread Richard Henderson
On 4/3/19 5:19 PM, Sudakshina Das wrote: > + /* PT_NOTE header: namesz, descsz, type. > + namesz = 4 ("GNU\0") > + descsz = 16 (Size of the program property array) > + type = 5 (NT_GNU_PROPERTY_TYPE_0). */ > + assemble_align (POINTER_SIZE); > + assemble_integer (GEN

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-03 Thread Sudakshina Das
Hi Richard On 02/04/2019 10:25, Sudakshina Das wrote: > Hi > > On 02/04/2019 03:27, H.J. Lu wrote: >> On Tue, Apr 2, 2019 at 10:05 AM Richard Henderson >> wrote: >>> >>> On 4/1/19 8:53 PM, Sudakshina Das wrote: > This could stand to use a comment, a moment's thinking about the > sizes,

[PATCH] Remove usage of apostrophes in error and warning messages (PR translation/89935).

2019-04-03 Thread Martin Liška
Hi. The patch addresses wrong usage of apostrophes in error and warning messages. It's follow up of what I did couple of weeks ago. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin contrib/ChangeLog: 2019-04-03 Martin Liska

Re: [PATCH] [ARC] Restore blink first when optimizing for speed.

2019-04-03 Thread Claudiu Zissulescu
Great, thanks! Claudiu On Wed, Apr 3, 2019 at 2:50 AM Andrew Burgess wrote: > > * Claudiu Zissulescu [2019-03-25 11:56:49 +0100]: > > > Hi, > > > > When not optimizing for size, we can restore first blink, hence the return > > instruction will be executed faster. > > > > OK to apply? > > Claudiu

Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Jonathan Wakely
On Wed, 3 Apr 2019 at 11:04, Ville Voutilainen wrote: > > On Wed, 3 Apr 2019 at 12:48, Jonathan Wakely wrote: > > > > The __glibcxx_assert macro should be used to check preconditions that > > users must meet, not to check postconditions that the implementation > > must meet. We have tests to veri

Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Ville Voutilainen
On Wed, 3 Apr 2019 at 13:04, Ville Voutilainen wrote: > > On Wed, 3 Apr 2019 at 12:48, Jonathan Wakely wrote: > > > > The __glibcxx_assert macro should be used to check preconditions that > > users must meet, not to check postconditions that the implementation > > must meet. We have tests to veri

Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Ville Voutilainen
On Wed, 3 Apr 2019 at 12:48, Jonathan Wakely wrote: > > The __glibcxx_assert macro should be used to check preconditions that > users must meet, not to check postconditions that the implementation > must meet. We have tests to verify std::variant meets its > postconditions, users shouldn't pay for

Re: [PATCH, GCC, DOCS, AArch64] Add missing documenation for mbranch-protection

2019-04-03 Thread Sudakshina Das
Hi Sandra On 02/04/2019 16:32, Sandra Loosemore wrote: > On 4/2/19 6:45 AM, Sudakshina Das wrote: >> Hi >> >> This patch add the missing documentation bits for -mbranch-protection in >> both extend.texi and invoke.texi. >> >> Is this ok for trunk? >> >> diff --git a/gcc/doc/extend.texi b/gcc/doc/e

Re: [PATCH] [ARC] PR 88409: miscompilation due to missing cc clobber in longlong.h macros

2019-04-03 Thread Claudiu Zissulescu
Pushed, thank you for your contribution, Claudiu On Tue, Apr 2, 2019 at 9:27 PM Vineet Gupta wrote: > > simple test such as below was failing. > > | void main(int argc, char *argv[]) > | { > |size_t total_time = 115424; // expected 115.424 > |double secs = (double)to

[PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Jonathan Wakely
The __glibcxx_assert macro should be used to check preconditions that users must meet, not to check postconditions that the implementation must meet. We have tests to verify std::variant meets its postconditions, users shouldn't pay for those checks at runtime. PR libstdc++/85184

[PATCH] Define std::hash specializations for C++17 PMR strings

2019-04-03 Thread Jonathan Wakely
These hash specializations should have been added when the pmr::string and related typedefs were added. * include/std/string (__hash_string_base): New class template defining operator() for hashing strings. (hash, hash, hash) (hash, hash): Define for C++17.

Re: [PATCH] Updated patch for PR84101

2019-04-03 Thread Richard Biener
On Mon, 1 Apr 2019, Richard Sandiford wrote: > Richard Biener writes: > > This is an update from last years attempt to tame down vectorization > > when it runs in to ABI inefficiencies at function return. I've > > updated the patch to look for multi-reg returns instead of > > !vector ones (due t

Re: [PATCH] Fix PR71598, aliasing between enums and compatible types

2019-04-03 Thread Richard Biener
On Wed, 3 Apr 2019, Christophe Lyon wrote: > Hi! > > On Fri, 29 Mar 2019 at 20:02, Jeff Law wrote: > > > > On 3/29/19 9:09 AM, Jason Merrill wrote: > > > On Fri, Mar 29, 2019 at 4:48 AM Richard Biener wrote: > > >> > > >> On Thu, 28 Mar 2019, Jason Merrill wrote: > > >> > > >>> On 3/26/19 4:40

Re: [PATCH] Fix PR71598, aliasing between enums and compatible types

2019-04-03 Thread Christophe Lyon
Hi! On Fri, 29 Mar 2019 at 20:02, Jeff Law wrote: > > On 3/29/19 9:09 AM, Jason Merrill wrote: > > On Fri, Mar 29, 2019 at 4:48 AM Richard Biener wrote: > >> > >> On Thu, 28 Mar 2019, Jason Merrill wrote: > >> > >>> On 3/26/19 4:40 AM, Richard Biener wrote: > On Mon, 18 Mar 2019, Richard Bi

[PATCH] Add missing libsanitizer extra patch (r259664) (PR sanitizer/89941).

2019-04-03 Thread Martin Liška
Hi. The patch is about re-application of what we've already had on top trunk libsanitizer. I'll then include the patch in libsanitizer/LOCAL_PATCHES. Ready for trunk? Thanks, Martin libsanitizer/ChangeLog: 2019-04-03 Martin Liska PR sanitizer/89941 * sanitizer_common/saniti

Re: [PATCH] Improve DF use of loop-invaraint (PR46590)

2019-04-03 Thread Richard Biener
On Tue, 2 Apr 2019, Richard Sandiford wrote: > Richard Sandiford writes: > > Richard Biener writes: > >> After the fix to RPO VN in loop header copying DF via RTL invariant > >> motion takes 50% of the compile-time for the second testcase in > >> PR46590. This is caused by the DF live problem i