Re: [PATCH 9/12] adjust tests to quoting/spelling diagnostics fixes

2019-05-17 Thread Martin Sebor
On 5/17/19 2:54 PM, Jeff Law wrote: On 5/17/19 12:35 PM, Martin Sebor wrote: On 5/16/19 1:35 PM, Jeff Law wrote: On 5/14/19 3:32 PM, Martin Sebor wrote: The attached patch adjusts the expected test output to the quoting, spelling and other formatting changes in diagnostics to fix issues pointe

Re: [PATCH] LWG 2899 - Make is_move_constructible correct for unique_ptr

2019-05-17 Thread Jonathan Wakely
On 14/05/19 12:17 +0100, Jonathan Wakely wrote: * include/bits/unique_ptr.h (__uniq_ptr_impl): Add move constructor, move assignment operator. (__uniq_ptr_impl::release(), __uniq_ptr_impl::reset(pointer)): Add. (__uniq_ptr_data): New class template with conditional

[PATCH] rs6000: Some rs6000_emit_epilogue improvements

2019-05-17 Thread Segher Boessenkool
This uses epilogue_type directly. It also changes some ints to bools, declares variables later, and simplifies some code. There is one actual change: else if (info->push_p && DEFAULT_ABI != ABI_V4 - && !crtl->calls_eh_return) + && epilogue_type != EPILOGUE_TYPE_EH

[PATCH] Don't use localized strings for -print-search-dirs output (cf. bug 14351)

2019-05-17 Thread Pieter "PoroCYon" Sluys
As the output of that flag is usually parsed by scripts, having the keys translated is more of a curse than a blessing. This problem seems to have been known for about 15 years now: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=14351 This patch simply removes the gettext _() macro invocations. ---

[PATCH] rs6000: Add "enabled" attribute

2019-05-17 Thread Segher Boessenkool
This adds the "enabled" attribute to the rs6000 backend. It uses the (new) "isa" attribute to automatically select which instruction alternatives should be enabled. For now it allows isa strings of "p5", "p6", "p7", meaning the instructions introduced on that CPU, not requiring vectors; and "p7v"

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Jason Merrill
On Fri, May 17, 2019 at 3:51 PM Segher Boessenkool wrote: > Yes -- one of the problems I have with the current git-svn mirror is that > it doesn't have any of the SVN branches under ibm/ as separate Git branches. > It looks like Maxim's scripts will handle this; the conversion hasn't > reached tho

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Steve Ellcey
I hope this isn't too much of a thread drift but I was wondering if, after the Git conversion, will the GCC repo look like a 'normal' GIT repo with the main line sources on the master branch? I.e. right now instead of a simple clone, the GCC Wiki says to use a sequence of git init/config/fetch/che

Re: [PATCH 9/12] adjust tests to quoting/spelling diagnostics fixes

2019-05-17 Thread Jeff Law
On 5/17/19 12:35 PM, Martin Sebor wrote: > On 5/16/19 1:35 PM, Jeff Law wrote: >> On 5/14/19 3:32 PM, Martin Sebor wrote: >>> The attached patch adjusts the expected test output to the quoting, >>> spelling and other formatting changes in diagnostics to fix issues >>> pointed out by the -Wformat-di

Re: Hashtable comment cleanups & renamings

2019-05-17 Thread Jonathan Wakely
On 17/05/19 18:19 +0200, François Dumont wrote: Hi     I got tired of '__n' being used in _Hashtable for many different purposes: node, bucket, bucket count, bucket hint. It makes the code difficult to read. This code makes sure that __n is a node except is some very limited use cases where t

[PATCH] gcc: aarch64: move assemble_start_function / assemble_end_function

2019-05-17 Thread Max Filippov
Change that moved assemble_start_function/assemble_end_function to backends missed aarch64. Fix that. Committed as obvious. gcc/ 2019-05-17 Max Filippov * config/aarch64/aarch64.c (aarch64_output_mi_thunk): Call assemble_start_function and assemble_end_function. --- gcc/confi

Backports to gcc-9-branch

2019-05-17 Thread Jakub Jelinek
Hi! I've backported following 11 patches from trunk to gcc-9-branch, bootstrapped/regtested on x86_64-linux and i686-linux, committed. Jakub 2019-05-17 Jakub Jelinek Backported from mainline 2019-04-26 Jakub Jelinek PR debug/90197 * c-tree.h (c_fini

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Segher Boessenkool
On Fri, May 17, 2019 at 09:18:53AM +0100, Richard Sandiford wrote: > Joseph Myers writes: > > On Thu, 16 May 2019, Maxim Kuvyrkov wrote: > >> With git, we can always split away unneeded history by removing > >> unnecessary branches and tags and re-packing the repo. We can equally > >> easily br

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jakub Jelinek
On Fri, May 17, 2019 at 10:33:30PM +0300, Janne Blomqvist wrote: > I don't think it's this simple, unfortunately. If it would be only R, > then yes, we could help the R people fix their code and then it would > all be done. But seems this is everywhere. It's in CBLAS & LAPACKE > (the official BLAS

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Janne Blomqvist
On Fri, May 17, 2019 at 9:57 PM Jerry DeLisle wrote: > > On 5/17/19 10:48 AM, Jeff Law wrote: > > My first, second and third thought has been we shouldn't be catering to > > code that is so clearly broken. Maybe we could do this on the release > > branches which would in turn give folks roughly a

[committed] PR89433 "Repeated use of the OpenACC 'routine' directive"

2019-05-17 Thread Thomas Schwinge
Hi! On Fri, 22 Feb 2019 12:22:38 +0100, I wrote: > To resolve PR89433 "Repeated use of the OpenACC 'routine' directive" at > least for C/C++, I intend to push the attached patches in next GCC > development stage 1 (unless that should be addressed right now, and also > on other GCC release branches

Re: [PATCH] tbb-backend effective target should check ability to link TBB

2019-05-17 Thread Thomas Rodgers
I have it fixed locally, but yeah I have not yet committed it. Jonathan Wakely writes: > On 25/04/19 15:58 -0700, Thomas Rodgers wrote: >> >> PR libstdc++/90252 >> * testsuite/lib/libstdc++.exp (check_effective_target_tbb-backend): >> Changed v3_target_compile check from preprocess

[PATCH, Darwin, PPC] Adjust formatting of picbase labels.

2019-05-17 Thread Iain Sandoe
The rest of the Darwin ports now emit Lnnn$pb as the picbase lable instead of the ancient (and hard to read) "L000nnn$pb". This just updates this part of the rs6000 port, NFC intended. tested on powerpc-darwin9 and powerpc-linux-gnu (power7) applied to mainline. Iain gcc/ 2019-05-17 Iain S

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jerry DeLisle
On 5/17/19 10:48 AM, Jeff Law wrote: On 5/16/19 2:09 AM, Jakub Jelinek wrote: Hi! Fortran subroutines/functions that have CHARACTER arguments have also hidden arguments at the end of the argument list which hold the string length. This is something all Fortran compilers I've tried do and is do

[PATCH, Darwin, PPC] Fix generated code whitespace, NFC.

2019-05-17 Thread Iain Sandoe
NFC intended, this simply adds a missing tab to the generated code for pic symbol stubs. tested on powerpc-darwin9, powerpc-linux-gnu (power7) applied to mainline Iain gcc/ 2019-05-17 Iain Sandoe * config/rs6000/rs6000.c (macho_branch_islands): Fix bad indent on the generated

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread David Malcolm
On Fri, 2019-05-17 at 12:07 -0600, Martin Sebor wrote: > On 5/17/19 11:16 AM, David Malcolm wrote: > > On Fri, 2019-05-17 at 09:02 -0600, Martin Sebor wrote: > > > On 5/17/19 7:43 AM, David Malcolm wrote: > > > > On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: > > > > > On 5/16/19 5:22 PM, J

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-17 Thread Richard Biener
On May 17, 2019 6:47:00 PM GMT+02:00, Jeff Law wrote: >On 5/16/19 10:17 PM, Feng Xue OS wrote: >> This patch is meant to give user a way to optimize away those empty >loops which are impossible to be recognized by compiler, such as C++ >STL container-based loop, >> >> void f (std::map &m) >>

Re: [PATCH 9/12] adjust tests to quoting/spelling diagnostics fixes

2019-05-17 Thread Martin Sebor
On 5/16/19 1:35 PM, Jeff Law wrote: On 5/14/19 3:32 PM, Martin Sebor wrote: The attached patch adjusts the expected test output to the quoting, spelling and other formatting changes in diagnostics to fix issues pointed out by the -Wformat-diag warning. Martin gcc-wformat-diag-tests.diff gcc/t

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread Martin Sebor
On 5/17/19 11:16 AM, David Malcolm wrote: On Fri, 2019-05-17 at 09:02 -0600, Martin Sebor wrote: On 5/17/19 7:43 AM, David Malcolm wrote: On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patc

[PATCH] Add myself to MAINTAINERS

2019-05-17 Thread Thomas Rodgers
diff --git a/ChangeLog b/ChangeLog index 8a6638497b8..4c8e3c91d55 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2019-05-17 Thomas Rodgers + + * MAINTAINERS (Write After Approval): Add myself. + 2019-05-16 Jun Ma * MAINTAINERS (Write After Approval): Add myself. diff --git a/MAI

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jeff Law
On 5/16/19 2:09 AM, Jakub Jelinek wrote: > Hi! > > Fortran subroutines/functions that have CHARACTER arguments have also > hidden arguments at the end of the argument list which hold the string > length. This is something all Fortran compilers I've tried do and is > done in order to support calli

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread David Malcolm
On Fri, 2019-05-17 at 09:02 -0600, Martin Sebor wrote: > On 5/17/19 7:43 AM, David Malcolm wrote: > > On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: > > > On 5/16/19 5:22 PM, Joseph Myers wrote: > > > > On Tue, 14 May 2019, Martin Sebor wrote: > > > > > > > > > The attached patch fixes quo

Re: [PATCH] Export forgotten _gfortran_{,m,s}findloc0_i2 (PR fortran/54613)

2019-05-17 Thread Thomas Koenig
Hi Jakub, I've found that gfortran.map doesn't export these 3 symbols (while it does export other variants, with i1, i4, i8, i16, etc.). Do we want to export them from both GCC 9.2 and 10 the following way, or just on the trunk using GFORTRAN_10? Both, please. Tested on x86_64-linux. Anothe

Re: [PATCH] tree-ssa-uninit: suppress more spurious warnings

2019-05-17 Thread Alexander Monakov
On Fri, 17 May 2019, Jeff Law wrote: > So my question is are these showing up in practice? The gimple based > tests seem to be skipping the optimizers that would have eliminated this > stuff. > > In each of the testcases I would have expected jump threading to have > eliminated the problematical

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-17 Thread Jeff Law
On 5/16/19 10:17 PM, Feng Xue OS wrote: > This patch is meant to give user a way to optimize away those empty loops > which are impossible to be recognized by compiler, such as C++ STL > container-based loop, > > void f (std::map &m) >   { >     for (auto it = m.begin (); it != m.end (

Re: [PATCH] tree-ssa-uninit: suppress more spurious warnings

2019-05-17 Thread Jeff Law
On 5/17/19 2:12 AM, Vladislav Ivanishin wrote: > Hi! > > Without the patch, two of the newly added tests fail with bogus warnings: > > - gcc.dg/uninit-28-gimple.c (Definition guarded with NE_EXPR, use with > BIT_AND_EXPR. This is an FP my previous patch [1] knowingly > overlooks.) > - gcc.dg

Re: [RFC, PATCH] Don't introduce useless edge splits unless in PRE

2019-05-17 Thread Vladislav Ivanishin
Richard Biener writes: > On Tue, May 14, 2019 at 3:58 PM Vladislav Ivanishin wrote: >> >> Hi! >> >> The split_critical_edges() function has multiple uses and it seems, a >> portion of its code was added to work only when called from tree-ssa-pre >> but right now it is executed regardless of the

Re: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx

2019-05-17 Thread Jeff Law
On 5/16/19 7:15 AM, Dragan Mladjenovic wrote: > Ping. > > > > From: Dragan Mladjenovic > Sent: Thursday, May 9, 2019 12:29 PM > To: gcc-patches@gcc.gnu.org > Cc: Dragan Mladjenovic; Jakub Jelinek; Matthew Fortune > Subject: [PATCH] Fix __builtin_init_dwarf_reg_siz

Hashtable comment cleanups & renamings

2019-05-17 Thread François Dumont
Hi     I got tired of '__n' being used in _Hashtable for many different purposes: node, bucket, bucket count, bucket hint. It makes the code difficult to read. This code makes sure that __n is a node except is some very limited use cases where the method name is clear enough to tell what __n

Re: [PATCH] x86-64: Add vararg ABI tests

2019-05-17 Thread Uros Bizjak
On Fri, May 17, 2019 at 5:05 PM H.J. Lu wrote: > > On Fri, May 17, 2019 at 12:08 AM Uros Bizjak wrote: > > > > On Thu, May 16, 2019 at 10:10 PM H.J. Lu wrote: > > > > > > We can scan stack for return address to get vector arguments passed on > > > stack. > > > > > > * gcc.target/x86_64/a

Re: [PATCH][RFC] Come up with TARGET_HAS_FAST_MEMPCPY_ROUTINE (PR middle-end/90263).

2019-05-17 Thread Jeff Law
On 5/15/19 5:35 AM, Martin Liška wrote: > On 5/14/19 5:07 PM, Martin Sebor wrote: >> On 5/14/19 8:55 AM, Martin Liška wrote: >>> On 5/13/19 3:07 PM, Jakub Jelinek wrote: On Mon, May 13, 2019 at 12:14:37PM +0200, Martin Liška wrote: > On 5/10/19 11:21 AM, Jakub Jelinek wrote: >> On Fri,

Re: preserve more debug stmts in gimple jump threading

2019-05-17 Thread Jeff Law
On 5/15/19 2:20 AM, Alexandre Oliva wrote: > Gimple jump threading does not duplicate forwarder blocks that might > be present before or after the second copied block. This silently > drops debug binds and markers that might be present in them. This > patch attempts to preserve them. > > For blo

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jeff Law
On 5/16/19 3:36 AM, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 11:22:08AM +0200, Richard Biener wrote: >> Which reminds me I forgot to update LTO_major_version on trunk - can >> you do that? > > Done with: > > 2019-05-16 Jakub Jelinek > > * lto-streamer.h (LTO_major_version): Bump t

Re: [PATCH] Export forgotten _gfortran_{,m,s}findloc{0,1}_r10 (PR fortran/54613)

2019-05-17 Thread Jakub Jelinek
On Fri, May 17, 2019 at 02:16:36PM +0200, Jakub Jelinek wrote: > As the attached testcase shows, that can't be intentional, as that > testcase fails to link. Forgot to attach the testcases (that said, it would be better to write something cleaner, perhaps one call for each library entry-point to b

Re: [PATCH 0/3] Small clean up of profile_{count,probability}

2019-05-17 Thread Jeff Law
On 5/17/19 1:28 AM, Martin Liška wrote: > PING^1 > > On 4/29/19 1:01 PM, marxin wrote: >> The patch makes couple of adjustements: >> 1) I changed enum values to use capital letters. It's aligned with >>our coding style and it makes the code more readable. E.g. >>profile_quality::profile_gu

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Maxim Kuvyrkov
> On May 17, 2019, at 4:07 PM, Jason Merrill wrote: > > On Tue, May 14, 2019 at 12:11 PM Maxim Kuvyrkov > wrote: >> >> This patch adds scripts to contrib/ to migrate full history of GCC's >> subversion repository to git. My hope is that these scripts will finally >> allow GCC project to migr

Re: [PATCH] x86-64: Add vararg ABI tests

2019-05-17 Thread H.J. Lu
On Fri, May 17, 2019 at 12:08 AM Uros Bizjak wrote: > > On Thu, May 16, 2019 at 10:10 PM H.J. Lu wrote: > > > > We can scan stack for return address to get vector arguments passed on > > stack. > > > > * gcc.target/x86_64/abi/test_varargs-m128.c: New file. > > * gcc.target/x86_64/

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread Martin Sebor
On 5/17/19 7:43 AM, David Malcolm wrote: On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the c-fa

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Maxim Kuvyrkov
> On May 17, 2019, at 3:22 PM, Martin Liška wrote: > > On 5/17/19 1:06 AM, Joseph Myers wrote: >> That repository >> represents what I consider the collaboratively built consensus on such >> things as the desired author map (including handling of the ambiguous >> author name), which directorie

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Maxim Kuvyrkov
> On May 17, 2019, at 2:06 AM, Joseph Myers wrote: > > On Tue, 14 May 2019, Maxim Kuvyrkov wrote: > >> The scripts convert svn history branch by branch. They rely on git-svn >> on convert individual branches. Git-svn is a good tool for converting >> individual branches. It is, however, eith

Re: [PATCH] i386: Enable MMX intrinsics without SSE/SSE2/SSSE3

2019-05-17 Thread H.J. Lu
On Thu, May 16, 2019 at 11:21 PM Uros Bizjak wrote: > > On Thu, May 16, 2019 at 11:59 PM H.J. Lu wrote: > > > > Since MMX intrinsics are marked with SSE/SSE2/SSSE3 for SSE emulation, > > enable them without SSE/SSE2/SSSE3 if MMX is enabled. > > > > Restore TARGET_3DNOW check, which was changed to

[PATCH] PR libstdc++/90246 Improve text of std::variant exceptions and assertions

2019-05-17 Thread Jonathan Wakely
PR libstdc++/90246 * include/std/variant (holds_alternative, get, get_if): Improve static assertion messages. (bad_variant_access::bad_variant_access()): Change default message. (__throw_bad_variant_access(bool)): New overload. (get): Use new overloa

Re: C++ PATCH to improve diagnostic for non-type template parameters

2019-05-17 Thread Marek Polacek
Ping. On Fri, May 10, 2019 at 07:10:16PM -0400, Marek Polacek wrote: > When we have > > template > struct S { }; > > then in > >S s; > > "int()" is resolved to a type-id, as per [temp.arg]/2, causing this program to > fail to compile. This can be rather confusing so I think we want t

Re: C++ PATCH to implement deferred parsing of noexcept-specifiers (c++/86476, c++/52869)

2019-05-17 Thread Marek Polacek
Ping. On Fri, May 10, 2019 at 03:21:33PM -0400, Marek Polacek wrote: > Coming back to this. I didn't think this was suitable for GCC 9. > > On Mon, Jan 07, 2019 at 10:44:37AM -0500, Jason Merrill wrote: > > On 12/19/18 3:27 PM, Marek Polacek wrote: > > > Prompted by Jon's observation in 52869, I

[PATCH] Fix uses of non-reserved names for template parameters

2019-05-17 Thread Jonathan Wakely
* include/bits/random.h (seed_seq::param): Fix non-reserved name. * include/experimental/type_traits (is_detected_exact) (is_detected_exact_v): Likewise. * include/pstl/execution_defs.h (is_execution_policy) (is_execution_policy_v, __enable_if_execution_poli

Re: [PATCH] Implement sane variant converting constructor (P0608R3)

2019-05-17 Thread Jonathan Wakely
On 17/05/19 15:55 +0200, Rainer Orth wrote: Hi Jonathan, * include/std/variant (__overload_set): Remove. (_Arr): New helper. (_Build_FUN): New class template to define a single FUN overload, with specializations to prevent unwanted conversions, as per P0608R3.

Re: Strenghten aliasing_component_refs_p

2019-05-17 Thread Jan Hubicka
> On Fri, 17 May 2019, Jan Hubicka wrote: > > > Hi, > > this patch cuts walks in aliasing_component_refs_p if the type we look for > > can not fit into a given type by comparing their sizes. Similar logic > > already exists in indirect_ref_may_alias_decl_p. > > > > When we walk reference a.b.c.d.

Re: [PATCH] Implement sane variant converting constructor (P0608R3)

2019-05-17 Thread Rainer Orth
Hi Jonathan, > * include/std/variant (__overload_set): Remove. > (_Arr): New helper. > (_Build_FUN): New class template to define a single FUN overload, > with specializations to prevent unwanted conversions, as per P0608R3. > (_Build_FUNs): New class template to buil

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread David Malcolm
On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: > On 5/16/19 5:22 PM, Joseph Myers wrote: > > On Tue, 14 May 2019, Martin Sebor wrote: > > > > > The attached patch fixes quoting, spelling, and other formatting > > > issues in diagnostics issued from files in the c-family/ > > > directory >

Go patch committed: Use SHA1 hash for long gcbits symbols

2019-05-17 Thread Ian Lance Taylor
This patch to the Go frontend by Than McIntosh uses a SHA1-hash for the symbol name for long gcbits symbols. The current scheme used by the compiler for "gcbits" symbols involves generating a symbol name based on a 32-char encoding of the bits data. This scheme works well in most cases but can ge

Re: [PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-17 Thread Richard Biener
On Fri, May 17, 2019 at 12:07 PM Thomas De Schampheleire wrote: > > > > On Fri, May 17, 2019, 11:57 Richard Biener wrote: >> >> On Fri, May 17, 2019 at 9:42 AM Thomas De Schampheleire >> wrote: >> > >> > Hi Richard, >> > >> > El jue., 16 may. 2019 a las 14:41, Richard Biener >> > () escribió: >>

[PATCH] Move VEC_PERM_EXPR folding to match.pd

2019-05-17 Thread Richard Biener
This moves things from fold-const.c to match.pd. Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2019-05-17 Richard Biener * gimple-match-head.c: Include vec-perm-indices.h. * generic-match-head.c: Likewise. * fold-const.h (fold_vec_perm): Declare

[PATCH][RFC] Fix PR90510, VEC_PERM -> BIT_INSERT folding

2019-05-17 Thread Richard Biener
This adds, incrementally ontop of moving VEC_PERM_EXPR folding to match.pd (but not incremental patch - sorry...), folding of single-element insert permutations to BIT_INSERT_EXPR. Things are quite awkward with the new poly-int vec-perm stuff so effectively this doesn't work for SVE and is still

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Jason Merrill
On Tue, May 14, 2019 at 12:11 PM Maxim Kuvyrkov wrote: > > This patch adds scripts to contrib/ to migrate full history of GCC's > subversion repository to git. My hope is that these scripts will finally > allow GCC project to migrate to Git. Thanks for looking into this. My feeling has been t

Re: Deque code cleanup and optimizations

2019-05-17 Thread Jonathan Wakely
On 17/05/19 07:06 +0200, François Dumont wrote: Here is the simplified patch. I put back the _M_map checks, we'll see later if those can be removed.     * include/bits/stl_deque.h     (_Deque_iterator<>::__ptr_to): Remove, use std::__ptr_rebind.     (_Deque_base(_Deque_base&&, const allocator_t

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Jakub Jelinek
On Fri, May 17, 2019 at 02:22:47PM +0200, Martin Liška wrote: > On 5/17/19 1:06 AM, Joseph Myers wrote: > > That repository > > represents what I consider the collaboratively built consensus on such > > things as the desired author map (including handling of the ambiguous > > author name), which

Re: [PATCH] tbb-backend effective target should check ability to link TBB

2019-05-17 Thread Jonathan Wakely
On 25/04/19 15:58 -0700, Thomas Rodgers wrote: PR libstdc++/90252 * testsuite/lib/libstdc++.exp (check_effective_target_tbb-backend): Changed v3_target_compile check from preprocess to executable. --- libstdc++-v3/testsuite/lib/libstdc++.exp | 9 +++-- 1 file changed,

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Martin Liška
On 5/17/19 1:06 AM, Joseph Myers wrote: > That repository > represents what I consider the collaboratively built consensus on such > things as the desired author map (including handling of the ambiguous > author name), which directories represent branches and tags, and what tags > should be kep

[PATCH] Export forgotten _gfortran_{,m,s}findloc{0,1}_r10 (PR fortran/54613)

2019-05-17 Thread Jakub Jelinek
On Fri, May 17, 2019 at 01:45:25PM +0200, Jakub Jelinek wrote: > Another thing is, but that one isn't just about exported symbols, but also > about not even generating such files and listing them in Makefile.am, > there are no findloc r10 entrypoints. Is that intentional? As the attached testcase

[PATCH] Export forgotten _gfortran_{,m,s}findloc0_i2 (PR fortran/54613)

2019-05-17 Thread Jakub Jelinek
Hi! I've found that gfortran.map doesn't export these 3 symbols (while it does export other variants, with i1, i4, i8, i16, etc.). Do we want to export them from both GCC 9.2 and 10 the following way, or just on the trunk using GFORTRAN_10? Tested on x86_64-linux. Another thing is, but that one

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Martin Liška
On 5/17/19 12:04 AM, Jonathan Wakely wrote: > On 16/05/19 13:07 -0600, Jeff Law wrote: >> On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: >>> On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov >>> wrote: > On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > On 5/15/19 5:19 AM, Richard

[Committed] S/390: Fix vec_sldw builtin

2019-05-17 Thread Andreas Krebbel
The builtin was wired up to the wrong pattern. Fixed with this patch. gcc/ChangeLog: 2019-05-17 Andreas Krebbel * config/s390/s390-builtins.def (s390_vec_sldw_*): Use the vec_sldw insn pattern. gcc/testsuite/ChangeLog: 2019-05-17 Andreas Krebbel * gcc.target/s39

Re: [PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-17 Thread Thomas De Schampheleire
On Fri, May 17, 2019, 11:57 Richard Biener wrote: > On Fri, May 17, 2019 at 9:42 AM Thomas De Schampheleire > wrote: > > > > Hi Richard, > > > > El jue., 16 may. 2019 a las 14:41, Richard Biener > > () escribió: > > > > > > On Thu, May 16, 2019 at 11:20 AM Thomas De Schampheleire > > > wrote: >

Re: [PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-17 Thread Richard Biener
On Fri, May 17, 2019 at 9:42 AM Thomas De Schampheleire wrote: > > Hi Richard, > > El jue., 16 may. 2019 a las 14:41, Richard Biener > () escribió: > > > > On Thu, May 16, 2019 at 11:20 AM Thomas De Schampheleire > > wrote: > > > > > > From: Thomas De Schampheleire > > > > > > In addition to mak

Re: [PATCH] Define std::__invoke_r for INVOKE

2019-05-17 Thread Jonathan Wakely
On 17/05/19 10:15 +0100, Jonathan Wakely wrote: I'm testing the attached fix. Thanks for the report. Tests passed, patch committed to trunk. commit 6ae6283255f58ad44a159970dce6f431cf46f293 Author: Jonathan Wakely Date: Fri May 17 10:10:10 2019 +0100 Fix __invoke_r to be valid in C++11

[PATCH] Add missing piece of P0777R1 and update C++20 status docs

2019-05-17 Thread Jonathan Wakely
* doc/xml/manual/status_cxx2020.xml: Update P0608R3, P0777R1, and P1165R1 entries. * doc/html/*: Regenerate. * include/std/tuple (make_from_tuple): Use remove_reference_t instead of decay_t (P0777R1). Tested powerpc64le-linux, committed to trunk. commit 8

[PATCH][gimplefe] Handle __VEC_PERM

2019-05-17 Thread Richard Biener
Bootstrap / testing in progress on x86_64-unknown-linux-gnu. Richard. 2019-05-17 Richard Biener c/ * gimple-parser.c (c_parser_gimple_statement): Handle __VEC_PERM. (c_parser_gimple_unary_expression): Likewise. (c_parser_gimple_parentized_ternary_expression):

Re: [PATCH] Define std::__invoke_r for INVOKE

2019-05-17 Thread Jonathan Wakely
On 17/05/19 10:49 +0200, Stephan Bergmann wrote: On 14/05/2019 17:25, Jonathan Wakely wrote: * include/bits/invoke.h (__invoke_r): Define new function implementing the INVOKE pseudo-function. * testsuite/20_util/function_objects/invoke/1.cc: Add more tests. * testsuite/20_util/fu

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-17 Thread Janne Blomqvist
On Thu, May 16, 2019 at 11:37 PM Nicolas Koenig wrote: > > Hi everyone, > > a quick heads up, that the native coarray patch I'm working on at the > moment (1200 loc and growing :D) will be based upon forked processes, so > we won't be able to eliminate fork(). I would guess that's a case where fo

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-17 Thread Janne Blomqvist
On Thu, May 16, 2019 at 11:54 PM Thomas Koenig wrote: > > Hi Janne, > > > I differ there. > > A longer explanation: > > fork() is standard POSIX. So is posix_spawn, as the name implies. >Not all systems have posix_spawn. Do you know of any target we support that has fork but not posix_spawn? >

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-17 Thread Martin Liška
On 5/16/19 1:42 PM, Richard Biener wrote: > IMHO > a reasonable feature, not sure if a reasonable way to achieve. Just for the record. The use case was not about having an alias to a default clone. They just want to test multi-versioning of some glibc math routines. Martin

Re: Strenghten aliasing_component_refs_p

2019-05-17 Thread Richard Biener
On Fri, 17 May 2019, Jan Hubicka wrote: > Hi, > this patch cuts walks in aliasing_component_refs_p if the type we look for > can not fit into a given type by comparing their sizes. Similar logic > already exists in indirect_ref_may_alias_decl_p. > > When we walk reference a.b.c.d.e looking for ty

Re: [PATCH] Define std::__invoke_r for INVOKE

2019-05-17 Thread Stephan Bergmann
On 14/05/2019 17:25, Jonathan Wakely wrote: * include/bits/invoke.h (__invoke_r): Define new function implementing the INVOKE pseudo-function. * testsuite/20_util/function_objects/invoke/1.cc: Add more tests. * testsuite/20_util/function_objects/invoke/2.cc: New test. Tested

Re: [PATCH 1/2] Add support for IVOPT

2019-05-17 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > [...] >> > +{ >> > + struct mem_address parts = {NULL_TREE, integer_one_node, >> > + NULL_TREE, NULL_TREE, NULL_TREE}; >> >> Might be better to use "= {}" and initialise the fields that matter by >> assignment. As it stands t

Re: patches to detect GCC diagnostics

2019-05-17 Thread Roland Illig
Am 16.05.2019 um 22:24 schrieb Martin Sebor: > On 5/16/19 8:58 AM, Roland Illig wrote: >> -  error ("#pragma GCC target string... is badly formed"); >> +  error ("%<#pragma GCC target%> string is badly formed"); >> -  error ("#pragma GCC optimize string... is badly formed"); >> + 

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Richard Sandiford
Joseph Myers writes: > On Thu, 16 May 2019, Maxim Kuvyrkov wrote: > >> Let's avoid mixing the two discussions: (1) converting svn repo to git >> (and getting community consensus to switch to git) and (2) deciding on >> which branches to keep in the new repo. >> >> With git, we can always split

[PATCH] Remove another gimple_assign_rhs_to_tree call

2019-05-17 Thread Richard Biener
Stupid one. We shouldn't have made it available... Bootstrapped/tested on x86_64-unknown-linux-gnu. Richard. 2019-05-17 Richard Biener * ccmp.c (expand_ccmp_expr_1): Do not use gimple_assign_rhs_to_tree. Index: gcc/ccmp.c ==

[PATCH] tree-ssa-uninit: suppress more spurious warnings

2019-05-17 Thread Vladislav Ivanishin
Hi! Without the patch, two of the newly added tests fail with bogus warnings: - gcc.dg/uninit-28-gimple.c (Definition guarded with NE_EXPR, use with BIT_AND_EXPR. This is an FP my previous patch [1] knowingly overlooks.) - gcc.dg/uninit-30-gimple.c (EQ_EXPR in the predicate guarding use. T

[PATCH] Honor OpenMP simdlen in the vectorizer

2019-05-17 Thread Jakub Jelinek
Hi! When simdlen clause is specified on simd loop, it specifies the preferred vectorization factor. It is a preference, so if there is no possibility of satisfying it, we can do something else, but still, we shouldn't ignore it as we've been ignoring it before. Unfortunately, we iterate over vec

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-17 Thread Jakub Jelinek
On Fri, May 17, 2019 at 03:02:51PM +0800, JunMa wrote: > 2019-05-17  Jun Ma  > >     PR tree-optimization/90106 >     * gcc.dg/cdce3.c: New test. Ok, thanks. Jakub

Re: [PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-17 Thread Thomas De Schampheleire
Hi Richard, El jue., 16 may. 2019 a las 14:41, Richard Biener () escribió: > > On Thu, May 16, 2019 at 11:20 AM Thomas De Schampheleire > wrote: > > > > From: Thomas De Schampheleire > > > > In addition to making -feliminate-unused-debug-symbols work for the DWARF > > format (see [1]), make this

Re: [PATCH] Support again multiple --help options (PR other/90315).

2019-05-17 Thread Martin Liška
PING^2 On 5/10/19 3:42 PM, Martin Liška wrote: > PING^1 > > On 5/3/19 12:59 PM, Martin Liška wrote: >> Hi. >> >> The patch prints all values requested in multiple --help options. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? >> Thanks, >

Re: [PATCH 0/3] Small clean up of profile_{count,probability}

2019-05-17 Thread Martin Liška
PING^1 On 4/29/19 1:01 PM, marxin wrote: > The patch makes couple of adjustements: > 1) I changed enum values to use capital letters. It's aligned with >our coding style and it makes the code more readable. E.g. >profile_quality::profile_guessed_local >vs. static profile_probability gu

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-17 Thread Kewen.Lin
Hi Segher, on 2019/5/17 下午2:49, Segher Boessenkool wrote: > Hi Kewen, > > On Thu, May 16, 2019 at 10:35:30PM -0500, li...@linux.ibm.com wrote: >> 2) For the other part of target invalid stmt check, as the >> hook invalid_within_doloop grep data shows, no all targets >> need to check whether inval

Re: [PATCH] x86-64: Add vararg ABI tests

2019-05-17 Thread Uros Bizjak
On Thu, May 16, 2019 at 10:10 PM H.J. Lu wrote: > > We can scan stack for return address to get vector arguments passed on > stack. > > * gcc.target/x86_64/abi/test_varargs-m128.c: New file. > * gcc.target/x86_64/abi/avx/test_varargs-m256.c: Likewise. > * gcc.target/x86_64/

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-17 Thread JunMa
在 2019/5/17 下午2:34, Jakub Jelinek 写道: On Fri, May 17, 2019 at 02:24:22PM +0800, JunMa wrote: 2019-05-17  Jun Ma Two spaces before < rather than one.     PR tree-optimization/90106     * gcc.dg/cdce3.c: New test. --- /dev/null +++ b/gcc/testsuite/gcc.dg/cdce3.c @@ -0,0 +1,12 @@ +/* { dg-do