Re: PING^1: V2 [PATCH] i386: Insert ENDBR for NOTE_INSN_DELETED_LABEL only if needed

2019-05-27 Thread Uros Bizjak
On Tue, May 21, 2019 at 11:48 PM H.J. Lu wrote: > > On Sat, Feb 16, 2019 at 7:02 AM H.J. Lu wrote: > > > > On Thu, Feb 14, 2019 at 08:13:32PM -0800, H.J. Lu wrote: > > > NOTE_INSN_DELETED_LABEL is used to mark what used to be a 'code_label', > > > but was not used for other purposes than taking i

Re: Add GCC support to ENQCMD.

2019-05-27 Thread Hongtao Liu
On Fri, May 24, 2019 at 3:51 PM Uros Bizjak wrote: > > On Fri, May 24, 2019 at 9:43 AM Uros Bizjak wrote: > > > > On Fri, May 24, 2019 at 7:16 AM Hongtao Liu wrote: > > > > > > Hi Uros and all: > > > This patch is about to enable support for ENQCMD(Enqueue Command) > > > which will be in Willo

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-27 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Sat, 25 May 2019 at 19:41, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > > index 77d3dac..d6452a1 100644 > > --- a/gcc/tree-vect-loop-manip.c > > +++ b/gcc/tree-vect-lo

[committed] Add lastprivate(conditional:) support for the sections construct

2019-05-27 Thread Jakub Jelinek
Hi! This adds support for the sections construct, similarly to the worksharing loop construct only supported when not combined with parallel for now. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019-05-27 Jakub Jelinek * gimplify.c (gimplify_scan_omp_cl

[committed] Fix up lastprivate(conditional:) handling when assignment is nested inside critical, taskgroup or ordered construct

2019-05-27 Thread Jakub Jelinek
Hi! The store to the lastprivate(conditional:) private variable could be nested inside some other construct, the following patch deals with that. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019-05-27 Jakub Jelinek * omp-low.c (lower_omp_1) : Look throu

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Thomas Schwinge
Hi! I'm highly annoyed that we're wasting a lot of time arguing about such a minor item. On Mon, 27 May 2019 21:29:13 +0200, Jakub Jelinek wrote: > On Mon, May 27, 2019 at 09:05:06PM +0200, Thomas Schwinge wrote: > > > The arrays are emitted in the *.omplower dump, so I think it is much > > > b

[committed] Fix libgomp lastprivate conditional handling on some strict alignment targets (PR libgomp/90641)

2019-05-27 Thread Jakub Jelinek
Hi! While on x86_64-linux as well as i686-linux inline_ordered_team_ids array is long long aligned, on other targets like sparc solaris it is not due to different sizes of mutexes/pointer locks. The following patch makes sure that the memory used for lastprivate conditional is always long long al

[C/C++ PATCH] Reject __builtin_{add,sub,mul}_overflow with pointer to const integer as last arg (PR c/90628)

2019-05-27 Thread Jakub Jelinek
Hi! As the testcase shows, we are silently accepting writes into const variables, because the type generic builtins don't have a prototype. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-05-27 Jakub Jelinek PR c/90628 * c-common.c (che

Re: Hashtable comment cleanups & renamings

2019-05-27 Thread François Dumont
I had miss some occurences of __bucket_hint to replace with __bucket_count_hint so here is a new version. Ok to commit with the simple ChangeLog entry below ? On 5/21/19 7:42 AM, François Dumont wrote: Here is a simplified form.     Rename variables and cleanup comments.     * include/bits/h

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Jakub Jelinek
On Mon, May 27, 2019 at 09:05:06PM +0200, Thomas Schwinge wrote: > > The arrays are emitted in the *.omplower dump, so I think it is much better > > to scan-tree-dump their content > > That's not feasible in the general case. Why? The arrays have easily parseable names (.omp_data_kinds.N), then

gotools patch committed: Only chmod check-go-dir if it exists

2019-05-27 Thread Ian Lance Taylor
This patch tweaks the gotools Makefile to only chmod check-go-dir if it exists. This avoids a pointless error message in a fresh build. Bootstrapped and ran gotools tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2019-05-27 Ian Lance Taylor * Makefile.am (check-go-tool): Only chmod

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Thomas Schwinge
Hi! On Mon, 27 May 2019 18:51:22 +0200, Jakub Jelinek wrote: > On Sun, May 26, 2019 at 06:46:19PM +0200, Thomas Schwinge wrote: > > To establish some suitable testsuite coverage for a task that I'm working > > on, I need to do 'scan-tree-dump' of 'lower_omp_target' mapping kinds. > > Is the attac

[PATCH, i386]: Use generic gen_{add2,add3,sub2,sub3}_insn functions instead of ix86_gen_* global indirect functions

2019-05-27 Thread Uros Bizjak
... instead of ix86_gen_* global indirect functions to genreate Pmode add and sub functions. Finally, the patch removes all ix86_gen_* global indirect functions. No functional changes. 2019-05-27 Uroš Bizjak * config/i386/i386.c (ix86_gen_add3): Remove indirect function. (*ix86_gen_su

[PATCH] rs6000: Fix sanitizer build (PR90639)

2019-05-27 Thread Segher Boessenkool
The assembler code needs to say it uses AltiVec instructions. Tested on powerpc64-linux {-m32,-m64} and on powerpc64le-linux. Committing to trunk. 2019-05-27 Segher Boessenkool libsanitizer/ PR target/90639 * tsan/tsan_rtl_ppc64.S: Add ".machine altivec". --- libsanitizer/t

Re: [PATCH,RFC 0/3] Support for CTF in GCC

2019-05-27 Thread Indu Bhagat
Hi Michael, On 05/24/2019 06:04 AM, Michael Matz wrote: Hello, On Thu, 23 May 2019, Indu Bhagat wrote: OK. So I wonder how difficult it is to emit CTF by walking dwarf2outs own data structures? That is, in my view CTF should be emitted by dwarf2out_early_finish () (which is also the point

Re: Make possible 'scan-tree-dump' of 'lower_omp_target' mapping kinds

2019-05-27 Thread Jakub Jelinek
On Sun, May 26, 2019 at 06:46:19PM +0200, Thomas Schwinge wrote: > To establish some suitable testsuite coverage for a task that I'm working > on, I need to do 'scan-tree-dump' of 'lower_omp_target' mapping kinds. > Is the attached OK? > > Any suggestions about whether/how to restrict the (effecti

Re: [gomp] Add langhook, so that Fortran can privatize variables by reference

2019-05-27 Thread Jakub Jelinek
On Sun, May 26, 2019 at 07:43:04PM +0200, Thomas Schwinge wrote: > On Tue, 18 Oct 2005 03:01:40 -0400, Jakub Jelinek wrote: > > --- gcc/omp-low.c.jj2005-10-15 12:00:06.0 +0200 > > +++ gcc/omp-low.c 2005-10-18 08:46:23.0 +0200 > > @@ -126,7 +126,7 @@ is_variable_sized (tre

[PATCH, i386]: Define STACK_SIZE_MODE

2019-05-27 Thread Uros Bizjak
STACK_SIZE_MODE should be defined together with "allocate_stack" named pattern. 2019-05-27 Uroš Bizjak * config/i386/i386.h (STACK_SIZE_MODE): Define. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline SVN. Uros. Index: config/i386/i386.h =

Re: Simplify more EXACT_DIV_EXPR comparisons

2019-05-27 Thread Aldy Hernandez
I don't know if there's the -Walloca pass would benefit from merging with any of the others or vice versa, but superficially it seems like it might be worth thinking about integrating the -Walloc-larger-than warnings into the -Walloca pass, if only to keep similar functionality in the same plac

Re: [patch] Fix ICE in resolve_args_picking_1 with -gsplit-dwarf

2019-05-27 Thread Richard Biener
On Mon, May 27, 2019 at 10:32 AM Eric Botcazou wrote: > > The function simply doesn't handle the new location expression opcodes coming > from DebugFission (https://gcc.gnu.org/wiki/DebugFission). Fixed by making it > handle them like DW_OP_addr and DW_OP_const*. > > OK for mainline and the activ

Re: Simplify more EXACT_DIV_EXPR comparisons

2019-05-27 Thread Richard Biener
On Mon, May 27, 2019 at 3:09 PM Aldy Hernandez wrote: > > > > On 5/21/19 5:53 AM, Richard Biener wrote: > > On Tue, May 21, 2019 at 4:13 AM Martin Sebor wrote: > >> > >> On 5/20/19 3:16 AM, Richard Biener wrote: > >>> On Mon, May 20, 2019 at 10:16 AM Marc Glisse wrote: > > On Mon, 20 M

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-27 Thread Jan Hubicka
Hi, this is minimal version of patch adding just the pointer compare. Bootstrapped/regtested x86_64-linux, makes sense? :) Honza * tree-ssa-alias.c (same_type_for_tbaa): Return 1 if types same as pointers. Index: tree-ssa-alias.c ==

Patch ping (was Re: [C++ PATCH] P1091R3 - Extending structured bindings to be more like var decls)

2019-05-27 Thread Jakub Jelinek
Hi! On Mon, May 20, 2019 at 11:44:18PM +0200, Jakub Jelinek wrote: > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2019-05-20 Jakub Jelinek > > P1091R3 - Extending structured bindings to be more like var decls > P1381R1 - Reference capture of structured

Re: [PATCH] Fix PR88440, enable mem* detection at -O[2s]

2019-05-27 Thread Christophe Lyon
On Mon, 27 May 2019 at 09:26, Richard Biener wrote: > > On Mon, 27 May 2019, Christophe Lyon wrote: > > > On Thu, 23 May 2019 at 13:32, Richard Biener wrote: > > > > > > On Wed, 22 May 2019, Richard Biener wrote: > > > > > > > > > > > This enables -ftree-loop-distribute-patterns at -O[2s] and als

Re: Simplify more EXACT_DIV_EXPR comparisons

2019-05-27 Thread Aldy Hernandez
On 5/21/19 5:53 AM, Richard Biener wrote: On Tue, May 21, 2019 at 4:13 AM Martin Sebor wrote: On 5/20/19 3:16 AM, Richard Biener wrote: On Mon, May 20, 2019 at 10:16 AM Marc Glisse wrote: On Mon, 20 May 2019, Richard Biener wrote: On Sun, May 19, 2019 at 6:16 PM Marc Glisse wrote:

Re: [PATCH] Handle loop fields in IPA ICF (PR ipa/90555).

2019-05-27 Thread Jakub Jelinek
On Mon, May 27, 2019 at 02:18:37PM +0200, Martin Liška wrote: > +/* Compare loop information for basic blocks BB1 and BB2. */ > + > +bool > +func_checker::compare_loops (basic_block bb1, basic_block bb2) > +{ > + if ((bb1->loop_father == NULL) != (bb2->loop_father == NULL)) > +return return_f

Re: [PATCH] Handle loop fields in IPA ICF (PR ipa/90555).

2019-05-27 Thread Martin Liška
On 5/24/19 11:37 AM, Richard Biener wrote: > On Fri, May 24, 2019 at 10:08 AM Jakub Jelinek wrote: >> >> On Fri, May 24, 2019 at 09:48:03AM +0200, Martin Liška wrote: >>> gcc/ChangeLog: >>> >>> 2019-05-23 Martin Liska >>> >>> PR ipa/90555 >>> * ipa-icf-gimple.c (func_checker::compar

[Ada] Silence useless -Wuninitialized warning

2019-05-27 Thread Eric Botcazou
This silences a warning issued for the call to the initialization procedure of a record type on a misaligned component of another record type. Tested on x86_64-suse-linux, applied on the mainline and 9 branch. 2019-05-27 Eric Botcazou * gcc-interface/trans.c (Call_to_gnu): Do not in

[Ada] Add support for __builtin_expect and friends

2019-05-27 Thread Eric Botcazou
This adds support for __builtin_expect as well as __builtin_[un]likely in Ada. Tested on x86_64-suse-linux, applied on the mainline. 2019-05-27 Eric Botcazou * gcc-interface/ada-builtin-types.def: New file. * gcc-interface/ada-builtins.def: Likewise. * gcc-interface/a

Remove pre-Solaris 11/SPARC unwinding support

2019-05-27 Thread Rainer Orth
One of the last remnants of Solaris 10 (and 9)/SPARC support is the libgcc unwinder. To get rid of unused cruft, I've taken a full clone of the Solaris 11 support repository, checked out every since version of 32 and 64-bit libc.so.1 and checked if the patters looked for in sol2-unwind.h are prese

[Ada] Fix minor warning issue

2019-05-27 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline, 9 and 8 branches. 2019-05-27 Eric Botcazou * gcc-interface/utils.c (maybe_pad_type): Issue the warning for the specific case of component types preferably. -- Eric Botcazou Index: gcc-interface/utils.c ===

[Ada] Do not generate dangling references to bounds

2019-05-27 Thread Eric Botcazou
This prevents gigi from generating dangling references to the bounds of an aliased parameter of an unconstrained array type. This cannot happen in strict Ada but you can bypass the rules by means of 'Unchecked_Access. Tested on x86_64-suse-linux, applied on the mainline and 9 branch. 2019-05-

[v3 PATCH] basic_string spurious use of a default constructible allocator - LWG2788

2019-05-27 Thread Nina Dinka Ranns
Tested on Linux x86_64 basic_string spurious use of a default constructible allocator - LWG2788 2019-05-27 Nina Dinka Ranns basic_string spurious use of a default constructible allocator - LWG2788 * bits/basic_string.tcc: (_M_replace_dispatch()): string temporary now con

[Ada] Fix internal error on limited view of incomplete type

2019-05-27 Thread Eric Botcazou
This fixes an ICE on a package whose spec has a limited_with clause of another package, whose body has a with clause of the same other package and uses a type which is first declared as incomplete in this other package. Tested on x86_64-suse-linux, applied on the mainline and 9 branch. 2019-05

[PATCH] Fix PR90637

2019-05-27 Thread Richard Biener
The following fixes GIMPLE stmt sinking to not sink a stmt into a loop. It actually chooses the correct basic-block to sink to but just ignores that when computing the stmt iterator to sink to... Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2019-05-27 Richard Biener

[PATCH] Fix PR90610

2019-05-27 Thread Richard Biener
Another mistake in the vec_perm -> bit_insert change. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2019-05-27 Richard Biener PR middle-end/90610 * match.pd (vec_perm): Avoid clobbering op0 when not generating a bit-insert. Index: gcc/matc

[Ada] Fix spurious error on unchecked conversion to misaligned type

2019-05-27 Thread Eric Botcazou
This is a regression present on the mainline, 9 and 8 branches. The compiler issues a spurious error on the result of an unchecked conversion used as an actual In parameter in a subprogram call, if the destination type is a scalar type subject to a clause which gives an alignment lower than the

[AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-27 Thread Prathamesh Kulkarni
Hi, The attached patch tries to improve initialization for fixed-length SVE vector and it's algorithm is described in comments for aarch64_sve_expand_vector_init() in the patch, with help from Richard Sandiford. I verified tests added in the patch pass with qemu and am trying to run bootstrap+test

[Ada] Improve code generated for Left_Rotate from Interfaces

2019-05-27 Thread Eric Botcazou
This tweaks the GENERIC code emitted by gigi for the Left_Rotate routine from the Interfaces package so as to expose more optimization opportunities. Tested on x86_64-suse-linux, applied on the mainline. 2019-05-27 Eric Botcazou * gcc-interface/trans.c (gnat_to_gnu) : Convert the

[wwwdocs] readings.html - opengroup.org has moved to https

2019-05-27 Thread Gerald Pfeifer
...so we should update our link, too. Committed. Gerald Index: readings.html === RCS file: /cvs/gcc/wwwdocs/htdocs/readings.html,v retrieving revision 1.312 diff -u -r1.312 readings.html --- readings.html 26 May 2019 19:39:47

[PATCH v4] Use builtin sort instead of shell sort

2019-05-27 Thread Émeric Dupont
v4: Handling wildcard files correctly Some build environments and configuration options may lead to the make variable PLUGIN_HEADERS being too long to be passed as parameters to the shell `echo` command, leading to a "write error" message when making the target install-plugin. The following patch

[patch] Fix ICE in resolve_args_picking_1 with -gsplit-dwarf

2019-05-27 Thread Eric Botcazou
The function simply doesn't handle the new location expression opcodes coming from DebugFission (https://gcc.gnu.org/wiki/DebugFission). Fixed by making it handle them like DW_OP_addr and DW_OP_const*. OK for mainline and the active branches (it's a regression from GCC 5)? 2019-05-27 Eric Bo

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-27 Thread Jan Hubicka
> The way you do it above seeing struct X p will end up comparing > 'struct X' but that doesn't really have any say on whether we > can apply TBAA to the outermost pointer type which, if used as a base, > cannot be subsetted by components anyway. We remove pointers in pairs so seeing struct X

Re: [PATCH v3] Use builtin sort instead of shell sort

2019-05-27 Thread Émeric Dupont
The 20.04.2019 09:23, Andreas Schwab wrote: >On Apr 20 2019, Émeric Dupont wrote: >> diff --git a/gcc/Makefile.in b/gcc/Makefile.in >> index d186d71c91e..3196e774a26 100644 >> --- a/gcc/Makefile.in >> +++ b/gcc/Makefile.in >> @@ -3538,7 +3538,7 @@ install-plugin: installdirs lang.install-plugin >

[PATCH] Fix PR90615

2019-05-27 Thread Richard Biener
Committed. Richard. 2019-05-27 Richard Biener PR testsuite/90615 * gcc.dg/vect/costmodel/ppc/costmodel-vect-31b.c: Add -fno-tree-loop-distribute-patterns. * gcc.dg/vect/costmodel/ppc/costmodel-vect-33.c: Likewise. * gcc.dg/vect/costmodel/ppc/costmodel

Re: [PATCH] Fix PR88440, enable mem* detection at -O[2s]

2019-05-27 Thread Richard Biener
On Mon, 27 May 2019, Christophe Lyon wrote: > On Thu, 23 May 2019 at 13:32, Richard Biener wrote: > > > > On Wed, 22 May 2019, Richard Biener wrote: > > > > > > > > This enables -ftree-loop-distribute-patterns at -O[2s] and also > > > arranges cold loops to be still processed but for pattern > >

Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers

2019-05-27 Thread Richard Biener
On Sat, 25 May 2019, Alex Henrie wrote: > On Sat, May 25, 2019 at 12:34 AM Richard Biener wrote: > > > > On May 24, 2019 5:49:38 PM GMT+02:00, Alex Henrie > > wrote: > > >As far as I can tell, "fndecl" is a misnomer: these attributes are > > >more accurately called "function definition attribut

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-05-27 Thread Richard Biener
On Fri, 24 May 2019, Jan Hubicka wrote: > > > so about 5 times increase of alias_components_refs_p disambiguations. > > > > Note the number of queries also changes so it's "somewhat" comparing > > apples and oranges (possibly the alias walk doesn't have to give up > > and thus we walk more and do