[PATCH] Enable GCC support for AVX512_VP2INTERSECT.

2019-06-05 Thread Hongtao Liu
Hi Uros and all: This patch is about to enable support for AVX512_VP2INTERSECT which will be in Willow Cove. There are two instructions for AVX512_VP2INTERSECT: VP2INTERSECTD and VP2INTERSECTQ. More details please refer to https://software.intel.com/sites/default/files/managed/c5/15/architecture-

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-05 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. Attached is the latest patch. For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I am limiting fwprop in cases like this. Is there a better fix for this? index cf2c9de..2c99285 100644 --- a/gcc/fwprop.c +++ b/gcc/fwprop.c @@ -1358,6 +1358,15 @@

Re: [PATCH] Enable memory operand for vfpclass[p,s][s,d] patterns.

2019-06-05 Thread Hongtao Liu
On Thu, Jun 6, 2019 at 6:18 AM Jeff Law wrote: > > On 6/5/19 1:39 AM, Hongtao Liu wrote: > > Hi Jeff and Jakub: > > When adding new intrinsics(PR target/89803), i found vfpclassp[sd], > > vfpclasss[sd] patterns didn't support memory operand which is > > supported in instructions. So this patch i

Go patch committed: Use specialized fast map routines

2019-06-05 Thread Ian Lance Taylor
In the Go runtime there are specialized fast map routines for certain kep types. This Go frontend patch by Cherry Zhang lets the compiler make use of thesefunctions, instead of always using the generic ones. As we now generate multiple versions of map delete calls, to make things easier we delay

Re: [PATCH] RX: Add rx-*-linux target

2019-06-05 Thread Jeff Law
On 6/3/19 11:01 AM, Yoshinori Sato wrote: > On Sun, 02 Jun 2019 22:12:37 +0900, > Oleg Endo wrote: >> >> On Sun, 2019-06-02 at 20:26 +0900, Yoshinori Sato wrote: >>> On Fri, 31 May 2019 09:16:18 +0900, >>> Jeff Law wrote: On 5/29/19 12:27 PM, Jeff Law wrote: > On 5/23/19 6:05 AM, Yosh

Re: [PATCH] RX: Add rx-*-linux target

2019-06-05 Thread Jeff Law
On 6/2/19 5:26 AM, Yoshinori Sato wrote: > On Fri, 31 May 2019 09:16:18 +0900, > Jeff Law wrote: >> >> On 5/29/19 12:27 PM, Jeff Law wrote: >>> On 5/23/19 6:05 AM, Yoshinori Sato wrote: I ported linux kernel to Renesas RX. rx-*-elf target output a binary different from the standard E

[PATCH] handle vla plus offset in strlen (PR 90662)

2019-06-05 Thread Martin Sebor
One of my new tests for the strlen/sprintf integration tripped over an incomplete handling of VLAs by the strlen pass. Where it can determine the length of a substring at some offset with other kinds of arrays, the pass fails with VLAs because they are represented as pointers to arrays. The atta

Re: [PATCH] [MIPS] Inhibit trailing .insn if pool is not followed by code

2019-06-05 Thread Maciej W. Rozycki
On Wed, 5 Jun 2019, Jeff Law wrote: > > Thanks for looking into it. FWIW I think the `__pend' symbol will best > > be still emitted for consistency, however as STT_OBJECT and consequently > > with no trailing `.insn'. > If I understand correctly we'd still want to call > mips_set_text_contents

Re: [PATCH] preserve integer value of local addresses returned from functions (PR 90737)

2019-06-05 Thread Jeff Law
On 6/3/19 3:24 PM, Martin Sebor wrote: > While testing a different -Wreturn-local-addr bug fix/enhancement > I noticed that in functions that return integers as opposed to > pointers such as: > >   intptr_t f (int i) { return (intptr_t)&i; } > > the converted address is folded to zero.  This can 

Re: [PATCH][MSP430][4/4] Implement 64-bit shifts in assembly code

2019-06-05 Thread Jeff Law
On 6/4/19 7:17 AM, Jozef Lawrynowicz wrote: > This patch implements 64-bit shifts in assembly code. Previously, generic C > library code from libgcc would be used to perform the shifts, which was much > more costly in terms of code size. > > I observed 700 PASS->FAIL regressions from the GCC tests

Re: [PATCH] [MIPS] Inhibit trailing .insn if pool is not followed by code

2019-06-05 Thread Jeff Law
On 6/4/19 3:07 PM, Maciej W. Rozycki wrote: > On Mon, 3 Jun 2019, Faraz Shahbazker wrote: > >> The __pool and __pend symbols are used to mark the beginning and end of >> inline constant pools in MIPS16 code regions. However if the pool occurs >> at the boundary of a code region and is not followe

Re: [PATCH] Put __dso_handle in .sdata/.sbss on ia64

2019-06-05 Thread Jeff Law
On 6/1/19 6:30 PM, James Clarke wrote: > The symbol is exposed to C by dso_handle.h, and since it's a single > 8-byte pointer, it is just within the threshold for being in the small > data (or bss) section, so code accessing it will use GP-relative > addressing. Therefore we must put it in .sdata/.

Re: [PATCH][MSP430][3/4] Disable performance optimal library code shifts when optimizing for size

2019-06-05 Thread Jeff Law
On 6/4/19 7:14 AM, Jozef Lawrynowicz wrote: > This patch reduces code size by disabling the performance optimized, > "const_variant" of shift library functions when optimization for size is > enabled. > > For the following program, the below code size reduction is observed: > long a; > > int

Re: [PATCH][MSP430][2/4] Emulate 16-bit shifts with rotate insn when src operand is originally in memory

2019-06-05 Thread Jeff Law
On 6/4/19 7:11 AM, Jozef Lawrynowicz wrote: > This patch reduces code size by enabling the emulation of some 16-bit shift > instructions with the native rotate instructions, when the source operand is > in > memory. This is achieved by forcing the source operand into a register. > > For the follo

Re: [PATCH][MSP430][1/4] Put libgcc shift functions in their own sections

2019-06-05 Thread Jeff Law
On 6/4/19 7:07 AM, Jozef Lawrynowicz wrote: > This patch reduces code size by putting each of the shift library functions > from > libgcc in their own section. This means that, for example, a 16-bit logical > left shift does not result in code to perform a 32-bit logical left shift > being > incl

Re: [PATCH] Enable memory operand for vfpclass[p,s][s,d] patterns.

2019-06-05 Thread Jeff Law
On 6/5/19 1:39 AM, Hongtao Liu wrote: > Hi Jeff and Jakub: > When adding new intrinsics(PR target/89803), i found vfpclassp[sd], > vfpclasss[sd] patterns didn't support memory operand which is > supported in instructions. So this patch is about to enable memory > operands for vfpclassp[s,d]/vfpcl

Re: [PATCH] IPA ICF: enhance dump output

2019-06-05 Thread Jeff Law
On 6/4/19 8:38 AM, Martin Liška wrote: > Hi. > > The patch is about simplification of dump output. Plus it prints > also a file in which the dump message was emitted. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc

Re: [PATCH] Fix HTML headers and titles for 'Installing GCC' pages (PR web/87933).

2019-06-05 Thread Jeff Law
On 6/5/19 3:09 AM, Martin Liška wrote: > Hi. > > The patch fixes wrong titles/header in 'Installing GCC' pages. > > Tested with make html. > Ready for trunk? > > Martin > > gcc/ChangeLog: > > 2019-06-05 Martin Liska > > PR web/87933 > * doc/install.texi: Fix HTML headers and >

Re: undefined behavior in value_range::equiv_add()?

2019-06-05 Thread Jeff Law
On 6/4/19 9:04 AM, Richard Biener wrote: > On Tue, Jun 4, 2019 at 3:40 PM Jeff Law wrote: >> >> On 6/4/19 5:23 AM, Richard Biener wrote: >>> On Tue, Jun 4, 2019 at 12:30 AM Jeff Law wrote: On 6/3/19 7:13 AM, Aldy Hernandez wrote: > On 5/31/19 5:00 AM, Richard Biener wrote: >>

Go patch committed: Make calls and functions inlinable

2019-06-05 Thread Ian Lance Taylor
This patch to the Go frontend makes call expressions and function reference expressions inlinable. We now scan inlinable methods for references to global variables and functions (I forgot to do that earlier). We now track all packages mentioned by exports (that should have been done earlier too).

Re: [PATCH] Improve PTA flow-sensitivity (for the return stmt)

2019-06-05 Thread Jeff Law
On 6/5/19 6:51 AM, Richard Biener wrote: > > The following was inspired by Marins work on escapes of locals > and the discussion there. It teaches points-to analysis that > the point of function return is special and thus escapes through > that a) do not influence other points-to solutions, b) ca

Re: Patch: don't cap TYPE_PRECISION of bitsizetype at MAX_FIXED_MODE_SIZE

2019-06-05 Thread Eric Botcazou
> This issue exists, not just for targets that can have their > MAX_FIXED_MODE_SIZE more-or-less easily tweaked higher, but also > for the 'bit-container' targets where it *can't* be set higher. > > Let's please DTRT and correct the code here in the middle-end, > so we don't ICE for those targets

Re: Patch: don't cap TYPE_PRECISION of bitsizetype at MAX_FIXED_MODE_SIZE

2019-06-05 Thread Hans-Peter Nilsson
> From: Richard Biener > Date: Wed, 29 May 2019 15:04:42 +0200 > On Tue, May 28, 2019 at 5:43 PM Hans-Peter Nilsson > wrote: > > > > TL;DR: instead of capping TYPE_PRECISION of bitsizetype at > > MAX_FIXED_MODE_SIZE, search for the largest fitting size from > > scalar_int_mode modes supported by

Re: Review Hashtable extract node API

2019-06-05 Thread Jonathan Wakely
On 05/06/19 17:43 +0100, Jonathan Wakely wrote: On 05/06/19 17:22 +0100, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: @@ -669,18 +670,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __node_base* _M_get_previous_node(size_type __bkt, __node_base* __n); - // Insert

Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
On Wed, 5 Jun 2019 at 19:19, Jason Merrill wrote: > On 6/5/19 1:29 PM, Nina Dinka Ranns wrote: > > Ack. Amended change log is below. Changes are : > > * changed C++ -> c++ > > * fixed the name of added test > > > > There are no changes in the diff, but I attached it to this e-mail for > > referen

Re: [wwwdocs] Document existence of openacc-gcc-9-branch

2019-06-05 Thread Julian Brown
On Wed, 5 Jun 2019 10:30:41 +0200 Thomas Schwinge wrote: > Hi Julian! > > On Tue, 4 Jun 2019 23:05:53 +0100, Julian Brown > wrote: > > I've pushed a new branch "openacc-gcc-9-branch" to the Git > > mirror (i.e. as a Git-only branch), for development of OpenACC and > > related functionality on t

Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-05 Thread Jason Merrill
On 6/5/19 2:09 PM, Paolo Carlini wrote: Hi, On 05/06/19 19:45, Jason Merrill wrote: On 6/4/19 11:57 AM, Paolo Carlini wrote: Hi, On 04/06/19 16:50, Jason Merrill wrote: On 6/4/19 10:31 AM, Paolo Carlini wrote: +  permerror (loc, "member functions are implicitly " + "frie

Re: [PATCH] fix more -Wformat-diag issues

2019-06-05 Thread Martin Sebor
On 5/31/19 12:20 PM, Jeff Law wrote: On 5/31/19 9:56 AM, Martin Sebor wrote: On 5/30/19 5:49 PM, Jeff Law wrote: So in several places there's a comment which indicates that debugging dumps and the like do not follow conventions.  Presumably you've tried to keep a narrow scope on the diagnostic

Re: PR C++/63149

2019-06-05 Thread Jason Merrill
On 6/5/19 1:29 PM, Nina Dinka Ranns wrote: Ack. Amended change log is below. Changes are : * changed C++ -> c++ * fixed the name of added test There are no changes in the diff, but I attached it to this e-mail for reference. Applied, thanks! For future reference it's also customary to add a b

Re: [PATCH] alpha: Use TARGET_COMPUTE_FRAME_LAYOUT

2019-06-05 Thread Uros Bizjak
> At the same time, merge several related frame computing functions. > Recall that HWI is now always 64-bit, so merge IMASK and FMASK, > which allows merging of several loops within prologue and epilogue. > > Full regression testing will take some time, but a quick browse > suggests no change in ge

Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-05 Thread Paolo Carlini
Hi, On 05/06/19 19:45, Jason Merrill wrote: On 6/4/19 11:57 AM, Paolo Carlini wrote: Hi, On 04/06/19 16:50, Jason Merrill wrote: On 6/4/19 10:31 AM, Paolo Carlini wrote: +  permerror (loc, "member functions are implicitly " + "friends of their class"); Wouldn't it be be

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-06-05 Thread Jason Merrill
On 6/3/19 6:33 PM, Joseph Myers wrote: On Sun, 2 Jun 2019, Segher Boessenkool wrote: Git has an identity (well, two) _per commit_, and there is no way you can reconstruct people's prefered name and email address (at any point in time, for every commit separately) correctly. IMO it is much bett

Re: [C++ Patch] Improve check_special_function_return_type locations

2019-06-05 Thread Jason Merrill
On 6/5/19 11:06 AM, Paolo Carlini wrote: Hi, here certainly we can do better than using input_location. In principle we could also pass the location of the entity (constructor, destructor, etc) itself or something else but I think it makes a lot of sense to simply include locations[ds_type_sp

Re: [C++ Patch] Use declarator->id_loc in three additional places

2019-06-05 Thread Jason Merrill
On 6/4/19 11:57 AM, Paolo Carlini wrote: Hi, On 04/06/19 16:50, Jason Merrill wrote: On 6/4/19 10:31 AM, Paolo Carlini wrote: +  permerror (loc, "member functions are implicitly " + "friends of their class"); Wouldn't it be better to use the location of "friend" in this d

Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
Ack. Amended change log is below. Changes are : * changed C++ -> c++ * fixed the name of added test There are no changes in the diff, but I attached it to this e-mail for reference. Thanks, Nina 2019-06-04 Nina Dinka Ranns gcc/cp PR c++/63149 * pt.c (listify_autos): Use non cv qu

Re: Review Hashtable extract node API

2019-06-05 Thread Jonathan Wakely
On 05/06/19 17:22 +0100, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: @@ -669,18 +670,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __node_base* _M_get_previous_node(size_type __bkt, __node_base* __n); - // Insert node with hash code __code, in bucket bkt if no

[PATCH] rs6000: Fix new testcase

2019-06-05 Thread Segher Boessenkool
At least with -m32 you need -maltivec if you #include . Tested on powerpc64-linux {-m32,-m64); committing to trunk. Segher 2019-06-05 Segher Boessenkool gcc/testsuite/ * g++.target/powerpc/undef-bool-3.C: Add -maltivec to dg-options. --- gcc/testsuite/g++.target/powerpc/undef-bool

Re: Review Hashtable extract node API

2019-06-05 Thread Jonathan Wakely
On 04/06/19 19:19 +0200, François Dumont wrote: Hi     Here is a patch to enhance the _Hashtable extract node API and fix a FIXME request.     The enhancement to the extract node Api is that extract(const key_type&) do not call extract(const_iterator) anymore. Doing so we had to loop again

[C++ Patch] Improve check_special_function_return_type locations

2019-06-05 Thread Paolo Carlini
Hi, here certainly we can do better than using input_location. In principle we could also pass the location of the entity (constructor, destructor, etc) itself or something else but I think it makes a lot of sense to simply include locations[ds_type_spec] in the computation, seems consistent

[PATCH] AIX unwind register number fixes

2019-06-05 Thread David Edelsohn
The recent changes to rs6000 "debug" register numbers created a conflict in libgcc aix unwind support. aix-unwind.h provided definitions of the DWARF register numbers for its own reference. After the internal register number changes and the definition of those register names in rs6000.md, the regi

Re: [0/3] Improve debug info for addressable vars

2019-06-05 Thread Richard Sandiford
Richard Biener writes: > On Sat, Jun 1, 2019 at 5:49 PM Richard Sandiford > wrote: >> >> Taking the address of a variable stops us doing var-tracking on it, >> so that we just use the DECL_RTL instead. This can easily cause wrong >> debug info for regions of code that would have had correct debu

Re: Ping: [PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-06-05 Thread Richard Sandiford
Thanks for the patch and sorry that there was no response. I've added the C++ maintainers to cc: nick writes: > I'm pinging this patch as it's old now and should be applied to fix the bug. > > Nick > > On 2019-04-08 7:20 p.m., Nicholas Krause wrote: >> This fixes the caller in tsubst_requires_exp

Re: [PATCH] Improve PTA flow-sensitivity (for the return stmt)

2019-06-05 Thread Richard Biener
On Wed, 5 Jun 2019, Martin Sebor wrote: > On 6/5/19 6:51 AM, Richard Biener wrote: > > > > The following was inspired by Marins work on escapes of locals > > and the discussion there. It teaches points-to analysis that > > the point of function return is special and thus escapes through > > that

Re: [PATCH 0/4] Store multiple values for single value profilers

2019-06-05 Thread Richard Biener
On Tue, Jun 4, 2019 at 10:44 AM Martin Liska wrote: > > Hi. > > It's becoming more common that a training run happens in parallel environment. > That can lead to a not reproducible builds caused by different order of > merging > of .gcda files. So that I'm suggesting to store up to 4 values for

Re: [PATCH] Improve PTA flow-sensitivity (for the return stmt)

2019-06-05 Thread Martin Sebor
On 6/5/19 6:51 AM, Richard Biener wrote: The following was inspired by Marins work on escapes of locals and the discussion there. It teaches points-to analysis that the point of function return is special and thus escapes through that a) do not influence other points-to solutions, b) can be pru

Re: [0/3] Improve debug info for addressable vars

2019-06-05 Thread Richard Biener
On Sat, Jun 1, 2019 at 5:49 PM Richard Sandiford wrote: > > Taking the address of a variable stops us doing var-tracking on it, > so that we just use the DECL_RTL instead. This can easily cause wrong > debug info for regions of code that would have had correct debug info > if the variable weren't

Re: [PATCH] Simplify mult where both arguments are 0 or 1 (PR tree-optimization/87954).

2019-06-05 Thread Martin Liška
On 6/5/19 3:04 PM, Richard Biener wrote: > On Wed, Jun 5, 2019 at 2:09 PM Martin Liška wrote: >> >> On 6/5/19 1:13 PM, Richard Biener wrote: >>> On Wed, Jun 5, 2019 at 12:56 PM Martin Liška wrote: Hi. I'm suggesting one multiplication simplification pattern. Patch ca

H!..

2019-06-05 Thread Joy
Hello Dear,is Joy from Belgium. Please can we have a discussion that will bring fortune to us? Kindly reply me. Thanks.

Re: [PATCH] Simplify mult where both arguments are 0 or 1 (PR tree-optimization/87954).

2019-06-05 Thread Richard Biener
On Wed, Jun 5, 2019 at 2:09 PM Martin Liška wrote: > > On 6/5/19 1:13 PM, Richard Biener wrote: > > On Wed, Jun 5, 2019 at 12:56 PM Martin Liška wrote: > >> > >> Hi. > >> > >> I'm suggesting one multiplication simplification pattern. > >> > >> Patch can bootstrap on x86_64-linux-gnu and survives

Re: PR C++/63149

2019-06-05 Thread Marek Polacek
On Wed, Jun 05, 2019 at 02:50:54PM +0200, Jakub Jelinek wrote: > On Wed, Jun 05, 2019 at 08:39:56AM -0400, Marek Polacek wrote: > > On Wed, Jun 05, 2019 at 10:34:05AM +0100, Nina Dinka Ranns wrote: > > > > PR C++/63149 > > > > * pt.c (listify_autos): Use non cv qualified auto_node in > > >

Re: PR C++/63149

2019-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2019 at 08:39:56AM -0400, Marek Polacek wrote: > On Wed, Jun 05, 2019 at 10:34:05AM +0100, Nina Dinka Ranns wrote: > > > PR C++/63149 > > > * pt.c (listify_autos): Use non cv qualified auto_node in > > > std::initializer_list. > > > > > > testsuite/ > > > > > > P

[PATCH] Improve PTA flow-sensitivity (for the return stmt)

2019-06-05 Thread Richard Biener
The following was inspired by Marins work on escapes of locals and the discussion there. It teaches points-to analysis that the point of function return is special and thus escapes through that a) do not influence other points-to solutions, b) can be pruned of all locals. This is one example of

Re: PR C++/63149

2019-06-05 Thread Marek Polacek
On Wed, Jun 05, 2019 at 10:34:05AM +0100, Nina Dinka Ranns wrote: > > PR C++/63149 > > * pt.c (listify_autos): Use non cv qualified auto_node in > > std::initializer_list. > > > > testsuite/ > > > > PR C++/63149 "c++" instead of "C++", thought I don't think anyone would mind.

Backports to gcc-9-branch

2019-06-05 Thread Jakub Jelinek
Hi! I've backported following 4 patches from trunk to 9 branch, bootstrapped/regtested on x86_64-linux and i686-linux, committed. Jakub 2019-06-05 Jakub Jelinek Backported from mainline 2019-05-24 Jakub Jelinek PR libgomp/90585 * plugin/plugin-hsa.c

Re: [PATCH] Simplify mult where both arguments are 0 or 1 (PR tree-optimization/87954).

2019-06-05 Thread Richard Sandiford
Martin Liška writes: > On 6/5/19 1:13 PM, Richard Biener wrote: >> On Wed, Jun 5, 2019 at 12:56 PM Martin Liška wrote: >>> >>> Hi. >>> >>> I'm suggesting one multiplication simplification pattern. >>> >>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >>> >>> Ready to be i

Re: [PATCH] Simplify mult where both arguments are 0 or 1 (PR tree-optimization/87954).

2019-06-05 Thread Martin Liška
On 6/5/19 1:13 PM, Richard Biener wrote: > On Wed, Jun 5, 2019 at 12:56 PM Martin Liška wrote: >> >> Hi. >> >> I'm suggesting one multiplication simplification pattern. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > + (if (INTEGRAL_T

Re: [PATCH] Testsuite: Add s390 exceptions for gen-vect

2019-06-05 Thread Robin Dapp
Ping. > gcc/testsuite/ChangeLog: > > 2019-05-15 Robin Dapp > > * gcc.dg/tree-ssa/gen-vect-26.c: Do not expect unaligned access > vectorization on s390. > * gcc.dg/tree-ssa/gen-vect-28.c: Likewise. > * gcc.dg/tree-ssa/gen-vect-32.c: Likewise. >

Re: [PATCH] Integrate non-TBB serial backend support

2019-06-05 Thread Jonathan Wakely
On 04/06/19 15:47 -0700, Thomas Rodgers wrote: * include/bits/c++config: Adjust TBB detection logic to select serial PSTL backend if no TBB present. * testsuite/utils/pstl/test_utils.h: Remove check for __PSTL_USE_PAR_POLICIES The changelog says __PSTL_USE_PAR_PO

Re: [PATCH] Simplify mult where both arguments are 0 or 1 (PR tree-optimization/87954).

2019-06-05 Thread Richard Biener
On Wed, Jun 5, 2019 at 12:56 PM Martin Liška wrote: > > Hi. > > I'm suggesting one multiplication simplification pattern. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? + (if (INTEGRAL_TYPE_P (type) + && wi::eq_p (get_nonzero_bits (@1)

Re: [PATCH][GCC][AARCH64] Add tests for pointer authentication B-key

2019-06-05 Thread Sam Tebbs
Committed as obvious as r271954. On 05/06/2019 11:20, Sam Tebbs wrote: > Hi all, > > When committing my b-key patch (r271735) I didn't svn add the new test > files, this patch adds them and moves the exception tests to > g++.target/aarch64. > > Tested on aarch64-none-linux-gnu and aarch64-none-elf

Re: [PATCH V6] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-06-05 Thread Richard Biener
On Tue, Jun 4, 2019 at 5:24 PM Feng Xue OS wrote: > > Some changes on documentation. Please name the option -ffinite-loops (plural), the patch is OK with this change if you also adjust > + /* If the loop has any non-EH exit, we can assume it will terminate. */ > + FOR_EACH_VEC_ELT (exi

[PATCH] Simplify mult where both arguments are 0 or 1 (PR tree-optimization/87954).

2019-06-05 Thread Martin Liška
Hi. I'm suggesting one multiplication simplification pattern. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-06-05 Martin Liska PR tree-optimization/87954 * match.pd: Simplify mult where both

Re: [C++ PATCH] decls with error_node type

2019-06-05 Thread Nathan Sidwell
On 6/3/19 1:30 PM, Jason Merrill wrote: On 5/31/19 1:39 PM, Nathan Sidwell wrote: The fallout is some error cascade on symbol lookups that now fail. Right, that's why we had the previous behavior, to avoid this extra noise.  And then various places check error_operand_p to avoid trying to

Re: [PR90743] Fortran 'allocatable' with OpenACC data/OpenMP 'target' 'map' clauses

2019-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2019 at 12:26:32PM +0200, Thomas Schwinge wrote: > Hi Jakub! > > On Wed, 5 Jun 2019 12:00:25 +0200, Jakub Jelinek wrote: > > On Wed, Jun 05, 2019 at 11:25:07AM +0200, Thomas Schwinge wrote: > > > + !$omp target map(to: a) map(tofrom: b, c, d) map(from: e) > > > + !$acc parallel

Re: [C++ PATCH] structure tag lookup.

2019-06-05 Thread Nathan Sidwell
On 6/4/19 11:20 AM, Marek Polacek wrote: On Tue, Jun 04, 2019 at 11:13:14AM -0400, Nathan Sidwell wrote: [...] + /* Now check if we can look in namespace scope. */ + for (; b->kind != sk_namespace; b = b->level_chain) +if (!(b->kind == sk_cleanup + || b->kind == sk_template_pa

Re: [PR90743] Fortran 'allocatable' with OpenACC data/OpenMP 'target' 'map' clauses

2019-06-05 Thread Thomas Schwinge
Hi Jakub! On Wed, 5 Jun 2019 12:00:25 +0200, Jakub Jelinek wrote: > On Wed, Jun 05, 2019 at 11:25:07AM +0200, Thomas Schwinge wrote: > > + !$omp target map(to: a) map(tofrom: b, c, d) map(from: e) > > + !$acc parallel copyin(a) copy(b, c, d) copyout(e) > > Is mixing OpenMP and OpenACC construc

[PATCH][GCC][AARCH64] Add tests for pointer authentication B-key

2019-06-05 Thread Sam Tebbs
Hi all, When committing my b-key patch (r271735) I didn't svn add the new test files, this patch adds them and moves the exception tests to g++.target/aarch64. Tested on aarch64-none-linux-gnu and aarch64-none-elf. OK for trunk? gcc/testsuite 2019-06-05  Sam Tebbs * gcc.target/aarch64/

Re: [PATCH] Find constant definition for by-ref argument using dominance information (PR ipa/90401)

2019-06-05 Thread Richard Biener
On Wed, Jun 5, 2019 at 10:59 AM Feng Xue OS wrote: > > IPA-CP can not identify a constant by-ref argument to a function, if > definition > of the argument is not in same basic block where the callsite lies in. This is > because IPA-CP only does local search in the callsite basic block.So this >

Re: [PR90743] Fortran 'allocatable' with OpenACC data/OpenMP 'target' 'map' clauses

2019-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2019 at 11:25:07AM +0200, Thomas Schwinge wrote: > libgomp/ > PR fortran/90743 > * oacc-parallel.c (GOACC_parallel_keyed): Handle NULL case. > * testsuite/libgomp.fortran/target-allocatable-1.f90: New file. > * testsuite/libgomp.oacc-fortran/allocatable

Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
yes, I forgot to attach the latest patch. :) On Wed, 5 Jun 2019 at 10:24, Nina Dinka Ranns wrote: > > Hi both, > Addressing all comments in this e-mail, as some are duplicate. > > On Tue, 4 Jun 2019 at 20:45, Paolo Carlini wrote: > > > > Hi, > > > > On 04/06/19 21:26, Nina Dinka Ranns wrote: > >

[PR90743] Fortran 'allocatable' with OpenACC data/OpenMP 'target' 'map' clauses

2019-06-05 Thread Thomas Schwinge
Hi! After having learned from PR90741 "Unreachable second '__builtin_malloc' for scalar 'allocatable'", I then in context of PR90743 "Device-side 'malloc' for Fortran 'allocatable' scalar" had a look at what OpenMP 5.0 is saying about Fortran 'allocatable' in 'map' clauses, and suggest to document

Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
Hi both, Addressing all comments in this e-mail, as some are duplicate. On Tue, 4 Jun 2019 at 20:45, Paolo Carlini wrote: > > Hi, > > On 04/06/19 21:26, Nina Dinka Ranns wrote: > > Good point, dg-do compile is sufficient to demonstrate the issue. > > I agree. > > A couple of additional nits, sorr

Re: [PATCH] Fix var-tracking ICE with complex subregs (PR debug/90733)

2019-06-05 Thread Richard Biener
On Wed, 5 Jun 2019, Jakub Jelinek wrote: > Hi! > > On the following testcase, we have: > (debug_insn 45 20 22 2 (var_location:DI D#4 (const_int 0 [0])) -1 (nil)) > (debug_insn 22 45 26 2 (debug_marker) "pr90733.c":16:3 -1 (nil)) > (debug_insn 26 22 27 2 (var_location:CSI D#3 (subreg:CSI (debug_ex

[PATCH] Fix HTML headers and titles for 'Installing GCC' pages (PR web/87933).

2019-06-05 Thread Martin Liška
Hi. The patch fixes wrong titles/header in 'Installing GCC' pages. Tested with make html. Ready for trunk? Martin gcc/ChangeLog: 2019-06-05 Martin Liska PR web/87933 * doc/install.texi: Fix HTML headers and titles for 'Installing GCC' pages. --- gcc/doc/install.tex

[PATCH] Find constant definition for by-ref argument using dominance information (PR ipa/90401)

2019-06-05 Thread Feng Xue OS
IPA-CP can not identify a constant by-ref argument to a function, if definition of the argument is not in same basic block where the callsite lies in. This is because IPA-CP only does local search in the callsite basic block.So this patch implemented an enhanced algorithm, which uses dominance info

[PATCH] Fix var-tracking ICE with complex subregs (PR debug/90733)

2019-06-05 Thread Jakub Jelinek
Hi! On the following testcase, we have: (debug_insn 45 20 22 2 (var_location:DI D#4 (const_int 0 [0])) -1 (nil)) (debug_insn 22 45 26 2 (debug_marker) "pr90733.c":16:3 -1 (nil)) (debug_insn 26 22 27 2 (var_location:CSI D#3 (subreg:CSI (debug_expr:DI D#4) 0)) "pr90733.c":16:10 -1 (nil)) (debug_ins

Re: [wwwdocs] Document existence of openacc-gcc-9-branch

2019-06-05 Thread Thomas Schwinge
Hi Julian! On Tue, 4 Jun 2019 23:05:53 +0100, Julian Brown wrote: > I've pushed a new branch "openacc-gcc-9-branch" to the Git > mirror (i.e. as a Git-only branch), for development of OpenACC and > related functionality on top of the GCC 9 branch. It's currently based > off the gcc-9_1_0-release

[committed] Force monotonic loops if lastprivate(conditional:) is present

2019-06-05 Thread Jakub Jelinek
Hi! The way we implement lastprivate(conditional:), where we have 2 per-thread variables, the privatized value of the variable and another private variable with the highest iteration count that stored to the privatized variable and only merge at the end of the construct doesn't really work for non

[committed] Add support for lastprivate (conditional: ) with reference arguments

2019-06-05 Thread Jakub Jelinek
Hi! The following patch fixes handling of references in lastprivate (conditional:). Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019-06-05 Jakub Jelinek * omp-low.c (lower_rec_input_clauses): For lastprivate conditional references, lookup in in

[committed] Fix up reference handling on simd constructs

2019-06-05 Thread Jakub Jelinek
Hi! To be able to properly vectorize code that uses private, lastprivate or linear clauses with reference arguments, we should be using "omp simd array" types holding what those references bind to. The following patch in addition disables "omp simd array" vectorization in loops where those refere

[PATCH] Enable memory operand for vfpclass[p,s][s,d] patterns.

2019-06-05 Thread Hongtao Liu
Hi Jeff and Jakub: When adding new intrinsics(PR target/89803), i found vfpclassp[sd], vfpclasss[sd] patterns didn't support memory operand which is supported in instructions. So this patch is about to enable memory operands for vfpclassp[s,d]/vfpclasss[s,d] patterns. Bootstrapped/regtested on x