Re: [PATCH] Add warn_unused_result for malloc-like functions (PR tree-optimization/78902).

2019-06-06 Thread Martin Liška
On 6/6/19 5:17 PM, Martin Sebor wrote: > On 6/6/19 2:01 AM, Martin Liška wrote: >> Hi. >> >> The patch is about addition of warn_unused_attribute for malloc-like >> function. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > I like this change (as you know :)  Just

libgo patch committed: Ignore unexported names in gccgoimporter

2019-06-06 Thread Ian Lance Taylor
This libgo patch changes the gccgoimporter package to ignore the unexported and imported names. Due to inlining, we can now see unexported functions and variables, and functions and variables imported from different packages. Ignore them rather than reporting them from this package. Handle

Re: [PATCH] A jump threading opportunity for condition branch

2019-06-06 Thread Jeff Law
On 5/31/19 9:03 AM, Jeff Law wrote: > On 5/31/19 1:24 AM, Richard Biener wrote: >> On Thu, 30 May 2019, Jeff Law wrote: >> >>> On 5/30/19 12:41 AM, Richard Biener wrote: On May 29, 2019 10:18:01 PM GMT+02:00, Jeff Law wrote: > On 5/23/19 6:11 AM, Richard Biener wrote: >> On Thu, 23

Re: [PATCH] Add warn_unused_result for malloc-like functions (PR tree-optimization/78902).

2019-06-06 Thread Jeff Law
On 6/6/19 2:01 AM, Martin Liška wrote: > Hi. > > The patch is about addition of warn_unused_attribute for malloc-like function. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > 2019-06-06 Martin

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Jeff Law
On 6/6/19 6:33 AM, Richard Sandiford wrote: > Kugan Vivekanandarajah writes: >> Hi Richard, >> >> On Thu, 6 Jun 2019 at 22:07, Richard Sandiford >> wrote: >>> >>> Kugan Vivekanandarajah writes: Hi Richard, On Thu, 6 Jun 2019 at 19:35, Richard Sandiford wrote: > >

Re: [PATCH] Disable PowerPC pc-relative support until the code is checked in

2019-06-06 Thread Michael Meissner
On Thu, Jun 06, 2019 at 06:14:29PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Thu, Jun 06, 2019 at 06:42:16PM -0400, Michael Meissner wrote: > > 2019-06-06 Michael Meissner > > > > * config/rs6000/rs6000-cpus.def (ISA_FUTURE_MASKS_SERVER): Delete > > enabling -mprefixed-addr

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-06-06 Thread Ian Lance Taylor
On Thu, Jun 6, 2019 at 4:41 PM Joseph Myers wrote: > > On Thu, 6 Jun 2019, Richard Earnshaw (lists) wrote: > > > > For email addresses, I think that using @gcc.gnu.org would be the best > > > approach for people that have such accounts, rather than an employer > > > address from an arbitrary

Re: [committed, amdgcn] Add -march=gfx906 for Vega20

2019-06-06 Thread Joseph Myers
On Thu, 6 Jun 2019, Andrew Stubbs wrote: > This patch adds a new -march=gfx906 option, and a new multilib to go with it. This is missing an invoke.texi update. -- Joseph S. Myers jos...@codesourcery.com

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-06-06 Thread Joseph Myers
On Thu, 6 Jun 2019, Richard Earnshaw (lists) wrote: > > For email addresses, I think that using @gcc.gnu.org would be the best > > approach for people that have such accounts, rather than an employer > > address from an arbitrary point in time. > > Or @gnu.org for accounts that pre-date the

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-06-06 Thread Joseph Myers
On Wed, 5 Jun 2019, Jason Merrill wrote: > > I think failing to credit (by name and email address) the person implied > > by the commit metadata, in the absence of positive evidence (such as a > > ChangeLog entry) for the change being authored by someone else, is just > > wrong, in the same way

Go patch committed: Permit inlining temporary statements and references

2019-06-06 Thread Ian Lance Taylor
This patch to the Go frontend permits inlining functions that use temporary statements and references. This increases the number of inlinable functions from 439 to 455. An example is math/bits.Mul32, which uses temporaries to handle the tuple assignment. Bootstrapped and ran Go testsuite on

Re: [PATCH] Fix PR90574

2019-06-06 Thread Jeff Law
On 6/6/19 5:43 AM, Richard Biener wrote: > > The following fixes debugging experience (and coverage) for cases > where CFG construction "optimizes" the CFG by squashing labels > into the same basic-block, defeating the regular mechanism of > dropping labels that are not reachable as done by CFG

[PATCH] RISC-V: Move STARTFILE_PREFIX_SPEC into target OS files.

2019-06-06 Thread Jim Wilson
This fixes a problem reported for the RISC-V Haiku OS port, where putting STARTFILE_PREFIX_SPEC in riscv.h breaks their port because they put libraries in different directories than the UNIX convention. The current definition is definitely needed for Linux. It should not be needed for rtems or

Re: [PATCH] Disable PowerPC pc-relative support until the code is checked in

2019-06-06 Thread Segher Boessenkool
Hi Mike, On Thu, Jun 06, 2019 at 06:42:16PM -0400, Michael Meissner wrote: > 2019-06-06 Michael Meissner > > * config/rs6000/rs6000-cpus.def (ISA_FUTURE_MASKS_SERVER): Delete > enabling -mprefixed-addr and -mpcrel by default. Why disable prefixed-addr? > *

[PATCH] PR other/90695 reduce testcase to remove library dependency

2019-06-06 Thread Jonathan Wakely
This reproduces the original ICE fixed by r178857 (tested at r178852 and r178860), without depending on a libstdc++ header that keeps changing. The number of errors differs between C++14 and C++17 modes, so the fixed test uses dg-excess-errors to match any number of them. The precise errors

[PATCH] Disable PowerPC pc-relative support until the code is checked in

2019-06-06 Thread Michael Meissner
I will be starting to put out the patches to enable pc-relative support for a future machine on the PowerPC. Until those patches are approved and committed, we need to change the defaults for the target so that pc-relative isn't default. Right now, we have the parts of the compiler that does

Re: undefined behavior in value_range::equiv_add()?

2019-06-06 Thread Aldy Hernandez
Meanwhile I have bootstrapped / tested the following which does the VARYING thing. Applied to trunk. I think we need to backport this since this is a latent wrong-code issue. We can see to improve things on the trunk incrementally. Folks, thanks so much for taking care of this. After

Re: [PATCH] handle vla plus offset in strlen (PR 90662)

2019-06-06 Thread Jeff Law
On 6/5/19 4:51 PM, Martin Sebor wrote: > One of my new tests for the strlen/sprintf integration tripped > over an incomplete handling of VLAs by the strlen pass.  Where > it can determine the length of a substring at some offset with > other kinds of arrays, the pass fails with VLAs because they >

Re: libbacktrace integration for _GLIBCXX_DEBUG mode

2019-06-06 Thread Jonathan Wakely
On 06/06/19 22:33 +0200, François Dumont wrote: Here is what I come up with. Regarding allocation in print_function I would also prefer to avoid it. But this patch also aim at creating a backtrace_state object in case of UB so the alloc is perhaps not so important. I can't use string_view

Remove -fodr-type-merging

2019-06-06 Thread Jan Hubicka
Hi, at the type introducing ODR type merging via mangled type names I was concerned about streaming overhead of this infrastructure and implemented flag to disable it. Maintaining this flag is harder over a time since we really want to establing ODR based type euivalences and also the type

[PATCH] Fix up g++.dg/cpp*/feat-cxx*.C tests (PR testsuite/90772, take 2, was: [PATCH] Avoid unnecessary inclusion of header)

2019-06-06 Thread Jakub Jelinek
On Thu, Jun 06, 2019 at 10:19:52PM +0200, Jakub Jelinek wrote: > Not only those, but apparently also ::size_t or std::plus; this broke > FAIL: g++.dg/cpp1y/feat-cxx14.C (test for excess errors) > FAIL: g++.dg/cpp1z/feat-cxx1z.C -std=gnu++17 (test for excess errors) > FAIL:

Re: libbacktrace integration for _GLIBCXX_DEBUG mode

2019-06-06 Thread François Dumont
Here is what I come up with. Regarding allocation in print_function I would also prefer to avoid it. But this patch also aim at creating a backtrace_state object in case of UB so the alloc is perhaps not so important. I can't use string_view as I need to modify it to display only a part of

Re: [PATCH] update get_range_strlen description

2019-06-06 Thread Marek Polacek
On Thu, Jun 06, 2019 at 01:32:14PM -0600, Martin Sebor wrote: > Hi Jeff, > > It looks like the updated comment for get_range_strlen didn't make > it into the strlen fixup commits last December and the function > still has the old description. (Not surprising given there are > at least two

[PATCH] Fix up g++.dg/cpp*/feat-cxx*.C tests (was: [PATCH] Avoid unnecessary inclusion of header)

2019-06-06 Thread Jakub Jelinek
Hi! On Thu, Jun 06, 2019 at 04:38:36PM +0100, Jonathan Wakely wrote: > This can greatly reduce the amount of preprocessed code that is included > by other headers, because depends on which is huge. > > * include/std/array: Do not include . > * include/std/optional: Include and >

[PATCH] update get_range_strlen description

2019-06-06 Thread Martin Sebor
Hi Jeff, It looks like the updated comment for get_range_strlen didn't make it into the strlen fixup commits last December and the function still has the old description. (Not surprising given there are at least two overloads of the same function and things moving between them.) I'm going to

[Darwin, c++, testsuite] Fix alignas4.C for Darwin.

2019-06-06 Thread Iain Sandoe
This test was failing on Darwin because the scan-asm clauses only excluded Darwin for m64 and the m32 syntax for Darwin is different, as below. @Rainer, Mike: the tests for non-Darwin are somewhat strange (although I have not modified them other than to exclude Darwin for 32b). (a) the tests seem

Re: [PATCH] remove trailing spaces from tree-ssa-strlen.c

2019-06-06 Thread Segher Boessenkool
On Thu, Jun 06, 2019 at 11:34:31AM -0600, Jeff Law wrote: > THough really I'd like to see these caught by and either rejected or > automatically fixed by commit hooks :-) It's silly to require any > manual intervention for trailing whitespace. [ Not fixed please, that can cause much bigger

[PATCH, PPC, Darwin] Ensure unwinder is built with altivec enabled.

2019-06-06 Thread Iain Sandoe
When libgcc is built on Darwin, it is usually built for the earliest potential target (Darwin8, 10.4). Build for that revision default to assuming that the processor might be G3 (without vector ops) and there is an outlined function used for save/restore that checks whether the processor is G3 or

[PATCH] Update preferred_stack_boundary only when expanding function call

2019-06-06 Thread H.J. Lu
locate_and_pad_parm is called when expanding function call from initialize_argument_information and when generating function body from assign_parm_find_entry_rtl: /* Remember if the outgoing parameter requires extra alignment on the calling function side. */ if

Re: undefined behavior in value_range::equiv_add()?

2019-06-06 Thread Jeff Law
On 6/6/19 1:31 AM, Richard Biener wrote: [ Big snip ] > >> I was primarily concerned with the ones in the evrp simplification >> engine which are easy to fix in-place. Looking at gimple-fold.c I agree >> we do need to address the walking problem. >> >> I'm not sure we can drop to varying though

Re: [PATCH] remove trailing spaces from tree-ssa-strlen.c

2019-06-06 Thread Jeff Law
On 6/6/19 11:19 AM, Martin Sebor wrote: > To avoid trailing whitespace in my commits I have my editor set > to highlight them.  While integrating the strlen/sprintf passes > and making more extensive changes than usual, I keep getting > distracted by the highlighting pointing out trailing spaces 

Re: [PATCH][MSP430][4/4] Implement 64-bit shifts in assembly code

2019-06-06 Thread Jeff Law
On 6/6/19 6:42 AM, Jozef Lawrynowicz wrote: > On Wed, 5 Jun 2019 16:35:14 -0600 > Jeff Law wrote: > >> On 6/4/19 7:17 AM, Jozef Lawrynowicz wrote: >>> libgcc/ChangeLog >>> >>> 2019-06-04 Jozef Lawrynowicz >>> >>> * config/msp430/slli.S (__mspabi_s): New library function for >>>

[PATCH] remove trailing spaces from tree-ssa-strlen.c

2019-06-06 Thread Martin Sebor
To avoid trailing whitespace in my commits I have my editor set to highlight them. While integrating the strlen/sprintf passes and making more extensive changes than usual, I keep getting distracted by the highlighting pointing out trailing spaces that predate my changes. Rather than "fixing"

Re: Make aliasing_component_refs_p to work harder when same_type_for_tbaa returns -1

2019-06-06 Thread Richard Sandiford
Richard Biener writes: > On Thu, 6 Jun 2019, Jan Hubicka wrote: > >> > > This is more of an accident and there are cases where we do not trip >> > > across >> > > this -1 and we disambiguate array accesses that seems unsafe to me. >> > > >> > > With my change aliasing_component_refs_p finds the

Re: [PATCH] Add warn_unused_result for malloc-like functions (PR tree-optimization/78902).

2019-06-06 Thread Jeff Law
On 6/6/19 9:17 AM, Martin Sebor wrote: > On 6/6/19 2:01 AM, Martin Liška wrote: >> Hi. >> >> The patch is about addition of warn_unused_attribute for malloc-like >> function. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > I like this change (as you know :)  Just

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Martin Sebor
On 6/6/19 9:42 AM, Jakub Jelinek wrote: On Thu, Jun 06, 2019 at 08:45:56AM -0600, Martin Sebor wrote: Changes for the same change shouldn't be separated by empty newlines in the ChangeLog. Furthermore, you've managed to commit only the first part (until varasm.c) and not the rest. I actually

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

2019-06-06 Thread Martin Jambor
Hi, (now even including gcc-patches mailing list which we managed to drop again and Honza whom I forgot to CC the last time) On Thu, Jun 06 2019, Richard Biener wrote: > yOn Tue, 4 Jun 2019, Martin Jambor wrote: >> >> @@ -1822,9 +1863,19 @@ build_ref_for_model (location_t loc, tree base, >> >>

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Jakub Jelinek
On Thu, Jun 06, 2019 at 08:45:56AM -0600, Martin Sebor wrote: > > Changes for the same change shouldn't be separated by empty newlines in the > > ChangeLog. Furthermore, you've managed to commit only the first part (until > > varasm.c) and not the rest. > > I actually managed to do that on

[PATCH] Avoid unnecessary inclusion of header

2019-06-06 Thread Jonathan Wakely
This can greatly reduce the amount of preprocessed code that is included by other headers, because depends on which is huge. * include/std/array: Do not include . * include/std/optional: Include and instead of . Preprocessed line counts for C++17 mode:

Re: [PATCH] Fix tests that fail with -std=gnu++98 or -std=gnu++11

2019-06-06 Thread Jonathan Wakely
On 06/06/19 13:17 +0100, Jonathan Wakely wrote: * testsuite/18_support/set_terminate.cc: Do not run for C++98 mode. * testsuite/18_support/set_unexpected.cc: Likewise. * testsuite/20_util/is_nothrow_invocable/value.cc: Test converting to void. *

Re: [PATCH] Enforce allocator::value_type consistency for containers in C++2a

2019-06-06 Thread Jonathan Wakely
On 06/06/19 14:36 +0100, Jonathan Wakely wrote: On 03/06/19 14:23 +0100, Jonathan Wakely wrote: In previous standards it is undefined for a container and its allocator to have a different value_type. Libstdc++ has traditionally allowed it as an extension, automatically rebinding the allocator

Re: [PATCH] Add warn_unused_result for malloc-like functions (PR tree-optimization/78902).

2019-06-06 Thread Martin Sebor
On 6/6/19 2:01 AM, Martin Liška wrote: Hi. The patch is about addition of warn_unused_attribute for malloc-like function. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I like this change (as you know :) Just one question: should all allocation functions be also

[committed, amdgcn] Add -march=gfx906 for Vega20

2019-06-06 Thread Andrew Stubbs
This patch adds a new -march=gfx906 option, and a new multilib to go with it. gfx906 is ISA compatible with gfx900 (at least as far as the compiler support goes), but unfortunately the metadata in the object files is not compatible, so we need a whole extra multilib (booo!). Or, at least

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Martin Sebor
On 6/6/19 3:39 AM, Jakub Jelinek wrote: On Wed, May 22, 2019 at 10:34:00AM -0600, Martin Sebor wrote: gcc/ChangeLog: * config/i386/i386-features.c (ix86_get_function_versions_dispatcher): Adjust quoting and hyphenation. * convert.c (convert_to_real_1): Same. *

Re: Patch: don't cap TYPE_PRECISION of bitsizetype at MAX_FIXED_MODE_SIZE

2019-06-06 Thread Hans-Peter Nilsson
> MIME-Version: 1.0 > X-Axis-User: NO > X-Axis-NonUser: YES > X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com > X-Spam-Score: 1.102 > X-Spam-Level: * > X-Spam-Status: No, score=1.102 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, > DKIM_INVALID=0.1, DKIM_SIGNED=0.1,

Re: Patch: don't cap TYPE_PRECISION of bitsizetype at MAX_FIXED_MODE_SIZE

2019-06-06 Thread Hans-Peter Nilsson
> Date: Thu, 6 Jun 2019 16:04:47 +0200 > From: Hans-Peter Nilsson > When bitsizetype objects end > up on the target, they use the actual Pmode and not the larger > precision mode. Oops, a half-way-done email slipped away, this part still needs to be investigated. I don't really know where the

Re: Patch: don't cap TYPE_PRECISION of bitsizetype at MAX_FIXED_MODE_SIZE

2019-06-06 Thread Hans-Peter Nilsson
> From: Eric Botcazou > Date: Wed, 05 Jun 2019 22:03:04 +0200 > > This issue exists, not just for targets that can have their > > MAX_FIXED_MODE_SIZE more-or-less easily tweaked higher, but also > > for the 'bit-container' targets where it *can't* be set higher. > > > > Let's please DTRT and

Re: [PATCH][AArch64] PR tree-optimization/90332: Implement vec_init where N is a vector mode

2019-06-06 Thread Kyrill Tkachov
[resending without HTML] On 6/3/19 11:48 AM, Kyrill Tkachov wrote: On 6/3/19 11:32 AM, James Greenhalgh wrote: On Fri, May 10, 2019 at 10:32:22AM +0100, Kyrill Tkachov wrote: Hi all, This patch fixes the failing gcc.dg/vect/slp-reduc-sad-2.c testcase on aarch64 by implementing a vec_init

Re: [PATCH] Enforce allocator::value_type consistency for containers in C++2a

2019-06-06 Thread Jonathan Wakely
On 03/06/19 14:23 +0100, Jonathan Wakely wrote: In previous standards it is undefined for a container and its allocator to have a different value_type. Libstdc++ has traditionally allowed it as an extension, automatically rebinding the allocator to the container's value_type. Since GCC 8.1 that

Re: [PATCH 1/4] Remove indirect call top N counter type.

2019-06-06 Thread Jan Hubicka
> On 6/6/19 2:52 PM, Jan Hubicka wrote: > > Hi, > > so the only point of removing this is the fact that builds would be > > not reproducible with indir-call-topn-profile? > > That's one reason. But the main reason is that the code is dead and not used. > If you take a look at

Re: Make aliasing_component_refs_p to work harder when same_type_for_tbaa returns -1

2019-06-06 Thread Richard Biener
On Thu, 6 Jun 2019, Jan Hubicka wrote: > > > This is more of an accident and there are cases where we do not trip > > > across > > > this -1 and we disambiguate array accesses that seems unsafe to me. > > > > > > With my change aliasing_component_refs_p finds the match of the > > > array types

Re: Make aliasing_component_refs_p to work harder when same_type_for_tbaa returns -1

2019-06-06 Thread Jan Hubicka
> > This is more of an accident and there are cases where we do not trip across > > this -1 and we disambiguate array accesses that seems unsafe to me. > > > > With my change aliasing_component_refs_p finds the match of the > > array types (type_same_for_tbaa_p returns 1 with non-LTO becuase they

Re: [PATCH 1/4] Remove indirect call top N counter type.

2019-06-06 Thread Martin Liška
On 6/6/19 2:52 PM, Jan Hubicka wrote: > Hi, > so the only point of removing this is the fact that builds would be > not reproducible with indir-call-topn-profile? That's one reason. But the main reason is that the code is dead and not used. If you take a look at gcc/ipa-profile.c:189, the code is

Re: [PR 89330] Avoid adding dead speculative edges to inlinig heap

2019-06-06 Thread Jan Hubicka
My understanding is that the problematic situation is when we create speculation, insert it to the priority queue and then decide it is useless. This is done by speculation_useful_p and that checks more than just the fact whether function is inlinable (it accepts targets declared as PURE/CONST

[C++ Patch] Further grokdeclarator locations work

2019-06-06 Thread Paolo Carlini
Hi, only minor functional changes here - more precise locations for two error messages  - but I think it's a step in the right direction: it moves the declaration of id_loc way up, near typespec_loc and as such id_loc is immediately used. Then its value is updated upon the loop over

Re: Make aliasing_component_refs_p to work harder when same_type_for_tbaa returns -1

2019-06-06 Thread Richard Biener
On Thu, 30 May 2019, Jan Hubicka wrote: > Hi, > this patch makes aliasing_component_refs_p to not give up at the first > -1 returned by types_same_for_tbaa_p and continue searching for pairs of types > we know to be the same. This affects disambiguations as follows: > > With patch: >

Re: [PATCH 3/4] Dump histograms only if present.

2019-06-06 Thread Jan Hubicka
> On 6/6/19 2:16 PM, Jan Hubicka wrote: > > What is the point of having histogram value when there are no counters? > > Because we first create histograms in branch_prob -> > gimple_find_values_to_profile and > later we read profile from file. At that point we know which are empty, but > we

Re: [PATCH 1/4] Remove indirect call top N counter type.

2019-06-06 Thread Jan Hubicka
Hi, so the only point of removing this is the fact that builds would be not reproducible with indir-call-topn-profile? I still kind of thing it may be useful to track multiple most common values, so I would be in favour of keeping it just updating the documentation of indir-call-topn-profile that

Re: [PATCH 2/4] Implement N disk counters for single value and indirect call counters.

2019-06-06 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2019-06-04 Martin Liska > > * gcov-io.h (GCOV_DISK_SINGLE_VALUES): New. > (GCOV_SINGLE_VALUE_COUNTERS): Likewise. > * ipa-profile.c (ipa_profile_generate_summary): > Use get_most_common_single_value. > * tree-profile.c

Re: [PATCH][MSP430][4/4] Implement 64-bit shifts in assembly code

2019-06-06 Thread Jozef Lawrynowicz
On Wed, 5 Jun 2019 16:35:14 -0600 Jeff Law wrote: > On 6/4/19 7:17 AM, Jozef Lawrynowicz wrote: > > libgcc/ChangeLog > > > > 2019-06-04 Jozef Lawrynowicz > > > > * config/msp430/slli.S (__mspabi_s): New library function for > > performing a logical left shift of a 64-bit value.

Re: [ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-06-06 Thread Christophe Lyon
Hi, If this makes review easier, here are the areas covered by the patches: - patches 1,3,4,7,8,9,10,12,21: target-specific - patch 2: configure - patch 5,6,11,13: generic parts, undef #if defined(__FDPIC__) - patches 14-20: testsuite Christophe On Tue, 4 Jun 2019 at 14:57, Christophe Lyon

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > Hi Richard, > > On Thu, 6 Jun 2019 at 22:07, Richard Sandiford > wrote: >> >> Kugan Vivekanandarajah writes: >> > Hi Richard, >> > >> > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford >> > wrote: >> >> >> >> Kugan Vivekanandarajah writes: >> >> > Hi Richard, >>

Re: [PATCH] Enable GCC support for AVX512_VP2INTERSECT.

2019-06-06 Thread Uros Bizjak
On Thu, Jun 6, 2019 at 2:12 PM Uros Bizjak wrote: > > On Thu, Jun 6, 2019 at 7:54 AM Hongtao Liu wrote: > > > > Hi Uros and all: > > This patch is about to enable support for AVX512_VP2INTERSECT which will > > be in Willow Cove. There are two instructions for AVX512_VP2INTERSECT: > >

Re: [PATCH 3/4] Dump histograms only if present.

2019-06-06 Thread Martin Liška
On 6/6/19 2:16 PM, Jan Hubicka wrote: > What is the point of having histogram value when there are no counters? Because we first create histograms in branch_prob -> gimple_find_values_to_profile and later we read profile from file. At that point we know which are empty, but we don't remove

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 6 Jun 2019 at 22:07, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > Hi Richard, > > > > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford > > wrote: > >> > >> Kugan Vivekanandarajah writes: > >> > Hi Richard, > >> > > >> > Thanks for the review. Attached is

Re: [PATCH] PR libstdc++/71579 assert that type traits are not misused with an incomplete type

2019-06-06 Thread Jonathan Wakely
On 31/05/19 11:35 +0100, Jonathan Wakely wrote: On 31/05/19 08:58 +0300, Antony Polukhin wrote: On Thu, May 30, 2019, 19:38 Jonathan Wakely wrote: <...> I've attached a relative diff, to be applied on top of yours, with my suggested tweaks. Do you see any issues with it? (If you're happy

[PATCH] Fix tests that fail with -std=gnu++98 or -std=gnu++11

2019-06-06 Thread Jonathan Wakely
* testsuite/18_support/set_terminate.cc: Do not run for C++98 mode. * testsuite/18_support/set_unexpected.cc: Likewise. * testsuite/20_util/is_nothrow_invocable/value.cc: Test converting to void. * testsuite/20_util/is_nothrow_invocable/value_ext.cc: Fix

[PATCH] Refactor SFINAE constraints on std::tuple constructors

2019-06-06 Thread Jonathan Wakely
Replace the _TC class template with the better-named _TupleConstraints one, which provides a different set of member functions. The new members do not distinguish construction from lvalues and rvalues, but expects the caller to do that by providing different template arguments. Within the

Re: [PATCH 3/4] Dump histograms only if present.

2019-06-06 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2019-06-04 Martin Liska > > * value-prof.c (dump_histogram_value): Print histogram values > only if present. What is the point of having histogram value when there are no counters? Honza > --- > gcc/value-prof.c | 72

Re: [PATCH 4/4] Update a bit dump format.

2019-06-06 Thread Jan Hubicka
> > gcc/ChangeLog: > > 2019-06-04 Martin Liska > > * value-prof.c (dump_histogram_value): Change dump format. > (gimple_mod_subtract_transform): Remove legacy comment. OK, Honza

Re: [PATCH] Enable GCC support for AVX512_VP2INTERSECT.

2019-06-06 Thread Uros Bizjak
On Thu, Jun 6, 2019 at 7:54 AM Hongtao Liu wrote: > > Hi Uros and all: > This patch is about to enable support for AVX512_VP2INTERSECT which will > be in Willow Cove. There are two instructions for AVX512_VP2INTERSECT: > VP2INTERSECTD and VP2INTERSECTQ. More details please refer to >

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > Hi Richard, > > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford > wrote: >> >> Kugan Vivekanandarajah writes: >> > Hi Richard, >> > >> > Thanks for the review. Attached is the latest patch. >> > >> > For testcase like cond_arith_1.c, with the patch, gcc ICE in

[PATCH] Fix PR90574

2019-06-06 Thread Richard Biener
The following fixes debugging experience (and coverage) for cases where CFG construction "optimizes" the CFG by squashing labels into the same basic-block, defeating the regular mechanism of dropping labels that are not reachable as done by CFG cleanup. Writing coverage testcases is easy enough

Re: Review Hashtable extract node API

2019-06-06 Thread Jonathan Wakely
On 05/06/19 20:18 +0100, Jonathan Wakely wrote: On 05/06/19 17:43 +0100, Jonathan Wakely wrote: On 05/06/19 17:22 +0100, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: @@ -669,18 +670,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __node_base*

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 6 Jun 2019 at 19:35, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > Hi Richard, > > > > Thanks for the review. Attached is the latest patch. > > > > For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I > > am limiting fwprop in cases like

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-06 Thread Richard Sandiford
Szabolcs Nagy writes: > On 03/06/2019 08:26, Prathamesh Kulkarni wrote: >> +++ b/gcc/testsuite/gcc.target/aarch64/sve/init_8.c >> @@ -0,0 +1,32 @@ >> +/* { dg-do assemble { target aarch64_asm_sve_ok } } */ >> +/* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256 >> --save-temps" } */

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-06 Thread Szabolcs Nagy
On 03/06/2019 08:26, Prathamesh Kulkarni wrote: > +++ b/gcc/testsuite/gcc.target/aarch64/sve/init_8.c > @@ -0,0 +1,32 @@ > +/* { dg-do assemble { target aarch64_asm_sve_ok } } */ > +/* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256 --save-temps" > } */ > + > +/* Case 5.2: Interleaved

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-06-06 Thread Richard Earnshaw (lists)
On 05/06/2019 19:04, Jason Merrill wrote: > On 6/3/19 6:33 PM, Joseph Myers wrote: >> On Sun, 2 Jun 2019, Segher Boessenkool wrote: >> > Git has an identity (well, two) _per commit_, and there is no way > you can > reconstruct people's prefered name and email address (at any point

[PATCH V7] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-06-06 Thread Feng Xue OS
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 37aab79..87cc125 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,16 @@ +2019-06-04 Feng Xue + + PR tree-optimization/89713 + * doc/invoke.texi (-ffinite-loops): Document new option. + * common.opt (-ffinite-loops): New

Re: [0/3] Improve debug info for addressable vars

2019-06-06 Thread Richard Sandiford
Richard Biener writes: > On Wed, Jun 5, 2019 at 4:30 PM Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On Sat, Jun 1, 2019 at 5:49 PM Richard Sandiford >> > wrote: >> >> >> >> Taking the address of a variable stops us doing var-tracking on it, >> >> so that we just use the

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Jakub Jelinek
On Wed, May 22, 2019 at 10:34:00AM -0600, Martin Sebor wrote: > gcc/ChangeLog: > > * config/i386/i386-features.c (ix86_get_function_versions_dispatcher): > Adjust quoting and hyphenation. > * convert.c (convert_to_real_1): Same. > * gcc.c (driver_wrong_lang_callback):

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Richard Sandiford
Kugan Vivekanandarajah writes: > Hi Richard, > > Thanks for the review. Attached is the latest patch. > > For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I > am limiting fwprop in cases like this. Is there a better fix for this? > index cf2c9de..2c99285 100644 > ---

Re: [PATCH] Find constant definition for by-ref argument using dominance information (PR ipa/90401)

2019-06-06 Thread Richard Biener
On Thu, Jun 6, 2019 at 10:54 AM Feng Xue OS wrote: > > > I don't think your PHI handling works correct. If you have > > >agg.part1 = 0; > >if () > > agg.part2 = 1; > >call (agg); > > > then you seem to end up above for agg.part2 because you push that onto the > > worklist below.

Re: [PATCH 0/4] Store multiple values for single value profilers

2019-06-06 Thread Richard Biener
On Thu, Jun 6, 2019 at 10:23 AM Martin Liška wrote: > > On 6/5/19 3:49 PM, Richard Biener wrote: > > On Tue, Jun 4, 2019 at 10:44 AM Martin Liska wrote: > >> > >> Hi. > >> > >> It's becoming more common that a training run happens in parallel > >> environment. > >> That can lead to a not

Re: [PATCH][arm] Implement usadv16qi and ssadv16qi standard names

2019-06-06 Thread Przemyslaw Wirkus
Hi all, This patch implements the usadv16qi and ssadv16qi standard names for arm. The V16QImode variant is important as it is the most commonly used pattern: reducing vectors of bytes into an int. The midend expects the optab to compute the absolute differences of operands 1 and 2 and reduce

[PATCH][arm] Implement usadv16qi and ssadv16qi standard names

2019-06-06 Thread Przemyslaw Wirkus
Hi all, This patch implements the usadv16qi and ssadv16qi standard names for arm. The V16QImode variant is important as it is the most commonly used pattern: reducing vectors of bytes into an int. The midend expects the optab to compute the absolute differences of operands 1 and 2 and reduce

Re: [PATCH] Find constant definition for by-ref argument using dominance information (PR ipa/90401)

2019-06-06 Thread Feng Xue OS
> I don't think your PHI handling works correct.  If you have >    agg.part1 = 0; >    if () >      agg.part2 = 1; >    call (agg); > then you seem to end up above for agg.part2 because you push that onto the > worklist below. It is correct. o. worklist is used to collect all non-dom virtual

[PATCH] Release cgraph_{node,edge} via ggc_free.

2019-06-06 Thread Martin Liška
Hi. This is follow up patch that releases memory for removed cgraph edges and nodes. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin >From 121138ee973b63bfdf7be04ab28113f479bc91b0 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 15

Re: [PR 89330] Avoid adding dead speculative edges to inlinig heap

2019-06-06 Thread Martin Liška
Hi. This is rebased version of the patch that Martin J. wrote. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Thanks, Martin >From 17290dd6dc4412aee6c6484844f9edb149129d36 Mon Sep 17 00:00:00 2001 From: Martin Jambor Date: Wed, 5 Jun 2019 16:11:44 +0200 Subject:

Re: [PATCH 0/4] Store multiple values for single value profilers

2019-06-06 Thread Martin Liška
On 6/5/19 3:49 PM, Richard Biener wrote: > On Tue, Jun 4, 2019 at 10:44 AM Martin Liska wrote: >> >> Hi. >> >> It's becoming more common that a training run happens in parallel >> environment. >> That can lead to a not reproducible builds caused by different order of >> merging >> of .gcda

Re: Negative arguments in OpenMP 'num_threads' clause etc.

2019-06-06 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 May 2019 16:52:45 +0200, Jakub Jelinek wrote: > On Wed, May 29, 2019 at 04:42:14PM +0200, Thomas Schwinge wrote: > > On Tue, 09 Apr 2019 17:51:46 +0200, I wrote: > > > On Tue, 29 Nov 2016 17:47:08 -0800, Cesar Philippidis > > > wrote: > > > > One notable difference between

[PATCH] Add warn_unused_result for malloc-like functions (PR tree-optimization/78902).

2019-06-06 Thread Martin Liška
Hi. The patch is about addition of warn_unused_attribute for malloc-like function. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-06-06 Martin Liska PR tree-optimization/78902 *

Re: Patch: don't cap TYPE_PRECISION of bitsizetype at MAX_FIXED_MODE_SIZE

2019-06-06 Thread Richard Biener
On Wed, Jun 5, 2019 at 10:03 PM Eric Botcazou wrote: > > > This issue exists, not just for targets that can have their > > MAX_FIXED_MODE_SIZE more-or-less easily tweaked higher, but also > > for the 'bit-container' targets where it *can't* be set higher. > > > > Let's please DTRT and correct the

[PATCH 1/2] [ARC] Improve code gen when compiling for size

2019-06-06 Thread Claudiu Zissulescu
When optimizing for size, try to avoid using long immediate by employing alternative (short) instructions. Ok to apply? Claudiu gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc-protos.h (arc_check_ior_const): Declare. (arc_split_ior): Likewise.

[PATCH 2/2] [ARC] Update RTX costs.

2019-06-06 Thread Claudiu Zissulescu
Update RTX costs to reflect better the ARC architecture. Ok to apply? Claudiu gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc.c (arc_rtx_costs): Update costs. /gcc/testsuite -xx-xx Claudiu Zissulescu * gcc.target/arc/jumptables.c: Update test. ---

Re: [0/3] Improve debug info for addressable vars

2019-06-06 Thread Richard Biener
On Wed, Jun 5, 2019 at 4:30 PM Richard Sandiford wrote: > > Richard Biener writes: > > On Sat, Jun 1, 2019 at 5:49 PM Richard Sandiford > > wrote: > >> > >> Taking the address of a variable stops us doing var-tracking on it, > >> so that we just use the DECL_RTL instead. This can easily cause

[PATCH] [ARC][DOC] Add documentation naked, ilink and firq

2019-06-06 Thread Claudiu Zissulescu
Hi Sandra, Andrew Please find a small patch on the documentation which adds info about naked, ilink and firq function attributes. Ok to apply? Claudiu gcc/ -xx-xx Claudiu Zissulescu * doc/extend.texi (ARC Function Attributes): Update info. --- gcc/doc/extend.texi | 14

Re: [PATCH] Simplify mult where both arguments are 0 or 1 (PR tree-optimization/87954).

2019-06-06 Thread Richard Biener
On Wed, Jun 5, 2019 at 3:35 PM Martin Liška wrote: > > On 6/5/19 3:04 PM, Richard Biener wrote: > > On Wed, Jun 5, 2019 at 2:09 PM Martin Liška wrote: > >> > >> On 6/5/19 1:13 PM, Richard Biener wrote: > >>> On Wed, Jun 5, 2019 at 12:56 PM Martin Liška wrote: > > Hi. > > I'm

[PATCH] [ARC] Fix PR89838

2019-06-06 Thread Claudiu Zissulescu
Hi Andrew, This is a proposed fix for bugzilla PR89838 issue. It also needs to be backported to gcc9 and, eventually, gcc8 branches. Ok to apply? Claudiu gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc.c (arc_symbol_binds_local_p): New function.

Re: undefined behavior in value_range::equiv_add()?

2019-06-06 Thread Richard Biener
On Wed, Jun 5, 2019 at 11:12 PM Jeff Law wrote: > > On 6/4/19 9:04 AM, Richard Biener wrote: > > On Tue, Jun 4, 2019 at 3:40 PM Jeff Law wrote: > >> > >> On 6/4/19 5:23 AM, Richard Biener wrote: > >>> On Tue, Jun 4, 2019 at 12:30 AM Jeff Law wrote: > > On 6/3/19 7:13 AM, Aldy

  1   2   >