Re: [PATCH] RISC-V: Fix splitter for 32-bit AND on 64-bit target.

2019-07-16 Thread Kito Cheng
Hi I'd like to back port this patch to GCC 8 and 9, should I send another patch mail or just wait ack from release manager? On Mon, Jul 8, 2019 at 6:48 PM Jim Wilson wrote: > > Fixes github.com/riscv/riscv-gcc issue #161. We were accidentally using > BITS_PER_WORD to compute shift counts when

Re: Remove array_index inliner hint

2019-07-16 Thread Richard Sandiford
JiangNing OS writes: > Hi Honza, > > It seems this commit caused gcc bootstrap failure on aarch64 as below, > > Comparing stages 2 and 3 > warning: gcc/cc1obj-checksum.o differs > Bootstrap comparison failure! > gcc/dwarf2out.o differs > gcc/var-tracking.o differs > gcc/aarch64.o differs > make[2]

Re: Rewrite some jump.c routines to use flags

2019-07-16 Thread Richard Sandiford
Eric Botcazou writes: >> gcc/ >> * jump.c (FLAGS_EQ, FLAGS_LT, FLAGS_GT, FLAGS_UNORDERED, FLAGS_ORDER) >> (FLAGS_SIGNED, FLAGS_UNSIGNED, FLAGS_SIGN_AGNOSTIC, FLAGS_SIGNEDNESS) >> (FLAGS_TRAP_QNANS, FLAGS_TRAP_SNANS, FLAGS_TRAP_NANS, FLAGS_TRAP_NONE) >> (FLAGS_TRAPS): New consta

[RFC] Consider lrotate const rotation in vectorizer

2019-07-16 Thread Kewen.Lin
Hi all, Based on the previous comments (thank you!), I tried to update the handling in expander and vectorizer. Middle-end optimizes lrotate with const rotation count to rrotate all the time, it makes vectorizer fail to vectorize if rrotate isn't supported on the target. We can at least teach i

[C++ PATCH] Fix g++.dg/template/pr84789.C on new concepts branch.

2019-07-16 Thread Jason Merrill
On the concepts branch I ran into trouble where a pre-parsed dependent nested-name-specifier got replaced on a subsequent parse with is_declaration by one with typenames resolved, which was then used wrongly on a further parse with !is_declaration. Tested x86_64-pc-linux-gnu, applying to trunk.

[C++ PATCH] Simplify type-specifier parsing.

2019-07-16 Thread Jason Merrill
Previously, the tentative parses for optional type-specifier and to support class template argument deduction were combined awkwardly. This reorganization was motivated by type-constraint parsing on the new concepts branch. Tested x86_64-pc-linux-gnu, applying to trunk. * parser.c (cp_pa

Fix -Wreturn-type for static naked functions in C

2019-07-16 Thread Richard Sandiford
This patch extends the fix for PR53633 to include static functions, which were giving a bogus -Wreturn-type warning for C but not for C++. Tested on aarch64-linux-gnu, x86_64-linux-gnu and armeb-eabi. OK for trunk? OK for GCC 8 and 9 too? I don't think it's a regression, but the current behaviou

[libstdc++ PATCH] Add parens around constraint in .

2019-07-16 Thread Jason Merrill
C++20 concepts require parens around atomic constraints that are not primary-expressions. Tested x86_64-pc-linux-gnu, applying to trunk. * include/std/memory (uses_allocator_construction_args): Add parens around constraint. --- libstdc++-v3/ChangeLog | 5 + libstdc++

[C++ PATCH] Simplify range location creation in C++ parser.

2019-07-16 Thread Jason Merrill
Many places in the parser follow the same pattern of capturing the location of the last lexed token, either before or after lexing it, and then using that as the end of a location range; this can be simplified by passing the lexer to make_location and grabbing the token location there. Tested x86_

Make alias sets of ODR types more precise

2019-07-16 Thread Jan Hubicka
Hi, this is the hunk we omitted from the original patch enabling TBAA for ODR types. Currently record_component_aliases record all pointers as void *. This is because canonical type merging handles them this way and thus it may merge for example strut a { int *ptr;}; and struct b { short *ptr

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-16 Thread Christophe Lyon
Ping? Le mar. 9 juil. 2019 à 00:04, Martin Sebor a écrit : > On 7/8/19 5:10 AM, Christophe Lyon wrote: > > On Sat, 6 Jul 2019 at 19:57, Martin Sebor wrote: > >> > >> On 7/4/19 9:27 AM, Christophe Lyon wrote: > >>> Hi, > >>> > >>> Similar to what already exists for TI msp430 or in TI compilers f

Re: [ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-07-16 Thread Christophe Lyon
Ping^6? Le lun. 8 juil. 2019 à 16:27, Christophe Lyon a écrit : > ping^5? > > On Mon, 1 Jul 2019 at 14:15, Christophe Lyon > wrote: > > > > ping^4 ? > > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00817.html > > > > On Mon, 17 Jun 2019 at 13:41, Christophe Lyon > > wrote: > > > > > > ping^3

[PATCH] Recompute domonators in DSE when removing dead edges (PR rtl-optimization/91164)

2019-07-16 Thread Jakub Jelinek
Hi! When DSEing stmts with EH edges, we can invalidate through that dominator info. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-07-16 Jakub Jelinek PR rtl-optimization/91164 * dse.c (rest_of_handle_dse): If dead edges have been purg

Re: [PATCH] Fix PR91162

2019-07-16 Thread Rainer Orth
Hi Richard, > 2019-07-15 Richard Biener > > PR middle-end/91162 > * tree-cfg.c (move_block_to_fn): When releasing a virtual PHI > node make sure to replace all uses with something valid. > > * gcc.dg/autopar/pr91162.c: New testcase. the new testcase FAILs on several 32-

Re: Make nonoverlapping_component_refs work with duplicated main variants

2019-07-16 Thread Jan Hubicka
> Hi Jan, > > > * g++.dg/lto/alias-3_0.C: New file. > > * g++.dg/lto/alias-3_1.c: New file. > > the new test has a couple of problems: DejaGnu warns everywhere: > > WARNING: lto.exp does not support dg-lto-do in secondary source files > WARNING: lto.exp does not support dg-lto-options in

[testsuite] Don't xfail gcc.dg/tree-ssa/pr84512.c on 64-bit SPARC

2019-07-16 Thread Rainer Orth
Since 20190701, when the failure of gcc.dg/tree-ssa/pr84512.c on x86 was fixed, the test has been XPASSing on 64-bit SPARC: XPASS: gcc.dg/tree-ssa/pr84512.c scan-tree-dump optimized "return 285;" Fixed as follows, just as been done recently on alpha. Tested on sparc-sun-solaris2.11 (both multili

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-16 Thread Richard Sandiford
Thanks for doing this in a generic way. Christophe Lyon writes: > @@ -2224,6 +2234,50 @@ handle_weak_attribute (tree *node, tree name, >return NULL_TREE; > } > > +/* Handle a "noinit" attribute; arguments as in struct > + attribute_spec.handler. Check whether the attribute is allowed >

Re: [ARM/FDPIC v5 01/21] [ARM] FDPIC: Add -mfdpic option support

2019-07-16 Thread Richard Sandiford
[This isn't really something that should be reviewed under global reviewership, but if it's either that or nothing, I'll do it anyway...] Christophe Lyon writes: > 2019-XX-XX Christophe Lyon > Mickaël Guêné > > gcc/ > * config/arm/arm.opt: Add -mfdpic option. > * doc/

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-07-16 Thread Maxim Kuvyrkov
Hi Everyone, I've been swamped with other projects for most of June, which gave me time to digest all the feedback I've got on GCC's conversion from SVN to Git. The scripts have heavily evolved from the initial version posted here. They have become fairly generic in that they have no implied k

[PATCH][OBVIOUS][GCC9] Do not use -Werror in a test that has -frepo warning (PR testsuite/91175).

2019-07-16 Thread Martin Liška
Hi. This is fix of the fallout caused by the warning for -frepo. I've just tested the test locally and I'm going to install the patch. Thanks, Martin gcc/testsuite/ChangeLog: 2019-07-16 Martin Liska PR testsuite/91175 * g++.old-deja/g++.pt/instantiate4.C: Do not use -Werror.

Re: [PATCH v3] Generalize get_most_common_single_value to return k_th value & count

2019-07-16 Thread Martin Liška
On 7/16/19 8:53 AM, luoxhu wrote: > Currently get_most_common_single_value could only return the max hist > , add qsort to enable this function return nth value. > Rename it to get_nth_most_common_value. > > v3 Changes: >  1. Move sort to profile.c after loading values from disk.  Simplify >     g

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-07-16 Thread Richard Sandiford
Christophe Lyon writes: > On 22/05/2019 10:45, Christophe Lyon wrote: >> On Wed, 22 May 2019 at 10:39, Szabolcs Nagy wrote: >>> >>> On 21/05/2019 16:28, Christophe Lyon wrote: --- a/gcc/config/arm/linux-eabi.h +++ b/gcc/config/arm/linux-eabi.h @@ -89,7 +89,7 @@ #define MUSL_

Re: [ARM/FDPIC v5 07/21] [ARM] FDPIC: Avoid saving/restoring r9 on stack since it is read-only

2019-07-16 Thread Kyrill Tkachov
On 5/15/19 1:39 PM, Christophe Lyon wrote: 2019-XX-XX  Christophe Lyon     Mickaël Guêné     gcc/     * config/arm/arm.h (PIC_REGISTER_MAY_NEED_SAVING): New helper.     * config/arm/arm.c (arm_compute_save_reg0_reg12_mask): Handle     FDPIC. Ok once the rest of the seri

Re: [ARM/FDPIC v5 08/21] [ARM] FDPIC: Enforce local/global binding for function descriptors

2019-07-16 Thread Kyrill Tkachov
Hi Christophe, On 5/15/19 1:39 PM, Christophe Lyon wrote: Use local binding rules to decide whether we can use GOTOFFFUNCDESC to compute the function address. 2019-XX-XX  Christophe Lyon      Mickaël Guêné     gcc/     * config/arm/arm.c (arm_local_funcdesc_p): New function.

Re: [PATCH] RISC-V: Fix splitter for 32-bit AND on 64-bit target.

2019-07-16 Thread Richard Biener
On Tue, 16 Jul 2019, Kito Cheng wrote: > Hi > > I'd like to back port this patch to GCC 8 and 9, should I send another > patch mail or just wait ack from release manager? Looks OK to backport since it only affects RISC-V and that's neither a primary nor secondary arch and this looks like a wrong

Re: [PATCH] Recompute domonators in DSE when removing dead edges (PR rtl-optimization/91164)

2019-07-16 Thread Richard Biener
On Tue, 16 Jul 2019, Jakub Jelinek wrote: > Hi! > > When DSEing stmts with EH edges, we can invalidate through that dominator > info. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, > ok for trunk? OK. Richard. > 2019-07-16 Jakub Jelinek > > PR rtl-optimization/

[PATCH] Make a warning for -Werror=wrong-language (PR driver/91172).

2019-07-16 Thread Martin Liška
Hi. I noticed in the PR that -Werror=argument argument is not verified that the option is supported by a language we compile for. That's changed in the patch. However, it's not ideal as I need to mark the -Werror as the problematic option and one can't print a proper list of valid languages for wh

Re: [ARM/FDPIC v5 09/21] [ARM] FDPIC: Add support for taking address of nested function

2019-07-16 Thread Kyrill Tkachov
Hi Christophe On 5/15/19 1:39 PM, Christophe Lyon wrote: In FDPIC mode, the trampoline generated to support pointers to nested functions looks like:    .word trampoline address    .word trampoline GOT address    ldr    r12, [pc, #8]    ldr    r9,

Re: Make nonoverlapping_component_refs work with duplicated main variants

2019-07-16 Thread Rainer Orth
Hi Jan, >> Hi Jan, >> >> >* g++.dg/lto/alias-3_0.C: New file. >> >* g++.dg/lto/alias-3_1.c: New file. >> >> the new test has a couple of problems: DejaGnu warns everywhere: >> >> WARNING: lto.exp does not support dg-lto-do in secondary source files >> WARNING: lto.exp does not support d

Re: [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2019-07-16 Thread Richard Sandiford
Christophe Lyon writes: > The FDPIC register is hard-coded to r9, as defined in the ABI. > > We have to disable tailcall optimizations if we don't know if the > target function is in the same module. If not, we have to set r9 to > the value associated with the target module. > > When generating a

[COMMITTED][GCC8] Fix Thumb-1 ldm (PR89190)

2019-07-16 Thread Wilco Dijkstra
Hi, I've backported PR89190 to GCC8 so it's now fixed on all active branches. Also added pr89190.c testcase to GCC9 and trunk since it was accidentally not committed. Wilco This patch fixes an ICE in the Thumb-1 LDM peepholer. Thumb-1 LDMs always update the base register except if the base is

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-07-16 Thread Jason Merrill
On Tue, Jul 16, 2019 at 12:18 PM Maxim Kuvyrkov wrote: > > Hi Everyone, > > I've been swamped with other projects for most of June, which gave me time to > digest all the feedback I've got on GCC's conversion from SVN to Git. > > The scripts have heavily evolved from the initial version posted he

Re: [C++ PATCH] PR c++/90590 Suppress warning for enumeration value not handled in switch warning

2019-07-16 Thread Marek Polacek
On Mon, Jul 15, 2019 at 09:47:26AM -0400, Matthew Beliveau wrote: > Okay I kept the TYPE_MAIN_VARIANT and dropped the accidental new line! > Hopefully this should be fine! CCing Joseph as this is c-family/ stuff. > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > 2019-07-12 Matthew Bel

Re: [ARM/FDPIC v5 09/21] [ARM] FDPIC: Add support for taking address of nested function

2019-07-16 Thread Kyrill Tkachov
On 7/16/19 12:18 PM, Kyrill Tkachov wrote: Hi Christophe On 5/15/19 1:39 PM, Christophe Lyon wrote: > In FDPIC mode, the trampoline generated to support pointers to nested > functions looks like: > >    .word trampoline address >    .word trampoline GOT address >    ldr

[COMMITTED][GCC7][GCC8] Backport PR89222 (ARM thumb-2 misoptimisation of func ptr call with -O2 or -Os)

2019-07-16 Thread Wilco Dijkstra
Hi, I've backported PR89222 to GCC7 and GCC8 branches so it's now fixed on all active branches. Wilco [ARM] Fix PR89222 The GCC optimizer can generate symbols with non-zero offset from simple if-statements. Bit zero is used for the Arm/Thumb state bit, so relocations with offsets fail if it cha

Add dg test for matching function bodies

2019-07-16 Thread Richard Sandiford
There isn't a 1:1 mapping from SVE intrinsics to SVE instructions, but the intrinsics are still close enough to the instructions for there to be a specific preferred sequence (or sometimes choice of preferred sequences) for a given combination of operands. Sometimes these sequences will be one ins

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-07-16 Thread Maxim Kuvyrkov
> On Jul 16, 2019, at 3:34 PM, Jason Merrill wrote: > > On Tue, Jul 16, 2019 at 12:18 PM Maxim Kuvyrkov > wrote: >> >> Hi Everyone, >> >> I've been swamped with other projects for most of June, which gave me time >> to digest all the feedback I've got on GCC's conversion from SVN to Git. >>

Re: [PR other/79543] Fix GNU ld --version scanning to conform to the GNU Coding Standards (ping)

2019-07-16 Thread Chung-Lin Tang
Ping. (I think Joseph happens to be out, was wondering if any build maintainer or global reviewer can take a look?) Thanks, Chung-Lin On 2019/7/4 4:28 PM, Chung-Lin Tang wrote: On 2017/10/31 8:17 AM, Joseph Myers wrote: Specifically,*non-release*  versions of binutils predating my patch comm

[committed] [PR rtl-optimization/91173] Avoid creating modeless REGs due to simplifiable addresses

2019-07-16 Thread Jeff Law
In this BZ we generate a modeless REG and as a result eventually ICE gen_addr_rtx takes a symbol, base, index, step and offset from a MEM_REF and constructs suitable RTL for the address. The caller in question (addr_for_mem_ref) will use expand_expr on the above objects to turn them from trees i

[committed] pr91173 testcase

2019-07-16 Thread Jeff Law
Opps, forgot the testcase... Jeff commit 6a8750b4ecafeac5411075730e9f8fa7a1e8238a Author: law Date: Tue Jul 16 14:57:51 2019 + PR rtl-optimization/91173 * g++.dg/pr91173.C: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@273531 138bc75d-0d04-0410

[OG9, committed] Re: [PR other/79543] Fix GNU ld --version scanning to conform to the GNU Coding Standards

2019-07-16 Thread Chung-Lin Tang
This patch has been committed ahead to openacc-gcc-9-branch [OG9], we will revert and adjust in case the patch is not approved for trunk later. Chung-Lin On 2019/7/16 10:27 PM, Chung-Lin Tang wrote: 2019-07-04  Chung-Lin Tang  libatomic/  PR other/79543  * acinclude

Re: [PATCH] Make a warning for -Werror=wrong-language (PR driver/91172).

2019-07-16 Thread Martin Sebor
On 7/16/19 5:16 AM, Martin Liška wrote: Hi. I noticed in the PR that -Werror=argument argument is not verified that the option is supported by a language we compile for. That's changed in the patch. However, it's not ideal as I need to mark the -Werror as the problematic option and one can't pri

Re: [C++ PATCH] Speed up inplace_merge algorithm & fix inefficient logic(PR libstdc++/83938)

2019-07-16 Thread François Dumont
Hi     I eventually spent much more time working on the inplace_merge performance bench.     And the results do not confirm the theory: Before patch: inplace_merge.cc     bench 1 / 1 memory        243r  227u   17s  1216mem    5pf inplace_merge.cc     bench 1 / 4 memor

Re: Deque fiil/copy/move/copy_backward/move_backward/equal overloads

2019-07-16 Thread François Dumont
Ping ? On 6/19/19 7:32 PM, François Dumont wrote: I wanted to implement Debug overloads for those already existing overloads but then realized that those algos could be generalized. This way we will benefit from the memmove replacement when operating with C array or std::array or std::vector i

[PATCH, i386]: Further fixes/improvements for TEST patterns

2019-07-16 Thread Uros Bizjak
2019-07-16 Uroš Bizjak * config/i386/i386.md (*testdi_1): Match CCZmode for constants that might have the SImode sign bit set. (*testqi_1_maybe_si): Remove "!" constraint modifier. Use correct constraints for pentium pairing. (*test_1): Ditto. Bootstrapped and regression te

Re: [PATCH], PowerPC, Patch #9, Refine calculation of whether an address offset is d-form, ds-form, or dq-form

2019-07-16 Thread Michael Meissner
On Fri, Jul 12, 2019 at 11:49:51AM -0500, Segher Boessenkool wrote: > Many of those are not clear why you allow or do not allow certain forms, > or what each is meant to be used for. For example: > > > + enum rs6000_offset_format format_gpr_64bit > > += (TARGET_POWERPC64) ? OFFSET_FORMAT_DS

Re: [PATCH] RISC-V: Fix splitter for 32-bit AND on 64-bit target.

2019-07-16 Thread Jim Wilson
On Tue, Jul 16, 2019 at 12:42 AM Kito Cheng wrote: > I'd like to back port this patch to GCC 8 and 9, should I send another > patch mail or just wait ack from release manager? I think it is only relevant to the gcc-9 branch. The buggy pattern was added June 2018, which is a while after the gcc-8

Re: [range-ops] patch 01/04: types for VR_UNDEFINED and VR_VARYING

2019-07-16 Thread Andrew MacLeod
On 7/9/19 5:56 AM, Richard Biener wrote: On Tue, Jul 9, 2019 at 9:28 AM Aldy Hernandez wrote: On 7/4/19 6:33 AM, Richard Biener wrote: On Wed, Jul 3, 2019 at 2:17 PM Aldy Hernandez wrote: On 7/3/19 7:08 AM, Richard Biener wrote: On Wed, Jul 3, 2019 at 11:19 AM Aldy Hernandez wrote: How

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-07-16 Thread Rich Felker
On Tue, Jul 16, 2019 at 11:34:06AM +0100, Richard Sandiford wrote: > > diff --git a/gcc/config/arm/linux-eabi.h b/gcc/config/arm/linux-eabi.h > > index 66ec0ea..d7cc923 100644 > > --- a/gcc/config/arm/linux-eabi.h > > +++ b/gcc/config/arm/linux-eabi.h > > @@ -89,7 +89,7 @@ > > #define MUSL_DYNAMIC

Re: [Patch, fortran] PR90903 - Implement runtime checks for bit manipulation intrinsics

2019-07-16 Thread Harald Anlauf
Committed with svn revision 273535. Steve, Paul, thanks for the review! Harald On 07/16/19 07:40, Paul Richard Thomas wrote: > Hi Harald and Steve, > > The patch looks fine to me - it's good be committed. > > Thanks > > Paul > > On Mon, 15 Jul 2019 at 03:34, Steve Kargl > wrote: >> >> Harald, t

Re: Fix -Wreturn-type for static naked functions in C

2019-07-16 Thread Marek Polacek
On Tue, Jul 16, 2019 at 09:50:31AM +0100, Richard Sandiford wrote: > This patch extends the fix for PR53633 to include static functions, > which were giving a bogus -Wreturn-type warning for C but not for C++. > > Tested on aarch64-linux-gnu, x86_64-linux-gnu and armeb-eabi. > OK for trunk? OK fo

Re: [PATCH], Patch #6, revision 3, Create pc-relative addressing insns

2019-07-16 Thread Segher Boessenkool
Hi Mike, On Tue, Jul 16, 2019 at 02:19:14AM -0400, Michael Meissner wrote: > I have changed the TARGET_TOC to be TARGET_HAS_TOC in the aix, darwin, system > V, and Linux 64-bit headers. Then in rs6000.h, TARGET_TOC is defined in terms > of TARGET_HAS_TOC and not pc-relative referencing. Cool, th

Re: [PATCH v3 0/5] OpenRISC updates for 10 (fpu, fixes)

2019-07-16 Thread Stafford Horne
On Tue, Jul 09, 2019 at 10:06:21PM +0900, Stafford Horne wrote: > Hello, > > New since v2: > - Fix comment formatting pointed out by Segher in valatile patch > - Fix issue and add test for rotrsi3 options pointed out by Segher > - Fix issue with reg mask for doubles being backwards Pointed out

Re: [C++] Don't fold __builtin_constant_p prematurely

2019-07-16 Thread Marc Glisse
Adding a C++ maintainer in Cc: https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00808.html On Wed, 10 Jul 2019, Marc Glisse wrote: Hello, this avoids folding __builtin_constant_p to 0 early when we are not forced to do so. Clearly this has an effect, since it uncovered a bug in wi::lshift, fixe

Re: [PATCH], PowerPC, Patch #9, Refine calculation of whether an address offset is d-form, ds-form, or dq-form

2019-07-16 Thread Segher Boessenkool
%s/format/form/g On Tue, Jul 16, 2019 at 01:29:50PM -0400, Michael Meissner wrote: > On Fri, Jul 12, 2019 at 11:49:51AM -0500, Segher Boessenkool wrote: > > Many of those are not clear why you allow or do not allow certain forms, > > or what each is meant to be used for. For example: > > > > > +

Re: [PATCH], Patch #6, revision 3, (Test on AIX and Darwin)

2019-07-16 Thread Michael Meissner
David, would it be possible to do a bootstrap on AIX to make sure I haven't broken anything before I commit the patch to the trunk? Ian, if you have time, could you also do the PowerPC Darwin port that would be helpful also. Now, the changes are pretty simple, and I expect them to be fine. Basic

Re: [PATCH v4] Generalize get_most_common_single_value to return k_th value & count

2019-07-16 Thread luoxhu
Currently get_most_common_single_value could only return the max hist , add sort after reading from disk, then it return nth value in later use. Rename it to get_nth_most_common_value. Hi Martin, Thanks for your review, v4 Changes as below: 1. Use decrease bubble sort. BTW, I have a question abo

-Wmissing-attributes: avoid duplicates and false positives

2019-07-16 Thread Alexandre Oliva
Hello, Martin, The initial patch for PR 81824 fixed one of the possibilities of -Wmissing-attributes reporting duplicates, namely, if TMPL had an attribute in ATTRLIST that was missing from DECL's decl and type attribute lists, both being non-empty. Another possibility of duplicate reporting rema

[PATCH PR91137]Find base object for ivopts via walk_tree

2019-07-16 Thread bin.cheng
Hi, This patch fixes PR91137 by finding base objects with walk_tree utility. Note we specially return integer_zero_node when a tree expression contains multiple base objects. This works since the special node is compared unequal to any real base object, thus skipped in candidate selection. Thi