[Darwin, committed] Fix some format-related build warnings.

2019-10-06 Thread Iain Sandoe
This fixes two error messages to avoid punctuation characters and contracted negations. tested on x86_64-darwin16, applied to mainline thanks Iain gcc/ChangeLog: 2019-10-06 Iain Sandoe * config/darwin.c (darwin_override_options): Adjust objective-c ABI version error messages

Re: [21/32] Remove global call sets: LRA

2019-10-06 Thread Uros Bizjak
>>> This caused: >>> >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91994 > > Thanks for reducing & tracking down the underlying cause. > >> This change doesn't work with -mzeroupper. When -mzeroupper is used, >> upper bits of vector registers are clobbered upon callee return if any >> MM/ZMM re

Re: [PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[a-c]*.c

2019-10-06 Thread Bernd Edlinger
On 10/5/19 8:24 PM, Segher Boessenkool wrote: > > I am maintainer of combine, I know all about its many problems (it has much > deeper problems than this unfortunately). Thanks for your help though, this > is much appreciated, but I do think your current patch is not a step in the > right directi

Re: [EXTERNAL]Re: Re: [PATCH] [MIPS] Fix PR target/91769

2019-10-06 Thread Dragan Mladjenovic
On 06.10.2019. 08:43, Paul Hua wrote: > Hi: > > The testsuite has a typo in "dg-final scan-assembler", s/mthc1/mtc1/. > Hi, I think I know what is happening here. My testing setup defaults to -mfpxx and yours probably to -mfp32. I should have probably tightened the test up to require R2 isa

Re: [21/32] Remove global call sets: LRA

2019-10-06 Thread Richard Sandiford
Uros Bizjak writes: This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91994 >> >> Thanks for reducing & tracking down the underlying cause. >> >>> This change doesn't work with -mzeroupper. When -mzeroupper is used, >>> upper bits of vector registers are clobbered upon call

Re: [PATCH][RFC] Add new ipa-reorder pass

2019-10-06 Thread Jan Hubicka
> On 9/19/19 2:33 AM, Martin Liška wrote: > > Hi. > > > > Function reordering has been around for quite some time and a naive > > implementation was also part of my diploma thesis some time ago. > > Currently, the GCC can reorder function based on first execution, which > > happens with PGO and LT

[patch, fortran] Fix PR 92004, restore Lapack compilation

2019-10-06 Thread Thomas Koenig
Hello world, this patch fixes an overzealous interpretation of F2018 15.5.2.4, where an idiom of passing an array element to an array was rejected. This also restores Lapack compilation without warning. Regression-tested. OK for trunk? Regards Thomas 2019-10-06 Thomas Koenig

Re: C++ PATCH for C++20 P0388R4 (conversions to arrays of unknown bounds) and CWG 1307 (c++/91364, c++/69531)

2019-10-06 Thread Tam S. B.
Hi, sorry for chiming in. IIUC P0388R4 does not allow implicit conversion from `T(*)[]` to `T(*)[N]`. Per [conv.qual]/3, > A prvalue of type `T1` can be converted to type `T2` if the cv-combined type > of `T1` and `T2` is `T2`. When T1 is `T(*)[]` and T2 is `T(*)[N]`, the "cv-combined type" i

[committed] Fix EXECUTE_IF_SET_IN_HARD_REG_SET use

2019-10-06 Thread Richard Sandiford
As Maxim pointed out, r276309 broke -O3 bootstrap for aarch64-linux-gnu. It turns out that EXECUTE_IF_SET_IN_HARD_REG_SET isn't safe to use for temporary objects because their lifetimes don't extend to the end of the loop. This patch therefore uses an explicit temporary instead. Other patches in

Re: [patch, fortran] Fix PR 92004, restore Lapack compilation

2019-10-06 Thread Thomas Koenig
Am 06.10.19 um 17:26 schrieb Thomas Koenig: This also restores Lapack compilation without warning. Well, up to an error in the testing routines, at least. TESTING/LIN/sdrvls.f has REAL, ALLOCATABLE :: WORK (:) ... REAL RESULT( NTESTS ), WQ and calls

Re: [PATCH] PR fortran/91801 -- convert assert to an error

2019-10-06 Thread Thomas Koenig
Hi Steve, Tested on x86_64-*-freebsd. OK to commit? OK. Thanks a lot for the patch!

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-06 Thread Bernd Edlinger
On 10/5/19 9:24 AM, Jakub Jelinek wrote: > On Sat, Oct 05, 2019 at 06:12:37AM +, Bernd Edlinger wrote: >> On 10/3/19 5:25 PM, Jakub Jelinek wrote: >>> What effect does this have on the cc1/cc1plus .text sizes? >> >> r276457: >> >> with patch, --enable-languages=all --enable-checking=yes,rtl >>

Re: [obvious, PATCH 4/3][doc] -Wuninitialized doesn't do -Wclobbered's job

2019-10-06 Thread Sandra Loosemore
On 10/3/19 9:12 AM, Vladislav Ivanishin wrote: Oh, and this old documentation bug. (AFAICT this is a historical artifact from the pre-tree-ssa times when both -Wclobbered and -Wuninitialized were implemented on RTL.) This one is actually independent of the others and, I believe, is obvious enou

Re: [PATCH] Update documentation of -Wshadow

2019-10-06 Thread Sandra Loosemore
On 10/3/19 9:16 AM, Bernd Edlinger wrote: Hi, I've noticed that the documentation of -Wshadow=x has some missing bits, and I want to add an negative example to -Wshadow=compatble-local. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. Is it OK for trunk? Index: gcc/doc/invoke.texi =

[PATCH 0/4] OpenACC 2.6 manual deep copy (repost)

2019-10-06 Thread Julian Brown
Hi, This patch series comprises an updated version of manual deep copy support for OpenACC 2.6. This was last posted upstream starting here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00823.html The reference counting changes from the 3rd patch from that submission have been reposted a few

[PATCH 3/4] Factor out duplicate code in gimplify_scan_omp_clauses

2019-10-06 Thread Julian Brown
This patch factors out some code in gimplify_scan_omp_clauses into two new outlined functions. Previously approved here: https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01309.html FAOD, OK for trunk? Thanks, Julian ChangeLog gcc/ * gimplify.c (insert_struct_comp_map, check_bas

[PATCH 2/4] Use gomp_map_val for OpenACC host-to-device address translation

2019-10-06 Thread Julian Brown
This patch uses gomp_map_val for OpenACC host-to-device address translation instead of open-coding the device address calculation. OK for trunk? Thanks, Julian ChangeLog libgomp/ * libgomp.h (gomp_map_val): Add prototype. * oacc-parallel.c (GOACC_parallel_keyed): Use go

[PATCH 1/4] Add function for pretty-printing OpenACC clause names

2019-10-06 Thread Julian Brown
This patch adds a function to pretty-print OpenACC clause names from OMP_CLAUSE_MAP_KINDs, for error output. The function is used by subsequent patches. Previously approved as part of: https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01292.html FAOD, OK for trunk? Julian ChangeLog gcc/

Re: [PATCH] Update documentation of -Wshadow

2019-10-06 Thread Bernd Edlinger
Hi Sandra, On 10/6/19 10:23 PM, Sandra Loosemore wrote: > On 10/3/19 9:16 AM, Bernd Edlinger wrote: >> Hi, >> >> I've noticed that the documentation of -Wshadow=x has some >> missing bits, and I want to add an negative example to >> -Wshadow=compatble-local. >> >> >> Bootstrapped and reg-tested on

Re: [21/32] Remove global call sets: LRA

2019-10-06 Thread Uros Bizjak
On Sun, Oct 6, 2019 at 4:32 PM Richard Sandiford wrote: > > Uros Bizjak writes: > This caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91994 > >> > >> Thanks for reducing & tracking down the underlying cause. > >> > >>> This change doesn't work with -mzeroupper. When -mze

Re: [PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[a-c]*.c

2019-10-06 Thread Richard Biener
On Sun, Oct 6, 2019 at 1:24 PM Bernd Edlinger wrote: > > On 10/5/19 8:24 PM, Segher Boessenkool wrote: > > > > I am maintainer of combine, I know all about its many problems (it has much > > deeper problems than this unfortunately). Thanks for your help though, this > > is much appreciated, but I