Re: C++ PATCH for c++/91678 - wrong error with decltype and location wrapper

On 12/6/19 7:18 PM, Marek Polacek wrote: [ Sorry for dropping the ball on this. ] On Tue, Sep 17, 2019 at 11:59:02PM -0400, Jason Merrill wrote: On 9/16/19 1:12 PM, Marek Polacek wrote: On Sun, Sep 15, 2019 at 10:18:29AM -0400, Jason Merrill wrote: On 9/5/19 9:24 PM, Marek Polacek wrote: The

Re: [PATCH 28/49] analyzer: new files: analyzer.{cc|h}

On 11/15/19, David Malcolm wrote: > gcc/ChangeLog: > * analyzer/analyzer.cc: New file. > * analyzer/analyzer.h: New file. > --- > gcc/analyzer/analyzer.cc | 125 > ++ > gcc/analyzer/analyzer.h | 126 > +++

Re: [PATCH 01/49] analyzer: user-facing documentation

On Fri, 2019-12-06 at 14:57 -0500, Eric Gallager wrote: > While I get that this is just the documentation, having a good list > like this will make it easy to use to respond to the individual items > it documents, so that's what I'm going to use it for: Thanks; I'm slowly working though the bugzil

Re: [PATCH 1/2] pretty-print: support URL escape sequences (PR 87488)

On Sat, 2019-12-07 at 00:41 +0100, Jakub Jelinek wrote: > On Thu, Oct 10, 2019 at 01:06:13PM -0400, David Malcolm wrote: > > https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda > > describes an emerging standard for embedding URLs in escape > > sequences > > for marking up text outpu

Re: [PING 3][PATCH] track dynamic allocation in strlen (PR 91582)

On Fri, Dec 06, 2019 at 05:19:36PM -0700, Martin Sebor wrote: > With part 2 (below) of this work committed, I've rebased the patch > on the top of trunk and on top of the updated part 1 (also below). > Attached is the result, retested on x86_64-linux. > --- a/gcc/tree-ssa-strlen.c > +++ b/gcc/tree

[PING 3][PATCH] track dynamic allocation in strlen (PR 91582)

With part 2 (below) of this work committed, I've rebased the patch on the top of trunk and on top of the updated part 1 (also below). Attached is the result, retested on x86_64-linux. [1] include size and offset in -Wstringop-overflow https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00392.html

Re: C++ PATCH for c++/91678 - wrong error with decltype and location wrapper

[ Sorry for dropping the ball on this. ] On Tue, Sep 17, 2019 at 11:59:02PM -0400, Jason Merrill wrote: > On 9/16/19 1:12 PM, Marek Polacek wrote: > > On Sun, Sep 15, 2019 at 10:18:29AM -0400, Jason Merrill wrote: > > > On 9/5/19 9:24 PM, Marek Polacek wrote: > > > > They use > > > > non_lvalue_lo

Re: [PATCH] Come up with constructors of symtab_node, cgraph_node and varpool_node.

On 5 December 2019 16:24:53 CET, "Martin Liška" wrote: -/* Allocate new callgraph node. */ - -inline cgraph_node * -symbol_table::allocate_cgraph_symbol (void) -{ - cgraph_node *node; - - node = ggc_cleared_alloc (); - node->type = SYMTAB_FUNCTION; - node->m_summary_id = -1; - node->m_uid =

Re: Add a new combine pass

On Fri, 2019-12-06 at 16:51 -0600, Segher Boessenkool wrote: > On Wed, Dec 04, 2019 at 07:43:30PM +0900, Oleg Endo wrote: > > On Tue, 2019-12-03 at 12:05 -0600, Segher Boessenkool wrote: > > > > Hmm ... the R0 problem ... SH doesn't override class_likely_spilled > > > > explicitly, but it's got a R

[committed] Fix up xvalue handling in ?: with omitted middle operand (PR c++/92831)

On Fri, Dec 06, 2019 at 02:31:55PM -0500, Jason Merrill wrote: > > Note, just to double check g++ doesn't ICE on expr1 ? : expr2 GNU extension, > > I also wrote the attached testcase, but unlike the testcase included in the > > patch which behaves the same with patched g++ as does recent clang++, t

Re: [PATCH 1/2] pretty-print: support URL escape sequences (PR 87488)

On Thu, Oct 10, 2019 at 01:06:13PM -0400, David Malcolm wrote: > https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda > describes an emerging standard for embedding URLs in escape sequences > for marking up text output. This is supported e.g. by recent releases > of GNOME Terminal.

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

On Thu, Dec 05, 2019 at 08:44:57AM +, Iain Sandoe wrote: > .. or I can just force a false return from effective_target_dfp as we > do for other cases where assembler support does not imply system > support. That's what I would do, yes. Segher

Re: PowerPC V9 patches, Add the PCREL_OPT optimization

On Thu, Dec 05, 2019 at 10:14:13AM +1030, Alan Modra wrote: > On Wed, Dec 04, 2019 at 05:16:05PM -0600, Segher Boessenkool wrote: > > > pla 9,ext_symbol@pcrel # add (0),1 for optional operands > > > > pla does not have optional operands like that? > > It does, just like load/store insns. That

Re: Add a new combine pass

On Wed, Dec 04, 2019 at 07:43:30PM +0900, Oleg Endo wrote: > On Tue, 2019-12-03 at 12:05 -0600, Segher Boessenkool wrote: > > > Hmm ... the R0 problem ... SH doesn't override class_likely_spilled > > > explicitly, but it's got a R0_REGS class with only one said reg in it. > > > So the default impl

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

On Tue, 2019-11-12 at 09:11 +, Matthew Malcomson wrote: > In scheduling passes, notes are removed with `remove_notes` before > the > > scheduling is done, and added back in with `reemit_notes` once the > > scheduling has been decided. > > > > This process leaves the notes in the RTL chain

Re: [PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

On Wed, 2019-11-13 at 09:27 -0700, Sandra Loosemore wrote: > > I bootstrapped and regression-tested this on x86_64-linux-gnu. There > are a few regressions involving these tests: > > gcc.dg/tree-ssa/pr77445-2.c I believe tihs is another instance of the FSA optimization. I'd need to see the befo

Re: [PATCH 16/49] Add support for in-tree plugins

On 11/15/19, David Malcolm wrote: > This patch adds support for "in-tree" plugins i.e. GCC plugins that live > in the GCC source tree and are shipped as part of the GCC tarball. Nick Clifton was asking us to do something like this anyways in his talk at Cauldron on his annobin plugin; it might be

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

On Wed, 2019-12-04 at 12:55 -0700, Martin Sebor wrote: > On 11/15/19 6:22 PM, David Malcolm wrote: > > This patch kit introduces a static analysis pass for GCC that can > > diagnose > > various kinds of problems in C code at compile-time (e.g. double- > > free, > > use-after-free, etc). > > I have

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

On Tue, 2019-12-03 at 11:52 -0500, David Malcolm wrote: > On Wed, 2019-11-20 at 11:18 +0100, Richard Biener wrote: > > On Tue, Nov 19, 2019 at 11:02 PM David Malcolm > > > > wrote: > > > > > The checker is implemented as a GCC plugin. > > > > > > > > > > The patch kit adds support for "in-tree" p

Re: [PATCH] [libiberty] Fix read buffer overflow in split_directories

On Thu, 2019-11-28 at 22:10 +0100, Tim Rühsen wrote: > An empty name param leads to read buffer overflow in > function split_directories. > > * libiberty/make-relative-prefix.c (split_directories): > Return early on empty name. > --- > libiberty/ChangeLog | 7 +++ > libiberty/m

[committed] Add test for c++/92451

This was ICEing from r277865 to r278786. Tested on x86_64-linux, applying to trunk. 2019-12-06 Marek Polacek PR c++/92451 * g++.dg/overload/error4.C: New test. --- /dev/null +++ gcc/testsuite/g++.dg/overload/error4.C @@ -0,0 +1,6 @@ +// PR c++/92451 + +template struct Local {

Re: Fix profile updatin in tree-ssa-threadupdate

On Thu, 2019-12-05 at 11:12 +0100, Jan Hubicka wrote: > Hi, > this patch makes tree-ssa-threadupdate to not leave basic blocks with > undefined counts in the program. > > create_block_for_threading sets counts as follows: > > /* Zero out the profile, since the block is unreachable for > now.

Re: Fix @multitable handling in texi2pod.pl

On Fri, 2019-12-06 at 10:17 +, Richard Sandiford wrote: > While trying out Dennis's Armv8.6-A patch, I noticed that texi2pod.pl > didn't handle the new @multitable correctly. There were two > problems: > > (1) @multitables nested in other @tables inherited the @item type > from > the encl

Re: [C++ Patch] Improve build_*_cast locations

Hi, On 06/12/19 18:53, Jason Merrill wrote: On 12/6/19 11:14 AM, Paolo Carlini wrote: Hi, as promised, the below takes care of the various remaining casts. It's mostly mechanical, follows the same approach used for build_functional_cast. Tested x86_64-linux. It occurs to me that once we're

Re: [C++ PATCH] (temporarily) undefine __cpp_consteval

On 11/29/19 4:30 AM, Jakub Jelinek wrote: Hi! When submitting the P1902R1 patch for missing feature macros, I completely forgot that we can't claim consteval support, because we have the /* FIXME: For now. */ if (virtualp && (inlinep & 8) != 0) { sorry_at (DECL_SOURCE_LOCATION

Re: [C++ PATCH] Tweak concept diagnostics

On 12/6/19 3:20 PM, Jakub Jelinek wrote: Hi! I've noticed that while for requires keyword we have a diagnostics like error_at (cp_lexer_peek_token (parser->lexer)->location, "% only available with " "%<-std=c++2a%> or %<-fconcepts%>"); for con

[C++ PATCH] Tweak concept diagnostics

Hi! I've noticed that while for requires keyword we have a diagnostics like error_at (cp_lexer_peek_token (parser->lexer)->location, "% only available with " "%<-std=c++2a%> or %<-fconcepts%>"); for concept keyword we emit inform (location,

Re: [PATCH 01/49] analyzer: user-facing documentation

While I get that this is just the documentation, having a good list like this will make it easy to use to respond to the individual items it documents, so that's what I'm going to use it for: On 11/15/19, David Malcolm wrote: > gcc/ChangeLog: > * doc/invoke.texi ("Static Analyzer Options"):

Re: libgo patch committed: Always mark assembly file as non-executable stack

Thanks, rather than try to make this work everywhere, I decided to only build the file for x86 GNU/Linux for now, since that is the only place it is currently used. This patch bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE =

libgo patch committed: Update HURD support for embedded mOS

In the update to 1.13 the mOS field of an m was embedded rather than named. This patch updates the HURD support for that change. This should fix GCC PR 92842. I built the code on x86_64-pc-linux-gnu, but that doesn't actually test this. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Patch to fix PR92176

The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92176 The patch was tested on i686, x86-64, and ppc64. Committed as r279061. Index: ChangeLog === --- ChangeLog (revision 279060) +++ ChangeLog (working copy)

Re: [C++ PATCH] CWG 1299, not extending temporary lifetime for ?: (PR c++/92831)

On 12/6/19 11:28 AM, Jakub Jelinek wrote: Hi! This is a reason latest firefox is miscompiled by G++ 9, seems DR 1299 says in [class.temporary]/(6.7) that reference binding to a temporary object from the second or third operand of a conditional expression should have extended lifetime too, but ex

[PATCH] i386: Use add for a = a + b and a = b + a when possible

Since except for Bonnell, 01 fbadd%edi,%ebx is faster and shorter than 8d 1c 1f lea(%rdi,%rbx,1),%ebx we should use add for a = a + b and a = b + a when possible if not optimizing for Bonnell. Tested on x86-64. gcc/ PR target/92807 * config/i386/i386.c (i

Re: [PATCH] add -Wmismatched-tags (PR 61339)

On 12/5/19 6:47 PM, Jakub Jelinek wrote: On Thu, Dec 05, 2019 at 04:33:10PM -0700, Martin Sebor wrote: It's hard to distinguish between this type and the previous one by name; this one should probably have "map" in its name. +static GTY (()) record_to_locs_t *rec2loc; ... +    rec2loc = new

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

Hi Christophe, > In practice, how do you activate it when running the GCC testsuite? Do > you plan to send a GCC patch to enable this assembler flag, or do you > locally enable that option by default in your binutils? The warning is off by default so there is no need to do anything in the testsu

Re: [PATCH] track dynamic allocation in strlen (PR 91582)

On 11/30/19 9:31 AM, Christophe Lyon wrote: On Tue, 12 Nov 2019 at 02:28, Martin Sebor wrote: The attached patch extends the strlen pass to detect out-of-bounds accesses to memory allocated by calls to other allocation functions besides calloc and malloc, as well as VLAs, and user-defined func

Re: [committed, amdgcn] Enable QI/HImode vector moves

Andrew Stubbs writes: > Hi all, > > This patch re-enables the V64QImode and V64HImode for GCN. > > GCC does not make these easy to work with because there is (was?) an > assumption that vector registers do not have excess bits in vector > registers, and therefore does not need to worry about tru

Re: [PATCH 21/49] analyzer: command-line options

On 12/4/19, Martin Sebor wrote: > On 11/15/19 6:23 PM, David Malcolm wrote: >> This patch contains the command-line options for the analyzer. >> > > Some of the -Wanalyzer- options sounds like they control similar > warnings as existing options (e.g., -Wanalyzer-null-argument sounds > like -Wnonnu

[committed, amdgcn] Fix unrecognised instruction

Hi all, I've committed the attached to fix a failure-to-assemble bug that can occur in some vectorized code. This has been hidden for a long time because sub-word vectors were disabled on GCN, but this is no longer the case. The gather load instructions had the suffixes for store, which did

Re: [C++ Patch] Improve build_*_cast locations

On 12/6/19 11:14 AM, Paolo Carlini wrote: Hi, as promised, the below takes care of the various remaining casts. It's mostly mechanical, follows the same approach used for build_functional_cast. Tested x86_64-linux. It occurs to me that once we're passing the location into the build_* functi

Re: Ping: [PATCH][C++] Pass type uses through the verify_type_context hook

On 12/6/19 9:26 AM, Richard Sandiford wrote: Jason Merrill writes: On 12/5/19 1:21 PM, Richard Sandiford wrote: + else if (!verify_type_context (input_location, TCTX_EXCEPTIONS, type)) +return false; + + else if (TYPE_REF_P (type) + && !verify_type_context (input_location, TCTX_

Re: [PATCH 09/49] gimple const-correctness fixes

On Fri, 2019-12-06 at 11:52 +0100, Richard Biener wrote: > On Sat, Nov 16, 2019 at 2:20 AM David Malcolm > wrote: > > This patch converts various "gimple *" to "const gimple *" and > > similar > > fixes for gimple subclasses, adding is_a_helper for gimple > > subclasses > > to support the const fo

[committed, amdgcn] Enable QI/HImode vector moves

Hi all, This patch re-enables the V64QImode and V64HImode for GCN. GCC does not make these easy to work with because there is (was?) an assumption that vector registers do not have excess bits in vector registers, and therefore does not need to worry about truncating or extending smaller type

[PATCH] Allow entry point markers without debug support in accelerator compiler

Hello A number of the libgomp tests running with AMD GCN offloading fail with the following internal compiler error: during RTL pass: final /scratch/ci-cs/amdtest/upstream-offload/src/gcc-mainline/libgomp/testsuite/libgomp.fortran/examples-4/async_target-1.f90: In function 'pipedf_._omp_fn.2'

Re: libgo patch committed: Always mark assembly file as non-executable stack

Hi Matthias, > On 06.12.19 12:28, Rainer Orth wrote: >> I Ian, >> >>> This libgo patch arranges for go-context.S to always be marked as >>> using a non-executable stack. This is not required for all targets, >>> but should do little harm. Bootstrapped on x86_64-pc-linux-gnu. >>> Committed to ma

Patch ping (was Re: [C++ PATCH] (temporarily) undefine __cpp_consteval)

On Fri, Nov 29, 2019 at 10:30:13AM +0100, Jakub Jelinek wrote: > 2019-11-29 Jakub Jelinek > > * c-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for > now. > > * g++.dg/cpp2a/feat-cxx2a.C: Don't test __cpp_consteval for now. I'd like to ping this patch (the wwwd

Re: [PATCH] extend -Wstringop-overflow to allocated objects (PR 91582)

On 12/6/19 8:44 AM, Christophe Lyon wrote: On Thu, 5 Dec 2019 at 02:37, Martin Sebor wrote: On 12/2/19 10:06 AM, Jeff Law wrote: On 11/8/19 3:11 PM, Martin Sebor wrote: Unless it's used with _FORTIFY_SOURCE, -Wstringop-overflow doesn't consider out-of-bounds accesses to objects allocated by

Re: *PING* – Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic

On Fri, Dec 6, 2019 at 10:02 AM Tobias Burnus wrote: > > *Ping* Ok. > > Regarding Frederik's remark about the testsuite: > > I think the only test case in gfortran.dg/, which tests the column > number, is use_without_only_1.f90. It has: > { dg-warning "7:has no ONLY qualifier" } > here, the "7" i

[PATCH] Canonicalize fancy ways of expressing blend operation into COND_EXPR (PR tree-optimization/92834)

Hi! The following patch canonicalizes fancy ways of writing cond ? A : B into COND_EXPR, which is what we expect people writing and thus are able to optimize it better. If in some case we wouldn't optimize it better, the right way would be improve the COND_EXPR handling, as that is what people ar

Re: [PATCH, Modula-2 (C/C++/D/F/Go/Jit)] (Register spec fn) (v3)

On 17.11.19 07:49, Gaius Mulley wrote: > > Hello, > > while spending the weekend on the Howland and Baker islands :-) I > thought I'd post version three of the patches which introduce Modula-2 > into the GCC trunk. The patches include: [...] > At a later point (after it is reviewed/approved) t

[C++ PATCH] CWG 1299, not extending temporary lifetime for ?: (PR c++/92831)

Hi! This is a reason latest firefox is miscompiled by G++ 9, seems DR 1299 says in [class.temporary]/(6.7) that reference binding to a temporary object from the second or third operand of a conditional expression should have extended lifetime too, but extend_ref_init_temps_1 was apparently handlin

Re: libgo patch committed: Always mark assembly file as non-executable stack

On 06.12.19 12:28, Rainer Orth wrote: > I Ian, > >> This libgo patch arranges for go-context.S to always be marked as >> using a non-executable stack. This is not required for all targets, >> but should do little harm. Bootstrapped on x86_64-pc-linux-gnu. >> Committed to mainline. > > unfortuna

[C++ Patch] Improve build_*_cast locations

Hi, as promised, the below takes care of the various remaining casts. It's mostly mechanical, follows the same approach used for build_functional_cast. Tested x86_64-linux. Thanks, Paolo. gcc/cp 2019-12-06 Paolo Carlini * typeck.c (check_for_casting_away_con

Re: [PATCH] Enable ICE-after-error with -fchecking

On Wed, Dec 04, 2019 at 05:26:25PM +0100, Jakub Jelinek wrote: > I'd fear people will use -fchecking and feel error-recovery bugs are then > more important because they no longer get the more user friendly message. > Can't we arrange for the emergency IL dump to happen in this case anyway? Does it

Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)

On Tue, 2019-11-26 at 11:28 -0500, Lewis Hyatt wrote: > New version 4 patch attached, and responses below too. > Thanks for the various updates; sorry about the delay in responding. [...] > > As noted above, m_x_offset should be renamed to clarify its units > > ("m_x_offset_display"?) > > > >

Re: [PATCH] extend -Wstringop-overflow to allocated objects (PR 91582)

On Thu, 5 Dec 2019 at 02:37, Martin Sebor wrote: > > On 12/2/19 10:06 AM, Jeff Law wrote: > > On 11/8/19 3:11 PM, Martin Sebor wrote: > >> Unless it's used with _FORTIFY_SOURCE, -Wstringop-overflow > >> doesn't consider out-of-bounds accesses to objects allocated > >> by alloca, malloc, other func

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

On Fri, 6 Dec 2019 at 16:03, Wilco Dijkstra wrote: > > Hi Christophe, > > I've added an option to allow the warning to be enabled/disabled: > https://sourceware.org/ml/binutils/2019-12/msg00093.html > Thanks. In practice, how do you activate it when running the GCC testsuite? Do you plan to send

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

Hi Christophe, I've added an option to allow the warning to be enabled/disabled: https://sourceware.org/ml/binutils/2019-12/msg00093.html Cheers, Wilco

Re: [PATCH] [libgomp, amdgcn] Fix Fortran linker errors on AMD GCN

Hi Kwok! On 2019-12-06T14:17:47+, Kwok Cheung Yeung wrote: > While running the libgomp testsuite with an AMD GCN card configured as > as the offload accelerator, I often see these errors with the Fortran > testcases: > > ld: error: undefined symbol: gomp_ialias_omp_get_num_procs refere

Re: Ping: [PATCH][C++] Pass type uses through the verify_type_context hook

Jason Merrill writes: > On 12/5/19 1:21 PM, Richard Sandiford wrote: >> + else if (!verify_type_context (input_location, TCTX_EXCEPTIONS, type)) >> +return false; >> + >> + else if (TYPE_REF_P (type) >> + && !verify_type_context (input_location, TCTX_EXCEPTIONS, >> +

Re: [PATCH] Come up with constructors of symtab_node, cgraph_node and varpool_node.

Hi, On Thu, 5 Dec 2019, Richard Biener wrote: > >> Indeed - please adjust that as well. > > > >Explicit ctors are a c++11+ feature. > > Surely not. Whoops, I was conflating ctors and conversion functions, the latter can be explicit only in c++11+. Ciao, Michael.

[PATCH] [libgomp, amdgcn] Fix Fortran linker errors on AMD GCN

Hello While running the libgomp testsuite with an AMD GCN card configured as as the offload accelerator, I often see these errors with the Fortran testcases: ld: error: undefined symbol: gomp_ialias_omp_get_num_procs referenced by fortran.c:330 (/scratch/ci-cs/amdtest/upstream-offload/src/g

Fwd: [PATCH, GCC, Vect] Fix costing for vector shifts

Hi While looking at the vectorization for following example, we realized that even though vectorizable_shift function was distinguishing vector shifted by vector from vector shifted by scalar, while modeling the cost it would always add the cost of building a vector constant despite not needin

Re: libgo patch committed: Always mark assembly file as non-executable stack

I Ian, > This libgo patch arranges for go-context.S to always be marked as > using a non-executable stack. This is not required for all targets, > but should do little harm. Bootstrapped on x86_64-pc-linux-gnu. > Committed to mainline. unfortunately, it does, breaking bootstrap on Solaris/SPARC

Re: [PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

On Fri, 6 Dec 2019, Richard Biener wrote: Although that will increase the code size. In case, we could still have both a nop_convert and a strip_nop predicates. Just thinking: We should measure it, yes, I hope it won't be too bad ;) In theory making genmatch emitted code more like a graph rat

Re: Ping Re: Fix libdecnumber handling of non-canonical BID significands (PR middle-end/91226)

Joseph Myers writes: > Ping. This patch > is pending > review. Like you say, it seems we no longer have a maintainer for this, and I wonder how many people other than you understand it well enough to do a meaningful technical review.

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

On Fri, 6 Dec 2019 at 11:47, Wilco Dijkstra wrote: > > Hi Christophe, > > > This patch (r278968) is causing regressions when building GCC > > --target arm-none-linux-gnueabihf > > --with-mode thumb > > --with-cpu cortex-a57 > > --with-fpu crypto-neon-fp-armv8 > > because the assembler (gas version

[committed][testsuite][aarch64] type_redef_11.c: Update expected diagnostics.

Hi, After the fix for PR c/36941 and PR c/88827 (r278976), this test emits a different error message and needs an update. I've committed this as r279039. Christophe 2019-12-06 Christophe Lyon PR c/36941 PR c/88827 * gcc.target/aarch64/sve/acle/general-c/type_redef_11

Re: [PATCH 09/49] gimple const-correctness fixes

On Sat, Nov 16, 2019 at 2:20 AM David Malcolm wrote: > > This patch converts various "gimple *" to "const gimple *" and similar > fixes for gimple subclasses, adding is_a_helper for gimple subclasses > to support the const form of as_a, and adding a few "const" overloads > of accessors. > > This i

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

Hi Christophe, > This patch (r278968) is causing regressions when building GCC > --target arm-none-linux-gnueabihf > --with-mode thumb > --with-cpu cortex-a57 > --with-fpu crypto-neon-fp-armv8 > because the assembler (gas version 2.33.1) complains: > /ccc7z5eW.s:4267: IT blocks containing more tha

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

On Tue, 3 Dec 2019 at 14:45, Wilco Dijkstra wrote: > > Hi, > > Part 2, split off from > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00399.html > > To enable cores to use the correct max_cond_insns setting, use the > core-specific > tuning when a CPU/tune is selected unless -mrestrict-it is exp

Re: [PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

On Fri, 6 Dec 2019, Richard Biener wrote: > On Fri, 6 Dec 2019, Marc Glisse wrote: > > > On Fri, 6 Dec 2019, Richard Biener wrote: > > > > >>> nop_convert sees that 'a' comes from a conversion, and only returns d > > >>> (unlike 'convert?' which would try both a and d). > > > > Maybe I should h

Re: [PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

On Fri, 6 Dec 2019, Marc Glisse wrote: > On Fri, 6 Dec 2019, Richard Biener wrote: > > >>> nop_convert sees that 'a' comes from a conversion, and only returns d > >>> (unlike 'convert?' which would try both a and d). > > Maybe I should have formulated it as: nop_convert works kind of like a > st

Re: [PATCH][AArch64] Enable CLI for Armv8.6-a: armv8.6-a, i8mm and bf16

Dennis Zhang writes: > 2019-12-04 Dennis Zhang > > * config/aarch64/aarch64-arches.def (armv8.6-a): New. > * config/aarch64/aarch64-c.c (aarch64_update_cpp_builtins): Define > __ARM_FEATURE_MATMUL_INT8, __ARM_FEATURE_BF16_VECTOR_ARITHMETIC and > __ARM_FEATURE_BF16_SCALAR

Fix @multitable handling in texi2pod.pl

While trying out Dennis's Armv8.6-A patch, I noticed that texi2pod.pl didn't handle the new @multitable correctly. There were two problems: (1) @multitables nested in other @tables inherited the @item type from the enclosing @table. Since the new @multitable is in a @table @samp, we appl

Re: [PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

On Fri, 6 Dec 2019, Richard Biener wrote: nop_convert sees that 'a' comes from a conversion, and only returns d (unlike 'convert?' which would try both a and d). Maybe I should have formulated it as: nop_convert works kind of like a strip_nops. If use gets more and more we can make nop_con

Re: Avoid quadratic behaviour in prune_runtime_alias_test_list

On Fri, Dec 6, 2019 at 9:36 AM Richard Sandiford wrote: > > prune_runtime_alias_test_list used ordered_remove to remove a merged > alias pair, which made the function quadratic when many aliases could > be removed. > > I had a testcase in which these memmoves accounted for an impressive > 85% of c

Re: [PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

On Fri, 6 Dec 2019, Richard Biener wrote: > On Thu, Dec 5, 2019 at 4:16 PM Richard Biener wrote: > > > > On December 5, 2019 2:03:24 PM GMT+01:00, Marc Glisse > > wrote: > > >On Wed, 4 Dec 2019, Jakub Jelinek wrote: > > > > > >> --- gcc/match.pd.jj 2019-12-03 10:20:00.244913801 +0100 > > >> ++

Re: [PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

On Thu, Dec 5, 2019 at 4:16 PM Richard Biener wrote: > > On December 5, 2019 2:03:24 PM GMT+01:00, Marc Glisse > wrote: > >On Wed, 4 Dec 2019, Jakub Jelinek wrote: > > > >> --- gcc/match.pd.jj 2019-12-03 10:20:00.244913801 +0100 > >> +++ gcc/match.pd 2019-12-03 13:36:01.084435697 +0100 > >>

Re: [RFC] Characters per line: from punch card (80) to line printer (132)

On 05/12/2019 18:21, Robin Curtis wrote: My IBM Selectric golfball electronic printer only does 90 characters on A4 in portrait mode………(at 10 cps) (as for my all electric TELEX Teleprinter machine !) Is this debate for real ?! - or is this a Christmas spoof ? I can't speak for the debate, b

Re: [PATCH] Fix up Fortran debug info for arrays with descriptors (PR fortran/92775)

@Paul: I have an ISO-C question for you. On 12/6/19 1:16 AM, Jakub Jelinek wrote: […] Unfortunately, I don't know Fortran enough to find out when exactly the compiler knows that descr->span will be always equal to element_size, Well, while gfc_expr is still available, that's gfc_get_array_spa

Avoid quadratic behaviour in prune_runtime_alias_test_list

prune_runtime_alias_test_list used ordered_remove to remove a merged alias pair, which made the function quadratic when many aliases could be removed. I had a testcase in which these memmoves accounted for an impressive 85% of compile time. The fact that we had so many probably shows a deeper pro

[PATCH] Improve *-match.c debugging

The following more closely re-emits C expressions by emitting line breaks whenever the source line location changes rather than only after ; This makes 'n' debugging easier. I've only briefly tried to reconstruct the original source but failed. I guess the pp tokens do not contain enough infor

*PING* – Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic

*Ping* Regarding Frederik's remark about the testsuite: I think the only test case in gfortran.dg/, which tests the column number, is use_without_only_1.f90. It has: { dg-warning "7:has no ONLY qualifier" } here, the "7" is the column number. — Hence, it is not surprising that changes do not