Re: [PATCH][RFC] Introduce BIT_FIELD_INSERT

On Mon, 16 Dec 2019, Andrew Pinski wrote: > On Thu, Nov 15, 2018 at 12:31 AM Richard Biener wrote: > > > > On Thu, 15 Nov 2018, Richard Biener wrote: > > > > > On Wed, 14 Nov 2018, Andrew Pinski wrote: > > > > > > > On Fri, May 13, 2016 at 3:51 AM Richard Biener > > > > wrote: > > > > > > > > >

Re: [testsuite][arm] Remove xfail for vect-epilogues test

On Fri, 13 Dec 2019, Andre Vieira (lists) wrote: > Consequently whilst looking at the list I noticed these two were missing. > > This OK for trunk? Yes. Thanks, Richard. > gcc/ChangeLog: > 2019-12-13 Andre Vieira > > * doc/sourcebuild.texi (arm_little_endian, arm_nothumb): >

[PATCH] Small ccp optimization for x * x (PR tree-optimization/93156)

Hi! In x * x = ((x & -2) + (x & 1))^2 = ((x^2) & -4) + 2 * (x & -2) * (x & 1) + (x & 1)^2 the first two terms are divisible by 4 and the last one is 0 or 1, so (x * x) % 4U <= 1 and thus bit ccp can assume he second least significant bit of any power of two is 0. Bootstrapped/regtested on x86_6

[committed] Fix UB in gfc_trans_omp_clauses (PR fortran/93162)

Hi! When I wrote the code, for map clause the arguments couldn't contain any REF_COMPONENT (nor REF_UNQUIRY nor REF_SUBSTRING) and therefore it was ok (although unclean) to just look at u.ar.type, but now that REF_COMPONENT can appear there (so far for OpenACC only, although OpenMP 5.0 also allows

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

On 2020/1/7 02:01, Jeff Law wrote: On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: Inline should return failure either (newsize > param_large_function_insns) OR (newsize > limit). Sometimes newsize is larger than param_large_function_insns, but smaller than limit, inline doesn't return f

Re: [PATCH, committed] V11 patch #5 of 15, Optimize vec_extract of a vector in memory with a PC-relative address

On Tue, Dec 24, 2019 at 10:24:55AM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Dec 20, 2019 at 06:55:53PM -0500, Michael Meissner wrote: > > * config/rs6000/rs6000.c (rs6000_reg_to_addr_mask): New helper > > function to identify the address mask of a hard register. > > Do this as a

Re: [PATCH, committed] V11 patch #4 of 15, Update 'Q' constraint documentation.

On Sun, Dec 22, 2019 at 11:49:19AM -0600, Segher Boessenkool wrote: > On Fri, Dec 20, 2019 at 06:49:30PM -0500, Michael Meissner wrote: > > In doing V11 patch #3, I noticed that the documentation for the 'Q' was > > misleading. > > It originally was used just for lswi/stswi, which can access up to

Re: [PATCH, committed] V11 patch #3 of 15, Use 'Q' constraint for variable vector extract from memory

On Sun, Dec 22, 2019 at 11:24:51AM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Dec 20, 2019 at 06:47:28PM -0500, Michael Meissner wrote: > > Then I realized that eventaully we will want to generate an X-FORM > > (register + > > register) address, and it was just simpler to use the 'Q' cons

Re: [PATCH, committed] V11 patch #2 of 15, Use prefixed load for vector extract with large offset

On Sun, Dec 22, 2019 at 11:10:09AM -0600, Segher Boessenkool wrote: > The patch is okay for trunk (with the comment moved, and the rtx_equal_p > fixed). Thanks! Here is the patch I committed (subversion id 279937): 2020-01-06 Michael Meissner * config/rs6000/rs6000.c (rs6000_adjust_v

Re: [PATCH] PR C++/92739

On 12/16/19 6:12 PM, Jason Merrill wrote: On 12/2/19 9:30 AM, Andrew Sutton wrote: Find attached.     gcc/cp/ * parser.c (cp_parser_constraint_requires_parens): Exclude attributes as postfix expressions. gcc/testsuite/ * g++.dg/concepts-pr92739.C: Ne

[C++ PATCH] PR c++/92552 - ICE with inherited constrained default ctor.

We set TYPE_HAS_USER_CONSTRUCTOR on the template type in lookup_using_decl, but we didn't copy it to the instantiation. Setting it in one_inherited_ctor is too late, as that gets called after we decide whether to set CLASSTYPE_LAZY_DEFAULT_CTOR. This change affects other testcases as well; the ch

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 07.01.2020 01:28, Jonathan Wakely wrote: > On 07/01/20 00:18 +0100, Kamil Rytarowski wrote: >> On 06.01.2020 16:34, Jonathan Wakely wrote: >>> On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: Hi Matthew, On Mon, 4 Feb 2019, Matthew Bauer wrote: > The ctype_base.h file in libstdc

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 07.01.2020 01:26, Jonathan Wakely wrote: > On 06/01/20 23:20 +0100, Kamil Rytarowski wrote: >> On 06.01.2020 16:24, Jonathan Wakely wrote: >>> On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: Hi Matthew, On Mon, 4 Feb 2019, Matthew Bauer wrote: > The ctype_base.h file in libstdc

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 07/01/20 00:18 +0100, Kamil Rytarowski wrote: On 06.01.2020 16:34, Jonathan Wakely wrote: On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: Hi Matthew, On Mon, 4 Feb 2019, Matthew Bauer wrote: The ctype_base.h file in libstdc++-v3 is out of date for NetBSD. They have changed their ctype.h def

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 06/01/20 23:20 +0100, Kamil Rytarowski wrote: On 06.01.2020 16:24, Jonathan Wakely wrote: On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: Hi Matthew, On Mon, 4 Feb 2019, Matthew Bauer wrote: The ctype_base.h file in libstdc++-v3 is out of date for NetBSD. They have changed their ctype.h def

Re: [committed] Fix comparison operator used for B and S integer comparisons on hppa

On 2020-01-01 4:11 p.m., John David Anglin wrote: > This fixes PR target/93111. The ICE > > The comparison_operator predicate is too broad and includes a couple of > comparisons > that aren't valid for integer comparisons on hppa. We need to use the > ordered_comparison_operator > predicate. >

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 06.01.2020 16:34, Jonathan Wakely wrote: > On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: >> Hi Matthew, >> >> On Mon, 4 Feb 2019, Matthew Bauer wrote: >>> The ctype_base.h file in libstdc++-v3 is out of date for NetBSD. They >>> have changed their ctype.h definition. It was updated in their int

Re: [C++ PATCH] Avoid caching constexpr calls that allocate something that they don't deallocate or vice versa (PR c++/91369)

On 1/5/20 8:04 AM, Jakub Jelinek wrote: Hi! The caching of constexpr calls breaks the following testcase. The problem is that constexpr calls that allocate from heap something that they don't deallocate or calls that deallocate something they haven't allocated aren't stateless for the constexpr

Re: [patch] relax aarch64 stack-clash tests depedence on alloca.h

On Mon, Jan 6, 2020 at 2:18 PM Olivier Hainque wrote: > > Hello, > > The aarch64 testsuite features a few tests for > the stack-clash-protection facility, all using "alloca" > after an #include . > > The use of alloca.h causes the tests to fail on > target systems not providing that header, such a

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 06.01.2020 16:24, Jonathan Wakely wrote: > On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: >> Hi Matthew, >> >> On Mon, 4 Feb 2019, Matthew Bauer wrote: >>> The ctype_base.h file in libstdc++-v3 is out of date for NetBSD. They >>> have changed their ctype.h definition. It was updated in their int

[patch] relax aarch64 stack-clash tests depedence on alloca.h

Hello, The aarch64 testsuite features a few tests for the stack-clash-protection facility, all using "alloca" after an #include . The use of alloca.h causes the tests to fail on target systems not providing that header, such as some variants of VxWorks. My understanding is that the tests really

Re: [PATCH] V11 patch #5 of 15, Optimize vec_extract of a vector in memory with a PC-relative address

On Tue, Dec 24, 2019 at 10:24:55AM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Dec 20, 2019 at 06:55:53PM -0500, Michael Meissner wrote: > > * config/rs6000/rs6000.c (rs6000_reg_to_addr_mask): New helper > > function to identify the address mask of a hard register. > > Do this as a

Re: [PATCH] V11 patch #5 of 15, Optimize vec_extract of a vector in memory with a PC-relative address

On Tue, Dec 24, 2019 at 10:24:55AM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Dec 20, 2019 at 06:55:53PM -0500, Michael Meissner wrote: > > * config/rs6000/rs6000.c (rs6000_reg_to_addr_mask): New helper > > function to identify the address mask of a hard register. > > Do this as a

Re: [C++ Patch] Improve build_new locations

On 1/2/20 4:23 AM, Paolo Carlini wrote: @@ -19320,8 +19320,8 @@ tsubst_copy_and_build (tree t, tree op1 = tsubst (TREE_OPERAND (t, 1), args, complain, in_decl); tree op2 = RECUR (TREE_OPERAND (t, 2)); - ret = build_new (&placement_vec, op1, op2, &init_vec, -

Re: [PATCH] Fix PowerPC -fstack-clash-protection -mprefixed-addr ICE (PR target/93122)

On Mon, Jan 06, 2020 at 11:03:02AM -0700, Jeff Law wrote: > On Mon, 2020-01-06 at 09:24 +0100, Jakub Jelinek wrote: > > Hi! > > > > As mentioned in the PR, the following testcase ICEs because rs, while valid > > add_operand is not valid add_cint_operand and so gen_add3_insn fails, > > because it d

Re: [PATCH] Document cloning for the target_clone attribute.

On Mon, 2020-01-06 at 11:05 +0100, Martin Liška wrote: > Hi. > > The patch is about explanation what happens when > a target_clone function calls a function without > the attribute. > > Ready for trunk? > Thanks, > Martin > > gcc/ChangeLog: > > 2020-01-06 Martin Liska > > PR ipa/83411

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

> > > OK > > Actually I am not so sure about this patch - how do we ensure > > reproducibility in this case? > ISTM that anyone trying to have reproducible builds shouldn't be using > PGO based optimizations. OpenSUSE does that. Builds are supposed to be reproducible + PGO is used for number of co

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

On Mon, 2020-01-06 at 19:23 +0100, Jan Hubicka wrote: > > On Mon, 2020-01-06 at 15:08 +0100, Martin Liška wrote: > > > Hi. > > > > > > As Honza noticed in the PR, we are quite strict about TOP N > > > counter invalidation due to multiple values that can't > > > fit in a counter. We due it in order

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

> On Mon, 2020-01-06 at 15:08 +0100, Martin Liška wrote: > > Hi. > > > > As Honza noticed in the PR, we are quite strict about TOP N > > counter invalidation due to multiple values that can't > > fit in a counter. We due it in order to have a reproducible > > builds. I guess we should do a comprom

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

On Mon, 2020-01-06 at 15:08 +0100, Martin Liška wrote: > Hi. > > As Honza noticed in the PR, we are quite strict about TOP N > counter invalidation due to multiple values that can't > fit in a counter. We due it in order to have a reproducible > builds. I guess we should do a compromise in between

Re: [PATCH] Fix PowerPC -fstack-clash-protection -mprefixed-addr ICE (PR target/93122)

On Mon, 2020-01-06 at 09:24 +0100, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, the following testcase ICEs because rs, while valid > add_operand is not valid add_cint_operand and so gen_add3_insn fails, > because it doesn't meet the expander predicates. > > Fixed thusly, bootstrapped/r

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: > Inline should return failure either (newsize > param_large_function_insns) > OR (newsize > limit). Sometimes newsize is larger than > param_large_function_insns, but smaller than limit, inline doesn't return > failure even if the new functio

Re: [patch][avr] PR92606: Disable -fipa-icf-variables because it generates wrong code.

Jeff Law schrieb: On Wed, 2019-12-18 at 16:30 +0100, Georg-Johann Lay wrote: Hi, this patch turns off -fipa-icf-variables because it generates wrong code like for PR92606. As there is no target hook that could decide whether such optimizations are obsolete, disable such optimizations alltoget

Re: [PATCH] Improve (x >> c) << c match.pd optimization (PR tree-optimization/93118)

On Fri, 2020-01-03 at 09:16 +0100, Jakub Jelinek wrote: > Hi! > > As can be seen in the testcase, for the (x >> c) << c optimization into > x & (-1< as the affected bits are shifted away. > Furthermore, while match.pd can handle > ((unsigned long long)(unsigned)(x >> 32))<<32 > for unsigned long l

Re: Add a generic lhd_simulate_enum_decl

On Thu, 2019-12-19 at 16:59 +, Richard Sandiford wrote: > Normally we only create SVE ACLE functions when arm_sve.h is included. > But for LTO we need to do it at start-up, so that the functions are > already defined when streaming in the LTO objects. > > One hitch with doing that is that LTO

Re: [patch][avr] New option -nodevicespecs to omit -specs=... in self specs.

On Wed, 2019-12-18 at 16:36 +0100, Georg-Johann Lay wrote: > Hi, currently device support in avr-gcc is accomplished by injecting a > specs file my means of -specs=... in dirver self specs. > > This patch adds a new avr driver option to omit the addition of > respective -specs option so give the

Re: Move -Wmaybe-uninitialized to -Wextra

On Mon, 2019-12-16 at 15:45 +0100, Martin Jambor wrote: > Hi Jeff, > > On Sat, Dec 07 2019, Jeff Law wrote: > > [...] > > The whole point behind the uninitialized warning is to capture cases > > where objects may not be properly initialized. For modern code the > > simple cases typically "just wo

[committed, amdgcn] Fix issue with '0' constraints

This patch fixes a wrong-code bug that can occur with subv64di3. The pattern uses '0' constraints to override the early-clobber modifier, meaning that the output can be in the same register as one of the inputs, whilst still disallowing overlapping pairs of registers (which are the real proble

Re: [patch,avr, 1/3] Support 64-bit (long) double: The gcc part.

On Mon, 2020-01-06 at 18:12 +0100, Georg-Johann Lay wrote: > Jeff Law schrieb: > > On Mon, 2019-12-16 at 17:43 +0100, Georg-Johann Lay wrote: > > > Am 16.12.19 um 17:40 schrieb Georg-Johann Lay: > > > Patch 1/3 is the GCC changes: Documentation and new avr-specific > > > configure options: > > > >

Re: [PATCH 1/1] Work around array out of bounds warning in mkdeps

On Tue, 2019-12-17 at 10:14 +0100, Andreas Krebbel wrote: > This suppresses an array out of bounds warning in mkdeps.c as proposed > by Martin Sebor in the bugzilla. > > array subscript 2 is outside array bounds of ‘const char [2]’ > > Since this warning does occur during bootstrap it currently b

Re: [patch,avr, 1/3] Support 64-bit (long) double: The gcc part.

Jeff Law schrieb: On Mon, 2019-12-16 at 17:43 +0100, Georg-Johann Lay wrote: Am 16.12.19 um 17:40 schrieb Georg-Johann Lay: Patch 1/3 is the GCC changes: Documentation and new avr-specific configure options: --with-libf7 selects to which level double support from libf7 is added to libgcc. --wi

Re: Fix tree-nrv.c ICE for direct internal functions

On Thu, 2019-12-12 at 15:13 +, Richard Sandiford wrote: > pass_return_slot::execute has: > > /* Ignore internal functions without direct optabs, >those are expanded specially and aggregate_value_p >on their result might result in undesirable warnings

Re: Fix libdecnumber handling of non-canonical BID significands (PR middle-end/91226)

On Fri, 2019-11-29 at 20:53 +, Joseph Myers wrote: > As reported in bug 91226, the libdecnumber code used on the host to > interpret DFP values in the BID encoding fails, for _Decimal64 and > _Decimal128, to check for the case where a significand is too large > and so specified in IEEE 754 to b

Re: [PATCH] Add Optimization keyword for TREE/RTL optimization passes.

On Fri, 2020-01-03 at 16:18 +0100, Martin Liška wrote: > Hello. > > The patch introduces Optimization keyword for various > parameters that influence an optimization that operates > on function level (TREE/RTL). I manually grepped for > each occurrence and verified that it's really used > within a

Re: [PATCH] Mark param_max_fields_for_field_sensitive with Optimization keyword.

On Fri, 2020-01-03 at 13:26 +0100, Martin Liška wrote: > Hi. > > One another fix where -Ox sets a parameter that > is not marked with Optimize keyword. Fixed by > adding the keyword. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, >

Re: [PATCH] Make warn_inline Optimization option.

On Thu, 2020-01-02 at 10:04 +0100, Martin Liška wrote: > Hi. > > The patch is about using Optimization for warn_inline as > it's affected by -O0. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > 2019

Re: Check mask argument's type when vectorising conditional functions

On Mon, 2019-12-23 at 14:44 +, Richard Sandiford wrote: > We can't yet vectorise conditional internal functions whose boolean > condition is fed by a data access (or more generally, by a tree of logic > ops in which all the leaves are data accesses). Although we should add > that eventually, w

Re: Require equal shift amounts for IFN_DIV_POW2

On Thu, 2019-12-19 at 15:22 +, Richard Sandiford wrote: > IFN_DIV_POW2 currently requires all elements to be shifted by the > same amount, in a similar way as for WIDEN_LSHIFT_EXPR. This patch > enforces that when building the SLP tree. > > If in future targets want to support IFN_DIV_POW2 wi

Re: [patch][avr] PR92606: Disable -fipa-icf-variables because it generates wrong code.

On Wed, 2019-12-18 at 16:30 +0100, Georg-Johann Lay wrote: > Hi, this patch turns off -fipa-icf-variables because it generates wrong > code like for PR92606. As there is no target hook that could decide > whether such optimizations are obsolete, disable such optimizations > alltogether until PR

Re: [patch,avr, 3/3] Support 64-bit (long) double: libf7.

On Mon, 2019-12-16 at 17:49 +0100, Georg-Johann Lay wrote: > Am 16.12.19 um 17:40 schrieb Georg-Johann Lay: > Patch 3/3 is the actual libf7 implementation. A great deal of which is > assembly, together with C + inline assembly for higher routines. > > Johann > > libgcc/config/avr/libf7/ >

Re: [patch,avr, 2/3] Support 64-bit (long) double: The libgcc changes.

On Mon, 2019-12-16 at 17:46 +0100, Georg-Johann Lay wrote: > Am 16.12.19 um 17:40 schrieb Georg-Johann Lay: > > Patch 2/3 is the libgcc additions: > > --with-libf7 selects which makefile-snips from libf7 to use. > > libgcc/ > * config.host (tmake_file) [target=avr]: Add t-libf7, > t-

Re: [wwwdocs] Document -fcommon default change

On 1/6/20 7:10 AM, Jonathan Wakely wrote: How about: GCC now defaults to -fno-common.  As a result, global variable accesses are more efficient on various targets.  In C, global variables with multiple tentative definitions will result in linker errors. This is better. I'd also s/will/now/,

Re: [patch,avr, 1/3] Support 64-bit (long) double: The gcc part.

On Mon, 2019-12-16 at 17:43 +0100, Georg-Johann Lay wrote: > Am 16.12.19 um 17:40 schrieb Georg-Johann Lay: > Patch 1/3 is the GCC changes: Documentation and new avr-specific > configure options: > > --with-libf7 selects to which level double support from libf7 is added > to libgcc. > > --with-do

Re: [PATCH] Mark param_max_combine_insns with Optimization keyword.

On Thu, 2020-01-02 at 12:07 +0100, Martin Liška wrote: > Hi. > > The param is changed here: > >/* Restrict the amount of work combine does at -Og while retaining > most of its useful transforms. */ >if (opts->x_optimize_debug) > SET_OPTION_IF_UNSET (opts, opts_set, param_max_c

Re: [PATCH] Mark param_min_crossjump_insns with Optimization keyword.

On Thu, 2020-01-02 at 12:06 +0100, Martin Liška wrote: > Hi. > > Again, the param is set based on optimize_size: > >if (opts->x_optimize_size) > /* We want to crossjump as much as possible. */ > SET_OPTION_IF_UNSET (opts, opts_set, param_min_crossjump_insns, 1); > > So that, the p

Re: [PATCH] Mark -free as Optimization option.

On Thu, 2020-01-02 at 12:04 +0100, Martin Liška wrote: > Hi. > > The flag is set based on optimization option: > gcc/common/config/i386/i386-common.c:{ OPT_LEVELS_2_PLUS, OPT_free, NULL, > 1 }, > > and so that it should be also per-function. The only usage of the flag is > in gate of a RTL p

Re: typo in 'patern'

On Thu, 2019-12-19 at 13:21 -0800, Bryan Stenson wrote: > x-post from here: https://marc.info/?t=15767864485&r=1&w=2 > > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c > index 6341216d1bc..e6d690b75c0 100644 > --- a/gcc/config/mips/mips.c > diff --git a/gcc/config/mips/mips.c b/g

[PING^3][PATCH v3] Add `--with-toolexeclibdir=' configuration option

On Mon, 2 Dec 2019, Maciej W. Rozycki wrote: > Provide means, in the form of a `--with-toolexeclibdir=' configuration > option, to override the default installation directory for target > libraries, otherwise known as $toolexeclibdir. This is so that it is > possible to get newly-built librari

[committed, amdgcn] Fix early-clobber in vec_extract

This patch fixes an execution test failure in gcc.dg/vect/vect-live-2.c. The problem was that the input and output registers were the same, which isn't safe for this pattern. It could be fixed by reversing the instructions, but then that would still be broken for overlapping input and output r

[PING^5][PATCH 0/4] Fix library testsuite compilation for build sysroot

On Fri, 20 Dec 2019, Mike Stump wrote: > >> This patch series addresses a problem with the testsuite compiler being > >> set up across libatomic, libffi, libgo, libgomp with no correlation > >> whatsoever to the target compiler being used in GCC compilation. > >> Consequently there in no arran

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: Hi Matthew, On Mon, 4 Feb 2019, Matthew Bauer wrote: The ctype_base.h file in libstdc++-v3 is out of date for NetBSD. They have changed their ctype.h definition. It was updated in their intree libstdc++-v3 but not in the GCC one. My understanding i

Re: [C++ PATCH] fix testcase

Hi Nathan, > Jason's recent patch > 2019-12-17 Jason Merrill > > PR c++/79592 - missing explanation of invalid constexpr. > > Caused ubsan/vptr-4.C to emit an additional, correct, > diagnostic. Committing this to update the testcase. this is PR testsuite/92991. Rainer -- -

[PING] Re: [Patch 0/X] HWASAN v3

Ping On 17/12/2019 14:11, Matthew Malcomson wrote: > I've noticed a few minor problems with this patch series after I sent it > out (mostly testcase stuff, one documentation tidy-up, but also that one > patch didn't bootstrap due to something fixed in a later patch). > > I also rely on a documen

Re: [PING^4][PATCH 0/4] Fix library testsuite compilation for build sysroot

Hi Julian, > FYI: This patch seems to be causing problems for our (internal -- as > you know!) test harness. I'm not sure if it's a local issue (or at least > something we can work around here), or a problem with the patch itself > though. I'm sorry to break your setup. I'm currently a little b

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

On 22/12/19 09:36 +1000, Gerald Pfeifer wrote: Hi Matthew, On Mon, 4 Feb 2019, Matthew Bauer wrote: The ctype_base.h file in libstdc++-v3 is out of date for NetBSD. They have changed their ctype.h definition. It was updated in their intree libstdc++-v3 but not in the GCC one. My understanding i

Re: [patch] Let libstdc++ know that VxWorks has_nanosleep

On 22/12/19 23:20 +0100, Olivier Hainque wrote: Hi Jonathan, On 19 Dec 2019, at 12:13, Jonathan Wakely wrote: Is there a way to detect that more reliably? Should we replicate the test used later in the file, to detect whether the timers are really enabled for VxWorks? AC_MSG_CHECKING([

[C++ PATCH] fix testcase

Jason's recent patch 2019-12-17 Jason Merrill PR c++/79592 - missing explanation of invalid constexpr. Caused ubsan/vptr-4.C to emit an additional, correct, diagnostic. Committing this to update the testcase. nathan -- Nathan Sidwell 2020-01-06 Nathan Sidwell PR c++/79592 * g

Re: [PATCH] libstdc++/92124 for associative containers

On 03/01/20 22:04 +0100, François Dumont wrote: This is the patch to extend PR 92124 to the associative containers. As it is pretty simple I thought it could maybe go in now. I also think that the existing 92124 tests are not really testing what they should with the move assignment operators n

Re: [PATCH] PR libstdc++/92124 on hashtable

On 07/11/19 20:28 +0100, François Dumont wrote: From what I understood from recent fix the unordered containers need to be updated the same way. I hope you'll appreciate the usage of rvalue forwarding. Containers node values are moved as soon as _M_assign is called with a rvalue reference to

Re: [PATCH] PR libstdc++/92124 on hashtable

On 07/11/19 20:28 +0100, François Dumont wrote: From what I understood from recent fix the unordered containers need to be updated the same way. I hope you'll appreciate the usage of rvalue forwarding. Containers Yes, I think it makes sense. node values are moved as soon as _M_assign is cal

Re: [wwwdocs] Document -fcommon default change

On 05/12/19 13:14 +, Wilco Dijkstra wrote: Hi, Add entries for the default change in changes.html and porting_to.html. Passes the W3 validator. Cheers, Wilco --- diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index e02966460450b7aad884b2d45190b9ecd8c7a5d8..304e1e8cc

[PATCH] Relax invalidation of TOP N counters in PGO.

Hi. As Honza noticed in the PR, we are quite strict about TOP N counter invalidation due to multiple values that can't fit in a counter. We due it in order to have a reproducible builds. I guess we should do a compromise in between reproducibility and possible speed up. That's why I'm suggesting

Re: [PATCH] Document cloning for the target_clone attribute.

On 1/6/20 3:05 AM, Martin Liška wrote: Hi. The patch is about explanation what happens when a target_clone function calls a function without the attribute. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2020-01-06  Martin Liska  PR ipa/83411 * doc/extend.texi: Explain cloning for

[Ping^2][patch,avr, 2/3] Support 64-bit (long) double: The libgcc changes.

Ping #2 Georg-Johann Lay schrieb: Am 16.12.19 um 17:40 schrieb Georg-Johann Lay: Patch 2/3 is the libgcc additions: --with-libf7 selects which makefile-snips from libf7 to use. libgcc/ * config.host (tmake_file) [target=avr]: Add t-libf7, t-libf7-math, t-libf7-math-symbols as specifie

[Ping^2][patch,avr, 0/3] Support 64-bit (long) double.

Ping #2 Georg-Johann Lay schrieb: Now that the avr backend can support 64-bit floats by means of configure-options --with-double= and --with-long-double=, this patch series adds some routines to support it. It's an ad-hoc, avr-specific implementation in assembly and GNU-C which is added as a

[Ping^2][patch,avr, 1/3] Support 64-bit (long) double: The gcc part.

Ping #2 Georg-Johann Lay schrieb: Am 16.12.19 um 17:40 schrieb Georg-Johann Lay: Patch 1/3 is the GCC changes: Documentation and new avr-specific configure options: --with-libf7 selects to which level double support from libf7 is added to libgcc. --with-double-comparison select what FLOAT_LIB_

[committed][AArch64] Use move-if-change for aarch64-tune.md

If aarch64-tune.md was older than gentune.sh or aarch64-cores.def, we'd try to overwrite it even if the current contents were correct. This could cause problems with read-only source directories and could cause spurious copying for rsync --archive. Tested on aarch64-linux-gnu. Also tested by chan

[AArch64] Fix constraints for CPY /M

The constraints for CPY /M allowed p0-p15 instead of the intended p0-p7. This looks like a pasto from the preceding constant pattern, where p0-p15 is allowed. Tested on aarch64-linux-gnu and applied as 279899. Richard 2020-01-06 Richard Sandiford gcc/ * config/aarch64/aarch64-sve.md

[PING^2][patch][avr] PR92606: Disable -fipa-icf-variables because it generates wrong code.

Ping #2. Hi, this patch turns off -fipa-icf-variables because it generates wrong code like for PR92606. As there is no target hook that could decide whether such optimizations are obsolete, disable such optimizations alltogether until PR92932 (target hook to disable such optimizations depend

[PING^2][patch][avr] New option -nodevicespecs to omit -specs=... in self specs.

Ping #2 Hi, currently device support in avr-gcc is accomplished by injecting a specs file my means of -specs=... in dirver self specs. This patch adds a new avr driver option to omit the addition of respective -specs option so give the user more freedom. Ok to apply? Johann * config/a

[committed, amdgcn] Fix inline immediate range

Inline immediates for AMD GCN instructions are supposed to be in the range -16..64 inclusive, but the implementation had the upper bound exclusive. This patch fixes the error. Andrew Fix amdgcn inline immediate range 2020-01-06 Andrew Stubbs gcc/ * config/gcn/gcn.c (gcn_inline_constant_

[PATCH] libstdc++: Remove redundant inequality operators in

* include/std/stop_token (stop_token): Remove operator!= (LWG 3254). (stop_source): Likewise (LWG 3362). * testsuite/30_threads/stop_token/stop_source.cc: Test equality comparisons. Tested powerpc64le-linux, committed to trunk. commit 55ac97433857c19cd9ecf3fbf6e35

Re: [PATCH] libstdc++: Define std::lexicographical_compare_three_way for C++20

On 03/01/20 15:03 +, Jonathan Wakely wrote: On 03/01/20 14:54 +, Jonathan Wakely wrote: On 29/12/19 12:07 +0100, Stephan Bergmann wrote: FYI, the above fails with -std=c++2a and recent Clang trunk after

Re: [PATCH] Make cgraph_edge::resolve_speculation static

> Hi, > > throughout this year a few of us got burnt by the fact that > cgraph_edge::resolve_speculation method sometimes removed and > deallocated its this pointer, sometimes making the this pointer of a few > other methods of the class also suddenly invalid. > > We postponed dealing with the is

Re: [PATCH] Make cgraph_edge::resolve_speculation static

On 1/4/20 7:23 PM, Martin Jambor wrote: Hi, throughout this year a few of us got burnt by the fact that cgraph_edge::resolve_speculation method sometimes removed and deallocated its this pointer, sometimes making the this pointer of a few other methods of the class also suddenly invalid. Hello

[PATCH] Document cloning for the target_clone attribute.

Hi. The patch is about explanation what happens when a target_clone function calls a function without the attribute. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2020-01-06 Martin Liska PR ipa/83411 * doc/extend.texi: Explain cloning for target_clone attribute. --

Re: [PATCH] Add changes that I made in GCC 10 development cycle.

On 11/29/19 3:34 PM, Martin Liška wrote: Hello. I'm sending entries for changes.html file for GCC 10. Martin ---  htdocs/gcc-10/changes.html | 38 ++  1 file changed, 38 insertions(+) I've just installed the changes update. Feel free to provide language

Re: [PATCH] Mark param_max_combine_insns with Optimization keyword.

On 1/3/20 5:12 PM, Segher Boessenkool wrote: Hi! On Thu, Jan 02, 2020 at 12:07:27PM +0100, Martin Liška wrote: The param is changed here: /* Restrict the amount of work combine does at -Og while retaining most of its useful transforms. */ if (opts->x_optimize_debug) SET_OPTIO

[RFC/PATCH] IVOPTs select cand with preferred D-form access

Hi all, Recently I'm investigating on an issue related to use D-form/X-form vector memory access, it's the same as what the patch https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01879.html was intended to deal with. Power9 introduces DQ-form instructions for vector memory access, we perfer to use

[PATCH] Fix PowerPC -fstack-clash-protection -mprefixed-addr ICE (PR target/93122)

Hi! As mentioned in the PR, the following testcase ICEs because rs, while valid add_operand is not valid add_cint_operand and so gen_add3_insn fails, because it doesn't meet the expander predicates. Fixed thusly, bootstrapped/regtested on powerpc64{,le}-linux, ok for trunk? Another option would