Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-24 Thread Hongtao Liu via Gcc-patches
On Mon, May 25, 2020 at 1:55 AM Uros Bizjak wrote: > > On Sun, May 24, 2020 at 9:26 AM Hongtao Liu wrote: > > > > On Sat, May 23, 2020 at 6:11 PM Uros Bizjak wrote: > > > > > > On Sat, May 23, 2020 at 9:25 AM Hongtao Liu wrote: > > > > > > > > Hi: > > > > This patch fix non-conforming

RE: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-05-24 Thread Yangfei (Felix)
Hi, > -Original Message- > From: Segher Boessenkool [mailto:seg...@kernel.crashing.org] > Sent: Saturday, May 23, 2020 10:57 PM > To: Yangfei (Felix) > Cc: gcc-patches@gcc.gnu.org; Zhanghaijian (A) > Subject: Re: [PATCH PR94026] combine missed opportunity to simplify > comparisons with

Re: [PATCH] Adjust wait logic to limit spurious evalution of wait predicate.

2020-05-24 Thread Thomas Rodgers
And this time, with patch. wake_up_fix.patch Description: Binary data > On May 24, 2020, at 3:06 PM, Thomas Rodgers wrote: > > * include/bits/atomic_wait.h (__waiters::_M_do_wait): adjust wakeup > logic.

[PATCH] Remove binary_semaphore implementation from stop_token

2020-05-24 Thread Thomas Rodgers
* include/std/stop_token: Remove local binary_semaphore implementation. (_Stop_state_t::_M_do_try_lock): Use __thread_yield() from bits/atomic_wait.h. 0001-Remove-binary_semaphore-implementation-from-stop_tok.patch Description: Binary data

[PATCH] Adjust wait logic to limit spurious evalution of wait predicate.

2020-05-24 Thread Thomas Rodgers
* include/bits/atomic_wait.h (__waiters::_M_do_wait): adjust wakeup logic.

Re: [PATCH] contrib/gen_autofdo_event.py: Allow for it to work if there are more than 3 hyphens in Family-model

2020-05-24 Thread Andi Kleen via Gcc-patches
Javad Karabi via Gcc-patches writes: > > diff --git a/contrib/gen_autofdo_event.py b/contrib/gen_autofdo_event.py > index c97460c61c6..cd77a8686d9 100755 > --- a/contrib/gen_autofdo_event.py > +++ b/contrib/gen_autofdo_event.py > @@ -94,7 +94,7 @@ for j in u: > n = j.rstrip().split(',') >

[PATCH] diagnostics: Add function call parens matching to c_parser.

2020-05-24 Thread Mark Wielaard
The C++ parser already tracks function call parens matching, but the C parser doesn't. This adds the same functionality to the C parser and adds a testcase showing the C++ and C parser matching function call parens in an error message. gcc/c/ChangeLog: * c-parser.c

Re: [PATCH] Add support for C++20 barriers

2020-05-24 Thread Thomas Rodgers
> On May 24, 2020, at 11:11 AM, Jonathan Wakely wrote: > > On Sun, 24 May 2020 at 18:55, Florian Weimer wrote: >> >> * Thomas Rodgers: >> >>> + static __gthread_t >>> + _S_get_tid() noexcept >>> + { >>> +#ifdef __GLIBC__ >>> + // For the GNU C library pthread_self() is

Re: [PATCH] Port libgccjit to Windows.

2020-05-24 Thread David Malcolm via Gcc-patches
On Sun, 2020-05-24 at 17:02 -0300, Nicolas Bértolo via Gcc-patches wrote: > Hello gcc devs. Hi Nicolas. > I have ported libgccjit to Windows. I have tested it with the > native-compilation branch of Emacs so I'm confident that it works well. Excellent - thanks for doing this work. Do you have

[RFC PATCH] i386: Remove broadcasts from TARGET_MMX_WITH_SSE vec_dup insn patterns

2020-05-24 Thread Uros Bizjak via Gcc-patches
XMM broadcast instructions broadcast value from general reg to all elements of the vector. This is not allowed for TARGET_MMX_WITH_SSE, where it is expected that bits outside lower 64bits load or retain zero value. Following testcases expect broadcast, and are thus invalid: FAIL:

[PATCH] Port libgccjit to Windows.

2020-05-24 Thread Nicolas Bértolo via Gcc-patches
Hello gcc devs. I have ported libgccjit to Windows. I have tested it with the native-compilation branch of Emacs so I'm confident that it works well. The work is not finished though, I could use some help with these two points: I have had to concede defeat to libtool and Automake. I could not

PR libfortran/95195 - improve runtime error for namelist i/o to unformatted file

2020-05-24 Thread Harald Anlauf
Without the patch below, an attempted namelist write to an unformatted file - which is prohibited by the standard - would generate the following runtime error: At line 12 of file pr95195.f90 (unit = 10, file = 'test.dat') Fortran runtime error: End of record followed by some backtrace. The

Re: [Patch] PR fortran/95106 - truncation of long symbol names with EQUIVALENCE

2020-05-24 Thread Thomas Koenig via Gcc-patches
Hi Harald, OK for master? The patch is OK. Regarding the test case - I think it should be OK. If not, expect to hear from people soon, you could then still restrict it to Linux (or something else along those lines). Regards Thomas

[patch, fortran] Fix memory leaks for finalized types

2020-05-24 Thread Thomas Koenig via Gcc-patches
Hello world, this patch fixes a 8/9/10/11 regression, where finalized types were not finalized (and deallocated), which led to memory leaks. Once the offending commit was identified (thanks, Harald!) error analysis was rather straightforward. The central idea was that it is the expression that

Re: [PATCH] Add support for C++20 barriers

2020-05-24 Thread Florian Weimer
* Jonathan Wakely: > On Sun, 24 May 2020 at 18:55, Florian Weimer wrote: >> >> * Thomas Rodgers: >> >> > + static __gthread_t >> > + _S_get_tid() noexcept >> > + { >> > +#ifdef __GLIBC__ >> > + // For the GNU C library pthread_self() is usable without linking to >> > + //

Re: [PATCH] Add support for C++20 barriers

2020-05-24 Thread Jonathan Wakely via Gcc-patches
On Sun, 24 May 2020 at 18:55, Florian Weimer wrote: > > * Thomas Rodgers: > > > + static __gthread_t > > + _S_get_tid() noexcept > > + { > > +#ifdef __GLIBC__ > > + // For the GNU C library pthread_self() is usable without linking to > > + // libpthread.so but returns 0, so

Re: [PATCH] Add missing expander for vector float_extend and float_truncate [PR target/95125]

2020-05-24 Thread Uros Bizjak via Gcc-patches
On Sun, May 24, 2020 at 9:20 AM Hongtao Liu wrote: > > Bootstrap is ok, regression test on i386/x86-64 backend is ok. > > gcc/ChangeLog > PR target/95125 > * config/i386/sse.md (sf2dfmode_lower): New mode attribute. > (trunc2) New expander. > (extend2): Ditto. >

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-24 Thread Uros Bizjak via Gcc-patches
On Sun, May 24, 2020 at 9:26 AM Hongtao Liu wrote: > > On Sat, May 23, 2020 at 6:11 PM Uros Bizjak wrote: > > > > On Sat, May 23, 2020 at 9:25 AM Hongtao Liu wrote: > > > > > > Hi: > > > This patch fix non-conforming expander for > > >

Re: [PATCH] Add support for C++20 barriers

2020-05-24 Thread Florian Weimer
* Thomas Rodgers: > + static __gthread_t > + _S_get_tid() noexcept > + { > +#ifdef __GLIBC__ > + // For the GNU C library pthread_self() is usable without linking to > + // libpthread.so but returns 0, so we cannot use it in single-threaded > + // programs, because

Re: [PATCH] Add support for C++20 barriers

2020-05-24 Thread Thomas Rodgers
This time with 100% more patch… 0001-Add-support-for-C-20-barriers_f.patch Description: Binary data > On May 23, 2020, at 3:58 PM, Thomas Rodgers wrote: > > This patch requires the patch for atomic::wait/notify to be applied first. > > This implementation is based on the libc++

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-24 Thread Segher Boessenkool
Hi! On Sun, May 24, 2020 at 07:03:13PM +0530, Kamlesh Kumar wrote: > In this patch series trying to address same by creating a struct Tuple > which bundles existing rtx and machine_mode and added one more > bool member which store unsigned_p which by default is false. The idea is good. However,

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-24 Thread François Dumont via Gcc-patches
Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque iterator as the output so that it is transform into an output to pointer. Ok to commit ? François On 23/05/20 6:37 pm, Jonathan Wakely wrote:

[PATCH v1 1/2][PPC64] [PR88877]

2020-05-24 Thread Kamlesh Kumar via Gcc-patches
Here is a discussion we did some time ago regarding the defect. https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877 for testcase behavior. We incorporating below Jakub's suggestion in this patch series. Jakub wrote: "" Yeah,

[pushed] Darwin: Make sanitizer local vars linker-visible.

2020-05-24 Thread Iain Sandoe
Hi Another case where we need a linker-visible symbols in order to preserve the ld64 atom model. If these symbols are emitted as 'local' the linker cannot see that they are separate from any global weak entry that precedes them. This will cause the linker to complain that there is (apparently)

Re: [PATCH] x86: Handle -mavx512vpopcntdq for -march=native

2020-05-24 Thread Uros Bizjak via Gcc-patches
On Sat, May 23, 2020 at 5:07 PM H.J. Lu wrote: > > On Fri, May 22, 2020 at 12:42 AM Uros Bizjak wrote: > > > > On Thu, May 21, 2020 at 2:54 PM H.J. Lu wrote: > > > > > > Add -mavx512vpopcntdq for -march=native if AVX512VPOPCNTDQ is available. > > > > > > PR target/95258 > > > *

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-24 Thread Hongtao Liu via Gcc-patches
On Sat, May 23, 2020 at 6:11 PM Uros Bizjak wrote: > > On Sat, May 23, 2020 at 9:25 AM Hongtao Liu wrote: > > > > Hi: > > This patch fix non-conforming expander for > > floatv2div2sf2,floatunsv2div2sf2,fix_truncv2sfv2di,fixuns_truncv2sfv2di, > > refer to PR95211, PR95256. > > bootstrap ok,

[PATCH] Add missing expander for vector float_extend and float_truncate [PR target/95125]

2020-05-24 Thread Hongtao Liu via Gcc-patches
Bootstrap is ok, regression test on i386/x86-64 backend is ok. gcc/ChangeLog PR target/95125 * config/i386/sse.md (sf2dfmode_lower): New mode attribute. (trunc2) New expander. (extend2): Ditto. gcc/testsuite/ChangeLog * gcc.target/i386/pr95125-avx.c: New