Re: [PATCH] PR94397 the compiler consider "type is( real(kind(1.)) )" as a syntax error

2020-05-26 Thread Mark Eggleston
ping On 13/05/2020 18:19, Mark Eggleston wrote: Please find attached a patch for PR94397. Commit message: Fortran  : "type is( real(kind(1.)) )" spurious syntax error PR94397 Based on a patch in the comments of the PR. That patch fixed this problem but caused the test cases for PR93484 to fai

Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392

2020-05-26 Thread Mark Eggleston
ping On 19/05/2020 08:49, Mark Eggleston wrote: Please find attached patch for PR50392. This patch was extracted from the comments in the PR and was written back in 2011! I have verified that it fixes the PR on master, gcc-8, gcc-9 and gcc-10. Commit message: Fortran  : ICE in gfc_trans_la

Re: [PATCH] Fix nonconforming memory_operand for vpmov instructions which has memory operand narrow than 128 bits [avx512f]

2020-05-26 Thread Hongtao Liu via Gcc-patches
On Mon, May 25, 2020 at 8:41 PM Uros Bizjak wrote: > > On Mon, May 25, 2020 at 2:21 PM Hongtao Liu wrote: > > > > According to Intel SDM, VPMOVQB xmm1/m16 {k1}{z}, xmm2 has 16-bit > > memory_operand instead of 128-bit one which exists in current > > implementation. Also for other vpmov instruct

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-26 Thread Jiufu Guo via Gcc-patches
Segher Boessenkool writes: > Hi! > > On Tue, May 26, 2020 at 08:58:13AM +0200, Richard Biener wrote: >> On Mon, May 25, 2020 at 7:44 PM Segher Boessenkool >> wrote: >> > Yes, cunroll does not have its own option, and that is a problem. But >> > that is easy to fix! Either with an option, or ju

[committed] Fix pr20601-1.c on the H8

2020-05-26 Thread Jeff Law via Gcc-patches
This is a codegen fix for the H8 that I debugged while working on the cc0 conversion. In simplest terms we're accepting things like (const_int 0) as the source of a zero_extract and it ultimately interacts badly with register reloading. One might argue this is combine's fault for not simplifying

[PATCH] extend cselim to check non-trapping for more references (PR tree-optimizaton/89430)

2020-05-26 Thread Hao Liu OS via Gcc-patches
Hi all, Previously, the fix for PR89430 was reverted by PR94734 due to a bug. The root cause is missing non-trapping check with dominating LOAD/STORE. This patch extends the cselim non-tra

RE: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-05-26 Thread Yangfei (Felix)
Hi, > -Original Message- > From: Segher Boessenkool [mailto:seg...@kernel.crashing.org] > Sent: Tuesday, May 26, 2020 11:32 PM > To: Yangfei (Felix) > Cc: gcc-patches@gcc.gnu.org; Zhanghaijian (A) > Subject: Re: [PATCH PR94026] combine missed opportunity to simplify > comparisons with ze

[PATCH PR95332] gcov-tool: Flexible endian adjustment for merging coverage data

2020-05-26 Thread dongjianqiang (A)
Hi GCC maintainers, Proposed patch to PR95332 - gcov-tool merge:"not a gcov data file" This error occurs when using gcov-tool merge dir1 dir2 where dir1 and dir2 are the directories containing the .gcda files which were generated by different endian machine, Any suggestions? Thanks. Regards,

Broken build (was: Re: drop -aux{dir,base}, revamp -dump{dir,base})

2020-05-26 Thread Hans-Peter Nilsson via Gcc-patches
> From: Alexandre Oliva > Date: Tue, 26 May 2020 15:52:57 +0200 > On May 26, 2020, Richard Biener wrote: > > > xgcc: error: unrecognized command-line option '-dumpbase'^M > > > xg++: error: unrecognized command-line option '-dA'; did you mean '-A' > > Here's a proper patch submission. And he

[PATCH] c++: Fix bogus -Wparentheses warning [PR95344]

2020-05-26 Thread Marek Polacek via Gcc-patches
Since r267272, which added location wrappers, cp_fold loses TREE_NO_WARNING on a MODIFY_EXPR that finish_parenthesized_expr set, and that results in a bogus -Wparentheses warning. I.e., previously we had "b = 1" but now we have "VIEW_CONVERT_EXPR(b) = 1" and cp_fold_maybe_rvalue folds away the loc

Re: [PATCH 0/7] Support vector load/store with length

2020-05-26 Thread Segher Boessenkool
Hi! On Tue, May 26, 2020 at 01:29:30PM +0100, Richard Sandiford wrote: > FWIW, I agree adding .LEN_LOAD and .LEN_STORE seems like a good > approach. I think it'll be more maintainable in the long run than > trying to have .MASK_LOADs and .MASK_STOREs that need a special mask > operand. (That wou

Re: [PATCH v2] Fix use of singleton in optinfo framework

2020-05-26 Thread Gerald Pfeifer
Okay to backport c00568f376078129196740d83946d54dc5437401 to the GCC 9 branch, Jakub? Thanks, Gerald On Tue, 7 Apr 2020, Gustavo Romero via Gcc-patches wrote: > Currently an use of get() method of dump_context singleton in optinfo > framework causes a new class to be instantiated and when its dt

Re: [PATCH 0/7] Support vector load/store with length

2020-05-26 Thread Jim Wilson
On Tue, May 26, 2020 at 12:12 AM Richard Biener wrote: > From a look at the series description below you seem to add a new way > of doing loads for this. Did you review other ISAs (those I'm not > familiar with myself too much are SVE, RISC-V and GCN) in GCC whether > they have similar support an

[committed] jit: fix missing types for builtins [PR 95306]

2020-05-26 Thread David Malcolm via Gcc-patches
PR jit/95306 reports that attempts to use builtins __builtin_sadd_overflow" and "__builtin_memcpy" via gcc_jit_context_get_builtin_function lead to inscrutable error messages of the form: unimplemented primitive type for builtin: 42 and: unimplemented primitive type for builtin: 38 The root ca

[PATCH, committed] [9/10/11 Regression] PR fortran/95104 - Segfault on a legal WAIT statement

2020-05-26 Thread Harald Anlauf
Committed as obvious. The invalid NULL pointer dereference was discovered by Steve Kargl. Will backport in a few days, when I figure out how to do it now. Thanks, Harald PR fortran/95104 - Segfault on a legal WAIT statement Referencing a unit in a WAIT statement that has not been opened befor

[PATCH] PR fortran/95090 - ICE: identifier overflow

2020-05-26 Thread Harald Anlauf
Yet another obvious case of insufficient size of a temporary buffer. OK for master? Thanks, Harald PR fortran/95090 - ICE: identifier overflow For long module name, derive type and component name, the generated name-mangled symbol did not fit into a buffer when coarrays were enabled. Provide

Re: [PATCH] libstdc++: Fix common_iterator::operator-> [PR95322]

2020-05-26 Thread Jonathan Wakely via Gcc-patches
On 26/05/20 15:18 -0400, Patrick Palka via Libstdc++ wrote: This patch fixes the definition of common_iterator::operator-> when the underlying iterator type's operator* returns a non-reference. The first problem is that the class __detail::_Common_iter_proxy is used unqualified. Fixing that rev

[Patch, fortran] PR fortran/95331 - Unlimited polymorphic arrays have wrong bounds

2020-05-26 Thread José Rui Faustino de Sousa via Gcc-patches
Hi all! Proposed patch to PR95331 - Unlimited polymorphic arrays have wrong bounds. Patch tested only on x86_64-pc-linux-gnu. When iterating over a class array use the bounds provided by the transformed descriptor (in sym->backend_decl) instead of the original bounds of the array (in the desc

[PATCH] libstdc++: Fix common_iterator::operator-> [PR95322]

2020-05-26 Thread Patrick Palka via Gcc-patches
This patch fixes the definition of common_iterator::operator-> when the underlying iterator type's operator* returns a non-reference. The first problem is that the class __detail::_Common_iter_proxy is used unqualified. Fixing that revealed another problem: the class's template friend declaration

Re: [PATCH] Add debug (slp_tree) and dump infrastructure for this

2020-05-26 Thread David Malcolm via Gcc-patches
On Mon, 2020-05-25 at 16:56 +0200, Richard Biener wrote: > This adds an alternate debug_dump_context similar to the one for > selftests but for interactive debugging routines. This allows > to share code between user-visible dumping via the dump_* API > and those debugging routines. The primary d

[PATCH] gcc: xtensa: delegitimize UNSPEC_PLT

2020-05-26 Thread Max Filippov via Gcc-patches
This fixes 'non-delegitimized UNSPEC 3 found in variable location' notes issued when building libraries which interferes with running tests. 2020-05-24 Max Filippov gcc/ * config/xtensa/xtensa.c (xtensa_delegitimize_address): New function. (TARGET_DELEGITIMIZE_ADDRESS):

Re: [PATCH] Port libgccjit to Windows.

2020-05-26 Thread David Malcolm via Gcc-patches
On Mon, 2020-05-25 at 16:48 -0300, Nicolas Bértolo wrote: > Hi Dave, > > Thanks for your feedback. > > > Do you have copyright assignment paperwork on file? > > https://gcc.gnu.org/contribute.html#legal > > My paperwork is done. Thanks. Do you have commit/push access to the gcc repository? >

Re: New mklog script

2020-05-26 Thread Jason Merrill via Gcc-patches
On Tue, May 26, 2020 at 11:38 AM Martin Sebor wrote: > On 5/26/20 7:14 AM, Martin Liška wrote: > > On 5/26/20 3:11 PM, Richard Earnshaw wrote: > >> On 26/05/2020 14:09, Martin Liška wrote: > >>> On 5/26/20 1:18 PM, Richard Earnshaw wrote: > On 26/05/2020 12:14, Martin Liška wrote: > > On

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-26 Thread Jason Merrill via Gcc-patches
On 5/26/20 3:12 AM, Martin Liška wrote: Hi. There's a small improvement. When filling up the ChangeLog entries, I see it handy to open a patch in a separate window. I would use GCC_DIFF_FILE env. variable for saving of the diff file. It seems easy enough to execute the command yourself in anot

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-26 Thread Segher Boessenkool
Hi! On Tue, May 26, 2020 at 08:58:13AM +0200, Richard Biener wrote: > On Mon, May 25, 2020 at 7:44 PM Segher Boessenkool > wrote: > > Yes, cunroll does not have its own option, and that is a problem. But > > that is easy to fix! Either with an option, or just with params (the > > option wouldn'

Re: [PATCH] RS6000, add VSX mask manipulation support

2020-05-26 Thread will schmidt via Gcc-patches
On Fri, 2020-05-22 at 13:27 -0700, Carl Love wrote: > GCC maintainers: > > The following patch adds support for builtins > vec_genbm(), vec_genhm(), > vec_genwm(), vec_gendm(), vec_genqm(), vec_cntm(), vec_expandm(), > vec_extractm(). Support for instructions mtvsrbm, mtvsrhm, mtvsrwm, > mtvsrdm

[committed] i386: Add SSE2 alternative to mmx_pswapd2vsi2

2020-05-26 Thread Uros Bizjak via Gcc-patches
2020-05-26 Uroš Bizjak gcc/ChangeLog: * config/i386/mmx.md (mmx_pswapdv2si2): Add SSE2 alternative. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Uros. diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md index c31b4f81079..215162dedb5 100644 --- a/gcc/config/i38

Re: PR libfortran/95195 - improve runtime error for namelist i/o to unformatted file

2020-05-26 Thread Thomas Koenig via Gcc-patches
Hello Harald, Without the patch below, an attempted namelist write to an unformatted file - which is prohibited by the standard - would generate the following runtime error: At line 12 of file pr95195.f90 (unit = 10, file = 'test.dat') Fortran runtime error: End of record followed by some bac

Re: [PATCH] PR fortran/95089 - ICE in gfc_get_derived_type, at fortran/trans-types.c:2843

2020-05-26 Thread Thomas Koenig via Gcc-patches
Hi Harald, Another rather obvious case of a buffer too small to hold a name-mangled symbol, this time with coarrays enabled. OK for master? OK. Thanks!

[PATCH] RS6000 Add testlsbb (Test LSB by Byte) operations

2020-05-26 Thread will schmidt via Gcc-patches
Hi, Add support for new instructions to test LSB by Byte. Tested on powerpc64le-unknown-linux-gnu with no regressions. (power7BE, power8LE, power8BE, power9LE). [gcc] 2020-05-26 Will Schmidt * config/rs6000/altivec.h (vec_test_lsbb_all_ones): New define. (vec_test_lsbb_all_ze

Re: [LTO/offloading] Fix offloading-compilation ICE without -flto (PR84320)

2020-05-26 Thread Richard Biener
On May 26, 2020 3:55:01 PM GMT+02:00, Tobias Burnus wrote: >LTO stream out not only happens with LTO (-flto) but also for >the offloaded functions with OpenMP/OpenACC. > >Without using -flto, this leads to an ICE as a recent patch >(r11-525-g03d90a20a1afcbb9c30da8d4adf4922b0685061f) added the >ch

Re: [PATCH PR95254] aarch64: gcc generate inefficient code with fixed sve vector length

2020-05-26 Thread Richard Sandiford
Sorry for the slow reply, was off for a few days. I think the new code ought to happen earlier in emit_move_insn, before: if (CONSTANT_P (y)) { That way, all the canonicalisation happens on the mode we actually want the move to have. "Yangfei (Felix)" writes: > diff --git a/gcc/expr.c b/

Re: [PATCH 2/2] gcc-changelog: handle entries with multi-line file lists

2020-05-26 Thread Pierre-Marie de Rodat
On 26/05/2020 17:06, Martin Liška wrote: That was simpler than I expected ;) I compared results for all 2000 patches since we switched to git and there are no changes! Ah, nice! Thank you for double-checking: I only ran the unit tests on my side. +diff --git a/gcc/ada/contracts.adb b/gcc/a

Re: [PATCH 1/2] gcc-changelog: remove file descriptor leaks

2020-05-26 Thread Pierre-Marie de Rodat
On 26/05/2020 17:04, Martin Liška wrote: Oh, that's new for me. I've never seen the warning. Please install the patch. That was the first time I saw it as well. :-) I just pushed the commit on master. -- Pierre-Marie de Rodat

Re: [Patch][OpenMP] Fix mapping of artificial variables (PR94874)

2020-05-26 Thread Jakub Jelinek via Gcc-patches
On Tue, May 26, 2020 at 04:06:04PM +0200, Jakub Jelinek wrote: > On Mon, May 25, 2020 at 07:10:31PM +0200, Tobias Burnus wrote: > > +enum omp_clause_defaultmap_kind > > +cxx_omp_predetermined_mapping (tree decl) > > +{ > > + enum omp_clause_default_kind ret = cxx_omp_predetermined_sharing_1 > > (

Re: New mklog script

2020-05-26 Thread Martin Sebor via Gcc-patches
On 5/26/20 7:14 AM, Martin Liška wrote: On 5/26/20 3:11 PM, Richard Earnshaw wrote: On 26/05/2020 14:09, Martin Liška wrote: On 5/26/20 1:18 PM, Richard Earnshaw wrote: On 26/05/2020 12:14, Martin Liška wrote: On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that ali

Re: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-05-26 Thread Segher Boessenkool
Hi! On Tue, May 26, 2020 at 03:45:05AM +, Yangfei (Felix) wrote: > > > I am using Outlook and I didn't find the place to change the MIME type > > > : - ( > > > > The simplest option is to use a different email client, one that plays > > nicely > > with others. You use git, maybe you could e

[committed] jit: fix sphinx formatting issues in docs

2020-05-26 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as 0981cf960d07752f9844a2f2799fbc85a7f1efd8. gcc/jit/ChangeLog: * docs/topics/compatibility.rst: Fix underline. Fix missing labels. * docs/topics/types.rst: Fix missing blank line. * doc

Re: [PATCH 2/2] gcc-changelog: handle entries with multi-line file lists

2020-05-26 Thread Martin Liška
On 5/26/20 4:47 PM, Pierre-Marie de Rodat wrote: This extends the ChangeLog entries parsing machinery to handle entries that cover multiple files spanning over multiple lines. For instance: * first_file_patched.c, second_file_patched.c, third_file_patched.c, fourth_file_patched.c: Do t

[committed] jit: check for void types [PR 95296]

2020-05-26 Thread David Malcolm via Gcc-patches
PR jit/95296 reports an ICE when using libgccjit to create a local of void type. This patch adds checking to various API entrypoints in libgccjit.c so that they fail gracefully with an error if the client code attempts to create various kinds of rvalues or types involving void types. The patch doc

Re: [PATCH 1/2] gcc-changelog: remove file descriptor leaks

2020-05-26 Thread Martin Liška
On 5/26/20 4:47 PM, Pierre-Marie de Rodat wrote: Currently, running gcc-changelog's unit tests may clutter the output with tons of warnings such as: .../contrib/gcc-changelog/git_email.py:40: ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/tmpt5okd4qp.patch' mode='r'

[PATCH 2/2] gcc-changelog: handle entries with multi-line file lists

2020-05-26 Thread Pierre-Marie de Rodat
This extends the ChangeLog entries parsing machinery to handle entries that cover multiple files spanning over multiple lines. For instance: * first_file_patched.c, second_file_patched.c, third_file_patched.c, fourth_file_patched.c: Do things. contrib/ * gcc-changelog/git_commit.

[PATCH 1/2] gcc-changelog: remove file descriptor leaks

2020-05-26 Thread Pierre-Marie de Rodat
Currently, running gcc-changelog's unit tests may clutter the output with tons of warnings such as: .../contrib/gcc-changelog/git_email.py:40: ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/tmpt5okd4qp.patch' mode='r' encoding='UTF-8'> lines = open(self.filename).re

Re: [rs6000] fix mffsl emulation

2020-05-26 Thread Alexandre Oliva
On Apr 28, 2020, Segher Boessenkool wrote: > Okay for trunk with such tweaks. Thank you! Also okay for the 9 branch, > after waiting to see if any fallout appears. Thanks, I've just pushed it to the gcc-9 branch. -- Alexandre Oliva, freedom fighterhe/himhttps://FSFLA.org/blogs/lxo/ F

Re: [Patch][OpenMP] Fix mapping of artificial variables (PR94874)

2020-05-26 Thread Jakub Jelinek via Gcc-patches
On Mon, May 25, 2020 at 07:10:31PM +0200, Tobias Burnus wrote: > +enum omp_clause_defaultmap_kind > +cxx_omp_predetermined_mapping (tree decl) > +{ > + enum omp_clause_default_kind ret = cxx_omp_predetermined_sharing_1 (decl); > + if (ret != OMP_CLAUSE_DEFAULT_UNSPECIFIED) > +return OMP_CLAUS

[PATCH] tree-optimization/95327 - fix another vectorizable_shift const SLP op

2020-05-26 Thread Richard Biener
This fixes another case where we fail to set the type on a SLP constant operand in vectorizable_shift. Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. Richard. 2020-05-26 Richard Biener PR tree-optimization/95327 * tree-vect-stmts.c (vectorizable_shift): Compute o

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-26 Thread Richard Biener
On Tue, 26 May 2020, Alexandre Oliva wrote: > On May 26, 2020, Richard Biener wrote: > > > xgcc: error: unrecognized command-line option '-dumpbase'^M > > > xg++: error: unrecognized command-line option '-dA'; did you mean '-A' > > > Here's a proper patch submission. I'm still throwing tests

[LTO/offloading] Fix offloading-compilation ICE without -flto (PR84320)

2020-05-26 Thread Tobias Burnus
LTO stream out not only happens with LTO (-flto) but also for the offloaded functions with OpenMP/OpenACC. Without using -flto, this leads to an ICE as a recent patch (r11-525-g03d90a20a1afcbb9c30da8d4adf4922b0685061f) added the check to DFS::DFS (lto-streamer-out.c:639): if (ob->local_trees &

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-26 Thread Alexandre Oliva
On May 26, 2020, Richard Biener wrote: > xgcc: error: unrecognized command-line option '-dumpbase'^M > xg++: error: unrecognized command-line option '-dA'; did you mean '-A' Here's a proper patch submission. I'm still throwing tests at it, but it's already proved (with a non-bootstrapped buil

Re: V5 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-26 Thread Martin Liška
On 5/26/20 1:59 PM, H.J. Lu wrote: On Tue, May 26, 2020 at 2:30 AM Martin Liška wrote: On 5/25/20 7:42 PM, H.J. Lu wrote: Here is the updated patch. OK for master? Thank you for the updated patch. I have still few nits: 1) I would make all the: + has_sse3 = has_feature (FEATURE_SSE3);

[committed] i386: Implement V2SI and V4HI shuffles

2020-05-26 Thread Uros Bizjak via Gcc-patches
2020-05-26 Uroš Bizjak gcc/ChangeLog: * config/i386/mmx.md (*mmx_pshufd_1): New insn pattern. * config/i386/i386-expand.c (ix86_vectorize_vec_perm_const): Handle E_V2SImode and E_V4HImode. (expand_vec_perm_even_odd_1): Handle E_V4HImode. Assert that E_V2SImode is already han

Re: New mklog script

2020-05-26 Thread Jakub Jelinek via Gcc-patches
On Tue, May 26, 2020 at 03:14:54PM +0200, Martin Liška wrote: > > > > gcc-ci? > > > > > > What the abbreviation stands for? > > > > > > Martin > > > > > > > > > > > R. > > > > > > > > > > > CheckIn > > > > For those who come from the SVN days where ci was the standard > > abbreviation for c

Re: New mklog script

2020-05-26 Thread Martin Liška
On 5/26/20 3:11 PM, Richard Earnshaw wrote: On 26/05/2020 14:09, Martin Liška wrote: On 5/26/20 1:18 PM, Richard Earnshaw wrote: On 26/05/2020 12:14, Martin Liška wrote: On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'?

Re: New mklog script

2020-05-26 Thread Richard Earnshaw
On 26/05/2020 14:09, Martin Liška wrote: > On 5/26/20 1:18 PM, Richard Earnshaw wrote: >> On 26/05/2020 12:14, Martin Liška wrote: >>> On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'?  This seems to go against that

Re: New mklog script

2020-05-26 Thread Martin Liška
On 5/26/20 1:18 PM, Richard Earnshaw wrote: On 26/05/2020 12:14, Martin Liška wrote: On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'?  This seems to go against that. You are right, but this one is so handy ;) What name

Re: [PATCH 5/7] vect: Support vector load/store with length in vectorizer

2020-05-26 Thread Richard Sandiford
Richard Sandiford writes: > "Kewen.Lin" writes: >> @@ -626,6 +645,12 @@ public: >>/* True if have decided to use a fully-masked loop. */ >>bool fully_masked_p; >> >> + /* Records whether we still have the option of using a length access >> loop. */ >> + bool can_with_length_p; >> +

Re: [PATCH 5/7] vect: Support vector load/store with length in vectorizer

2020-05-26 Thread Richard Sandiford
"Kewen.Lin" writes: > @@ -626,6 +645,12 @@ public: >/* True if have decided to use a fully-masked loop. */ >bool fully_masked_p; > > + /* Records whether we still have the option of using a length access loop. > */ > + bool can_with_length_p; > + > + /* True if have decided to use

[pushed] coroutines, testsuite: Fix co-ret-17-void-ret-coro.C.

2020-05-26 Thread Iain Sandoe
Hi This was a bad testcase, found with fsanitize=address; the final suspend is 'suspend never' which flows off the end of the coroutine destroying the promise and the frame. At that point access via the handle is an error. Fixed by checking that the promise is destroyed via a global var. teste

Re: [PATCH 0/7] Support vector load/store with length

2020-05-26 Thread Richard Sandiford
"Kewen.Lin" writes: > on 2020/5/26 下午5:44, Richard Biener wrote: >> On Tue, 26 May 2020, Kewen.Lin wrote: >> >>> Hi Richi, >>> >>> on 2020/5/26 下午3:12, Richard Biener wrote: On Tue, 26 May 2020, Kewen.Lin wrote: > Hi all, > > This patch set adds support for vector load/store

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-26 Thread Alexandre Oliva
On May 26, 2020, Richard Biener wrote: > All visible by testing on x86_64-linux. Interesting bug. You wouldn't have hit it if you enabled Ada. That's because I'd missed the %< directives that validate_switches mishandled in the Ada specs, so validate_switches handled the %{d*} and validated -d

V5 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-26 Thread H.J. Lu via Gcc-patches
On Tue, May 26, 2020 at 2:30 AM Martin Liška wrote: > > On 5/25/20 7:42 PM, H.J. Lu wrote: > > Here is the updated patch. OK for master? > > Thank you for the updated patch. > > I have still few nits: > > 1) I would make all the: > > > + has_sse3 = has_feature (FEATURE_SSE3); > > a macro. The lo

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-26 Thread François Dumont via Gcc-patches
On 24/05/20 3:43 pm, François Dumont wrote: Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque iterator as the output so that it is transform into an output to pointer. Ignore this remark, I had

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-26 Thread Richard Sandiford
Thanks for working on this. Kamlesh Kumar via Gcc-patches writes: > Here is a discussion we did some time ago regarding the defect. > https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html > please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877 for testcase > behavior. > > We incorpor

[Patch, fortran] PR fortran/52351, 85868 Wrong array section bounds when passing to an intent-in pointer dummy

2020-05-26 Thread José Rui Faustino de Sousa via Gcc-patches
Hi all! Proposed patch to PRs 52351, 85868 Wrong array section bounds when passing to an intent-in pointer dummy. Patch tested only on x86_64-pc-linux-gnu. Add code to allow for the creation a new descriptor for array sections with the correct one based indexing. Rework the generated descr

Re: [PR77691] x86-vxworks malloc aligns to 8 bytes like solaris

2020-05-26 Thread Jonathan Wakely via Gcc-patches
On 26/05/20 07:11 -0300, Alexandre Oliva wrote: On May 9, 2020, Jonathan Wakely wrote: Also approved for gcc-10 branch if the target maintainers are OK with it. It's an ABI change (allocations aligned to alignof(max_align_t) will store the token in the allocation after this change) but the he

Re: New mklog script

2020-05-26 Thread Richard Earnshaw
On 26/05/2020 12:14, Martin Liška wrote: > On 5/26/20 12:23 PM, Richard Earnshaw wrote: >> I thought we had a convention that aliases we added were prefixed with >> 'gcc-'?  This seems to go against that. > > You are right, but this one is so handy ;) > What name do you suggest? > > Martin gcc-c

Re: New mklog script

2020-05-26 Thread Martin Liška
On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'? This seems to go against that. You are right, but this one is so handy ;) What name do you suggest? Martin

Re: New mklog script

2020-05-26 Thread Richard Earnshaw
On 25/05/2020 20:41, Jason Merrill via Gcc-patches wrote: > On Mon, May 25, 2020 at 5:23 AM Martin Liška wrote: >> >> On 5/22/20 11:01 PM, Jason Merrill wrote: >>> On Thu, May 21, 2020 at 6:03 PM Jason Merrill wrote: On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: > > On 5

Re: [stage1][PATCH] Lower VEC_COND_EXPR into internal functions.

2020-05-26 Thread Richard Sandiford
Richard Biener writes: > On Thu, May 21, 2020 at 10:17 PM Segher Boessenkool > wrote: >> >> Hi! >> >> On Thu, May 21, 2020 at 03:29:49PM +0200, Martin Liška wrote: >> > Adding Segher to CC, he can help us. >> >> Oh dear. Are you sure? >> >> > On 5/21/20 2:51 PM, Martin Liška wrote: >> > >Back to

[PATCH] Support --dry-mode in git_update_version.py.

2020-05-26 Thread Martin Liška
The patch improves the script based on Jakub's needs, I'm going to install the patch. contrib/ChangeLog: * gcc-changelog/git_update_version.py: Add 2 new options. contrib/ChangeLog: * gcc-changelog/git_update_version.py: --- contrib/gcc-changelog/git_update_version.py | 43 +++

Re: [PR77691] x86-vxworks malloc aligns to 8 bytes like solaris

2020-05-26 Thread Alexandre Oliva
On May 9, 2020, Jonathan Wakely wrote: > Also approved for gcc-10 branch if the target maintainers are OK with > it. It's an ABI change (allocations aligned to alignof(max_align_t) > will store the token in the allocation after this change) but the > header is an experimental TS feature so not g

Re: [PATCH 0/7] Support vector load/store with length

2020-05-26 Thread Kewen.Lin via Gcc-patches
on 2020/5/26 下午5:44, Richard Biener wrote: > On Tue, 26 May 2020, Kewen.Lin wrote: > >> Hi Richi, >> >> on 2020/5/26 下午3:12, Richard Biener wrote: >>> On Tue, 26 May 2020, Kewen.Lin wrote: >>> Hi all, This patch set adds support for vector load/store with length, Power ISA 3.0

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-26 Thread Alexandre Oliva
On May 26, 2020, Richard Biener wrote: > I'm seeing a lot of issues. :-( > First any LTO invocations end up with > xgcc: error: unrecognized command-line option '-dumpbase'^M > lto-wrapper: fatal error: /home/rguenther/obj/gcc/xgcc returned 1 exit > status^M > compilation terminated.^M > xg+

Re: [PATCH 0/7] Support vector load/store with length

2020-05-26 Thread Richard Biener
On Tue, 26 May 2020, Kewen.Lin wrote: > Hi Richi, > > on 2020/5/26 下午3:12, Richard Biener wrote: > > On Tue, 26 May 2020, Kewen.Lin wrote: > > > >> Hi all, > >> > >> This patch set adds support for vector load/store with length, Power > >> ISA 3.0 brings instructions lxvl/stxvl to perform vecto

Re: V4 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-26 Thread Martin Liška
On 5/25/20 7:42 PM, H.J. Lu wrote: Here is the updated patch. OK for master? Thank you for the updated patch. I have still few nits: 1) I would make all the: + has_sse3 = has_feature (FEATURE_SSE3); a macro. The local variable seems to superfluous. 2) can we automatically deduce option

[PATCH] libatomic/test: correctly handle multilib in blddir

2020-05-26 Thread CHIGOT, CLEMENT via Gcc-patches
Hi, This patch fixes how the variable blddir is computed inside libatomic testsuite in order to ensure that the multilib arguments are taken into account. Note that I'm not sure why DejaGNU function "get_multilibs" can correctly retrieve the multilib directory in some configurations and won't

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-26 Thread Martin Liška
On 5/26/20 10:52 AM, Richard Biener wrote: Did you maybe install a wrong patch or miss some changes? No, I see the same failures. Martin

gcc-patches@gcc.gnu.org

2020-05-26 Thread Jonathan Wakely via Gcc-patches
On 26/05/20 10:36 +0200, Christophe Lyon via Libstdc++ wrote: Hi, On Thu, 21 May 2020 at 02:07, Jonathan Wakely via Gcc-patches wrote: On 21/05/20 01:01 +0100, Jonathan Wakely wrote: >Also add some missing member functions, nodiscard attributes, and >noexcept-specifiers. > > * include/

Re: [PATCH 0/7] Support vector load/store with length

2020-05-26 Thread Kewen.Lin via Gcc-patches
Hi Richi, on 2020/5/26 下午3:12, Richard Biener wrote: > On Tue, 26 May 2020, Kewen.Lin wrote: > >> Hi all, >> >> This patch set adds support for vector load/store with length, Power >> ISA 3.0 brings instructions lxvl/stxvl to perform vector load/store with >> length, it's good to be exploited fo

Simplify tree streaming

2020-05-26 Thread Jan Hubicka
Hi, this patch cleans up tree streaming. The code is prepared to stream nested trees, but we only handle flat trees. As a result we have quite heavy function to stream in/out tree reference which is used many times and shows up in profile. This patch adds stream_write_tree_ref/stream_read_tree_re

gcc-patches@gcc.gnu.org

2020-05-26 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 21 May 2020 at 02:07, Jonathan Wakely via Gcc-patches wrote: > > On 21/05/20 01:01 +0100, Jonathan Wakely wrote: > >Also add some missing member functions, nodiscard attributes, and > >noexcept-specifiers. > > > > * include/experimental/executor (use_future_t::use_future_t()):

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-26 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Mon, May 25, 2020 at 7:44 PM Segher Boessenkool > wrote: >> >> On Mon, May 25, 2020 at 02:39:54PM +0200, Richard Biener wrote: >> > On Fri, May 22, 2020 at 6:54 PM Segher Boessenkool >> > wrote: >> > > > The split above allows the "bug" to be fixed (even on the branc

[wwwdocs] Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-26 Thread Alexandre Oliva
On May 21, 2020, Alexandre Oliva wrote: > On May 19, 2020, Richard Biener wrote: >> Thanks again for doing this. May I also suggest to prepare a short >> entry for gcc-11/changes.html with these things (like "Output of >> auxiliary files changed. See https://gcc.gnu.org/ml/gcc-patches/... >>

[committed] openmp: Ensure copy ctor for composite distribute parallel for class iterators is instantiated [PR95197]

2020-05-26 Thread Jakub Jelinek via Gcc-patches
Hi! During gimplification omp_finish_clause langhook is called in several places to add the language specific info to the clause like what default/copy ctors, dtors and assignment operators should be used. Unfortunately, if it refers to some not yet instantiated method, during gimplification it i

Re: ChangeLog files - server and client scripts

2020-05-26 Thread Alexandre Oliva
Hi, Martin, On May 26, 2020, Martin Liška wrote: >> I've long used the following syntax to start ChangeLog entries: >> >> for /ChangeLog > Ah, it's new for me. >> >> It was introduced over 20 years ago, with the (so far never formally >> released) GNU CVS-Utilities. Among other goodies, th

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-26 Thread Martin Liška
Hi. There's a small improvement. When filling up the ChangeLog entries, I see it handy to open a patch in a separate window. I would use GCC_DIFF_FILE env. variable for saving of the diff file. Thoughts? Martin >From bffc1bdd709b5152f290febb334b009c2f225872 Mon Sep 17 00:00:00 2001 From: Martin

Re: [PATCH 0/7] Support vector load/store with length

2020-05-26 Thread Richard Biener
On Tue, 26 May 2020, Kewen.Lin wrote: > Hi all, > > This patch set adds support for vector load/store with length, Power > ISA 3.0 brings instructions lxvl/stxvl to perform vector load/store with > length, it's good to be exploited for those cases we don't have enough > stuffs to fill in the who

[PATCH] Allow ChangeLog entries for ignored location.

2020-05-26 Thread Martin Liška
We should be able to generate ChangeLog entries for commits like b3d566f570f4416299240b51654b70c74f6cba6a. I'm going to install the patch. contrib/ChangeLog: * gcc-changelog/git_commit.py: Parse changelog entries for ignored locations. * gcc-changelog/test_email.py: Add n