Re: [PATCH] Check calls before loop unrolling

2020-08-31 Thread Jiufu Guo via Gcc-patches
guojiufu writes: Hi, In this patch, the default value of param=max-unrolled-average-calls-x1 is '0', which means to unroll a loop, there should be no call inside the body. Do I need to set the default value to a bigger value (16?) for later tune? Biger value will keep the behavior unchange

[PATCH] test/rs6000: Replace test target p8 and p9+

2020-08-31 Thread Kewen.Lin via Gcc-patches
Hi, This is a trivial patch to clean existing rs6000 test targets p8 and p9+ with existing has_arch_pwr8 and has_arch_pwr9 target combination or only one of them. Not sure if it's a good idea to tidy this, but send out for comments. Bootstrapped/regtested on powerpc64le-linux-gnu P9. Any commen

Re: [PATCH] test/rs6000: Add Power9 and up as vect_len target

2020-08-31 Thread Kewen.Lin via Gcc-patches
Hi Segher, >> proc check_effective_target_vect_len_load_store { } { >> -return 0 >> +return [expr { [check_effective_target_has_arch_pwr9] }] >> } > > Why not just > > return check_effective_target_has_arch_pwr9; > > ? (Or lose at least two pairs of brackets if not all three :-) )

PING: [PATCH V2] Add pattern for pointer-diff on addresses with same base/offset (PR 94234)

2020-08-31 Thread Feng Xue OS via Gcc-patches
Thanks, Feng From: Feng Xue OS Sent: Wednesday, August 19, 2020 5:17 PM To: Richard Biener Cc: gcc-patches@gcc.gnu.org; Marc Glisse Subject: [PATCH V2] Add pattern for pointer-diff on addresses with same base/offset (PR 94234) As Richard's comment, this p

Re: [PATCH] test/rs6000: Add Power9 and up as vect_len target

2020-08-31 Thread Kewen.Lin via Gcc-patches
Hi Will, Thanks for the review! on 2020/9/1 上午1:13, will schmidt wrote: > On Mon, 2020-08-31 at 14:43 +0800, Kewen.Lin via Gcc-patches wrote: >> Hi, >> >> Power9 supports vector with length in bytes load/store, this patch >> is to teach check_effective_target_vect_len_load_store to take it >> and

Re: [PATCH] Enable GCC support for AMX

2020-08-31 Thread Hongyu Wang via Gcc-patches
PING^3 Hongyu Wang 于2020年8月4日周二 下午11:40写道: > > Kirill Yukhin 于2020年8月4日周二 下午10:47写道: > > > > Hello, > > > > On 06 июл 09:58, Hongyu Wang via Gcc-patches wrote: > > > Hi: > > > > > > This patch is about to support Intel Advanced Matrix Extensions (AMX) > > > which will be enabled in GLC. > > > >

[committed] analyzer: handle __builtin___memset_chk [PR96798]

2020-08-31 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-2957-gbc62bfb0f43eeada02cb924e3cb5457a399b01c0. gcc/analyzer/ChangeLog: PR analyzer/96798 * region-model.cc (region_model::on_call_pre): Handle BUILT_IN_MEMSET_CHK. gcc/testsuite/ChangeL

[committed] analyzer: gather builtin/internal fn handling into switch statements

2020-08-31 Thread David Malcolm via Gcc-patches
Clean up this code in preparation for fixing PR analyzer/96798. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-2956-gee7bfbe5eb70a23bbf3a2cedfdcbd2ea1a20c3f2. gcc/analyzer/ChangeLog: * region-model.cc (region_model::on_call_pre): Gather handling of

[committed] analyzer: fix ICE on unknown index in CONSTRUCTOR [PR96860]

2020-08-31 Thread David Malcolm via Gcc-patches
PR analyzer/96860 reports an ICE inside CONSTRUCTOR-handling with --param analyzer-max-svalue-depth=0 when attempting to build a binding_map for the CONSTRUCTOR's values. The issue is that when handling (index, value) pairs for initializing an array, the index values for the elements exceeds the s

Re: [PATCH] separate reading past the end from -Wstringop-overflow

2020-08-31 Thread Martin Sebor via Gcc-patches
On 8/31/20 3:50 PM, Martin Sebor wrote: On 8/31/20 4:51 AM, Christophe Lyon wrote: Hi, ... I pushed a small aarch64 patch as obvious: 2020-08-31  Christophe Lyon  gcc/testsuite/ * gcc.target/aarch64/strcmpopt_6.c: Suppress -Wstringop-overread. (same as you added fo

Re: [PATCH] separate reading past the end from -Wstringop-overflow

2020-08-31 Thread Martin Sebor via Gcc-patches
On 8/31/20 4:51 AM, Christophe Lyon wrote: Hi, ... I pushed a small aarch64 patch as obvious: 2020-08-31 Christophe Lyon gcc/testsuite/ * gcc.target/aarch64/strcmpopt_6.c: Suppress -Wstringop-overread. (same as you added for i386) Thank you! On arm, there is a

Re: [patch] PR tree-optimization/96818 - cast label range to type of switch operand

2020-08-31 Thread Jason Merrill via Gcc-patches
On 8/31/20 5:10 AM, Aldy Hernandez wrote: On 8/31/20 10:33 AM, Richard Biener wrote: On Mon, Aug 31, 2020 at 10:20 AM Aldy Hernandez wrote: As discussed in the PR, the type of a switch operand may be different than the type of the individual cases.  This is causing us to attempt to intersect

[wwwdocs] cxx-status: Use C++20 instead of C++2a.

2020-08-31 Thread Marek Polacek via Gcc-patches
It's time to use 20 instead of 2a. Pushed. commit 2330b0f89b6ac47cbb2253562a350eb1d121dd69 Author: Marek Polacek Date: Mon Aug 31 16:30:51 2020 -0400 cxx-status: Use C++20 instead of C++2a. diff --git a/htdocs/projects/cxx-status.html b/htdocs/projects/cxx-status.html index d942e7d3..e69

[committed] analyzer: fix ICE on RANGE_EXPR in CONSTRUCTORs [PR96763]

2020-08-31 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-2953-g0d1b4edc5fff834e8f924b20dd021ded7a21d2d2. gcc/analyzer/ChangeLog: PR analyzer/96763 * store.cc (binding_map::apply_ctor_to_region): Handle RANGE_EXPR by calling a new binding_map::a

[committed] analyzer: fix ICE on casting float to pointer [PR96764]

2020-08-31 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-2952-gecdb93224c56189a129e97c556fe6b78e1b15a63. gcc/analyzer/ChangeLog: PR analyzer/96764 * region-model-manager.cc (region_model_manager::maybe_fold_unaryop): Handle VIEW_CONVERT_EXPR.

Re: [PATCH] c++: Fix resolving the address of overloaded pmf [PR96647]

2020-08-31 Thread Jason Merrill via Gcc-patches
On 8/28/20 12:45 PM, Patrick Palka wrote: (Removing libstd...@gcc.gnu.org from CC list) On Fri, 28 Aug 2020, Patrick Palka wrote: In resolve_address_of_overloaded_function, currently only the second pass over the overload set (which considers just the function templates in the overload set) che

Re: [PATCH v3] c++: Implement P1009: Array size deduction in new-expressions.

2020-08-31 Thread Jason Merrill via Gcc-patches
On 8/25/20 8:26 AM, Marek Polacek wrote: On Mon, Aug 24, 2020 at 10:49:38PM -0400, Jason Merrill wrote: On 8/24/20 5:44 PM, Marek Polacek wrote: --- a/gcc/tree.c +++ b/gcc/tree.c @@ -2123,6 +2123,23 @@ build_constructor_from_list (tree type, tree vals) return build_constructor (type, v);

Re: [PATCH 3/4 v3] ivopts: Consider cost_step on different forms during unrolling

2020-08-31 Thread Segher Boessenkool
Hi! Just a note: On Tue, Aug 25, 2020 at 08:46:55PM +0800, Kewen.Lin wrote: > 1) Currently address_cost hook on rs6000 always return zero, but at least > from Power7, pre_inc/pre_dec kind instructions are cracked, it means we > have to take the address update into account (scalar normal operation

Re: [PATCH] test/rs6000: Add Power9 and up as vect_len target

2020-08-31 Thread Segher Boessenkool
Hi! On Mon, Aug 31, 2020 at 02:43:50PM +0800, Kewen.Lin wrote: > --- a/gcc/testsuite/lib/target-supports.exp > +++ b/gcc/testsuite/lib/target-supports.exp > @@ -7066,7 +7066,7 @@ proc check_effective_target_vect_fully_masked { } { > # @code{len_store} optabs. > > proc check_effective_target_ve

Re: [PATCH] test/rs6000: Add Power9 and up as vect_len target

2020-08-31 Thread will schmidt via Gcc-patches
On Mon, 2020-08-31 at 14:43 +0800, Kewen.Lin via Gcc-patches wrote: > Hi, > > Power9 supports vector with length in bytes load/store, this patch > is to teach check_effective_target_vect_len_load_store to take it > and its laters as effective vector with length targets. > > Also supplement the do

Re: [PATCH] rs6000: Expand vec_insert in expander instead of gimple [PR79251]

2020-08-31 Thread Segher Boessenkool
Hi! On Mon, Aug 31, 2020 at 04:06:47AM -0500, Xiong Hu Luo wrote: > vec_insert accepts 3 arguments, arg0 is input vector, arg1 is the value > to be insert, arg2 is the place to insert arg1 to arg0. This patch adds > __builtin_vec_insert_v4si[v4sf,v2di,v2df,v8hi,v16qi] for vec_insert to > not expa

[PATCH] doc: Update documentation on MODE_PARTIAL_INT subregs

2020-08-31 Thread Jozef Lawrynowicz
In d8487c949ad5 (~GCC 4.9.0), MODE_PARTIAL_INT modes were changed from having an unknown number of undefined bits, to having a known number of undefined bits, however the documentation on using SUBREG expressions with MODE_PARTIAL_INT modes was not updated to reflect this. The attached patch updat

Re: [PATCH] rs6000: Expand vec_insert in expander instead of gimple [PR79251]

2020-08-31 Thread will schmidt via Gcc-patches
On Mon, 2020-08-31 at 04:06 -0500, Xiong Hu Luo via Gcc-patches wrote: > vec_insert accepts 3 arguments, arg0 is input vector, arg1 is the value > to be insert, arg2 is the place to insert arg1 to arg0. This patch adds > __builtin_vec_insert_v4si[v4sf,v2di,v2df,v8hi,v16qi] for vec_insert to > not

Re: [Patch] OpenMP/Fortran: Handle polymorphic scalars in data-sharing FIRSTPRIVATE (PR86470)

2020-08-31 Thread Jakub Jelinek via Gcc-patches
On Tue, Aug 25, 2020 at 12:50:46PM +0200, Tobias Burnus wrote: > OK for mainline? Generally, you know Fortran FE much more than I do, so just a few random comments. > --- a/gcc/fortran/trans-openmp.c > +++ b/gcc/fortran/trans-openmp.c > @@ -355,6 +355,51 @@ gfc_has_alloc_comps (tree type, tree de

Re: [PATCH] rs6000, vec_popcntd is improperly defined in altivec.h

2020-08-31 Thread Carl Love via Gcc-patches
Will: > That looks OK within this context. > > Are there any existing tests that use these named variations? > > Thanks, > -Will I was not able to find any test cases for these named builtins. I fixed the other issues you mentioned in the message and patch below. Carl Lov

Re: [PATCH] rs6000, vec_popcntd is improperly defined in altivec.h

2020-08-31 Thread Segher Boessenkool
Hi! On Fri, Aug 28, 2020 at 08:08:05AM -0700, Carl Love wrote: > The defines for vec_popcnt, bvec_popcnth, vec_popcntw, vec_popcntd in > gcc/config/rs6000/altivec.h are not listed in the Power 64-Bi ELF V2 > ABI specification revision 1.4, May 10, 2017. They are not used by any > of the regressio

[Patch, fortran] PR fortran/96870 - Class name on error message

2020-08-31 Thread José Rui Faustino de Sousa via Gcc-patches
Hi all! Proposed patch to PR96870 - Class name on error message. Patch tested only on x86_64-pc-linux-gnu. Make the error message more intelligible for the average user. Thank you very much. Best regards, José Rui 2020-8-21 José Rui Faustino de Sousa gcc/fortran/ChangeLog:

Re: [Patch] OpenMP: Handle cpp_implicit_alias in declare-target discovery (PR96390)

2020-08-31 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 03, 2020 at 05:37:40PM +0200, Tobias Burnus wrote: > It turned out that the omp_discover_declare_target_tgt_fn_r > discovered all nodes – but as it tagged the C++ alias nodes > and not the streamed-out nodes, no device function was created > and one got link errors if offloading devices

Re: [PATCH] rs6000, vec_popcntd is improperly defined in altivec.h

2020-08-31 Thread will schmidt via Gcc-patches
On Fri, 2020-08-28 at 08:08 -0700, Carl Love wrote: > GCC maintainers: > Hi, > The defines for vec_popcnt, bvec_popcnth, vec_popcntw, vec_popcntd in s/bvec/vec/ > gcc/config/rs6000/altivec.h are not listed in the Power 64-Bi ELF V2 > ABI specification revision 1.4, May 10, 2017. They are n

Re: [PATCH v3] libgcc: Use `-fasynchronous-unwind-tables' for LIB2_DIVMOD_FUNCS

2020-08-31 Thread Maciej W. Rozycki via Gcc-patches
On Fri, 28 Aug 2020, Jakub Jelinek wrote: > > As far as `-fexceptions' and `-fasynchronous-unwind-tables' are concerned > > it aligns with my understanding, i.e. in this specific scenario we need > > `-fasynchronous-unwind-tables' for libcalls (all of them) so that an > > -fasynchronous-unwin

[committed] d: Fix ICEs in the front-end when pointer size is 16-bit.

2020-08-31 Thread Iain Buclaw via Gcc-patches
Hi, This patch fixes a couple of ICEs seen when compiling D source code for a 16-bit target. The one I used for testing was xstormy16-elf. In the lowering of `bt*' intrinsics, some integer constants had mismatched types, and bitsize was set to the wrong value. In base_vtable_offset, the base of

[WIP][PATCH] RISC-V: Add `-mgprel' option for GP-relative addressing

2020-08-31 Thread Maciej W. Rozycki via Gcc-patches
Implement `-mgprel', forcing `-mexplicit-relocs' whenever the option is active due to the lack of GAS macro support for GP-relative addressing. gcc/ * riscv/riscv-protos.h (riscv_symbol_type): Add SYMBOL_GPREL enumeration constant. * config/riscv/riscv.c (riscv_cl

Re: [Patch] OpenMP/Fortran: Handle polymorphic scalars in data-sharing FIRSTPRIVATE (PR86470)

2020-08-31 Thread Tobias Burnus
Hi Andre, On 8/31/20 12:55 PM, Andre Vehreschild wrote: +gfc_is_unlimited_polymorphic_nonptr (tree type) + tree field = TYPE_FIELDS (type); /* _data */ + if (!field) ^^^ here you don't . So theoretically this routine could match a type which has a _len as its third field, but that is not a un

Re: [patch] PR tree-optimization/96818 - cast label range to type of switch operand

2020-08-31 Thread Richard Biener via Gcc-patches
On Mon, Aug 31, 2020 at 11:10 AM Aldy Hernandez wrote: > > > > On 8/31/20 10:33 AM, Richard Biener wrote: > > On Mon, Aug 31, 2020 at 10:20 AM Aldy Hernandez wrote: > >> > >> As discussed in the PR, the type of a switch operand may be different > >> than the type of the individual cases. This is

Re: [PATCH] rs6000: Expand vec_insert in expander instead of gimple [PR79251]

2020-08-31 Thread Richard Biener via Gcc-patches
On Mon, Aug 31, 2020 at 11:09 AM Xiong Hu Luo via Gcc-patches wrote: > > vec_insert accepts 3 arguments, arg0 is input vector, arg1 is the value > to be insert, arg2 is the place to insert arg1 to arg0. This patch adds > __builtin_vec_insert_v4si[v4sf,v2di,v2df,v8hi,v16qi] for vec_insert to > not

Re: [r11-1851 Regression] FAIL: gcc.dg/vect/slp-46.c scan-tree-dump-times vect "vectorizing stmts using SLP" 2 on Linux/x86_64 (-m64 -march=cascadelake)

2020-08-31 Thread H.J. Lu via Gcc-patches
On Mon, Aug 31, 2020 at 12:25 AM Richard Biener wrote: > > On Sat, 29 Aug 2020, sunil.k.pandey wrote: > > > On Linux/x86_64, > > > > dccbf1e2a6e544f71b4a5795f0c79015db019fc3 is the first bad commit > > commit dccbf1e2a6e544f71b4a5795f0c79015db019fc3 > > Author: Richard Biener > > Date: Mon Jul

[PATCH] tree-optimization/96854 - SLP reduction of two-operator is broken

2020-08-31 Thread Richard Biener
This fixes SLP reduction of two-operator operations by marking those not supported. In fact any live lane out of such an operation cannot be code-generated correctly. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. This is for GCC 10 only, trunk gets the new testcase only. Richar

Re: [PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine.

2020-08-31 Thread Jan Hubicka
> > Yeah. Or even refactor the output machinery so that in theory > we can create asm fragments [into memory] for functions and variables > and only at the end concat/output them in a desired order (cf. > -fno-toplevel-reorder > wrt toporder code-generation we'd prefer). That would also be one

Re: [PATCH 3/n] ipa: Simplify interface of ipa_call_context::estimate_size_and_time

2020-08-31 Thread Jan Hubicka
> > All right, but let's start from the basic objective of the patch. Do > we want to have something like ipa_call_arg_values? OK, i suppose you patch was motivated by two things: 1) combine results of the estimates to one place (reducing number of parameters in estimate_size_and_time) whi

Re: [PATCH] Fix ICE in ipa-cp due to cost addition overflow (PR 96806)

2020-08-31 Thread Jan Hubicka
> Hi, > > On Mon, Aug 31 2020, Feng Xue OS wrote: > > This patch is to fix a bug that cost that is used to evaluate clone > > candidate > > becomes negative due to integer overflow. > > > > Feng > > --- > > 2020-08-31 Feng Xue > > > > gcc/ > > PR tree-optimization/96806 > > the compon

Re: [Patch] OpenMP/Fortran: Handle polymorphic scalars in data-sharing FIRSTPRIVATE (PR86470)

2020-08-31 Thread Andre Vehreschild
Hi Tobias, in (look for ^^^): diff --git a/gcc/fortran/trans-openmp.c b/gcc/fortran/trans-openmp.c index 063d4c145e2..705cdc7749f 100644 --- a/gcc/fortran/trans-openmp.c +++ b/gcc/fortran/trans-openmp.c @@ -355,6 +355,51 @@ gfc_has_alloc_comps (tree type, tree decl) return false; } +/* Retur

Re: [PATCH] separate reading past the end from -Wstringop-overflow

2020-08-31 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 26 Aug 2020 at 22:36, Jeff Law via Gcc-patches wrote: > > On Tue, 2020-06-23 at 20:05 -0600, Martin Sebor wrote: > > -Wstringop-overflow is issued for both writing and reading past > > the end, even though the latter problem is often viewed as being > > lower severity than the former,

Re: [Patch, fortran] PR96495 - [gfortran] Composition of user-defined operators does not copy ALLOCATABLE property of derived type

2020-08-31 Thread Andre Vehreschild
Hi Paul, your patch looks fine to me. Ok for trunk. Thanks for the patch. Regards, Andre On Sat, 29 Aug 2020 12:50:20 +0100 Paul Richard Thomas via Fortran wrote: > This patch detects a scalar function result that has allocatable components > and is being used inside a scalarization l

Re: [PATCH 3/6] Implement fork-based parallelism engine

2020-08-31 Thread Richard Biener via Gcc-patches
On Thu, Aug 27, 2020 at 8:27 PM Giuliano Belinassi wrote: > > Hi, Honza. > > Thank you for your detailed review! > > On 08/27, Jan Hubicka wrote: > > > diff --git a/gcc/cgraph.c b/gcc/cgraph.c > > > index c0b45795059..22405098dc5 100644 > > > --- a/gcc/cgraph.c > > > +++ b/gcc/cgraph.c > > > @@ -2

Re: [PATCH 2/6] Implement a new partitioner for parallel compilation

2020-08-31 Thread Richard Biener via Gcc-patches
On Fri, Aug 21, 2020 at 12:00 AM Giuliano Belinassi wrote: > > When using the LTO infrastructure to compile files in parallel, we > can't simply use any of the LTO partitioner, once extra dependency > analysis is required to ensure that some nodes are correctly > partitioned together. > > Therefor

Re: [PATCH] Fix ICE in ipa-cp due to cost addition overflow (PR 96806)

2020-08-31 Thread Feng Xue OS via Gcc-patches
>>> the component is "ipa," please change that when you commit the patch. >> Mistake has been made, I'v pushed it. Is there a way to correct it? git push >> --force? > > There is. You need to wait until tomorrow (after the commit message > gets copied to gcc/ChangeLog by a script) and then push a

Re: [PATCH] Fix ICE in ipa-cp due to cost addition overflow (PR 96806)

2020-08-31 Thread Martin Jambor
Hi, On Mon, Aug 31 2020, Feng Xue OS wrote: >>> gcc/ >>> PR tree-optimization/96806 > >> the component is "ipa," please change that when you commit the patch. > Mistake has been made, I'v pushed it. Is there a way to correct it? git push > --force? There is. You need to wait until tomor

Re: [patch] PR tree-optimization/96818 - cast label range to type of switch operand

2020-08-31 Thread Aldy Hernandez via Gcc-patches
On 8/31/20 10:33 AM, Richard Biener wrote: On Mon, Aug 31, 2020 at 10:20 AM Aldy Hernandez wrote: As discussed in the PR, the type of a switch operand may be different than the type of the individual cases. This is causing us to attempt to intersect incompatible ranges. This inconsistent

Re: [PATCH] Fix ICE in ipa-cp due to cost addition overflow (PR 96806)

2020-08-31 Thread Feng Xue OS via Gcc-patches
>> gcc/ >> PR tree-optimization/96806 > the component is "ipa," please change that when you commit the patch. Mistake has been made, I'v pushed it. Is there a way to correct it? git push --force? Thanks, Feng

[PATCH] rs6000: Expand vec_insert in expander instead of gimple [PR79251]

2020-08-31 Thread Xiong Hu Luo via Gcc-patches
vec_insert accepts 3 arguments, arg0 is input vector, arg1 is the value to be insert, arg2 is the place to insert arg1 to arg0. This patch adds __builtin_vec_insert_v4si[v4sf,v2di,v2df,v8hi,v16qi] for vec_insert to not expand too early in gimple stage if arg2 is variable, to avoid generate store h

Re: [PATCH] Fix ICE in ipa-cp due to cost addition overflow (PR 96806)

2020-08-31 Thread Martin Jambor
Hi, On Mon, Aug 31 2020, Feng Xue OS wrote: > This patch is to fix a bug that cost that is used to evaluate clone candidate > becomes negative due to integer overflow. > > Feng > --- > 2020-08-31 Feng Xue > > gcc/ > PR tree-optimization/96806 the component is "ipa," please change that

Re: [patch] PR tree-optimization/96818 - cast label range to type of switch operand

2020-08-31 Thread Richard Biener via Gcc-patches
On Mon, Aug 31, 2020 at 10:39 AM Jakub Jelinek wrote: > > On Mon, Aug 31, 2020 at 10:33:20AM +0200, Richard Biener wrote: > > In any case type mismatches here are of course unfortunate > > and both more verification and documentation would be > > nice. verify_gimple_switch only verifies all case

Re: [patch] PR tree-optimization/96818 - cast label range to type of switch operand

2020-08-31 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 31, 2020 at 10:33:20AM +0200, Richard Biener wrote: > In any case type mismatches here are of course unfortunate > and both more verification and documentation would be > nice. verify_gimple_switch only verifies all case labels > have the same type, the type of the switch argument is >

Re: [patch] PR tree-optimization/96818 - cast label range to type of switch operand

2020-08-31 Thread Richard Biener via Gcc-patches
On Mon, Aug 31, 2020 at 10:20 AM Aldy Hernandez wrote: > > As discussed in the PR, the type of a switch operand may be different > than the type of the individual cases. This is causing us to attempt to > intersect incompatible ranges. > > This inconsistent IL seems wrong to me, but it also seems

Re: [Patch] OpenMP/Fortran: Handle polymorphic scalars in data-sharing FIRSTPRIVATE (PR86470)

2020-08-31 Thread Tobias Burnus
*PING* — For this part 1/n patch series. On 8/25/20 12:50 PM, Tobias Burnus wrote: This patch adds support for polymorphic variables ("CLASS") to OpenMP's data-sharing clause FIRSTPRIVATE. While the patch should be okay, there is more follow-up work required, but one has to make a start :-) *

Re: [PATCH] Fix ICE in ipa-cp due to cost addition overflow (PR 96806)

2020-08-31 Thread Richard Biener via Gcc-patches
On Mon, Aug 31, 2020 at 10:06 AM Feng Xue OS via Gcc-patches wrote: > > This patch is to fix a bug that cost that is used to evaluate clone candidate > becomes negative due to integer overflow. OK. Richard. > Feng > --- > 2020-08-31 Feng Xue > > gcc/ > PR tree-optimization/96806 >

[patch] PR tree-optimization/96818 - cast label range to type of switch operand

2020-08-31 Thread Aldy Hernandez via Gcc-patches
As discussed in the PR, the type of a switch operand may be different than the type of the individual cases. This is causing us to attempt to intersect incompatible ranges. This inconsistent IL seems wrong to me, but it also seems pervasive throughout GCC. Jason, as one of the original gimpl

Re: [PATCH] [AVX512] [PR87767] Optimize memory broadcast for constant vector under AVX512

2020-08-31 Thread Richard Biener via Gcc-patches
On Sun, Aug 30, 2020 at 11:24 AM Jakub Jelinek wrote: > > On Fri, Aug 28, 2020 at 06:25:46PM +0200, Jakub Jelinek via Gcc-patches wrote: > > You're right, thanks for spotting it, I've missed native_encode_rtx will do > > quick_push rather than safe_push. > > > > Updated patch below, it shouldn't b

Re: [PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine.

2020-08-31 Thread Richard Biener via Gcc-patches
On Sat, Aug 29, 2020 at 1:31 PM Jan Hubicka wrote: > > > > > It not only creates hidden symbols, but it also changes the original > > symbol name to avoid clashses with other object files. It could be > > very nice to avoid doing this at all. > > > > There was once an idea (I don't remember if fro

Re: [PATCH] c: Silently ignore pragma region [PR85487]

2020-08-31 Thread Richard Biener via Gcc-patches
On Fri, Aug 28, 2020 at 10:04 PM Austin Morton wrote: > > > The patch misses documentation of the pragma. > > This was an intentional omission - when looking for documentation of > the pragma in clang I found none. > > If we do want to document the pragmas in GCC: > - what section of the document

[PATCH] Fix ICE in ipa-cp due to cost addition overflow (PR 96806)

2020-08-31 Thread Feng Xue OS via Gcc-patches
This patch is to fix a bug that cost that is used to evaluate clone candidate becomes negative due to integer overflow. Feng --- 2020-08-31 Feng Xue gcc/ PR tree-optimization/96806 * ipa-cp.c (decide_about_value): Use safe_add to avoid cost addition overflow. gcc/tests

Re: [PATCH v3] libgcc: Use `-fasynchronous-unwind-tables' for LIB2_DIVMOD_FUNCS

2020-08-31 Thread Richard Biener via Gcc-patches
On Fri, Aug 28, 2020 at 5:47 PM Ramana Radhakrishnan wrote: > > On Wed, Aug 26, 2020 at 12:08 PM Richard Biener via Gcc-patches > wrote: > > > > On Tue, Aug 25, 2020 at 6:32 PM Maciej W. Rozycki wrote: > > > > > > Hi Kito, > > > > > > > I just found the mail thread about div mod with -fnon-call-

Re: [PATCH] VEC_COND_EXPR: fix ICE in gimple_expand_vec_cond_expr

2020-08-31 Thread Richard Biener via Gcc-patches
On Fri, Aug 28, 2020 at 4:18 PM Martin Liška wrote: > > Hey. > > The patch is about VEC_COND_EXP comparison of a SSA_NAME with a constant > that is artifact of -fno-tree-ccp. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Err, no - we shouldn

Re: [PATCH] [AVX512]For vector compare to mask register, UNSPEC is needed instead of comparison operator [PR96243]

2020-08-31 Thread Jakub Jelinek via Gcc-patches
On Tue, Aug 11, 2020 at 05:43:48PM +0800, Hongtao Liu via Gcc-patches wrote: > Hi: > The issue is described in the bugzilla. > Bootstrap is ok, regression test for i386/x86-64 backend is ok. > Ok for trunk? > > ChangeLog > gcc/ > PR target/96551 > * config/i386/sse.md (vec_unp

Re: [r11-1851 Regression] FAIL: gcc.dg/vect/slp-46.c scan-tree-dump-times vect "vectorizing stmts using SLP" 2 on Linux/x86_64 (-m64 -march=cascadelake)

2020-08-31 Thread Richard Biener
On Sat, 29 Aug 2020, sunil.k.pandey wrote: > On Linux/x86_64, > > dccbf1e2a6e544f71b4a5795f0c79015db019fc3 is the first bad commit > commit dccbf1e2a6e544f71b4a5795f0c79015db019fc3 > Author: Richard Biener > Date: Mon Jul 6 16:26:50 2020 +0200 > > tree-optimization/96075 - fix bogus misal

Re: [PATCH] sra: Avoid SRAing if there is an aout-of-bounds access (PR 96820)

2020-08-31 Thread Richard Biener
On Fri, 28 Aug 2020, Martin Jambor wrote: > Hi, > > the testcase causes and ICE in the SRA verifier on x86_64 when > compiling with -m32 because build_user_friendly_ref_for_offset looks > at an out-of-bounds array_ref within an array_ref which accesses an > offset which does not fit into a signed