Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Paul Eggert
On 10/2/20 12:01 PM, Alejandro Colomar wrote: If you propose not to document the stdint types either, This is not a stdint.h issue. __int128 is not in stdint.h and is not a system data type in any real sense; it's purely a compiler issue. Besides, do we start repeating the GCC manual too, whi

Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 21:54, Paul Eggert wrote: > On 10/2/20 12:01 PM, Alejandro Colomar wrote: >> If you propose not to document the stdint types either, > > This is not a stdint.h issue. __int128 is not in stdint.h and is not a > system data type in any real sense; it's purely a compiler issue

Re: [PATCH v4 1/2] system_data_types.7: Add 'void *'

2020-10-02 Thread Paul Eggert
On 10/2/20 11:38 AM, Alejandro Colomar wrote: .I void * renders with a space in between. That's odd, as "man(7)" says "All of the arguments will be printed next to each other without intervening spaces". I'd play it safe and quote the arg anyway. > %p works with any object pointer type (

Re: [PATCH] libgccjit: add some reflection functions in the jit C api

2020-10-02 Thread David Malcolm via Gcc-patches
On Tue, 2020-09-01 at 21:01 -0400, Antoni Boucher via Jit wrote: > Hello. > This WIP patch implements new reflection functions in the C API as > mentioned in bug 96889. > I'm looking forward for feedbacks on this patch. > It's WIP because I'll probably add a few more reflection functions. > Thanks

Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Paul Eggert
On 10/2/20 1:03 PM, Alejandro Colomar wrote: I know it's not in stdint, but I mean that it behaves as any other stdint type. It doesn't. There's no portable way to use scanf and printf on it. You can't reliably convert it to intmax_t. It doesn't have the associated _MIN and _MAX macros that t

Re: [PATCH] libgccjit: add some reflection functions in the jit C api

2020-10-02 Thread David Malcolm via Gcc-patches
On Fri, 2020-10-02 at 16:17 -0400, David Malcolm wrote: > On Tue, 2020-09-01 at 21:01 -0400, Antoni Boucher via Jit wrote: > > Hello. > > This WIP patch implements new reflection functions in the C API as > > mentioned in bug 96889. > > I'm looking forward for feedbacks on this patch. > > It's WIP

Re: [PATCH v4 1/2] system_data_types.7: Add 'void *'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 22:14, Paul Eggert wrote: > On 10/2/20 11:38 AM, Alejandro Colomar wrote: > >> .I void * >> >> renders with a space in between. > > That's odd, as "man(7)" says "All of the arguments will be printed next > to each other without intervening spaces". I'd play it safe and quot

[PATCH] PR fortran/97272 - Wrong answer from MAXLOC with character arg

2020-10-02 Thread Harald Anlauf
The generation of the library call for the MINLOC/MAXLOC intrinsic mishandled the optional KIND argument and resulted in a bad argument list passed to the library function. The fix is obvious. Regtested on x86_64-pc-linux-gnu. OK for master? As it technically wrong code, OK for backports? Than

Re: [PATCH] c++: Fix printing of C++20 template parameter object [PR97014]

2020-10-02 Thread Jason Merrill via Gcc-patches
On 10/1/20 5:49 PM, Marek Polacek wrote: No one is interested in the mangled name of the C++20 template parameter object for a class NTTP. So instead of printing required for the satisfaction of ‘positive’ [with T = X<::_ZTAXtl5ratioLin1ELi2EEE>] let's print required for the satisfacti

Re: [committed] libstdc++: Use __libc_single_threaded to optimise atomics [PR 96817]

2020-10-02 Thread Jonathan Wakely via Gcc-patches
On 26/09/20 20:42 +0100, Jonathan Wakely wrote: Glibc 2.32 adds a global variable that says whether the process is single-threaded. We can use this to decide whether to elide atomic operations, as a more precise and reliable indicator than __gthread_active_p. This means that guard variables for

[committed] libstdc++: Change test to work without 64-bit atomics

2020-10-02 Thread Jonathan Wakely via Gcc-patches
This fixes a linker error for older ARM cores without 64-bit atomics. I think the { dg-add-options libatomic } is no longer needed, but it's harmless to keep it there. libstdc++-v3/ChangeLog: * testsuite/29_atomics/atomic_float/value_init.cc: Use float instead of double so that _

Re: This is my patch for fstream to fix the performance issue on Windows.

2020-10-02 Thread Jonathan Wakely via Gcc-patches
On 01/10/20 03:29 +, sotrdg sotrdg via Libstdc++ wrote: From fb8d644a4c315058af141a3e84fcc083d665c8b9 Mon Sep 17 00:00:00 2001 From: ejsvifq_mabmip Date: Wed, 30 Sep 2020 23:26:47 -0400 Subject: [PATCH] Fix a long term performance issue of fstream on Windows since MSVCRT defines BUFSIZ as 51

Re: [PATCH] libstdc++: Diagnose visitors with different return types [PR95904]

2020-10-02 Thread Jonathan Wakely via Gcc-patches
On 29/09/20 19:35 +0300, Ville Voutilainen via Libstdc++ wrote: On Tue, 29 Sep 2020 at 14:20, Jonathan Wakely wrote: I think this is what we want: template constexpr inline __same_types = (is_same_v<_Tp, _Types> && ...); is_same_v is very cheap, it uses the built-in directly, so you d

Re: [PATCH] libgccjit: add some reflection functions in the jit C api [PR96889]

2020-10-02 Thread Antoni Boucher via Gcc-patches
Hi. Thanks for the review. I attached the updated patch file. I don't have a copyright assignment, but I'll look at that. On Fri, Oct 02, 2020 at 04:24:26PM -0400, David Malcolm wrote: On Fri, 2020-10-02 at 16:17 -0400, David Malcolm wrote: On Tue, 2020-09-01 at 21:01 -0400, Antoni Boucher via

Re: [patch] Rework CPP_BUILTINS_SPEC for powerpc-vxworks

2020-10-02 Thread Segher Boessenkool
Hi Olivier, On Thu, Oct 01, 2020 at 11:30:55AM +0200, Olivier Hainque wrote: > This change reworks CPP_BUILTINS_SPEC for powerpc-vxworks to > prepare for the upcoming addition of 32 and 64 bit ports for > VxWorks 7r2. Cool, looking forward to it! Your attachment is not quotable (it is applicatio

[r11-3633 Regression] FAIL: c-c++-common/spellcheck-reserved.c -std=gnu++98 (test for excess errors) on Linux/x86_64 (-m64 -march=cascadelake)

2020-10-02 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 7ee1c0413e251ff0b6a6d526209ef038b9835320 is the first bad commit commit 7ee1c0413e251ff0b6a6d526209ef038b9835320 Author: Nathan Sidwell Date: Fri Oct 2 11:13:26 2020 -0700 c++: Hash table iteration for namespace-member spelling suggestions caused FAIL: c-c++-common/spell

Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Alejandro Colomar via Gcc-patches
Hi Paul, On 2020-10-02 22:19, Paul Eggert wrote: > On 10/2/20 1:03 PM, Alejandro Colomar wrote: >> I know it's not in stdint, >> but I mean that it behaves as any other stdint type. With caveats, of course. > > It doesn't. There's no portable way to use scanf and printf on it. I didn't need to

Re: [PATCH 1/4] system_data_types.7: Add '__int128'

2020-10-02 Thread Paul Eggert
On 10/2/20 4:44 PM, Alejandro Colomar wrote: I know, they aren't perfect. But they are still very useful, and don't see a good reason to not document them. "aren't perfect" is an understatement More important, lots of things in GNU C are useful but shouldn't be documented in the man page

<    1   2