Re: [PATCH] C-family : Add attribute 'unavailable'.

2020-11-09 Thread Richard Biener
On Mon, 9 Nov 2020, Iain Sandoe wrote: > Hi, > > I?ve been carrying this patch around on my Darwin branches for a very long > time? > > tested across the Darwin patch and on x86_64-linux-gnu, > OK for master? > thanks > Iain > > = commit message > > If an interface is marked 'deprecated'

Re: *PING* Re: [Patch] Fortran: Fix function decl's location [PR95847]

2020-11-09 Thread Thomas Koenig via Gcc-patches
Hi Tobias, *PING* OK. Thanks for the patch! Best regards Thomas

Re: [PATCH 1/2] cfgloop: Extend loop iteration macros to loop only over sub-loops

2020-11-09 Thread Richard Biener
On Mon, 9 Nov 2020, Martin Jambor wrote: > Hi, > > This patch adds loop iteration macros FOR_EACH_ENCLOSED_LOOP and > FOR_EACH_ENCLOSED_LOOP_FN which can loop only over inner loops of a > given loop. > > The patch is required for a follow-up patch which enables loop > invariant motion to only

[PATCH] PR target/97682 - Fix to reuse t1 register between call address and epilogue.

2020-11-09 Thread Monk Chiang
- When expanding the call pattern, choose t1 register be a jump register. Epilogue also uses a t1 register to adjust Stack point. The call pattern and epilogue will initial t1 twice, if both are generated in the same function. The call pattern will emit 'la t1,symbol' and 'jalr

testsuite: Adjust pr96789.c to exclude vect_load_lanes

2020-11-09 Thread Kewen.Lin via Gcc-patches
Hi, As Lyon pointed out, the newly introduced test case gcc.dg/tree-ssa/pr96789.c fails on arm-none-linux-gnueabihf. Loop vectorizer is able to vectorize the two loops which operate on array tmp with load_lanes feature support. It makes dse3 get unexpected inputs and do nothing. This patch is

Re: [PATCH] generalized range_query class for multiple contexts

2020-11-09 Thread Andrew MacLeod via Gcc-patches
On 11/5/20 2:29 PM, Martin Sebor wrote: On 10/1/20 11:25 AM, Martin Sebor wrote: I have applied the patch and ran some tests.  There are quite a few failures (see the list below).  I have only looked at a couple.  The one in in gcc.dg/tree-ssa/builtin-sprintf-warn-3.c boils down to the

Fix logical_combine OR operation. Again.

2020-11-09 Thread Andrew MacLeod via Gcc-patches
Doh. The original fix for PR97657 was incorrect.  It papered over a problem by reducing opportunities it could find. Given   if (c_2 || c_3) If the FALSE edge is taken, this is ! (c_2 || c_3) which is equivalent to !c_2 && !c_3.. so performing the intersection as combine_logical was

[PATCH] c++: Improve static_assert diagnostic [PR97518]

2020-11-09 Thread Marek Polacek via Gcc-patches
Currently, when a static_assert fails, we only say "static assertion failed". It would be more useful if we could also print the expression that evaluated to false; this is especially useful when the condition uses template parameters. Consider the motivating example, in which we have this line:

[r11-4852 Regression] FAIL: g++.dg/ubsan/pr61272.C (test for excess errors) on Linux/x86_64

2020-11-09 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 05b03452db6a520091aed254d3c399caed714b15 is the first bad commit commit 05b03452db6a520091aed254d3c399caed714b15 Author: Jason Merrill Date: Fri Nov 6 20:41:54 2020 -0500 c++: Improve error location for class using-decl. caused FAIL: g++.dg/ubsan/pr61272.C(test for

Re: [C PATCH RFC] Drop qualifiers during lvalue conversion

2020-11-09 Thread Joseph Myers
On Sat, 7 Nov 2020, Uecker, Martin wrote: > In 'gcc.dg/cond-constqual-1.c' we test for the opposite > behavior for conditional operators. I do not know why. > We could just invert the test. That's probably a relic of the old idea that rvalues might actually have qualified type in some cases; it

[Patch] Fortran: OpenMP 5.0 (in_,task_)reduction clause extensions

2020-11-09 Thread Tobias Burnus
This patch updates the OpenMP handling to support OpenMP 5.0's reductions changes: - add task_reduction (for taskgroup) - add in_reduction (for task, taskloop, target) - add 'default', 'inscan' and 'task' to 'reduction' - only default for teams, taskloop - all three for parallel, simd, do,

Re: Detect EAF flags in ipa-modref

2020-11-09 Thread Jan Hubicka
Hi, this is updated patch for autodetection of EAF flags. Still the goal is to avoid fancy stuff and get besic logic in place (so no dataflow, no IPA propagation, no attempts to handle trickier cases). There is one new failure ./gcc/testsuite/gcc/gcc.sum:FAIL: gcc.dg/sso/t2.c

Re: [ranger] Fix wrong code for boolean negation in condition at -O

2020-11-09 Thread Andrew MacLeod via Gcc-patches
On 11/9/20 4:38 PM, Eric Botcazou wrote: Hi, this is a regression present on mainline in the form of wrong code generated for the attached Ada testcase at -O -ftree-vrp. It's again an issue with the 8-bit booleans in Ada and, as a matter of fact, it's exactly the same issue as the one I fixed

Re: [PATCH, rs6000] Update instruction attributes for Power10

2020-11-09 Thread Segher Boessenkool
On Wed, Nov 04, 2020 at 02:42:39PM -0600, Pat Haugen wrote: > This patch updates the type/prefixed/dot/size attributes for various new > instructions (and a couple existing that were incorrect) in preparation for > the Power10 scheduling patch that will be following. > ---

[RFH] Use get_deref_alias_type in ipa-modref

2020-11-09 Thread Jan Hubicka
Hi, this patch implements cleanup we discussed some time ago on IRC. Instead of recording reference types in ipa-modref I record pointer types same way as done by RTL attributes and I moved corresponding logic to tree-ssa-alias.c. Problem is that it breaks some testcases:

[ranger] Fix wrong code for boolean negation in condition at -O

2020-11-09 Thread Eric Botcazou
Hi, this is a regression present on mainline in the form of wrong code generated for the attached Ada testcase at -O -ftree-vrp. It's again an issue with the 8-bit booleans in Ada and, as a matter of fact, it's exactly the same issue as the one I fixed elsewhere about one year and half ago

Re: [PATCH] c, c++: Fix up -Wunused-value on COMPLEX_EXPRs [PR97748]

2020-11-09 Thread Jakub Jelinek via Gcc-patches
On Mon, Nov 09, 2020 at 02:35:58PM -0500, Jason Merrill wrote: > How about calling warn_if_unused_value instead of the new > warn_if_unused_value_p? That seems to work if I just replace the warning_at call with warn_if_unused_value call (at least no regression in check-c++-all and libstdc++

Re: [PATCH] nvptx: Cache stacks block for OpenMP kernel launch

2020-11-09 Thread Alexander Monakov via Gcc-patches
On Mon, 26 Oct 2020, Jakub Jelinek wrote: > On Mon, Oct 26, 2020 at 07:14:48AM -0700, Julian Brown wrote: > > This patch adds caching for the stack block allocated for offloaded > > OpenMP kernel launches on NVPTX. This is a performance optimisation -- > > we observed an average 11% or so

Add support for copy specifier to fnspec

2020-11-09 Thread Jan Hubicka
Hi, this patch adds 'c' and 'C' fnspec for parameter that is copied to different parameter. Main motivation is to get rid of wrong EAF_NOESCAPE flag on the memcpy argument #2. I however also added arg_copies_to_arg_p predicate that can be eventually used by tree-ssa-structalias instead of special

[committed] MAINTAINERS: add myself for write after approval

2020-11-09 Thread Pat Bernardi
2020-11-09 Pat Bernardi * MAINTAINERS (Write After Approval): Add myself. --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 24b77f5e663..a0216185de9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -323,6 +323,7 @@ Jon Beniston

Re: [PATCH, rs6000] Update instruction attributes for Power10

2020-11-09 Thread Segher Boessenkool
On Fri, Nov 06, 2020 at 10:46:43AM -0600, Pat Haugen wrote: > On 11/5/20 4:32 PM, will schmidt wrote: > > On Wed, 2020-11-04 at 14:42 -0600, Pat Haugen via Gcc-patches wrote: > >>* config/rs6000/rs6000.c (rs6000_final_prescan_insn): Only add 'p' for > >>PREFIXED_YES. > > > > The code

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-09 Thread H.J. Lu via Gcc-patches
On Mon, Nov 9, 2020 at 11:56 AM Jozef Lawrynowicz wrote: > > On Mon, Nov 09, 2020 at 10:36:07AM -0800, H.J. Lu via Gcc-patches wrote: > > On Mon, Nov 9, 2020 at 9:41 AM Jozef Lawrynowicz > > wrote: > > > > > > On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > > > > On

[pushed] c++: Improve error location for class using-decl.

2020-11-09 Thread Jason Merrill via Gcc-patches
We should use the location of the using-declaration, not the location of the class. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/cp/ChangeLog: * class.c (handle_using_decl): Add an iloc_sentinel. gcc/testsuite/ChangeLog: * g++.dg/lookup/using26.C: Adjust location.

[pushed] c++: Call tsubst_pack_expansion from tsubst.

2020-11-09 Thread Jason Merrill via Gcc-patches
This was unnecessary (and incomplete) code duplication. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/cp/ChangeLog: * pt.c (tsubst): Replace *_ARGUMENT_PACK code with a call to tsubst_argument_pack. --- gcc/cp/pt.c | 15 +-- 1 file changed, 1 insertion(+), 14

[PATCH] c++: Call tsubst_pack_expansion from tsubst.

2020-11-09 Thread Jason Merrill via Gcc-patches
This was unnecessary (and incomplete) code duplication. gcc/cp/ChangeLog: * pt.c (tsubst): Replace *_ARGUMENT_PACK code with a call to tsubst_argument_pack. --- gcc/cp/pt.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/gcc/cp/pt.c

[PATCH 2/2] loops: Invoke lim after successful loop interchange

2020-11-09 Thread Martin Jambor
Hi, this patch modifies the loop invariant pass so that is can operate only on a single requested loop and its sub-loops and ignore the rest of the function, much like it currently ignores basic blocks that are not in any real loop. It then invokes it from within the loop interchange pass when

[PATCH 1/2] cfgloop: Extend loop iteration macros to loop only over sub-loops

2020-11-09 Thread Martin Jambor
Hi, This patch adds loop iteration macros FOR_EACH_ENCLOSED_LOOP and FOR_EACH_ENCLOSED_LOOP_FN which can loop only over inner loops of a given loop. The patch is required for a follow-up patch which enables loop invariant motion to only work on a selected loop. I have bootstrapped and tested

[PATCH 2/2] IBM Z: Test long doubles in vector registers

2020-11-09 Thread Ilya Leoshkevich via Gcc-patches
gcc/testsuite/ChangeLog: 2020-11-05 Ilya Leoshkevich * gcc.target/s390/vector/long-double-callee-abi-scan.c: New test. * gcc.target/s390/vector/long-double-caller-abi-run.c: New test. * gcc.target/s390/vector/long-double-caller-abi-scan.c: New test. *

Re: [PATCH 1/4] c++: Fix ICE with variadic concepts and aliases [PR93907]

2020-11-09 Thread Jason Merrill via Gcc-patches
On 11/7/20 10:59 AM, Patrick Palka wrote: On Fri, 6 Nov 2020, Jason Merrill wrote: On 11/5/20 8:40 PM, Patrick Palka wrote: This patch (naively) extends the PR93907 fix to also apply to variadic concepts invoked with a type argument pack. Without this, we ICE on the below testcase (a

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-09 Thread Jozef Lawrynowicz
On Mon, Nov 09, 2020 at 10:36:07AM -0800, H.J. Lu via Gcc-patches wrote: > On Mon, Nov 9, 2020 at 9:41 AM Jozef Lawrynowicz > wrote: > > > > On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > > > On Fri, Nov 6, 2020 at 4:17 PM Jeff Law wrote: > > > > > > > > > > > > On

[PATCH 1/2] IBM Z: Store long doubles in vector registers when possible

2020-11-09 Thread Ilya Leoshkevich via Gcc-patches
On z14+, there are instructions for working with 128-bit floats (long doubles) in vector registers. It's beneficial to use them instead of instructions that operate on floating point register pairs, because it allows to store 4 times more data in registers at a time, relieving register pressure.

[PATCH 0/2] IBM Z: Store long doubles in vector registers when possible

2020-11-09 Thread Ilya Leoshkevich via Gcc-patches
Bootstrapped and regtested on s390x-redhat-linux with --with-arch=z15. Ok for master? This patch series implements storing long doubles in vector registers on z14+. Patch 1 is the actual implementation, patch 2 adds tests. v1: https://gcc.gnu.org/pipermail/gcc-patches/2020-November/557968.html

Re: [PATCH v2] c++: DR 1914 - Allow duplicate standard attributes.

2020-11-09 Thread Jason Merrill via Gcc-patches
On 11/9/20 12:05 PM, Marek Polacek wrote: On Fri, Nov 06, 2020 at 03:01:56PM -0500, Jason Merrill via Gcc-patches wrote: On 11/6/20 2:34 PM, Marek Polacek wrote: On Fri, Nov 06, 2020 at 02:23:10PM -0500, Jason Merrill via Gcc-patches wrote: On 11/6/20 2:06 PM, Marek Polacek wrote: Following

Re: PowerPC: Update long double IEEE 128-bit tests.

2020-11-09 Thread Segher Boessenkool
On Fri, Nov 06, 2020 at 11:45:21PM -0500, Michael Meissner wrote: > On Mon, Nov 02, 2020 at 07:00:15PM -0600, Segher Boessenkool wrote: > > > + /* This test is written to test IBM extended double, which is a pair of > > > + doubles. If long double can hold a larger value than a double can,

Re: [PATCH] c++: Fix -Wvexing-parse ICE with omitted int [PR97762]

2020-11-09 Thread Jason Merrill via Gcc-patches
On 11/9/20 11:47 AM, Marek Polacek wrote: For declarations like long f(); decl_specifiers->type will be NULL, but I neglected to handle this case, therefore we ICE. So handle this case by pretending we've seen 'int', which is good enough for -Wvexing-parse's purposes.

Re: [PATCH] c, c++: Fix up -Wunused-value on COMPLEX_EXPRs [PR97748]

2020-11-09 Thread Jason Merrill via Gcc-patches
On 11/9/20 4:51 AM, Jakub Jelinek wrote: Hi! The -Wunused-value warning in both C and C++ FEs (implemented significantly differently between the two) sees the COMPLEX_EXPRs created e.g. for complex pre/post increment and many other expressions as useless and warns about it. For the C warning

C++ patch ping

2020-11-09 Thread Jakub Jelinek via Gcc-patches
Hi! I'd like to ping the updated bit_cast patch: https://gcc.gnu.org/pipermail/gcc-patches/2020-November/557781.html Thanks Jakub

Re: Enable MOVDIRI, MOVDIR64B, CLDEMOTE and WAITPKG for march=tremont

2020-11-09 Thread Jason Merrill via Gcc-patches
This patch was also applied to the GCC 9 and 10 branches and breaks those builds, because PTA_CLDEMOTE is not defined. On Mon, Nov 9, 2020 at 4:03 AM Uros Bizjak via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > On Mon, Nov 9, 2020 at 9:50 AM Cui, Lili wrote: > > > > Hi Uros, > > > > This

[PATCH] x86: Add -mneeded for GNU_PROPERTY_X86_ISA_1_V[234] marker

2020-11-09 Thread H.J. Lu via Gcc-patches
GCC 11 supports -march=x86-64-v[234] to enable x86 micro-architecture ISA levels: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97250 Binutils has been updated to support GNU_PROPERTY_X86_ISA_1_V[234] marker: https://gitlab.com/x86-psABIs/x86-64-ABI/-/merge_requests/13 with commit

[PATCH][AArch64] Skip arm targets in vq*shr*n_high_n intrinsic tests

2020-11-09 Thread David Candler via Gcc-patches
Hi, These tests should be skipped for arm targets as the instrinsics are only supported on aarch64. Tested on aarch64 and aarch32 gcc/testsuite/ChangeLog 2020-11-09 David Candler * gcc.target/aarch64/advsimd-intrinsics/vqrshrn_high_n.c: Added skip directive. *

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-09 Thread H.J. Lu via Gcc-patches
On Mon, Nov 9, 2020 at 9:41 AM Jozef Lawrynowicz wrote: > > On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > > On Fri, Nov 6, 2020 at 4:17 PM Jeff Law wrote: > > > > > > > > > On 11/6/20 5:13 PM, H.J. Lu wrote: > > > > On Fri, Nov 6, 2020 at 4:01 PM Jeff Law wrote: > >

[PATCH] [PR target/97727] aarch64: [testcase] fix bf16_vstN_lane_2.c for big endian targets

2020-11-09 Thread Andrea Corallo via Gcc-patches
Hi all, this simple patch is to fix PR target/97727. Okay for trunk and gcc-10? Thanks! Andrea 2020-11-09 Andrea Corallo PR target/97727 * gcc.target/aarch64/advsimd-intrinsics/bf16_vldN_lane_2.c: Relax regexps. >From

[PATCH] rs6000.c DECL_IS_BUILTIN bootstrap fix

2020-11-09 Thread David Edelsohn via Gcc-patches
rs6000: Fix bootstrap after r11-4793. The patch omitted a change for rs6000.c, fixed thus. gcc/ChangeLog: * config/rs6000/rs6000.c (rs6000_mangle_decl_assembler_name): ChangeDECL_IS_BUILTIN -> DECL_IS_UNDECLARED_BUILTIN. diff --git

Re: [PATCH] openmp: Retire nest-var ICV

2020-11-09 Thread Kwok Cheung Yeung
On 06/11/2020 8:33 pm, Tobias Burnus wrote: Hello Kwok, hi Jakub, On 06.11.20 21:13, Kwok Cheung Yeung wrote: In addition to deprecating the omp_(get|set)_nested() functions and OMP_NESTED environment variable, OpenMP 5.0 also removes the nest-var ICV altogether, defining it in terms of the

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-09 Thread Jozef Lawrynowicz
On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > On Fri, Nov 6, 2020 at 4:17 PM Jeff Law wrote: > > > > > > On 11/6/20 5:13 PM, H.J. Lu wrote: > > > On Fri, Nov 6, 2020 at 4:01 PM Jeff Law wrote: > > >> > > >> On 11/6/20 4:45 PM, H.J. Lu wrote: > > >>> On Fri, Nov 6,

Re: [PATCH v2] c++: DR 1914 - Allow duplicate standard attributes.

2020-11-09 Thread Marek Polacek via Gcc-patches
On Fri, Nov 06, 2020 at 03:01:56PM -0500, Jason Merrill via Gcc-patches wrote: > On 11/6/20 2:34 PM, Marek Polacek wrote: > > On Fri, Nov 06, 2020 at 02:23:10PM -0500, Jason Merrill via Gcc-patches > > wrote: > > > On 11/6/20 2:06 PM, Marek Polacek wrote: > > > > Following Joseph's change for C

Re: [Patch] opts: Change `is incompatible with` messages to have standard parametrised form

2020-11-09 Thread Jeff Law via Gcc-patches
On 11/9/20 8:22 AM, Matthew Malcomson via Gcc-patches wrote: > Hello, > > In a recent review for one of the hwasan patches Richard S. noticed there are > quite a few errors of the form "% is incompatible with > ". > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/556137.html > > In order

[PATCH] c++: Fix -Wvexing-parse ICE with omitted int [PR97762]

2020-11-09 Thread Marek Polacek via Gcc-patches
For declarations like long f(); decl_specifiers->type will be NULL, but I neglected to handle this case, therefore we ICE. So handle this case by pretending we've seen 'int', which is good enough for -Wvexing-parse's purposes. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?

Re: [PATCH] c-family: Avoid unnecessary work when -Wpragmas is being ignored

2020-11-09 Thread Jeff Law via Gcc-patches
On 11/9/20 8:38 AM, Patrick Palka via Gcc-patches wrote: > This speeds up handle_pragma_diagnostic by avoiding computing a spelling > suggestion for an unrecognized option inside a #pragma directive when > -Wpragmas warnings are being suppressed. > > In the range-v3 library, which contains many

Re: [PATCH] warn for integer overflow in allocation calls (PR 96838)

2020-11-09 Thread Martin Sebor via Gcc-patches
Ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-September/554000.html Jeff, I don't expect to have the cycles to reimplement this patch using the Ranger APIs before stage 1 closes. I'm open to giving it a try in stage 3 if it's still in scope for GCC 11. Otherwise, is this patch okay to

Re: [PATCH] Prefer bit-test over the jump table.

2020-11-09 Thread Jeff Law via Gcc-patches
On 11/9/20 7:24 AM, Martin Liška wrote: > Hello. > > As mentioned in the PR, we used to prefer BT over JT in switch expansion. > I restore the behavior to that. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > >

Ping^2 Re: float.h: C2x NaN and Inf macros

2020-11-09 Thread Joseph Myers
Ping^2. This patch is still pending review (the DFP sNaN followup has been approved). -- Joseph S. Myers jos...@codesourcery.com

Re: [24/32] module mapper

2020-11-09 Thread Nathan Sidwell
On 11/9/20 1:42 AM, Boris Kolpackov wrote: I've noticed the following issues with the module mapper in the -fdirectives-only mode: 1. When partially preprocessing the module interface unit, the mapper receives the MODULE-EXPORT request that's unnecessary (BMI is not written): g++

[PATCH] c-family: Avoid unnecessary work when -Wpragmas is being ignored

2020-11-09 Thread Patrick Palka via Gcc-patches
This speeds up handle_pragma_diagnostic by avoiding computing a spelling suggestion for an unrecognized option inside a #pragma directive when -Wpragmas warnings are being suppressed. In the range-v3 library, which contains many instances of #pragma GCC diagnostic push #pragma GCC diagnostic

[Patch] opts: Change `is incompatible with` messages to have standard parametrised form

2020-11-09 Thread Matthew Malcomson via Gcc-patches
Hello, In a recent review for one of the hwasan patches Richard S. noticed there are quite a few errors of the form "% is incompatible with ". https://gcc.gnu.org/pipermail/gcc-patches/2020-October/556137.html In order to avoid this creating extra work for translators we would like to change

Re: [PATCH] rs6000: Fix default alignment ABI break caused by MMA base support

2020-11-09 Thread Paul A. Clarke via Gcc-patches
On Fri, Nov 06, 2020 at 04:18:00PM -0600, Peter Bergner via Gcc-patches wrote: > As part of the MMA base support, we incremented BIGGEST_ALIGNMENT in > order to align the __vector_pair and __vector_quad types to 256 and 512 > bits respectively. This had the unintended effect of changing the >

[committed] libstdc++: Improve comment on _Power_of_2 helper function

2020-11-09 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/bits/uniform_int_dist.h (__detail::_Power_of_2): Document that true result for zero is intentional. Tested x86_64-linux. Committed to trunk. commit b2b85163731e8647542f2f7561bd4c69ae5f5f2a Author: Jonathan Wakely Date: Mon Nov 9 14:32:45 2020

[committed] libstdc++: Remove redundant check for zero in std::__popcount

2020-11-09 Thread Jonathan Wakely via Gcc-patches
The popcount built-ins work fine for zero, so there's no need to check for it. libstdc++-v3/ChangeLog: * include/std/bit (__popcount): Remove redundant check for zero. Tested x86_64-linux. Committed to trunk. commit ff4bfb1553cf525d7299bbf7451ac32cfd97ae1b Author: Jonathan Wakely

[PATCH] tree-optimization/97761 - fix SLP live calculation

2020-11-09 Thread Richard Biener
This removes a premature end of the DFS walk. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-11-09 Richard Biener PR tree-optimization/97761 * tree-vect-slp.c (vect_bb_slp_mark_live_stmts): Remove premature end of DFS walk. *

Re: [PATCH] Clean up irange self tests.

2020-11-09 Thread Aldy Hernandez via Gcc-patches
Yes, it was leftover from the original irange work years ago. Aldy On Mon, Nov 9, 2020 at 3:42 PM Andrew MacLeod wrote: > > On 11/9/20 9:38 AM, Aldy Hernandez wrote: > > Currently we have all the irange and range-op tests in range-op.cc. > > This patch splits them up into the appropriate file

[PATCH] Cleanup irange::set.

2020-11-09 Thread Aldy Hernandez via Gcc-patches
[This is actually part of a larger patch that actually changes behavior, but I thought I'd commit the non-invasive cleanups first which will simplify the upcoming work.] irange::set was doing more work than it should for legacy ranges. I cleaned up various unnecessary calls to

Re: [PATCH] Clean up irange self tests.

2020-11-09 Thread Andrew MacLeod via Gcc-patches
On 11/9/20 9:38 AM, Aldy Hernandez wrote: Currently we have all the irange and range-op tests in range-op.cc. This patch splits them up into the appropriate file (irange tests in value-range.cc and range-op tests in range-op.cc). The patch also splits up the tests themselves by functionality.

Re: [PATCH] aarch64: Do not alter force_reg returned register expanding fcmla

2020-11-09 Thread Andrea Corallo via Gcc-patches
Kyrylo Tkachov writes: >> -Original Message- >> From: Andrea Corallo >> Sent: 09 November 2020 10:04 >> To: gcc-patches@gcc.gnu.org >> Cc: Kyrylo Tkachov ; Richard Earnshaw >> ; nd >> Subject: [PATCH] aarch64: Do not alter force_reg returned register >> expanding fcmla >> >> Hi all,

[PATCH] Clean up irange self tests.

2020-11-09 Thread Aldy Hernandez via Gcc-patches
Currently we have all the irange and range-op tests in range-op.cc. This patch splits them up into the appropriate file (irange tests in value-range.cc and range-op tests in range-op.cc). The patch also splits up the tests themselves by functionality. It's not perfect, but significantly better

Re: [committed 1/2] libstdc++: Fix multiple definitions of std::exception_ptr functions [PR 97729]

2020-11-09 Thread Jonathan Wakely via Gcc-patches
On 05/11/20 18:03 +, Jonathan Wakely wrote: This fixes some multiple definition errors caused by the changes for PR libstdc++/90295. The previous solution for inlining the members of std::exception_ptr but still exporting them from the library was to suppress the 'inline' keyword on those

Re: [committed] libstdc++: Make std::function work better with -fno-rtti

2020-11-09 Thread Jonathan Wakely via Gcc-patches
On 29/10/20 14:49 +, Jonathan Wakely wrote: This change allows std::function::target() to work even without RTTI, using the same approach as std::any. Because we know what the manager function would be for a given type, we can check if the stored pointer has the expected address. If it does,

Re: [PATCH] analyzer: remove dead code

2020-11-09 Thread Martin Liška
PING^1 On 10/23/20 5:26 PM, Martin Liška wrote: Hey. I've noticed that when building GCC with Clang. David what do you think about it? Thanks, Martin gcc/analyzer/ChangeLog: * constraint-manager.cc (constraint_manager::merge): Remove unused code. * constraint-manager.h:

[PATCH] Prefer bit-test over the jump table.

2020-11-09 Thread Martin Liška
Hello. As mentioned in the PR, we used to prefer BT over JT in switch expansion. I restore the behavior to that. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: PR tree-optimization/97736 *

RE: [PATCH] aarch64: Do not alter force_reg returned register expanding fcmla

2020-11-09 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: 09 November 2020 10:04 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd > Subject: [PATCH] aarch64: Do not alter force_reg returned register > expanding fcmla > > Hi all, > > this patch is to fix a

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Uros Bizjak via Gcc-patches
On Mon, Nov 9, 2020 at 2:50 PM Hongyu Wang wrote: LGTM. Thanks, Uros. > > > > Please rewrite scan strings back to using double-quotation marks. > > > > Yes, updated patch. > > Uros Bizjak 于2020年11月9日周一 下午7:41写道: > > > > > On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > > > > > > Hi > >

[PATCH] tree-optimization/97746 - fix order of mask precision computes

2020-11-09 Thread Richard Biener
This fixes the order of walking PHIs and stmts for BB mask precision compute. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-11-09 Richard Biener PR tree-optimization/97746 * tree-vect-patterns.c (vect_determine_precisions): First walk PHIs. *

[PATCH] tree-optimization/97753 - fix SLP induction vect

2020-11-09 Thread Richard Biener
This fixes updating of the step vectors when filling up to group_size. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-11-09 Richard Biener PR tree-optimization/97753 * tree-vect-loop.c (vectorizable_induction): Fill vec_steps when CSEing inside the

Re: [04/32] cpp lexer

2020-11-09 Thread Nathan Sidwell
Jeff, here is an updated patch with changelog. I've added checking_asserts and comments for the state changes you were concerned about. While the __builtin_expects do make a change to generated code, you are probably right that they are not significant and I have removed them -- cpplib

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Hongyu Wang via Gcc-patches
> > Please rewrite scan strings back to using double-quotation marks. > Yes, updated patch. Uros Bizjak 于2020年11月9日周一 下午7:41写道: > > On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > > > > Hi > > > > According to the discussion in > >

Re: [PATCH][Arm] Auto-vectorization for MVE: vsub

2020-11-09 Thread Christophe Lyon via Gcc-patches
Hi, On Fri, 23 Oct 2020 at 10:02, Dennis Zhang via Gcc-patches wrote: > > Hi Kyrylo, > > > > > From: Kyrylo Tkachov > > Sent: Thursday, October 22, 2020 9:40 AM > > To: Dennis Zhang; gcc-patches@gcc.gnu.org > > Cc: nd; Richard Earnshaw; Ramana

Detect EAF flags in ipa-modref

2020-11-09 Thread Jan Hubicka
> > > > Yep, i am not arguing for eliminating special case of memcpy (because we > > have the additional info that it only copies pointers from *src to > > *dest). > > > > However I find current definition of EAF_NOESCAPE bit hard to handle in > > modref, since naturally it is quite reliable to

c++: ADL refactor

2020-11-09 Thread Nathan Sidwell
Jason, this might be relevant to using enum, not sure. This refactors the ADL lookup. It just so happens the refactoring makes dropping modules in simpler :) We break apart the namespace and class fn processing, and move scope iteration to an outer function. It'll also become possible to find

Re: [PATCH] 2/2 Remove debug/array

2020-11-09 Thread Jonathan Wakely via Gcc-patches
On 08/11/20 15:27 +0100, François Dumont via Libstdc++ wrote: Following a recent fix on std::array this test started to fail in _GLIBCXX_DEBUG mode. FAIL: 23_containers/array/comparison_operators/96851.cc (test for excess errors) Rather than fixing it and now that __glibcxx_assert is

[PATCH] Use a per-edge PRE PHI translation cache

2020-11-09 Thread Richard Biener
This changes the phi translation cache to be per edge which pushes it off the profiling radar. For larger testcases the combined hashtable causes a load of cache misses and making it per edge allows to shrink the entry further. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.

[PATCH] CSE VN_INFO calls in PRE and VN

2020-11-09 Thread Richard Biener
The following CSEs VN_INFO calls which nowadays are hashtable queries. Bootstrapped / tested on x86_64-unknown-linux-gnu, pushed. 2020-11-09 Richard Biener * tree-ssa-pre.c (get_representative_for): CSE VN_INFO calls. (create_expression_by_pieces): Likewise.

Re: [PATCH] 1/2 Make _GLIBCXX_DEBUG checks constexpr compatible

2020-11-09 Thread Jonathan Wakely via Gcc-patches
On 08/11/20 15:06 +0100, François Dumont via Libstdc++ wrote: Now that __glibcxx_assert is constexpr compatible we can do the same for the _GLIBCXX_DEBUG equivalent. I had also try to do the same on my own so this patch contains the string_view tests I had written when doing so. I plan to

Re: [pushed] Ada : Fix bootstrap after r11-4793.

2020-11-09 Thread Arnaud Charlet
> Iain, thank you for catching and fixing this. As you know (but > others don't), ada is harder for me as I can't build that on my > usual machine. > > Eric, Iain does bootstraps of the modules branch on darwin include > Ada, and I have done so for linux (a few months back). I will make > sure

Re: [pushed] Ada : Fix bootstrap after r11-4793.

2020-11-09 Thread Nathan Sidwell
On 11/7/20 4:10 AM, Iain Sandoe wrote: Hi The patch omitted a change for Ada, fixed thus. Iain, thank you for catching and fixing this. As you know (but others don't), ada is harder for me as I can't build that on my usual machine. Eric, Iain does bootstraps of the modules branch on

Re: Fix hashing of multiply and add

2020-11-09 Thread Richard Biener via Gcc-patches
On Mon, Nov 9, 2020 at 11:39 AM Jan Hubicka wrote: > > Hi, > I have noticed that hash_operand computes a hash value that is unused > since two is a local variable. This patch fixes it. > > Bootstrapped/regtested x86_64-linux, OK? OK. You can add DOT_PROD_EXPR to the mix (or handle

Re: [PATCH v2] Add if-chain to switch conversion pass.

2020-11-09 Thread Martin Liška
On 11/6/20 1:31 PM, Richard Biener wrote: On Fri, Oct 16, 2020 at 4:04 PM Martin Liška wrote: Hello. There's another version of the patch that should be based on what I discussed with Richi and Jakub: - the first patch introduces a new option -fbit-tests that analogue to -fjump-tables

Re: [Patch] x86: Enable GCC support for Intel AVX-VNNI extension

2020-11-09 Thread Uros Bizjak via Gcc-patches
On Mon, Nov 9, 2020 at 11:31 AM Hongtao Liu wrote: > > > > > + /* Support unified builtin. */ > > + || (mask2 == OPTION_MASK_ISA2_AVXVNNI) > > > > I don't think we gain anything with unified builtins. Better, just > > introduce separate builtins, e.g for > > > > Unified builtins are

Re: [PATCH][AArch64] Use intrinsics for upper saturating shift right

2020-11-09 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 5 Nov 2020 at 17:12, David Candler via Gcc-patches wrote: > > Hi Richard, > > Thanks for the feedback. > > Richard Sandiford writes: > > > diff --git a/gcc/config/aarch64/aarch64-builtins.c > > > b/gcc/config/aarch64/aarch64-builtins.c > > > index 4f33dd936c7..f93f4e29c89 100644 >

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Andreas Schwab
On Nov 09 2020, Hongyu Wang via Gcc-patches wrote: > diff --git a/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > b/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > index 8dd1bc634ac..c2bc7ea344d 100644 > --- a/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > +++

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Uros Bizjak via Gcc-patches
On Mon, Nov 9, 2020 at 12:47 PM Iain Sandoe wrote: > > Uros Bizjak via Gcc-patches wrote: > > > On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > >> Hi > >> > >> According to the discussion in > >> https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, > >> The testcase for keylocker-*

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Iain Sandoe via Gcc-patches
Uros Bizjak via Gcc-patches wrote: On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: Hi According to the discussion in https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, The testcase for keylocker-* is too strict for darwin target. This patch adjusted the regex, and add a missing

Re: [PATCH V2] arm: [testcase] Better narrow some bfloat16 testcase

2020-11-09 Thread Andrea Corallo via Gcc-patches
Kyrylo Tkachov writes: >> -Original Message- >> From: Andrea Corallo >> Sent: 09 November 2020 10:05 >> To: Christophe Lyon >> Cc: Kyrylo Tkachov ; gcc-patches@gcc.gnu.org; >> Richard Earnshaw ; nd >> Subject: Re: [PATCH V2] arm: [testcase] Better narrow some bfloat16 >> testcase >>

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Uros Bizjak via Gcc-patches
On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > > Hi > > According to the discussion in > https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, > The testcase for keylocker-* is too strict for darwin target. This > patch adjusted the regex, and add a missing test for aesenc256kl >

[Patch] Fortran: Fix OpenACC in specification-part checks [PR90111]

2020-11-09 Thread Tobias Burnus
OpenACC (as OpenMP) permits some directives in the 'specification part' In Fortran (here: Fortran 2018), the latter is: R504 specification-part is [use-stmt]... [import-stmt]... [implicit-part]

RE: [PATCH V2] arm: [testcase] Better narrow some bfloat16 testcase

2020-11-09 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: 09 November 2020 10:05 > To: Christophe Lyon > Cc: Kyrylo Tkachov ; gcc-patches@gcc.gnu.org; > Richard Earnshaw ; nd > Subject: Re: [PATCH V2] arm: [testcase] Better narrow some bfloat16 > testcase > > Christophe Lyon writes: >

Embedded Real-Time Operating Systems for the IoT Market Analysis: Here's the One Report That You Must Share With Your Management Team

2020-11-09 Thread garemwinmark via Gcc-patches
Hello Have a nice day ! This is JoJo from WMResearch. We recently published a new market research report: < Global Embedded Real-Time Operating Systems for the IoT Market Research Report 2015-2020>and kindly let us know if you are interested in it. If you are interested in getting more

[PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Hongyu Wang via Gcc-patches
Hi According to the discussion in https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, The testcase for keylocker-* is too strict for darwin target. This patch adjusted the regex, and add a missing test for aesenc256kl instruction. Tested by Iain Sandone and all get pass in darwin

Fix hashing of multiply and add

2020-11-09 Thread Jan Hubicka
Hi, I have noticed that hash_operand computes a hash value that is unused since two is a local variable. This patch fixes it. Bootstrapped/regtested x86_64-linux, OK? * fold-const.c (operand_compare::hash_operand): Fix hashing of operand 3 of multiply and add. diff --git

Re: [PATCH] Optimize macro: make it more predictable

2020-11-09 Thread Martin Liška
On 11/6/20 6:34 PM, Jeff Law wrote: So you XNEWVEC and store the result into "merge_decoded_options".  But you free "decoded_options".  Was that intentional? Hello. Good point here. This seems to bring a bit more predictability, but I suspect there's more to do here. Yes, both should

Re: [PATCH] Optimize macro: make it more predictable

2020-11-09 Thread Martin Liška
On 11/3/20 2:34 PM, Jakub Jelinek wrote: On Tue, Nov 03, 2020 at 02:27:52PM +0100, Richard Biener wrote: On Fri, Oct 23, 2020 at 1:47 PM Martin Liška wrote: This is a follow-up of the discussion that happened in thread about no_stack_protector attribute:

Re: [Patch] x86: Enable GCC support for Intel AVX-VNNI extension

2020-11-09 Thread Hongtao Liu via Gcc-patches
> > + /* Support unified builtin. */ > + || (mask2 == OPTION_MASK_ISA2_AVXVNNI) > > I don't think we gain anything with unified builtins. Better, just > introduce separate builtins, e.g for > Unified builtins are used for unified intrinsics, intrinsics users may prefer same interface

  1   2   >