Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Richard Biener via Gcc-patches
On Wed, Jan 20, 2021 at 5:25 PM Martin Liška wrote: > > On 1/20/21 5:00 PM, Jan Hubicka wrote: > > There are two thinks that I would like to discuss first > > 1) I think the option is stil used for value profiling of divisors > > It's not. Right now the only usage lives in get_nth_most_common_va

Re: [PATCH] [WIP] openmp: Add OpenMP 5.0 task detach clause support

2021-01-21 Thread Florian Weimer via Gcc-patches
* Jakub Jelinek: > Not all targets support GNU style function versioning where one can have > multiple symbol versions for the same symbol name, and I wanted to > avoid GOMP_task2, GOMP_task3 etc. Why? If it is about aesthetics, wouldn't compliance with language standards and ABI requirements be

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Martin Liška
On 1/20/21 11:39 PM, Jan Hubicka wrote: On 1/20/21 5:00 PM, Jan Hubicka wrote: There are two thinks that I would like to discuss first 1) I think the option is stil used for value profiling of divisors It's not. Right now the only usage lives in get_nth_most_common_value which is an entry p

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Martin Liška
On 1/21/21 9:25 AM, Richard Biener wrote: On Wed, Jan 20, 2021 at 5:25 PM Martin Liška wrote: On 1/20/21 5:00 PM, Jan Hubicka wrote: There are two thinks that I would like to discuss first 1) I think the option is stil used for value profiling of divisors It's not. Right now the only usa

RE: [PATCH] arm: [testuiste] fix ivopts.c target test [PR96372]

2021-01-21 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: 19 January 2021 17:13 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd ; > christophe.l...@linaro.org > Subject: [PATCH] arm: [testuiste] fix ivopts.c target test [PR96372] > > Hi all, > > this patch is fo

[PATCH] testsuite/98224 - un-XFAIL Walloca-2.c on ilp32

2021-01-21 Thread Richard Biener
As reported this now XPASSes with ranger. Tested on i?86-linux, pushed. 2021-01-21 Richard Biener * gcc.dg/Walloca-2.c: Un-XFAIL. --- gcc/testsuite/gcc.dg/Walloca-2.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gcc/testsuite/gcc.dg/Walloca-2.c b/gcc/tests

[PATCH] testsuite/98241 - remove ilp32 XFAIL of gcc.dg/pr78973.c

2021-01-21 Thread Richard Biener
XPASSes as reported. Pushed. 2021-01-21 Richard Biener PR testsuite/98241 * gcc.dg/pr78973.c: Remove ilp32 XFAIL. --- gcc/testsuite/gcc.dg/pr78973.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/pr78973.c b/gcc/testsuite/gcc.dg/pr789

Re: [Ada,FYI] revamp ada.numerics.aux

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Sebastian Huber wrote: > Which target properties determine that a-nallfl__wraplf.ads should be > used? The question really is what makes the default a-nallfl.ads unusable for a target. It works when the Ada type Long_Long_Float and the C long double type are nop-convertible. W

[PATCH] ipa: Fix resolving speculations through cgraph_edge::set_call_stmt (PR 98078)

2021-01-21 Thread Martin Jambor
Hi, in the PR 98078 testcase, speculative call-graph edges which were created by IPA-CP are confirmed during inlining but cgraph_edge::set_call_stmt does not take it very well. The function enters the update_speculative branch and updates the edges in the speculation bundle separately (by a recur

[PATCH] testsuite/97299 - more gcc.dg/vect/slp-reduc-3.c massaging

2021-01-21 Thread Richard Biener
This adds more guards to the VEC_PERM_EXPR scan, namely that we also could end up with load-lanes and of course no vectorization at all. Need dependent scans (scan-if-scan-X PASSed ...). Pushed. 2021-01-21 Richard Biener PR testsuite/97299 * gcc.dg/vect/slp-reduc-3.c: Amend t

[PATCH] RISC-V: Add implementation for builtin overflow

2021-01-21 Thread Levy
Added implementation for builtin overflow detection, new patterns are listed below. signed addition: add t0, t1, t2 sltit3, t2, 0 slt t4, t0, t1 bne t3, t4, overflow unsigned addition: add t0, t1, t2 bltut0, t1, overflow sig

Re: [PATCH v3] libgcc: Thumb-1 Floating-Point Library for Cortex M0

2021-01-21 Thread Christophe Lyon via Gcc-patches
On Sat, 16 Jan 2021 at 17:13, Daniel Engel wrote: > > Hi Christophe, > > On Fri, Jan 15, 2021, at 4:30 AM, Christophe Lyon wrote: > > On Fri, 15 Jan 2021 at 12:39, Daniel Engel wrote: > > > > > > Hi Christophe, > > > > > > On Mon, Jan 11, 2021, at 8:39 AM, Christophe Lyon wrote: > > > > On Mon, 1

Re: [PATCH] fwprop: Allow (subreg (mem)) simplifications

2021-01-21 Thread Richard Sandiford via Gcc-patches
Ilya Leoshkevich via Gcc-patches writes: > On Tue, 2021-01-19 at 09:41 +0100, Richard Biener wrote: >> On Mon, Jan 18, 2021 at 11:04 PM Ilya Leoshkevich via Gcc-patches >> wrote: >> > >> Suppose we have: >> > >> > (set (reg/v:TF 63) (mem/c:TF (reg/v:DI 62))) >> > (set (reg:FPRX2 66) (su

Re: [GCC9 backport] AArch64: Fix symbol offset limit (PR 98618)

2021-01-21 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra via Gcc-patches writes: > In aarch64_classify_symbol symbols are allowed large offsets on relocations. > This means the offset can use all of the +/-4GB offset, leaving no offset > available for the symbol itself. This results in relocation overflow and > link-time errors for simpl

Re: [PATCH] arm: [testuiste] fix ivopts.c target test [PR96372]

2021-01-21 Thread Andrea Corallo via Gcc-patches
Kyrylo Tkachov writes: >> -Original Message- >> From: Andrea Corallo >> Sent: 19 January 2021 17:13 >> To: gcc-patches@gcc.gnu.org >> Cc: Kyrylo Tkachov ; Richard Earnshaw >> ; nd ; >> christophe.l...@linaro.org >> Subject: [PATCH] arm: [testuiste] fix ivopts.c target test [PR96372] >>

RE: [PATCH] arm: [testuiste] fix ivopts.c target test [PR96372]

2021-01-21 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: 21 January 2021 11:13 > To: Kyrylo Tkachov > Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw > ; nd ; > christophe.l...@linaro.org > Subject: Re: [PATCH] arm: [testuiste] fix ivopts.c target test [PR96372] > > Kyrylo Tkachov writes: >

[AArch64] Remove backend support for widen-sub

2021-01-21 Thread Joel Hutton via Gcc-patches
Hi all, This patch removes support for the widening subtract operation in the aarch64 backend as it is causing a performance regression. In the following example: #include extern void wdiff( int16_t d[16], uint8_t *restrict pix1, uint8_t *restrict pix2) {    for( int y = 0; y < 4; y++ )   {

Re: [PATCH] fwprop: Allow (subreg (mem)) simplifications

2021-01-21 Thread Ilya Leoshkevich via Gcc-patches
On Thu, 2021-01-21 at 10:49 +, Richard Sandiford wrote: > Ilya Leoshkevich via Gcc-patches writes: > > On Tue, 2021-01-19 at 09:41 +0100, Richard Biener wrote: > > > On Mon, Jan 18, 2021 at 11:04 PM Ilya Leoshkevich via Gcc-patches > > > wrote: > > > Suppose we have: > > > > (set (reg/v:T

Re: [PATCH] fwprop: Allow (subreg (mem)) simplifications

2021-01-21 Thread Richard Sandiford via Gcc-patches
Ilya Leoshkevich writes: > On Thu, 2021-01-21 at 10:49 +, Richard Sandiford wrote: >> What prevents combine from handling this? Are the instructions in >> different blocks? > > I wanted to do this before combine, because in __ieee754_sqrtl case > fwprop turns this (example from the commit mes

[committed] libstdc++: Regenerate Makefile.in

2021-01-21 Thread Jonathan Wakely via Gcc-patches
This removes a trivial whitespace difference between the currently committed file and the one regenerated by autotools. libstdc++-v3/ChangeLog: * src/c++17/Makefile.in: Regenerate. Tested powerpc64le-linux. Committed to trunk. commit a1a967ce1ffe17cc6e6afaf76655314ab07a8de1 Author: Jona

Re: [PATCH v2] fwprop: Allow (subreg (mem)) simplifications

2021-01-21 Thread Richard Sandiford via Gcc-patches
Ilya Leoshkevich via Gcc-patches writes: > v1: https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563800.html > > v1 -> v2: Allow (mem) -> (subreg) propagation only for single uses. > > Boostrapped and regtested on x86_64-redhat-linux, ppc64le-redhat-linux > and s390x-redhat-linux. Ok for mas

[PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

2021-01-21 Thread Xing GUO via Gcc-patches
This patch fixes -march option parsing when `p` extension exists, e.g., -march=rv64imafdcp should produce .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c2p0_p" rather than .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c_p" --- gcc/ChangeLog: * common/config/riscv/riscv-common.c (risc

Re: [PATCH] libstdc++: implement locale support for AIX

2021-01-21 Thread CHIGOT, CLEMENT via Gcc-patches
Hi everyone,  Here is a new version of the patch. I've tested on Linux and AIX. There are still some tests failing but it starts having a good shape !  However, I have few questions: 1) locale.name and syscalls locale.name() is returning a string having the description of each locale category. It

c++: Stat-hack for members [PR 98530]

2021-01-21 Thread Nathan Sidwell
This was a header file that deployed the stat-hack inside a class (both a member-class and a [non-static data] member had the same name). Due to the way that's represented in name lookup we missed the class. Sadly just changing the representation globally has detrimental effects elsewhere, and

[GCC8 backport] AArch64: Fix symbol offset limit (PR 98618)

2021-01-21 Thread Wilco Dijkstra via Gcc-patches
In aarch64_classify_symbol symbols are allowed large offsets on relocations. This means the offset can use all of the +/-4GB offset, leaving no offset available for the symbol itself. This results in relocation overflow and link-time errors for simple expressions like &global_array + 0xff00.

Re: [AArch64] Remove backend support for widen-sub

2021-01-21 Thread Richard Biener via Gcc-patches
On Thu, Jan 21, 2021 at 12:37 PM Joel Hutton via Gcc-patches wrote: > > Hi all, > > This patch removes support for the widening subtract operation in the aarch64 > backend as it is causing a performance regression. > > In the following example: > > #include > extern void wdiff( int16_t d[16], ui

Re: [AArch64] Remove backend support for widen-sub

2021-01-21 Thread Richard Sandiford via Gcc-patches
Joel Hutton via Gcc-patches writes: > Hi all, > > This patch removes support for the widening subtract operation in the aarch64 > backend as it is causing a performance regression. > > In the following example: > > #include > extern void wdiff( int16_t d[16], uint8_t *restrict pix1, uint8_t *re

[Patch, committed] gcc/fortran/intrinsic.texi: Fix typo (was: gfortran online docs: small typo in RESULT_IMAGE description)

2021-01-21 Thread Tobias Burnus
On 21.01.21 13:22, Jorge D'Elia via Fortran wrote: A small typo in https://gcc.gnu.org/onlinedocs/gfortran/CO_005fREDUCE.html#CO_005fREDUCE Thanks for the report – I regarded it as (almost) patch and, hence, used you as author :-) Committed as r11-6835-g9be0a89c95cc30089786faa26b89e8d7444c87

Re: [AArch64] Remove backend support for widen-sub

2021-01-21 Thread Richard Biener
On Thu, 21 Jan 2021, Richard Sandiford wrote: > Joel Hutton via Gcc-patches writes: > > Hi all, > > > > This patch removes support for the widening subtract operation in the > > aarch64 backend as it is causing a performance regression. > > > > In the following example: > > > > #include > > ex

[PATCH] Fix typo in arm_mve.h __arm_vcmpneq_s8 return type

2021-01-21 Thread Christophe Lyon via Gcc-patches
Like all vcmp intrinsics, __arm_vcmpneq_s8 should return a mve_pred16_t. 2021-01-21 Christophe Lyon gcc/ * config/arm/arm_mve.h (__arm_vcmpneq_s8): Fix return type. --- gcc/config/arm/arm_mve.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/arm/

Re: [PATCH] arm: [testuiste] fix ivopts.c target test [PR96372]

2021-01-21 Thread Andrea Corallo via Gcc-patches
Kyrylo Tkachov writes: [...] > Ah ok, then it's fine to be consistent. > The patch is ok. > Thanks, > Kyrill Thanks, into master as 0568f801eff Andrea

RE: [PATCH] Fix typo in arm_mve.h __arm_vcmpneq_s8 return type

2021-01-21 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Gcc-patches On Behalf Of > Christophe Lyon via Gcc-patches > Sent: 21 January 2021 13:37 > To: gcc-patches@gcc.gnu.org > Subject: [PATCH] Fix typo in arm_mve.h __arm_vcmpneq_s8 return type > > Like all vcmp intrinsics, __arm_vcmpneq_s8 should return a mve_p

Re: [AArch64] Remove backend support for widen-sub

2021-01-21 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Thu, 21 Jan 2021, Richard Sandiford wrote: > >> Joel Hutton via Gcc-patches writes: >> > Hi all, >> > >> > This patch removes support for the widening subtract operation in the >> > aarch64 backend as it is causing a performance regression. >> > >> > In the following

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> On 1/21/21 9:25 AM, Richard Biener wrote: > > On Wed, Jan 20, 2021 at 5:25 PM Martin Liška wrote: > > > > > > On 1/20/21 5:00 PM, Jan Hubicka wrote: > > > > There are two thinks that I would like to discuss first > > > >1) I think the option is stil used for value profiling of divisors > >

Re: [PATCH][AVX512]Lower AVX512 vector compare to AVX version when dest is vector

2021-01-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 06, 2021 at 11:34:32AM +0800, Hongtao Liu via Gcc-patches wrote: > > >> > > >> Note there's a data dependency between them. insn 7 feeds insn 9. When > > >> there's a data dependency, combiner patterns are usually the better > > >> choice than peepholes. I think you'd be looking to m

Re: [PATCH] Fix typo in arm_mve.h __arm_vcmpneq_s8 return type

2021-01-21 Thread Christophe Lyon via Gcc-patches
On Thu, 21 Jan 2021 at 14:39, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Gcc-patches On Behalf Of > > Christophe Lyon via Gcc-patches > > Sent: 21 January 2021 13:37 > > To: gcc-patches@gcc.gnu.org > > Subject: [PATCH] Fix typo in arm_mve.h __arm_vcmpneq_s8 return type >

[committed] d: Enable private member access for __traits

2021-01-21 Thread Iain Buclaw via Gcc-patches
Hi, This patch merges the D front-end with upstream dmd 3a7ebef73. The following traits can now access non-public members: - hasMember - getMember - getOverloads - getVirtualMethods - getVirtualFuntions This fixes a long-standing issue in D where the allMembers trait would correctly return

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> > Plus I'm planning to send one more patch that will ignore time profile when > -fprofile-reproduce != serial. Why you need to disable time profiling? Honza

[PATCH] aarch64: Use canonical RTL for sqdmlal patterns

2021-01-21 Thread Kyrylo Tkachov via Gcc-patches
Hi all, The aarch64_sqdmll patterns are of the form: [(set (match_operand: 0 "register_operand" "=w") (SBINQOPS: (match_operand: 1 "register_operand" "0") (ss_ashift: (mult: (sign_extend: (match_operand:VSD_HSI 2 "re

Re: [AArch64] Remove backend support for widen-sub

2021-01-21 Thread Joel Hutton via Gcc-patches
> I think we should try to fix the PR instead. The widening operations > can only be used for SLP if the group_size is at least double the > number of elements in the vectype, so one idea (not worked through) > is to make the vect_build_slp_tree family of routines undo pattern > recognition for wi

RE: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2021-01-21 Thread Tamar Christina via Gcc-patches
Hi All, James and I have been investigating this regression and have tracked it down to register allocation. I have create a new PR with our findings https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98782 but unfortunately we don't know how to proceed. This does seem like a genuine bug in RA. It

Re: [PATCH] c++: Fix excessive instantiation inside decltype [PR71879]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/20/21 11:27 AM, Patrick Palka wrote: On Tue, 19 Jan 2021, Jason Merrill wrote: On 1/18/21 12:31 AM, Patrick Palka wrote: Here after resolving the address of a template-id inside decltype, we end up instantiating the chosen specialization from the call to mark_used in resolve_nondeduced_co

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2021-01-21 Thread Jan Hubicka
> Hi All, > > James and I have been investigating this regression and have tracked it down > to register allocation. > > I have create a new PR with our findings > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98782 but unfortunately > we don't know how to proceed. > > This does seem like a gen

Re: [PATCH] c++, v2: Fix up potential_constant_expression_1 FOR/WHILE_STMT handling [PR98672]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/19/21 4:54 PM, Jakub Jelinek wrote: On Tue, Jan 19, 2021 at 04:01:49PM -0500, Jason Merrill wrote: Hmm, IF_STMT probably also needs to check the else clause, if the condition isn't a known constant. You're right, I thought it was ok because it recurses with tf_none, but if the then branch

Re: [PATCH v3] c++: ICE with delayed noexcept and attribute used [PR97966]

2021-01-21 Thread Marek Polacek via Gcc-patches
On Thu, Jan 21, 2021 at 01:55:24AM -0500, Jason Merrill wrote: > > + /* Now that we've gone through all the members, instantiate those > > + marked with attribute used. */ > > + for (tree &x : used) > > This doesn't need to be a reference. And I think we want this to happen > even later, a

[PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Patrick Palka via Gcc-patches
Here at parse time finish_qualified_id_expr adds an implicit 'this->' to the expression tmp::integral (because it's type-dependent, and also current_class_ptr is set) within the trailing return type, and later during substitution we can't resolve the 'this' since tsubst_function_type does inject_th

Re: [PATCH] libstdc++: implement locale support for AIX

2021-01-21 Thread Rainer Orth
Hi Clement, > Here is a new version of the patch. I've tested on Linux and AIX. > There are still some tests failing but it starts having a good shape !  > However, I have few questions: > > 1) locale.name and syscalls just a terminology nit: none of those are syscalls. > 3) POSIX 2017 and non-P

Re: [PATCH] gimple UIDs, LTO and -fanalyzer [PR98599]

2021-01-21 Thread David Malcolm via Gcc-patches
On Thu, 2021-01-14 at 15:00 +0100, Jan Hubicka wrote: > > On Wed, Jan 13, 2021 at 11:04 PM David Malcolm via Gcc-patches > > wrote: > > > gimple.h has this comment for gimple's uid field: > > > > > > /* UID of this statement. This is used by passes that want to > > > assign IDs to stateme

[PATCH v3] fwprop: Allow (subreg (mem)) simplifications

2021-01-21 Thread Ilya Leoshkevich via Gcc-patches
On Thu, 2021-01-21 at 12:29 +, Richard Sandiford wrote: > Given what you said in the other message about combine, I agree this > is a reasonable workaround. I don't know whether it's suitable for > stage 4 or whether it would need to wait for stage 1. Thanks for reviewing! I've implemented y

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Patrick Palka via Gcc-patches
On Thu, 21 Jan 2021, Patrick Palka wrote: > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > the expression tmp::integral (because it's type-dependent, and also > current_class_ptr is set) within the trailing return type, and later > during substitution we can't resolve t

Re: [PATCH] improve warning suppression for inlined functions (PR 98465, 98512)

2021-01-21 Thread Florian Weimer via Gcc-patches
* Martin Sebor via Gcc-patches: > This patch depends on the fix for PR 98664 (already approved but > not yet checked in). I've tested it on x86_64-linux. > > To avoid fallout I tried to keep the changes to a minimum, and > so the design isn't as robust as I'd like it ultimately to be. > I plan to

Re: [PATCH v3] fwprop: Allow (subreg (mem)) simplifications

2021-01-21 Thread Richard Sandiford via Gcc-patches
Ilya Leoshkevich writes: > On Thu, 2021-01-21 at 12:29 +, Richard Sandiford wrote: >> Given what you said in the other message about combine, I agree this >> is a reasonable workaround. I don't know whether it's suitable for >> stage 4 or whether it would need to wait for stage 1. > > Thanks

Re: [GCC8 backport] AArch64: Fix symbol offset limit (PR 98618)

2021-01-21 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > In aarch64_classify_symbol symbols are allowed large offsets on relocations. > This means the offset can use all of the +/-4GB offset, leaving no offset > available for the symbol itself. This results in relocation overflow and > link-time errors for simple expressions li

Re: driver: do not check input file existence here [PR 98452]

2021-01-21 Thread Joseph Myers
On Wed, 20 Jan 2021, Nathan Sidwell wrote: > On 1/19/21 6:27 PM, Joseph Myers wrote: > > On Tue, 19 Jan 2021, Nathan Sidwell wrote: > > > > > Joseph, > > > I was relying on this patch on the modules branch, but didn't realize the > > > implications when merging and thought it was just a cleanup.

ping [PATCH] c++: fix string literal member initializer bug [PR90926]

2021-01-21 Thread Tom Greenslade (thomgree) via Gcc-patches
Ping for this patch: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562259.html -Original Message- From: Thomas Greenslade (thomgree) Sent: 17 December 2020 22:12 To: gcc-patches@gcc.gnu.org Subject: [PATCH] c++: fix string literal member initializer bug [PR90926] build_aggr_con

Re: [PATCH] improve warning suppression for inlined functions (PR 98465, 98512)

2021-01-21 Thread Martin Sebor via Gcc-patches
On 1/21/21 10:34 AM, Florian Weimer wrote: * Martin Sebor via Gcc-patches: This patch depends on the fix for PR 98664 (already approved but not yet checked in). I've tested it on x86_64-linux. To avoid fallout I tried to keep the changes to a minimum, and so the design isn't as robust as I'd

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Martin Liška
On 1/21/21 3:01 PM, Jan Hubicka wrote: Plus I'm planning to send one more patch that will ignore time profile when -fprofile-reproduce != serial. Why you need to disable time profiling? Because you can have 2 training runs (running in parallel) when order is: runA: foo -> bar runB: bar -> f

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Martin Liška
On 1/21/21 2:46 PM, Jan Hubicka wrote: I think easy way to get users of this option is to make profile not reproducible by default and modify packages to use right reproducibility option when reproducible builds are intended. It is not feature that comes for free and I think most users of PGO do

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> On 1/21/21 3:01 PM, Jan Hubicka wrote: > > > > > > Plus I'm planning to send one more patch that will ignore time profile > > > when -fprofile-reproduce != serial. > > > > Why you need to disable time profiling? > > Because you can have 2 training runs (running in parallel) when order is: > r

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Martin Liška
On 1/21/21 7:45 PM, Jan Hubicka wrote: For this reason we merge by computing average, which is stable over reordering the indices Looking at the implementation, we merge by using minimum value: /* Time profiles are merged so that minimum from all valid (greater than zero) is stored. The

[PATCH]Arm: Add NEON and MVE complex mul, mla and mls patterns.

2021-01-21 Thread Tamar Christina via Gcc-patches
Hi All, This adds implementation for the optabs for complex operations. With this the following C code: void g (float complex a[restrict N], float complex b[restrict N], float complex c[restrict N]) { for (int i=0; i < N; i++) c[i] = a[i] * b[i]; } generates NEON:

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> On 1/21/21 7:45 PM, Jan Hubicka wrote: > > For this reason we merge by computing average, which is stable over > > reordering the indices > > Looking at the implementation, we merge by using minimum value: > > /* Time profiles are merged so that minimum from all valid (greater than zero) >

Re: [PATCH] improve warning suppression for inlined functions (PR 98465, 98512)

2021-01-21 Thread Florian Weimer via Gcc-patches
* Martin Sebor: > On 1/21/21 10:34 AM, Florian Weimer wrote: >> * Martin Sebor via Gcc-patches: >> >>> This patch depends on the fix for PR 98664 (already approved but >>> not yet checked in). I've tested it on x86_64-linux. >>> >>> To avoid fallout I tried to keep the changes to a minimum, and

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c > index b401f0817a3..042c03d819e 100644 > --- a/gcc/cgraphunit.c > +++ b/gcc/cgraphunit.c > @@ -1961,8 +1961,9 @@ expand_all_functions (void) >} > >/* First output functions with time profile in specified order. */ > - qsort (tp_fir

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> > This will become more common problem for multithreaded profiles where > > one needs to annotate locking and busy waiting loops in them for example > > (or the scheduler responsible for executing paralle tasks). > > > > I can see this to be practically achievable but we probably want to > > pro

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Martin Liška
On 1/21/21 8:03 PM, Jan Hubicka wrote: What exactly is suggested? This one. Martin >From 22bbf5342f2b73fad6c0286541bba6699c617380 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 21 Jan 2021 09:02:31 +0100 Subject: [PATCH 1/2] Restore -fprofile-reproducibility flag. gcc/ChangeLog: PR

Re: [PATCH] gimple UIDs, LTO and -fanalyzer [PR98599]

2021-01-21 Thread Jan Hubicka
> On Thu, 2021-01-14 at 15:00 +0100, Jan Hubicka wrote: > > > On Wed, Jan 13, 2021 at 11:04 PM David Malcolm via Gcc-patches > > > wrote: > > > > gimple.h has this comment for gimple's uid field: > > > > > > > > /* UID of this statement. This is used by passes that want to > > > > assign

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Martin Liška
On 1/21/21 8:02 PM, Jan Hubicka wrote: diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c index b401f0817a3..042c03d819e 100644 --- a/gcc/cgraphunit.c +++ b/gcc/cgraphunit.c @@ -1961,8 +1961,9 @@ expand_all_functions (void) } /* First output functions with time profile in specified o

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> On 1/21/21 8:03 PM, Jan Hubicka wrote: > > What exactly is suggested? > > This one. > > Martin > From 22bbf5342f2b73fad6c0286541bba6699c617380 Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Thu, 21 Jan 2021 09:02:31 +0100 > Subject: [PATCH 1/2] Restore -fprofile-reproducibility flag. >

Re: [PATCH] Drop profile reproducibility flag as it is not used.

2021-01-21 Thread Jan Hubicka
> On 1/21/21 2:46 PM, Jan Hubicka wrote: > > I think easy way to get users of this option is to make profile not > > reproducible by default and modify packages to use right reproducibility > > option when reproducible builds are intended. It is not feature that > > comes for free and I think most

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-21 Thread Anthony Sharp via Gcc-patches
Hi Jason, I've finally completed my copyright assignment form. I've attached it to this email for reference. > You don't need write access to the main repository to use these commands > on your local copy. One nice thing about git compared to svn is that > you don't need to touch the server for

[PATCH] openmp: Fix intermittent hanging of task-detach-6 libgomp tests [PR98738]

2021-01-21 Thread Kwok Cheung Yeung
Hello This patch addresses the intermittent hanging seen in the libgomp.c-c++-common/task-detach-6.f90 test. The main problem is due to the 'omp taskwait' in the test. GOMP_taskwait can run tasks, so for correct semantics it needs to be able to place finished tasks that have unfulfilled comp

Re: [PATCH] gimple UIDs, LTO and -fanalyzer [PR98599]

2021-01-21 Thread David Malcolm via Gcc-patches
On Thu, 2021-01-21 at 20:09 +0100, Jan Hubicka wrote: > > On Thu, 2021-01-14 at 15:00 +0100, Jan Hubicka wrote: > > > > On Wed, Jan 13, 2021 at 11:04 PM David Malcolm via Gcc-patches > > > > wrote: > > > > > gimple.h has this comment for gimple's uid field: > > > > > > > > > > /* UID of this st

c++: Fix null this pointer [PR 98624]

2021-01-21 Thread Nathan Sidwell
One maynot usea null this pointer to invoke astatic member function. Thisfixes the remaining ubsan errors found with an ubsan bootstrap. PR c++/98624 gcc/cp/ * module.cc (depset::hash::find_dependencies): Add module arg. (trees_out::core_vals):Chec

Re: [PATCH v2] c++: ICE when mangling operator name [PR98545]

2021-01-21 Thread Marek Polacek via Gcc-patches
On Tue, Jan 19, 2021 at 05:38:20PM -0500, Marek Polacek via Gcc-patches wrote: > On Tue, Jan 19, 2021 at 03:47:47PM -0500, Jason Merrill via Gcc-patches wrote: > > On 1/13/21 6:39 PM, Marek Polacek wrote: > > > r11-6301 added some asserts in mangle.c, and now we trip over one of > > > them. In par

Re: driver: do not check input file existence here [PR 98452]

2021-01-21 Thread Nathan Sidwell
On 1/21/21 12:59 PM, Joseph Myers wrote: On Wed, 20 Jan 2021, Nathan Sidwell wrote: Unspecified non-existent response file: OLD: (1)devvm293:282>g++ -c @nothing g++: error: nothing: No such file or directory g++: fatal error: no input files compilation terminated. NEW: (1)devvm293:284>./xg+

Re: driver: do not check input file existence here [PR 98452]

2021-01-21 Thread Joseph Myers
On Thu, 21 Jan 2021, Nathan Sidwell wrote: > Do you want expandargv altered alongs the lines you mention? Or a bug filed? > [in order for my patch to be acceptable] The patch is OK as-is. Filing a bug for expandargv handling of missing files might be a good idea; it seems very arbitrary that @

Re: [PATCH] improve warning suppression for inlined functions (PR 98465, 98512)

2021-01-21 Thread Martin Sebor via Gcc-patches
On 1/21/21 12:01 PM, Florian Weimer wrote: * Martin Sebor: On 1/21/21 10:34 AM, Florian Weimer wrote: * Martin Sebor via Gcc-patches: This patch depends on the fix for PR 98664 (already approved but not yet checked in). I've tested it on x86_64-linux. To avoid fallout I tried to keep the c

Re: [PATCH v3] libgcc: Thumb-1 Floating-Point Library for Cortex M0

2021-01-21 Thread Daniel Engel
Hi Christophe, On Thu, Jan 21, 2021, at 2:29 AM, Christophe Lyon wrote: > On Sat, 16 Jan 2021 at 17:13, Daniel Engel wrote: > > > > Hi Christophe, > > > > On Fri, Jan 15, 2021, at 4:30 AM, Christophe Lyon wrote: > > > On Fri, 15 Jan 2021 at 12:39, Daniel Engel wrote: > > > > > > > > Hi Christoph

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Marek Polacek via Gcc-patches
On Thu, Jan 21, 2021 at 11:22:24AM -0500, Patrick Palka via Gcc-patches wrote: > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > the expression tmp::integral (because it's type-dependent, and also > current_class_ptr is set) within the trailing return type, and later > du

follow SSA defs for asan base

2021-01-21 Thread Alexandre Oliva
Ada makes extensive use of nested functions, which turn all automatic variables of the enclosing function that are used in nested ones into members of an artificial FRAME record type. The address of a local variable is usually passed to asan marking functions without using a temporary. Taking t

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Jakub Jelinek via Gcc-patches
On Thu, Jan 21, 2021 at 06:30:06PM -0300, Alexandre Oliva wrote: > > GNAT may create temporaries to hold return values of function calls. > If such a temporary is created as part of a dynamic initializer of a > variable in a unit other than the one being compiled, the initializer > is dropped, inc

skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
GNAT may create temporaries to hold return values of function calls. If such a temporary is created as part of a dynamic initializer of a variable in a unit other than the one being compiled, the initializer is dropped, including the temporary and its binding block. Don't issue asan mark calls f

Re: [BACKPORT] Apply fix for PR libgcc/97643 to gcc 10 branch

2021-01-21 Thread Segher Boessenkool
On Wed, Jan 20, 2021 at 08:28:57PM -0500, Michael Meissner wrote: > On Wed, Jan 20, 2021 at 06:46:14PM -0600, Segher Boessenkool wrote: > > Is there a reason we do not have that testcase in the testsuite, btw? > > In order to test it you need to build a compiler + toolchain where the default > lon

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-21 Thread Segher Boessenkool
Hi! What is holding up this patch still? Ke Wen has pinged it every month since May, and there has still not been a review. Segher On Thu, May 28, 2020 at 08:19:59PM +0800, Kewen.Lin wrote: > > gcc/ChangeLog > > 2020-MM-DD Kewen Lin > > * cfgloop.h (struct loop): New field estimat

[PATCH] document BLOCK_ABSTRACT_ORIGIN et al.

2021-01-21 Thread Martin Sebor via Gcc-patches
On 1/18/21 6:25 AM, Richard Biener wrote: PS Here are my notes on the macros and the two related functions: BLOCK: Denotes a lexical scope. Contains BLOCK_VARS of variables declared in it, BLOCK_SUBBLOCKS of scopes nested in it, and BLOCK_CHAIN pointing to the next BLOCK. Its BLOCK_SUPERCONTEX

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Jakub Jelinek wrote: > Does that affect only Ada and not other languages? I haven't observed it on other languages, but I didn't try really hard. Doing that now, with an assert that the newly-added condition doesn't ever hit. I'd already completed a bootstrap-asan the other day

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Patrick Palka via Gcc-patches
On Thu, 21 Jan 2021, Marek Polacek wrote: > On Thu, Jan 21, 2021 at 11:22:24AM -0500, Patrick Palka via Gcc-patches wrote: > > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > > the expression tmp::integral (because it's type-dependent, and also > > current_class_ptr is s

Re: [PATCH] c++: ICE when mangling operator name [PR98545]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/19/21 5:38 PM, Marek Polacek wrote: On Tue, Jan 19, 2021 at 03:47:47PM -0500, Jason Merrill via Gcc-patches wrote: On 1/13/21 6:39 PM, Marek Polacek wrote: r11-6301 added some asserts in mangle.c, and now we trip over one of them. In particular, it's the one asserting that we didn't get I

Re: [PATCH v2] c++: ICE when mangling operator name [PR98545]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/21/21 2:44 PM, Marek Polacek wrote: On Tue, Jan 19, 2021 at 05:38:20PM -0500, Marek Polacek via Gcc-patches wrote: On Tue, Jan 19, 2021 at 03:47:47PM -0500, Jason Merrill via Gcc-patches wrote: On 1/13/21 6:39 PM, Marek Polacek wrote: r11-6301 added some asserts in mangle.c, and now we tr

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Alexandre Oliva wrote: > But I was wrong. The bootstrap with the added assert has just failed, > as early as stage2 libiberty. Looking into it... Uhh, I take that back. I just goofed in the assert, inverting the condition. Long day... With the correct condition, it's got pa

[PATCH] c++: ICE with noexcept in class in member function [PR96623]

2021-01-21 Thread Marek Polacek via Gcc-patches
I discovered very strange code in inject_parm_decls: if (args && is_this_parameter (args)) { gcc_checking_assert (current_class_ptr == NULL_TREE); current_class_ptr = NULL_TREE; We are tripping up on the assert because when we call inject_parm_decls, current_class_ptr is set

Re: [PATCH] openmp: Fix intermittent hanging of task-detach-6 libgomp tests [PR98738]

2021-01-21 Thread Kwok Cheung Yeung
On 21/01/2021 7:33 pm, Kwok Cheung Yeung wrote: With Nvidia and GCN offloading though, task-detach-6 hangs... I _think_ the reason why it 'worked' before was because the taskwait allowed tasks with detach clauses to always complete immediately after execution. Since that backdoor has been close

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/21/21 2:28 PM, Anthony Sharp wrote: Hi Jason, I've finally completed my copyright assignment form. I've attached it to this email for reference. You don't need write access to the main repository to use these commands on your local copy. One nice thing about git compared to svn is that y

Re: [PATCH v3] c++: ICE with delayed noexcept and attribute used [PR97966]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/21/21 10:39 AM, Marek Polacek wrote: On Thu, Jan 21, 2021 at 01:55:24AM -0500, Jason Merrill wrote: + /* Now that we've gone through all the members, instantiate those + marked with attribute used. */ + for (tree &x : used) This doesn't need to be a reference. And I think we want

Re: [PATCH v6] Practical improvement to libgcc complex divide

2021-01-21 Thread Joseph Myers
On Fri, 18 Dec 2020, Patrick McGehearty via Gcc-patches wrote: > TEST Data I'd still like to see the test data / code used to produce the accuracy and performance results made available somewhere (presumably with a link then being provided in the commit message). > + if ((mode == TYPE_MO

[committed] LRA: patch fixing PR98777

2021-01-21 Thread Vladimir Makarov via Gcc-patches
The following patch fixes recently reported https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98777 The patch was successfully bootstrapped on x86-64. [PR98777] LRA: Use preliminary created pseudo for in LRA elimination subpass LRA did not extend ira_reg_equiv after generation of a pseudo in elimi

Re: [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:01:57PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555754.html > > On Thu, Oct 08, 2020 at 09:27:55AM +1030, Alan Modra wrote: > > * config/rs6000/rs6000.c (rs6000_rtx_costs): Tidy AND code. > > Don't avoid rec

Re: [PATCH 4/8] [RS6000] rs6000_rtx_costs tidy break/return

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:02:09PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555755.html > > On Thu, Oct 08, 2020 at 09:27:56AM +1030, Alan Modra wrote: > > Most cases use "return false" rather than breaking out of the switch. > > Do so in all

Re: [PATCH 5/8] [RS6000] rs6000_rtx_costs cost IOR

2021-01-21 Thread Alan Modra via Gcc-patches
Ping. On Tue, Jan 12, 2021 at 02:02:18PM +1030, Alan Modra wrote: > Ping > https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555756.html > > On Thu, Oct 08, 2020 at 09:27:57AM +1030, Alan Modra wrote: > > * config/rs6000/rs6000.c (rotate_insert_cost): New function. > > (rs6000_rtx_co

  1   2   >