Re: [PATCH] c++: Implement -Wuninitialized for mem-initializers (redux) [PR19808]

On 11/5/21 19:22, Marek Polacek wrote: 2021 update: Last year I posted a version of this patch: but it didn't make it in. The main objection seemed to be that the patch tried to do too much, and overlapped with the ME

Re: [PATCH 2/2] Fortran: Fix memory leak in gfc_add_include_path [PR68800]

On Sat, 6 Nov 2021 20:22:53 +0100 Harald Anlauf wrote: > Hi Bernhard, > > I cannot comment on the gcc/ parts, but > > > diff --git a/gcc/fortran/cpp.c b/gcc/fortran/cpp.c > > index e86386c8b17..04fe8fe460b 100644 > > --- a/gcc/fortran/cpp.c > > +++ b/gcc/fortran/cpp.c > > @@ -728,12 +728,20

Re: Some PINGs

On 11/6/2021 4:20 PM, Roger Sayle wrote: Simplify paradoxical subreg extensions of TRUNCATE https://gcc.gnu.org/pipermail/gcc-patches/2021-September/578848.html So the discussion seemed to end with a recommendation to try and address this earlier in the call chain rather than in

[PATCH] c++: designated init of char array by string constant [PR55227]

This patch aims to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55227. There are two underlying bugs in the designated initialization of char array fields by string literals that cause: (1) Rejection of valid cases with: (a) brace-enclosed string literal initializer (of any valid size), or

Re: [PATCH,FORTRAN] Fix memory leak in finalization wrappers

On Sat, 6 Nov 2021 13:04:07 +0100 Mikael Morin wrote: > Le 05/11/2021 à 23:08, Bernhard Reutner-Fischer a écrit : > > On Fri, 5 Nov 2021 19:46:16 +0100 > > Mikael Morin wrote: > > > >> Le 29/10/2021 à 01:58, Bernhard Reutner-Fischer via Fortran a écrit : > >>> On Wed, 27 Oct 2021 23:39:43

Fix can_be_discarded_p wrt partitioned functions

Hi, can_be_discarded_p is testing DECL_EXTERNAL flag to see if the symbol can be discarded by linker if unreachable. This is meant to catch extern inline functions (which is bit side case and it is intded to avoid gcc from producing new references to them if there were no refernces before) but it

Some PINGs

I wonder if reviewers could take a look (or a second look) at some of my outstanding patches. Four nvptx backend patches: nvptx: Use cvt to perform sign-extension of truncation. https://gcc.gnu.org/pipermail/gcc-patches/2021-August/578256.html nvptx: Add (experimental) support for HFmode with

Re: [PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

On Sat, 6 Nov 2021 15:29:57 -0400 Jason Merrill wrote: > On 11/6/21 14:28, Marek Polacek wrote: > > On Sat, Nov 06, 2021 at 02:32:26AM +0100, Bernhard Reutner-Fischer wrote: > > No, I want q to point into the copy of the string, since I'm about > > to modify it. And I'd prefer a single call

[PATCH] aarch64: [PR101529] Fix vector shuffle insertion expansion

From: Andrew Pinski The function aarch64_evpc_ins would reuse the target even though it might be the same register as the two inputs. Instead of checking to see if we can reuse the target, creating a new register always is better. OK? Bootstrapped and tested on aarch64-linux-gnu with no

Re: [PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

On 11/6/21 14:28, Marek Polacek wrote: On Sat, Nov 06, 2021 at 02:32:26AM +0100, Bernhard Reutner-Fischer wrote: On 6 November 2021 01:21:43 CET, Marek Polacek via Gcc-patches wrote: Thanks, so like this? I'm including an incremental diff so that it's clear what changed: diff --git

Re: [PATCH 2/2] Fortran: Fix memory leak in gfc_add_include_path [PR68800]

Hi Bernhard, I cannot comment on the gcc/ parts, but Am 05.11.21 um 22:17 schrieb Bernhard Reutner-Fischer via Gcc-patches: From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: PR fortran/68800 * cpp.h (gfc_cpp_free_cpp_dirs): New declaration. * cpp.c

Re: [PATCH] PR fortran/91497 -- Silence conversion warnings for MIN1 and MAX1

Hi Manfred, looks good to me. Thanks for the patch! Best regards Thomas

Re: [PATCH v5] attribs: Implement -Wno-attributes=vendor::attr [PR101940]

On Sat, Nov 06, 2021 at 02:32:26AM +0100, Bernhard Reutner-Fischer wrote: > On 6 November 2021 01:21:43 CET, Marek Polacek via Gcc-patches > wrote: > > > > >Thanks, so like this? I'm including an incremental diff so that it's > >clear what changed: > > > >diff --git a/gcc/attribs.c

Re: [PATCH] Add debug counters to back threader.

On Tue, Nov 2, 2021 at 3:13 PM Richard Biener wrote: > > On Tue, Nov 2, 2021 at 2:36 PM Aldy Hernandez wrote: > > > > On Tue, Nov 2, 2021 at 2:27 PM Richard Biener > > wrote: > > > > > > On Mon, Nov 1, 2021 at 2:03 PM Jeff Law via Gcc-patches > > > wrote: > > > > > > > > > > > > > > > > On

[PATCH] Fix vsx_splat_v4si in 32 bit mode

powerpc: Fix vsx_splat_v4si in 32 bit mode Tamar's recent patch to teach CSE to perform vector extract exercises VSX splat more frequently, which exposed a constraint error for the vsx_splat patterns. The pattern could be created for Power9, but the "we constraint only

Re: [PATCH] PR fortran/91497 -- Silence conversion warnings for MIN1 and MAX1

Am 02.11.21 um 19:39 schrieb Thomas Koenig: > On 02.11.21 15:22, Manfred Schwarb wrote: >> Am 02.11.21 um 14:26 schrieb Thomas Koenig: >>> Hi Manfred, >>> In addition to the patches of Steve Kargl for PR 91497: The MIN1 and MAX1 intrinsics do explicit type conversions and should be

[COMMITTED] path oracle: Do not look at root oracle for killed defs.

[This is more Andrew's domain, but this is a P1 PR and I'd like to unbreak the SPEC run, since this is a straigthforward fix. When he returns he can double check my work and give additional suggestions.] The problem here is that we are incorrectly threading 41->20->21 here: [local count:

Re: [PATH][_GLIBCXX_DEBUG] Fix unordered container merge

You were right to delay your reply. Here is a new version with less code duplication and a bug fix in the new _UContMergeGuard where we were using it->second rather than it->first to get the key. Note also that the change to _M_merge_multi implementation is also important because otherwise we

Re: [PATCH,FORTRAN] Fix memory leak in finalization wrappers

Sorry, I hadn’t seen your message. Le 05/11/2021 à 23:08, Bernhard Reutner-Fischer a écrit : On Fri, 5 Nov 2021 19:46:16 +0100 Mikael Morin wrote: Le 29/10/2021 à 01:58, Bernhard Reutner-Fischer via Fortran a écrit : On Wed, 27 Oct 2021 23:39:43 +0200 Bernhard Reutner-Fischer wrote:

Re: [PATCH,FORTRAN] Fix memory leak in finalization wrappers

Le 05/11/2021 à 19:46, Mikael Morin a écrit : Don’t you get the same effect on the memory leaks if you keep just the following hunk? >>> @@ -1605,8 +1608,7 @@ generate_finalization_wrapper (gfc_symbol *derived, gfc_namespace *ns, >>> /* Set up the namespace.  */ >>> sub_ns =

Re: [PATCH] Fortran: Diagnose all operands/arguments with constraint violations

Le 05/11/2021 à 03:58, Sandra Loosemore a écrit : This is an expanded version of the patch for PR 101337 that Bernhard sent out a few days ago with a request for me to finish it.  Bernhard did the part for operands and I added the pieces for procedure arguments and intrinsics, along with

Re: [PATCH] PR fortran/102715 - [12 Regression] ICE in gfc_simplify_transpose, at fortran/simplify.c:8184

Le 31/10/2021 à 22:35, Harald Anlauf via Fortran a écrit : Dear Fortranners, the fix for initialization of DT arrays caused an apparent regression for cases where inconsistent ranks were used in such an initialization. This caused either an ICE in subsequent uses of these arrays, or showed up

Re: [PATCH] c++, dyninit: Optimize C++ dynamic initialization by constants into DECL_INITIAL adjustment [PR102876]

On Fri, Nov 05, 2021 at 11:06:44AM -0600, Martin Sebor wrote: > In my work-in-progress patch to diagnose stores into constant > objects (and subobjects) I deal with the same problem. I had > considered a pair of markers like those above (David Malcolm > suggested a smilar approach as well), but

Re: [PATCH v1 5/7] LoongArch Port: libgomp

On Sat, 2021-11-06 at 16:40 +0800, Chenghua Xu wrote: > From: chenglulu > > libgomp/ > > * configure.tgt: Add LoongArch tuple. "tuple" should be "triplet". -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University

Re: Values of WIDE_INT_MAX_ELTS in gcc11 and gcc12 are different

On Fri, Nov 05, 2021 at 05:37:25PM +, Qing Zhao wrote: > > On Nov 5, 2021, at 11:17 AM, Jakub Jelinek wrote: > > > > On Fri, Nov 05, 2021 at 04:11:36PM +, Qing Zhao wrote: > >> 3076 if (TREE_CODE (TREE_TYPE (lhs)) != BOOLEAN_TYPE > >> 3077 && tree_fits_uhwi_p (var_size) >

Re: [PATCH v1 6/7] LoongArch Port: gcc/testsuite

On Sat, 2021-11-06 at 16:40 +0800, Chenghua Xu wrote: > diff --git a/gcc/testsuite/gcc.dg/20020312-2.c > b/gcc/testsuite/gcc.dg/20020312-2.c > index 52c33d09b90..2e35d443a1d 100644 > --- a/gcc/testsuite/gcc.dg/20020312-2.c > +++ b/gcc/testsuite/gcc.dg/20020312-2.c > @@ -49,6 +49,8 @@ extern void

Re: [PATCH v1 3/7] LoongArch Port: libgcc

On Sat, 2021-11-06 at 16:40 +0800, Chenghua Xu wrote: /* snip */ > diff --git a/libgcc/config/loongarch/crti.S b/libgcc/config/loongarch/crti.S > new file mode 100644 > index 000..bac029874b5 > --- /dev/null > +++ b/libgcc/config/loongarch/crti.S > @@ -0,0 +1,43 @@ > +/* Copyright (C)

Re: [PATCH v1 0/7] Add LoongArch support.

On Sat, 2021-11-06 at 16:40 +0800, Chenghua Xu wrote: > > This is a series of patch sets to support LoongArch. > > The LoongArch architecture (LoongArch) is an Instruction Set > Architecture (ISA) that has a Reduced Instruction Set Computer (RISC) > style. > The documents are on >

Re: [committed] Fortran: Add more documentation for mixed-language programming

Hi Sandra, Looks good to me. Thanks Paul On Fri, 5 Nov 2021 at 21:13, Sandra Loosemore wrote: > I was recently pinged about PR35276. It's an old issue, but a couple of > the concerns raised there haven't been fixed yet, so I've checked in > this patch to fill in the gaps. > > -Sandra >

[PATCH v1 7/7] LoongArch Port: Regenerate configure

From: chenglulu * config/picflag.m4: Default add build option '-fpic' for LoongArch. * configure: Add LoongArch tuples. * configure.ac: Like wise. --- config/picflag.m4 | 3 +++ configure | 12 +++- configure.ac | 10 +- 3 files changed, 23

[PATCH v1 6/7] LoongArch Port: gcc/testsuite

From: chenglulu gcc/testsuite/ * g++.dg/cpp0x/constexpr-rom.C: Add build options for LoongArch. * g++.old-deja/g++.abi/ptrmem.C: Add LoongArch support. * g++.old-deja/g++.pt/ptrmem6.C: xfail for LoongArch. * gcc.dg/20020312-2.c: Add LoongArch support. *

[PATCH v1 5/7] LoongArch Port: libgomp

From: chenglulu libgomp/ * configure.tgt: Add LoongArch tuple. --- libgomp/configure.tgt | 4 1 file changed, 4 insertions(+) diff --git a/libgomp/configure.tgt b/libgomp/configure.tgt index d4f1e741b5a..2cd7272fcd8 100644 --- a/libgomp/configure.tgt +++ b/libgomp/configure.tgt

[PATCH v1 4/7] LoongArch Port: Regenerate libgcc/configure.

From: chenglulu --- libgcc/configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libgcc/configure b/libgcc/configure index 4919a56f518..150ea04cb3d 100755 --- a/libgcc/configure +++ b/libgcc/configure @@ -5066,7 +5066,7 @@ $as_echo "$libgcc_cv_cfi" >&6; } # word size

[PATCH v1 3/7] LoongArch Port: libgcc

From: chenglulu libgcc/ * config/loongarch/crtfastmath.c: New file. * config/loongarch/crti.S: Like wise. * config/loongarch/crtn.S: Like wise. * config/loongarch/lib2funcs.c: Like wise. * config/loongarch/linux-unwind.h: Like wise. *

[PATCH v1 2/7] LoongArch Port: Regenerate gcc/configure.

From: chenglulu --- gcc/configure | 63 ++- 1 file changed, 57 insertions(+), 6 deletions(-) diff --git a/gcc/configure b/gcc/configure index 920868bcd33..5044fc27e42 100755 --- a/gcc/configure +++ b/gcc/configure @@ -7759,6 +7759,9 @@ else

[PATCH v1 0/7] Add LoongArch support.

This is a series of patch sets to support LoongArch. The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a Reduced Instruction Set Computer (RISC) style. The documents are on https://loongson.github.io/LoongArch-Documentation/README-EN.html The ELF ABI

Re: [PATCH] Add TSVC tests.

Hello. Sorry for issue related to portability. On 11/6/21 03:45, David Edelsohn wrote: I just noticed that Iain adjusted the tsvc.h for Darwin in the same way that I need to adjust it for AIX. Are we trying to keep the testcase directory pristine and in sync with its upstream source or can we