Re: [PATCH] [i386] Optimize a ^ ((a ^ b) & mask) to (~mask & a) | (b & mask).

2022-01-12 Thread Uros Bizjak via Gcc-patches
On Thu, Jan 13, 2022 at 2:53 AM Jiang, Haochen wrote: > > Hi Uros, > > Has fixed that format issue with this new patch. Ok for trunk? The patch was already approved in my previous message, so no need to re-approve it. I'm sure you are able to move one brace to a new position without another

Re: [PATCH] [i386] GLC tuning: Break false dependency for dest register.

2022-01-12 Thread Uros Bizjak via Gcc-patches
On Thu, Jan 13, 2022 at 8:28 AM Hongyu Wang wrote: > > From: wwwhhhyyy > > Hi, > > For GoldenCove micro-architecture, force insert zero-idiom in asm > template to break false dependency of dest register for several insns. > > The related insns are: > > VPERM/D/Q/PS/PD > VRANGEPD/PS/SD/SS >

[PATCH] [i386] GLC tuning: Break false dependency for dest register.

2022-01-12 Thread Hongyu Wang via Gcc-patches
From: wwwhhhyyy Hi, For GoldenCove micro-architecture, force insert zero-idiom in asm template to break false dependency of dest register for several insns. The related insns are: VPERM/D/Q/PS/PD VRANGEPD/PS/SD/SS VGETMANTSS/SD/SH VGETMANDPS/PD - mem version only VPMULLQ VFMULCSH/PH

Re: [PATCH] rs6000: Fix constraint v with rs6000_constraints[RS6000_CONSTRAINT_v]

2022-01-12 Thread Kewen.Lin via Gcc-patches
on 2022/1/13 上午11:44, David Edelsohn wrote: > On Wed, Jan 12, 2022 at 10:38 PM Kewen.Lin wrote: >> >> Hi David, >> >> on 2022/1/13 上午11:07, David Edelsohn wrote: >>> On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin wrote: Hi, This patch is to fix register constraint v with

Re: [PATCH] rs6000: Fix constraint v with rs6000_constraints[RS6000_CONSTRAINT_v]

2022-01-12 Thread David Edelsohn via Gcc-patches
On Wed, Jan 12, 2022 at 10:38 PM Kewen.Lin wrote: > > Hi David, > > on 2022/1/13 上午11:07, David Edelsohn wrote: > > On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin wrote: > >> > >> Hi, > >> > >> This patch is to fix register constraint v with > >> rs6000_constraints[RS6000_CONSTRAINT_v] instead of

Re: [PATCH] rs6000: Fix constraint v with rs6000_constraints[RS6000_CONSTRAINT_v]

2022-01-12 Thread Kewen.Lin via Gcc-patches
Hi David, on 2022/1/13 上午11:07, David Edelsohn wrote: > On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin wrote: >> >> Hi, >> >> This patch is to fix register constraint v with >> rs6000_constraints[RS6000_CONSTRAINT_v] instead of ALTIVEC_REGS, >> just like some other existing register constraints with

Re: [PATCH] rs6000: Use known constant for GET_MODE_NUNITS and similar

2022-01-12 Thread David Edelsohn via Gcc-patches
On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin wrote: > > Hi, > > This patch is to clean up some codes with GET_MODE_UNIT_SIZE or > GET_MODE_NUNITS, which can use known constant instead. I'll let Segher decide, but often the additional code is useful self-documentation instead of magic constants. Or

Re: [PATCH] rs6000: Fix constraint v with rs6000_constraints[RS6000_CONSTRAINT_v]

2022-01-12 Thread David Edelsohn via Gcc-patches
On Wed, Jan 12, 2022 at 8:56 PM Kewen.Lin wrote: > > Hi, > > This patch is to fix register constraint v with > rs6000_constraints[RS6000_CONSTRAINT_v] instead of ALTIVEC_REGS, > just like some other existing register constraints with > RS6000_CONSTRAINT_*. > > I happened to see this and hope it's

PING^1 [PATCH] rs6000: Don't turn off VSX for P9 VECTOR when TARGET_AVOID_XFORM set

2022-01-12 Thread Kewen.Lin via Gcc-patches
Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587449.html on 2021/12/29 下午5:36, Kewen.Lin via Gcc-patches wrote: > Hi, > > When TARGET_AVOID_XFORM is set, we turn off VSX. But at least from > ISA3.0 (Power9), we support DQ form vector load/store. This patch > is to make

PING^1 [PATCH] rs6000: Move the hunk affecting VSX/ALTIVEC ahead [PR103627]

2022-01-12 Thread Kewen.Lin via Gcc-patches
Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587311.html on 2021/12/23 上午10:12, Kewen.Lin via Gcc-patches wrote: > Hi, > > There is one hunk checking for functions with target attribute/pragma > have the same altivec abi as the one of main_target_opt, it can update >

PING^1 [PATCH] rs6000: Disable MMA if no P9 VECTOR support [PR103627]

2022-01-12 Thread Kewen.Lin via Gcc-patches
Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587310.html on 2021/12/23 上午10:09, Kewen.Lin via Gcc-patches wrote: > Hi, > > As PR103627 shows, there is an unexpected case where !TARGET_VSX > and TARGET_MMA co-exist. As ISA3.1 claims, SIMD is a requirement > for MMA. By

PING^1 [PATCH] rs6000: Fix an assertion in update_target_cost_per_stmt [PR103702]

2022-01-12 Thread Kewen.Lin via Gcc-patches
Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587309.html on 2021/12/23 上午10:06, Kewen.Lin via Gcc-patches wrote: > Hi, > > This patch is to fix one wrong assertion which is too aggressive. > Vectorizer can do vec_construct costing for the vector type which > only has

[PATCH] rs6000: Use known constant for GET_MODE_NUNITS and similar

2022-01-12 Thread Kewen.Lin via Gcc-patches
Hi, This patch is to clean up some codes with GET_MODE_UNIT_SIZE or GET_MODE_NUNITS, which can use known constant instead. Bootstrapped and regtested on powerpc64le-linux-gnu P9 and powerpc64-linux-gnu P8. Is it ok for trunk? BR, Kewen - gcc/ChangeLog: * config/rs6000/altivec.md

[PATCH] rs6000: Fix constraint v with rs6000_constraints[RS6000_CONSTRAINT_v]

2022-01-12 Thread Kewen.Lin via Gcc-patches
Hi, This patch is to fix register constraint v with rs6000_constraints[RS6000_CONSTRAINT_v] instead of ALTIVEC_REGS, just like some other existing register constraints with RS6000_CONSTRAINT_*. I happened to see this and hope it's not intentional and just got neglected. Bootstrapped and

Re: [PATCH, rs6000] Enable absolute jump table by default

2022-01-12 Thread David Edelsohn via Gcc-patches
On Wed, Jan 12, 2022 at 8:40 PM HAO CHEN GUI wrote: > > Hi David, > > On 12/1/2022 下午 10:44, David Edelsohn wrote: > > On Wed, Jan 12, 2022 at 7:22 AM HAO CHEN GUI wrote: > >> > >> Hi, > >>This patch enables absolute jump table by default on rs6000. The > >> relative jump tables are used

RE: [PATCH] [i386] Optimize a ^ ((a ^ b) & mask) to (~mask & a) | (b & mask).

2022-01-12 Thread Jiang, Haochen via Gcc-patches
Hi Uros, Has fixed that format issue with this new patch. Ok for trunk? Thx, Haochen -Original Message- From: Uros Bizjak Sent: Thursday, January 13, 2022 3:22 AM To: Jiang, Haochen Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao Subject: Re: [PATCH] [i386] Optimize a ^ ((a ^ b) & mask)

[PATCH 2/2] Add assumption combining iv

2022-01-12 Thread Jiufu Guo via Gcc-patches
This is the second patch for two IVs combining. When one IV is chasing another one, to make it safe, we should check if there is wrap/overflow for either IV. With the assumption, which computed as this patch, the number of iterations can be caculated, even the no_overflow flag is not updated for

[PATCH 1/2] Check negative combined step

2022-01-12 Thread Jiufu Guo via Gcc-patches
Hi, Previously, there is discussion in: https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586460.html I seperate it as two patches. This first patch is to avoid negative step when combining two ivs. The second patch is adding more accurate assumptions. This patch pass bootstrap and

[Patch][V4][Patch 2/2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables.

2022-01-12 Thread Qing Zhao via Gcc-patches
Hi, Richard, This is the updated version for the second patch, which is mainly the change for "Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables”. In this update, I mainly made the following change: 1. Delete “repl_var”, use the var_def_stmt, i.e, the call to

Re: [PATCH, rs6000] Enable absolute jump table by default

2022-01-12 Thread HAO CHEN GUI via Gcc-patches
Hi David, On 12/1/2022 下午 10:44, David Edelsohn wrote: > On Wed, Jan 12, 2022 at 7:22 AM HAO CHEN GUI wrote: >> >> Hi, >>This patch enables absolute jump table by default on rs6000. The relative >> jump tables are used when >>it's explicit set by "rs6000_relative_jumptables", >>or

RE: [PATCH] [i386] Optimize a ^ ((a ^ b) & mask) to (~mask & a) | (b & mask).

2022-01-12 Thread Jiang, Haochen via Gcc-patches
Hi Uros, I have also tested on -m32. They do not fail. Thx, Haochen -Original Message- From: Uros Bizjak Sent: Thursday, January 13, 2022 3:22 AM To: Jiang, Haochen Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao Subject: Re: [PATCH] [i386] Optimize a ^ ((a ^ b) & mask) to (~mask & a) |

[PATCH] PR fortran/67804 - ICE on data initialization of type(character) with wrong data

2022-01-12 Thread Harald Anlauf via Gcc-patches
Dear Fortranners, the attached patch improves error recovery after an invalid structure constructor has been detected in a DATA statement. Testcase by Gerhard. Regtested on x86_64-pc-linux-gnu. OK for mainline? This should be a rather safe patch which I would like to backport to 11-branch

[PATCH] testsuite: Compile g++.dg/vect/slp-pr98855.cc only for x86 targets [PR103935]

2022-01-12 Thread Uros Bizjak via Gcc-patches
The testcase is x86 specific, other targets have different costs defined. 2022-01-12 Uroš Bizjak gcc/testsuite/ChangeLog: PR target/103935 * g++.dg/vect/slp-pr98855.cc: Compile only for x86 targets. Tested on x86_64-linux-gnu {,-m32}. Pushed to master. Uros. diff --git

Re: [PATCH] [i386] Optimize a ^ ((a ^ b) & mask) to (~mask & a) | (b & mask).

2022-01-12 Thread Uros Bizjak via Gcc-patches
On Wed, Jan 12, 2022 at 9:11 AM Haochen Jiang wrote: > > Hi all, > > This patch targets PR94790, which change the instruction selection under the > following circumstance. > > Regtested on x86_64-pc-linux-gnu. Ok for trunk? Please also test with -m32, e.g.: make -j 12 -k check

Re: [PATCH] x86_64: Improvements to arithmetic right shifts of V1TImode values.

2022-01-12 Thread Uros Bizjak via Gcc-patches
On Tue, Jan 11, 2022 at 2:26 PM Roger Sayle wrote: > > > This patch to the i386 backend's ix86_expand_v1ti_ashiftrt provides > improved (shorter) implementations of V1TI mode arithmetic right shifts > for constant amounts between 111 and 126 bits. The significance of > this range is that this

[PATCH] i386: Add CC clobber and splits for 32-bit vector mode logic insns [PR100673, PR103861]

2022-01-12 Thread Uros Bizjak via Gcc-patches
Add CC clobber to 32-bit vector mode logic insns to allow variants with general-purpose registers. Also improve ix86_sse_movcc to emit insn with CC clobber for narrow vector modes in order to re-enable conditional moves for 16-bit and 32-bit narrow vector modes with -msse2. 2022-01-12 Uroš

[PATCH] rs6000: Convert built-in constraints to form

2022-01-12 Thread Bill Schmidt via Gcc-patches
Hi! When introducing the new built-in support, I tried to match as many existing error messages as possible. One common form was "argument X must be a Y-bit unsigned literal". Another was "argument X must be a literal between X' and Y', inclusive". During reviews, Segher requested that I

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Koning, Paul via Gcc-patches
> On Jan 12, 2022, at 1:13 PM, Hans-Peter Nilsson via Gcc-patches > wrote: > >> ... > I recall comments about code quality regressions. Are there > actual numbers? (Preferably from around the transition > time, because I bet targets still supporting "-mlra" have > regressed on the reload

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Maciej W. Rozycki
On Wed, 12 Jan 2022, Richard Biener via Gcc-patches wrote: > > So in theory it might be just pulling the switch for some? That is, > > removing their definition of TARGET_LRA_P which then defaults > > to true? > > I can confirm it works for visium which builds after such change and > can

Re: [PATCH v5 1/1] [ARM] Add support for TLS register based stack protector canary access

2022-01-12 Thread Ard Biesheuvel via Gcc-patches
On Wed, 17 Nov 2021 at 18:12, Ard Biesheuvel wrote: > > (+ Ramana) > Ping? > On Mon, 15 Nov 2021 at 19:04, Ard Biesheuvel wrote: > > > > Add support for accessing the stack canary value via the TLS register, > > so that multiple threads running in the same address space can use > > distinct

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jeff Law via Gcc-patches > Date: Wed, 12 Jan 2022 16:58:50 +0100 > On 1/12/2022 8:00 AM, Richard Biener wrote: > > On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov > > wrote: > >> > >> On 2022-01-12 03:47, Richard Biener wrote: > >>> On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jeff Law via Gcc-patches > Date: Wed, 12 Jan 2022 16:58:50 +0100 > On 1/12/2022 8:00 AM, Richard Biener wrote: > > On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov > > wrote: > >> > >> On 2022-01-12 03:47, Richard Biener wrote: > >>> On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via

[PATCH] Use system default for long double if not specified on PowerPC.

2022-01-12 Thread Michael Meissner via Gcc-patches
Use system default for long double if not specified on PowerPC. If the user did not specify a default long double format, use the long double default for the build compiler for the long double default. This patch will allow compilers built on a distribution that has changed the 128-bit floating

Re: [PATCH] Allow other languages to change long double format on PowerPC

2022-01-12 Thread Michael Meissner via Gcc-patches
On Wed, Jan 12, 2022 at 06:50:04PM +0100, Jakub Jelinek wrote: > On Wed, Jan 12, 2022 at 12:46:16PM -0500, Michael Meissner via Gcc-patches > wrote: > > Allow other languages to change long double format on PowerPC. > > > > With Fortran adding support for changing the long double format, this >

Re: [PATCH] Allow other languages to change long double format on PowerPC

2022-01-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 12, 2022 at 12:46:16PM -0500, Michael Meissner via Gcc-patches wrote: > Allow other languages to change long double format on PowerPC. > > With Fortran adding support for changing the long double format, this > patch removes the code that only allowed C/C++ to change the long double

[PATCH] Allow other languages to change long double format on PowerPC

2022-01-12 Thread Michael Meissner via Gcc-patches
Allow other languages to change long double format on PowerPC. With Fortran adding support for changing the long double format, this patch removes the code that only allowed C/C++ to change the long double format for GLIBC 2.32 and later without a warning. I have bootstraped the compiler with

Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-12 Thread Martin Sebor via Gcc-patches
On 1/12/22 02:02, Martin Liška wrote: Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for rs6000 target. Ready to be installed? Thanks, Martin gcc/ChangeLog: *

[committed] libstdc++: Add explicit dg-do directive to .../103955.cc

2022-01-12 Thread Patrick Palka via Gcc-patches
libstdc++-v3/ChangeLog: * testsuite/20_util/to_chars/103955.cc: Add explicit dg-do directive. --- libstdc++-v3/testsuite/20_util/to_chars/103955.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/libstdc++-v3/testsuite/20_util/to_chars/103955.cc

Re: [PATCH] Fix -Wformat-diag for s390x target.

2022-01-12 Thread Martin Sebor via Gcc-patches
On 1/12/22 02:03, Martin Liška wrote: Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for s390x target. Ready to be installed? Thanks, Martin gcc/ChangeLog: *

Re: [Patch][V2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2022-01-12 Thread Qing Zhao via Gcc-patches
> On Jan 12, 2022, at 4:46 AM, Richard Biener > wrote: > > On Tue, Jan 11, 2022 at 5:32 PM Qing Zhao wrote: >> > + /* Ignore the call to .DEFERRED_INIT that define the original > +var itself. */ > + if (is_gimple_assign (context)) > + {

Re: [PATCH] epiphany: fix -Wimplicit-fallthrough warnings in epiphany.c.

2022-01-12 Thread Jeff Law via Gcc-patches
On 1/12/2022 2:56 AM, Martin Liška wrote: This is RFC. Cheers, Martin gcc/ChangeLog: * config/epiphany/epiphany.c (epiphany_mode_priority): Use gcc_unreachable for not handled cases. OK.  As are similar changes in other ports. jeff

Re: [PATCH] epiphany: fir -Wformat-diag.

2022-01-12 Thread Jeff Law via Gcc-patches
On 1/12/2022 2:57 AM, Martin Liška wrote: This fixes -Wformat-diag warnings. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/epiphany/epiphany.c (epiphany_handle_interrupt_attribute): Use %qs format specifier. (epiphany_override_options): Wrap keyword in %<, %>.

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Jeff Law via Gcc-patches
On 1/12/2022 8:00 AM, Richard Biener wrote: On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov wrote: On 2022-01-12 03:47, Richard Biener wrote: On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches wrote: On 2022-01-11 12:42, Richard Sandiford wrote: The new IRA heuristics

Re: [PATCH] Fix redefined macro for epiphany.

2022-01-12 Thread Jeff Law via Gcc-patches
On 1/12/2022 7:56 AM, Richard Biener wrote: On Wed, Jan 12, 2022 at 3:23 PM Jeff Law via Gcc-patches wrote: On 1/12/2022 2:47 AM, Martin Liška wrote: The following warning is emitted gazillion times. Fixes: In file included from ./tm.h:23, from gcc/genconfig.c:25:

[PATCH] git-backport: support renamed .cc files in commit message.

2022-01-12 Thread Martin Liška
Hi. There's a patch that enhances git-backport so that it updates commit messages for files which name ends now with .cc and is still .c on a branch. Example usage: $ git show test commit 8ed4b2cb9aa158c0ef418fd1ac66271664904604 (test) Author: Martin Liska Date: Wed Jan 12 16:08:13 2022

Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-12 Thread Martin Sebor via Gcc-patches
On 1/12/22 02:02, Martin Liška wrote: Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for rs6000 target. Ready to be installed? Thanks, Martin gcc/ChangeLog: *

Re: PING^2 (C/C++): Re: [PATCH 6/6] Add __attribute__ ((tainted))

2022-01-12 Thread David Malcolm via Gcc-patches
On Tue, 2022-01-11 at 23:36 -0500, Jason Merrill wrote: > On 1/10/22 16:36, David Malcolm via Gcc-patches wrote: > > On Thu, 2022-01-06 at 09:08 -0500, David Malcolm wrote: > > > On Sat, 2021-11-13 at 15:37 -0500, David Malcolm wrote: > > > > This patch adds a new __attribute__ ((tainted)) to the

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 4:00 PM Richard Biener wrote: > > On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov wrote: > > > > > > On 2022-01-12 03:47, Richard Biener wrote: > > > On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches > > > wrote: > > >> > > >> On 2022-01-11 12:42, Richard

[committed] analyzer: complain about tainted sizes with "access" attribute [PR103940]

2022-01-12 Thread David Malcolm via Gcc-patches
GCC 10 gained the "access" function and type attribute, which optionally can take a size-index param: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html -fanalyzer in trunk (for GCC 12) has gained a -Wanalyzer-tainted-size to complain about attacker-controlled size values, but

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 3:26 PM Vladimir Makarov wrote: > > > On 2022-01-12 03:47, Richard Biener wrote: > > On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches > > wrote: > >> > >> On 2022-01-11 12:42, Richard Sandiford wrote: > >>> The new IRA heuristics would need more work on

[committed][nvptx] Add gcc.target/nvptx/atomic-exchange-*.c test-cases

2022-01-12 Thread Tom de Vries via Gcc-patches
Hi, Add a few test-cases that test expansion of __atomic_exchange. Tested on nvptx. Committed to trunk. Thanks, - Tom [nvptx] Add gcc.target/nvptx/atomic-exchange-*.c test-cases gcc/testsuite/ChangeLog: 2022-01-12 Tom de Vries * gcc.target/nvptx/atomic-exchange-1.c: New test.

[committed][nvptx] Improve gcc.target/nvptx/atomic_fetch-*.c test-cases

2022-01-12 Thread Tom de Vries via Gcc-patches
Hi, Fix a few issues in test-cases gcc.target/nvptx/atomic_fetch-*.c: - atomic_fetch-1.c uses scan-assembler instead of scan-assembler-times, which is less accurate - atomic_fetch-2.c only contains negative testing using scan-assembler-not - the test-cases use stack variables to generate

Re: [PATCH] Fix redefined macro for epiphany.

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 3:23 PM Jeff Law via Gcc-patches wrote: > > > > On 1/12/2022 2:47 AM, Martin Liška wrote: > > The following warning is emitted gazillion times. > > > > Fixes: > > > > In file included from ./tm.h:23, > > from gcc/genconfig.c:25: > > gcc/config/elfos.h:209:

[PATCH] tree-optimization/103990 - fix CFG cleanup regression from PRE change

2022-01-12 Thread Richard Biener via Gcc-patches
This adjusts the CFG cleanup flow back to what it was before the last change which fixes the observed regression of 541.leela_r with LTO and FDO. Boostrapped on x86_64-unknown-linux-gnu, testing in progress. 2022-01-12 Richard Biener PR tree-optimization/103990 * tree-pass.h

Re: [PATCH, rs6000] Enable absolute jump table by default

2022-01-12 Thread David Edelsohn via Gcc-patches
On Wed, Jan 12, 2022 at 7:22 AM HAO CHEN GUI wrote: > > Hi, >This patch enables absolute jump table by default on rs6000. The relative > jump tables are used when >it's explicit set by "rs6000_relative_jumptables", >or jump tables are placed in text section but global relocation is

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Andre Vieira (lists) via Gcc-patches
On 12/01/2022 12:57, Richard Biener wrote: On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: On 12/01/2022 11:59, Richard Biener wrote: On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: On 12/01/2022 11:44, Richard Sandiford wrote: Another alternative would be to push

Re: [PATCH] ira: Fix old-reload targets [PR103974]

2022-01-12 Thread Vladimir Makarov via Gcc-patches
On 2022-01-12 03:47, Richard Biener wrote: On Tue, Jan 11, 2022 at 7:41 PM Vladimir Makarov via Gcc-patches wrote: On 2022-01-11 12:42, Richard Sandiford wrote: The new IRA heuristics would need more work on old-reload targets, since flattening needs to be able to undo the cost

Re: [PATCH] Fix redefined macro for epiphany.

2022-01-12 Thread Jeff Law via Gcc-patches
On 1/12/2022 2:47 AM, Martin Liška wrote: The following warning is emitted gazillion times. Fixes: In file included from ./tm.h:23, from gcc/genconfig.c:25: gcc/config/elfos.h:209: warning: "READONLY_DATA_SECTION_ASM_OP" redefined   209 | #define

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Bill Schmidt via Gcc-patches
I think we need a fix or a revert for this today, please.  Bootstrap has been broken for a couple of days during the last week of stage 3, which is really problematic. Thanks, Bill On 1/12/22 6:57 AM, Richard Biener via Gcc-patches wrote: > On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > >>

Re: [PATCH v2][GCC] arm: Add support for dwarf debug directives and pseudo hard-register for PAC feature.

2022-01-12 Thread Srinath Parvathaneni via Gcc-patches
Ping!! From: Srinath Parvathaneni Sent: 13 December 2021 10:44 To: gcc-patches@gcc.gnu.org Cc: Kyrylo Tkachov ; Richard Earnshaw ; Tejas Belagod Subject: Re: [PATCH v2][GCC] arm: Add support for dwarf debug directives and pseudo hard-register for PAC feature.

Re: [PATCH] [12/11/10] Fix invalid format warnings on Windows

2022-01-12 Thread Tomas Kalibera via Gcc-patches
On 1/11/22 2:37 PM, Martin Liška wrote: Hello. I do support the patch, but I would ... Thanks, Martin,  that makes the patch simpler and easier to maintain. Would the attached version do? Thanks Tomas On 1/7/22 19:33, Tomas Kalibera wrote: +  if (is_attribute_p ("format", 

[PATCH] Fix -Wformat-diag for s390x-ibm-tpf.

2022-01-12 Thread Martin Liška
This one is related to s390x-ibm-tpf -Wformat-diag warnings. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/s390/s390.c: Fix -Wformat-diag warnings. --- gcc/config/s390/s390.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] Fix -Wformat-diag for ARM target.

2022-01-12 Thread Martin Liška
Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for ARM target. Ready to be installed? Thanks, Martin gcc/ChangeLog: * common/config/arm/arm-common.c

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > > On 12/01/2022 11:59, Richard Biener wrote: > > On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > > > >> On 12/01/2022 11:44, Richard Sandiford wrote: > >>> Another alternative would be to push autodetected_vector_mode when the > >>> length is

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Andre Vieira (lists) via Gcc-patches
On 12/01/2022 11:59, Richard Biener wrote: On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: On 12/01/2022 11:44, Richard Sandiford wrote: Another alternative would be to push autodetected_vector_mode when the length is 1 and keep 1 as the starting point. Richard I'm guessing we would still

[PATCH, rs6000] Enable absolute jump table by default

2022-01-12 Thread HAO CHEN GUI via Gcc-patches
Hi, This patch enables absolute jump table by default on rs6000. The relative jump tables are used when it's explicit set by "rs6000_relative_jumptables", or jump tables are placed in text section but global relocation is required. Bootstrapped and tested on powerpc64-linux BE and LE

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > > On 12/01/2022 11:44, Richard Sandiford wrote: > > Another alternative would be to push autodetected_vector_mode when the > > length is 1 and keep 1 as the starting point. > > > > Richard > > I'm guessing we would still want to skip epilogue

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jan 2022, Richard Sandiford wrote: > Richard Biener writes: > > On Wed, 12 Jan 2022, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > On Wed, 12 Jan 2022, Richard Sandiford wrote: > >> > > >> >> Richard Biener writes: > >> >> > On Wed, 12 Jan 2022, Richard Sandiford

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Andre Vieira (lists) via Gcc-patches
On 12/01/2022 11:44, Richard Sandiford wrote: Another alternative would be to push autodetected_vector_mode when the length is 1 and keep 1 as the starting point. Richard I'm guessing we would still want to skip epilogue vectorization if !VECTOR_MODE_P (autodetected_vector_mode) in that

Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs

2022-01-12 Thread FX via Gcc-patches
> Thanks. Just a nit, it is cc1 that reports the warning, not f951. I confirm the patch fixes the testcase failure. And I fixed the comment in a follow-up commit. Thanks! FX

Re: [PATCH] opts: do not do sanity check when an error is seen

2022-01-12 Thread Martin Liška
On 12/16/21 17:44, Jeff Law wrote: On 12/16/2021 7:37 AM, Martin Liška wrote: Do not check global options modification when an error is seen in parsing of options (pragmas or attributes). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks,

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Wed, 12 Jan 2022, Richard Sandiford wrote: > >> Richard Biener writes: >> > On Wed, 12 Jan 2022, Richard Sandiford wrote: >> > >> >> Richard Biener writes: >> >> > On Wed, 12 Jan 2022, Richard Sandiford wrote: >> >> > >> >> >> Richard Biener writes: >> >> >> > On

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jan 2022, Richard Sandiford wrote: > Richard Biener writes: > > On Wed, 12 Jan 2022, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > On Wed, 12 Jan 2022, Richard Sandiford wrote: > >> > > >> >> Richard Biener writes: > >> >> > On Wed, 12 Jan 2022, Andre Vieira

Re: [PATCH] Fix -Wformat-diag for aarch64 target.

2022-01-12 Thread Richard Earnshaw via Gcc-patches
On 12/01/2022 09:02, Martin Liška wrote: Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for aarch64 target. Ready to be installed? Thanks, Martin OK. R.

Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs

2022-01-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 12, 2022 at 12:03:40PM +0100, FX wrote: > > We need -fintrinsic-modules-path option for the signalling_1.f90 compilation > > but need to make sure it isn't used when the *.c file is compiled, so they > > need to be compiled by separate compiler invocations probably. > > Thanks for

Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs

2022-01-12 Thread FX via Gcc-patches
Hi Jakub, > We need -fintrinsic-modules-path option for the signalling_1.f90 compilation > but need to make sure it isn't used when the *.c file is compiled, so they > need to be compiled by separate compiler invocations probably. Thanks for posting the errors! So I wasn’t seeing it because I

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Wed, 12 Jan 2022, Richard Sandiford wrote: > >> Richard Biener writes: >> > On Wed, 12 Jan 2022, Richard Sandiford wrote: >> > >> >> Richard Biener writes: >> >> > On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: >> >> > >> >> >> Hi, >> >> >> >> >> >> This a fix for

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jan 2022, Richard Sandiford wrote: > Richard Biener writes: > > On Wed, 12 Jan 2022, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > >> > > >> >> Hi, > >> >> > >> >> This a fix for the regression caused by '[vect]

Re: [Patch][V2]Enable -Wuninitialized + -ftrivial-auto-var-init for address taken variables

2022-01-12 Thread Richard Biener via Gcc-patches
On Tue, Jan 11, 2022 at 5:32 PM Qing Zhao wrote: > > Hi, Richard, > > > On Jan 11, 2022, at 7:43 AM, Richard Biener > > wrote: > > > > > 1. Add some meaningful temporaries to break the long expression to make > it > Readable. And also add comments to explain the

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Wed, 12 Jan 2022, Richard Sandiford wrote: > >> Richard Biener writes: >> > On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: >> > >> >> Hi, >> >> >> >> This a fix for the regression caused by '[vect] Re-analyze all modes for >> >> epilogues'. The earlier patch

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jan 2022, Richard Sandiford wrote: > Richard Biener writes: > > On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > > > >> Hi, > >> > >> This a fix for the regression caused by '[vect] Re-analyze all modes for > >> epilogues'. The earlier patch assumed there was always at least one

Re: [PATCH] Fix redefined macro for epiphany.

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 11:10 AM Martin Liška wrote: > > On 1/12/22 11:03, Richard Biener wrote: > > tm_file in config.gcc? (${tm_file} first, before elfos.h) > > Heh, yes, that's the case. The following patch fixes that. OK if the target builds with that. > May I install it? > Cheers, >

Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs

2022-01-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 12, 2022 at 11:23:43AM +0100, FX via Gcc-patches wrote: > I can confirm that I don’t see this failure on a Debian bullseye/sid (Linux > 5.11.0-46, glibc 2.31-0ubuntu9.2) with a fresh bootstrap of master: > > $ grep signaling testsuite/gfortran/gfortran.sum > PASS:

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > >> Hi, >> >> This a fix for the regression caused by '[vect] Re-analyze all modes for >> epilogues'. The earlier patch assumed there was always at least one other >> mode >> than VOIDmode, but that does not need to be

Re: [vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jan 2022, Andre Vieira (lists) wrote: > Hi, > > This a fix for the regression caused by '[vect] Re-analyze all modes for > epilogues'. The earlier patch assumed there was always at least one other mode > than VOIDmode, but that does not need to be the case. > If we are dealing with a

Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs

2022-01-12 Thread FX via Gcc-patches
Hi, I can confirm that I don’t see this failure on a Debian bullseye/sid (Linux 5.11.0-46, glibc 2.31-0ubuntu9.2) with a fresh bootstrap of master: $ grep signaling testsuite/gfortran/gfortran.sum PASS: gfortran.dg/ieee/signaling_1.f90 -O0 (test for excess errors) PASS:

Re: [patch] Fix reverse SSO issues in IPA-SRA

2022-01-12 Thread Martin Jambor
Hi, On Wed, Jan 12 2022, Eric Botcazou wrote: >> Thanks for the fixes, the forgotten duplication and streaming were quite >> embarrassing, but one reason is that there are few reverse SSO testcases >> in the suite. Would it be difficult to add some covering the issues you >> fixed? > > No, I

[vect] PR103971, PR103977: Fix epilogue mode selection for autodetect only

2022-01-12 Thread Andre Vieira (lists) via Gcc-patches
Hi, This a fix for the regression caused by '[vect] Re-analyze all modes for epilogues'. The earlier patch assumed there was always at least one other mode than VOIDmode, but that does not need to be the case. If we are dealing with a target that does not define more modes for

Re: [PATCH] Fix redefined macro for epiphany.

2022-01-12 Thread Martin Liška
On 1/12/22 11:03, Richard Biener wrote: tm_file in config.gcc? (${tm_file} first, before elfos.h) Heh, yes, that's the case. The following patch fixes that. May I install it? Cheers, MartinFrom 14fa27ba17cf9aa1a971ae93f8a5ef6aa857c67e Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Wed,

Re: [PATCH] Fix redefined macro for epiphany.

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 10:47 AM Martin Liška wrote: > > The following warning is emitted gazillion times. > > Fixes: > > In file included from ./tm.h:23, > from gcc/genconfig.c:25: > gcc/config/elfos.h:209: warning: "READONLY_DATA_SECTION_ASM_OP" redefined >209 | #define

Re: [PATCH] epiphany: fix -Wimplicit-fallthrough warnings in epiphany.c.

2022-01-12 Thread Martin Liška
On 1/12/22 10:56, Martin Liška wrote: This fixes -Wformat-diag warnings. Ready to be installed? Thanks, Martin Please forget about this email, it's a dup. Martin

[PATCH] epiphany: fir -Wformat-diag.

2022-01-12 Thread Martin Liška
This fixes -Wformat-diag warnings. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/epiphany/epiphany.c (epiphany_handle_interrupt_attribute): Use %qs format specifier. (epiphany_override_options): Wrap keyword in %<, %>. --- gcc/config/epiphany/epiphany.c

[PATCH] epiphany: fix -Wimplicit-fallthrough warnings in epiphany.c.

2022-01-12 Thread Martin Liška
This fixes -Wformat-diag warnings. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/epiphany/epiphany.c (epiphany_mode_priority): Use gcc_unreachable for not handled cases. --- gcc/config/epiphany/epiphany.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] epiphany: fix -Wimplicit-fallthrough warnings in epiphany.c.

2022-01-12 Thread Martin Liška
This is RFC. Cheers, Martin gcc/ChangeLog: * config/epiphany/epiphany.c (epiphany_mode_priority): Use gcc_unreachable for not handled cases. --- gcc/config/epiphany/epiphany.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/config/epiphany/epiphany.c

Re: [PATCH] Fix -Wformat-diag for s390x target.

2022-01-12 Thread Richard Biener via Gcc-patches
On Wed, Jan 12, 2022 at 10:05 AM Martin Liška wrote: > > Hello. > > We've got -Wformat-diag for some time and I think we should start using it > in -Werror for GCC bootstrap. The following patch removes last pieces of the > warning > for s390x target. > > Ready to be installed? > Thanks, >

[PATCH] Fix redefined macro for epiphany.

2022-01-12 Thread Martin Liška
The following warning is emitted gazillion times. Fixes: In file included from ./tm.h:23, from gcc/genconfig.c:25: gcc/config/elfos.h:209: warning: "READONLY_DATA_SECTION_ASM_OP" redefined 209 | #define READONLY_DATA_SECTION_ASM_OP"\t.section\t.rodata" | In file

Re: [patch] Fix reverse SSO issues in IPA-SRA

2022-01-12 Thread Eric Botcazou via Gcc-patches
> Thanks for the fixes, the forgotten duplication and streaming were quite > embarrassing, but one reason is that there are few reverse SSO testcases > in the suite. Would it be difficult to add some covering the issues you > fixed? No, I think I should be able to cover 3 out of the 4 changes,

[PATCH] libgomp, OpenMP: Fix issue for omp_get_device_num on gfx targets.

2022-01-12 Thread Marcel Vollweiler
Hi, Currently omp_get_device_num does not work on gcn targets with more than one offload device. The reason is that GOMP_DEVICE_NUM_VAR is static in icv-device.c and thus "__gomp_device_num" is not visible in the offload image. This patch removes "static" such that "__gomp_device_num" is now

[PATCH] libstdc++: Add attribute to features deprecated in C++17 [PR91260]

2022-01-12 Thread Jonathan Wakely via Gcc-patches
This passes testing (with -std=gnu++98/11/17/20) but is quite a large patch for this late in stage 3. Does anybody object to doing this now? The bugs it fixes were closed as INVALID because we're not actually *required* to remove these or deprecate them. But users are right to complain about us

[PATCH] Fix -Wformat-diag for s390x target.

2022-01-12 Thread Martin Liška
Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for s390x target. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/s390/s390-c.c

  1   2   >