Re: [PATCH] RISC-V: Update testcases info with new implement info

2022-01-23 Thread Kito Cheng via Gcc-patches
Committed, thanks! On Wed, Jan 19, 2022 at 5:18 PM Martin Liška wrote: > > On 1/19/22 10:15, shi...@iscas.ac.cn wrote: > > |From: LiaoShihua After commit > > 591b6e00d1bfe12932ca31530d5859f95db8a35a " riscv: fix -Wformat-diag errors > > ", some strings in implement was changed. This patch

Re: [PING^3][PATCH,v2,1/1,AARCH64][PR102768] aarch64: Add compiler support for Shadow Call Stack

2022-01-23 Thread Dan Li via Gcc-patches
On 1/20/22 04:02, Richard Sandiford wrote: Thanks for the patch and sorry for the (very) slow review. Thanks for the review, Richard :). +/* Handle a "no_sanitize_shadow_call_stack" attribute; arguments as in + struct attribute_spec.handler. */ +static tree

Re: [PATCH v2] x86: Also check mode of memory broadcast in bcst_mem_operand

2022-01-23 Thread H.J. Lu via Gcc-patches
On Sun, Jan 23, 2022 at 4:35 PM Hongtao Liu wrote: > > On Sun, Jan 23, 2022 at 8:28 PM H.J. Lu via Gcc-patches > wrote: > > > > Return false for invalid mode on memory broadcast in bcst_mem_operand: > > > > (vec_duplicate:V16SF (mem/j:V4SF (reg/v/f:DI 109 [ b ]))) > > > Yes, thanks. I will also

Re: [PATCH v2] x86: Also check mode of memory broadcast in bcst_mem_operand

2022-01-23 Thread Hongtao Liu via Gcc-patches
On Sun, Jan 23, 2022 at 8:28 PM H.J. Lu via Gcc-patches wrote: > > Return false for invalid mode on memory broadcast in bcst_mem_operand: > > (vec_duplicate:V16SF (mem/j:V4SF (reg/v/f:DI 109 [ b ]))) > Yes, thanks. > gcc/ > > PR target/104188 > * config/i386/predicates.md

Re: [PATCH] libstdc++: Fix aliasing violation in std::shared_ptr

2022-01-23 Thread Jonathan Wakely via Gcc-patches
I thought I'd CC'd Maged on this patch, but apparently not. I've pushed it to trunk now. On Fri, 21 Jan 2022 at 13:50, Jonathan Wakely wrote: > > Tested powerpc64le-linux. Does anybody see a problem with this change? > > > The non-atomic store that sets both reference counts to zero uses a >

[committed] libstdc++: Fix std::spanstream move assignment [PR104032]

2022-01-23 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. libstdc++-v3/ChangeLog: PR libstdc++/104032 * include/std/spanstream (basic_spanbuf(basic_spanbuf&&)): Use mem-initializer for _M_buf. (basic_spanbuf::Operator=(basic_spanbuf&&)): Fix ill-formed member access.

[committed] libstdc++: Use fast_float for long double if it uses binary64 format

2022-01-23 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. We can use the new from_chars implementation when long double and double have the same representation. libstdc++-v3/ChangeLog: * src/c++17/floating_from_chars.cc (USE_STRTOD_FOR_FROM_CHARS): Define macro for case where std::from_chars

[committed] libstdc++: Restore support for unordered_map [PR104174]

2022-01-23 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. I broke this unintentionally in r12-4259. libstdc++-v3/ChangeLog: PR libstdc++/104174 * include/bits/hashtable_policy.h (_Map_base): Add partial specialization for maps with const key types. *

Re: [PATCH] c++: value category of compound object expr [PR104173]

2022-01-23 Thread Jason Merrill via Gcc-patches
On 1/22/22 16:24, Patrick Palka wrote: Here the call to the &&-qualified toLower() is incorrectly rejected because the object expression is deemed to be an lvalue, even though it's really a prvalue. The object expression, instance()->applicationName(), is expressed as an INDIRECT_REF of a

Re: [PATCH v3] c++: designated init of char array by string constant [PR55227]

2022-01-23 Thread Jason Merrill via Gcc-patches
On 1/17/22 14:29, will wray wrote: Attached (the cut n paste looks like it removed some whitespace formatting) Pushed, thanks! I incorporated the introduction from your initial email in the commit message. Jason

[PATCH] [aarch64/64821]: Simplify __builtin_aarch64_sqrt* into internal function .SQRT.

2022-01-23 Thread apinski--- via Gcc-patches
From: Andrew Pinski This is a simple patch which simplifies the __builtin_aarch64_sqrt* builtins into the internal function SQRT which allows for constant folding and other optimizations at the gimple level. It was originally suggested we do to __builtin_sqrt just for __builtin_aarch64_sqrtdf

Re: [PATCH] riscv: fix -Wformat-diag errors.

2022-01-23 Thread Maciej W. Rozycki
On Tue, 18 Jan 2022, Palmer Dabbelt wrote: > Yep. Seeing this go by, though, I think there's some English issues with the > original messages. I'd write it more like this, but I'm never 100% sure on > these things: > >diff --git a/gcc/common/config/riscv/riscv-common.cc >

[PATCH] PR fortran/104128 - ICE in gfc_widechar_to_char, at fortran/scanner.c:199

2022-01-23 Thread Harald Anlauf via Gcc-patches
Dear Fortranners, conversions between different character kinds using TRANSFER exhibit inconsistencies that can occur between expr->representation.string (which is char*) on the one hand, and expr->->value.character.string. One issue (in target-memory.cc) is easily fixed by simply passing a

Re: [PATCH] libgccjit: Add option to hide stderr logs [PR104073]

2022-01-23 Thread Antoni Boucher via Gcc-patches
Thanks for the review. Here's the updated patch. Le mardi 18 janvier 2022 à 18:22 -0500, David Malcolm a écrit : > On Mon, 2022-01-17 at 21:02 -0500, Antoni Boucher via Gcc-patches > wrote: > > Hi. > > This option will be useful for rustc_codegen_gcc to hide the error > > about unsupported

Re: [committed] analyzer: reject ((i + 1 > 0) && (i < 0)) for integers [PR94362]

2022-01-23 Thread Mikael Morin
Hello, Le 21/01/2022 à 00:59, David Malcolm via Gcc-patches a écrit : diff --git a/gcc/analyzer/constraint-manager.cc b/gcc/analyzer/constraint-manager.cc index 568e7150ea7..7c4a85bbb24 100644 --- a/gcc/analyzer/constraint-manager.cc +++ b/gcc/analyzer/constraint-manager.cc @@ -301,6 +301,80

Re: [PATCH] Fortran: detect signaling NaNs on targets without issignaling macro in libc

2022-01-23 Thread Mikael Morin
Le 23/01/2022 à 11:05, FX a écrit : Hi Mikael, I spotted two unexpected things (to me at least) related to x86 extended type: - You check for endianness, so the format is not x86-specific? - Is it expected that the padding bits are in the middle of the data in the big-endian case? IEEE

Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2022-01-23 Thread Marc Nieper-Wißkirchen
Am Sa., 15. Jan. 2022 um 14:56 Uhr schrieb Marc Nieper-Wißkirchen : > > Jeff, David, do you need any more input from my side? > > -- Marc > > Am Sa., 8. Jan. 2022 um 17:32 Uhr schrieb Jeff Law : > > > > > > > > On 1/6/2022 6:53 AM, David Malcolm via Gcc-patches wrote: > > > On Sun, 2021-12-19 at

[PATCH v2] x86: Also check mode of memory broadcast in bcst_mem_operand

2022-01-23 Thread H.J. Lu via Gcc-patches
Return false for invalid mode on memory broadcast in bcst_mem_operand: (vec_duplicate:V16SF (mem/j:V4SF (reg/v/f:DI 109 [ b ]))) gcc/ PR target/104188 * config/i386/predicates.md (bcst_mem_operand): Also check mode of memory broadcast. gcc/testsuite/ PR

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-23 Thread Jakub Jelinek via Gcc-patches
On Sun, Jan 23, 2022 at 10:06:24AM +0100, Uros Bizjak wrote: > > 2022-01-22 Jakub Jelinek > > > > * config/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P, > > OPTION_BIONIC_P, OPTION_MUSL_P): Define. > > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine > >

Re: [PATCH] Fortran: detect signaling NaNs on targets without issignaling macro in libc

2022-01-23 Thread FX via Gcc-patches
Hi Mikael, > I spotted two unexpected things (to me at least) related to x86 extended type: > - You check for endianness, so the format is not x86-specific? > - Is it expected that the padding bits are in the middle of the data in the > big-endian case? IEEE specifies that extended precision

Re: [PATCH v5 02/12] LoongArch Port: gcc build

2022-01-23 Thread 程璐璐
在 2022/1/23 下午5:00, Xi Ruoyao 写道: On Sun, 2022-01-23 at 16:39 +0800, 程璐璐 wrote: 在 2022/1/22 下午4:42, Xi Ruoyao 写道: On Sat, 2022-01-22 at 15:55 +0800, Chenghua Xu wrote: +mstrict-align +Target Var(TARGET_STRICT_ALIGN) Init(0) +Do not generate unaligned memory accesses. Section 2.1.8

Re: Difference between 32-bit SPARCv9 and SPARCv8+?

2022-01-23 Thread Eric Botcazou via Gcc-patches
> Does anyone know the reasoning behind this? Solaris preserves the full 64-bit registers in 32-bit mode. -- Eric Botcazou

Re: Difference between 32-bit SPARCv9 and SPARCv8+?

2022-01-23 Thread Eric Botcazou via Gcc-patches
> While playing around with the compiler options trying to find a solution, I > made an interesting discovery which is that GCC support 64-bit compare and > swap on SPARCv8plus but not on 32-bit SPARCv9: > > glaubitz@gcc202:~$ echo | gcc -mv8plus -E -dM -|grep -i SWAP > #define

Re: [PATCH] Disable -fsplit-stack support on non-glibc targets

2022-01-23 Thread Uros Bizjak via Gcc-patches
On Sat, Jan 22, 2022 at 7:04 PM Jakub Jelinek via Gcc-patches wrote: > > On Sat, Jan 22, 2022 at 01:16:38PM +0100, Jakub Jelinek via Gcc-patches wrote: > > Actually, I suspect we either need something like following patch, > > or need to change gcc/config/{linux,rs6000/linux{,64},alpha/linux}.h >

Re: [PATCH v5 02/12] LoongArch Port: gcc build

2022-01-23 Thread Xi Ruoyao via Gcc-patches
On Sun, 2022-01-23 at 16:39 +0800, 程璐璐 wrote: > > 在 2022/1/22 下午4:42, Xi Ruoyao 写道: >   > > > On Sat, 2022-01-22 at 15:55 +0800, Chenghua Xu wrote: > >   > > > > > +mstrict-align > > > +Target Var(TARGET_STRICT_ALIGN) Init(0) > > > +Do not generate unaligned memory accesses. > > Section 2.1.8

Re: [PATCH v5 02/12] LoongArch Port: gcc build

2022-01-23 Thread 程璐璐
在 2022/1/22 下午4:42, Xi Ruoyao 写道: On Sat, 2022-01-22 at 15:55 +0800, Chenghua Xu wrote: +mstrict-align +Target Var(TARGET_STRICT_ALIGN) Init(0) +Do not generate unaligned memory accesses. Section 2.1.8 of LoongArch spec says "load/store instruction *may* be implemented to allow unaligned

Re: [PATCH v5 02/12] LoongArch Port: gcc build

2022-01-23 Thread 程璐璐
在 2022/1/22 下午5:31, Jakub Jelinek 写道: On Sat, Jan 22, 2022 at 05:05:00PM +0800, Xi Ruoyao wrote: On Sat, 2022-01-22 at 16:56 +0800, 程璐璐 wrote: Under the MIPS architecture, *.opt files are also generated in $(srcdir). Well, but then you should put the commands for generating those files