Thanks for the review. I've tested and uploaded a new patch v2 with
the requested changes.
On Thu, 17 Mar 2022 at 09:20, Jason Merrill wrote:
>
> On 3/14/22 02:36, Zhao Wei Liew via Gcc-patches wrote:
>
> > This patch adds a warning when casting "this" to Derived* in the Base
> > class
Hi,
This patch adds V1TI mode into a new mode iterator used in vector
comparison expands.With the patch, both built-ins and direct comparison
could generate P10 new V1TI comparison instructions.
Bootstrapped and tested on ppc64 Linux BE and LE with no regressions.
Is this okay for trunk?
This patch only handle pure-slp for by-value passed parameter which
has nothing to do with IPA but psABI. For by-reference passed
parameter IPA is required.
The patch is aggressive in determining STLF failure, any
unaligned_load for parm_decl passed by stack is thought to have STLF
stall issue.
This patch only handle pure-slp for by-value passed parameter which
has nothing to do with IPA but psABI. For by-reference passed
parameter IPA is required.
The patch is aggressive in determining STLF failure, any
unaligned_load for parm_decl passed by stack is thought to have STLF
stall issue.
Backport PR fortran/96983 patch to GCC 11.
I applied a patch on the trunk in April 22nd, 2021 that fixes an issue (PR
fortran/66983) where we could fail for 128-bit floating point types
because we don't have a built-in function that is equivalent to llround
for 128-bit integer types. Instead,
On 17/03/2022 05:11, Martin Sebor wrote:
As the GCC manual prominently states (and as I already pointed out)
warnings are:
We are indeed going around in circles. Hopefully someone else will
pitch in and break the deadlock.
Siddhesh
On 3/14/22 02:36, Zhao Wei Liew via Gcc-patches wrote:
This patch adds a warning when casting "this" to Derived* in the Base
class constructor and destructor. I've added the warning under the
-Wextra flag as I can't find a more appropriate flag for it.
It's generally best to add a new warning
Thanks for the detailed review. I have uploaded patch v2 based on the review.
v1: https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590604.html
Changes since v1:
1. Add patterns for the cases CST / (T)x and (T)x / CST as well. Fix
test regressions caused by those patterns.
2. Support signed
On 3/15/22 19:24, Siddhesh Poyarekar wrote:
On 16/03/2022 02:06, Martin Sebor wrote:
The intended use of the strncmp bound is to limit the comparison to
at most the size of the arrays or (in a subset of cases) the length
of an initial substring. Providing an arbitrary bound that's not
related
Tested x86_64-linux and sparc-sun-solaris2.11 (but 11.3 only).
Pushed to trunk.
Rainer, this should allow you to continue omitting the
_ZSt10from_charsPKcS0_R[def]St12chars_format symbols from the baseline,
without the current FAIL. Please check on your other Solaris targets.
-- >8 --
The new
Hi Mikael,
Am 14.03.22 um 19:28 schrieb Mikael Morin:
Hello,
this workarounds the regression I introduced with the fix for pr104228.
The problem comes from the evaluation of character length for the
associate target (y) in the testcase.
The expression is non-scalar which is not supported at
Zero-length pack expansions are treated as if no list were provided
at all, that is, with
template struct S { };
template
void g() {
S...>;
}
g will result in S<>. In the following test we have something
similar:
template
using IsOneOf = disjunction...>;
and then we have
On Wed, Mar 16, 2022 at 03:06:42PM -0500, will schmidt wrote:
> On Wed, 2022-03-16 at 13:12 -0500, Segher Boessenkool wrote:
> > (define_insn "addg6s"
> > [(set (match_operand:GPR 0 "register_operand" "=r")
> > (unspec:GPR [(match_operand:GPR 1 "register_operand" "r")
> >
This patch updates libgo to the final 1.18 release. Bootstrapped and
ran Go testsuite on x86_64-pc-linux-nu. Committed to mainline.
Ian
patch.txt.gz
Description: application/gzip
> On Mar 14, 2022, at 11:04 AM, Richard Sandiford
> wrote:
>
> Sorry for the slow response, was out for a few days.
>
> Xi Ruoyao writes:
>> On Sat, 2022-03-12 at 18:48 +0800, Xi Ruoyao via Gcc-patches wrote:
>>> On Fri, 2022-03-11 at 21:26 +, Qing Zhao wrote:
Hi, Ruoyao,
> and there needs to be code to actually expand the builtin using optabs.
> And something needs to be done to make match.pd work on the output.
Never mind that bit, that was just due to a function argument type mismatch
on the last argument of the crc built-in functions.
Thanks. Just committed the patch to gcc11 branch.
Qing
> On Mar 14, 2022, at 2:46 AM, Richard Biener
> wrote:
>
> On Fri, Mar 11, 2022 at 5:31 PM Qing Zhao via Gcc-patches
> wrote:
>>
>>
>> Hi,
>>
>> I plan to backport the patch to fix PR100775:
>>
On Wed, 2022-03-16 at 13:12 -0500, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Mar 16, 2022 at 12:20:18PM -0500, will schmidt wrote:
> > For PR100693, we currently provide an addg6s builtin using unsigned
> > int arguments, but we are missing an unsigned long long argument
> > equivalent. This
On Linux/x86_64,
f6fb661ea8ac7e17c6924719de6219f002c4efef is the first bad commit
commit f6fb661ea8ac7e17c6924719de6219f002c4efef
Author: Richard Biener
Date: Wed Mar 16 13:39:31 2022 +0100
tree-optimization/102008 - restore if-conversion of adjacent loads
caused
FAIL:
Hi!
On Wed, Mar 16, 2022 at 12:20:18PM -0500, will schmidt wrote:
> For PR100693, we currently provide an addg6s builtin using unsigned
> int arguments, but we are missing an unsigned long long argument
> equivalent. This patch adds an overload to provide the long long
> version of the builtin.
Avoid generating execution paths for warnings that are ultimately
rejected due to -Wno-analyzer-* flags.
This improves the test case from taking at least several minutes
(before I killed it) to taking under a second.
This doesn't fix the slowdown seen in PR analyzer/104955 with large
numbers of
"Andre Vieira (lists)" writes:
> Hi,
>
> This patch implements the costing function
> determine_suggested_unroll_factor for aarch64.
> It determines the unrolling factor by dividing the number of X
> operations we can do per cycle by the number of X operations in the loop
> body, taking this
On Wed, 16 Mar 2022, Roger Sayle wrote:
> This is Christophe Lyon's fix to PR c/98198, an ICE-on-invalid-code
> regression affecting mainline, and a suitable testcase.
> Tested on x86_64-pc-linux-gnu with make bootstrap and make -k check
> with no new failures. Ok for mainline?
>
>
>
Hi!
I'd like to ping this patch:
https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590960.html
Thanks.
On Mon, Feb 28, 2022 at 07:06:30AM +0100, Jakub Jelinek wrote:
> As mentioned in the PR, the latest Intel SDM has added:
> "Processors that enumerate support for Intel® AVX (by setting
Hi!
As mentioned in the PR, we emit a bogus uninitialized warning but
easily could emit wrong-code for it or similar testcases too.
The bug is that we emit clobber for a TARGET_EXPR_SLOT too early:
D.2499.e = B::qux (); [return slot optimization]
D.2516 = 1;
try
Hi,
RFC/Update support for addg6s instruction. PR100693
For PR100693, we currently provide an addg6s builtin using unsigned
int arguments, but we are missing an unsigned long long argument
equivalent. This patch adds an overload to provide the long long
version of the builtin.
unsigned long
"Andre Vieira (lists)" writes:
> Hi,
>
> This patch updates the register move tunings for
> -mcpu/-mtune={neoverse-v1,neoverse-512tvb}.
>
> 2022-03-16 Tamar Christina
> Andre Vieira
>
> * config/aarch64/aarch64.cc (neoversev1_regmove_cost): New
> tuning
"Andre Vieira (lists)" writes:
> This patch introduces a struct to differentiate between different
> memmove costs to enable a better modeling of memory operations. These
> have been modelled for
> -mcpu/-mtune=neoverse-v1/neoverse-n1/neoverse-n2/neoverse-512tvb, for
> all other tunings all
On Wed, 16 Mar 2022 at 08:15, Richard Biener wrote:
> The canonical place to transform loops into builtins would be loop
> distribution.
> Another place would be final value replacement since you basically replace
> the reduction result with a call to the builtin, but I think
>
On Tue, Mar 15, 2022 at 04:19:05PM -0400, Jason Merrill wrote:
> > But if you strongly prefer it that way, I can do that.
> > Note, probably not 3 new args but 4, depends on whether we could turn
> > all those cases where the tree arg0 = CALL_EXPR_ARG (oldop, 0);
> > is done but var_size_adjusted
On Mon, 14 Mar 2022 at 14:15, Patrick Palka wrote:
> I think __floating_from_chars_hex should work fine on 16 bit targets,
> so I suppose we could use it in the !USE_LIB_FAST_FLOAT branch as well.
Good point, and even for SIZE_WIDTH >= 32, it might be faster to use
your __floating_from_chars_hex
"Andre Vieira (lists)" writes:
> Hi,
>
> This patch adds tuning structs for -mcpu/-mtune=demeter.
>
>
> 2022-03-16 Tamar Christina
> Andre Vieira
>
> * config/aarch64/aarch64.cc (demeter_addrcost_table,
> demeter_regmove_cost,
>
On Tue, 15 Mar 2022 at 14:12, Patrick Palka wrote:
>
> On Mon, 14 Mar 2022, Jonathan Wakely wrote:
>
> > On Mon, 14 Mar 2022 at 14:17, Patrick Palka via Libstdc++
> > wrote:
> > >
> > > On Fri, 11 Mar 2022, Jonathan Wakely wrote:
> > >
> > > > Patrick, I think this is right, but please take a
This is Christophe Lyon's fix to PR c/98198, an ICE-on-invalid-code
regression affecting mainline, and a suitable testcase.
Tested on x86_64-pc-linux-gnu with make bootstrap and make -k check
with no new failures. Ok for mainline?
2022-03-16 Christophe Lyon
Roger Sayle
"Andre Vieira (lists)" writes:
> Hi,
>
> This patch adds tuning structures for Neoverse N2.
>
> 2022-03-16 Tamar Christina
> Andre Vieira
>
> * config/aarch64/aarch64.cc (neoversen2_addrcost_table,
> neoversen2_regmove_cost,
> neoversen2_advsimd_vector_cost,
Hi Rainer,
> On 16 Mar 2022, at 15:55, Rainer Orth wrote:
>
>>> I've omitted the Darwin-specific stuff so far documented in PRs d/103577
>>> and d/103578:
>>>
>>> * needs --enable-libphobos
>>> * top of gcc-11 branch only
>>> * backport of -static-libphobos patch
>>> * Darwin/i386 doesn't work
Hi Iain,
>> I've omitted the Darwin-specific stuff so far documented in PRs d/103577
>> and d/103578:
>>
>> * needs --enable-libphobos
>> * top of gcc-11 branch only
>> * backport of -static-libphobos patch
>> * Darwin/i386 doesn't work at all
>
> — hopefully we will not need to add that —
>
>
On 3/9/22 06:17, Richard Biener wrote:
On Fri, Feb 11, 2022 at 12:05 AM Martin Sebor via Gcc-patches
wrote:
On 2/8/22 15:37, Jason Merrill wrote:
On 2/8/22 16:59, Martin Sebor wrote:
Transforming a by-value arguments to by-reference as GCC does for some
class types can trigger
> On 16 Mar 2022, at 13:28, Rainer Orth wrote:
>
> This patch documents the Solaris-specific D bootstrap requirements.
>
> Tested by building and inspecting gccinstall.{pdf,info}.
>
> Ok for trunk?
>
> I've omitted the Darwin-specific stuff so far documented in PRs d/103577
> and d/103578:
On Wed, Mar 16, 2022 at 08:24:24PM +0530, Siddhesh Poyarekar wrote:
> Assign the result of fold_convert to offset.
>
> gcc/ChangeLog:
>
> PR tree-optimization/104941
> * tree-object-size.cc (size_for_offset): Assign result of
> fold_convert to OFFSET.
>
>
Hi,
As requested, I updated the Neoverse N2 entry to use the
AARCH64_FL_FOR_ARCH9 feature set, removed duplicate entries, updated the
ARCH_INDENT to 9A and moved it under the Armv9 cores.
gcc/ChangeLog:
* config/aarch64/aarch64-cores.def: Update Neoverse N2 core entry.
diff --git
Hi,
This patch implements the costing function
determine_suggested_unroll_factor for aarch64.
It determines the unrolling factor by dividing the number of X
operations we can do per cycle by the number of X operations in the loop
body, taking this information from the vec_ops analysis during
This patch introduces a struct to differentiate between different
memmove costs to enable a better modeling of memory operations. These
have been modelled for
-mcpu/-mtune=neoverse-v1/neoverse-n1/neoverse-n2/neoverse-512tvb, for
all other tunings all entries are equal to the old single memmove
Assign the result of fold_convert to offset.
gcc/ChangeLog:
PR tree-optimization/104941
* tree-object-size.cc (size_for_offset): Assign result of
fold_convert to OFFSET.
gcc/testsuite/ChangeLog:
PR tree-optimization/104941
*
Hi,
This patch updates the register move tunings for
-mcpu/-mtune={neoverse-v1,neoverse-512tvb}.
2022-03-16 Tamar Christina
Andre Vieira
* config/aarch64/aarch64.cc (neoversev1_regmove_cost): New
tuning struct.
(neoversev1_tunings): Use
Hi,
This patch adds tuning structs for -mcpu/-mtune=demeter.
2022-03-16 Tamar Christina
Andre Vieira
* config/aarch64/aarch64.cc (demeter_addrcost_table,
demeter_regmove_cost,
demeter_advsimd_vector_cost, demeter_sve_vector_cost,
Hi,
This patch adds tuning structures for Neoverse N2.
2022-03-16 Tamar Christina
Andre Vieira
* config/aarch64/aarch64.cc (neoversen2_addrcost_table,
neoversen2_regmove_cost,
neoversen2_advsimd_vector_cost, neoversen2_sve_vector_cost,
The following backports a pointer associating pattern from trunk
that mitigates an issue with number_of_iterations_lt_to_ne in
which context we fail to fold a comparison but succeed in folding
a related subtraction. In the failure mode this results in
a loop wrongly assumed looping with a bogus
On Wed, Mar 16, 2022 at 02:06:16PM +0100, Marcel Vollweiler wrote:
> libgomp/ChangeLog:
>
> * fortran.c (omp_set_num_teams_8_): Fix bug.
> * testsuite/libgomp.fortran/icv-8.f90: New test.
Ok, with a minor nit. Please use
Call omp_set_num_teams instead of omp_set_max_active_levels.
On Tue, Mar 15, 2022 at 6:57 PM Hongtao Liu wrote:
>
> On Tue, Mar 15, 2022 at 10:40 PM H.J. Lu wrote:
> >
> > On Mon, Mar 14, 2022 at 7:31 AM H.J. Lu wrote:
> > >
> > > Push target("general-regs-only") in if x87 is enabled.
> > >
> > > gcc/
> > >
> > > PR target/104890
> > > *
This patch documents the Solaris-specific D bootstrap requirements.
Tested by building and inspecting gccinstall.{pdf,info}.
Ok for trunk?
I've omitted the Darwin-specific stuff so far documented in PRs d/103577
and d/103578:
* needs --enable-libphobos
* top of gcc-11 branch only
* backport of
Hi Shi-Hua:
Thanks, generally it's LGTM, just a few coding style issues. I've
fixed that and committed this time,
but just let you know where you should update your coding style.
And you could use git clang-format and use /contrib/clang-format
as format file to save
your time to indent that.
Hi Jakub,
! { dg-do run }
! { dg-additional-options "-fdefault-integer-8" }
program set_num_teams_8
use omp_lib
omp_set_num_teams (42)
if (omp_get_num_teams () .ne. 42) stop 1
end program
I modified your suggested test case a bit:
program set_num_teams_8
use omp_lib
use,
On Wed, Mar 16, 2022 at 1:59 PM Richard Biener
wrote:
>
> On Wed, Mar 16, 2022 at 1:31 PM Roger Sayle
> wrote:
> >
> >
> > This patch is the second of two changes to genmatch that don't affect
> > the executable code, but reduce the amount of debugging information
> > generated in stage3 of a
On Wed, Mar 16, 2022 at 1:31 PM Roger Sayle wrote:
>
>
> This patch is the second of two changes to genmatch that don't affect
> the executable code, but reduce the amount of debugging information
> generated in stage3 of a build, but adhering more closely to GNU style
> guidelines.
>
> This
On Wed, Mar 16, 2022 at 1:28 PM Roger Sayle wrote:
>
>
> This patch is the first of two changes to genmatch that don't affect
> the executable code, but reduce the amount of debugging information
> generated in stage3 of a build, but adhering more closely to GNU style
> guidelines.
>
> This patch
On Wed, Mar 16, 2022 at 01:42:26PM +0100, Richard Biener wrote:
> The following re-orders the newly added code sinking pass before
> the last phiopt pass which performs hoisting of adjacent loads
> with the intent to enable if-conversion on those.
>
> I've added the aarch64 specific testcase from
The following re-orders the newly added code sinking pass before
the last phiopt pass which performs hoisting of adjacent loads
with the intent to enable if-conversion on those.
I've added the aarch64 specific testcase from the PR.
Bootstrapped and tested on x86_64-unknown-linux-gnu, verified
On Tue, Mar 15, 2022 at 02:49:39PM -0500, Peter Bergner wrote:
> On 3/4/22 8:14 PM, Peter Bergner wrote:
> > On 3/4/22 11:33 AM, Peter Bergner wrote:
> >>> Ok pushed to trunk. I haven't determined yet whether we need this on GCC
> >>> 11 yet.
> >>> I'll check on that and report back. Thanks!
>
在 2022/3/15 下午10:35, Xi Ruoyao 写道:
On Fri, 2022-03-04 at 15:17 +0800, xucheng...@loongson.cn wrote:
v7 -> v8
1. Add new addressing type ADDRESS_REG_REG support.
2. Modify documentation.
3. Eliminate compile-time warnings.
Hi,
The v8 series does not build LoongArch Linux kernel tree
This patch is the second of two changes to genmatch that don't affect
the executable code, but reduce the amount of debugging information
generated in stage3 of a build, but adhering more closely to GNU style
guidelines.
This patch avoids generating "next_after_fail1:;" label statements
in
This patch is the first of two changes to genmatch that don't affect
the executable code, but reduce the amount of debugging information
generated in stage3 of a build, but adhering more closely to GNU style
guidelines.
This patch avoids generating a switch with a single case statement,
instead
On Tue, Mar 15, 2022 at 01:32:46PM +0100, Jakub Jelinek via Gcc-patches wrote:
> Another one is whether we shouldn't punt for FIELD_DECLs that don't have
> nicely printable name of its containing scope, something like:
> if (tree scope = get_containing_scope (field))
>
On Wed, Mar 16, 2022 at 3:19 AM liuhongt wrote:
>
> This patch only handle pure-slp for by-value passed parameter which
> has nothing to do with IPA but psABI. For by-reference passed
> parameter IPA is required.
>
> The patch is aggressive in determining STLF failure, any
> unaligned_load for
Richard Biener via Gcc-patches writes:
> On Mon, Mar 14, 2022 at 8:26 PM Roger Sayle
> wrote:
>> I've been wondering about the possible performance/missed-optimization
>> impact of my patch for PR middle-end/98420 and similar IEEE correctness
>> fixes that disable constant folding optimizations
On Wed, Mar 16, 2022 at 09:10:35AM +, Richard Sandiford wrote:
> Jakub Jelinek writes:
> > We unshare all RTL created during expansion, but when
> > aarch64_load_symref_appropriately is called after expansion like in the
> > following testcases, we use imm in both HIGH and LO_SUM operands.
>
Hi!
On 2021-05-21T21:29:19+0200, I wrote:
> I've pushed "[OpenACC privatization] Largely extend diagnostics and
> corresponding testsuite coverage [PR90115]" to master branch in commit
> 11b8286a83289f5b54e813f14ff56d730c3f3185
Pushed to master branch commit
Jakub Jelinek writes:
> Hi!
>
> We unshare all RTL created during expansion, but when
> aarch64_load_symref_appropriately is called after expansion like in the
> following testcases, we use imm in both HIGH and LO_SUM operands.
> If imm is some RTL that shouldn't be shared like a non-sharable
On Wed, Mar 16, 2022 at 9:18 AM liuhongt via Gcc-patches
wrote:
>
> __builtin_ia32_blendvpd is defined under sse4.1 and gimple folded
> to ((v2di) c) < 0 ? b : a where vec_cmpv2di is under sse4.2 w/o which
> it's veclowered to scalar operations and not combined back in rtl.
>
> Bootstrap and
Retain the sizetype alloc_object_size to guarantee the assertion in
size_for_offset and to avoid adding a conversion there. nop conversions
are eliminated at the end anyway in dynamic object size computation.
gcc/ChangeLog:
tree-optimization/104942
* tree-object-size.cc
On Wed, Mar 16, 2022 at 01:56:50PM +0530, Siddhesh Poyarekar wrote:
> Retain the sizetype alloc_object_size to guarantee the assertion in
> size_for_offset and to avoid adding a conversion there. nop conversions
> are eliminated at the end anyway in dynamic object size computation.
>
>
On Wed, 16 Mar 2022, Roger Sayle wrote:
>
> Here's version 2 of my patch, incorporating Richard Biener's suggestions.
> I've also done an analysis of the stage3 sizes of gimple-match.o on
> x86_64-pc-linux-gnu, which I believe is dominated by debug information,
> the .o file is 30MB in stage3,
__builtin_ia32_blendvpd is defined under sse4.1 and gimple folded
to ((v2di) c) < 0 ? b : a where vec_cmpv2di is under sse4.2 w/o which
it's veclowered to scalar operations and not combined back in rtl.
Bootstrap and regtest on x86_64-pc-linux-gnu{-m32,}.
Ready push to main trunk.
gcc/ChangeLog:
On Tue, Mar 15, 2022 at 4:15 PM Joern Rennecke
wrote:
>
> On 15/03/2022, Richard Biener wrote:
>
> > Why's this a new pass? Every walk over all insns costs time.
>
> If should typically scan considerably less than all the insns.
>
> > The pass
> > lacks any comments as to what CFG / stmt
Here's version 2 of my patch, incorporating Richard Biener's suggestions.
I've also done an analysis of the stage3 sizes of gimple-match.o on
x86_64-pc-linux-gnu, which I believe is dominated by debug information,
the .o file is 30MB in stage3, but only 4.8M in stage2. Before my
proposed patch
75 matches
Mail list logo
