Re: [x86_64 PATCH] Improved Scalar-To-Vector (STV) support for TImode to V1TImode.

2022-07-14 Thread Richard Biener via Gcc-patches
On Thu, Jul 14, 2022 at 7:32 AM Roger Sayle wrote: > > > On Mon, Jul 11, 2022, H.J. Lu wrote: > > On Sun, Jul 10, 2022 at 2:38 PM Roger Sayle > > wrote: > > > Hi HJ, > > > > > > I believe this should now be handled by the post-reload (CSE) pass. > > > Consider the simple test case: > > > > > > _

Re: [PATCH] Extend 64-bit vector bit_op patterns with ?r alternative

2022-07-14 Thread Uros Bizjak via Gcc-patches
On Thu, Jul 14, 2022 at 7:33 AM liuhongt wrote: > > And split it to GPR-version instruction after reload. > > > ?r was introduced under the assumption that we want vector values > > mostly in vector registers. Currently there are no instructions with > > memory or immediate operand, so that made s

Re: [PATCH] xtensa: Minor fix for FP constant synthesis

2022-07-14 Thread Max Filippov via Gcc-patches
On Wed, Jul 13, 2022 at 4:41 AM Takayuki 'January June' Suwa wrote: > > This patch fixes an non-fatal issue about negative constant values derived > from FP constant synthesis on hosts whose 'long' is wider than 'int32_t'. > > And also replaces the dedicated code in FP constant synthesis split > p

Re: ICE after folding svld1rq to vec_perm_expr duing forwprop

2022-07-14 Thread Prathamesh Kulkarni via Gcc-patches
On Wed, 13 Jul 2022 at 12:22, Richard Biener wrote: > > On Tue, Jul 12, 2022 at 9:12 PM Prathamesh Kulkarni via Gcc-patches > wrote: > > > > Hi Richard, > > For the following test: > > > > svint32_t f2(int a, int b, int c, int d) > > { > > int32x4_t v = (int32x4_t) {a, b, c, d}; > > return sv

[PATCH] Fix ICE on view conversion between struct and integer

2022-07-14 Thread Eric Botcazou via Gcc-patches
Hi, you can build a view conversion between pretty much anything in Ada including between types with different sizes, although the compiler warns in this case and gigi pads the smaller type to end up with the same size. The attached testcase triggers an ICE at -O or above for one of them: FAIL:

Re: [PATCH] [RFC]Support vectorization for Complex type.

2022-07-14 Thread Richard Biener via Gcc-patches
On Wed, Jul 13, 2022 at 9:34 AM Richard Biener wrote: > > On Wed, Jul 13, 2022 at 6:47 AM Hongtao Liu wrote: > > > > On Tue, Jul 12, 2022 at 10:12 PM Richard Biener > > wrote: > > > > > > On Tue, Jul 12, 2022 at 6:11 AM Hongtao Liu wrote: > > > > > > > > On Mon, Jul 11, 2022 at 7:47 PM Richard

[PATCH][pushed] docs: fix position of @end deftypefn

2022-07-14 Thread Martin Liška
gcc/ChangeLog: * doc/gimple.texi: Close properly a deftypefn. --- gcc/doc/gimple.texi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/doc/gimple.texi b/gcc/doc/gimple.texi index dd9149377f3..9150218fed8 100644 --- a/gcc/doc/gimple.texi +++ b/gcc/doc/gimple.texi @

Re: ICE after folding svld1rq to vec_perm_expr duing forwprop

2022-07-14 Thread Richard Biener via Gcc-patches
On Thu, Jul 14, 2022 at 9:55 AM Prathamesh Kulkarni wrote: > > On Wed, 13 Jul 2022 at 12:22, Richard Biener > wrote: > > > > On Tue, Jul 12, 2022 at 9:12 PM Prathamesh Kulkarni via Gcc-patches > > wrote: > > > > > > Hi Richard, > > > For the following test: > > > > > > svint32_t f2(int a, int b

Re: [PATCH] Fix ICE on view conversion between struct and integer

2022-07-14 Thread Richard Biener via Gcc-patches
On Thu, Jul 14, 2022 at 10:20 AM Eric Botcazou via Gcc-patches wrote: > > Hi, > > you can build a view conversion between pretty much anything in Ada including > between types with different sizes, although the compiler warns in this case > and gigi pads the smaller type to end up with the same si

[PATCH part2][PUSHED] docs: fix position of @end deftypefn

2022-07-14 Thread Martin Liška
gcc/ChangeLog: * doc/gimple.texi: Close properly a deftypefn. --- gcc/doc/gimple.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/doc/gimple.texi b/gcc/doc/gimple.texi index 9150218fed8..7832fa6ff90 100644 --- a/gcc/doc/gimple.texi +++ b/gcc/doc/gimple.texi

Re: [PATCH] [RFC]Support vectorization for Complex type.

2022-07-14 Thread Hongtao Liu via Gcc-patches
On Thu, Jul 14, 2022 at 4:20 PM Richard Biener wrote: > > On Wed, Jul 13, 2022 at 9:34 AM Richard Biener > wrote: > > > > On Wed, Jul 13, 2022 at 6:47 AM Hongtao Liu wrote: > > > > > > On Tue, Jul 12, 2022 at 10:12 PM Richard Biener > > > wrote: > > > > > > > > On Tue, Jul 12, 2022 at 6:11 AM H

Re: [PATCH] [RFC]Support vectorization for Complex type.

2022-07-14 Thread Hongtao Liu via Gcc-patches
On Thu, Jul 14, 2022 at 4:53 PM Hongtao Liu wrote: > > On Thu, Jul 14, 2022 at 4:20 PM Richard Biener > wrote: > > > > On Wed, Jul 13, 2022 at 9:34 AM Richard Biener > > wrote: > > > > > > On Wed, Jul 13, 2022 at 6:47 AM Hongtao Liu wrote: > > > > > > > > On Tue, Jul 12, 2022 at 10:12 PM Richar

Re: [PATCH] Extend 64-bit vector bit_op patterns with ?r alternative

2022-07-14 Thread Hongtao Liu via Gcc-patches
On Thu, Jul 14, 2022 at 3:22 PM Uros Bizjak via Gcc-patches wrote: > > On Thu, Jul 14, 2022 at 7:33 AM liuhongt wrote: > > > > And split it to GPR-version instruction after reload. > > > > > ?r was introduced under the assumption that we want vector values > > > mostly in vector registers. Curren

[PATCH][pushed] libiberty: fix docs typo

2022-07-14 Thread Martin Liška
libiberty/ChangeLog: * functions.texi: Replace strtoul with strtoull. --- libiberty/functions.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libiberty/functions.texi b/libiberty/functions.texi index e4d74b58220..b56b02e0686 100644 --- a/libiberty/functions.texi +

Re: [PATCH] ipa-cp: Fix assert triggering with -fno-toplevel-reorder (PR 106260)

2022-07-14 Thread Martin Jambor
Hi, On Thu, Jul 14 2022, Richard Biener wrote: > On Wed, Jul 13, 2022 at 11:06 PM Martin Jambor wrote: >> >> Hi, >> >> with -fno-toplevel-reorder (and -fwhole-program), there apparently can >> be local functions without any callers. > > Did you check why? Can't we fix that? no, I have not check

Re: [PATCH] Extend 64-bit vector bit_op patterns with ?r alternative

2022-07-14 Thread Uros Bizjak via Gcc-patches
On Thu, Jul 14, 2022 at 11:32 AM Hongtao Liu wrote: > > On Thu, Jul 14, 2022 at 3:22 PM Uros Bizjak via Gcc-patches > wrote: > > > > On Thu, Jul 14, 2022 at 7:33 AM liuhongt wrote: > > > > > > And split it to GPR-version instruction after reload. > > > > > > > ?r was introduced under the assumpt

Re: [PATCH] lto-plugin: use -pthread only for detected targets

2022-07-14 Thread Martin Liška
On 7/13/22 14:15, Richard Biener wrote: > Didn't we have it that way and not work? IIRC LDFLAGS is only > used during configure link tests and _not_ substituted? You are right. There's a proper fix that utilizes AM_CONDITIONAL and sets LDFLAGS properly in Makefile.am. Patch can bootstrap on x86

Re: [PATCH] lto-plugin: use -pthread only for detected targets

2022-07-14 Thread Richard Biener via Gcc-patches
On Thu, Jul 14, 2022 at 12:03 PM Martin Liška wrote: > > On 7/13/22 14:15, Richard Biener wrote: > > Didn't we have it that way and not work? IIRC LDFLAGS is only > > used during configure link tests and _not_ substituted? > > You are right. > > There's a proper fix that utilizes AM_CONDITIONAL a

[aarch64] Use op_mode instead of vmode for op0, op1 in aarch64_vectorize_vec_perm_const

2022-07-14 Thread Prathamesh Kulkarni via Gcc-patches
Hi, For following test case: svint32_t foo() { int32x4_t v = (int32x4_t) { 1, 2, 3, 4 }; svint32_t v2 = svld1rq_s32 (svptrue_b8(), &v[0]); return v2; } After applying workaround in forwprop to not simplify VEC_PERM_EXPR in simplify_permutation to avoid type error in middle end (or using -fn

Re: Mips: Fix kernel_stat structure size

2022-07-14 Thread Dimitrije Milosevic
Hi Xi, > Please CC me (@xry111) in LLVM review. I just posted the patch. You should've gotten the email. If not, see: https://reviews.llvm.org/D129749. > By the way, if you have some spare time, you can also add the value for > Musl (all 3 ABIs).  Musl has a different struct stat than Glibc (it's

Re: [PATCH] lto-plugin: use -pthread only for detected targets

2022-07-14 Thread Martin Liška
On 7/14/22 12:10, Richard Biener wrote: > On Thu, Jul 14, 2022 at 12:03 PM Martin Liška wrote: >> >> On 7/13/22 14:15, Richard Biener wrote: >>> Didn't we have it that way and not work? IIRC LDFLAGS is only >>> used during configure link tests and _not_ substituted? >> >> You are right. >> >> The

Re: [PATCH] lto-plugin: use -pthread only for detected targets

2022-07-14 Thread Richard Biener via Gcc-patches
On Thu, Jul 14, 2022 at 1:13 PM Martin Liška wrote: > > On 7/14/22 12:10, Richard Biener wrote: > > On Thu, Jul 14, 2022 at 12:03 PM Martin Liška wrote: > >> > >> On 7/13/22 14:15, Richard Biener wrote: > >>> Didn't we have it that way and not work? IIRC LDFLAGS is only > >>> used during configu

Re: [aarch64] Use op_mode instead of vmode for op0, op1 in aarch64_vectorize_vec_perm_const

2022-07-14 Thread Richard Sandiford via Gcc-patches
Prathamesh Kulkarni writes: > Hi, > For following test case: > > svint32_t foo() > { > int32x4_t v = (int32x4_t) { 1, 2, 3, 4 }; > svint32_t v2 = svld1rq_s32 (svptrue_b8(), &v[0]); > return v2; > } > > After applying workaround in forwprop to not simplify VEC_PERM_EXPR in > simplify_permutat

Re: ICE after folding svld1rq to vec_perm_expr duing forwprop

2022-07-14 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Thu, Jul 14, 2022 at 9:55 AM Prathamesh Kulkarni > wrote: >> >> On Wed, 13 Jul 2022 at 12:22, Richard Biener >> wrote: >> > >> > On Tue, Jul 12, 2022 at 9:12 PM Prathamesh Kulkarni via Gcc-patches >> > wrote: >> > > >> > > Hi Richard, >> > > For the following test:

[PATCH] libstdc++: Make __from_chars_alnum_to_val conversion explicit

2022-07-14 Thread Marco Falke via Gcc-patches
>From 2d4e7cd1d476a065d824e11045c8dbc049d5f0a0 Mon Sep 17 00:00:00 2001 From: MacroFake Date: Thu, 14 Jul 2022 15:26:12 +0200 Subject: [PATCH] libstdc++: Make __from_chars_alnum_to_val conversion explicit The optimizations from commit a54137c88061c7495728fc6b8dfd0474e812b2cb introduced a clang in

Re: [PATCH] match.pd: Add new abs pattern [PR94290]

2022-07-14 Thread Sam Feifer via Gcc-patches
On Wed, Jul 13, 2022 at 3:36 PM Andrew Pinski wrote: > On Wed, Jul 13, 2022 at 12:26 PM Sam Feifer via Gcc-patches > wrote: > > > > This patch is intended to fix a missed optimization in match.pd. It > optimizes (x >= 0 ? x : 0) + (x <= 0 ? -x : 0) to just abs(x). I had to > write a second simpl

Re: kernel sparse annotations vs. compiler attributes and debug_annotate_{type,decl} WAS: Re: [PATCH 0/9] Add debug_annotate attributes

2022-07-14 Thread Jose E. Marchesi via Gcc-patches
Hi Yonghong. > On 7/7/22 1:24 PM, Jose E. Marchesi wrote: >> Hi Yonghong. >> >>> On 6/21/22 9:12 AM, Jose E. Marchesi wrote: > On 6/17/22 10:18 AM, Jose E. Marchesi wrote: >> Hi Yonghong. >> >>> On 6/15/22 1:57 PM, David Faust wrote: On 6/14/22 22:53, Yong

Re: [GCC 12 backport] Disable generating load/store vector pairs for block copies.

2022-07-14 Thread Michael Meissner via Gcc-patches
I have applied the patch to GCC 12. | From 22736f3d0d4fb8ce4afb3230023f8accdb03a623 Mon Sep 17 00:00:00 2001 | From: Michael Meissner | Date: Thu, 14 Jul 2022 11:16:08 -0400 | Subject: [PATCH] [BACKPORT] Disable generating load/store vector pairs for block copies. Testing has found that using l

[PATCH] PR target/106278: Keep REG_EQUAL notes consistent during TImode STV.

2022-07-14 Thread Roger Sayle
This patch resolves PR target/106278 a regression on x86_64 caused by my recent TImode STV improvements. Now that TImode STV can handle comparisons such as "(set (regs:CC) (compare:CC (reg:TI) ...))" the convert_insn method sensibly checks that the mode of the SET_DEST is TImode before setting it

Re: [PATCH] match.pd: Add new abs pattern [PR94290]

2022-07-14 Thread Andrew Pinski via Gcc-patches
On Thu, Jul 14, 2022 at 7:09 AM Sam Feifer wrote: > > > On Wed, Jul 13, 2022 at 3:36 PM Andrew Pinski wrote: >> >> On Wed, Jul 13, 2022 at 12:26 PM Sam Feifer via Gcc-patches >> wrote: >> > >> > This patch is intended to fix a missed optimization in match.pd. It >> > optimizes (x >= 0 ? x : 0)

[PATCH v3] c++: Add __reference_con{struc,ver}ts_from_temporary [PR104477]

2022-07-14 Thread Marek Polacek via Gcc-patches
On Tue, Jul 12, 2022 at 04:10:08PM -0400, Jason Merrill wrote: > On 7/8/22 13:41, Marek Polacek wrote: > > +bool > > +reference_from_temporary (tree to, tree from, bool direct_init_p) > > +{ > > + /* Check is_reference. */ > > + if (!TYPE_REF_P (to)) > > +return false; > > + /* Check is_con

[PATCH] x86: Disable sibcall if indirect_return attribute doesn't match

2022-07-14 Thread H.J. Lu via Gcc-patches
When shadow stack is enabled, function with indirect_return attribute may return via indirect jump. In this case, we need to disable sibcall if caller doesn't have indirect_return attribute and indirect branch tracking is enabled since compiler won't generate ENDBR when calling the caller. gcc/

Re: [PATCH] c++: Add __reference_con{struc,ver}ts_from_temporary [PR104477]

2022-07-14 Thread Marek Polacek via Gcc-patches
On Tue, Jul 12, 2022 at 04:15:00PM -0400, Jason Merrill wrote: > On 7/12/22 16:10, Jason Merrill wrote: > > On 7/8/22 13:41, Marek Polacek wrote: > > > This patch implements C++23 P2255R2, which adds two new type traits to > > > detect reference binding to a temporary.  They can be used to detect c

Re: [RFC] RISC-V: Add support for RV64E/lp64e

2022-07-14 Thread Palmer Dabbelt
On Tue, 12 Jul 2022 22:09:53 PDT (-0700), Palmer Dabbelt wrote: gcc/ChangeLog * config.gcc (riscv): Accept rv64e and lp64e. * config/riscv/arch-canonicalize: Likewise. * config/riscv/riscv-c.cc (riscv_cpu_cpp_builtins): Likewise. * config/riscv/riscv-opts.h (riscv

Re: [GCC 11 backport] Disable generating load/store vector pairs for block copies.

2022-07-14 Thread Michael Meissner via Gcc-patches
Back port patch (changing .cc to .c) from trunk to GCC 11 committed. | From 3118d0856b030fe491a170354fed2df570df199f Mon Sep 17 00:00:00 2001 | From: Michael Meissner | Date: Thu, 14 Jul 2022 14:03:37 -0400 | Subject: [PATCH] [BACKPORT] Disable generating load/store vector pairs for block copies

[PATCH] jit: Make recording::memento non-copyable

2022-07-14 Thread Jonathan Wakely via Gcc-patches
These polymoprhic types don't appear to be copied anywhere. Rather than trying to reason about what it means to copy a polymoprhic base without copying the derived part, disable copies. This also avoids a potential double-free if a recorindg::string object does somehow get copied (it owns a pointer

Re: [PATCH] jit: Make recording::memento non-copyable

2022-07-14 Thread David Malcolm via Gcc-patches
On Thu, 2022-07-14 at 19:44 +0100, Jonathan Wakely wrote: > These polymoprhic types don't appear to be copied anywhere. Rather > than > trying to reason about what it means to copy a polymoprhic base > without > copying the derived part, disable copies. This also avoids a > potential > double-free

Re: [PATCH] PR target/106278: Keep REG_EQUAL notes consistent during TImode STV.

2022-07-14 Thread Uros Bizjak via Gcc-patches
On Thu, Jul 14, 2022 at 6:58 PM Roger Sayle wrote: > > > This patch resolves PR target/106278 a regression on x86_64 caused by my > recent TImode STV improvements. Now that TImode STV can handle comparisons > such as "(set (regs:CC) (compare:CC (reg:TI) ...))" the convert_insn method > sensibly c

Re: [PATCH] match.pd: Add new abs pattern [PR94290]

2022-07-14 Thread Sam Feifer via Gcc-patches
On Thu, Jul 14, 2022 at 1:24 PM Andrew Pinski wrote: > On Thu, Jul 14, 2022 at 7:09 AM Sam Feifer wrote: > > > > > > On Wed, Jul 13, 2022 at 3:36 PM Andrew Pinski wrote: > >> > >> On Wed, Jul 13, 2022 at 12:26 PM Sam Feifer via Gcc-patches > >> wrote: > >> > > >> > This patch is intended to fi

Re: [PATCH] match.pd: Add new abs pattern [PR94290]

2022-07-14 Thread Andrew Pinski via Gcc-patches
On Thu, Jul 14, 2022 at 12:38 PM Sam Feifer wrote: > > > > On Thu, Jul 14, 2022 at 1:24 PM Andrew Pinski wrote: >> >> On Thu, Jul 14, 2022 at 7:09 AM Sam Feifer wrote: >> > >> > >> > On Wed, Jul 13, 2022 at 3:36 PM Andrew Pinski wrote: >> >> >> >> On Wed, Jul 13, 2022 at 12:26 PM Sam Feifer via

Re: [PATCH 2/3] tree-cfg: do not duplicate returns_twice calls

2022-07-14 Thread Alexander Monakov via Gcc-patches
On Thu, 14 Jul 2022, Richard Biener wrote: > Indeed. Guess that's what __builtin_setjmp[_receiver] for SJLJ_EH got > "right". > > When copying a block we do not copy labels so any "jumps" remain to the > original > block and thus we are indeed able to isolate normal control flow. Given that

[PATCH, committed] Fortran: error recovery for bad initializers of implied-shape arrays [PR106209]

2022-07-14 Thread Harald Anlauf via Gcc-patches
Dear all, the attached patch introduces error recovery for two cases of using an invalid array in a declaration of an implied-shape array instead of hitting internal errors. Initial patch by Steve. The final version was approved in the PR by Steve. Committed as: https://gcc.gnu.org/g:748f8a8b1

Re: [PATCH] Revert "[PATCH] RISC-V: Use new linker emulations for glibc ABI."

2022-07-14 Thread Palmer Dabbelt
On Mon, 20 Jun 2022 20:48:50 PDT (-0700), gcc-patches@gcc.gnu.org wrote: On Mon, Jun 20, 2022 at 1:21 AM Kito Cheng wrote: Generally I agree we should fix that by GCC driver rather than ld emulation, but I think this should be reverted with the -L path fix, otherwise that will break multilib o

Re: [PATCH] Revert "[PATCH] RISC-V: Use new linker emulations for glibc ABI."

2022-07-14 Thread Fangrui Song via Gcc-patches
On 2022-07-14, Palmer Dabbelt wrote: On Mon, 20 Jun 2022 20:48:50 PDT (-0700), gcc-patches@gcc.gnu.org wrote: On Mon, Jun 20, 2022 at 1:21 AM Kito Cheng wrote: Generally I agree we should fix that by GCC driver rather than ld emulation, but I think this should be reverted with the -L path fix

Re: [PATCH v3] Simplify memchr with small constant strings

2022-07-14 Thread H.J. Lu via Gcc-patches
On Wed, Jul 13, 2022 at 11:42 PM Richard Biener wrote: > > On Wed, Jul 13, 2022 at 6:50 PM H.J. Lu wrote: > > > > When memchr is applied on a constant string of no more than the bytes of > > a word, simplify memchr by checking each byte in the constant string. > > > > int f (int a) > > { > >r

[PATCH] libcpp: Improve encapsulation of label_text

2022-07-14 Thread Jonathan Wakely via Gcc-patches
I'm not sure if label_text::get () is the best name for the new accessor. Other options include buffer () and c_str () but I don't see a compelling reason to prefer either of those. As a follow-up patch we could change label_text::m_buffer (and pod_label_text::m_buffer) to be const char*, since th

Re: [GCC 12 backport] Disable generating load/store vector pairs for block copies.

2022-07-14 Thread Segher Boessenkool
On Thu, Jul 14, 2022 at 11:20:56AM -0400, Michael Meissner wrote: > I have applied the patch to GCC 12. > > | From 22736f3d0d4fb8ce4afb3230023f8accdb03a623 Mon Sep 17 00:00:00 2001 > | From: Michael Meissner > | Date: Thu, 14 Jul 2022 11:16:08 -0400 > | Subject: [PATCH] [BACKPORT] Disable generat

Re: [PATCH] libcpp: Improve encapsulation of label_text

2022-07-14 Thread David Malcolm via Gcc-patches
On Thu, 2022-07-14 at 22:10 +0100, Jonathan Wakely wrote: Thanks for the patch. > I'm not sure if label_text::get () is the best name for the new > accessor. Other options include buffer () and c_str () but I don't > see a > compelling reason to prefer either of those. label_text::get should ret

Re: [GCC 12 backport] Disable generating load/store vector pairs for block copies.

2022-07-14 Thread Michael Meissner via Gcc-patches
On Thu, Jul 14, 2022 at 04:12:14PM -0500, Segher Boessenkool wrote: > On Thu, Jul 14, 2022 at 11:20:56AM -0400, Michael Meissner wrote: > > I have applied the patch to GCC 12. > > > > | From 22736f3d0d4fb8ce4afb3230023f8accdb03a623 Mon Sep 17 00:00:00 2001 > > | From: Michael Meissner > > | Date:

[PATCH] libphobos: Fix instability in the parallelized testsuite

2022-07-14 Thread Lewis Hyatt via Gcc-patches
Hello- I get a different number of test results from libphobos.unittest/unittest.exp, depending on server load. I believe it's because this testsuite doesn't check runtest_file_p: $ make -j 1 RUNTESTFLAGS='unittest.exp' check-target-libphobos | grep '^#' # of expected passes 10 $ make

[PATCH] stack-protector: Check stack canary for noreturn function

2022-07-14 Thread H.J. Lu via Gcc-patches
Check stack canary for noreturn function to catch stack corruption before calling noreturn function. For C++, check stack canary when throwing exception or resuming stack unwind to avoid corrupted stack. gcc/ PR middle-end/58245 * calls.cc (expand_call): Check stack canary for no

Re: [GCC 12 backport] Disable generating load/store vector pairs for block copies.

2022-07-14 Thread Segher Boessenkool
On Thu, Jul 14, 2022 at 05:49:57PM -0400, Michael Meissner wrote: > On Thu, Jul 14, 2022 at 04:12:14PM -0500, Segher Boessenkool wrote: > > You never posted the trunk version of this, so that never was approved > > either. > > I did post the trunk version on June 10th, and your only comment was fi

Re: kernel sparse annotations vs. compiler attributes and debug_annotate_{type, decl} WAS: Re: [PATCH 0/9] Add debug_annotate attributes

2022-07-14 Thread Yonghong Song via Gcc-patches
On 7/14/22 8:09 AM, Jose E. Marchesi wrote: Hi Yonghong. On 7/7/22 1:24 PM, Jose E. Marchesi wrote: Hi Yonghong. On 6/21/22 9:12 AM, Jose E. Marchesi wrote: On 6/17/22 10:18 AM, Jose E. Marchesi wrote: Hi Yonghong. On 6/15/22 1:57 PM, David Faust wrote: On 6/14/22 22:53, Yonghong

Re: [PATCH, committed] Fortran: error recovery for bad initializers of implied-shape arrays [PR106209]

2022-07-14 Thread Jerry D via Gcc-patches
Hi Herald, Looks good to me. I have always preferred informative messages. Thanks, Jerry On 7/14/22 1:34 PM, Harald Anlauf via Fortran wrote: Dear all, the attached patch introduces error recovery for two cases of using an invalid array in a declaration of an implied-shape array instead of

Re: [PATCH] i386: Fix _mm_[u]comixx_{ss,sd} codegen and add PF result. [PR106113]

2022-07-14 Thread Hongtao Liu via Gcc-patches
On Thu, Jul 14, 2022 at 2:11 PM Kong, Lingling via Gcc-patches wrote: > > Hi, > > The patch is to fix _mm_[u]comixx_{ss,sd} codegen and add PF result. These > intrinsics have changed over time, like `_mm_comieq_ss ` old operation is > `RETURN ( a[31:0] == b[31:0] ) ? 1 : 0`, and new operation u

Re: [PATCH] x86: Disable sibcall if indirect_return attribute doesn't match

2022-07-14 Thread Hongtao Liu via Gcc-patches
On Fri, Jul 15, 2022 at 1:44 AM H.J. Lu via Gcc-patches wrote: > > When shadow stack is enabled, function with indirect_return attribute > may return via indirect jump. In this case, we need to disable sibcall > if caller doesn't have indirect_return attribute and indirect branch > tracking is en

Re: [PATCH] c++: Add __reference_con{struc,ver}ts_from_temporary [PR104477]

2022-07-14 Thread Jason Merrill via Gcc-patches
On 7/14/22 13:43, Marek Polacek wrote: On Tue, Jul 12, 2022 at 04:15:00PM -0400, Jason Merrill wrote: On 7/12/22 16:10, Jason Merrill wrote: On 7/8/22 13:41, Marek Polacek wrote: This patch implements C++23 P2255R2, which adds two new type traits to detect reference binding to a temporary.  Th