Re: [PATCH, rs6000] Add multiply-add expand pattern [PR103109]

2022-07-31 Thread Kewen.Lin via Gcc-patches
Hi Haochen, Thanks for the patch, some comments are inlined. on 2022/7/25 13:11, HAO CHEN GUI wrote: > Hi, > This patch adds an expand and several insns for multiply-add with > three 64bit operands. > > Bootstrapped and tested on powerpc64-linux BE and LE with no regressions. > Is this okay

[COMMITTED] Make irange dependency explicit for range_of_ssa_name_with_loop_info.

2022-07-31 Thread Aldy Hernandez via Gcc-patches
Even though ranger is type agnostic, SCEV seems to only work with integers. This patch removes some FIXME notes making it explicit that bounds_of_var_in_loop only works with iranges. Tested on x86-64 Linux. gcc/ChangeLog: * gimple-range-fold.cc (fold_using_range::range_of_phi): Only

[COMMITTED] const_tree conversion of vrange::supports_*

2022-07-31 Thread Aldy Hernandez via Gcc-patches
Make all vrange::supports_*_p methods const_tree as they can end up being called from functions that are const_tree. Tested on x86-64 Linux. gcc/ChangeLog: * value-range.cc (vrange::supports_type_p): Use const_tree. (irange::supports_type_p): Same. (frange::supports_type_

[COMMITTED] Cleanups to frange.

2022-07-31 Thread Aldy Hernandez via Gcc-patches
These are some assorted cleanups to the frange class to make it easier to drop in an implementation with FP endpoints: * frange::set() had some asserts limiting the type of arguments passed. There's no reason why we can't handle all the variants. Worse comes to worse, we can always return a V

[PATCH V2] libcpp: Optimize #pragma once with a hash table [PR58770]

2022-07-31 Thread Paul Hollinsky via Gcc-patches
Rather than traversing the all_files linked list for every include, this factors out the quick idempotency checks (modification time and size) to be the keys in a hash table so we can find matching files quickly. The hash table value type is a linked list, in case more than one file matches the qu

Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream

2022-07-31 Thread Martin Liška
On 7/29/22 08:38, Dimitrije Milosevic wrote: > Thanks Martin! I'm sending out the output from git format-patch as an > attachment to this email. You're welcome, pushed as r13-1909-g1efeaf99bd8bdf. Cheers, Martin

Re: ICE after folding svld1rq to vec_perm_expr duing forwprop

2022-07-31 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 21 Jul 2022 at 12:21, Richard Biener wrote: > > On Wed, Jul 20, 2022 at 5:36 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 18 Jul 2022 at 11:57, Richard Biener > > wrote: > > > > > > On Fri, Jul 15, 2022 at 3:49 PM Prathamesh Kulkarni > > > wrote: > > > > > > > > On Thu, 14 Jul 2022

Ping^2 [PATCH v6, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

2022-07-31 Thread HAO CHEN GUI via Gcc-patches
Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597158.html Thanks. On 4/7/2022 下午 2:32, HAO CHEN GUI wrote: > Hi, >Gentle ping this: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597158.html > Thanks. > > On 24/6/2022 上午 10:02, HAO CHEN GUI wrote: >> Hi,

Ping^2 [PATCH v2, rs6000] Use CC for BCD operations [PR100736]

2022-07-31 Thread HAO CHEN GUI via Gcc-patches
Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597020.html Thanks. On 4/7/2022 下午 2:33, HAO CHEN GUI wrote: > Hi, >Gentle ping this: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597020.html > Thanks. > > On 22/6/2022 下午 4:26, HAO CHEN GUI wrote: >> Hi,

Ping [PATCH, rs6000] Add multiply-add expand pattern [PR103109]

2022-07-31 Thread HAO CHEN GUI via Gcc-patches
Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598744.html Thanks On 25/7/2022 下午 1:11, HAO CHEN GUI wrote: > Hi, > This patch adds an expand and several insns for multiply-add with > three 64bit operands. > > Bootstrapped and tested on powerpc64-linux BE and LE

Ping [PATCH v3] Modify combine pattern by a pseudo AND with its nonzero bits [PR93453]

2022-07-31 Thread HAO CHEN GUI via Gcc-patches
Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598685.html Thanks. On 22/7/2022 下午 3:07, HAO CHEN GUI wrote: > Hi, > This patch creates a new function - change_pseudo_and_mask. If recog fails, > the function converts a single pseudo to the pseudo AND with a mask if

Re: [PATCH] tree-optimization/105679 - disable backward threading of unlikely entry

2022-07-31 Thread Jeff Law via Gcc-patches
On 7/31/2022 1:17 PM, Iain Sandoe via Gcc-patches wrote: Hi Richi, On 29 Jul 2022, at 09:54, Richard Biener via Gcc-patches wrote: The following makes the backward threader reject threads whose entry edge is probably never executed according to the profile. That in particular, for the te

Re: [PATCH 2/3] testsuite: Add tests for C2X N2653 char8_t and UTF-8 string literal changes

2022-07-31 Thread Tom Honermann via Gcc-patches
On 7/27/22 7:23 PM, Joseph Myers wrote: On Mon, 25 Jul 2022, Tom Honermann via Gcc-patches wrote: This change provides new tests for the core language and compiler dependent library changes adopted for C2X via WG14 N2653. I'd expect this patch also to add tests verifying that u8"" strings have

Re: [PATCH 1/1] c++/106423: Fix pragma suppression of -Wc++20-compat diagnostics.

2022-07-31 Thread Tom Honermann via Gcc-patches
On 7/31/22 11:05 AM, Lewis Hyatt wrote: On Sat, Jul 30, 2022 at 7:06 PM Tom Honermann via Gcc-patches wrote: On 7/27/22 7:09 PM, Joseph Myers wrote: On Sun, 24 Jul 2022, Tom Honermann via Gcc-patches wrote: Gcc's '#pragma GCC diagnostic' directives are processed in "early mode" (see handle_

[PATCH] configure: respect --with-build-time-tools [PR43301]

2022-07-31 Thread Eric Gallager via Gcc-patches
Hi, there's been a patch sitting in bug 43301 for over a decade that I think still makes sense to apply, so I rebased it against current trunk and found that it still applies. It just makes the configure script respect the --with-build-time-tools flag. OK to commit? ChangeLog: PR bootstrap/43

Re: [PATCH] tree-optimization/105679 - disable backward threading of unlikely entry

2022-07-31 Thread Iain Sandoe via Gcc-patches
Hi Richi, > On 29 Jul 2022, at 09:54, Richard Biener via Gcc-patches > wrote: > > The following makes the backward threader reject threads whose entry > edge is probably never executed according to the profile. That in > particular, for the testcase, avoids threading the irq == 1 check > on th

Re: [PATCH, v4] Fortran: detect blanks within literal constants in free-form mode [PR92805]

2022-07-31 Thread Harald Anlauf via Gcc-patches
Hi Mikael, Am 31.07.22 um 10:35 schrieb Mikael Morin: Le 30/07/2022 à 21:40, Harald Anlauf a écrit : Hi Mikael, Am 30.07.22 um 10:28 schrieb Mikael Morin: Meh! We killed one check for gfc_current_form but the other one is still there. OK, match_kind_param calls two functions that also gobble

Re: [RFA] Implement basic range operators to enable floating point VRP.

2022-07-31 Thread Aldy Hernandez via Gcc-patches
PING Andrew, anyone, would you mind giving this a once over? I realize reviewing ranger's range-op code is not on anyone's list of priorities, but I could use a sanity check. The patch is sufficiently self-contained to easily catch anything caused by it, and I'd like to commit earlier in the wee

Re: PING [PATCH] x86: Add ix86_ifunc_ref_local_ok

2022-07-31 Thread Uros Bizjak via Gcc-patches
On Wed, Jul 27, 2022 at 4:47 PM H.J. Lu wrote: > > On Thu, Jul 21, 2022 at 11:53 AM H.J. Lu wrote: > > > > We can't always use the PLT entry as the function address for local IFUNC > > functions. When the PIC register is needed for PLT call, indirect call > > via the PLT entry will fail since th

Re: [x86_64 PATCH] Add rotl64ti2_doubleword pattern to i386.md

2022-07-31 Thread Uros Bizjak via Gcc-patches
On Fri, Jul 29, 2022 at 8:10 AM Roger Sayle wrote: > > > This patch adds rot[lr]64ti2_doubleword patterns to the x86_64 backend, > to move splitting of 128-bit TImode rotates by 64 bits after reload, > matching what we now do for 64-bit DImode rotations by 32 bits with -m32. > > In theory moving w

Re: [x86_64 PATCH take #2] PR target/106450: Tweak timode_remove_non_convertible_regs.

2022-07-31 Thread Uros Bizjak via Gcc-patches
On Sat, Jul 30, 2022 at 11:42 AM Roger Sayle wrote: > > > Many thanks to H.J. for pointing out a better idiom for traversing > the USEs (and also DEFs) of TImode registers in an instruction. > > This revised patched has been tested on x86_64-pc-linux-gnu with > make bootstrap and make -k check, bo

Re: [x86 PATCH] Support logical shifts by (some) integer constants in TImode STV.

2022-07-31 Thread Uros Bizjak via Gcc-patches
On Fri, Jul 29, 2022 at 12:18 AM Roger Sayle wrote: > > > This patch improves TImode STV by adding support for logical shifts by > integer constants that are multiples of 8. For the test case: > > __int128 a, b; > void foo() { a = b << 16; } > > on x86_64, gcc -O2 currently generates: > >

Re: [GCC 12] [PATCH] x86: Support 2/4/8 byte constant vector stores

2022-07-31 Thread Uros Bizjak via Gcc-patches
On Wed, Jul 27, 2022 at 4:24 PM H.J. Lu wrote: > > On Fri, Jul 1, 2022 at 8:31 AM Uros Bizjak wrote: > > > > On Thu, Jun 30, 2022 at 4:50 PM H.J. Lu wrote: > > > > > > 1. Add a predicate for constant vectors which can be converted to integer > > > constants suitable for constant integer stores.

Re: [PATCH] c: Fix location for _Pragma tokens [PR97498]

2022-07-31 Thread Jeff Law via Gcc-patches
On 7/31/2022 6:44 AM, Lewis Hyatt wrote: On Sat, Jul 30, 2022 at 10:43 PM Jeff Law wrote: There was a request to backport this (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97498#c7) since it is relevant to this one: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106267. Is that OK as well for

Re: [PATCH 1/1] c++/106423: Fix pragma suppression of -Wc++20-compat diagnostics.

2022-07-31 Thread Lewis Hyatt via Gcc-patches
On Sat, Jul 30, 2022 at 7:06 PM Tom Honermann via Gcc-patches wrote: > > On 7/27/22 7:09 PM, Joseph Myers wrote: > > On Sun, 24 Jul 2022, Tom Honermann via Gcc-patches wrote: > > > >> Gcc's '#pragma GCC diagnostic' directives are processed in "early mode" > >> (see handle_pragma_diagnostic_early)

Re: [PATCH] c: Fix location for _Pragma tokens [PR97498]

2022-07-31 Thread Lewis Hyatt via Gcc-patches
On Sat, Jul 30, 2022 at 10:43 PM Jeff Law wrote: > > There was a request to backport this > > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97498#c7) since it is > > relevant to this one: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106267. Is that OK as > > well for any of the current release

Re: [PATCH] libfortran: Fix up boz_15.f90 on powerpc64le with -mabi=ieeelongdouble [PR106079]

2022-07-31 Thread Thomas Koenig via Gcc-patches
Hi Jakub, The boz_15.f90 test FAILs on powerpc64le-linux when -mabi=ieeelongdouble is used (either default through --with-long-double-format=ieee or when used explicitly). The problem is that the read/write transfer routines are called with BT_REAL (or BT_COMPLEX) type and kind 17 which is magic

Re: [PATCH v3] LoongArch: add addr_global attribute

2022-07-31 Thread Chenghua Xu
在 2022/7/30 上午1:17, Xi Ruoyao via Gcc-patches 写道: Change v2 to v3: - Disable section anchor for addr_global symbols. - Use -O2 in test to make sure section anchor is disabled. -- Background: https://lore.kernel.org/loongarch/d7670b60-2782-4642-995b-7baa01779...@loongson.cn/T/#e1d47e2fe185f2e2

Re: [committed] wwwdocs: cxx-status: Move www.open-std.org to https

2022-07-31 Thread Jonathan Wakely via Gcc-patches
" On Sat, 30 Jul 2022 at 22:28, Gerald Pfeifer wrote: > > This is a trivial change which fixes several dozen links. > > Marek, Jason, Jonathan - I noticed that (in other places) we have both > links to www.open-std.org and open-std.org, both of which seem to work. > > What is the preferred spelli

Re: [PATCH, v4] Fortran: detect blanks within literal constants in free-form mode [PR92805]

2022-07-31 Thread Mikael Morin
Le 30/07/2022 à 21:40, Harald Anlauf a écrit : Hi Mikael, Am 30.07.22 um 10:28 schrieb Mikael Morin: Meh! We killed one check for gfc_current_form but the other one is still there. OK, match_kind_param calls two functions that also gobble space, so there is work remaining here. So please make m