Re: [PATCH] Fortran: fix ICE in check_charlen_present [PR108420]

2023-01-22 Thread Paul Richard Thomas via Gcc-patches
Hi Harald, This is fine for mainline and for backporting if you feel so inclined. Thanks for the patch. Paul On Mon, 16 Jan 2023 at 21:12, Harald Anlauf via Fortran wrote: > Dear all, > > it appears that the fix for pr107874 uncovered a latent bug > for the case of arrays of type character

Re: [PATCH] tree-optimization/108449 - keep maybe_special_function_p behavior

2023-01-22 Thread Richard Biener via Gcc-patches
On Sat, 21 Jan 2023, Jan Hubicka wrote: > > When we have a static declaration without definition we diagnose > > that and turn it into an extern declaration. That can alter > > the outcome of maybe_special_function_p here and there's really > > no point in doing that, so don't. > > > >

Re: [PATCH] modula2/108144 - Fix multilib install of libgm2

2023-01-22 Thread Richard Biener via Gcc-patches
On Fri, 20 Jan 2023, NightStrike wrote: > On Fri, Jan 20, 2023 at 1:40 PM Gaius Mulley via Gcc-patches > wrote: > > > > Richard Biener writes: > > > > > The following adjusts libgm2 to properly use the multilib build > > > infrastructure, thereby fixing the install with > > >

Re: [PATCH] modula-2, driver, Front end: Revise handling of I and L paths [PR108182].

2023-01-22 Thread Richard Biener via Gcc-patches
On Tue, Jan 17, 2023 at 6:05 PM Iain Sandoe via Gcc-patches wrote: > > Tested on x86_64-linux-gnu (with a 32b multilib), powerpc, i686 and > x86_64-darwin. OK for trunk? Reading through the patch I fear there's more issues lurking (-sysroot?) but this seems to be a step in the right direction,

[PATCH][_GLIBCXX_DEBUG] Remove useless checks

2023-01-22 Thread François Dumont via Gcc-patches
    libstdc++: [_GLIBCXX_DEBUG] Remove useless constructor checks     Creating a safe iterator from a normal iterator is done within the library where we     already know that it is done correctly. The rare situation where a user would use safe     iterators for his own purpose is non-Standard

Re: [PATCH v4] xtensa: Eliminate the use of callee-saved register that saves and restores only once

2023-01-22 Thread Takayuki 'January June' Suwa via Gcc-patches
On 2023/01/23 0:45, Max Filippov wrote: > On Fri, Jan 20, 2023 at 8:39 PM Takayuki 'January June' Suwa > wrote: >> On 2023/01/21 0:14, Max Filippov wrote: >>> After having this many attempts and getting to the issues that are >>> really hard to detect I wonder if the target backend is the right

Re: [wwwdocs] lists: Add documentation about the Sourceware public-inbox

2023-01-22 Thread Arsen Arsenović via Gcc-patches
Arsen Arsenović writes: > --- > Evening, > > I've gone through lists.html and documented the Sourceware public-inbox > instance, since it seems to be commonly missed, yet some might find useful. > > This patch includes: > - A brief summary of what the public-inbox provides, > - A brief

[wwwdocs] lists: Add documentation about the Sourceware public-inbox

2023-01-22 Thread Arsen Arsenović via Gcc-patches
--- Evening, I've gone through lists.html and documented the Sourceware public-inbox instance, since it seems to be commonly missed, yet some might find useful. This patch includes: - A brief summary of what the public-inbox provides, - A brief summary on alternative methods of accessing the

[pushed] c++: lifetime extension with .* expression [PR53288]

2023-01-22 Thread Jason Merrill via Gcc-patches
Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- This PR points out a case where we are not extending the lifetime of a temporary when the subobject is denoted by a pointer-to-member operation. These rules were clarified in C++20 by CWG1299. There are other cases that also need to be

Re: [PATCH] c++: Handle structured bindings like anon unions in initializers [PR108474]

2023-01-22 Thread Jason Merrill via Gcc-patches
On 1/22/23 15:50, Jakub Jelinek wrote: On Sun, Jan 22, 2023 at 03:40:26PM -0500, Jason Merrill wrote: 2023-01-21 Jakub Jelinek PR c++/108474 * cp-gimplify.cc (cp_fold_r): Handle structured bindings vars like anon union artificial vars. *

Re: [PATCH] c++: Handle structured bindings like anon unions in initializers [PR108474]

2023-01-22 Thread Jakub Jelinek via Gcc-patches
On Sun, Jan 22, 2023 at 03:40:26PM -0500, Jason Merrill wrote: > > 2023-01-21 Jakub Jelinek > > > > PR c++/108474 > > * cp-gimplify.cc (cp_fold_r): Handle structured bindings > > vars like anon union artificial vars. > > > > * g++.dg/cpp1z/decomp57.C: New test. > > *

Re: [PATCH] c++: Handle structured bindings like anon unions in initializers [PR108474]

2023-01-22 Thread Jason Merrill via Gcc-patches
On 1/21/23 04:59, Jakub Jelinek wrote: Hi! As reported by Andrew Pinski, structured bindings (with the exception of the ones using std::tuple_{size,element} and get which are really standalone variables in addition to the binding one) also use DECL_VALUE_EXPR and needs the same treatment in

[committed] pru: Fix CLZ expansion for QI and HI modes

2023-01-22 Thread Dimitar Dimitrov
The recent gcc.dg/tree-ssa/clz-char.c test case failed for PRU target, exposing a wrong code generation bug in the PRU backend. The "clz" pattern did not produce correct output for QI and HI input operand modes. SI mode is ok. The "clz" pattern is expanded to an LMBD instruction to get the

*PING* [PATCH] Fortran: fix ICE in check_charlen_present [PR108420]

2023-01-22 Thread Harald Anlauf via Gcc-patches
Ping! Am 16.01.23 um 22:11 schrieb Harald Anlauf via Gcc-patches: Dear all, it appears that the fix for pr107874 uncovered a latent bug for the case of arrays of type character and size zero when passed to the intrinsics MERGE and SPREAD as SOURCE. In that case, there is no constructor from

Re: [PATCH] RISC-V: Change VSETVL PASS always call split_all_insns

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/17/23 19:50, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong Since LCM will destroy CFG, we are going to reorder the location of VSETVL PASS at least before bbro (block-reorder PASS) which is before split3 PASS. We need to call it in VSETVL PASS to get final RVV instructions patterns.

Re: [PATCH] RISC-V: Remove DCE in VSETVL PASS

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/17/23 19:53, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (pass_vsetvl::done): Remove DCE. * config/riscv/t-riscv: Ditto. OK. Presumably this is because the pass is now placed before DCE. Jeff

Re: [PATCH] RISC-V: Clang-format some annotations[NFC]

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/17/23 19:58, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc: Clang-format. OK. jeff

Re: [PATCH] RISC-V: Reorder VSETVL PASS location

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/17/23 20:03, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong gcc/ChangeLog: * config/riscv/riscv-passes.def (INSERT_PASS_BEFORE): Reorder VSETVL PASS. It'd be useful to know the motivation here, I could easily see someone in the future finding a case where the location of

Re: [PATCH] RISC-V: Change parse_insn into public for future use.

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/17/23 20:06, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong gcc/ChangeLog: * config/riscv/riscv-vsetvl.h: Change it into public. OK. jeff

Re: [PATCH] RISC-V: Add :: for static function calling to avoid confusing

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/17/23 20:16, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong Since we have same function in class and static function calling get_avl. Adding :: to avoid codes confusing. gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (pass_vsetvl::get_backward_fusion_type): Add ::. Is there

Re: [PATCH] RISC-V: Add TARGET_MIN_VLEN > 32 into iterators of EEW = 64 vector modes

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/20/23 02:33, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong According to RVV ISA, RVV doesn't support EEW == 64 vector type for zve32x and zve32f. So it makes sense add predicate in the iterators of EEW = 64 vector modes. gcc/ChangeLog: * config/riscv/vector-iterators.md:

Re: [PATCH 2/2] Corrected pr25521.c target matching.

2023-01-22 Thread Jeff Law via Gcc-patches
On 12/7/22 08:45, Cupertino Miranda wrote: On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: This commit is a follow up of bugzilla #107181. The commit /a0aafbc/ changed the default implementation of the SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the

Re: [PATCH 1/2] select .rodata for const volatile variables.

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/9/23 00:57, Richard Biener wrote: On Mon, Dec 5, 2022 at 7:07 PM Jeff Law via Gcc-patches wrote: On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: Changed target code to select .rodata section for 'const volatile' defined variables. This change is in the context of the

Re: [PATCH 1/2] select .rodata for const volatile variables.

2023-01-22 Thread Jeff Law via Gcc-patches
On 1/19/23 02:59, Cupertino Miranda wrote: Hi Jeff, Kindly calling your attention to this thread. Sorry, just crazy busy around here. Jeff

Re: [PATCH] Modula-2, testsuite: Remove use of concatenated paths.

2023-01-22 Thread Gaius Mulley via Gcc-patches
Iain Sandoe writes: > tested on x86_64-darwin21 with an updated compiler that does not support > the path concatentation and on an unpatched trunk. > OK for trunk? > thanks > Iain > > --- 8< --- > > The original implementation for Modula-2 search paths allows things like > '-I/path/a:/path/b'.

[PATCH] Modula-2, testsuite: Remove use of concatenated paths.

2023-01-22 Thread Iain Sandoe via Gcc-patches
tested on x86_64-darwin21 with an updated compiler that does not support the path concatentation and on an unpatched trunk. OK for trunk? thanks Iain --- 8< --- The original implementation for Modula-2 search paths allows things like '-I/path/a:/path/b'. Such paths are not compatible with the

Re: [patch, gfortran.dg] Adjust numerous tests so that they pass on line endings

2023-01-22 Thread Jerry D via Gcc-patches
On 1/22/23 5:38 AM, Mikael Morin wrote: Hello, Le 22/01/2023 à 00:59, Jerry D via Fortran a écrit : (...) Proposed ChangeLog entry using git gcc-commit-mklog: Author: Jerry DeLisle Date:   Sat Jan 21 15:47:19 2023 -0800 Revise the line end tests to pass on certain windows test

Re: [PATCH v4] xtensa: Eliminate the use of callee-saved register that saves and restores only once

2023-01-22 Thread Max Filippov via Gcc-patches
On Fri, Jan 20, 2023 at 8:39 PM Takayuki 'January June' Suwa wrote: > On 2023/01/21 0:14, Max Filippov wrote: > > After having this many attempts and getting to the issues that are > > really hard to detect I wonder if the target backend is the right place > > for this optimization? > > > I guess

Re: [patch, gfortran.dg] Adjust numerous tests so that they pass on line endings

2023-01-22 Thread Mikael Morin
Hello, Le 22/01/2023 à 00:59, Jerry D via Fortran a écrit : (...) Proposed ChangeLog entry using git gcc-commit-mklog: Author: Jerry DeLisle Date:   Sat Jan 21 15:47:19 2023 -0800     Revise the line end tests to pass on certain windows test environments     which inject spurious /r

[pushed] wwwdocs: gcc-10: Grammar fixes in the amdgcn section

2023-01-22 Thread Gerald Pfeifer
I missed this originally and noticed looking for something else. Pushed. Gerald --- htdocs/gcc-10/changes.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index 2bad8ea3..4acc8d12 100644 ---

Re: [pushed] Darwin, libffi, testsuite: Ensure we pick up the convenience lib.

2023-01-22 Thread Iain Sandoe
Hi Rainer, > On 22 Jan 2023, at 09:44, Rainer Orth wrote: > >> Tested on i686, powerpc, x86_64, Arm64 Darwin, x86_64-linux-gnu, >> pushed to trunk, thanks, >> Iain >> >> --- 8< --- >> >> For several Darwin linker versions, the link paths are first traversed >> looking for shared libraries,

Re: [pushed] Darwin, libffi, testsuite: Ensure we pick up the convenience lib.

2023-01-22 Thread Rainer Orth
Hi Iain, > Tested on i686, powerpc, x86_64, Arm64 Darwin, x86_64-linux-gnu, > pushed to trunk, thanks, > Iain > > --- 8< --- > > For several Darwin linker versions, the link paths are first traversed > looking for shared libraries, and then again looking for archives. > > We want the paths to be

[pushed] Darwin, libffi, testsuite: Ensure we pick up the convenience lib.

2023-01-22 Thread Iain Sandoe via Gcc-patches
Tested on i686, powerpc, x86_64, Arm64 Darwin, x86_64-linux-gnu, pushed to trunk, thanks, Iain --- 8< --- For several Darwin linker versions, the link paths are first traversed looking for shared libraries, and then again looking for archives. We want the paths to be searched for both shared