[PATCH] i386: Clear REG_UNUSED and REG_DEAD notes from the IL at the end of vzeroupper pass [PR113059]

2024-01-31 Thread Jakub Jelinek
Hi! The move of the vzeroupper pass from after reload pass to after postreload_cse helped only partially, CSE-like passes can still invalidate those notes (especially REG_UNUSED) if they use some earlier register holding some value later on in the IL. So, either we could try to move it one pass f

[PATCH] lower-bitint: Fix up VIEW_CONVERT_EXPR handling in handle_operand_addr [PR113639]

2024-01-31 Thread Jakub Jelinek
Hi! Yet another spot where we need to treat VIEW_CONVERT_EXPR differently from NOP_EXPR/CONVERT_EXPR. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2024-01-31 Jakub Jelinek PR tree-optimization/113639 * gimple-lower-bitint.cc (bitint_large_huge::handle_

[PATCH] dwarf2out: Fix ICE on large _BitInt in loc_list_from_tree_1 [PR113637]

2024-01-31 Thread Jakub Jelinek
Hi! This spot uses SCALAR_INT_TYPE_MODE which obviously ICEs for large/huge BITINT_TYPE types which have BLKmode. But such large BITINT_TYPEs certainly don't fit into DWARF2_ADDR_SIZE either, so we can just assume it would be false if type has BLKmode. Bootstrapped/regtested on x86_64-linux and

[PATCH] simplify-rtx: Fix up last argument to simplify_gen_unary [PR113656]

2024-01-31 Thread Jakub Jelinek
Hi! When simplifying e.g. (float_truncate:SF (float_truncate:DF (reg:XF)) or (float_truncate:SF (float_extend:XF (reg:DF)) etc. into (float_truncate:SF (reg:XF)) or (float_truncate:SF (reg:DF)) we call simplify_gen_unary with incorrect op_mode argument, it should be the argument's mode, but we cal

Re: [PATCH] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Richard Biener
On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek wrote: > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > -- >8 -- > We plan to deprecate -fconcepts-ts in GCC 15 and remove the flag_concepts_ts > code. This note is an admonishing reminder to convert the Concepts TS > code to C++2

Re: [PATCH RFA] asan: poisoning promoted statics [PR113531]

2024-01-31 Thread Richard Biener
On Wed, Jan 31, 2024 at 4:38 AM Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu, OK for trunk? It's a quite "late" fixup, I suppose you have tried to avoid marking it during gimplification? I see we do parts of this during BIND_EXPR processing which is indeed a bit early but possibly difficu

Re: About 31109 - gprofng not built and installed in a combined binutils+gcc build

2024-01-31 Thread Richard Biener
On Wed, Jan 31, 2024 at 4:46 AM Vladimir Mezentsev wrote: > > Hi, > > I asked in https://sourceware.org/bugzilla/show_bug.cgi?id=31109 > > I prepared a patch for the releases/gcc-13 branch. > > Richard Biener rejected my patch for > this branch. > > Which branch should I use? master, trunk or

Re: [PATCH RFA] asan: poisoning promoted statics [PR113531]

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 09:51:05AM +0100, Richard Biener wrote: > On Wed, Jan 31, 2024 at 4:38 AM Jason Merrill wrote: > > > > Tested x86_64-pc-linux-gnu, OK for trunk? > > It's a quite "late" fixup, I suppose you have tried to avoid marking it > during gimplification? I see we do parts of this

Re: [PATCH] lower-bitint: Fix up VIEW_CONVERT_EXPR handling in handle_operand_addr [PR113639]

2024-01-31 Thread Richard Biener
On Wed, 31 Jan 2024, Jakub Jelinek wrote: > Hi! > > Yet another spot where we need to treat VIEW_CONVERT_EXPR differently > from NOP_EXPR/CONVERT_EXPR. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK > 2024-01-31 Jakub Jelinek > > PR tree-optimization/1136

Re: [PATCH] dwarf2out: Fix ICE on large _BitInt in loc_list_from_tree_1 [PR113637]

2024-01-31 Thread Richard Biener
On Wed, 31 Jan 2024, Jakub Jelinek wrote: > Hi! > > This spot uses SCALAR_INT_TYPE_MODE which obviously ICEs for large/huge > BITINT_TYPE types which have BLKmode. But such large BITINT_TYPEs certainly > don't fit into DWARF2_ADDR_SIZE either, so we can just assume it would be > false if type ha

Re: [PATCH] simplify-rtx: Fix up last argument to simplify_gen_unary [PR113656]

2024-01-31 Thread Richard Biener
On Wed, 31 Jan 2024, Jakub Jelinek wrote: > Hi! > > When simplifying e.g. (float_truncate:SF (float_truncate:DF (reg:XF)) > or (float_truncate:SF (float_extend:XF (reg:DF)) etc. into > (float_truncate:SF (reg:XF)) or (float_truncate:SF (reg:DF)) we call > simplify_gen_unary with incorrect op_mode

[PATCH] tree-optimization/113670 - gather/scatter to/from hard registers

2024-01-31 Thread Richard Biener
The following makes sure we're not taking the address of hard registers when vectorizing appearant gathers or scatters to/from them. Bootstrapped and tested on x86_64-unkown-linux-gnu, pushed. PR tree-optimization/113670 * tree-vect-data-refs.cc (vect_check_gather_scatter):

Re: [PATCH] aarch64: Avoid out-of-range shrink-wrapped saves [PR111677]

2024-01-31 Thread Richard Sandiford
Alex Coplan writes: > Hi, > > The PR shows us ICEing due to an unrecognizable TFmode save emitted by > aarch64_process_components. The problem is that for T{I,F,D}mode we > conservatively require mems to be in range for x-register ldp/stp. That > is because (at least for TImode) it can be alloca

Re: [PATCH][GCC 13] aarch64: Avoid out-of-range shrink-wrapped saves [PR111677]

2024-01-31 Thread Richard Sandiford
Alex Coplan writes: > Bootstrapped/regtested on aarch64-linux-gnu, OK for the 13 branch after > a week of the trunk fix being in? OK for the other active branches if > the same changes test cleanly there? > > GCC 14 patch for reference: > https://gcc.gnu.org/pipermail/gcc-patches/2024-January/644

Re: [PATCH] libstdc++: Enable std::text_encoding for darwin and FreeBSD

2024-01-31 Thread Iain Sandoe
Hi Jonathan, > On 30 Jan 2024, at 15:02, Jonathan Wakely wrote: > > This should fix the std/text_encoding/* FAILs that Iain sees on darwin. > I assume it will make it work for FreeBSD too. > > I won't push this until I hear it works for at least one of those. It works on x86_64-darwin{19,21,23

[PATCH] RISC-V: Support scheduling for sifive p600 series

2024-01-31 Thread Monk Chiang
Add sifive p600 series scheduler module. For more information see https://www.sifive.com/cores/performance-p650-670. Add sifive-p650, sifive-p670 for mcpu option will come in separate patches. gcc/ChangeLog: * config/riscv/riscv.md: Add "fcvt_i2f", "fcvt_f2i" type attribute, and in

[committed] libstdc++: Fix -Wshift-count-overflow warning in std::bitset

2024-01-31 Thread Jonathan Wakely
Tested x86_64-linux and aarch64-linux. Pushed to trunk. -- >8 -- This shift only happens if the unsigned long long type is wider than unsigned long but the compiler warns when it sees the shift, without caring if it's reachable. Use the preprocessor to compare the sizes and just reuse _M_to_ulon

[committed] libstdc++: Add all supported headers to lists in the manual

2024-01-31 Thread Jonathan Wakely
Another piece of the manual that needs to be kept up to date as we add features. Pushed to trunk. -- >8 -- libstdc++-v3/ChangeLog: * doc/xml/manual/using.xml: Update tables of supported headers. * doc/html/*: Regenerate. --- libstdc++-v3/doc/html/manual/index.html | 2 +

[committed] libstdc++: Add "ASCII" as an alias for std::text_encoding::id::ASCII

2024-01-31 Thread Jonathan Wakely
SG16 (Unicode and Text Study Group) and LWG are overwhelmingly in favour of adding this alias, so let's not wait for the issue to get voted into the working draft. Tested aarch64-linux. Pushed to trunk. -- >8 -- As noted in LWG 4043, "ASCII" is not an alias for any known registered character enc

Re: [PATCH] libstdc++: Enable std::text_encoding for darwin and FreeBSD

2024-01-31 Thread Jonathan Wakely
On Wed, 31 Jan 2024 at 09:38, Iain Sandoe wrote: > > Hi Jonathan, > > > On 30 Jan 2024, at 15:02, Jonathan Wakely wrote: > > > > This should fix the std/text_encoding/* FAILs that Iain sees on darwin. > > I assume it will make it work for FreeBSD too. > > > > I won't push this until I hear it work

Re: [PATCH V2] rs6000: New pass for replacement of adjacent loads fusion (lxv).

2024-01-31 Thread Ajit Agarwal
Hello Alex: Thanks for your valuable review comments. I am incorporating the comments and would send the patch with rs6000 and AARCH64 changes. Thanks & Regards Ajit On 24/01/24 10:13 pm, Alex Coplan wrote: > Hi Ajit, > > On 21/01/2024 19:57, Ajit Agarwal wrote: >> >> Hello All: >> >> New pass

GCN, RDNA 3: Adjust 'sync_compare_and_swap_lds_insn'

2024-01-31 Thread Thomas Schwinge
Hi! OK to push "GCN, RDNA 3: Adjust 'sync_compare_and_swap_lds_insn'", see attached? In pre-RDNA 3 ISA manuals, there are notes for 'DS_CMPST_[...]', like: Caution, the order of src and cmp are the *opposite* of the BUFFER_ATOMIC_CMPSWAP opcode. ..., and conversely in the RDNA 3 ISA manual

[PATCH] gimple-fold: Remove .ASAN_MARK calls on TREE_STATIC variables [PR113531]

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 10:07:28AM +0100, Jakub Jelinek wrote: > Indeed. But what we could do is try to fold_stmt those .ASAN_MARK calls > away earlier (but sure, the asan.cc change would be still required because > that would be just an optimization). But that can be handled incrementally, > so

Re: GCN, RDNA 3: Adjust 'sync_compare_and_swap_lds_insn'

2024-01-31 Thread Andrew Stubbs
On 31/01/2024 10:36, Thomas Schwinge wrote: Hi! OK to push "GCN, RDNA 3: Adjust 'sync_compare_and_swap_lds_insn'", see attached? In pre-RDNA 3 ISA manuals, there are notes for 'DS_CMPST_[...]', like: Caution, the order of src and cmp are the *opposite* of the BUFFER_ATOMIC_CMPSWAP opcode

[PATCH] tree-optimization/113630 - invalid code hoisting

2024-01-31 Thread Richard Biener
The following avoids code hoisting (but also PRE insertion) of expressions that got value-numbered to another one that are not a valid replacement (but still compute the same value). This time because the access path ends in a structure with different size, meaning we consider a related access as

Re: [PATCH] LoongArch: Fix soft-float builds of libffi

2024-01-31 Thread Xi Ruoyao
On Sat, 2024-01-27 at 15:09 +0800, Yang Yujie wrote: > This patch correspond to the upstream PR: > https://github.com/libffi/libffi/pull/817 > > libffi/ChangeLog: > > * src/loongarch64/ffi.c: Avoid defining floats > in struct call_context if the ABI is soft-float. You need to wait un

[PATCH] match: Fix vcond into conditional op folding [PR113607].

2024-01-31 Thread Robin Dapp
Hi, in PR113607 we see an invalid fold of _429 = .COND_SHL (mask_patt_205.47_276, vect_cst__262, vect_cst__262, { 0, ... }); vect_prephitmp_129.51_282 = _429; vect_iftmp.55_287 = VEC_COND_EXPR ; to Applying pattern match.pd:9607, gimple-match-10.cc:3817 gimple_simplified to vect_iftm

[PATCH] libgcc: Fix up i386/t-heap-trampoline [PR113403]

2024-01-31 Thread Jakub Jelinek
On Sun, Jan 28, 2024 at 02:07:32PM +, Iain Sandoe wrote: > --- a/libgcc/config/aarch64/t-heap-trampoline > +++ b/libgcc/config/aarch64/t-heap-trampoline > @@ -16,4 +16,5 @@ > # along with GCC; see the file COPYING3. If not see > # . > > -LIB2ADD += $(srcdir)/c

[PATCH] libgcc: Avoid warnings on __gcc_nested_func_ptr_created [PR113402]

2024-01-31 Thread Jakub Jelinek
On Sun, Jan 28, 2024 at 11:02:33AM +, Iain Sandoe wrote: > * config/aarch64/heap-trampoline.c: Rename > __builtin_nested_func_ptr_created to __gcc_nested_func_ptr_created and > __builtin_nested_func_ptr_deleted to __gcc_nested_func_ptr_deleted. > * config/i386/heap-tramp

Re: [PATCH] gimple-fold: Remove .ASAN_MARK calls on TREE_STATIC variables [PR113531]

2024-01-31 Thread Richard Biener
On Wed, Jan 31, 2024 at 12:18 PM Jakub Jelinek wrote: > > On Wed, Jan 31, 2024 at 10:07:28AM +0100, Jakub Jelinek wrote: > > Indeed. But what we could do is try to fold_stmt those .ASAN_MARK calls > > away earlier (but sure, the asan.cc change would be still required because > > that would be jus

Re: [PATCH] match: Fix vcond into conditional op folding [PR113607].

2024-01-31 Thread Richard Biener
On Wed, Jan 31, 2024 at 12:50 PM Robin Dapp wrote: > > Hi, > > in PR113607 we see an invalid fold of > > _429 = .COND_SHL (mask_patt_205.47_276, vect_cst__262, vect_cst__262, { 0, > ... }); > vect_prephitmp_129.51_282 = _429; > vect_iftmp.55_287 = VEC_COND_EXPR vect_prephitmp_129.51_282, v

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Richard Biener
On Tue, 30 Jan 2024, Andre Vieira wrote: > > This patch adds stmt_vec_info to TARGET_SIMD_CLONE_USABLE to make sure the > target can reject a simd_clone based on the vector mode it is using. > This is needed because for VLS SVE vectorization the vectorizer accepts > Advanced SIMD simd clones when

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Richard Biener
On Wed, 31 Jan 2024, Richard Biener wrote: > On Tue, 30 Jan 2024, Andre Vieira wrote: > > > > > This patch adds stmt_vec_info to TARGET_SIMD_CLONE_USABLE to make sure the > > target can reject a simd_clone based on the vector mode it is using. > > This is needed because for VLS SVE vectorization

Re: [PATCH 2/3] vect: disable multiple calls of poly simdclones

2024-01-31 Thread Richard Biener
On Tue, 30 Jan 2024, Andre Vieira wrote: > > The current codegen code to support VF's that are multiples of a simdclone > simdlen rely on BIT_FIELD_REF to create multiple input vectors. This does not > work for non-constant simdclones, so we should disable using such clones when > the VF is a mu

[COMMITTED] testsuite: Require ucn in g++.dg/cpp0x/udlit-extended-id-1.C

2024-01-31 Thread Rainer Orth
g++.dg/cpp0x/udlit-extended-id-1.C FAILs on Solaris/SPARC and x86 with the native assembler: UNRESOLVED: g++.dg/cpp0x/udlit-extended-id-1.C -std=c++14 compilation failed to produce executable FAIL: g++.dg/cpp0x/udlit-extended-id-1.C -std=c++17 (test for excess errors) UNRESOLVED: g++.dg/cpp0x/u

Re: [PATCH v3 4/5] Add tests for C/C++ musttail attributes

2024-01-31 Thread Prathamesh Kulkarni
On Wed, 31 Jan 2024 at 07:49, Andi Kleen wrote: > > Mostly adopted from the existing C musttail plugin tests. > --- > gcc/testsuite/c-c++-common/musttail1.c | 17 > gcc/testsuite/c-c++-common/musttail2.c | 36 + > gcc/testsuite/c-c++-common/musttail3.c | 31

[PATCH] tree-optimization/111444 - avoid insertions when skipping defs

2024-01-31 Thread Richard Biener
The following avoids inserting expressions for IPA CP discovered equivalences into the VN hashtables when we are optimistically skipping may-defs in the attempt to prove it's redundant. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/111444 * tree

[PATCH] testsuite: i386: Disable .eh_frame in gcc.target/i386/auto-init-5.c etc.

2024-01-31 Thread Rainer Orth
The gcc.target/i386/auto-init-5.c and gcc.target/i386/auto-init-6.c tests FAIL on 64-bit Solaris/x86 with the native assembler: FAIL: gcc.target/i386/auto-init-5.c scan-assembler-times .long\\t0 14 FAIL: gcc.target/i386/auto-init-6.c scan-assembler-times long\\t0 8 /bin/as doesn't fully suppo

Re: [PATCH] RISC-V: Support scheduling for sifive p600 series

2024-01-31 Thread Robin Dapp
> + NULL, /* vector cost */ > +}; Does the P600 series include a vector unit? From what I found on the web it looks like it. If so I would suggest specifying at least the default (generic) vector cost model here. We fall back to the default one for

Re: [PATCH] testsuite: i386: Disable .eh_frame in gcc.target/i386/auto-init-5.c etc.

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 01:50:33PM +0100, Rainer Orth wrote: > The gcc.target/i386/auto-init-5.c and gcc.target/i386/auto-init-6.c > tests FAIL on 64-bit Solaris/x86 with the native assembler: > > FAIL: gcc.target/i386/auto-init-5.c scan-assembler-times .long\\t0 14 > FAIL: gcc.target/i386/aut

[PATCH] testsuite: i386: Fix gcc.target/i386/no-callee-saved-1.c etc. on Solaris/x86

2024-01-31 Thread Rainer Orth
The gcc.target/i386/no-callee-saved-[12].c tests FAIL on Solaris/x86: FAIL: gcc.target/i386/no-callee-saved-1.c scan-assembler-not push FAIL: gcc.target/i386/no-callee-saved-2.c scan-assembler-not push In both cases, the test expect the Linux/x86 default of -fomit-frame-pointer, while Solaris/x86

[PATCH] testsuite: i386: Fix gcc.target/i386/pr38534-1.c etc. on Solaris/x86

2024-01-31 Thread Rainer Orth
The gcc.target/i386/pr38534-1.c etc. tests FAIL on 32 and 64-bit Solaris/x86: FAIL: gcc.target/i386/pr38534-1.c scan-assembler-not push FAIL: gcc.target/i386/pr38534-2.c scan-assembler-not push FAIL: gcc.target/i386/pr38534-3.c scan-assembler-not push FAIL: gcc.target/i386/pr38534-4.c scan-assembl

[PATCH] uninit-pr108968-register.c: use __UINTPTR_TYPE__ for LLP64

2024-01-31 Thread Jonathan Yong
Ensure sp variable is long enough by using __UINTPTR_TYPE__ for rsp. Attached patch okay? Changes unsigned long to __UINTPTR_TYPE__.From 8b5e79e1345d99ec6d3595013a20a9c672edb403 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Wed, 31 Jan 2024 13:31:30 + Subject: [PATCH]

Re: [PATCH v3 2/2] arm: Add support for MVE Tail-Predicated Low Overhead Loops

2024-01-31 Thread Richard Earnshaw (lists)
On 30/01/2024 14:09, Andre Simoes Dias Vieira wrote: > Hi Richard, > > Thanks for the reviews, I'm making these changes but just a heads up. > > When hardcoding LR_REGNUM like this we need to change the way we compare the > register in doloop_condition_get. This function currently compares the r

Re: [PATCH RFA] asan: poisoning promoted statics [PR113531]

2024-01-31 Thread Jason Merrill
On 1/31/24 03:51, Richard Biener wrote: On Wed, Jan 31, 2024 at 4:38 AM Jason Merrill wrote: Tested x86_64-pc-linux-gnu, OK for trunk? It's a quite "late" fixup, I suppose you have tried to avoid marking it during gimplification? I see we do parts of this during BIND_EXPR processing which i

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Andre Vieira (lists)
On 31/01/2024 12:13, Richard Biener wrote: On Wed, 31 Jan 2024, Richard Biener wrote: On Tue, 30 Jan 2024, Andre Vieira wrote: This patch adds stmt_vec_info to TARGET_SIMD_CLONE_USABLE to make sure the target can reject a simd_clone based on the vector mode it is using. This is needed bec

Re: [PATCH] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Jason Merrill
On 1/31/24 03:40, Richard Biener wrote: On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- We plan to deprecate -fconcepts-ts in GCC 15 and remove the flag_concepts_ts code. This note is an admonishing reminder to conve

Re: [PATCH] uninit-pr108968-register.c: use __UINTPTR_TYPE__ for LLP64

2024-01-31 Thread Richard Biener
On Wed, Jan 31, 2024 at 2:39 PM Jonathan Yong <10wa...@gmail.com> wrote: > > Ensure sp variable is long enough by using __UINTPTR_TYPE__ for > rsp. > > Attached patch okay? Changes unsigned long to __UINTPTR_TYPE__. OK.

Re: [PATCH] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Richard Biener
On Wed, Jan 31, 2024 at 2:53 PM Jason Merrill wrote: > > On 1/31/24 03:40, Richard Biener wrote: > > On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek wrote: > >> > >> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > >> > >> -- >8 -- > >> We plan to deprecate -fconcepts-ts in GCC 15 an

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Richard Biener
On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: > > > On 31/01/2024 12:13, Richard Biener wrote: > > On Wed, 31 Jan 2024, Richard Biener wrote: > > > >> On Tue, 30 Jan 2024, Andre Vieira wrote: > >> > >>> > >>> This patch adds stmt_vec_info to TARGET_SIMD_CLONE_USABLE to make sure the > >>> ta

Unreviewed patches

2024-01-31 Thread Rainer Orth
Three patches have remained unreviewed for a week or more: c++: Fix g++.dg/ext/attr-section2.C etc. with Solaris/SPARC as https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643434.html This one may even be obvious. testsuite: i386: Fix gcc.target/i386/pr70321.c on 32-

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Richard Biener
On Wed, 31 Jan 2024, Richard Biener wrote: > On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: > > > > > > > On 31/01/2024 12:13, Richard Biener wrote: > > > On Wed, 31 Jan 2024, Richard Biener wrote: > > > > > >> On Tue, 30 Jan 2024, Andre Vieira wrote: > > >> > > >>> > > >>> This patch adds s

RE: [PATCH][libsanitizer]: Sync fixes for asan interceptors from upstream [PR112644]

2024-01-31 Thread Tamar Christina
> -Original Message- > From: Andrew Pinski > Sent: Monday, January 29, 2024 9:55 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; ja...@redhat.com; > do...@redhat.com; k...@google.com; dvyu...@google.com > Subject: Re: [PATCH][libsanitizer]: Sync fixes for asan interceptors fr

[PATCH 1/2][libsanitizer] hwasan: Remove testsuite check for a complaint message [PR112644]

2024-01-31 Thread Tamar Christina
Hi All, Recent libhwasan updates[1] intercept various string and memory functions. These functions have checking in them, which means there's no need to inline the checking. This patch marks said functions as intercepted, and adjusts a testcase to handle the difference. It also looks for HWASAN

[PATCH 2/2][libsanitizer] hwasan: Remove testsuite check for a complaint message [PR112644]

2024-01-31 Thread Tamar Christina
Hi All, With recent updates to hwasan runtime libraries, the error reporting for this particular check is has been reworked. I would question why it has lost this message. To me it looks strange that num_descriptions_printed is incremented whenever we call PrintHeapOrGlobalCandidate whether that

[PATCH] libgcc, v2: Fix up _BitInt division [PR113604]

2024-01-31 Thread Jakub Jelinek
Hi! On Sat, Jan 27, 2024 at 08:53:42AM +0100, Jakub Jelinek wrote: > The following testcase ends up with SIGFPE in __divmodbitint4. > The problem is a thinko in my attempt to implement Knuth's algorithm. Here is an updated version of the patch, the libgcc part is the same, but I've added a new te

[PATCH] middle-end/110176 - wrong zext (bool) <= (int) 4294967295u folding

2024-01-31 Thread Richard Biener
The following fixes a wrong pattern that didn't match the behavior of the original fold_widened_comparison in that get_unwidened returned a constant always in the wider type. But here we're using (int) 4294967295u without the conversion applied. Fixed by doing as earlier in the pattern - matching

Re: [PATCH 1/2][libsanitizer] hwasan: Remove testsuite check for a complaint message [PR112644]

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 02:17:00PM +, Tamar Christina wrote: > gcc/ChangeLog: > > PR sanitizer/112644 > * asan.h (asan_intercepted_p): Incercept memset, memmove, memcpy and > memcmp. > * builtins.cc (expand_builtin): Include HWASAN when checking for > builtin inli

Re: [PATCH 2/2][libsanitizer] hwasan: Remove testsuite check for a complaint message [PR112644]

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 02:18:53PM +, Tamar Christina wrote: > gcc/testsuite/ChangeLog: > > PR sanitizer/112644 > * c-c++-common/hwasan/hwasan-thread-clears-stack.c: Update testcase. LGTM. Jakub

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Andre Vieira (lists)
On 31/01/2024 13:58, Richard Biener wrote: On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: On 31/01/2024 12:13, Richard Biener wrote: On Wed, 31 Jan 2024, Richard Biener wrote: On Tue, 30 Jan 2024, Andre Vieira wrote: This patch adds stmt_vec_info to TARGET_SIMD_CLONE_USABLE to make

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Richard Biener
On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: > > > On 31/01/2024 13:58, Richard Biener wrote: > > On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: > > > >> > >> > >> On 31/01/2024 12:13, Richard Biener wrote: > >>> On Wed, 31 Jan 2024, Richard Biener wrote: > >>> > On Tue, 30 Jan 2024,

Re: About 31109 - gprofng not built and installed in a combined binutils+gcc build

2024-01-31 Thread Sam James
Richard Biener writes: > On Wed, Jan 31, 2024 at 4:46 AM Vladimir Mezentsev > wrote: >> >> Hi, >> >> I asked in https://sourceware.org/bugzilla/show_bug.cgi?id=31109 >> > I prepared a patch for the releases/gcc-13 branch. >> > Richard Biener rejected my patch for >> this branch. >> > Which

[PATCH] gimple-low: Remove .ASAN_MARK calls on TREE_STATIC variables [PR113531]

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 01:04:22PM +0100, Richard Biener wrote: > > Like this, so far just tested on the testcase. Ok for trunk if it passes > > bootstrap/regtest on top of Jason's patch? > > Note we fold all - well, all builtin - calls during gimple lowering. Internal calls aren't builtin, so t

Re: [PATCH] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Jason Merrill
On 1/31/24 08:55, Richard Biener wrote: On Wed, Jan 31, 2024 at 2:53 PM Jason Merrill wrote: On 1/31/24 03:40, Richard Biener wrote: On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- We plan to deprecate -fconcepts-

[PATCH v2] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Marek Polacek
On Wed, Jan 31, 2024 at 08:53:00AM -0500, Jason Merrill wrote: > On 1/31/24 03:40, Richard Biener wrote: > > On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek wrote: > > > > > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > > > > > -- >8 -- > > > We plan to deprecate -fconcepts-t

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Andre Vieira (lists)
On 31/01/2024 14:03, Richard Biener wrote: On Wed, 31 Jan 2024, Richard Biener wrote: On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: On 31/01/2024 12:13, Richard Biener wrote: On Wed, 31 Jan 2024, Richard Biener wrote: On Tue, 30 Jan 2024, Andre Vieira wrote: This patch adds stmt

Re: [PATCH] uninit-pr108968-register.c: use __UINTPTR_TYPE__ for LLP64

2024-01-31 Thread Jonathan Yong
On 1/31/24 13:52, Richard Biener wrote: On Wed, Jan 31, 2024 at 2:39 PM Jonathan Yong <10wa...@gmail.com> wrote: Ensure sp variable is long enough by using __UINTPTR_TYPE__ for rsp. Attached patch okay? Changes unsigned long to __UINTPTR_TYPE__. OK. Thanks, pushed to master branch.

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread Jakub Jelinek
On Tue, Jan 30, 2024 at 06:21:36PM -0800, H.J. Lu wrote: > Changes in v2: > > 1. Check decl non-null before dereferencing it. > 2. Update PR rtl-optimization/113617 from Thanks for updating the testcase. > --- a/gcc/varasm.cc > +++ b/gcc/varasm.cc > @@ -7459,16 +7459,46 @@ default_elf_select_rtx

Re: [PATCH 1/3] vect: Pass stmt_vec_info to TARGET_SIMD_CLONE_USABLE

2024-01-31 Thread Andre Vieira (lists)
On 31/01/2024 14:35, Richard Biener wrote: On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: On 31/01/2024 13:58, Richard Biener wrote: On Wed, 31 Jan 2024, Andre Vieira (lists) wrote: On 31/01/2024 12:13, Richard Biener wrote: On Wed, 31 Jan 2024, Richard Biener wrote: On Tue, 30 J

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread H.J. Lu
On Wed, Jan 31, 2024 at 8:30 AM Jakub Jelinek wrote: > > On Tue, Jan 30, 2024 at 06:21:36PM -0800, H.J. Lu wrote: > > Changes in v2: > > > > 1. Check decl non-null before dereferencing it. > > 2. Update PR rtl-optimization/113617 from > > Thanks for updating the testcase. > > > --- a/gcc/varasm.cc

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 08:48:33AM -0800, H.J. Lu wrote: > Which function (target hook) can I use to generate > > .section.data.rel.ro.local,"awG",@progbits,_ZN1AIxE3fooExx,comdat Just if (decl) return get_section (reloc == 1 ? ".data.rel.ro.loca

GCN: Remove 'SGPR_OR_VGPR_REGNO_P' definition (was: [PATCH v3 05/10] GCN back-end code)

2024-01-31 Thread Thomas Schwinge
Hi! On 2018-12-12T11:52:52+, Andrew Stubbs wrote: > This patch contains the major part of the GCN back-end. [...] > --- /dev/null > +++ b/gcc/config/gcn/gcn.h > +#define FIRST_SGPR_REG 0 > +#define SGPR_REGNO(N)((N)+FIRST_SGPR_REG) > +#define LAST_SGPR_REG

[PATCH] c++: ttp CTAD equivalence [PR112737]

2024-01-31 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Here during declaration matching we undesirably consider the two TT{42} CTAD expressions to be non-equivalent ultimately because for CTAD placeholder equivalence we compare the TEMPLATE_DECLs (which uses poin

Re: [PATCH] libstdc++: atomic: Add missing clear_padding in __atomic_float constructor

2024-01-31 Thread xndcn
Thanks! > Why not just use -latomic unconditionally here? testsuites of libstdc++ seems to have some tricks to find and link libatomic.a by using "dg-add-options libatomic", which do nothing for x86 target. In previous email, we decide not to pollute the current option, so we add a new libatomic_1

GCN: Remove 'FIRST_{SGPR,VGPR,AVGPR}_REG', 'LAST_{SGPR,VGPR,AVGPR}_REG' from machine description (was: [PATCH v3 04/10] GCN machine description)

2024-01-31 Thread Thomas Schwinge
Hi! On 2018-12-12T11:52:23+, Andrew Stubbs wrote: > This patch contains the machine description portion of the GCN back-end. > [...] > --- /dev/null > +++ b/gcc/config/gcn/gcn.md > +;; {{{ Constants and enums > + > +; Named registers > +(define_constants > + [(FIRST_SGPR_REG0

Re: GCN: Remove 'SGPR_OR_VGPR_REGNO_P' definition

2024-01-31 Thread Andrew Stubbs
On 31/01/2024 17:12, Thomas Schwinge wrote: Hi! On 2018-12-12T11:52:52+, Andrew Stubbs wrote: This patch contains the major part of the GCN back-end. [...] --- /dev/null +++ b/gcc/config/gcn/gcn.h +#define FIRST_SGPR_REG 0 +#define SGPR_REGNO(N) ((N)+FIRST_SGPR_REG) +#defin

[patch,avr,applied] Tabify avr.cc

2024-01-31 Thread Georg-Johann Lay
avr.cc still had a mix of spaces and TABs for indentation. This patch uses TABs according to the coding rules. Applied prior to the creation of the v14 branch so that master -> v14 back-porting will be easier. Johann -- AVR: Tabify avr.cc gcc/ * config/avr/avr.cc: Tabify. <>

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread H.J. Lu
On Wed, Jan 31, 2024 at 9:10 AM Jakub Jelinek wrote: > > On Wed, Jan 31, 2024 at 08:48:33AM -0800, H.J. Lu wrote: > > Which function (target hook) can I use to generate > > > > .section.data.rel.ro.local,"awG",@progbits,_ZN1AIxE3fooExx,comdat > > Just > if (decl) > return ge

Re: GCN: Remove 'FIRST_{SGPR,VGPR,AVGPR}_REG', 'LAST_{SGPR,VGPR,AVGPR}_REG' from machine description

2024-01-31 Thread Andrew Stubbs
On 31/01/2024 17:21, Thomas Schwinge wrote: Hi! On 2018-12-12T11:52:23+, Andrew Stubbs wrote: This patch contains the machine description portion of the GCN back-end. [...] --- /dev/null +++ b/gcc/config/gcn/gcn.md +;; {{{ Constants and enums + +; Named registers +(define_constants

Re: [PATCH] gimple-low: Remove .ASAN_MARK calls on TREE_STATIC variables [PR113531]

2024-01-31 Thread Richard Biener
> Am 31.01.2024 um 16:20 schrieb Jakub Jelinek : > > On Wed, Jan 31, 2024 at 01:04:22PM +0100, Richard Biener wrote: >>> Like this, so far just tested on the testcase. Ok for trunk if it passes >>> bootstrap/regtest on top of Jason's patch? >> >> Note we fold all - well, all builtin - calls

Re: [PATCH v3 1/5] Improve must tail in RTL backend

2024-01-31 Thread Marek Polacek
On Tue, Jan 30, 2024 at 06:17:14PM -0800, Andi Kleen wrote: > - Give error messages for all causes of non sibling call generation > - Don't override choices of other non sibling call checks with > must tail. This causes ICEs. The must tail attribute now only > overrides flag_optimize_sibling_calls

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 09:39:12AM -0800, H.J. Lu wrote: > GNU binutils has no issues with it: I know, I meant gcc. If I try the proposed: --- gcc/varasm.cc.jj2024-01-30 08:44:43.304175273 +0100 +++ gcc/varasm.cc 2024-01-31 18:45:57.271087170 +0100 @@ -7459,15 +7459,46 @@ default_elf_sel

Fwd: [Bug libstdc++/90276] PSTL tests fail in Debug Mode

2024-01-31 Thread François Dumont
I replied to bugzilla rather than sending to proper mailing list ! At the same time it looks like you also found the root cause of the problem Jonathan. Just let me know if you want to deal with it eventually. François Forwarded Message Subject:Re: [Bug libstdc++/90

Re: [PATCH] aarch64: Fix ICE in poly-int.h due to SLP.

2024-01-31 Thread Richard Ball
Hi Prathamesh, Thanks for the review, I missed that code up above. I've looking into this and it seems to me at least, that what you have suggested, is equivalent. I'll make the change and repost. Thanks, Richard From: Prathamesh Kulkarni Sent: 30 January 2024 1

[PATCH] Assuming the working GNU assembler with --with-gnu-as

2024-01-31 Thread H.J. Lu
When configuring GCC with --target=TARGET to build a cross compiler to reproduce a compiler bug, as and collect have ORIGINAL_AS_FOR_TARGET="" As the result, many target features are disabled which makes it almost impossible to reproduce the bug. Without assembler, the GCC build won't finish a

[PATCH] Assuming the working GNU assembler with --with-gnu-as

2024-01-31 Thread H.J. Lu
When configuring GCC with --target=TARGET to build a cross compiler to reproduce a compiler bug, as and collect have ORIGINAL_AS_FOR_TARGET="" As the result, many target features are disabled which makes it almost impossible to reproduce the bug. Without assembler, the GCC build won't finish a

[PATCH] varasm, v3: Handle private COMDAT function symbol reference in readonly data section [PR113617]

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 07:11:20PM +0100, Jakub Jelinek wrote: > On Wed, Jan 31, 2024 at 09:39:12AM -0800, H.J. Lu wrote: > > GNU binutils has no issues with it: > > I know, I meant gcc. > So, it seems get_section handles section purely by name lookup > and isn't prepared to deal with multiple dif

Re: [PATCH v2] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Jason Merrill
On 1/31/24 10:55, Marek Polacek wrote: On Wed, Jan 31, 2024 at 08:53:00AM -0500, Jason Merrill wrote: On 1/31/24 03:40, Richard Biener wrote: On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- We plan to deprecate -fco

[PATCH V4 2/4] RISC-V: Add vector related pipelines

2024-01-31 Thread Edwin Lu
Creates new generic vector pipeline file common to all cpu tunes. Moves all vector related pipelines from generic-ooo to generic-vector-ooo. Creates new vector crypto related insn reservations. gcc/ChangeLog: * config/riscv/generic-ooo.md (generic_ooo): Move reservation (generic_o

Re: [PATCH v2] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Marek Polacek
On Wed, Jan 31, 2024 at 02:00:18PM -0500, Jason Merrill wrote: > On 1/31/24 10:55, Marek Polacek wrote: > > On Wed, Jan 31, 2024 at 08:53:00AM -0500, Jason Merrill wrote: > > > On 1/31/24 03:40, Richard Biener wrote: > > > > On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek > > > > wrote: > > > > >

Re: Unreviewed patches

2024-01-31 Thread Uros Bizjak
On Wed, Jan 31, 2024 at 3:04 PM Rainer Orth wrote: > > Three patches have remained unreviewed for a week or more: > > c++: Fix g++.dg/ext/attr-section2.C etc. with Solaris/SPARC as > https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643434.html > > This one may even be obviou

Re: [PATCH] c++: ttp CTAD equivalence [PR112737]

2024-01-31 Thread Jason Merrill
On 1/31/24 12:12, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Here during declaration matching we undesirably consider the two TT{42} CTAD expressions to be non-equivalent ultimately because for CTAD placeholder equivalence we co

Re: [PATCH v2] c++: add deprecation notice for -fconcepts-ts

2024-01-31 Thread Jason Merrill
On 1/31/24 14:07, Marek Polacek wrote: On Wed, Jan 31, 2024 at 02:00:18PM -0500, Jason Merrill wrote: On 1/31/24 10:55, Marek Polacek wrote: On Wed, Jan 31, 2024 at 08:53:00AM -0500, Jason Merrill wrote: On 1/31/24 03:40, Richard Biener wrote: On Wed, Jan 31, 2024 at 12:19 AM Marek Polacek w

Re: [PATCH] testsuite: i386: Fix gcc.target/i386/pr38534-1.c etc. on Solaris/x86

2024-01-31 Thread Uros Bizjak
On Wed, Jan 31, 2024 at 2:02 PM Rainer Orth wrote: > > The gcc.target/i386/pr38534-1.c etc. tests FAIL on 32 and 64-bit > Solaris/x86: > > FAIL: gcc.target/i386/pr38534-1.c scan-assembler-not push > FAIL: gcc.target/i386/pr38534-2.c scan-assembler-not push > FAIL: gcc.target/i386/pr38534-3.c scan

Re: [PATCH] testsuite: i386: Fix gcc.target/i386/no-callee-saved-1.c etc. on Solaris/x86

2024-01-31 Thread Uros Bizjak
On Wed, Jan 31, 2024 at 1:57 PM Rainer Orth wrote: > > The gcc.target/i386/no-callee-saved-[12].c tests FAIL on Solaris/x86: > > FAIL: gcc.target/i386/no-callee-saved-1.c scan-assembler-not push > FAIL: gcc.target/i386/no-callee-saved-2.c scan-assembler-not push > > In both cases, the test expect

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread H.J. Lu
On Wed, Jan 31, 2024 at 10:11 AM Jakub Jelinek wrote: > > On Wed, Jan 31, 2024 at 09:39:12AM -0800, H.J. Lu wrote: > > GNU binutils has no issues with it: > > I know, I meant gcc. > If I try the proposed: > --- gcc/varasm.cc.jj2024-01-30 08:44:43.304175273 +0100 > +++ gcc/varasm.cc 2024-

Re: [PATCH 2/2] libstdc++: Implement P2165R4 changes to std::pair/tuple/etc

2024-01-31 Thread Patrick Palka
On Wed, 24 Jan 2024, Patrick Palka wrote: > On Wed, 24 Jan 2024, Patrick Palka wrote: > > > On Wed, 24 Jan 2024, Jonathan Wakely wrote: > > > > > On Wed, 24 Jan 2024 at 15:24, Patrick Palka wrote: > > > > > > > > On Wed, 24 Jan 2024, Jonathan Wakely wrote: > > > > > > > > > On Tue, 23 Jan 2024

Re: [PATCH v2] c++: avoid -Wdangling-reference for std::span-like classes [PR110358]

2024-01-31 Thread Alex Coplan
Hi Marek, On 30/01/2024 13:15, Marek Polacek wrote: > On Thu, Jan 25, 2024 at 10:13:10PM -0500, Jason Merrill wrote: > > On 1/25/24 20:36, Marek Polacek wrote: > > > Better version: > > > > > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > > > > > -- >8 -- > > > Real-world exp

Re: [PATCH v3 2/5] C++: Support clang compatible [[musttail]] (PR83324)

2024-01-31 Thread Marek Polacek
On Tue, Jan 30, 2024 at 06:17:15PM -0800, Andi Kleen wrote: > This patch implements a clang compatible [[musttail]] attribute for > returns. > > musttail is useful as an alternative to computed goto for interpreters. > With computed goto the interpreter function usually ends up very big > which ca

Re: [PATCH v2] c++: avoid -Wdangling-reference for std::span-like classes [PR110358]

2024-01-31 Thread Jason Merrill
On 1/31/24 14:44, Alex Coplan wrote: Hi Marek, On 30/01/2024 13:15, Marek Polacek wrote: On Thu, Jan 25, 2024 at 10:13:10PM -0500, Jason Merrill wrote: On 1/25/24 20:36, Marek Polacek wrote: Better version: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- Real-world exp

  1   2   >