Re: [Backport 1/2] tree-profile: Disable indirect call profiling for IFUNC resolvers

2024-04-14 Thread Richard Biener
On Mon, 15 Apr 2024, Richard Biener wrote: > On Sun, 14 Apr 2024, H.J. Lu wrote: > > > We can't profile indirect calls to IFUNC resolvers nor their callees as > > it requires TLS which hasn't been set up yet when the dynamic linker is > > resolving IFUNC symbols. > > > > Add an IFUNC resolver ca

Re: [Backport 1/2] tree-profile: Disable indirect call profiling for IFUNC resolvers

2024-04-14 Thread Richard Biener
On Sun, 14 Apr 2024, H.J. Lu wrote: > We can't profile indirect calls to IFUNC resolvers nor their callees as > it requires TLS which hasn't been set up yet when the dynamic linker is > resolving IFUNC symbols. > > Add an IFUNC resolver caller marker to cgraph_node and set it if the > function is

Re: [C PATCH, v2] Fix ICE with -g and -std=c23 related to incomplete types [PR114361]

2024-04-14 Thread Richard Biener
On Sun, 14 Apr 2024, Martin Uecker wrote: > > I had to revert the old patch because it broke LTO which lead > to PR114574. We now set TYPE_STRUCTURAL_EQUALITY and properly > update TYPE_CANONICAL for such types and also for pointers > to such types via a new function c_update_type_canonical > (t

[PATCH] [RISC-V] optimize Zicond conditional select cases.

2024-04-14 Thread Fei Gao
When one of the two input operands is 0, ADD and IOR are functionally equivalent. ADD is slightly preferred over IOR because ADD has a higher likelihood of being implemented as a compressed instruction when compared to IOR. C.ADD uses the CR format with any of the 32 RVI registers availble, while C

[PATCH v2] gcc-14: Mention that some warnings are now errors

2024-04-14 Thread Sebastian Huber
--- v2: Remove listing of options. htdocs/gcc-14/changes.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index 8ac08e9a..665d050a 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -231,6 +231,8 @@ a work-

[PATCH v2 2/2] c++/modules: Fix instantiation of imported temploid friends [PR114275]

2024-04-14 Thread Nathaniel Shead
I'm not a huge fan of always streaming 'imported_temploid_friends' for all decls, but I don't think it adds much performance cost over adding a new flag to categorise decls that might be marked as such. Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- This patch fixes a

[PATCH v2 1/2] c++: Standardise errors for module_may_redeclare

2024-04-14 Thread Nathaniel Shead
I took another look at this patch and have split it into two, one (this one) to standardise the error messages used and prepare 'module_may_redeclare' for use with temploid friends, and another followup patch to actually handle them correctly. Bootstrapped and regtested on x86_64-pc-linux-gnu, OK

Re: [PATCH] x86: Allow TImode offsettable memory only with 8-bit constant

2024-04-14 Thread Hongtao Liu
On Sat, Apr 13, 2024 at 6:42 AM H.J. Lu wrote: > > The x86 instruction size limit is 15 bytes. If a NDD instruction has > a segment prefix byte, a 4-byte opcode prefix, a MODRM byte, a SIB byte, > a 4-byte displacement and a 4-byte immediate, adding an address size > prefix will exceed the size l

[Backport 2/2] middle-end/114599 - fix bitmap allocation for check_ifunc_callee_symtab_nodes

2024-04-14 Thread H.J. Lu
From: Richard Biener There's no default bitmap obstack during global CTORs, so allocate the bitmap locally. PR middle-end/114599 PR gcov-profile/114115 * symtab.cc (ifunc_ref_map): Do not use auto_bitmap. (is_caller_ifunc_resolver): Optimize bitmap_bit_p/bitmap_se

[Backport 1/2] tree-profile: Disable indirect call profiling for IFUNC resolvers

2024-04-14 Thread H.J. Lu
We can't profile indirect calls to IFUNC resolvers nor their callees as it requires TLS which hasn't been set up yet when the dynamic linker is resolving IFUNC symbols. Add an IFUNC resolver caller marker to cgraph_node and set it if the function is called by an IFUNC resolver. Disable indirect c

Re: [PATCH V4 1/3] aarch64: Place target independent and dependent changed code in one file

2024-04-14 Thread Ajit Agarwal
Hello Alex: On 12/04/24 11:02 pm, Ajit Agarwal wrote: > Hello Alex: > > On 12/04/24 8:15 pm, Alex Coplan wrote: >> On 12/04/2024 20:02, Ajit Agarwal wrote: >>> Hello Alex: >>> >>> On 11/04/24 7:55 pm, Alex Coplan wrote: On 10/04/2024 23:48, Ajit Agarwal wrote: > Hello Alex: > > O

Re: [wwwdocs] gcc-14: Mention that some warnings are now errors

2024-04-14 Thread Jakub Jelinek
On Sun, Apr 14, 2024 at 05:55:03PM +0200, Gerald Pfeifer wrote: > Hi Sebastian, > > On Sat, 13 Apr 2024, Sebastian Huber wrote: > > + The following warnings are now errors (see also > > +Porting to GCC 14): > > + > > + -Werror=declaration-missing-parameter-type > > + -Werror=imp

Re: [wwwdocs] gcc-14: Mention that some warnings are now errors

2024-04-14 Thread Gerald Pfeifer
Hi Sebastian, On Sat, 13 Apr 2024, Sebastian Huber wrote: > + The following warnings are now errors (see also > +Porting to GCC 14): > + > + -Werror=declaration-missing-parameter-type > + -Werror=implicit-function-declaration > + -Werror=implicit-int > + -Werror=incomp

Re: [pushed] c++/modules: make bits_in/out move-constructible

2024-04-14 Thread Gerald Pfeifer
On Sat, 13 Apr 2024, Patrick Palka wrote: > Pushed as obvious after verifying C++11 bootstrap is restored. Thank you, Patrick! x86_64-unknown-freebsd13.2 is back to bootstrap again as well (with clang version 16.0.6). Gerald

Re: [C PATCH, v2] Fix ICE with -g and -std=c23 related to incomplete types [PR114361]

2024-04-14 Thread Martin Uecker
(new email for Joseph) Am Sonntag, dem 14.04.2024 um 14:30 +0200 schrieb Martin Uecker: > I had to revert the old patch because it broke LTO which lead > to PR114574. We now set TYPE_STRUCTURAL_EQUALITY and properly > update TYPE_CANONICAL for such types and also for pointers > to such types vi

[C PATCH, v2] Fix ICE with -g and -std=c23 related to incomplete types [PR114361]

2024-04-14 Thread Martin Uecker
I had to revert the old patch because it broke LTO which lead to PR114574. We now set TYPE_STRUCTURAL_EQUALITY and properly update TYPE_CANONICAL for such types and also for pointers to such types via a new function c_update_type_canonical (thanks to Jakob). Bootstrapped and regession tested o

Re: [PATCH] c++/modules: Setup aliases imported from modules [PR106820]

2024-04-14 Thread Nathaniel Shead
On Fri, Apr 12, 2024 at 03:54:21PM -0400, Jason Merrill wrote: > On 3/26/24 09:24, Nathaniel Shead wrote: > > > > I wonder if more generally we need to be doing more work when importing > > definitions from header units especially to handle all the work that > > 'make_rtl_for_nonlocal_decl' and 'r