[PATCH] testsuite: Fix PR108080 testcase for some targets [PR121396]

2025-08-16 Thread Nathaniel Shead
Tested on x86_64-pc-linux-gnu and verified with a powerpc64-linux-gnu cross. OK for trunk and 15? -- >8 -- I added a testcase for the (temporary) warning that we don't currently support the 'gnu::optimize' or 'gnu::target' attributes in r15-10183; however, some targets produce target nodes even

[PATCH] c++/modules: Fix exporting using-decls of unattached purview functions [PR120195]

2025-08-16 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- We have logic to adjust a function decl if it gets re-declared as a using-decl with different purviewness, but we also need to do the same if it gets redeclared with different exportedness. PR c++/120195 gcc/cp/Ch

Re: [PATCH 2/3] ira: tie output allocnos for fused instruction pairs

2025-08-16 Thread Jeff Law
On 8/16/25 4:16 AM, Artemiy Volkov wrote: On Sun, Aug 10, 2025 at 09:28:50AM -0600, Jeff Law wrote: Conceptually OK. I slightly worry about the use of PREV_INSN as we could conceptually end up with notes, line markers, etc between the two fusible insns. Right now the scheduler is the only p

Re: [PATCH] RISC-V: Fix block matching in arch-canonicalize [PR121538]

2025-08-16 Thread Jeff Law
On 8/16/25 8:43 AM, Kito Cheng wrote: LGTM, ok for the trunk, thanks! Note that while pre-commit CI is reporting failures, I was highly skeptical that they failures were at all related to Dimitar's work. So I spun his change in my tester successfully. I'll push it to the trunk momentarily

Re: [PATCH v2] x86: Add target("80387") function attribute

2025-08-16 Thread Hongtao Liu
On Sat, Aug 16, 2025 at 10:24 PM H.J. Lu wrote: > > On Sat, Aug 16, 2025 at 6:43 AM Hongtao Liu wrote: > > > > On Sat, Aug 16, 2025 at 8:45 PM Hongtao Liu wrote: > > > > > > On Fri, Aug 15, 2025 at 8:48 PM H.J. Lu wrote: > > > > > > > > On Fri, Aug 15, 2025 at 12:44 AM Hongtao Liu wrote: > > >

[PATCH] x86: Place the TLS call before all FLAGS_REG setting BBs

2025-08-16 Thread H.J. Lu
We can't place a TLS call before a conditional jump in a basic block like (code_label 13 11 14 4 2 (nil) [1 uses]) (note 14 13 16 4 [bb 4] NOTE_INSN_BASIC_BLOCK) (jump_insn 16 14 17 4 (set (pc) (if_then_else (le (reg:CCNO 17 flags) (const_int 0 [0])) (label_ref

[PATCH v2] c++: Fix ICE on mangling invalid compound requirement [PR120618]

2025-08-16 Thread Ben Wu
This testcase caused an ICE when mangling the invalid type-constraint in write_requirement since write_type_constraint expects a TEMPLATE_TYPE_PARM. Setting the trailing return type to NULL_TREE when a return-type-requirement is found in place of a type-constraint prevents the failed assertion in

Re: [PATCH] fortran: Set DECL_TLS_MODEL after processing a variable

2025-08-16 Thread Harald Anlauf
Am 01.08.25 um 14:00 schrieb H.J. Lu: Call set_decl_tls_model only after a variable has been fully processed, not in the middle of processing it. gcc/fortran/ PR fortran/107421 * trans-common.cc (build_common_decl): Call set_decl_tls_model after processing a variable.

[PATCH] Rewrite bool loads for undefined case [PR121279]

2025-08-16 Thread Andrew Pinski
Just like r16-465-gf2bb7ffe84840d8 but this time instead of a VCE there is a full on load from a boolean. This showed up when trying to remove the extra copy in the testcase from the revision mentioned above (pr120122-1.c). So when moving loads from a boolean type from being conditional to non-cond

Re: [PATCH] c++: Add testcases for the defarg part of P1766R1 [PR121552]

2025-08-16 Thread Jason Merrill
On 8/16/25 7:48 AM, Jakub Jelinek wrote: On Sat, Aug 16, 2025 at 09:14:23AM -0400, Jason Merrill wrote: I don't think this (or the following in this file) should be errors; we error currently because we don't implement textual deduplication (PR99000), but since the default arguments are the same

Re: [PATCH v2 1/3] AArch64: Support C/C++ operations on svbool_t

2025-08-16 Thread Jason Merrill
On 7/31/25 5:36 AM, Tejas Belagod wrote: Support a subset of C/C++ operations (bitwise, conditional etc.) on svbool_t. gcc/ChangeLog: * c-family/c-common.cc (c_build_vec_convert): Support vector boolean types for __builtin_convertvector (). (c_common_bool_type): New. Gi

Re: [PATCH] c++: Add testcases for the defarg part of P1766R1 [PR121552]

2025-08-16 Thread Jakub Jelinek
On Sat, Aug 16, 2025 at 09:14:23AM -0400, Jason Merrill wrote: > > I don't think this (or the following in this file) should be errors; we > > error currently because we don't implement textual deduplication > > (PR99000), but since the default arguments are the same, from the > > current wording t

Re: [PATCH] RISC-V: Fix block matching in arch-canonicalize [PR121538]

2025-08-16 Thread Kito Cheng
LGTM, ok for the trunk, thanks! Dimitar Dimitrov 於 2025年8月16日 週六,21:06寫道: > Commit r16-3028-g0c517ddf9b136c introduced parsing of conditional blocks > in riscv-ext*.def. For simplicity, it used a simple regular expression > to match the C++ lambda function for each condition. But the regular >

Re: [PATCH v2] x86: Add target("80387") function attribute

2025-08-16 Thread H.J. Lu
On Sat, Aug 16, 2025 at 6:43 AM Hongtao Liu wrote: > > On Sat, Aug 16, 2025 at 8:45 PM Hongtao Liu wrote: > > > > On Fri, Aug 15, 2025 at 8:48 PM H.J. Lu wrote: > > > > > > On Fri, Aug 15, 2025 at 12:44 AM Hongtao Liu wrote: > > > > > > > > On Fri, Aug 15, 2025 at 10:07 AM H.J. Lu wrote: > > >

Re: [PATCH v2] x86: Add target("80387") function attribute

2025-08-16 Thread Hongtao Liu
On Sat, Aug 16, 2025 at 8:45 PM Hongtao Liu wrote: > > On Fri, Aug 15, 2025 at 8:48 PM H.J. Lu wrote: > > > > On Fri, Aug 15, 2025 at 12:44 AM Hongtao Liu wrote: > > > > > > On Fri, Aug 15, 2025 at 10:07 AM H.J. Lu wrote: > > > > > > > > Add target("80387") attribute to enable and disable x87 i

Re: [PATCH v2] c++: Implement P2115R0 linkage changes for unnamed unscoped enums [PR120503]

2025-08-16 Thread Jason Merrill
On 8/15/25 4:04 PM, Nathaniel Shead wrote: On Sun, Aug 10, 2025 at 03:33:26PM -0700, Jason Merrill wrote: On 8/8/25 9:46 AM, Nathaniel Shead wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? Alternatively, if preferred I also experimented with a patch that cached the prop

Re: [PATCH] c++: Add testcases for the defarg part of P1766R1 [PR121552]

2025-08-16 Thread Jason Merrill
On 8/15/25 4:28 PM, Nathaniel Shead wrote: On Fri, Aug 15, 2025 at 12:38:01PM +0200, Jakub Jelinek wrote: Hi! The following patch adds some testcases for the default argument (function and template) part of the paper, making sure we diagnose multiple defargs in the same TU and when visible in m

[PATCH] RISC-V: Fix block matching in arch-canonicalize [PR121538]

2025-08-16 Thread Dimitar Dimitrov
Commit r16-3028-g0c517ddf9b136c introduced parsing of conditional blocks in riscv-ext*.def. For simplicity, it used a simple regular expression to match the C++ lambda function for each condition. But the regular expression is too simple - it matches only the first scoped code block, without any

Re: [PATCH v2] x86: Add target("80387") function attribute

2025-08-16 Thread Hongtao Liu
On Fri, Aug 15, 2025 at 8:48 PM H.J. Lu wrote: > > On Fri, Aug 15, 2025 at 12:44 AM Hongtao Liu wrote: > > > > On Fri, Aug 15, 2025 at 10:07 AM H.J. Lu wrote: > > > > > > Add target("80387") attribute to enable and disable x87 instructions in a > > > function. > > > > > > gcc/ > > > > > >

Ping: [PATCH] libcpp: Improve locations for macros defined prior to PCH include [PR105608]

2025-08-16 Thread Lewis Hyatt
https://gcc.gnu.org/pipermail/gcc-patches/2025-July/691235.html Ping please? Thanks! -Lewis On Wed, Jul 30, 2025 at 7:21 PM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105608 > > The PR was originally about an ICE in the linemap code that was patched up > for

Re: [PATCH v1 0/2] Refine the vx combine pattern

2025-08-16 Thread Kito Cheng
LGTM On Sat, Aug 16, 2025 at 4:44 PM wrote: > > From: Pan Li > > Add the missed DONE indicator and update comments > > Pan Li (2): > RISC-V: Add missed DONE for vx combine pattern [NFC] > RISC-V: Update the comments of vx combine [NFC] > > gcc/config/riscv/autovec-opt.md | 24 ++

Re: [PATCH 2/3] ira: tie output allocnos for fused instruction pairs

2025-08-16 Thread Artemiy Volkov
On Sun, Aug 10, 2025 at 09:28:50AM -0600, Jeff Law wrote: > Conceptually OK. I slightly worry about the use of PREV_INSN as we could > conceptually end up with notes, line markers, etc between the two fusible > insns. > > Right now the scheduler is the only pass that ever examines SCHED_GROUP_P >

Re: [PATCH v2] libstdc++: Implement LWG4222 'expected' constructor from a single value missing a constraint

2025-08-16 Thread Yrong
Thanks for your suggestion, comments addressed in [PATCH v3] libstdc++: Implement LWG4222 'expected' constructor from a single value missing a constraint Patrick Palka 于2025年8月16日周六 03:58写道: > On Thu, 14 Aug 2025, Yihan Wang wrote: > > > libstdc++-v3/ChangeLog: > > > > * include/std/expect

[COMMITTED] MAINTAINERS: Add myself to write after approval

2025-08-16 Thread Mikael Pettersson
ChangeLog: * MAINTAINERS: Add myself to write after approval. --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 07359c5d7ee..55e33427b91 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -732,6 +732,7 @@ Fernando Pereiraprone

[PATCH v1 0/2] Refine the vx combine pattern

2025-08-16 Thread pan2 . li
From: Pan Li Add the missed DONE indicator and update comments Pan Li (2): RISC-V: Add missed DONE for vx combine pattern [NFC] RISC-V: Update the comments of vx combine [NFC] gcc/config/riscv/autovec-opt.md | 24 1 file changed, 24 insertions(+) -- 2.43.0

[PATCH v1 2/2] RISC-V: Update the comments of vx combine [NFC]

2025-08-16 Thread pan2 . li
From: Pan Li The supported insn of vx combine is out of date, update all insn supported for now. gcc/ChangeLog: * config/riscv/autovec-opt.md: Add supported insn of vx combine. Signed-off-by: Pan Li --- gcc/config/riscv/autovec-opt.md | 20 1 file changed

[PATCH v3] libstdc++: Implement LWG4222 'expected' constructor from a single value missing a constraint

2025-08-16 Thread Yihan Wang
libstdc++-v3/ChangeLog: * include/std/expected: Add missing constraint as per LWG 4222. * testsuite/20_util/expected/lwg4222.cc: New test. Signed-off-by: Yihan Wang --- libstdc++-v3/include/std/expected | 1 + .../testsuite/20_util/expected/lwg4222.cc | 39 +

[PATCH v1 1/2] RISC-V: Add missed DONE for vx combine pattern [NFC]

2025-08-16 Thread pan2 . li
From: Pan Li The previous patch missed the DONE indicator of the vx combine pattern. Thus add it back. gcc/ChangeLog: * config/riscv/autovec-opt.md: Add missed DONE for vx combine pattern. Signed-off-by: Pan Li --- gcc/config/riscv/autovec-opt.md | 4 1 file changed, 4