Re: [PATCH v1 0/1] c: Add support for array parameters in _Countof

Hi Joseph, On Mon, Aug 18, 2025 at 11:19:39PM +, Joseph Myers wrote: > On Fri, 15 Aug 2025, Alejandro Colomar wrote: > > > Hi Joseph, > > > > On Thu, Aug 14, 2025 at 10:03:00PM +, Joseph Myers wrote: > > > On Thu, 14 Aug 2025, Alejandro Colomar wrote: &g

Re: [PATCH v1 0/1] c: Add support for array parameters in _Countof

Hi Joseph, On Thu, Aug 14, 2025 at 10:03:00PM +, Joseph Myers wrote: > On Thu, 14 Aug 2025, Alejandro Colomar wrote: > > > And I'm proposing it as a GNU extension, which means we don't even need > > to care about what ISO C says about [n]. We, as a quality >

[PATCH v2 1/1] c: Add support for array parameters in _Countof

param-pedantic.c: New test. * gcc.dg/countof-param.c: New test. Co-authored-by: Martin Uecker Signed-off-by: Alejandro Colomar --- gcc/c/c-typeck.cc | 50 ++-- gcc/doc/extend.texi | 11 +++ gcc/testsuite/gcc.dg/countof-compi

[PATCH v2 0/1] c: Add support for array parameters in _Countof

we don't need to hear the committee: either they standardize this in the future, or they don't, but we can't end up with something incompatible. Have a lovely night! Alex Alejandro Colomar (1): c: Add support for array parameters in _Countof gcc/c/c-typeck.cc

Re: [PATCH v1 0/1] c: Add support for array parameters in _Countof

Hi Joseph, On Thu, Aug 14, 2025 at 06:44:07PM +, Joseph Myers wrote: > We'd need standard wording that's gone through several rounds of review in > WG14 before there's a reasonable basis for reviewing such a patch, given > how it's based on a very different conceptual model to how array > p

Re: [PATCH v1 1/1] c: Add support for array parameters in _Countof

Hi Martin, On Thu, Aug 14, 2025 at 02:21:10PM +0200, Martin Uecker wrote: > > > You could also add a warning when _Countof is applied to a > > > non-constant pointer. > > > > Yup, I should add that. I wouldn't enable it in any groups flags, > > though. I don't want people to start writing [cons

Re: [PATCH v1 1/1] c: Add support for array parameters in _Countof

Hi Martin, On Thu, Aug 14, 2025 at 01:37:55PM +0200, Martin Uecker wrote: > Am Donnerstag, dem 14.08.2025 um 12:19 +0200 schrieb Alejandro Colomar: > > Hi Martin, > > > > On Thu, Aug 14, 2025 at 11:01:05AM +0200, Alejandro Colomar wrote: > > > +void

Re: [PATCH v1 1/1] c: Add support for array parameters in _Countof

Hi Martin, On Thu, Aug 14, 2025 at 11:01:05AM +0200, Alejandro Colomar wrote: > +void > +decay_obvious (int a[2]) > +{ > + _Countof (typeof (a)); /* { dg-error "invalid" } */ > + _Countof (a + 1); /* { dg-error "invalid" } */ It didn't occur to me

[PATCH v1 1/1] c: Add support for array parameters in _Countof

param-compile.c: New test. * gcc.dg/countof-param-pedantic.c: New test. * gcc.dg/countof-param.c: New test. Co-authored-by: Martin Uecker Signed-off-by: Alejandro Colomar --- gcc/c/c-typeck.cc | 50 ++-- gcc/doc/extend.texi

[PATCH v1 0/1] c: Add support for array parameters in _Countof

Hi! Here's a patch co-authored by Martin and I. It adds support for array parameters in _Countof, which will enable writing safer code that only specifies array bounds in function calls when strictly necessary, reducing the chances for mistakes. Here's an example program that never specifies bou

[PATCH v1] testsuite: Remove spurious comments [PR117025]

PR c/117025 gcc/testsuite/ChangeLog: * gcc.dg/countof-vla.c: Remove spurious comments. * gcc.dg/countof-zero-compile.c: Remove spurious comments. Fixes: 517c9487f8fd (2025-05-27; "c: Add _Countof operator [PR117025]") Reported-by: Sam James Signed-off-by:

Re: [PATCH v25 0/3] c: Add _Countof and

Hi Jakub, Joseph, On Tue, May 27, 2025 at 10:28:23PM +0200, Jakub Jelinek wrote: > On Tue, May 27, 2025 at 08:22:28PM +, Joseph Myers wrote: > > Thanks, I've committed these patches, with additional commit message > > changes to reference PR117025 in the standard way for GCC so that Bugzilla

[PATCH v25 1/3] c: Add _Countof operator

* gcc.dg/countof-zero.c: New test. * gcc.dg/countof.c: New test. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc| 26

[PATCH v25 3/3] c: Add -Wpedantic diagnostic for _Countof

est. * gcc.dg/countof-pedantic.c: New test. * gcc.dg/countof-pedantic-errors.c: New test. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof-no-compa

[PATCH v25 2/3] c: Add

gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: New file. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: New test. Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude/stdcountof.h

[PATCH v25 0/3] c: Add _Countof and

ave a lovely night! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof gcc/Makefile.in | 1 + gcc/c-family/c-common.cc | 26 gcc/c-family/c-common.def | 3 +

Re: [PATCH v24 1/3] c: Add _Countof operator

Hi Jakub, On Wed, May 21, 2025 at 11:47:30PM +0200, Jakub Jelinek wrote: > > @@ -1747,6 +1737,8 @@ static struct c_expr c_parser_binary_expression > > (c_parser *, struct c_expr *, > > tree); > > static struct c_expr c_parser_cast_expr

Re: [PATCH v24 1/3] c: Add _Countof operator

Hi Jakub, On Wed, May 21, 2025 at 11:31:05PM +0200, Alejandro Colomar wrote: > > > +#define c_parser_sizeof_expressi

Re: [PATCH v24 1/3] c: Add _Countof operator

On Wed, May 21, 2025 at 11:36:56PM +0200, Alejandro Colomar wrote: > Hi Jakub, > > On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote: > > > warning_at (loc, OPT_Wc___compat, > > > "defining type in %qs expression is invalid in

Re: [PATCH v24 1/3] c: Add _Countof operator

Hi Jakub, On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote: > > warning_at (loc, OPT_Wc___compat, > > "defining type in %qs expression is invalid in C++", > > (in_sizeof > > ? "sizeof" > > -: (in_typeof ? "typeof" : "alignof"))); >

Re: [PATCH v24 1/3] c: Add _Countof operator

Hi Jakub, On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote: > > * c-common.h: Add RID_COUNTOF. > > (enum rid): Add RID_COUNTOF. Okay. > > > (c_countof_type): New function prototype. > > * c-common.def (COUNTOF_EXPR): New tree. > > * c-common.cc > > (c_common_re

[PATCH v24 2/3] c: Add

gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

[PATCH v24 1/3] c: Add _Countof operator

f. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc| 26 gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

[PATCH v24 3/3] c: Add -Wpedantic diagnostic for _Countof

tic-errors on C23. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof-no-compat.c | 5 + gcc/testsuite/gcc.dg/countof-pedantic-errors.c | 8

[PATCH v24 0/3] c: Add _Countof and

(test for excess errors) PASS: gcc.dg/countof-zero.c (test for excess errors) PASS: gcc.dg/countof-zero.c execution test PASS: gcc.dg/countof.c (test for excess errors) PASS: gcc.dg/countof.c execution test Have a lovely day! Alex Alejandro Colomar (3): c: Add _Co

Re: [PATCH v23 1/3] c: Add _Countof operator

Hi Joseph, On Wed, May 21, 2025 at 04:26:46PM +, Joseph Myers wrote: > On Wed, 21 May 2025, Alejandro Colomar wrote: > > > @@ -10572,6 +10583,8 @@ c_parser_unary_expression (c_parser *parser) > > case CPP_KEYWORD: > >switch (c_parser_peek

Re: [PATCH v23 0/3] c: Add _Countof and

On Wed, May 21, 2025 at 02:17:58AM +0200, Alejandro Colomar wrote: > Hi! > > Here's another revision of this patch set. > > v23 changes: > > - More specific change logs. > - #define assert() instead of #include'ing . > > `make check` says all'

[PATCH v23 1/3] c: Add _Countof operator

f. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc| 26 gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

[PATCH v23 2/3] c: Add

gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

[PATCH v23 3/3] c: Add -Wpedantic diagnostic for _Countof

tic-errors on C23. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof-no-compat.c | 5 + gcc/testsuite/gcc.dg/countof-pedantic-errors.c | 8

[PATCH v23 0/3] c: Add _Countof and

I've only ran `make check -j24` once at the tip, and all the countof tests pass. Have a lovely night! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof gcc/Makefile.in | 1 + gcc/c-family/c-common

Re: [PATCH v22 0/3] c: Add _Countof and

Hi Jakub, On Tue, May 20, 2025 at 11:20:27PM +0200, Jakub Jelinek wrote: > On Tue, May 20, 2025 at 11:12:38PM +0200, Alejandro Colomar wrote: > > Okay; how about this? > > > > gcc/c-family/ChangeLog: > > > > * c-common.h: Add _Countof operato

Re: [PATCH v22 0/3] c: Add _Countof and

Hi Jakub, On Tue, May 20, 2025 at 05:25:29PM +0200, Jakub Jelinek wrote: > On Tue, May 20, 2025 at 05:15:33PM +0200, Alejandro Colomar wrote: > > I've based on gnulib commits, which I believe follow the same > > guidelines. For example:

Re: [PATCH v22 0/3] c: Add _Countof and

Hi Joseph, On Tue, May 20, 2025 at 02:43:55PM +, Joseph Myers wrote: > > Could you please clarify if I need to do anything or if this is already > > scheduled for review when you have some time? Also please clarify if > > you're okay with amending that or if you prefer that I send v23. > > I

Re: [PATCH v22 0/3] c: Add _Countof and

Hi Joseph, On Fri, May 16, 2025 at 07:13:15PM +0200, Alejandro Colomar wrote: > On Fri, May 16, 2025 at 05:01:36PM +, Joseph Myers wrote: > > On Fri, 16 May 2025, Alejandro Colomar wrote: > > > > > Hmmm, I've been trying to find a compromise between readabilit

Re: [PATCH v22 0/3] c: Add _Countof and

Hi Joseph, On Fri, May 16, 2025 at 05:01:36PM +, Joseph Myers wrote: > On Fri, 16 May 2025, Alejandro Colomar wrote: > > > Hmmm, I've been trying to find a compromise between readability and > > simplicity, and I think I have something. I've seen some

Re: [PATCH v22 0/3] c: Add _Countof and

Hi Joseph, On Fri, May 16, 2025 at 12:25:39PM +, Joseph Myers wrote: > On Fri, 16 May 2025, Alejandro Colomar wrote: > > > - Add (and NDEBUG) to some test files that were missing it, > >and also the forward declaration of strcmp(3). > > Depending on libc heade

Re: [PATCH v22 0/3] c: Add _Countof and

Here's the test run. No regressions. BTW, there are some differences between runs. I _think_ this is due to running them in separate days, and having run 'make install' in between, which seems to have made some tests that would normally fail now succeed but that's unrelated to the feature, and i

[PATCH v22 1/3] c: Add _Countof operator

* gcc.dg/countof-zero-compile.c * gcc.dg/countof-zero.c * gcc.dg/countof.c: Add tests for _Countof operator. Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.c

[PATCH v22 2/3] c: Add

gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

[PATCH v22 0/3] c: Add _Countof and

it, and also the forward declaration of strcmp(3). - Fix typos in dejagnu diagnostic comments. Is this ready to merge now, hopefully? :-) Have a lovely night! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Count

[PATCH v22 3/3] c: Add -Wpedantic diagnostic for _Countof

.dg/countof-pedantic.c * gcc.dg/countof-pedantic-errors.c: Test pedantic diagnostics for _Countof. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof

Re: [PATCH v1] contrib/: Add support for Link: tags

Hi Jason, On Tue, May 13, 2025 at 10:35:00AM -0400, Jason Merrill wrote: > > > It seems to be one of the more common trailers used in the linux > > > kernel [1], > > Hmm, I don't see it in that list. But it is described in > https://docs.kernel.org/process/submitting-patches.html It was mentio

Re: [PATCH v21 1/3] c: Add _Countof operator

Hi Jonathan, On Tue, May 13, 2025 at 10:39:21AM +0100, Jonathan Wakely wrote: > On Mon, 12 May 2025 at 23:15, Alejandro Colomar wrote: > > <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by> > > > >

Re: [PATCH v1] contrib/: Add support for Link: tags

Hi Jonathan, On Tue, May 13, 2025 at 10:50:23AM +0100, Jonathan Wakely wrote: > Fair enough, I have no objection to adding Link: support to the > git_commit.py script. (We don't really have anybody who is the owner > of those scripts now, so I think you need a global reviewer to approve > it.) Th

Re: [PATCH v21 1/3] c: Add _Countof operator

Hi Jonathan, On Mon, May 12, 2025 at 06:11:18PM +0100, Jonathan Wakely wrote: > On 12/05/25 17:53 +0200, Alejandro Colomar wrote: > > Suggested-by: Xavier Del Campo Romero > > Co-authored-by: Martin Uecker > > Acked-by: "James K. Lowden" > > What

Re: [PATCH v1] contrib/: Add support for Link: tags

Hi Jonathan, On Mon, May 12, 2025 at 05:42:55PM +0100, Jonathan Wakely wrote: > On Mon, 12 May 2025 at 17:34, Jonathan Wakely wrote: > > > > On Mon, 12 May 2025 at 16:46, Alejandro Colomar wrote: > > > > > > contrib/ChangeLog: > > > > > &g

Re: [PATCH v21 2/3] c: Add

Hi Joseph, On Mon, May 12, 2025 at 04:43:45PM +, Joseph Myers wrote: > On Mon, 12 May 2025, Alejandro Colomar wrote: > > > + if (strcmp (xstr(countof), "_Alignas") != 0) > > countof should definitely not expand to _Alignas! D'oh! :-) > I don't

[PATCH v21 3/3] c: Add -Wpedantic diagnostic for _Countof

.dg/countof-pedantic.c * gcc.dg/countof-pedantic-errors.c: Test pedantic diagnostics for _Countof. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 gcc/testsuite/gcc.dg/countof-compat.c | 8 gcc/testsuite/gcc.dg/countof

[PATCH v21 0/3] c: Add _Countof and

hey look good. Have a lovely day! Alex Alejandro Colomar (3): c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof gcc/Makefile.in | 1 + gcc/c-family/c-common.cc | 26 +++ gcc/c-family/c-common.def

[PATCH v21 2/3] c: Add

gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. gcc/testsuite/ChangeLog: * gcc.dg/countof-stdcountof.c: Add tests for . Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude

[PATCH v21 1/3] c: Add _Countof operator

/questions/37538/#57537491> Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc | 26 + gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

[PATCH v1] contrib/: Add support for Link: tags

contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Link:' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- Hi, This patch is needed by my patches that add _Countof. Have a lovely day! Alex contrib/gcc-changelog/git_com

Re: [PATCH v20 2/4] c: Add _Countof operator

On Mon, May 12, 2025 at 10:54:34AM +, Joseph Myers wrote: > On Sun, 11 May 2025, Alejandro Colomar wrote: > > > +/* { dg-options "-Wno-declaration-after-statement -Wno-pedantic -Wno-vla" > > } */ > > > +/* { dg-options "-Wno-pedantic -Wvla-par

Re: [PATCH v20 3/4] c: Add

On Mon, May 12, 2025 at 10:54:52AM +, Joseph Myers wrote: > On Sun, 11 May 2025, Alejandro Colomar wrote: > > > gcc/ChangeLog: > > > > * Makefile.in (USER_H): Add . > > * ginclude/stdcountof.h: Add countof macro. > > This is missing tests for th

[PATCH v20 3/4] c: Add

gcc/ChangeLog: * Makefile.in (USER_H): Add . * ginclude/stdcountof.h: Add countof macro. Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude/stdcountof.h | 31 +++ 2 files changed, 32 insertions(+) create mode 100644

[PATCH v20 4/4] c: Add -Wpedantic diagnostic for _Countof

It is not supported in <= C23 mode. gcc/c/ChangeLog: * c-parser.cc (c_parser_sizeof_or_countof_expression): Add -Wpedantic diagnostic for _Countof in <= C23 mode. Signed-off-by: Alejandro Colomar --- gcc/c/c-parser.cc | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v20 2/4] c: Add _Countof operator

/questions/37538/#57537491> Suggested-by: Xavier Del Campo Romero Co-authored-by: Martin Uecker Acked-by: "James K. Lowden" Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc | 26 + gcc/c-family/c-common.def | 3 + gcc/c-family/c-common.h

[PATCH v20 1/4] contrib/: Add support for Link: tags

contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Link:' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/gcc-changelog/git_co

[PATCH v20 0/4] c: Add _Countof and

Have a lovely day! Alex Alejandro Colomar (4): contrib/: Add support for Link: tags c: Add _Countof operator c: Add c: Add -Wpedantic diagnostic for _Countof contrib/gcc-changelog/git_commit.py| 3 + gcc/Makefile.in| 1 + gcc/c-family/c-common.cc

Re: [PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

On Fri, May 09, 2025 at 11:43:18PM +0200, Alejandro Colomar wrote: > Hi Joseph, > > On Fri, May 09, 2025 at 09:39:34PM +, Joseph Myers wrote: > > > > > contrib/ChangeLog: > > > > > > > > > > * gcc-changelog/git_commit.py (GitCom

Re: [PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

Hi Joseph, On Fri, May 09, 2025 at 09:39:34PM +, Joseph Myers wrote: > > > > contrib/ChangeLog: > > > > > > > > * gcc-changelog/git_commit.py (GitCommit): > > > > Add support for 'Cc: ' and 'Link: ' tags. > > > > > > Please remove this patch from this patch series; it has not

Re: [PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

Hi Joseph, On Fri, May 09, 2025 at 09:00:58PM +, Joseph Myers wrote: > On Fri, 9 May 2025, Alejandro Colomar wrote: > > > contrib/ChangeLog: > > > > * gcc-changelog/git_commit.py (GitCommit): > > Add support for 'Cc: ' and 'Link: ' t

Re: [PATCH v19 3/3] c: Add

Hi Jakub, On Fri, May 09, 2025 at 10:02:17PM +0200, Jakub Jelinek wrote: > On Fri, May 09, 2025 at 09:32:50PM +0200, Alejandro Colomar wrote: > > gcc/ChangeLog: > > > > * Makefile.in > > Missing (USER_H): Add stdcountof.h. Thanks! > > --- /dev/null &g

[PATCH v19 3/3] c: Add

gcc/ChangeLog: * Makefile.in * ginclude/stdcountof.h: Add countof macro. Signed-off-by: Alejandro Colomar --- gcc/Makefile.in | 1 + gcc/ginclude/stdcountof.h | 31 +++ 2 files changed, 32 insertions(+) create mode 100644 gcc/ginclude

[PATCH v19 1/3] contrib/: Add support for Cc: and Link: tags

contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Cc: ' and 'Link: ' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH v19 2/3] c: Add _Countof operator

iewicz Cc: Douglas McIlroy Cc: Jason Merrill Cc: "Gustavo A. R. Silva" Cc: Patrizia Kaye Cc: Ori Bernstein Cc: Robert Seacord Cc: Marek Polacek Cc: Sam James Cc: Richard Biener Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc | 26 + gcc/c-fam

[PATCH v19 0/3] c: Add _Countof and

o that in the following days, since I'll be traveling. I haven't yet implemented the pedantic diagnostic for old C versions. This is in my TODO list. I think that's the only thing I'm missing. Have a lovely night! Alex Alejandro Colomar (3): contrib/: Add support for Cc: an

Re: [PATCH] c: do not warn about truncating NUL char when initializing nonstring arrays [PR117178]

check for nonstring cases. > * gcc.dg/Wunterminated-string-initialization-c++.c: Duplicate > C test for -Wc++-compat. The log and the code look good to me, but I'm not a maintainer, so can't review that part. For the behavior and tests: Acked-by: Alejand

Re: [PATCH v2] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

Hi Eric, On Thu, Oct 17, 2024 at 03:20:11PM GMT, Eric Gallager wrote: > On Thu, Oct 17, 2024 at 10:54 AM Alejandro Colomar wrote: > > > > Just like we already do for git-send-email(1). In some cases, patches > > are prepared with git-format-patch(1), but are sent with a

Re: [PATCH v18 0/2] c: Add __countof__ operator

On Sun, Nov 10, 2024 at 11:32:54AM GMT, Alejandro Colomar wrote: > Hi! > > Your favourite operator with the most controversial name comes back with > support for [0], thanks to Martin Uecker. In movie theaters, and > probably in GCC 16. > > For those who fight in a side in

[PATCH v18 2/2] c: Add __countof__ operator

Alex Celeste Cc: Jakub Łukasiewicz Cc: Douglas McIlroy Cc: Jason Merrill Cc: "Gustavo A. R. Silva" Cc: Patrizia Kaye Cc: Ori Bernstein Cc: Robert Seacord Cc: Marek Polacek Cc: Sam James Cc: Richard Biener Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc

[PATCH v18 0/2] c: Add __countof__ operator

reply to this email with the regression-test session results; they all passed. [0] works like a charm. Have a lovely day! Alex Alejandro Colomar (2): contrib/: Add support for Cc: and Link: tags c: Add __countof__ operator contrib/gcc-changelog/git_commit.py| 5 +- gcc/c

[PATCH v18 1/2] contrib/: Add support for Cc: and Link: tags

contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Cc: ' and 'Link: ' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH v2] c: add Wzero-as-null-pointer-constant [PR117059]

geLog: > * gcc.dg/Wzero-as-null-pointer-constant.c: New test. > > > Suggested-by: Alejandro Colomar > Acked-by: Alejandro Colomar > > > diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt > index 9b9f5e744f6..b4e967ce000 100644 > --- a/gcc/c-fami

Re: [PATCH] c: add Wzero-as-null-pointer-constant [PR117059]

ing that it may be good to add some tests to check that structs with implicit initialization to 0s don't trigger this diagnostic. struct ( int a; void *b; } a = { 0 }; struct ( int a; int b; void *b; } b = { 0 , 0 }; There might be other corner cases worth testing. Thanks for adding this diagnostic! Feel free to add: Suggested-by: Alejandro Colomar Acked-by: Alejandro Colomar Cheers, Alex -- <https://www.alejandro-colomar.es/> signature.asc Description: PGP signature

Re: [PATCH v17 2/2] c: Add __countof__ operator

Hi Joseph, This is a gentle ping about this patch set, 10 days before the start of stage 3. Have a lovely day! Alex On Sat, Oct 26, 2024 at 12:10:56AM GMT, Alejandro Colomar wrote: > Hi Joseph, > > On Fri, Oct 25, 2024 at 08:44:15PM GMT, Joseph Myers wrote: > > I don&#

Re: [PATCH v17 2/2] c: Add __countof__ operator

Hi Joseph, On Fri, Oct 25, 2024 at 08:44:15PM GMT, Joseph Myers wrote: > I don't see the use of pedwarn_c23 and associated tests (error with > -std=c23 -pedantic-errors, warning with -std=c23 -pedantic, no diagnostic > with -std=c23 -pedantic-errors -Wno-c23-c2y-compat, no diagnostic with > -st

Re: [PATCH v17 0/2] c: Add __countof__ operator

On Tue, Oct 22, 2024 at 08:48:10PM GMT, Alejandro Colomar wrote: > Hi Joseph, > > I found some tests that could be improved, so I've worked on that in the > last few days. I'll post as a reply to this email the bootstrap and > regression testing results. alx@debian:~

[PATCH v17 2/2] c: Add __countof__ operator

Cc: Ville Voutilainen Cc: Alex Celeste Cc: Jakub Łukasiewicz Cc: Douglas McIlroy Cc: Jason Merrill Cc: "Gustavo A. R. Silva" Cc: Patrizia Kaye Cc: Ori Bernstein Cc: Robert Seacord Cc: Marek Polacek Cc: Sam James Cc: Richard Biener Signed-off-by: Alejandro Colomar ---

[PATCH v17 1/2] contrib/: Add support for Cc: and Link: tags

contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Cc: ' and 'Link: ' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH v17 0/2] c: Add __countof__ operator

ts. Below is the range diff against v16b. Have a lovely night! Alex Alejandro Colomar (2): contrib/: Add support for Cc: and Link: tags c: Add __countof__ operator contrib/gcc-changelog/git_commit.py| 5 +- gcc/c-family/c-common.cc | 26 + gcc/c-family/c-

Re: [PATCH v16b 2/4] gcc/: Rename array_type_nelts => array_type_nelts_minus_one

On Fri, Oct 18, 2024 at 10:25:59AM GMT, Alejandro Colomar wrote: > Hi Joseph, > > On Wed, Oct 16, 2024 at 08:02:05PM GMT, Alejandro Colomar wrote: > > Hi Joseph, > > > > On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote: > > > On Wed,

Re: [PATCH v16b 2/4] gcc/: Rename array_type_nelts => array_type_nelts_minus_one

Hi Joseph, On Wed, Oct 16, 2024 at 08:02:05PM GMT, Alejandro Colomar wrote: > Hi Joseph, > > On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote: > > On Wed, 16 Oct 2024, Alejandro Colomar wrote: > > > > > The old name was misleading. > > > > &

Re: [PATCH v2] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

On Thu, Oct 17, 2024 at 04:54:04PM GMT, Alejandro Colomar wrote: > Just like we already do for git-send-email(1). In some cases, patches > are prepared with git-format-patch(1), but are sent with a different > program, or some flags to git-send-email(1) may accidentally in

[PATCH v2] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

@ will receive the patch. contrib/ChangeLog: * gcc-git-customization.sh: Configure git-format-patch(1) to add 'To: gcc-patches@gcc.gnu.org'. Cc: Eric Gallager Signed-off-by: Alejandro Colomar --- Hi! v2 changes: - Fix comment. [Eric] Cheers, Alex Range-diff aga

Re: [PATCH v1] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

On Wed, Oct 16, 2024 at 03:41:00PM GMT, Eric Gallager wrote: > On Wed, Oct 16, 2024 at 8:55 AM Alejandro Colomar wrote: > > > > Just like we already do for git-send-email(1). In some cases, patches > > are prepared with git-format-patch(1), but are sent with a different

Re: [PATCH v16b 2/4] gcc/: Rename array_type_nelts => array_type_nelts_minus_one

Hi Joseph, On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote: > On Wed, 16 Oct 2024, Alejandro Colomar wrote: > > > The old name was misleading. > > > > While at it, also rename some temporary variables that are used with > > this function, for consiste

[PATCH v1] contrib/: Configure git-format-patch(1) to add To: gcc-patches@gcc.gnu.org

@ will receive the patch. contrib/ChangeLog: * gcc-git-customization.sh: Configure git-format-patch(1) to add 'To: gcc-patches@gcc.gnu.org'. Signed-off-by: Alejandro Colomar --- contrib/gcc-git-customization.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/contr

[PATCH v16b 2/4] gcc/: Rename array_type_nelts => array_type_nelts_minus_one

* backend/rust-tree.cc (array_type_nelts_top): Rename array_type_nelts => array_type_nelts_minus_one Cc: Gabriel Ravier Cc: Martin Uecker Cc: Joseph Myers Cc: Xavier Del Campo Romero Cc: Jakub Jelinek Suggested-by: Richard Biener Signed-off-by: Alejandro Colomar --- gcc/c/c-decl.

[PATCH v16b 4/4] c: Add __countof__ operator

Cc: Ville Voutilainen Cc: Alex Celeste Cc: Jakub Łukasiewicz Cc: Douglas McIlroy Cc: Jason Merrill Cc: "Gustavo A. R. Silva" Cc: Patrizia Kaye Cc: Ori Bernstein Cc: Robert Seacord Cc: Marek Polacek Cc: Sam James Cc: Richard Biener Signed-off-by: Alejandro Colomar ---

[PATCH v16b 3/4] gcc/: Merge definitions of array_type_nelts_top

geLog: * backend/rust-tree.h (array_type_nelts_top) * backend/rust-tree.cc (array_type_nelts_top): Remove function. Signed-off-by: Alejandro Colomar --- gcc/cp/cp-tree.h | 1 - gcc/cp/tree.cc| 13 - gcc/rust/backend/rust-tree.cc

[PATCH v16b 1/4] contrib/: Add support for Cc: and Link: tags

contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit): Add support for 'Cc: ' and 'Link: ' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH v16b 0/4] c: Add __countof__ operator

is a resend, since I accidentally didn't send them to the mailing list. Have a lovely day! Alex Alejandro Colomar (4): contrib/: Add support for Cc: and Link: tags gcc/: Rename array_type_nelts => array_type_nelts_minus_one gcc/: Merge definitions of array_type_nelts_top c: Add __c

Re: [PATCH v15 2/4] gcc/: Rename array_type_nelts() => array_type_nelts_minus_one()

On Wed, Oct 16, 2024 at 10:34:21AM GMT, Joseph Myers wrote: > On Wed, 16 Oct 2024, Alejandro Colomar wrote: > > > The old name was misleading. > > > > While at it, also rename some temporary variables that are used with > > this function, for consistency. >

Re: [PATCH v15 4/4] c: Add __countof__ operator

Hi Joseph, On Wed, Oct 16, 2024 at 10:30:36AM GMT, Joseph Myers wrote: > On Wed, 16 Oct 2024, Alejandro Colomar wrote: > > > + if (type_code != ARRAY_TYPE) > > +{ > > + error_at (loc, "invalid application of % to type %qT", > >

Re: [PATCH v15 2/4] gcc/: Rename array_type_nelts() => array_type_nelts_minus_one()

Hi Joseph, On Wed, Oct 16, 2024 at 10:34:21AM GMT, Joseph Myers wrote: > On Wed, 16 Oct 2024, Alejandro Colomar wrote: > > > The old name was misleading. > > > > While at it, also rename some temporary variables that are used with > > this function, for consistency

[PATCH v15 4/4] c: Add __countof__ operator

Cc: Ville Voutilainen Cc: Alex Celeste Cc: Jakub Łukasiewicz Cc: Douglas McIlroy Cc: Jason Merrill Cc: "Gustavo A. R. Silva" Cc: Patrizia Kaye Cc: Ori Bernstein Cc: Robert Seacord Cc: Marek Polacek Cc: Sam James Signed-off-by: Alejandro Colomar --- gcc/c-family/c-common.cc

[PATCH v15 3/4] Merge definitions of array_type_nelts_top()

geLog: * backend/rust-tree.h (array_type_nelts_top) * backend/rust-tree.cc (array_type_nelts_top): Remove function. Signed-off-by: Alejandro Colomar --- gcc/cp/cp-tree.h | 1 - gcc/cp/tree.cc| 13 - gcc/rust/backend/rust-tree.cc

[PATCH v15 2/4] gcc/: Rename array_type_nelts() => array_type_nelts_minus_one()

gcc/rust/ChangeLog: * backend/rust-tree.cc (array_type_nelts_top): Rename array_type_nelts() => array_type_nelts_minus_one() Cc: Gabriel Ravier Cc: Martin Uecker Cc: Joseph Myers Cc: Xavier Del Campo Romero Cc: Jakub Jelinek Suggested-by: Richard Biener Signed-off-by: Alejandro Colomar

  1   2   3   4   >