Re: [committed, Fortran, pr55901, v1] [OOP] type is (character(len=*)) misinterpreted as array and Re: [Patch, Fortran, v1] Cosmetics and code simplify

Andre Vehreschild ve...@gmx.de PR fortran/55901 * trans-expr.c (gfc_conv_structure): Fixed indendation. Using integer_zero_node now instead of explicitly constructing a integer constant zero node. (gfc_conv_derived_to_class): Add handling of _len component

[Patch, Fortran, pr60322] was: [Patch 1/2, Fortran, pr60322] [OOP] Incorrect bounds on polymorphic dummy array

in others. I will put my thinking cap on tonight :-) Cheers Paul On 23 March 2015 at 13:43, Andre Vehreschild ve...@gmx.de wrote: Hi Mikael, thanks for looking at the patch. Please note, that Paul has sent an addendum to the patches for 60322, which I deliberately have attached. 26/02

Re: [Patch 1/2, Fortran, pr60322] [OOP] Incorrect bounds on polymorphic dummy array

Hi Mikael, thanks for looking at the patch. Please note, that Paul has sent an addendum to the patches for 60322, which I deliberately have attached. 26/02/2015 18:17, Andre Vehreschild a écrit : This first patch is only preparatory and does not change any of the semantics of gfortran

Re: [commited, Fortran, Backport to 4.9, pr60255] [OOP] Deferred character length variable at (1) cannot yet be associated with unlimited polymorphic entities

Hi all, commited as r221591 to gcc_4.9-branch. Okayed by Paul via IRC on 2015-03-22. Thanks, Paul. gcc/fortran/ChangeLog 2015-03-23 Andre Vehreschild ve...@gmx.de Janus Weil ja...@gcc.gnu.org Backported from mainline PR fortran/60255 Initial patch version

Re: [Patch 1/2, Fortran, pr60322] [OOP] Incorrect bounds on polymorphic dummy array

attr.pointer is checked on the sym, having the expression like you pointed out: (sym-ts.type != BT_CLASS sym-attr.pointer) || (sym-ts.type == BT_CLASS CLASS_DATA (sym)-attr.class_pointer) Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

Re: [Patch, Fortran, pr55901, v1] [OOP] type is (character(len=*)) misinterpreted as array

at 16:13, Andre Vehreschild ve...@gmx.de wrote: Hi all, please find attached the parts missing to stop valgrind's complaining about the use of uninitialized memory. The issue was, that when constructing a temporary class-object to call a routine with unlimited polymorphic arguments

[Patch, Fortran, Backport to 4.9, pr60255] [OOP] Deferred character length variable at (1) cannot yet be associated with unlimited polymorphic entities

, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de pr60255-4.9.clog Description: Binary data diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c index aee9666..a8212f7 100644 --- a/gcc/fortran/class.c +++ b/gcc/fortran/class.c @@ -34,6 +34,12 @@ along with GCC; see the file COPYING3

[Patch, Fortran, v1] Cosmetics and code simplify

-- Andre Vehreschild * Email: vehre ad gmx dot de cosm_simp.clog Description: Binary data diff --git a/gcc/fortran/trans-expr.c b/gcc/fortran/trans-expr.c index a30c391..f6fe9a1 100644 --- a/gcc/fortran/trans-expr.c +++ b/gcc/fortran/trans-expr.c @@ -7111,7 +7111,7 @@ gfc_conv_structure (gfc_se * se

Re: [Patch, Fortran, PR 64787 a.o., v2] Invalid code on sourced allocation of class(*) character string

previous patches as stated in: https://gcc.gnu.org/ml/fortran/2015-03/msg00076.html Bootstraps and regtests ok on x86_64-linux-gnu/F20. Reviews and comments welcome. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de pr64787_v2.clog Description: Binary data diff --git

[Patch, Fortran, pr55901, v1] [OOP] type is (character(len=*)) misinterpreted as array

! - Andre -- Andre Vehreschild * Email: vehre ad gmx dot de pr55901_v1.clog Description: Binary data diff --git a/gcc/fortran/trans-expr.c b/gcc/fortran/trans-expr.c index 7d3f3be..a30c391 100644 --- a/gcc/fortran/trans-expr.c +++ b/gcc/fortran/trans-expr.c @@ -578,6 +578,34

[Patch, Fortran, 2/2] Proposal on renaming gfc_vtable_*_get() to gfc_class_vtab_*_get()

Hi all, this is the second part of the patch, substituting gfc_class_vtab_*_get() for gfc_vtable_*_get () where needed. Bootstraps and regtests ok on x86_64-linux-gnu/F20. Ok for trunk? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de vtab_access_rework2_v1.clog

[Patch, Fortran, 1/2] Proposal on renaming gfc_vtable_*_get() to gfc_class_vtab_*_get()

part substitutes the new name gfc_class_vtab_*_get () where needed. Bootstraps and regtests fine on x86_64-linux-gnu/F20. Ok for trunk? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de vtab_access_rework1_v1.clog Description: Binary data diff --git a/gcc/fortran/trans

Re: [Patch, Fortran] Prevent segfault on illegal input

Hi Tobias, hi all, thanks for the review. Commited as r221455: r221455 | vehre | 2015-03-16 11:29:59 +0100 (Mo, 16. Mär 2015) | 13 Zeilen gcc/fortran/ChangeLog: 2015-03-16 Andre Vehreschild ve...@gmx.de * resolve.c: Prevent segfault on illegal input. gcc/testsuite/ChangeLog: 2015

[Patch, Fortran, PR 64787, v1] Invalid code on sourced allocation of class(*) character string

/msg00075.html (necessary) Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de pr64787_v1.clog Description: Binary data diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c index 786876c..949fc98 100644 --- a/gcc/fortran/class.c +++ b/gcc/fortran/class.c @@ -2562,13 +2562,19

[Patch, Fortran] Prevent segfault on illegal input

-- Andre Vehreschild * Email: vehre ad gmx dot de crashfix1_v1.clog Description: Binary data diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index 942a9ad..465cf2b 100644 --- a/gcc/fortran/resolve.c +++ b/gcc/fortran/resolve.c @@ -2639,6 +2639,10 @@ found: expr-ts = sym-ts; expr

[Patch, Fortran] Prevent segfault with dump-*-original for implicit class expressions.

it better. Bootstraps and regtests ok on x86_64-linux-gnu/F20. Ok, for trunk? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de crashfix2_v1.clog Description: Binary data diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c index 320eb01..71721dd 100644 --- a/gcc

Re: [Ping, Patch 2/2, v3, Fortran, pr60322 a.o.] [OOP] Incorrect bounds on polymorphic dummy array

Ping! On Fri, 6 Mar 2015 13:38:21 +0100 Andre Vehreschild ve...@gmx.de wrote: Hi everyone, please find attached the latest version of the patch with the comments from Dominique via IRC worked in. Those were mostly about clarifying comments and style. Nevertheless, thanks for your help

Re: [Patch 2/2, v3, Fortran, pr60322 a.o.] [OOP] Incorrect bounds on polymorphic dummy array

/fortran/2015-02/msg00105.html Bootstraps and regtests fine on x86_64-linux-gnu/F20. Reviews welcome. Regards, Andre On Wed, 4 Mar 2015 20:30:15 +0100 Andre Vehreschild ve...@gmx.de wrote: Dear all, during his initial tests Dominique pointed out, that my patch did not fix all issues

Re: [Patch 2/2, v2, Fortran, pr60322 a.o.] [OOP] Incorrect bounds on polymorphic dummy array

rules. The patch boostraps and regtests cleanly on x86_64-linux-gnu/F20. Note, you need to apply part 1 of this patch first. Part 1 can be found at: https://gcc.gnu.org/ml/fortran/2015-02/msg00105.html Regards, Andre On Thu, 26 Feb 2015 18:17:21 +0100 Andre Vehreschild ve...@gmx.de

[Patch 1/2, Fortran, pr60322] [OOP] Incorrect bounds on polymorphic dummy array

-linux-gnu/F20. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de pr60322_base_1.clog Description: Binary data diff --git a/gcc/fortran/expr.c b/gcc/fortran/expr.c index ab6f7a5..d28cf77 100644 --- a/gcc/fortran/expr.c +++ b/gcc/fortran/expr.c @@ -4052,6 +4052,7 @@ gfc_expr

Re: [PATCH, fortran, committed] PR60289 was: PR fortran/60255 Deferred character length + PR60289 Also deferred char len.

for it today. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de -- Andre Vehreschild * Email: vehre ad gmx dot de Index: gcc/fortran/trans-stmt.c === --- gcc/fortran/trans-stmt.c (Revision 220473

Re: [Patch, fortran] Cosmetics: Dup. code removal, indent fix, typo fix.

Hi Jerry, thanks for the review. Committed as r220345. Regards, Andre On Sat, 31 Jan 2015 07:41:24 -0800 Jerry DeLisle jvdeli...@charter.net wrote: On 01/30/2015 04:10 AM, Andre Vehreschild wrote: Hi all, I fear this fix is not so obvious in one location, I therefore ask

[Patch, fortran] Cosmetics: Dup. code removal, indent fix, typo fix.

on x86_64-linux-gnu/FC20. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de cosmetics_2.clog Description: Binary data diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c index 8a65d2b..3664824 100644 --- a/gcc/fortran/trans-decl.c +++ b/gcc/fortran/trans

Re: [Fortran, Patch, comitted] Cosmetics

Hi all, comitted as r220032. Regards, Andre On Tue, 13 Jan 2015 14:04:50 +0100 Andre Vehreschild ve...@gmx.de wrote: Hi, is this patch commited now? I don't have the rights to do so myself. - Andre On Sun, 28 Dec 2014 17:17:50 +0100 FX fxcoud...@gmail.com wrote: 2014

[PATCH] Add myself to MAINTAINER

Hi all, just added myself to the MAINTAINERS file (Write after approval) as r219936. I will do mostly gfortran development. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de Index: ChangeLog

[Fortran, Patch] Fix for PR60357 and possibly also for 55932, 57857 and others

that for me Dominique? All comments welcome. Bootstraps and regtests ok on x86_64-linux-gnu. Regards, Andre -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve...@gmx.de pr60357_1.clog Description: Binary data diff --git a/gcc/fortran/primary.c b/gcc

[PING, PATCH, Fortran] PR fortran/60289 Fixing character array allocation for class(*) type variable

*ping* On Mon, 29 Dec 2014 14:12:43 +0100 Andre Vehreschild ve...@gmx.de wrote: Hi all, this patches fixes PR60289 for allocating unlimited polymorphic entities retyping them to a char array. The patch depends on my former patch for pr60255 at: https://gcc.gnu.org/ml/fortran/2014-12

[Fortran, Patch] Fix for pr61275 - Invalid initialization expression for ALLOCATABLE component in structure constructor at (1)

! Special thanks to Tobias Burnus for his help. Bootstraps and regtests ok on x86_64-linux-gnu. Please comment. Regards, Andre -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve...@gmx.de pr61275_1.clog Description: Binary data diff --git a/gcc/fortran

Re: [Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

of the patch. -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve...@gmx.de

Re: [Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

Hi, please don't commit this patch yet. I am seeing non-explainable ICEs and wrong code now. Just have to investigate. - Andre On Tue, 13 Jan 2015 12:42:13 +0100 Andre Vehreschild ve...@gmx.de wrote: Hi Paul, thanks for the reviewed and the valued comments. Just for completeness I have

Re: [Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

at that time. Cheers Paul On 11 January 2015 at 16:21, Andre Vehreschild ve...@gmx.de wrote: Hi Paul, thanks for the review. I do not have commits rights. Unfortunately is the patch not ok. I figured today, that it needs an extension when function calls that return deferred char len

Re: [Fortran, Patch] Cosmetics

Hi, is this patch commited now? I don't have the rights to do so myself. - Andre On Sun, 28 Dec 2014 17:17:50 +0100 FX fxcoud...@gmail.com wrote: 2014-12-28 Andre Vehreschild ve...@gmx.de * trans-decl.c (gfc_finish_var_decl): Fixed displaced comment. * trans-stmt.c

Re: [Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

or not you have commit rights yet. If not, I will get to it sometime this week. Thanks for the patch. Paul On 10 January 2015 at 15:59, Andre Vehreschild ve...@gmx.de wrote: Hi all, attached patch fixes the bug reported in pr 60334. The issue here was that the function's result

[Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

functions the compiler will hold all parameters in registers for a significant level of optimization, all the overhead of memory access (I hope :-). Bootstraps and regtests ok on x86_64-linux-gnu. - Andre -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve

Re: [PATCH, fortran] PR fortran/60255 Deferred character length

to the above change in the value of _len, I think that your patch is OK for trunk. With best regards Paul On 4 January 2015 at 13:40, Andre Vehreschild ve...@gmx.de wrote: Hi Janus, hi Paul, hi Tobias, Janus: During code review, I found that I had the code in gfc_get_len_component

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

do we do about the bind_c issue above? Is some bind_c guru available to have a look at this? It would be very much appreciated. Regards, Andre -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve...@gmx.de

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

On Tue, 30 Dec 2014 16:35:48 +0100 Dominique d'Humières domi...@lps.ens.fr wrote: The new patch fixes the ICEs, but still emit the wrong codes reported in pr61337. Thanks and Happy New Year to all, Dominique Le 30 déc. 2014 à 14:39, Andre Vehreschild ve...@gmx.de a écrit : Hi Dominique

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

, Janus On Tue, 30 Dec 2014 16:35:48 +0100 Dominique d'Humières domi...@lps.ens.fr wrote: The new patch fixes the ICEs, but still emit the wrong codes reported in pr61337. Thanks and Happy New Year to all, Dominique Le 30 déc. 2014 à 14:39, Andre Vehreschild ve...@gmx.de

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

of pr60255. Cheers, Dominique Le 29 déc. 2014 à 11:07, Andre Vehreschild ve...@gmx.de a écrit : Hi all, attached is the patch and changelog for fixing pr60255. All comments I received have been integrated into the current patch, therefore I submit this patch as final and hope

[PATCH, fortran, final] PR fortran/60255 Deferred character length

the module to its place of use, which I adapted to fully fix pr60357. Regards, Andre -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve...@gmx.de pr60255_5.clog Description: Binary data diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c index 5130022

[PATCH, Fortran] PR fortran/60289 Fixing character array allocation for class(*) type variable

Regards, Andre -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve...@gmx.de pr60289_5.clog Description: Binary data diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index 05a948b..6038dd5 100644 --- a/gcc/fortran/resolve.c +++ b/gcc

[Fortran, Patch] Cosmetics

Hi all, during gfortran hacking I found a displaced comment and an indentation mistake. Just to make sure those don't get mangled in my other patches, I submit them here. - Andre gcc/fortran/ChangeLog: 2014-12-28 Andre Vehreschild ve...@gmx.de * trans-decl.c (gfc_finish_var_decl

Re: [RFC, PATCH, Fortran] PR fortran/60289 Fixing character array allocation for class(*) type variable

Dear all, sorry for the bad patch yesterday. Here is an update to that one. It fixes the pr60289 is GNU-style checked, bootstraps and regtests ok on x86_64-linux-gnu. Comments welcome. Regards, Andre On Sat, 20 Dec 2014 16:38:23 +0100 Andre Vehreschild ve...@gmx.de wrote: Dear all

Re: [RFC, PATCH, Fortran] PR fortran/60289 Fixing character array allocation for class(*) type variable

object - object was probably modified after being freed. ... Dominique -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve...@gmx.de diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index 9d7d3c2..214b64d 100644 --- a/gcc/fortran/resolve.c

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

triggered for pr61115. Thanks for working on these issues, Dominique On 8 December 2014 at 18:38, Andre Vehreschild ve...@gmx.de wrote: Hi all, please find attached a more elaborate patch for pr60255. I totally agree that my first attempt was just scratching the surface of the work needed

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

. Parenthetically, I wonder if this is not the time to implement PR53971... including responding to Mikael's comment? Anyway, this is a good start in the right direction. Please persist! Thanks Paul On 8 December 2014 at 18:38, Andre Vehreschild ve...@gmx.de wrote: Hi all

Re: [RFC, PATCH, fortran] PR fortran/60255 Deferred character length

in the comment 3 of PR60255 that can be used to check the run time behavior (and possibly check the vtab issue). Dominique -- Andre Vehreschild * Email: vehre ad gmx dot de diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c index 0286c9e..29e31e1 100644 --- a/gcc/fortran/class.c +++ b/gcc

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

Hi, this patch is ready for commit now. Please apply. There have been no objections against doing dg-do compile only, since my last post in August. - Andre On Tue, 26 Aug 2014 11:30:12 +0200 Andre Vehreschild ve...@gmx.de wrote: Hi, On Sun, 17 Aug 2014 15:06:02 +0200 Mikael Morin

Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

understand Dominique wanting to have the dg-do run, because the effectiveness of the patch is only shown on running the test. Is there a compromise of running a test, but only for one optimization stage? Then may be we can do that. - Andre -- Andre Vehreschild * Email: vehre ad gmx dot de

[PATCH, Fortran] PR fortran/60289 First try on: Fixing character array allocation for class(*) type variable

. You may need to have my patch for 60255 incorporated, too, for testing. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index 15d8dab..15d3613 100644 --- a/gcc/fortran/resolve.c +++ b/gcc/fortran/resolve.c

[PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

the first conditional was introduced, the second one should have been removed. This is what the attached patch is for. The patch also adds a testcase for this ICE. *** gcc/fortran/Changelog *** 2014-08-06 Andre Vehreschild ve...@gmx.de PR fortran/60414 * interface.c

Re: PR 60414: Patch proposal

that not only the testcase doesn’t crash the compiler any more, but to confirm that it now generates the correct code (i.e. that we don’t turn an ice-on-valid bug into a wrong-code bug!). Cheers, FX -- Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen Tel.: +49 241 9291018 * Email: ve

PR 60414: Patch proposal

line comment, one line actual code - Testcase in gcc/testsuite/fortran.dg/unlimited_polymorphism_18.f90 Regards, Andre -- Andre Vehreschild diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index c33936b..cb01a13 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3

<    1   2   3   4   5