Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-08-05 Thread Andrew Burgess
Jeff Law writes: > On 7/29/24 6:51 AM, Andrew Burgess wrote: >> Thomas Schwinge writes: >> >>> Hi! >>> >>> On 2024-02-10T17:26:01+, Andrew Burgess wrote: >>>> --- a/libiberty/argv.c >>>> +++ b/libiberty/argv.c &

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-29 Thread Andrew Burgess
Thomas Schwinge writes: > Hi! > > On 2024-02-10T17:26:01+0000, Andrew Burgess wrote: >> --- a/libiberty/argv.c >> +++ b/libiberty/argv.c > >> @@ -439,17 +442,8 @@ expandargv (int *argcp, char ***argvp) >> } >>/* Add a NUL t

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-16 Thread Andrew Burgess
Jeff Law writes: > On 6/11/24 4:39 AM, Andrew Burgess wrote: > >> >> Jeff, >> >> Thanks for looking these patches over. >> >> For testing, using current(ish) gcc HEAD, on x86-64 GNU/Linux, I: >> >>../src/configure --prefix=$(cd .. &a

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-06-28 Thread Andrew Burgess
Hi, Am I OK to push these patches given the testing went OK? I'm thinking probably, but I don't want to overstep. Thanks, Andrew Andrew Burgess writes: > Jeff Law writes: > >> On 2/10/24 10:26 AM, Andrew Burgess wrote: >>> GDB makes use of the libiberty f

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-06-11 Thread Andrew Burgess
Jeff Law writes: > On 2/10/24 10:26 AM, Andrew Burgess wrote: >> GDB makes use of the libiberty function buildargv for splitting the >> inferior (program being debugged) argument string in the case where >> the inferior is not being started under a shell. >> >>

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-06-11 Thread Andrew Burgess
Jeff Law writes: > On 2/10/24 10:26 AM, Andrew Burgess wrote: >> GDB makes use of the libiberty function buildargv for splitting the >> inferior (program being debugged) argument string in the case where >> the inferior is not being started under a shell. >> >>

Re: [PATCHv2 0/2] Changes to libiberty buildargv

2024-04-27 Thread Andrew Burgess
Ping! Any thoughts on these patches? Thanks, Andrew Andrew Burgess writes: > I realise that these patches are not going to get merged until GCC is > back in stage 1, but thought I'd post my latest set of changes for the > libiberty buildargv function. > > Patch #1

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-03-11 Thread Andrew Burgess
Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Tom Tromey writes: >>> This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. >>> >>> This patch caused problems for some users when building gdb,

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-03-06 Thread Andrew Burgess
our guile scripts using a suitable version of guile. This could be applied irrespective of whether you revert b7e5a29602143b53267efcd9c8d5ecc78cd5a62f or not. What do you think? Thanks, Andrew --- commit 6d326010217a2c94ad27d4063f90f689f7c11615 Author: Andrew Burgess Date: Tue Mar 5 12:35:05 2024

[PATCHv2 1/2] libiberty/buildargv: POSIX behaviour for backslash handling

2024-02-10 Thread Andrew Burgess
GDB makes use of the libiberty function buildargv for splitting the inferior (program being debugged) argument string in the case where the inferior is not being started under a shell. I have recently been working to improve this area of GDB, and have tracked done some of the unexpected behaviour

[PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-02-10 Thread Andrew Burgess
GDB makes use of the libiberty function buildargv for splitting the inferior (program being debugged) argument string in the case where the inferior is not being started under a shell. I have recently been working to improve this area of GDB, and noticed some unexpected behaviour to the libiberty

[PATCHv2 0/2] Changes to libiberty buildargv

2024-02-10 Thread Andrew Burgess
I realise that these patches are not going to get merged until GCC is back in stage 1, but thought I'd post my latest set of changes for the libiberty buildargv function. Patch #1 is unchanged from V1. Patch #2 is new in V2. Thanks, Andrew --- Andrew Burgess (2): libiberty/buildargv:

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-02-08 Thread Andrew Burgess
Christian Biesinger writes: > On Mon, Jan 22, 2024 at 7:21 PM Tom Tromey wrote: > >> This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. >> >> This patch caused problems for some users when building gdb, because >> it would cause 'guild' to be invoked with the wrong versin of guile. >>

Re: [PATCH] Revert "Pass GUILE down to subdirectories"

2024-02-07 Thread Andrew Burgess
Tom Tromey writes: > This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. > > This patch caused problems for some users when building gdb, because > it would cause 'guild' to be invoked with the wrong versin of guile. > On the whole it seems simpler to just back this out. > > * Mak

Re: [PATCH] Pass GUILE down to subdirectories

2024-01-13 Thread Andrew Burgess
ne 'GUILE = guile' to instead be just 'GUILE ='. With this in place I can still override the choice of guile executable with: make GUILE=guile but, if I don't do this then instead of forcing 'guile' as the default, we allow the guild compiler t

Ping: Re: [PATCH] libiberty/buildargv: POSIX behaviour for backslash handling

2024-01-02 Thread Andrew Burgess
Ping! Thanks, Andrew Andrew Burgess writes: > GDB makes use of the libiberty function buildargv for splitting the > inferior (program being debugged) argument string in the case where > the inferior is not being started under a shell. > > I have recently been working to impro

[PATCH] libiberty/buildargv: POSIX behaviour for backslash handling

2023-12-06 Thread Andrew Burgess
GDB makes use of the libiberty function buildargv for splitting the inferior (program being debugged) argument string in the case where the inferior is not being started under a shell. I have recently been working to improve this area of GDB, and have tracked done some of the unexpected behaviour

[PUSHED] update my email address

2021-11-02 Thread Andrew Burgess via Gcc-patches
+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fe56b2f647e..31f379fc004 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -257,7 +257,6 @@ check in changes outside of the parts of the compiler they maintain. Reviewers -arc port Andrew Bu

Re: [PATCHv2] top-level configure: setup target_configdirs based on repository

2021-09-28 Thread Andrew Burgess
* Richard Biener [2021-09-27 10:23:50 +0200]: > On Fri, Sep 24, 2021 at 12:34 PM Andrew Burgess > wrote: > > > > * Thomas Schwinge [2021-09-23 11:29:05 +0200]: > > > > > Hi! > > > > > > I only had a curious look here; hope that's still

Re: [PATCH] top-level: merge Makefile.def patches from binutils-gdb repository

2021-09-24 Thread Andrew Burgess
* Richard Biener [2021-09-24 13:58:20 +0200]: > On Fri, Sep 24, 2021 at 12:49 PM Andrew Burgess > wrote: > > > > This commit back-ports two patches to Makefile.def from the > > binutils-gdb repository, these patches were committed over there > > without fi

[PATCH] top-level: merge Makefile.def patches from binutils-gdb repository

2021-09-24 Thread Andrew Burgess
commit 755ba58ebef02e1be9fc6770d00243ba6ed0223c Date: Thu Mar 18 12:37:52 2021 + Add install dependencies for ld -> bfd and libctf -> bfd OK to merge? 2021-09-07 Andrew Burgess Merge from binutils-gdb: 2021-09-08 Nick Alcock PR libctf

[PATCHv2] top-level configure: setup target_configdirs based on repository

2021-09-24 Thread Andrew Burgess
* Thomas Schwinge [2021-09-23 11:29:05 +0200]: > Hi! > > I only had a curious look here; hope that's still useful. > > On 2021-09-22T16:30:42+0100, Andrew Burgess > wrote: > > The top-level configure script is shared between the gcc repository > > and the b

Re: [PATCH] top-level configure: setup target_configdirs based on repository

2021-09-24 Thread Andrew Burgess
* Richard Biener [2021-09-23 10:53:16 +0200]: > On Wed, Sep 22, 2021 at 5:47 PM Andrew Burgess > wrote: > > > > The top-level configure script is shared between the gcc repository > > and the binutils-gdb repository. > > > > The target_configdirs variable

[PATCH] top-level configure: setup target_configdirs based on repository

2021-09-22 Thread Andrew Burgess
The top-level configure script is shared between the gcc repository and the binutils-gdb repository. The target_configdirs variable in the configure.ac script, defines sub-directories that contain components that should be built for the target using the target tools. Some components, e.g. zlib, a

[PATCH] gdb: Add a dependency between gdb and libbacktrace

2021-08-30 Thread Andrew Burgess
I plan to make use of libbacktrace within GDB. I believe that the patch below needs to be merged into GCCs toplevel directory and then back-ported to the binutils-gdb repository. Is this OK to merge? Thanks, Andrew --- GDB is going to start using libbacktrace, so add a build dependency between

Re: [PATCH 0/13] v2 warning control by group and location (PR 74765)

2021-07-29 Thread Andrew Burgess
* Martin Sebor [2021-07-28 10:16:59 -0600]: > On 7/28/21 5:14 AM, Andrew Burgess wrote: > > * Martin Sebor via Gcc-patches [2021-07-19 > > 09:08:35 -0600]: > > > > > On 7/17/21 2:36 PM, Jan-Benedict Glaw wrote: > > > > Hi Martin! > > > &

Re: [PATCH 0/13] v2 warning control by group and location (PR 74765)

2021-07-28 Thread Andrew Burgess
* Martin Sebor via Gcc-patches [2021-07-19 09:08:35 -0600]: > On 7/17/21 2:36 PM, Jan-Benedict Glaw wrote: > > Hi Martin! > > > > On Fri, 2021-06-04 15:27:04 -0600, Martin Sebor wrote: > > > This is a revised patch series to add warning control by group and > > > location, updated based on fee

[PATCH] contrib: Handle GDB specific test result types

2020-05-11 Thread Andrew Burgess
This commit is for the benefit of GDB, but as the binutils-gdb repository shares the contrib/ directory with gcc, this commit must first be applied to gcc then copied back to binutils-gdb. This commit extends the two scripts contrib/dg-extract-results.{py,sh} to handle some new, GDB specific test

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-31 Thread Andrew Burgess
* Iain Sandoe [2020-01-31 20:18:58 +]: > Hello Andrew, > > Andrew Burgess wrote: > > > Here's a cleaned up version of the previous patch I posted. If Iain > > reports this fixes the regressions he saw then I will push this. > > I applied this to r10-6

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-30 Thread Andrew Burgess
Here's a cleaned up version of the previous patch I posted. If Iain reports this fixes the regressions he saw then I will push this. All feedback welcome. Thanks, Andrew --- >From 876996580d64d31407357787fc5df7bd5699b2c0 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Thu, 30 Jan

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-30 Thread Andrew Burgess
* Iain Sandoe [2020-01-30 15:21:08 +]: > >> Can you clarify why there’s no need to match the configury changes in > >> libcpp > >> / gcc / libstdc++ ? > > > > This is the same issue that Tobias pointed out, and was a result of me > > incorrectly trying to regenerate the configure files. >

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-30 Thread Andrew Burgess
* Iain Sandoe [2020-01-28 10:34:52 +]: > Hi Andrew, > > Andrew Burgess wrote: > > > * Jeff Law [2020-01-22 13:52:27 -0700]: > > > > > On Wed, 2020-01-22 at 15:39 +, Andrew Burgess wrote: > > > > The motivation behind this change is

[PATCH] libiberty/hashtab: More const parameters

2020-01-27 Thread Andrew Burgess
I know that the tree's currently closed to non-bugfix changes, but I was hoping this might be accpeted anyway so it can be backported to binutils-gdb. --- Makes some parameters const in libiberty's hashtab library. include/ChangeLog: * hashtab.h (htab_remove_elt): Make a parameter const

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-27 Thread Andrew Burgess
* Jeff Law [2020-01-22 13:52:27 -0700]: > On Wed, 2020-01-22 at 15:39 +0000, Andrew Burgess wrote: > > The motivation behind this change is to make it easier for a user to > > link against static libraries on a target where dynamic libraries are > > the default library

[PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-22 Thread Andrew Burgess
The motivation behind this change is to make it easier for a user to link against static libraries on a target where dynamic libraries are the default library type (for example GNU/Linux). Further, my motivation is really for linking libraries into GDB, however, the binutils-gdb/config/ directory

Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0

2019-10-28 Thread Andrew Burgess
* Jim Wilson [2019-10-22 16:34:53 -0700]: > On Mon, Oct 21, 2019 at 5:26 AM Andrew Burgess > wrote: > > Below is a new versions of this patch, I believe that this addresses > > the review comments from the earlier version. In addition this has > > been tested using Jim&

Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0

2019-10-21 Thread Andrew Burgess
don't know if a separate flag is required. Thanks, Andrew --- commit f1b824e94f3ea396bd0ef46692d5211f855d4b4c Author: Andrew Burgess Date: Thu Jul 18 16:03:10 2019 +0100 gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0 When using the -msave-restore flag we

Re: [PATCH] RISC-V: Include more registers in SIBCALL_REGS.

2019-10-17 Thread Andrew Burgess
* Jim Wilson [2019-10-17 14:55:34 -0700]: > On Thu, Oct 17, 2019 at 7:09 AM Andrew Burgess > wrote: > > I'm still working on part 2, I'm hoping to have a revised patch posted > > by Monday next week. > > I started looking at the part 2 patch also

Re: [PATCH] RISC-V: Include more registers in SIBCALL_REGS.

2019-10-17 Thread Andrew Burgess
* Jim Wilson [2019-10-16 14:04:45 -0700]: > This finishes the part 1 of 2 patch submitted by Andrew Burgess on Aug 19. > This adds the argument registers but not t0 (aka x5) to SIBCALL_REGS. It > also adds the missing riscv_regno_to_class change. > > Tested with cross riscv32-

[PATCH] contrib: Add KPASS support to dg-extract-results.{sh,py}

2019-10-03 Thread Andrew Burgess
My motivation for the patch below comes from GDB. The binutils-gdb project maintains a copy of the contrib directory that it keeps in sync with upstream GCC, and patches to contrib/ are ideally first applied to GCC then backported to binutils-gdb. This patch extends the dg-extract-results.* scrip

[PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0

2019-08-19 Thread Andrew Burgess
When using the -msave-restore flag we end up with calls to _riscv_save_0 and _riscv_restore_0. These functions adjust the stack and save or restore the return address. Due to grouping multiple save/restore stub functions together the save/restore 0 calls actually save s0, s1, s2, and the return a

[PATCH 1/2] gcc/riscv: Include more registers in SIBCALL_REGS

2019-08-19 Thread Andrew Burgess
The current SIBCALL_REGS are x6, x7, and x28 to x31. These are all caller saved registers, however, they are not all of the caller saved registers. I don't see any reason why we couldn't add t1, and a0 to a7 into this set, and this is what this patch does. gcc/ChangeLog: * config/riscv/

[PATCH 0/2] RISCV: Reduce code size when compiling with -msave-restore

2019-08-19 Thread Andrew Burgess
approaches I could take are gratefully recieved. Thanks, Andrew -- Andrew Burgess (2): gcc/riscv: Include more registers in SIBCALL_REGS gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0 gcc/ChangeLog | 15 + gcc/config.gcc

Re: [PATCH 04/30] Changes to arc

2019-07-01 Thread Andrew Burgess
* acsaw...@linux.ibm.com [2019-06-25 15:22:13 -0500]: > From: Aaron Sawdey > > * config/arc/arc-protos.h: Change movmem to cpymem. > * config/arc/arc.c (arc_expand_movmem): Change movmem to cpymem. > * config/arc/arc.h: Change movmem to cpymem in comment. > * config/arc/

Re: [PATCH] [ARC] Fix PR89838

2019-06-23 Thread Andrew Burgess
* Claudiu Zissulescu [2019-06-06 10:32:11 +0300]: > Hi Andrew, > > This is a proposed fix for bugzilla PR89838 issue. It also needs to be > backported to gcc9 and, eventually, gcc8 branches. > > Ok to apply? > Claudiu I had a look through the patch and found just one small nit detailed below.

Re: [PATCH] [ARC][DOC] Add documentation naked, ilink and firq

2019-06-11 Thread Andrew Burgess
* Claudiu Zissulescu [2019-06-06 10:37:09 +0300]: > Hi Sandra, Andrew > > Please find a small patch on the documentation which adds info about naked, > ilink and firq function attributes. > > Ok to apply? > Claudiu > > gcc/ > -xx-xx Claudiu Zissulescu > > * doc/extend.texi (ARC

Re: [PATCH 3/3] [ARC] Remove Rs5 constraint.

2019-04-10 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-25 12:03:13 +0100]: > New LRA algorithms require the all the register constraints to be > defined using define_register_constraint keyword. However, Rs5 > constraint was not LRA proof. Remove it and replace it by equivalent > Rcd constraint. > > gcc/ > -xx-xx C

Re: [PATCH 2/3] [ARC] Refurb eliminate regs.

2019-04-10 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-25 12:03:12 +0100]: > Refurbish eliminable regs howto by introducing a fake > FRAME_POINTER_REGNUM with the purpose to release FP register to be > used freely by the register allocator. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.c (arc_h

Re: [PATCH 1/3] [ARC] Emit blockage regardless to avoid delay slot scheduling.

2019-04-10 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-25 12:03:11 +0100]: > 1.The delay slot scheduler can reschedule some of the frame related > instructions resulting in having incorect CFI information. This patch > introduces a schedule blockage to avoid this problem. > > 2.There are cases when an interrupt may happ

Re: [PATCH] [ARC] Restore blink first when optimizing for speed.

2019-04-02 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-25 11:56:49 +0100]: > Hi, > > When not optimizing for size, we can restore first blink, hence the return > instruction will be executed faster. > > OK to apply? > Claudiu > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.c (GMASK_LEN): Define

Re: [PATCH 5/5] [ARC] Refactor deprecated macros.

2019-03-16 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-06 12:20:05 +0200]: > -xx-xx Claudiu Zissulescu > > * config/arc/arc-protos.h (arc_register_move_cost): Remove. > * config/arc/arc.c (arc_register_move_cost): Re-purpose it to > implement target hook. > (arc_memory_move_cost): New func

Re: [PATCH 4/5] [ARC] Fix tst_movb pattern.

2019-03-16 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-06 12:20:04 +0200]: > -xx-xx Claudiu Zissulescu > > * config/arc/arc.md (tst_movb): Fix constraint. This is fine. Thanks, Andrew > --- > gcc/config/arc/arc.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/a

Re: [PATCH 3/5] [ARC] Define TARGET_HAVE_SPECULATION_SAFE_VALUE.

2019-03-16 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-06 12:20:03 +0200]: > -xx-xx Claudiu Zissulescu > > * config/arc/arc.c (TARGET_HAVE_SPECULATION_SAFE_VALUE): Define. This is fine. Thanks, Andrew > --- > gcc/config/arc/arc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/config/ar

Re: [PATCH 2/5] [ARC] Enable code density frame option for elf targets.

2019-03-16 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-06 12:20:02 +0200]: > -xx-xx Claudiu Zissulescu > > * config/arc/arc.opt (mcode-density-frame): Get the inital value > from TARGET_CODE_DENSITY_FRAME_DEFAULT. > * config/arc/elf.h (TARGET_CODE_DENSITY_FRAME_DEFAULT): Define it > to 1.

Re: [PATCH 1/5] [ARC] Introduce ADJUST_REG_ALLOC_ORDER.

2019-03-16 Thread Andrew Burgess
* Claudiu Zissulescu [2019-03-06 12:20:01 +0200]: > The ARC port is changing the allocation order in the > arc_conditional_register_usage function, but this is not the proper > way. Thus, we employ ADJUST_REG_ALLOC_ORDER hook for this task. > > gcc/ > -xx-xx Claudiu Zissulescu > >

[PATCH] gcc/riscv: Correctly ignore empty C++ structs when flattening for ABI

2019-03-13 Thread Andrew Burgess
Jim, Sorry for the delay in sending this patch. Thanks, Andrew --- This fixes PR target/89627. The RISC-V ABI document[1] says: For the purposes of this section, "struct" refers to a C struct with its hierarchy flattened, including any array fields. That is, struct { struct { float f

Re: [PATCH] [ARC] Fix logic set UNALIGNED_ACCESS

2019-03-01 Thread Andrew Burgess
* Vineet Gupta [2019-02-28 10:04:24 -0800]: > From: Claudiu Zissulescu > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc-c.def (__ARC_UNALIGNED__): Set it on > unaligned_access variable. > * config/arc/arc.c (arc_override_options): Set unaligned access >

Re: [PATCH 2/2] [ARC] Fix millicode wrong blink restore.

2018-12-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-12-11 12:23:35 +0200]: > The blink is restored wrongly when using millicode and regular load > instructions. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.c (arc_restore_callee_milli) Don't clobber off > variable. > > testsuite/ > -

Re: [PATCH 1/2] [ARC] Fix REG_CLASS_NAMES

2018-12-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-12-11 12:23:34 +0200]: > Forgot a class name, fix it. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.h (REG_CLASS_NAMES): Add SIBCALL_REGS. Looks good, Thanks, Andrew > > > --- > gcc/config/arc/arc.h | 1 + > 1 file changed, 1 insertion(+

Re: [PATCH] [ARC] Cleanup, fix and set LRA default.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:29:33 +0200]: > From: claziss > > Hi Andrew, > > This is a patch which fixes and sets LRA by default. > > OK to apply? > Claudiu > > Commit message > > LP_COUNT register cannot be freely allocated by the compiler as it > size, and/or content ma

Re: [PATCH 3/3] [ARC] Add support for profiling in glibc.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:25:13 +0200]: > Use PROFILE_HOOK to add mcount library calls in each toolchain. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.h (FUNCTION_PROFILER): Redefine to empty. > * config/arc/elf.h (PROFILE_HOOK): Define. > * confi

Re: [PATCH 2/3] [ARC] Do not emit ZOL in the presence of text jump tables.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:25:12 +0200]: > Avoid emitting lp instruction when in its ZOL body we find a jump table data > in text section. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.c (hwloop_optimize): Bailout when detecting a > jump table data in the

Re: [PATCH 1/3] [ARC] Update EH code.

2018-11-13 Thread Andrew Burgess
* Claudiu Zissulescu [2018-11-12 13:25:11 +0200]: > Our ABI says the blink is pushed first on stack followed by an unknown > number of register saves, and finally by fp. Hence we cannot use the > EH_RETURN_ADDRESS macro as the stack is not finalized at that moment. > The alternative is to use th

Re: [PATCH 4/6] [ARC] Add peephole rules to combine store/loads into double store/loads

2018-11-13 Thread Andrew Burgess
* claz...@gmail.com [2018-10-31 10:33:33 +0200]: > Thank you for your review. Please find attached a new respin patch with > your feedback in. > > Please let me know if it is ok, > Claudiu > From 4ff7d8419783eceeffbaf27df017d0a93c3af942 Mon Sep 17 00:00:00 2001 > From: Claudiu Zissulescu > Da

Re: [PATCH 6/6] [ARC] Handle store cacheline hazard.

2018-10-30 Thread Andrew Burgess
* Claudiu Zissulescu [2018-10-10 11:00:16 +0300]: > Handle store cacheline hazard for A700 cpus by inserting two NOP_S > between ST ST LD or their logical equivalent (like ST ST NOP_S NOP_S > J_L.D LD) > > gcc/ > 2016-08-01 Claudiu Zissulescu > > * config/arc/arc-arch.h (ARC_TUNE_ARC7X

Re: [PATCH 4/6] [ARC] Add peephole rules to combine store/loads into double store/loads

2018-10-22 Thread Andrew Burgess
* Claudiu Zissulescu [2018-10-10 11:00:14 +0300]: > Simple peephole rules which combines multiple ld/st instructions into > 64-bit load/store instructions. It only works for architectures which > are having double load/store option on. > > gcc/ > Claudiu Zissulescu > > * config/ar

Re: [PATCH 5/6] [ARC] Refurbish and improve prologue/epilogue functions.

2018-10-22 Thread Andrew Burgess
* Claudiu Zissulescu [2018-10-10 11:00:15 +0300]: > Reimplement how prologue and epilogue is emitted to accomodate > enter/leave instructions, as well as improving the size of the > existing techinques. > > The following modifications are added: > > - millicode thunk calls can be now selected r

Re: [PATCH 3/6] [ARC] Add BI/BIH instruction support.

2018-10-16 Thread Andrew Burgess
* Claudiu Zissulescu [2018-10-10 11:00:13 +0300]: > Use BI/BIH instruction to implement casesi pattern. Only ARC V2. This removes the compact-casesi as an option for earlier ARC, right? Was there a reason why that had to be done? > > gcc/ > 2018-03-21 Claudiu Zissulescu > > * config/

Re: [PATCH 1/6] [ARC] Remove non standard funcions calls.

2018-10-11 Thread Andrew Burgess
* Claudiu Zissulescu [2018-10-10 11:00:11 +0300]: > Replace all custom "library" calls with compiler known patterns. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.md (mulsi3): Remove call to mulsi_600_lib. > (mulsi3_600_lib): Remove pattern. > (umulsi3_highp

Re: [PATCH 2/6] [ARC] Cleanup TLS implementation.

2018-10-11 Thread Andrew Burgess
* Claudiu Zissulescu [2018-10-10 11:00:12 +0300]: > Cleanup TLS implementation and add a number of tests. > > gcc/ > 2018-07-25 Claudiu Zissulescu > > * config/arc/arc.c (arc_get_tp): Remove function. > (arc_emit_call_tls_get_addr): Likewise. > (arc_call_tls_get_addr): New

Re: [PATCH 2/2] [ARC] Avoid specific constants to end in limm field.

2018-09-20 Thread Andrew Burgess
* Claudiu Zissulescu [2018-09-17 15:50:27 +0300]: > The 3-operand instructions accepts to place an immediate into the > second operand. However, this immediate will end up in the long > immediate field. This patch avoids constants to end up in the limm > field for particular instructions when com

Re: [PATCH 1/2] [ARC] Check for odd-even register when emitting double mac ops.

2018-09-20 Thread Andrew Burgess
* Claudiu Zissulescu [2018-09-17 15:50:26 +0300]: > Avoid generate dmac instructions when the register is not odd-even, > use instead the equivalent mac instruction. > > gcc/ > Claudiu Zissulescu > > * config/arc/arc.md (maddsidi4_split): Don't use dmac if the > destination

Re: [PATCH] [ARC]: core3 features are default for core4

2018-09-11 Thread Andrew Burgess
* Vineet Gupta [2018-09-10 11:26:35 -0700]: >* config/arc/arc.c: object attributes for core4 not reflected correctly >* config/arc/arc.h: Don't restrict DBNZ to core3 (core4 includes core3) > > Signed-off-by: Vineet Gupta > --- > gcc/ChangeLog| 7 +++ > gcc/config/arc/arc.c

Re: [PATCH 1/4] [ARC] Add more additional register names

2018-07-25 Thread Andrew Burgess
All the patches in this series look fine. Thanks, Andrew * Claudiu Zissulescu [2018-07-16 15:29:42 +0300]: > From: claziss > > gcc/ > 2017-06-14 Claudiu Zissulescu > > * config/arc/arc.h (ADDITIONAL_REGISTER_NAMES): Add additional > register names. > --- > gcc/config/arc/arc

Re: [PATCH] [ARC] Add support for HS4x cpus.

2018-07-06 Thread Andrew Burgess
* Claudiu Zissulescu [2018-06-13 12:09:18 +0300]: > From: Claudiu Zissulescu > > This patch adds support for two ARCHS variations. > > Ok to apply? > Claudiu Sorry for the delay, this looks fine. Thanks, Andrew > > gcc/ > 2017-03-10 Claudiu Zissulescu > > * config/arc/arc-arch.

Re: [PATCH 6/6] [ARC] Reimplement return padding operation for ARC700.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:39 +0300]: > From: Claudiu Zissulescu > > For ARC700, adding padding if necessary to avoid a mispredict. A > return could happen immediately after the function start. A > call/return and return/return must be 6 bytes apart to avoid > mispredict. > > The

Re: [PATCH 5/6] [ARC] Update fma expansions.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:38 +0300]: > Make sure only one operand has an immediate. > > OK to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2018-03-21 Claudiu Zissulescu > > * config/arc/fpu.md (fmasf4): Force operand to register. > (fnmasf4): Likewise.

Re: [PATCH 1/6] [ARC] Add modes scheduler HS

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:34 +0300]: > From: Claudiu Zissulescu > > An update on how the instructions are scheduled for HS processor. > > Ok to apply? Looks good. Thanks, Andrew > Claudiu > > --- > gcc/config/arc/arcHS.md | 21 +++-- > 1 file changed, 15 inse

Re: [PATCH 2/6] [ARC] Allow EX instruction for ARC700 and ARCv2.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:35 +0300]: > From: claziss > > The EX instruction is base line for both architectures. Reflect this in the > compiler. > > OK to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2017-05-02 Claudiu Zissulescu > > * config/arc/arc.c (a

Re: [PATCH 4/6] [ARC] Define LINK_GCC_C_SEQUENCE_SPEC.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:37 +0300]: > From: claziss > > If no specs file is provided, default to nosys library. > > Ok to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2017-05-03 Claudiu Zissulescu > > * config/arc/elf.h (LINK_GCC_C_SEQUENCE_SPEC): Define.

Re: [PATCH 3/6] [ARC] SYNC instruction is valid on all ARC cores.

2018-06-12 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:18:36 +0300]: > From: claziss > > The sync instruction is part of all ARC architectures. Fix this in the > compiler. > > Ok to apply? Looks good. Thanks, Andrew > Claudiu > > gcc/ > 2017-05-03 Claudiu Zissulescu > > * config/arc/builtins.def

Re: [PATCH 2/2] [ARC] Update warning messges.

2018-06-04 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:20:29 +0300]: > From: claziss > > When we pass an mcpu to the compiler we have two types of (hardware > configuration) flags that are set: > > 1. Architecture specific, for example code-density is always enabled > for ARCHS architectures. These options are o

Re: [PATCH 1/2] [ARC][QuarkSE] Update

2018-06-04 Thread Andrew Burgess
* Claudiu Zissulescu [2018-05-21 13:20:28 +0300]: > From: claziss > > QuarkSE has lp_count width set to 16 bits. Update the compiler to > consider it. > > Ok to apply? > Claudiu > > gcc/ > 2017-07-11 Claudiu Zissulescu > > * config/arc/arc-arch.h (arc_extras): New enum. > (arc

Re: [PATCH] ARC: Add multilib support for linux targets

2018-05-16 Thread Andrew Burgess
* Alexey Brodkin [2018-05-16 22:42:36 +0300]: > We used to build baremetal (AKA Elf32) multilibbed toolchains for years > now but never made that for Linux targets since there were problems with > uClibc n multilib setup. Now with help of Crosstool-NG it is finally > possible to create uClibc-bas

Re: [PATCH 5/5] [ARC] Clear the instruction cache using syscalls.

2018-04-27 Thread Andrew Burgess
* Claudiu Zissulescu [2018-04-06 11:00:14 +0200]: > Clear the instruction cache from `beg' to `end'. This makes an inline > system call to SYS_cacheflush. > > gcc/ > 2017-03-28 Claudiu Zissulescu > > * config/arc/linux.h (CLEAR_INSN_CACHE): Define. Looks good. Thanks, Andrew > --

Re: [PATCH 4/5] [ARC] Cleanup sdata handling.

2018-04-27 Thread Andrew Burgess
* Claudiu Zissulescu [2018-04-06 11:00:13 +0200]: > From: Claudiu Zissulescu > > Clean up how we handle small data load/store operations. This patch clears > -flto-fat-lto-object LTO related errors. > > gcc/ > 2018-01-18 Claudiu Zissulescu > > * config/arc/arc-protos.h (prepare_ext

Re: [PATCH 3/5] [ARC] Update movhi and movdi patterns.

2018-04-27 Thread Andrew Burgess
* Claudiu Zissulescu [2018-04-06 11:00:12 +0200]: > From: Claudiu Zissulescu > > Allow signed 6-bit short immediates into st[d] instructions. > > 2017-10-19 Claudiu Zissulescu > > * config/arc/arc.c (arc_split_move): Allow signed 6-bit constants > as source of std instructions

Re: [PATCH 2/5] [ARC] Fix FLS, SETI patterns.

2018-04-18 Thread Andrew Burgess
* Claudiu Zissulescu [2018-04-06 11:00:11 +0200]: > From: claziss > > Claudiu Zissulescu > > * config/arc/arc.md ("vunspec"): Delete it, unify all the unspec > enums into a single definition. > (fls): Fix predicates and printing. > (seti): Likewise. Looks good, Tha

Re: [PATCH 1/5] [ARC] Update sleep builtin.

2018-04-18 Thread Andrew Burgess
* Claudiu Zissulescu [2018-04-06 11:00:10 +0200]: > From: claziss > > gcc/ > 2017-05-09 Claudiu Zissulescu > > * config/arc/arc-protos.h (check_if_valid_sleep_operand): Remove. > * config/arc/arc.c (arc_expand_builtin): Sleep accepts registers > and short u6 immediate. >

Re: [PATCH] [ARC] Add/update combiner patterns.

2018-04-07 Thread Andrew Burgess
* Claudiu Zissulescu [2018-03-07 13:59:03 +0200]: > From: claziss > > Hi Andrew, > > Please find the following patch which improves generating more instructions > with .f flag (i.e., compare with zero). > > Ok to apply? Looks good. Thanks. Andrew > Claudiu > > gcc/ > 2018-01-26 Claudiu

Re: [PATCH] [ARC] Cleanup unused functions.

2018-03-05 Thread Andrew Burgess
* Claudiu Zissulescu [2018-02-20 15:38:32 +0200]: > From: Claudiu Zissulescu > > Cleanup unsed functions and macros. > > OK to apply? > Claudiu Looks good. Nice cleanup. Thanks, Andrew > > gcc/ > 2018-01-26 Claudiu Zissulescu > > * config/arc/arc.c (arc_finalize_pic): Remove fu

Re: [PATCH 6/6] [ARC] Add 'aux' variable attribute.

2018-01-29 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-02 13:30:35 +0100]: > From: claziss > > The 'aux' variable attribute is used to directly access the auxiliary > register space from C. > > gcc/ > 2017-07-25 Claudiu Zissulescu > > * config/arc/arc.c (arc_handle_aux_attribute): New function. > (arc

Re: [PATCH 5/6] [ARC] Add 'uncached' attribute.

2018-01-29 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-02 13:30:34 +0100]: > From: claziss > > The _Uncached type qualifier can be used to bypass the cache without > resorting to declaring variables as volatile. > > gcc/ > 2017-07-12 Claudiu Zissulescu > > * config/arc/arc-protos.h (arc_is_uncached_mem_p):

Re: [PATCH 4/6] [ARC] Rework delegitimate_address hook

2018-01-23 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-02 13:30:33 +0100]: > From: claziss > > Delegitimize address is used to undo the obfuscating effect of PIC > addresses, returning the address in a way which is understood by the > compiler. > > gcc/ > 2017-04-25 Claudiu Zissulescu > > * config/arc/arc.c

Re: [PATCH 3/6] [ARC] Add support for "register file 16" reduced register set

2018-01-16 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-02 13:30:32 +0100]: > gcc/ > 2017-03-20 Claudiu Zissulescu > > * config/arc/arc-arches.def: Option mrf16 valid for all > architectures. > * config/arc/arc-c.def (__ARC_RF16__): New predefined macro. > * config/arc/arc-cpus.def (em_mini):

Re: [PATCH 2/6] [ARC] Add SJLI support.

2018-01-16 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-02 13:30:31 +0100]: > gcc/ > 2017-02-20 Claudiu Zissulescu > > * config/arc/arc-protos.h: Add arc_is_secure_call_p proto. > * config/arc/arc.c (arc_handle_secure_attribute): New function. > (arc_attribute_table): Add 'secure_call' attribute. >

Re: [PATCH 1/6] [ARC] Add JLI support.

2018-01-16 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-02 13:30:30 +0100]: > The ARCv2 ISA provides the JLI instruction, which is two-byte instructions > that can be used to reduce code size in an application. To make use of it, > we provide two new function attributes 'jli_always' and 'jli_fixed' which > will force the

Re: [PATCH 00/10][ARC] Critical fixes

2018-01-16 Thread Andrew Burgess
* Claudiu Zissulescu [2018-01-08 15:18:30 +]: > > [ARC][LRA] Use TARGET_CANNOT_SUBSTITUTE_MEM_EQUIV. > > [ARC] Don't allow the last ZOL insn to be in a delay slot. > > [ARC] Add trap instruction. > > [ARC] Update legitimate constant hook. > > [ARC] Enable unaligned access. > > [A

Re: [PATCH 10/10] [ARC] Revamp trampoline implementation.

2018-01-02 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-27 12:09:59 +0100]: > From: Claudiu Zissulescu > > The new implementation attempts to clean up the existing trampoline > implementation for ARC making it to work for linux type of systems. > > gcc/ > 2017-11-10 Claudiu Zissulescu > > * config/arc/arc.c

Re: [PATCH 08/10] [ARC] Enable unaligned access.

2018-01-02 Thread Andrew Burgess
* Claudiu Zissulescu [2017-11-27 12:09:57 +0100]: > From: Claudiu Zissulescu > > Use munaligned-access to control if we can have unaligned accesses. For ARC > HS family unaligned access is always on. > > 2017-10-19 Claudiu Zissulescu > > * config/arc/arc-c.def (__ARC_UNALIGNED__):

  1   2   3   >