Re: [PATCH v2] c: Silently ignore pragma region [PR85487]

2020-11-13 Thread Austin Morton via Gcc-patches
> How much does this pragma get used "in the wild"? A quick search on github for "#pragma region" comes back with 170k C++ results and searching for "#pragma" comes back with 38M C++ results Possibly not the best metric, but we can "conclude" roughly 0.45% of open source C++ code files on github

Re: [PATCH v2] c: Silently ignore pragma region [PR85487]

2020-11-13 Thread Austin Morton via Gcc-patches
> But in that case the pragma shouldn't be ignored, but instead checked > against the various requirements. E.g. that region is followed by a single > optional name (are there any requirements on what name can be, can it be > just a single token, can it be C/C++ keyword, etc.), guess ignore all

Re: [PATCH v2] c: Silently ignore pragma region [PR85487]

2020-11-13 Thread Austin Morton via Gcc-patches
without any runtime configuration, and I think GCC should as well. Austin On Thu, Nov 12, 2020 at 11:25 PM Jeff Law wrote: > > > On 9/2/20 6:59 PM, Austin Morton via Gcc-patches wrote: > > #pragma region is a feature introduced by Microsoft in order to allow > > manual g

[PATCH v2] c: Silently ignore pragma region [PR85487]

2020-09-02 Thread Austin Morton via Gcc-patches
#pragma region is a feature introduced by Microsoft in order to allow manual grouping and folding of code within Visual Studio. It is entirely ignored by the compiler. Clang has supported this feature since 2012 when in MSVC compatibility mode, and enabled it across the board in 2018. As it

Re: [PATCH] c: Silently ignore pragma region [PR85487]

2020-08-28 Thread Austin Morton via Gcc-patches
> The patch misses documentation of the pragma. This was an intentional omission - when looking for documentation of the pragma in clang I found none. If we do want to document the pragmas in GCC: - what section of the documentation would that go in? - gcc/doc/cpp.texi, section 7, "Pragmas"

[PATCH] c: Silently ignore pragma region [PR85487]

2020-08-27 Thread Austin Morton via Gcc-patches
#pragma region is a feature introduced by Microsoft in order to allow manual grouping and folding of code within Visual Studio. It is entirely ignored by the compiler. Clang has supported this feature since 2012 when in MSVC compatibility mode, and enabled it across the board 3 months ago. As